Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-19 Thread Weinan Liu
On Tue, Mar 18, 2025 at 10:39 PM Josh Poimboeuf wrote: > > On Tue, Mar 18, 2025 at 08:58:52PM -0700, Song Liu wrote: > > On a closer look, I think we also need some logic in unwind_find_stack() > > so that we can see when the unwinder hits the exception boundary. For > > this reason, we may still

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Christoph Hellwig
On Wed, Mar 19, 2025 at 10:45:22AM -0700, Joe Damato wrote: > I don't disagree; I just don't know if app developers: > a.) know that this is possible to do, and > b.) know how to do it So if you don't know that why do you even do the work? > In general: it does seem a bit odd to me that there

[PATCH v6 2/5] arm64: dts: imx8mp: Add mu2 root clock

2025-03-19 Thread Daniel Baluta
Enable MU2 node and add mu2 root clock. MU2 is used to communicate with DSP core. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 4 arch/arm64/boot/dts/freescale/imx8mp.dtsi| 1 + 2 files changed, 5 ins

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Christoph Hellwig
On Wed, Mar 19, 2025 at 08:32:19AM -0700, Joe Damato wrote: > See the docs on MSG_ZEROCOPY [1], but in short when a user app calls > sendmsg and passes MSG_ZEROCOPY a completion notification is added > to the error queue. The user app can poll for these to find out when > the TX has completed and t

[PATCH] libnvdimm/labels: Fix divide error in nd_label_data_init()

2025-03-19 Thread Robert Richter
If a CXL memory device returns a broken zero LSA size in its memory device information (Identify Memory Device (Opcode 4000h), CXL spec. 3.1, 8.2.9.9.1.1), a divide error occurs in the libnvdimm driver: Oops: divide error: [#1] PREEMPT SMP NOPTI RIP: 0010:nd_label_data_init+0x10e/0x800 [lib

[PATCH v6 4/5] arm64: dts: imx8mp: Add DSP clocks

2025-03-19 Thread Daniel Baluta
DSP core needs ocram, core and debug clocks. Reviewed-by: Iuliana Prodan Reviewed-by: Peng Fan Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/fr

Re: [PATCH 5/5] rcu/exp: Warn on CPU lagging for too long within hotplug IPI's blindspot

2025-03-19 Thread Frederic Weisbecker
Le Tue, Mar 18, 2025 at 10:22:33AM -0700, Paul E. McKenney a écrit : > On Fri, Mar 14, 2025 at 03:36:42PM +0100, Frederic Weisbecker wrote: > > A CPU within hotplug operations can make the RCU exp kworker lagging if: > > > > * The dying CPU is running after CPUHP_TEARDOWN_CPU but before > > rcut

Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

2025-03-19 Thread AngeloGioacchino Del Regno
Il 18/03/25 23:22, Nícolas F. R. A. Prado ha scritto: The SCP present on MT8188 does not have an L1TCM memory region, but the binding incorrectly requires one for the dual-core description of the MT8188 SCP. Remove that requirement. Also update the minimum number of reg and reg-names to 1, since

Re: [PATCH 4/4] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0

2025-03-19 Thread AngeloGioacchino Del Regno
Il 18/03/25 23:22, Nícolas F. R. A. Prado ha scritto: Add the firmware-name property for SCP core0 so the firmware can be loaded from its canonical location in the linux-firmware repository. Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH 1/5] rcu/exp: Protect against early QS report

2025-03-19 Thread Frederic Weisbecker
Le Tue, Mar 18, 2025 at 10:17:16AM -0700, Paul E. McKenney a écrit : > On Fri, Mar 14, 2025 at 03:36:38PM +0100, Frederic Weisbecker wrote: > > When a grace period is started, the ->expmask of each node is set up > > from sync_exp_reset_tree(). Then later on each leaf node also initialize > > its -

Re: [PATCH 2/5] rcu/exp: Remove confusing needless full barrier on task unblock

2025-03-19 Thread Frederic Weisbecker
Le Tue, Mar 18, 2025 at 10:18:12AM -0700, Paul E. McKenney a écrit : > On Fri, Mar 14, 2025 at 03:36:39PM +0100, Frederic Weisbecker wrote: > > A full memory barrier in the RCU-PREEMPT task unblock path advertizes > > to order the context switch (or rather the accesses prior to > > rcu_read_unlock(

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Amit Shah
On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner wrote: > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > wrote: > > > According to the virtio spec[0] the virtio console resize struct > > > defines > > > co

Re: [PATCH net-next 0/4] virtio_net: Fixes and improvements

2025-03-19 Thread Michael S. Tsirkin
On Tue, Mar 18, 2025 at 06:56:50PM +0900, Akihiko Odaki wrote: > Jason Wang recently proposed an improvement to struct > virtio_net_rss_config: > https://lore.kernel.org/r/CACGkMEud0Ki8p=z299q7b4qedonpydzbvqhhxcnvk_vo-kd...@mail.gmail.com > > This patch series implements it and also fixes a few mi

Re: [PATCH v2] remoteproc: imx_dsp_rproc: Add support for DSP-specific features

2025-03-19 Thread Daniel Baluta
On Tue, Mar 18, 2025 at 11:50 PM Iuliana Prodan (OSS) wrote: > > From: Iuliana Prodan > > Some DSP firmware requires a FW_READY signal before proceeding, while > others do not. > Therefore, add support to handle i.MX DSP-specific features. > > Implement handle_rsc callback to handle resource tabl

Re: [PATCH 4/5] rcu/exp: Warn on QS requested on dying CPU

2025-03-19 Thread Frederic Weisbecker
Le Tue, Mar 18, 2025 at 10:21:48AM -0700, Paul E. McKenney a écrit : > On Fri, Mar 14, 2025 at 03:36:41PM +0100, Frederic Weisbecker wrote: > > It is not possible to send an IPI to a dying CPU that has passed the > > CPUHP_TEARDOWN_CPU stage. Remaining unhandled IPIs are handled later at > > CPUHP_

Re: [PATCH net v4 2/3] selftest/bpf: Add test for AF_VSOCK connect() racing sockmap update

2025-03-19 Thread Stefano Garzarella
On Mon, Mar 17, 2025 at 10:52:24AM +0100, Michal Luczaj wrote: Racing signal-interrupted connect() and sockmap update may result in an unconnected (and missing vsock transport) socket in a sockmap. Test spends 2 seconds attempting to reach WARN_ON_ONCE(). connect / state = SS_CONNECTED /

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Amit Shah
On Wed, 2025-03-19 at 09:54 +0100, Maximilian Immanuel Brandtner wrote: > On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 at 10:21

Re: [PATCH net v4 0/3] vsock/bpf: Handle races between sockmap update and connect() disconnecting

2025-03-19 Thread Michael S. Tsirkin
On Mon, Mar 17, 2025 at 10:52:22AM +0100, Michal Luczaj wrote: > Signal delivery during connect() may disconnect an already established > socket. Problem is that such socket might have been placed in a sockmap > before the connection was closed. > > PATCH 1 ensures this race won't lead to an uncon

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Christoph Hellwig
On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: > One way to fix this is to add zerocopy notifications to sendfile similar > to how MSG_ZEROCOPY works with sendmsg. This is possible thanks to the > extensive work done by Pavel [1]. What is a "zerocopy notification" and why aren't you s

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Maximilian Immanuel Brandtner
On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > wrote: > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > On Tue, 2025-02-25 at 10:21 +0100, Maximilian Immanuel Brandtner > > > wrote: > > > > According to the virtio

[PATCH] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-19 Thread Peng Fan (OSS)
From: Peng Fan There is case as below could trigger kernel dump: Use U-Boot to start remote processor(rproc) with resource table published to a fixed address by rproc. After Kernel boots up, stop the rproc, load a new firmware which doesn't have resource table ,and start rproc. When starting rpr

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
On 3/19/25 9:32 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: >> On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: >>> One way to fix this is to add zerocopy notifications to sendfile similar >>> to how MSG_ZEROCOPY works with sendmsg. This is

Re: [PATCHv4 RESEND net-next 0/2] selftests: wireguards: use nftables for testing

2025-03-19 Thread Jason A. Donenfeld
On Tue, Mar 18, 2025 at 10:24:40AM +, Hangbin Liu wrote: > I saw the patch status[1] is still "Awaiting Upstream". > Is there anything I need to do? I'm looking at it now, but the subject line of your series says, "selftests: wireguards: " which is really not the same as all the other patches

Re: [PATCHv4 RESEND net-next 2/2] selftests: wireguard: update to using nft for qemu test

2025-03-19 Thread Jason A. Donenfeld
On Mon, Jan 06, 2025 at 08:10:43AM +, Hangbin Liu wrote: > + echo "file /bin/nft $(NFTABLES_PATH)/src/nft 755 0 0" >> $@ > + echo "file /lib/libmnl.so.0 $(TOOLCHAIN_PATH)/lib/libmnl.so.0 755 0 0" > >> $@ > + echo "file /lib/libnftnl.so.11 $(TOOLCHAIN_PATH)/lib/libnftnl.so.11 755 >

Re: [PATCHv4 RESEND net-next 1/2] selftests: wireguards: convert iptables to nft

2025-03-19 Thread Jason A. Donenfeld
On Mon, Jan 06, 2025 at 08:10:42AM +, Hangbin Liu wrote: > +n0 nft add rule ip wgtest INPUT meta length 1360 counter drop What's the point of `counter` here? It's never read back. > +n0 nft add rule ip wgtest POSTROUTING ip saddr 192.168.1.0/24 ip daddr > 10.0.0.0/24 counter snat to 10.0.0.1

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Joe Damato
On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: > On 3/19/25 11:04 AM, Joe Damato wrote: > > On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: > >> On 3/19/25 9:32 AM, Joe Damato wrote: > >>> On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: > On Wed, Mar

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
On 3/19/25 11:04 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: >> On 3/19/25 9:32 AM, Joe Damato wrote: >>> On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: > One way to fix

Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status()

2025-03-19 Thread Dongli Zhang
Hi Jason, On 3/17/25 5:48 PM, Jason Wang wrote: > On Tue, Mar 18, 2025 at 7:52 AM Dongli Zhang wrote: >> >> Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was >> signaled by the commit 664ed90e621c ("vhost/scsi: Set >> VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 feature bits"), >>

Re: [PATCH] remoteproc: core: Clear table_sz when rproc_shutdown

2025-03-19 Thread Arnaud POULIQUEN
Hello Peng, On 3/19/25 11:01, Peng Fan (OSS) wrote: > From: Peng Fan > > There is case as below could trigger kernel dump: > Use U-Boot to start remote processor(rproc) with resource table > published to a fixed address by rproc. After Kernel boots up, > stop the rproc, load a new firmware whic

Re: [PATCH bpf-next 11/11] bpf: Fall back to nospec for spec path verification

2025-03-19 Thread Luis Gerhorst
Alexei Starovoitov writes: > On Thu, Mar 13, 2025 at 10:57 AM Luis Gerhorst wrote: >> With increased limits this allows applying mitigations to large BPF >> progs such as the Parca Continuous Profiler's prog. However, this >> requires a jump-seq limit of 256k. In any case, the same principle >>

Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

2025-03-19 Thread Konstantin Ryabitsev
On Wed, Mar 19, 2025 at 03:26:27AM +, Dmitry Safonov wrote: > However, as I sent the patches with b4 relay, it seems patchwork is > unable to authorise me as the author of the series. Ugh :( Oops. We should definitely properly handle this. Sending a note to self via the helpdesk. -K

Re: [PATCH v2 04/10] vhost: modify vhost_log_write() for broader users

2025-03-19 Thread Dongli Zhang
Hi Jason, On 3/17/25 6:12 PM, Jason Wang wrote: > On Tue, Mar 18, 2025 at 7:51 AM Dongli Zhang wrote: >> >> Currently, the only user of vhost_log_write() is vhost-net. The 'len' >> argument prevents logging of pages that are not tainted by the RX path. >> >> Adjustments are needed since more driv

Re: [PATCH net v4 3/3] vsock/bpf: Fix bpf recvmsg() racing transport reassignment

2025-03-19 Thread Michal Luczaj
On 3/19/25 10:34, Stefano Garzarella wrote: > On Mon, Mar 17, 2025 at 10:52:25AM +0100, Michal Luczaj wrote: >> ... >> -static int vsock_bpf_recvmsg(struct sock *sk, struct msghdr *msg, >> - size_t len, int flags, int *addr_len) >> +static int vsock_bpf_recvmsg(struct sock *

Re: [PATCH 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-19 Thread Song Liu
On Wed, Mar 19, 2025 at 11:38 AM Weinan Liu wrote: > > On Tue, Mar 18, 2025 at 10:39 PM Josh Poimboeuf wrote: > > > > On Tue, Mar 18, 2025 at 08:58:52PM -0700, Song Liu wrote: > > > On a closer look, I think we also need some logic in unwind_find_stack() > > > so that we can see when the unwinder

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Joe Damato
On Wed, Mar 19, 2025 at 12:37:29PM -0600, Jens Axboe wrote: > On 3/19/25 11:45 AM, Joe Damato wrote: > > On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: > >> On 3/19/25 11:04 AM, Joe Damato wrote: > >>> On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: > On 3/19/25 9:32 A

Re: [PATCH 1/2] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-03-19 Thread Joel Fernandes
On Tue, Mar 18, 2025 at 11:37:38AM -0700, Paul E. McKenney wrote: > On Tue, Mar 18, 2025 at 02:56:18PM +0100, Frederic Weisbecker wrote: > > The numbers used in rcu_seq_done_exact() lack some explanation behind > > their magic. Especially after the commit: > > > > 85aad7cc4178 ("rcu: Fix get_s

Re: [PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195

2025-03-19 Thread Nícolas F . R . A . Prado
On Wed, Mar 19, 2025 at 08:16:37AM +0100, Krzysztof Kozlowski wrote: > On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote: > > Both MT8192 and MT8195 have an L1TCM memory, so it should be described > > in reg, and therefore reg's minItems should be 3, as is already implicit > > by reg-names. Overrid

Re: [PATCH net v4 3/3] vsock/bpf: Fix bpf recvmsg() racing transport reassignment

2025-03-19 Thread Stefano Garzarella
On Mon, Mar 17, 2025 at 10:52:25AM +0100, Michal Luczaj wrote: Signal delivery during connect() may lead to a disconnect of an already established socket. That involves removing socket from any sockmap and resetting state to SS_UNCONNECTED. While it correctly restores socket's proto, a call to vs

Re: [Linux-stm32] [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-19 Thread Arnaud POULIQUEN
Hello Rob, On 3/18/25 00:24, Rob Herring (Arm) wrote: > Use the newly added of_reserved_mem_region_to_resource() and > of_reserved_mem_region_count() functions to handle "memory-region" > properties. > > The error handling is a bit different in some cases. Often > "memory-region" is optional, so

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Halil Pasic
On Wed, 19 Mar 2025 11:00:06 -0400 "Michael S. Tsirkin" wrote: > > > I was mistaken in my earlier reply - I had missed this > > > virtio_console_resize definition in the spec.  So indeed there's a > > > discrepancy in Linux kernel and the spec's ordering for the control > > > message. > > > > >

Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

2025-03-19 Thread Krzysztof Kozlowski
On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote: > The SCP present on MT8188 does not have an L1TCM memory region, but the > binding incorrectly requires one for the dual-core description of the > MT8188 SCP. Remove that requirement. Also update the minimum number of > reg and reg-names to 1, sin

Re: [PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195

2025-03-19 Thread Krzysztof Kozlowski
On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote: > Both MT8192 and MT8195 have an L1TCM memory, so it should be described > in reg, and therefore reg's minItems should be 3, as is already implicit > by reg-names. Override minItems to 3 for MT8192 and MT8195. I think that was the original intenti

[PATCH v6 1/5] arm64: dts: imx8mp: Use resets property

2025-03-19 Thread Daniel Baluta
Add resets property to dsp node in order to be able to control the dsp run/stall bit from audio block control. Reviewed-by: Peng Fan Reviewed-by: Frank Li Signed-off-by: Daniel Baluta --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm6

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Joe Damato
On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: > On 3/19/25 9:32 AM, Joe Damato wrote: > > On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: > >> On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: > >>> One way to fix this is to add zerocopy notifications to s

Re: [Linux-stm32] [PATCH 3/3] remoteproc: Use of_reserved_mem_region_* functions for "memory-region"

2025-03-19 Thread Rob Herring
On Wed, Mar 19, 2025 at 10:26 AM Arnaud POULIQUEN wrote: > > Hello Rob, > > On 3/18/25 00:24, Rob Herring (Arm) wrote: > > Use the newly added of_reserved_mem_region_to_resource() and > > of_reserved_mem_region_count() functions to handle "memory-region" > > properties. > > > > The error handling

Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

2025-03-19 Thread 何宗原
On Wed, 2025-03-19 at 10:34 +0100, AngeloGioacchino Del Regno wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 18/03/25 23:22, Nícolas F. R. A. Prado ha scritto: > > The SCP present on MT8188 does not have an

Re: [PATCH v2 04/10] vhost: modify vhost_log_write() for broader users

2025-03-19 Thread Jason Wang
On Thu, Mar 20, 2025 at 12:38 AM Dongli Zhang wrote: > > Hi Jason, > > On 3/17/25 6:12 PM, Jason Wang wrote: > > On Tue, Mar 18, 2025 at 7:51 AM Dongli Zhang > > wrote: > >> > >> Currently, the only user of vhost_log_write() is vhost-net. The 'len' > >> argument prevents logging of pages that ar

Re: [PATCH v2 03/10] vhost-scsi: Fix vhost_scsi_send_status()

2025-03-19 Thread Jason Wang
On Thu, Mar 20, 2025 at 1:54 AM Dongli Zhang wrote: > > Hi Jason, > > On 3/17/25 5:48 PM, Jason Wang wrote: > > On Tue, Mar 18, 2025 at 7:52 AM Dongli Zhang > > wrote: > >> > >> Although the support of VIRTIO_F_ANY_LAYOUT + VIRTIO_F_VERSION_1 was > >> signaled by the commit 664ed90e621c ("vhost/

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Joe Damato
On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: > On 3/19/25 9:32 AM, Joe Damato wrote: > > On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: > >> On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: > >>> One way to fix this is to add zerocopy notifications to s

Re: [PATCH v3 1/2] kunit: tool: Fix bug in parsing test plan

2025-03-19 Thread Rae Moar
On Mon, Mar 17, 2025 at 12:13 PM Brendan Jackman wrote: > > On Fri, 14 Mar 2025 at 06:37, David Gow wrote: > > > > On Fri, 14 Mar 2025 at 03:27, Rae Moar wrote: > > > > > > A bug was identified where the KTAP below caused an infinite loop: > > > > > > TAP version 13 > > > ok 4 test_case > > >

[PATCH] kunit: tool: fix count of tests if late test plan

2025-03-19 Thread Rae Moar
Fix test count with late test plan. For example, TAP version 13 ok 1 test1 1..4 Returns a count of 1 passed, 1 crashed (because it expects tests after the test plan): returning the total count of 2 tests Change this to be 1 passed, 1 error: total count of 1 test Signed-off-by: Rae Moar -

[PATCH v2 0/2] arm64: livepatch: Enable livepatch without sframe

2025-03-19 Thread Song Liu
There are recent efforts to enable livepatch for arm64, with sframe [1] or without sframe [2]. This set tries to enable livepatch without sframe. Some of the code, however, are from [1]. Although the sframe implementation is more promising in longer term, it suffers from the following issues: 1

[PATCH v2 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-19 Thread Song Liu
With proper exception boundary detection, it is possible to implment arch_stack_walk_reliable without sframe. Note that, arch_stack_walk_reliable does not guarantee getting reliable stack in all scenarios. Instead, it can reliably detect when the stack trace is not reliable, which is enough to pro

Re: [PATCH bpf-next v3 1/3] bpf, sockmap: avoid using sk_socket after free when sending

2025-03-19 Thread Cong Wang
On Mon, Mar 17, 2025 at 05:22:54PM +0800, Jiayuan Chen wrote: > The sk->sk_socket is not locked or referenced, and during the call to Hm? We should have a reference in socket map, whether directly or indirectly, right? When we add a socket to a socket map, we do call sock_map_psock_get_checked() t

Re: [PATCH bpf-next 0/2] selftests/bpf: Migrate test_xdp_vlan.sh into test_progs

2025-03-19 Thread Martin KaFai Lau
On 3/18/25 3:25 AM, Bastien Curutchet wrote: Hi all, On 2/24/25 5:10 PM, Stanislav Fomichev wrote: On 02/21, Bastien Curutchet (eBPF Foundation) wrote: Hi all, This patch series continues the work to migrate the script tests into prog_tests. test_xdp_vlan.sh tests the ability of an XDP progr

[PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-19 Thread Nico Pache
FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download") Signed-of

[PATCH v2 2/2] arm64: Implement HAVE_LIVEPATCH

2025-03-19 Thread Song Liu
This is largely based on [1] by Suraj Jitindar Singh. Test coverage: - Passed manual tests with samples/livepatch. - Passed all but test-kprobe.sh in selftests/livepatch. test-kprobe.sh is expected to fail, because arm64 doesn't have KPROBES_ON_FTRACE. - Passed tests with kpatch-build [2]. (T

Re: [PATCH v2 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-19 Thread Josh Poimboeuf
On Wed, Mar 19, 2025 at 02:37:06PM -0700, Song Liu wrote: > +noinline noinstr int arch_stack_walk_reliable(stack_trace_consume_fn > consume_entry, > + void *cookie, struct task_struct *task) > +{ > + struct kunwind_consume_entry_data data = { > + .consume_entry

Re: [PATCH bpf-next v3 1/3] bpf, sockmap: avoid using sk_socket after free when sending

2025-03-19 Thread Cong Wang
On Wed, Mar 19, 2025 at 11:36:13PM +, Jiayuan Chen wrote: > 2025/3/20 07:02, "Cong Wang" wrote: > > > > > On Mon, Mar 17, 2025 at 05:22:54PM +0800, Jiayuan Chen wrote: > > > > > > > > The sk->sk_socket is not locked or referenced, and during the call to > > > > > > > Hm? We should have a

Re: [PATCH] kunit: cs_dsp: Depend on FW_CS_DSP rather then enabling it

2025-03-19 Thread Nico Pache
On Wed, Mar 19, 2025 at 5:05 PM Nico Pache wrote: > > FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather > depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the > depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling. A further note here: This test

Re: [PATCH net-next 3/4] virtio_net: Use new RSS config structs

2025-03-19 Thread Jason Wang
On Wed, Mar 19, 2025 at 12:48 PM Akihiko Odaki wrote: > > On 2025/03/19 10:43, Jason Wang wrote: > > On Tue, Mar 18, 2025 at 5:57 PM Akihiko Odaki > > wrote: > >> > >> The new RSS configuration structures allow easily constructing data for > >> VIRTIO_NET_CTRL_MQ_RSS_CONFIG as they strictly foll

[PATCH v5 08/17] rust: kunit: refactor to use `&raw [const|mut]`

2025-03-19 Thread Antonio Hickey
Replacing all occurrences of `addr_of!(place)` with `&raw const place`. This will allow us to reduce macro complexity, and improve consistency with existing reference syntax as `&raw const` is similar to `&` making it fit more naturally with other existing code. Suggested-by: Benno Lossin Link:

Re: [PATCH v2 1/2] arm64: Implement arch_stack_walk_reliable

2025-03-19 Thread Song Liu
On Wed, Mar 19, 2025 at 3:35 PM Josh Poimboeuf wrote: > > On Wed, Mar 19, 2025 at 02:37:06PM -0700, Song Liu wrote: > > +noinline noinstr int arch_stack_walk_reliable(stack_trace_consume_fn > > consume_entry, > > + void *cookie, struct task_struct *task) > > +{ > > + struc

Re: [PATCH] libnvdimm/labels: Fix divide error in nd_label_data_init()

2025-03-19 Thread Gupta, Pankaj
On 3/19/2025 12:32 PM, Robert Richter wrote: If a CXL memory device returns a broken zero LSA size in its memory device information (Identify Memory Device (Opcode 4000h), CXL spec. 3.1, 8.2.9.9.1.1), a divide error occurs in the libnvdimm driver: Oops: divide error: [#1] PREEMPT SMP NOPT

Re: [PATCH 2/5] rcu/exp: Remove confusing needless full barrier on task unblock

2025-03-19 Thread Paul E. McKenney
On Wed, Mar 19, 2025 at 10:01:36AM +0100, Frederic Weisbecker wrote: > Le Tue, Mar 18, 2025 at 10:18:12AM -0700, Paul E. McKenney a écrit : > > On Fri, Mar 14, 2025 at 03:36:39PM +0100, Frederic Weisbecker wrote: > > > A full memory barrier in the RCU-PREEMPT task unblock path advertizes > > > to o

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Joe Damato
On Wed, Mar 19, 2025 at 01:04:48AM -0700, Christoph Hellwig wrote: > On Wed, Mar 19, 2025 at 12:15:11AM +, Joe Damato wrote: > > One way to fix this is to add zerocopy notifications to sendfile similar > > to how MSG_ZEROCOPY works with sendmsg. This is possible thanks to the > > extensive work

Re: [RFC -next 00/10] Add ZC notifications to splice and sendfile

2025-03-19 Thread Jens Axboe
On 3/19/25 11:45 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 11:20:50AM -0600, Jens Axboe wrote: >> On 3/19/25 11:04 AM, Joe Damato wrote: >>> On Wed, Mar 19, 2025 at 10:07:27AM -0600, Jens Axboe wrote: On 3/19/25 9:32 AM, Joe Damato wrote: > On Wed, Mar 19, 2025 at 01:04:48AM -0700, C

Re: [PATCH] virtio: console: Make resizing compliant with virtio spec

2025-03-19 Thread Michael S. Tsirkin
On Wed, Mar 19, 2025 at 02:00:44PM +0100, Maximilian Immanuel Brandtner wrote: > On Tue, 2025-03-18 at 15:25 +0100, Amit Shah wrote: > > On Tue, 2025-03-18 at 11:07 +0100, Maximilian Immanuel Brandtner > > wrote: > > > On Mon, 2025-03-03 at 12:54 +0100, Amit Shah wrote: > > > > On Tue, 2025-02-25 a