On Wed, Mar 19, 2025 at 5:05 PM Nico Pache <npa...@redhat.com> wrote:
>
> FW_CS_DSP gets enabled if KUNIT is enabled. The test should rather
> depend on if the feature is enabled. Fix this by moving FW_CS_DSP to the
> depends on clause, and set CONFIG_FW_CS_DSP=y in the kunit tooling.
A further note here:
This test is failing and panicing across multiple arches, and
triggering kasan slats on debug kernels. I think this test needs more
testing ;P
>
> Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file
> download")
> Signed-off-by: Nico Pache <npa...@redhat.com>
> ---
> drivers/firmware/cirrus/Kconfig | 3 +--
> tools/testing/kunit/configs/all_tests.config | 2 ++
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/cirrus/Kconfig b/drivers/firmware/cirrus/Kconfig
> index 0a883091259a..989568ab5712 100644
> --- a/drivers/firmware/cirrus/Kconfig
> +++ b/drivers/firmware/cirrus/Kconfig
> @@ -11,9 +11,8 @@ config FW_CS_DSP_KUNIT_TEST_UTILS
>
> config FW_CS_DSP_KUNIT_TEST
> tristate "KUnit tests for Cirrus Logic cs_dsp" if !KUNIT_ALL_TESTS
> - depends on KUNIT && REGMAP
> + depends on KUNIT && REGMAP && FW_CS_DSP
> default KUNIT_ALL_TESTS
> - select FW_CS_DSP
> select FW_CS_DSP_KUNIT_TEST_UTILS
> help
> This builds KUnit tests for cs_dsp.
> diff --git a/tools/testing/kunit/configs/all_tests.config
> b/tools/testing/kunit/configs/all_tests.config
> index b0049be00c70..96c6b4aca87d 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -49,3 +49,5 @@ CONFIG_SOUND=y
> CONFIG_SND=y
> CONFIG_SND_SOC=y
> CONFIG_SND_SOC_TOPOLOGY_BUILD=y
> +
> +CONFIG_FW_CS_DSP=y
> \ No newline at end of file
> --
> 2.48.1
>
