Re: [PATCH v2 0/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2025-01-09 Thread Christoph Hellwig
On Thu, Jan 09, 2025 at 08:56:37AM +0100, Greg Kroah-Hartman wrote: > The "pointless" penalty will go away once we convert all instances, and > really, it's just one pointer check, sysfs files should NOT be a hot > path for anything real, and one more pointer check should be cached and > not measur

[syzbot] [virt?] [net?] general protection fault in vsock_connectible_has_data

2025-01-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8ce4f287524c net: libwx: fix firmware mailbox abnormal ret.. git tree: net console+strace: https://syzkaller.appspot.com/x/log.txt?x=13f06edf98 kernel config: https://syzkaller.appspot.com/x/.config?x=1c541fa8af5c9cc7 dashboar

Re: [PATCH v2 0/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2025-01-09 Thread Greg Kroah-Hartman
On Thu, Jan 09, 2025 at 12:06:09AM -0800, Christoph Hellwig wrote: > On Thu, Jan 09, 2025 at 08:56:37AM +0100, Greg Kroah-Hartman wrote: > > The "pointless" penalty will go away once we convert all instances, and > > really, it's just one pointer check, sysfs files should NOT be a hot > > path for

Re: [PATCH v2 0/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2025-01-09 Thread Christoph Hellwig
On Thu, Jan 09, 2025 at 09:12:03AM +0100, Greg Kroah-Hartman wrote: > > Hey, when I duplicated the method to convert sysfs over to a proper > > seq_file based approach that avoids buffer overflows you basically > > came up with the same line that Alexei had here. > > I did? Sorry about that, I do

Re: [syzbot] [virt?] [net?] general protection fault in vsock_connectible_has_data

2025-01-09 Thread Stefano Garzarella
On Thu, Jan 09, 2025 at 12:11:20AM -0800, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:8ce4f287524c net: libwx: fix firmware mailbox abnormal ret.. git tree: net console+strace: https://syzkaller.appspot.com/x/log.txt?x=13f06edf98 kernel config: https://s

Re: [sos-linux-ext-patches] [PATCH v4 2/8] KVM: selftests: SEV-SNP test for KVM_SEV_INIT2

2025-01-09 Thread Nikunj A. Dadhania
On 11/15/2024 5:10 AM, Pratik R. Sampat wrote: > Add the X86_FEATURE_SNP CPU feature to the architectural definition for > the SEV-SNP VM type to exercise the KVM_SEV_INIT2 call. Ensure that the > SNP test is skipped in scenarios where CPUID supports it but KVM does > not, so that a failure is n

Re: [PATCH 3/6] syscall.h: introduce syscall_set_nr()

2025-01-09 Thread Sven Schnelle
"Dmitry V. Levin" writes: > Similar to syscall_set_arguments() that complements > syscall_get_arguments(), introduce syscall_set_nr() > that complements syscall_get_nr(). > > syscall_set_nr() is going to be needed along with > syscall_set_arguments() on all HAVE_ARCH_TRACEHOOK > architectures to

[PATCH bpf-next] bpf: veristat: Document verifier log dumping capability

2025-01-09 Thread Daniel Xu
`-l2 -v` is a useful combination of flags to dump the entire verification log. This is helpful when making changes to the verifier, as you can see what it thinks program one instruction at a time. This was more or less a hidden feature before. Document it so others can discover it. Signed-off-by:

Re: [sos-linux-ext-patches] [PATCH v4 1/8] KVM: SEV: Disable SEV-SNP on FW validation failure

2025-01-09 Thread Nikunj A. Dadhania
On 11/15/2024 5:10 AM, Pratik R. Sampat wrote: > On incompatible firmware versions, SEV-SNP support is pulled and the > setup is not performed. However, the platform and subsequently the KVM > capability may continue to advertize support for it. Disable support for > SEV-SNP if the FW version va

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Andrew Morton
On Thu, 9 Jan 2025 09:50:45 -0800 Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > > For the all other case, why should we keep argv/argc and mark them unused > > as well when they aren't being used? > > I'm fine either way, but my personal code style in

Re: [PATCH] selftests/net/forwarding: teamd command not found

2025-01-09 Thread Hangbin Liu
On Fri, Jan 10, 2025 at 01:07:44AM +0100, Alessandro Zanni wrote: > Running "make kselftest TARGETS=net/forwarding" results in several > occurrences of the same error: > ./lib.sh: line 787: teamd: command not found > > Since many tests depends on teamd, this fix stops the tests if the > teamd com

Re: [PATCH] perf tools: Fixup end address of modules

2025-01-09 Thread Arnaldo Carvalho de Melo
On Wed, Dec 18, 2024 at 02:15:35PM -0800, Ian Rogers wrote: > On Wed, Dec 18, 2024 at 2:04 PM Namhyung Kim wrote: > > > > In machine__create_module(), it reads /proc/modules to get a list of > > modules in the system. The file shows the start address (of text) and > > the size of the module so it

Re: [RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

2025-01-09 Thread Jeff Xu
On Wed, Jan 8, 2025 at 11:06 AM Lorenzo Stoakes wrote: > > On Mon, Jan 06, 2025 at 04:44:33PM -0800, Kees Cook wrote: > > On Mon, Jan 06, 2025 at 10:26:27AM -0800, Jeff Xu wrote: > > > + Kees because this is related to W^X memfd and security. > > > > > > On Fri, Jan 3, 2025 at 7:14 AM Jann Horn w

[PATCH] selftests/net/forwarding: teamd command not found

2025-01-09 Thread Alessandro Zanni
Running "make kselftest TARGETS=net/forwarding" results in several occurrences of the same error: ./lib.sh: line 787: teamd: command not found Since many tests depends on teamd, this fix stops the tests if the teamd command is not installed. Signed-off-by: Alessandro Zanni --- tools/testing/se

Re: [PATCH 0/2] selftest: fix riscv/vector tests

2025-01-09 Thread Charlie Jenkins
On Fri, Dec 20, 2024 at 05:17:25PM +0800, Yong-Xuan Wang wrote: > Add test counts and pass message to remove warning of riscv/vector tests. A similar patch has been staged on Palmers for-next tree that I sent out a long time ago. I also reworked these tests so that they use the kselftest_harness [

Re: [PATCH] virtio_ring: skip cpu sync when mapping fails

2025-01-09 Thread Jason Wang
On Wed, Jan 8, 2025 at 7:35 PM Michael S. Tsirkin wrote: > > On Mon, Nov 11, 2024 at 10:55:38AM +0800, Jason Wang wrote: > > There's no need to sync DMA for CPU on mapping errors. So this patch > > skips the CPU sync in the error handling path of DMA mapping. > > > > Signed-off-by: Jason Wang > >

Re: [PATCH v4 2/2] riscv: selftests: Add a ptrace test to verify syscall parameter modification

2025-01-09 Thread Charlie Jenkins
On Thu, Dec 26, 2024 at 11:21:59PM +0800, Celeste Liu wrote: > > On 2024-12-26 21:35, Dmitry V. Levin wrote: > > On Thu, Dec 26, 2024 at 06:52:52PM +0800, Celeste Liu wrote: > >> This test checks that orig_a0 allows a syscall argument to be modified, > >> and that changing a0 does not change the s

Re: [PATCH bpf-next v6 4/5] bpf: verifier: Support eliding map lookup nullness

2025-01-09 Thread Daniel Xu
On Thu, Jan 02, 2025 at 06:53:54PM -0800, Eduard Zingerman wrote: > On Thu, 2024-12-19 at 21:09 -0700, Daniel Xu wrote: > > lgtm, but please see a note below. > > [...] > > > +/* Returns constant key value if possible, else negative error */ > > +static s64 get_constant_map_key(struct bpf_verifi

Re: [PATCH] rseq/selftests: Fix riscv rseq_offset_deref_addv inline asm

2025-01-09 Thread Charlie Jenkins
On Fri, Jan 03, 2025 at 04:03:26AM +, Stafford Horne wrote: > When working on OpenRISC support for restartable sequences I noticed > and fixed these two issues with the riscv support bits. > > 1 The 'inc' argument to RSEQ_ASM_OP_R_DEREF_ADDV was being implicitly >passed to the macro. Fix

Re: [PATCH net-next v3 0/4] netconsole: selftest for userdata overflow

2025-01-09 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 08 Jan 2025 03:50:24 -0800 you wrote: > Implement comprehensive testing for netconsole userdata entry handling, > demonstrating correct behavior when creating maximum entries and > preventing unauthorized ove

Re: [sos-linux-ext-patches] [PATCH v4 2/8] KVM: selftests: SEV-SNP test for KVM_SEV_INIT2

2025-01-09 Thread Nikunj A. Dadhania
On 1/10/2025 11:22 AM, Nikunj A. Dadhania wrote: > > > On 11/15/2024 5:10 AM, Pratik R. Sampat wrote: >> Add the X86_FEATURE_SNP CPU feature to the architectural definition for >> the SEV-SNP VM type to exercise the KVM_SEV_INIT2 call. Ensure that the >> SNP test is skipped in scenarios where

[PATCH v4 3/4] rust: str: add radix prefixed integer parsing functions

2025-01-09 Thread Andreas Hindborg
Add the trait `ParseInt` for parsing string representations of integers where the string representations are optionally prefixed by a radix specifier. Implement the trait for the primitive integer types. Signed-off-by: Andreas Hindborg --- rust/kernel/str.rs | 118 +++

Re: [PATCH RFC 2/2] module: Introduce hash-based integrity checking

2025-01-09 Thread Arnout Engelen
On Fri, 3 Jan 2025 17:37:52 -0800, Luis Chamberlain wrote: > What distro which is using module signatures would switch > to this as an alternative instead? In NixOS, we disable MODULE_SIG by default (because we value reproducibility over having module signatures). Enabling MODULE_HASHES on systems

[PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Andreas Hindborg
This patch includes changes required for Rust kernel modules to utilize module parameters. This code implements read only support for integer types without `sysfs` support. Signed-off-by: Andreas Hindborg --- rust/kernel/lib.rs | 1 + rust/kernel/module_param.rs | 225 ++

[PATCH v4 0/4] rust: extend `module!` macro with integer parameter support

2025-01-09 Thread Andreas Hindborg
This series extends the `module!` macro with support module parameters. It also adds some string to integer parsing functions and updates `BStr` with a method to strip a string prefix. This series stated out as code by Adam Bratschi-Kaye lifted from the original `rust` branch [1]. After a bit of

[PATCH v4 1/4] rust: str: implement `PartialEq` for `BStr`

2025-01-09 Thread Andreas Hindborg
Implement `PartialEq` for `BStr` by comparing underlying byte slices. Reviewed-by: Alice Ryhl Signed-off-by: Andreas Hindborg --- rust/kernel/str.rs | 6 ++ 1 file changed, 6 insertions(+) diff --git a/rust/kernel/str.rs b/rust/kernel/str.rs index d04c12a1426d1c1edeb88325bcd9c63bf45f9b60.

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Stefano Garzarella
On Thu, Jan 09, 2025 at 04:13:44AM -0500, Hyunwoo Kim wrote: On Thu, Jan 09, 2025 at 10:01:31AM +0100, Stefano Garzarella wrote: On Wed, Jan 08, 2025 at 02:31:19PM -0500, Hyunwoo Kim wrote: > On Wed, Jan 08, 2025 at 07:06:16PM +0100, Stefano Garzarella wrote: > > If the socket has been de-assign

Re: [PATCH V3 6/8] arm64: dts: qcom: ipq5332: add nodes to bringup q6

2025-01-09 Thread Konrad Dybcio
On 7.01.2025 11:16 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- [...] > + q6v5_wcss: remoteproc@d10 { > +

Re: [PATCH V3 7/8] arm64: dts: qcom: ipq9574: add nodes to bring up q6

2025-01-09 Thread Konrad Dybcio
On 7.01.2025 11:16 AM, Gokul Sriram Palanisamy wrote: > From: Manikanta Mylavarapu > > Enable nodes required for q6 remoteproc bring up. > > Signed-off-by: Manikanta Mylavarapu > Signed-off-by: Gokul Sriram Palanisamy > --- The comments you got on patch 6 apply here and to patch 8 too Konrad

Re: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB

2025-01-09 Thread David Hildenbrand
On 09.01.25 14:05, David Hildenbrand wrote: > That is clear. The issue would be to figure which chunks are valid to unmap. If something critical like the executable file is unmapped, the process crashes. But see below. Ah, now I see what you mean. Yes, also the stack etc. will be problematic

[PATCH 02/16] selftests/mm: Fix unused parameter warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix warnings generated by unused parameters. Signed-off-by: Muhammad Usama Anjum --- .../selftests/mm/hugetlb_fault_after_madv.c | 4 +- .../selftests/mm/hugetlb_madv_vs_map.c| 6 +-- tools/testing/selftests/mm/ksm_tests.c| 17 +++--- tools/testing/selftests/mm/memfd_secret.

[PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Muhammad Usama Anjum
Remove the following warnings by removing unused argc and argv parameters: In function ‘main’: warning: unused parameter ‘argc’ [-Wunused-parameter] 158 | int main(int argc, char *argv[]) | ^~~~ warning: unused parameter ‘argv’ [-Wunused-parameter] 158 | int main(in

[PATCH 00/16] selftest/mm: Remove warnings found by adding compiler flags

2025-01-09 Thread Muhammad Usama Anjum
Recently, I reviewed a patch on the mm/kselftest mailing list about a test which had obvious type mismatch fix in it. It was strange why that wasn't caught during development and when patch was accepted. This led me to discover that those extra compiler options to catch these warnings aren't being

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Kees Cook
On Thu, Jan 09, 2025 at 10:48:52PM +0500, Muhammad Usama Anjum wrote: > For the all other case, why should we keep argv/argc and mark them unused > as well when they aren't being used? I'm fine either way, but my personal code style instinct is to keep the "standard" main declaration with argc/arg

[PATCH 05/16] selftests/mm: kselftest_harness: Fix warnings

2025-01-09 Thread Muhammad Usama Anjum
Found warnings through hmm-tests and mdwe_test. Fix following warnings: - Mark unused variable with unused attribute - __EXPECT is causing types mismatch warnings when __exp is unsigned and _seen is equal to a constant number, __typeof__(_seen) returns signed type. hmm-tests.c: In function

[PATCH 04/16] selftests/mm: Fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings in different tests. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/compaction_test.c | 2 +- tools/testing/selftests/mm/gup_longterm.c | 3 ++- tools/testing/selftests/mm/hugetlb_dio.c | 2 +- tools/testing/selftest

[PATCH 03/16] selftests/mm: Fix unused parameter warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix unused parameter warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/pkey-x86.h | 4 +++- .../selftests/mm/pkey_sighandler_tests.c | 17 +++-- tools/testing/selftests/mm/protection_keys.c | 18 ++ 3 files changed, 24 inse

[PATCH 11/16] selftests/mm: hugetlb-read-hwpoison: Fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/hugetlb-read-hwpoison.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/mm/hugetlb-read-hwpoison.c b/tools/testing/selftests/mm/hugetlb-read-hwpoison.

[PATCH 06/16] selftests/mm: cow: remove unused variables and fix type mismatch errors

2025-01-09 Thread Muhammad Usama Anjum
Fix following warnings: - Remove unused variables - Use __attribute__(unused) with unused variables which aren't being used and cannot be removed because of function pointer declaration - Fix type mismatches Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/cow.c | 46

[PATCH 07/16] selftests/mm: hmm-tests: Remove always false expressions

2025-01-09 Thread Muhammad Usama Anjum
As default_hsize is unsigned, it is always greater than equal to zero. Remove expression which is checking if it is less than 0. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/hmm-tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/se

[PATCH 13/16] selftests/mm: protection_keys: Fix variables types mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix variable type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/protection_keys.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/mm/protection_keys.c b/tools/testing/selftests/mm/protection_key

[PATCH 08/16] selftests/mm: guard-pages: Fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/guard-pages.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/guard-pages.c b/tools/testing/selftests/mm/guard-pages.c index ece37212a8a2e..fc1165ef2

[PATCH 10/16] selftests/mm: hugepage-vmemmap: fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/hugepage-vmemmap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/hugepage-vmemmap.c b/tools/testing/selftests/mm/hugepage-vmemmap.c index 23e97e55205

[PATCH 16/16] selftests/mm: Makefile: Add the compiler flags

2025-01-09 Thread Muhammad Usama Anjum
Add the compiler flags to catch warnings during development. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile index 63ce39d024bb5..006ed2e8df8

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Kees Cook
On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: > Remove the following warnings by removing unused argc and argv > parameters: > In function ‘main’: > warning: unused parameter ‘argc’ [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > |

[PATCH 12/16] selftests/mm: khugepaged: Fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/khugepaged.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c index 8a4d34cce36b2.

[PATCH 15/16] selftests/mm: uffd-*: Fix all type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix all type mismatch warnings in all uffd-* files. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/uffd-common.c | 6 +++--- tools/testing/selftests/mm/uffd-stress.c | 2 +- tools/testing/selftests/mm/uffd-unit-tests.c | 6 +++--- 3 files changed, 7 insertions(+), 7 d

[PATCH 14/16] selftests/mm: thuge-gen: Fix type mismatch warnings

2025-01-09 Thread Muhammad Usama Anjum
Fix all the found type mismatch warnings. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/thuge-gen.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c index e4370b79b

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

2025-01-09 Thread Muhammad Usama Anjum
On 1/9/25 10:42 PM, Kees Cook wrote: > On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: >> Remove the following warnings by removing unused argc and argv >> parameters: >> In function ‘main’: >> warning: unused parameter ‘argc’ [-Wunused-parameter] >> 158 | int main(int a

[PATCH 09/16] selftests/mm: hugetlb-madvise: fix type mismatch issues

2025-01-09 Thread Muhammad Usama Anjum
Fix type mismatch warnings: hugetlb-madvise.c:30:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Wsign-compare] 30 | if (fhp != (exp_free)) { \ | ^~ huge

Re: [PATCH net 2/2] vsock/bpf: return early if transport is not assigned

2025-01-09 Thread Michal Luczaj
On 1/8/25 19:06, Stefano Garzarella wrote: > Some of the core functions can only be called if the transport > has been assigned. > > As Michal reported, a socket might have the transport at NULL, > for example after a failed connect(), causing the following trace: > > BUG: kernel NULL pointer

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Stefano Garzarella
On Thu, Jan 09, 2025 at 02:34:28PM +0100, Michal Luczaj wrote: On 1/8/25 19:06, Stefano Garzarella wrote: If the socket has been de-assigned or assigned to another transport, we must discard any packets received because they are not expected and would cause issues when we access vsk->transport.

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-serranove: Add display panel

2025-01-09 Thread Bjorn Andersson
On Thu, 14 Nov 2024 23:07:18 +0100, Jakob Hauser wrote: > Add the Samsung S6E88A0-AMS427AP24 panel to the device tree for the > Samsung Galaxy S4 Mini Value Edition. By default the panel displays > everything horizontally flipped, so add "flip-horizontal" to the panel > node to correct that. > >

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-09 Thread Hangbin Liu
On Thu, Jan 09, 2025 at 09:26:38AM +0800, Jianbo Liu wrote: > > > On 1/8/2025 3:14 PM, Hangbin Liu wrote: > > On Wed, Jan 08, 2025 at 11:40:05AM +0800, Jianbo Liu wrote: > > > > > > > > > On 1/8/2025 10:46 AM, Hangbin Liu wrote: > > > > On Mon, Jan 06, 2025 at 10:47:16AM +, Hangbin Liu wrot

Re: [PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2025-01-09 Thread Sakari Ailus
Hi André, On Wed, Jan 08, 2025 at 10:46:51PM +0100, André Apitzsch wrote: > Hi Sakari, > > Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus: > > Hi André, > > > > Thanks for the update. > > > > On Fri, Dec 20, 2024 at 02:26:11PM +0100, André Apitzsch via B4 Relay > > wrote: > > >

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-09 Thread Jianbo Liu
On 1/9/2025 4:37 PM, Hangbin Liu wrote: On Thu, Jan 09, 2025 at 09:26:38AM +0800, Jianbo Liu wrote: On 1/8/2025 3:14 PM, Hangbin Liu wrote: On Wed, Jan 08, 2025 at 11:40:05AM +0800, Jianbo Liu wrote: On 1/8/2025 10:46 AM, Hangbin Liu wrote: On Mon, Jan 06, 2025 at 10:47:16AM +, Han

Re: [PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Andreas Hindborg
"Greg KH" writes: > On Thu, Jan 09, 2025 at 11:54:59AM +0100, Andreas Hindborg wrote: >> This patch includes changes required for Rust kernel modules to utilize >> module parameters. This code implements read only support for integer >> types without `sysfs` support. > > I know you want to keep t

Re: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB

2025-01-09 Thread David Hildenbrand
> That is clear. The issue would be to figure which chunks are valid to unmap. If something critical like the executable file is unmapped, the process crashes. But see below. Ah, now I see what you mean. Yes, also the stack etc. will be problematic. So IIUC, you want to limit the munmap optimi

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Stefano Garzarella
On Wed, Jan 08, 2025 at 02:31:19PM -0500, Hyunwoo Kim wrote: On Wed, Jan 08, 2025 at 07:06:16PM +0100, Stefano Garzarella wrote: If the socket has been de-assigned or assigned to another transport, we must discard any packets received because they are not expected and would cause issues when we

Re: [PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2025-01-09 Thread Sakari Ailus
On Thu, Jan 09, 2025 at 08:59:43AM +, Sakari Ailus wrote: > I tried to find a good example but the few I found are buggy. :-( Getting > runtime PM right is just hard. I'll drop the last patch and post another to I meant to say this patch, not the last one. -- Sakari Ailus

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Hyunwoo Kim
On Thu, Jan 09, 2025 at 10:01:31AM +0100, Stefano Garzarella wrote: > On Wed, Jan 08, 2025 at 02:31:19PM -0500, Hyunwoo Kim wrote: > > On Wed, Jan 08, 2025 at 07:06:16PM +0100, Stefano Garzarella wrote: > > > If the socket has been de-assigned or assigned to another transport, > > > we must discard

Re: [PATCH] virtio: console: Replace deprecated kmap_atomic with kmap_local_page

2025-01-09 Thread Amit Shah
On Wed, 2025-01-08 at 19:59 -0800, David Reaver wrote: > kmap_atomic() is deprecated and should be replaced with > kmap_local_page() > [1][2]. kmap_local_page() is faster in kernels with HIGHMEM enabled, > can > take page faults, and allows preemption. > > According to [2], this replacement is saf

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Michael S. Tsirkin
On Thu, Jan 09, 2025 at 10:01:31AM +0100, Stefano Garzarella wrote: > On Wed, Jan 08, 2025 at 02:31:19PM -0500, Hyunwoo Kim wrote: > > On Wed, Jan 08, 2025 at 07:06:16PM +0100, Stefano Garzarella wrote: > > > If the socket has been de-assigned or assigned to another transport, > > > we must discard

Re: [PATCH net 2/2] vsock/bpf: return early if transport is not assigned

2025-01-09 Thread Luigi Leonardi
On Wed, Jan 08, 2025 at 07:06:17PM +0100, Stefano Garzarella wrote: Some of the core functions can only be called if the transport has been assigned. As Michal reported, a socket might have the transport at NULL, for example after a failed connect(), causing the following trace: BUG: kernel

Re: [PATCH net 2/2] vsock/bpf: return early if transport is not assigned

2025-01-09 Thread Michael S. Tsirkin
On Wed, Jan 08, 2025 at 07:06:17PM +0100, Stefano Garzarella wrote: > Some of the core functions can only be called if the transport > has been assigned. > > As Michal reported, a socket might have the transport at NULL, > for example after a failed connect(), causing the following trace: > >

Re: [PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Greg KH
On Thu, Jan 09, 2025 at 11:54:59AM +0100, Andreas Hindborg wrote: > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. I know you want to keep this simple for now, but will

Re: [PATCH v4 2/4] rust: str: implement `strip_prefix` for `BStr`

2025-01-09 Thread Alice Ryhl
On Thu, Jan 9, 2025 at 11:56 AM Andreas Hindborg wrote: > > Implement `strip_prefix` for `BStr` by deferring to `slice::strip_prefix` > on the underlying `&[u8]`. > > Signed-off-by: Andreas Hindborg Reviewed-by: Alice Ryhl

Re: [PATCH V3 4/8] remoteproc: qcom: add hexagon based WCSS secure PIL driver

2025-01-09 Thread Gokul Sriram Palanisamy
On 1/8/2025 9:39 AM, Bjorn Andersson wrote: > On Tue, Jan 07, 2025 at 03:46:43PM +0530, Gokul Sriram Palanisamy wrote: >> From: Vignesh Viswanathan >> >> Add support to bring up hexagon based WCSS secure PIL remoteproc. >> IPQ5332, IPQ9574 supports secure PIL remoteproc. > > I'd love for this to

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-09 Thread Jianbo Liu
On 1/9/2025 6:17 PM, Hangbin Liu wrote: On Thu, Jan 09, 2025 at 05:51:07PM +0800, Jianbo Liu wrote: No, we don't need. But I am trying to understand what you said in your last email about adding a new lock, or unlocking spin lock in I *thought* we need the spin lock in xfrm_state_delete().

Re: [PATCH] checkpatch: Remove migrated RCU APIs from deprecated_apis

2025-01-09 Thread Paul E. McKenney
On Thu, Jan 09, 2025 at 07:56:51AM -0800, Joe Perches wrote: > On Wed, 2025-01-08 at 11:24 -0800, David Reaver wrote: > > The deprecated_apis map was created in [1] so checkpatch would flag > > deprecated RCU APIs. These deprecated APIs have since been removed from the > > kernel. This patch remove

Re: [PATCH] checkpatch: Remove migrated RCU APIs from deprecated_apis

2025-01-09 Thread Joe Perches
On Wed, 2025-01-08 at 11:24 -0800, David Reaver wrote: > The deprecated_apis map was created in [1] so checkpatch would flag > deprecated RCU APIs. These deprecated APIs have since been removed from the > kernel. This patch removes them from this map so checkpatch doesn't waste > time looking for t

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Michal Luczaj
On 1/9/25 14:42, Stefano Garzarella wrote: > On Thu, Jan 09, 2025 at 02:34:28PM +0100, Michal Luczaj wrote: >> ... >> That said, when I apply this patch, but drop the `sk->sk_state != >> TCP_LISTEN &&`: no more splats. > > We can't drop `sk->sk_state != TCP_LISTEN &&` because listener socket > do

Re: [PATCH v4 4/4] rust: add parameter support to the `module!` macro

2025-01-09 Thread Greg KH
On Thu, Jan 09, 2025 at 02:03:39PM +0100, Andreas Hindborg wrote: > "Greg KH" writes: > > > On Thu, Jan 09, 2025 at 11:54:59AM +0100, Andreas Hindborg wrote: > >> This patch includes changes required for Rust kernel modules to utilize > >> module parameters. This code implements read only support

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Hyunwoo Kim
On Thu, Jan 09, 2025 at 11:59:21AM +0100, Stefano Garzarella wrote: > On Thu, Jan 09, 2025 at 04:13:44AM -0500, Hyunwoo Kim wrote: > > On Thu, Jan 09, 2025 at 10:01:31AM +0100, Stefano Garzarella wrote: > > > On Wed, Jan 08, 2025 at 02:31:19PM -0500, Hyunwoo Kim wrote: > > > > On Wed, Jan 08, 2025

Re: [syzbot] [virt?] [net?] general protection fault in vsock_connectible_has_data

2025-01-09 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-by: syzbot+3affdbfc986ecd920...@syzkaller.appspotmail.com Tested-by: syzbot+3affdbfc986ecd920...@syzkaller.appspotmail.com Tested on: commit: 767faff2 vsock/bpf: return early if transport

Re: [PATCH net 0/2] bond: fix xfrm offload feature during init

2025-01-09 Thread Hangbin Liu
On Thu, Jan 09, 2025 at 05:51:07PM +0800, Jianbo Liu wrote: > > > No, we don't need. But I am trying to understand what you said in your > > > last > > > email about adding a new lock, or unlocking spin lock in > > > > I *thought* we need the spin lock in xfrm_state_delete(). So to protect > > x

Re: [PATCH net-next v16 07/26] ovpn: introduce the ovpn_socket object

2025-01-09 Thread Sabrina Dubroca
2025-01-06, 00:27:28 +0100, Antonio Quartulli wrote: > Hi Sabrina, > > On 03/01/2025 18:00, Sabrina Dubroca wrote: > > Hello Antonio, > > > > 2024-12-19, 02:42:01 +0100, Antonio Quartulli wrote: > > > +static void ovpn_socket_release_kref(struct kref *kref) > > > + __releases(sock->sock->sk) > >

[PATCH v4 2/4] rust: str: implement `strip_prefix` for `BStr`

2025-01-09 Thread Andreas Hindborg
Implement `strip_prefix` for `BStr` by deferring to `slice::strip_prefix` on the underlying `&[u8]`. Signed-off-by: Andreas Hindborg --- It is also possible to get this method by implementing `core::slice::SlicePattern` for `BStr`. `SlicePattern` is unstable, so this seems more reasonable. ---

Re: [PATCH net 1/2] vsock/virtio: discard packets if the transport changes

2025-01-09 Thread Michal Luczaj
On 1/8/25 19:06, Stefano Garzarella wrote: > If the socket has been de-assigned or assigned to another transport, > we must discard any packets received because they are not expected > and would cause issues when we access vsk->transport. > > A possible scenario is described by Hyunwoo Kim in the

Re: [PATCH 1/3] selftests/mm: virtual_address_range: Fix error when CommitLimit < 1GiB

2025-01-09 Thread Thomas Weißschuh
On Thu, Jan 09, 2025 at 02:05:43PM +0100, David Hildenbrand wrote: > > > > That is clear. The issue would be to figure which chunks are valid to > > unmap. If something critical like the executable file is unmapped, > > the process crashes. But see below. > > Ah, now I see what you mean. Yes, also

Re: [PATCH 0/2] selftest: fix riscv/vector tests

2025-01-09 Thread patchwork-bot+linux-riscv
Hello: This series was applied to riscv/linux.git (fixes) by Palmer Dabbelt : On Fri, 20 Dec 2024 17:17:25 +0800 you wrote: > Add test counts and pass message to remove warning of riscv/vector tests. > > Yong-Xuan Wang (2): > tools: selftests: riscv: Add pass message for v_initval_nolibc > t

Re: [PATCH] KVM: selftests: Remove unneeded semicolon

2025-01-09 Thread Sean Christopherson
On Tue, 26 Nov 2024 15:37:44 +0800, Chen Ni wrote: > Remove unnecessary semicolons reported by Coccinelle/coccicheck and the > semantic patch at scripts/coccinelle/misc/semicolon.cocci. Applied to kvm-x86 selftests, thanks! [1/1] KVM: selftests: Remove unneeded semicolon https://github.com/

Re: [PATCH] KVM: selftests: Add printf attribute to _no_printf()

2025-01-09 Thread Sean Christopherson
On Fri, 13 Dec 2024 14:30:00 -0800, Reinette Chatre wrote: > Annotate the KVM selftests' _no_printf() with the printf format attribute > so that the compiler can help check parameters provided to pr_debug() and > pr_info() irrespective of DEBUG and QUIET being defined. > > [reinette: move attribut

Re: [PATCH v2 0/6] Extend pmu_counters_test to AMD CPUs

2025-01-09 Thread Sean Christopherson
On Wed, 18 Sep 2024 20:53:13 +, Colton Lewis wrote: > Extend pmu_counters_test to AMD CPUs. > > As the AMD PMU is quite different from Intel with different events and > feature sets, this series introduces a new code path to test it, > specifically focusing on the core counters including the >

Re: [PATCH v2 0/2] KVM: x86: read the PML log in the same order it was written

2025-01-09 Thread Sean Christopherson
On Thu, 19 Dec 2024 17:10:32 -0500, Maxim Levitsky wrote: > Reverse the order in which > the PML log is read to align more closely to the hardware. It should > not affect regular users of the dirty logging but it fixes a unit test > specific assumption in the dirty_log_test dirty-ring mode. > > Be

Re: [PATCH v6 12/13] media: i2c: imx214: Fix clock handling on probe error or remove

2025-01-09 Thread André Apitzsch
Hi Sakari, Am Donnerstag, dem 09.01.2025 um 08:59 + schrieb Sakari Ailus: > Hi André, > > On Wed, Jan 08, 2025 at 10:46:51PM +0100, André Apitzsch wrote: > > Hi Sakari, > > > > Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus: > > > Hi André, > > > > > > Thanks for the update