Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty

2021-04-02 Thread Herbert Xu
On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote: > > I think it is not a real bug, and soft fallback setkey can always catch the > error. > But our original intention was to make it don't go to 'xxx_set_pub_key' > when the key is null, and it can return an error earlier. > But maybe it is no

Re: [PATCH 14/16] dt-bindings: phy: Convert Cadence DPHY binding to YAML

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:46PM +0530, Pratyush Yadav wrote: > Convert Cadence DPHY binding to YAML. > > Signed-off-by: Pratyush Yadav > --- > .../devicetree/bindings/phy/cdns,dphy.txt | 20 > .../devicetree/bindings/phy/cdns,dphy.yaml|

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephan Gerhold
On Thu, Apr 01, 2021 at 11:58:48PM -0700, Stephen Boyd wrote: > Quoting Elliot Berman (2021-04-01 18:12:14) > > > > It might be a good idea to wrap these lines from qcom_scm_call with #if > > IS_ENABLED(CONFIG_ARM), and the corresponding ones in qcom_scm_call_atomic: > > > >case SMC_CONVENTI

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-02 Thread Lukasz Luba
Hi Viresh, Daniel On 2/18/21 4:18 AM, Viresh Kumar wrote: On 17-02-21, 11:59, Lukasz Luba wrote: Update maintainers responsible for CPU cooling on Arm side. Signed-off-by: Lukasz Luba --- Hi Daniel, Please ignore the previous email and that this change with 'R'. Javi will ack it later. Rega

Re: [PATCH 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-04-02 Thread Łukasz Stelmach
It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote: > The core now has RTC_FEATURE_ALARM for the driver to indicate whether > alarms are available. Use that instead of HAS_ALARM to ensure the alarm > callbacks are not even called. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/

[PATCH v3] MIPS: Check __clang__ to avoid performance influence with GCC in csum_tcpudp_nofold()

2021-04-02 Thread Tiezhu Yang
The asm code in csum_tcpudp_nofold() is performance critical, I am sorry for the poorly considered implementation about the performance influence with GCC in the commit 198688edbf77 ("MIPS: Fix inline asm input/output type mismatch in checksum.h used with Clang"). Using __clang__ instead of CC_IS_

Re: [PATCH 2/3] rtc: ds1307: remove flags

2021-04-02 Thread Łukasz Stelmach
It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote: > flags is now unused, drop it. > > Signed-off-by: Alexandre Belloni > --- > drivers/rtc/rtc-ds1307.c | 2 -- > 1 file changed, 2 deletions(-) > Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach > diff --git a/drivers/rtc/rtc-

Re: [PATCH 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-02 Thread Łukasz Stelmach
It was <2021-03-30 wto 02:03>, when Alexandre Belloni wrote: > Now that the core is aware of whether alarms are available, it is possible > to decide whether UIE emulation is required before actually trying to set > the alarm. > > This greatly simplifies rtc_update_irq_enable because there is now o

Re: [RFC PATCH 2/2] drivers: soc: qcom: Add SDPM clock monitor driver

2021-04-02 Thread AngeloGioacchino Del Regno
Il 02/04/21 08:59, Manaf Meethalavalappu Pallikunhi ha scritto: Add SDPM clock monitor driver, which will register for clock rate change notification and write the clock rate into SDPM CSR register. Signed-off-by: Ram Chandrasekar Signed-off-by: Manaf Meethalavalappu Pallikunhi --- drivers/s

[PATCH] rapidio/rio_cm: Remove an unused variable 'rc'

2021-04-02 Thread Yang Li
Fixes the following W=1 kernel build warning(s): drivers/rapidio/rio_cm.c:673:7: warning: variable ???rc??? set but not used Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/rapidio/rio_cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/rapidio/rio_

Re: [PATCH 15/16] dt-bindings: phy: cdns,dphy: make clocks optional

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:47PM +0530, Pratyush Yadav wrote: > The clocks are not used by the DPHY when used in Rx mode so make them > optional. Isn't there a main functional clock (DPHY_RX_MAIN_CLK in the J721E TRM) that is needed in RX mode ? > Signed-

Re: [PATCH v3] arm64: dts: msm8916: Enable CoreSight STM component

2021-04-02 Thread Stephan Gerhold
On Sun, Mar 21, 2021 at 08:42:12PM +0800, Leo Yan wrote: > From: Georgi Djakov > > Add DT binding for CoreSight System Trace Macrocell (STM) on msm8916, > which can benefit the CoreSight development on DB410c. > > Signed-off-by: Georgi Djakov > Signed-off-by: Leo Yan Thanks for sending the ne

Re: [PATCH] ecc: delete a useless function declaration

2021-04-02 Thread Christophe Leroy
Le 02/04/2021 à 11:55, Meng Yu a écrit : This function declaration has been added in 'ecc_curve.h', delete it in 'crypto/ecc.h'. Fixes: 14bb76768275(crypto: ecc - expose ecc curves) Fixes tag is wrong I think, should be 4e6602916bc6 Signed-off-by: Meng Yu --- crypto/ecc.h | 8

Re: [PATCH 16/16] dt-bindings: phy: cdns,dphy: add power-domains property

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:48PM +0530, Pratyush Yadav wrote: > This property is needed on TI platforms to enable the PD of the DPHY > before it can be used. > > Signed-off-by: Pratyush Yadav > --- > Documentation/devicetree/bindings/phy/cdns,dphy.yaml |

[PATCH net] net: octeon: mgmt: fix xmit hang as busy

2021-04-02 Thread Ivan Khoronzhuk
The issue happens only at appropriate circumstances, in my case I faced it only while running crash kernel, when basic kernel worked fine. The code inspection has shown tx_current_fill counter overflow, after one packet or couple packets were sent. That's because tx cleanup tasklet dequeued bunch o

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-02 Thread Joe Perches
On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > remove all RT_TRACE logs > > fix patch-related checkpatch issues > > Signed-off-by: Fabio Aiuto > --- >  .../staging/rtl8723bs/core/rtw_wlan_util.c| 26 +-- >  1 file changed, 6 insertions(+), 20 deletions(-) > > diff --

Re: [PATCH 03/16] phy: cdns-dphy: Allow setting mode

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:35PM +0530, Pratyush Yadav wrote: > Allow callers to set the PHY mode. The main mode should always be > PHY_MODE_MIPI_DPHY but the submode can either be > PHY_MIPI_DPHY_SUBMODE_RX or PHY_MIPI_DPHY_SUBMODE_TX. Update the ops > bas

[PATCH] mm/vmscan.c: drop_slab_node with task's memcg

2021-04-02 Thread Neil Sun
This patch makes shrink_slab() with task's memcg in drop_slab_node(), so we can free reclaimable slab objects belongs to memcg /lxc/i-vbe1u8o7 with following command: cgexec -g memory:/lxc/i-vbe1u8o7 sysctl vm.drop_caches=2 Test with following steps: root@i-yl0pwrt8:~# free -h tota

Re: [PATCH 10/16] media: cadence: csi2rx: Add wrappers for subdev calls

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:42PM +0530, Pratyush Yadav wrote: > When this bridge driver is being user by another platform driver, it > might want to call subdev operations like getting format, setting > format, enumerating format codes, etc. Add wrapper fun

[PATCH] net/Bluetooth - delete unneeded variable initialization

2021-04-02 Thread Kai Ye
Delete unneeded variable initialization. Signed-off-by: Kai Ye --- net/bluetooth/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index cff4944..ee4b0ec 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan

[PATCH v2 1/1] power: reset: at91-reset: use devm_of_iomap

2021-04-02 Thread Claudiu Beznea
Use devm_of_iomap() to map resources. This will avoid the necessity to track the mapped resources and free them on failure path or on remove. Reported-by: kernel test robot Reported-by: Dan Carpenter Suggested-by: Nicolas Ferre Signed-off-by: Claudiu Beznea --- Changes in v2: - use devm_of_io

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-02 Thread Daniel Lezcano
On 02/04/2021 12:25, Lukasz Luba wrote: > Hi Viresh, Daniel > > On 2/18/21 4:18 AM, Viresh Kumar wrote: >> On 17-02-21, 11:59, Lukasz Luba wrote: >>> Update maintainers responsible for CPU cooling on Arm side. >>> >>> Signed-off-by: Lukasz Luba >>> --- >>> Hi Daniel, >>> >>> Please ignore the pre

Re: [PATCH 12/16] dt-bindings: media: Add DT bindings for TI CSI2RX driver

2021-04-02 Thread Laurent Pinchart
On Fri, Apr 02, 2021 at 01:01:22PM +0300, Laurent Pinchart wrote: > On Thu, Apr 01, 2021 at 10:52:01AM -0500, Rob Herring wrote: > > On Tue, Mar 30, 2021 at 11:03:44PM +0530, Pratyush Yadav wrote: > > > TI's J721E uses the Cadence CSI2RX and DPHY peripherals to facilitate > > > capture over a CSI-2

Re: [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

2021-04-02 Thread Daniel Lezcano
On 01/04/2021 21:37, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:36:54PM +0200, Daniel Lezcano wrote: [ ... ] > Why have you not documented all of this in Documentation/ABI so that we > can find it later? You are right, I will write some documentation. >> Signed-off-by: Daniel Lezcano >> ---

Re: [PATCH v6 7/7] powercap/drivers/dtpm: Allow dtpm node device creation through configfs

2021-04-02 Thread Daniel Lezcano
On 01/04/2021 21:37, Greg KH wrote: > On Thu, Apr 01, 2021 at 08:36:54PM +0200, Daniel Lezcano wrote: [ ... ] > Why have you not documented all of this in Documentation/ABI so that we > can find it later? You are right, I will write some documentation. >> Signed-off-by: Daniel Lezcano >> ---

Re: [PATCH 09/16] media: cadence: csi2rx: Turn subdev power on before starting stream

2021-04-02 Thread Laurent Pinchart
Hi Pratyush, Thank you for the patch. On Tue, Mar 30, 2021 at 11:03:41PM +0530, Pratyush Yadav wrote: > The subdevice power needs to be turned on before the stream is started. > Otherwise it might not be in the proper state to stream the data. Turn > it off when stopping the stream. The .s_power

Re: [PATCH 00/16] CSI2RX support on J721E

2021-04-02 Thread Laurent Pinchart
On Wed, Mar 31, 2021 at 03:03:51PM +0530, Vinod Koul wrote: > On 30-03-21, 23:03, Pratyush Yadav wrote: > > Hi, > > > > This series adds support for CSI2 capture on J721E. It includes some > > fixes to the Cadence CSI2RX driver, adds Rx support to Cadence DPHY > > driver, and finally adds the TI C

Re: [PATCH 12/32] MAINTAINERS: update lego,ev3-battery.yaml reference

2021-04-02 Thread Sebastian Reichel
Hi, On Thu, Apr 01, 2021 at 10:40:32AM -0500, David Lechner wrote: > On 4/1/21 7:17 AM, Mauro Carvalho Chehab wrote: > > Changeset 3004e581d92a ("dt-bindings: power: supply: lego-ev3-battery: > > Convert to DT schema format") > > renamed: Documentation/devicetree/bindings/power/supply/lego_ev3_ba

Re: [PATCH 28/32] dt-bindings: power: update battery.yaml reference

2021-04-02 Thread Sebastian Reichel
Hi, On Thu, Apr 01, 2021 at 02:17:48PM +0200, Mauro Carvalho Chehab wrote: > Changesets: 70c23e62d20c ("dt-bindings: power: supply: Fix remaining > battery.txt links") > and: 471dec8023d1 ("dt-bindings: power: Convert battery.txt to battery.yaml") > renamed: Documentation/devicetree/bindings/powe

Re: [PATCH v3 07/25] x86/sgx: Initialize virtual EPC driver even when SGX driver is disabled

2021-04-02 Thread Kai Huang
On Fri, 2 Apr 2021 11:48:16 +0200 Borislav Petkov wrote: > On Fri, Mar 19, 2021 at 08:23:02PM +1300, Kai Huang wrote: > > Modify sgx_init() to always try to initialize the virtual EPC driver, > > even if the SGX driver is disabled. The SGX driver might be disabled > > if SGX Launch Control is in l

Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

2021-04-02 Thread Lukasz Luba
+CC Javi (on his Arm email) On 4/2/21 11:53 AM, Daniel Lezcano wrote: On 02/04/2021 12:25, Lukasz Luba wrote: Hi Viresh, Daniel On 2/18/21 4:18 AM, Viresh Kumar wrote: On 17-02-21, 11:59, Lukasz Luba wrote: Update maintainers responsible for CPU cooling on Arm side. Signed-off-by: Lukasz

Re: [PATCH v2 01/10] KVM: Assert that notifier count is elevated in .change_pte()

2021-04-02 Thread Paolo Bonzini
On 02/04/21 02:56, Sean Christopherson wrote: In KVM's .change_pte() notification callback, replace the notifier sequence bump with a WARN_ON assertion that the notifier count is elevated. An elevated count provides stricter protections than bumping the sequence, and the sequence is guarnateed t

Re: [PATCH v10 10/16] KVM: x86: Introduce KVM_GET_SHARED_PAGES_LIST ioctl

2021-04-02 Thread Ashish Kalra
Hello Steve, On Thu, Apr 01, 2021 at 06:40:06PM -0700, Steve Rutherford wrote: > On Fri, Mar 19, 2021 at 11:00 AM Ashish Kalra wrote: > > > > On Thu, Mar 11, 2021 at 12:48:07PM -0800, Steve Rutherford wrote: > > > On Thu, Mar 11, 2021 at 10:15 AM Ashish Kalra > > > wrote: > > > > > > > > On Wed

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

2021-04-02 Thread Daniel Lezcano
On 02/04/2021 10:02, Greg KH wrote: > On Fri, Apr 02, 2021 at 12:08:49AM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 01/04/2021 21:28, Greg KH wrote: >>> On Thu, Apr 01, 2021 at 08:36:49PM +0200, Daniel Lezcano wrote: A SoC can be differently structured depending on the platform and t

Re: [PATCH] coda: Remove various instances of an unused variable 'outp'

2021-04-02 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yang-Li/coda-Remove-various-instances-of-an-unused-variable-outp/20210402-173111 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1678e493d530e7977cce34e59a86bb86f3c56

Re: [PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-04-02 Thread Marc Zyngier
On Thu, 25 Mar 2021 09:00:25 +, Kishon Vijay Abraham I wrote: > > Add PCI legacy interrupt support for AM654. AM654 has a single HW > interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. > The HW interrupt line connected to GIC is a pulse interrupt whereas > the legacy inter

Re: [PATCH] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Andy Shevchenko
On Fri, Apr 2, 2021 at 12:32 AM Tomas Winkler wrote: > > From: Tamar Mashiah > > During PCH manufacturing a global reset has to be induced in order > for configuration changes take affect upon following platform reset. effect upon the following ? > This setting was commonly done by accessing PM

Re: [PATCH v2 1/1] power: reset: at91-reset: use devm_of_iomap

2021-04-02 Thread Sebastian Reichel
Hi, On Fri, Apr 02, 2021 at 01:50:18PM +0300, Claudiu Beznea wrote: > Use devm_of_iomap() to map resources. This will avoid the necessity to > track the mapped resources and free them on failure path or on remove. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Suggested-by: N

Re: [PATCH v2 10/13] KVM: x86/mmu: Allow zapping collapsible SPTEs to use MMU read lock

2021-04-02 Thread Paolo Bonzini
On 02/04/21 01:37, Ben Gardon wrote: To speed the process of disabling dirty logging, change the TDP MMU function which zaps collapsible SPTEs to run under the MMU read lock. Technically it only reduces the impact on the running VM; it doesn't speed it up right? Something like: To reduce

Re: [PATCH 3/4] PCI: j721e: Add PCIe support for j7200

2021-04-02 Thread Marc Zyngier
On Thu, 25 Mar 2021 09:09:35 +, Kishon Vijay Abraham I wrote: > > J7200 has the same PCIe IP as in J721E with minor changes in the > wrapper. Add PCIe support for j7200 accounting for the wrapper > changes in pci-j721e.c > Changes from J721E: > *) Allows byte access of bridge configuration s

Re: [PATCH][next] crypto: sun8i-ss: Fix memory leak of pad

2021-04-02 Thread Corentin Labbe
Le Thu, Apr 01, 2021 at 04:18:27PM +0100, Colin King a écrit : > From: Colin Ian King > > It appears there are several failure return paths that don't seem > to be free'ing pad. Fix these. > > Addresses-Coverity: ("Resource leak") > Fixes: d9b45418a917 ("crypto: sun8i-ss - support hash algorithm

Re: [PATCH v3 07/25] x86/sgx: Initialize virtual EPC driver even when SGX driver is disabled

2021-04-02 Thread Borislav Petkov
On Sat, Apr 03, 2021 at 12:08:10AM +1300, Kai Huang wrote: > Do you want me to send updated patch? No need. If I do, I'll ask kindly, otherwise you don't have to do anything. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette

[PATCH v2] crypto: hisilicon/qm - delete redundant code

2021-04-02 Thread Kai Ye
The "qdma" is a structure variable instead of actual data. This structure doesn't need to be zerod, The memset is useless and redundant. So delete it. Signed-off-by: Kai Ye --- Changes v1 -> v2: Re-edit the description. drivers/crypto/hisilicon/qm.c | 1 - 1 file changed, 1 deletion(-) diff -

Re: [PATCH] arm64/mm: Fix mapping_dirty_helpers with arm64

2021-04-02 Thread Catalin Marinas
On Wed, Mar 31, 2021 at 02:23:44PM -0400, Zack Rusin wrote: > The pagetable walk callbacks in mm/mapping_dirty_helpers.c depend > on a set of helpers from which pud_dirty(pud) was missing. I'm > assuming mapping_dirty_helpers weren't used on ARM64 before > because the missing pud_dirty is causing a

[PATCH v2] crypto: hisilicon/hpre - delete redundant log

2021-04-02 Thread Hui Tang
'hpre_cfg_by_dsm' has checked and printed error path internally. It is not necessary to do it here, so remove it. Signed-off-by: Hui Tang v1 -> v2: - Return immediately when return value of 'hpre_cfg_by_dsm' is non-zero. --- drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +- 1 file changed, 1 in

Re: [PATCH v3 2/3] ima: enable signing of modules with build time generated key

2021-04-02 Thread Stefan Berger
On 3/30/21 9:16 AM, Nayna Jain wrote: The kernel build process currently only signs kernel modules when MODULE_SIG is enabled. Also, sign the kernel modules at build time when IMA_APPRAISE_MODSIG is enabled. Signed-off-by: Nayna Jain Acked-by: Stefan Berger --- certs/Kconfig | 2 +- ce

Re: [PATCH v3 3/3] ima: enable loading of build time generated key on .ima keyring

2021-04-02 Thread Stefan Berger
On 3/30/21 9:16 AM, Nayna Jain wrote: The kernel currently only loads the kernel module signing key onto the builtin trusted keyring. Load the module signing key onto the IMA keyring as well. Signed-off-by: Nayna Jain Acked-by: Stefan Berger --- certs/system_certificates.S | 13 +++

Re: [PATCH v3 07/25] x86/sgx: Initialize virtual EPC driver even when SGX driver is disabled

2021-04-02 Thread Kai Huang
On Fri, 2 Apr 2021 13:22:35 +0200 Borislav Petkov wrote: > On Sat, Apr 03, 2021 at 12:08:10AM +1300, Kai Huang wrote: > > Do you want me to send updated patch? > > No need. If I do, I'll ask kindly, otherwise you don't have to do > anything. > I see. Thanks.

Re: [Freedreno] [v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-04-02 Thread kalyan_t
On 2021-04-01 19:01, Dmitry Baryshkov wrote: On Thu, 1 Apr 2021 at 16:19, wrote: On 2021-04-01 07:37, Dmitry Baryshkov wrote: > On 01/04/2021 01:47, Rob Clark wrote: >> On Wed, Mar 31, 2021 at 9:03 AM Dmitry Baryshkov >> wrote: >>> >>> On 31/03/2021 14:27, Kalyan Thota wrote: WARN_ON was

Re: [PATCH v2 00/13] More parallel operations for the TDP MMU

2021-04-02 Thread Paolo Bonzini
On 02/04/21 01:37, Ben Gardon wrote: Now that the TDP MMU is able to handle page faults in parallel, it's a relatively small change to expand to other operations. This series allows zapping a range of GFNs, reclaiming collapsible SPTEs (when disabling dirty logging), and enabling dirty logging to

[PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-02 Thread Dan Carpenter
The nla_len() is less than or equal to 16. If it's less than 16 then end of the "gid" buffer is uninitialized. Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") Signed-off-by: Dan Carpenter --- I just spotted this in review. I think it's a bug but I'm not 100%. drivers/infiniband

Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 01:10:51PM +0200, Daniel Lezcano wrote: > >> To answer your questions, there is a SoC vendor thermal daemon using > >> DTPM and there is a tool created to watch the thermal framework and read > >> the DTPM values, it is available at [4]. It is currently under > >> developmen

Re: [PATCH] mm: page_owner: detect page_owner recursion via task_struct

2021-04-02 Thread Sergei Trofimovich
On Thu, 1 Apr 2021 17:05:19 -0700 Andrew Morton wrote: > On Thu, 1 Apr 2021 23:30:10 +0100 Sergei Trofimovich > wrote: > > > Before the change page_owner recursion was detected via fetching > > backtrace and inspecting it for current instruction pointer. > > It has a few problems: > > - it is

[PATCH v2] mm: page_owner: detect page_owner recursion via task_struct

2021-04-02 Thread Sergei Trofimovich
Before the change page_owner recursion was detected via fetching backtrace and inspecting it for current instruction pointer. It has a few problems: - it is slightly slow as it requires extra backtrace and a linear stack scan of the result - it is too late to check if backtrace fetching required

[v1] drm/msm/disp/dpu1: program 3d_merge only if block is attached

2021-04-02 Thread Kalyan Thota
Update the 3d merge as active in the data path only if the hw block is selected in the configuration. Reported-by: Stephen Boyd Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/d

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Dan Carpenter
On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter > *padapter, struct pkt_attrib *p > if (pattrib->encrypt > 0) > memcpy(pattrib->dot118021x_UncstKey.skey, > psta->dot118021x_UncstKey.skey, 16)

Re: [PATCH v4 2/2] power: supply: mt6360_charger: add MT6360 charger support

2021-04-02 Thread Sebastian Reichel
Hi, On Mon, Jan 18, 2021 at 08:41:43PM +0800, Gene Chen wrote: > From: Gene Chen > > Add basic support for the battery charger for MT6360 PMIC > > Signed-off-by: Gene Chen > --- > drivers/power/supply/Kconfig | 10 + > drivers/power/supply/Makefile | 1 + > drivers/power/s

[PATCH] dt-bindings: fpga: fpga-region: Convert to sugar syntax

2021-04-02 Thread Geert Uytterhoeven
Using overlay sugar syntax makes the DTS files easier to read (and write). While at it, fix two build issues: - "/dts-v1/" and "/plugin/" must be separate statements. - Add a missing closing curly brace. Signed-off-by: Geert Uytterhoeven --- .../devicetree/bindings/fpga/fpga-region.txt | 1

Re: [RFC v2] KVM: x86: Support KVM VMs sharing SEV context

2021-04-02 Thread Ashish Kalra
Hi Nathan, Will you be posting a corresponding Qemu patch for this ? Thanks, Ashish On Tue, Mar 16, 2021 at 01:40:27AM +, Nathan Tempelman wrote: > Add a capability for userspace to mirror SEV encryption context from > one vm to another. On our side, this is intended to support a > Migration

Re: [PATCH] power: reset: hisi-reboot: use the correct HiSilicon copyright

2021-04-02 Thread s...@kernel.org
Hi, On Tue, Mar 30, 2021 at 08:40:48AM +, Haojian Zhuang wrote: > On 3/30/21 2:38 PM, Hao Fang wrote: > > s/Hisilicon/HiSilicon/g. > > It should use capital S, according to > > https://www.hisilicon.com/en/terms-of-use. > > > > Signed-off-by: Hao Fang > > --- > > drivers/power/reset/hisi-r

Re: [PATCH v2 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver

2021-04-02 Thread Philipp Zabel
Hi Quan, On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote: > The SMBus system interface (SSIF) IPMI BMC driver can be used to perform > in-band IPMI communication with their host in management (BMC) side. > > This commits adds support specifically for Aspeed AST2500 which commonly > us

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-02 Thread kernel test robot
Hi Fabio, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Fabio-Aiuto/staging-rtl8723bs-remove-RT_TRACE-logs-in-core/20210402-180617 base: https://git.kernel.org/pub/scm/linux/kernel

[PATCH] fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE

2021-04-02 Thread zuoqilin1
From: zuoqilin Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: zuoqilin --- fs/debugfs/file.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 686e0ad..d670ca3 100644 --- a/fs/debugfs/file.c +

Re: [PATCH v2 0/1] charger-supply for max8997_charger

2021-04-02 Thread Sebastian Reichel
Hi, On Mon, Mar 29, 2021 at 02:37:47PM +, Timon Baetz wrote: > Based on the discussion from [0] add an optional DT property to retrieve > the regulator used for charging control in the max8997_charger driver. > > [0] https://lore.kernel.org/lkml/20210118124505.gg4...@sirena.org.uk/ > > Chang

[PATCH] nfc: s3fwrn5: remove unnecessary label

2021-04-02 Thread samirweng1979
From: wengjianfeng In function s3fwrn5_nci_post_setup, The variable ret is assigned to 0, then goto out label, but just return ret in out label, so we use return 0 to replace it. and other goto sentences are similar, we use return sentences to replace it and delete out label. Signed-off-by: weng

[PATCH] KVM: MMU: protect TDP MMU pages only down to required level

2021-04-02 Thread Paolo Bonzini
When using manual protection of dirty pages, it is not necessary to protect nested page tables down to the 4K level; instead KVM can protect only hugepages in order to split them lazily, and delay write protection at 4K-granularity until KVM_CLEAR_DIRTY_LOG. This was overlooked in the TDP MMU, so d

Re: [PATCH v2 00/10] KVM: Consolidate and optimize MMU notifiers

2021-04-02 Thread Paolo Bonzini
On 02/04/21 02:56, Sean Christopherson wrote: The end goal of this series is to optimize the MMU notifiers to take mmu_lock if and only if the notification is relevant to KVM, i.e. the hva range overlaps a memslot. Large VMs (hundreds of vCPUs) are very sensitive to mmu_lock being taken for wri

[PATCH 1/2] misc: vmw_vmci: explicitly initialize vmci_notify_bm_set_msg struct

2021-04-02 Thread Tetsuo Handa
KMSAN complains that the vmci_use_ppn64() == false path in vmci_dbell_register_notification_bitmap() left upper 32bits of bitmap_set_msg.bitmap_ppn64 member uninitialized. = BUG: KMSAN: uninit-value in kmsan_check_memory+0xd/0x10 CPU: 1 PID

[PATCH 2/2] misc: vmw_vmci: explicitly initialize vmci_datagram payload

2021-04-02 Thread Tetsuo Handa
KMSAN complains that vmci_check_host_caps() left the payload part of check_msg uninitialized. = BUG: KMSAN: uninit-value in kmsan_check_memory+0xd/0x10 CPU: 1 PID: 1 Comm: swapper/0 Tainted: GB 5.11.0-rc7+ #4 Hardware name

Re: [PATCH] fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqil...@163.com wrote: > From: zuoqilin Please use your full/real name. thanks, greg k-h

[PATCH] ath9k: Fix kernel NULL pointer dereference during ath_reset_internal()

2021-04-02 Thread Pali Rohár
Function ath9k_hw_reset() is dereferencing chan structure pointer, so it needs to be non-NULL pointer. Function ath9k_stop() already contains code which sets ah->curchan to valid non-NULL pointer prior calling ath9k_hw_reset() function. Add same code pattern also into ath_reset_internal() functio

Re: [PATCH v8 09/13] media: uapi: Add a control for HANTRO driver

2021-04-02 Thread Ezequiel Garcia
Hi Benjamin, Thanks for the patch. On Thu, 2021-04-01 at 17:59 +0200, Benjamin Gaignard wrote: > The HEVC HANTRO driver needs to know the number of bits to skip at > the beginning of the slice header. > That is a hardware specific requirement so create a dedicated control > that this purpose. >

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-02 Thread Andrew Lunn
> > Do you actually have a requirement for this? > > > Yes, the Marvell 88Q2112 1000Base-T1 PHY. But actually, I just recognize that > it > should be possible to just register it with the compatible string > "ethernet-phy-ieee802.3-c22" instead of "ethernet-phy-ieee802.3-c45", this > should result

Re: [PATCH net-next 1/2] net: stmmac: enable 2.5Gbps link speed

2021-04-02 Thread Andrew Lunn
On Fri, Apr 02, 2021 at 07:45:04AM +, Voon, Weifeng wrote: > > > + /* 2.5G mode only support 2500baseT full duplex only */ > > > + if (priv->plat->has_gmac4 && priv->plat->speed_2500_en) { > > > + phylink_set(mac_supported, 2500baseT_Full); > > > + phylink_set(mask, 10baseT_Half

[PATCH v2] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
From: Tamar Mashiah During PCH manufacturing a global reset has to be induced in order for configuration changes take affect upon following platform reset. This setting was commonly done by accessing PMC registers via /dev/mem but due to security concern /dev/mem access is much restricted, hence

[PATCH] kbuild: merge module sections under CONFIG_LD_DEAD_CODE_DATA_ELIMINATION too

2021-04-02 Thread Alexander Lobakin
When building with CONFIG_LD_DEAD_CODE_DATA_ELIMINATION, -fdata-sections and -ffunction-sections are being enabled by the top-level Makefile, and module section merging is also needed. Expand the ifdef (and the comment block) to cover that case too. Fixes: 6a3193cdd5e5 ("kbuild: lto: Merge module

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Fabio Aiuto
On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter > > *padapter, struct pkt_attrib *p > > if (pattrib->encrypt > 0) > > memcpy(patt

[PATCH 1/1] net: macb: restore cmp registers on resume path

2021-04-02 Thread Claudiu Beznea
Restore CMP screener registers on resume path. Fixes: c1e85c6ce57ef ("net: macb: save/restore the remaining registers and features") Signed-off-by: Claudiu Beznea --- drivers/net/ethernet/cadence/macb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/cadence

RE: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-02 Thread Liu, Yi L
Hi Jason, > From: Jason Gunthorpe > Sent: Thursday, April 1, 2021 7:54 PM > > On Thu, Apr 01, 2021 at 07:04:01AM +, Liu, Yi L wrote: > > > After reading your reply in https://lore.kernel.org/linux- > iommu/20210331123801.gd1463...@nvidia.com/#t > > So you mean /dev/ioasid FD is per-VM inste

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 02:40:46PM +0200, Fabio Aiuto wrote: > On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > > @@ -568,20 +561,11 @@ static s32 update_attrib_sec_info(struct adapter > > > *padapter, struct pkt_at

Re: [External] [PATCH v3 7/8] hugetlb: make free_huge_page irq safe

2021-04-02 Thread Muchun Song
On Wed, Mar 31, 2021 at 11:42 AM Mike Kravetz wrote: > > Commit c77c0a8ac4c5 ("mm/hugetlb: defer freeing of huge pages if in > non-task context") was added to address the issue of free_huge_page > being called from irq context. That commit hands off free_huge_page > processing to a workqueue if !

Re: (subset) [PATCH 0/4] Convert Cadence QSPI bindings to yaml

2021-04-02 Thread Nishanth Menon
On Fri, 26 Mar 2021 18:30:30 +0530, Pratyush Yadav wrote: > This series picks up Ramuthevar's effort on converting the Cadence QSPI > bindings to yaml [0]. During the conversion process, I discovered that > some TI device tree files were not using the compatible correctly. Those > are fixed in patc

Re: [PATCH 14/16] staging: rtl8723bs: remove all RT_TRACE logs in core/rtw_wlan_util.c

2021-04-02 Thread Fabio Aiuto
On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > > remove all RT_TRACE logs > > > > fix patch-related checkpatch issues > > > > Signed-off-by: Fabio Aiuto > > --- > >  .../staging/rtl8723bs/core/rtw_wlan_util.c| 26 +--

Re: [PATCH v4 1/3] sched/fair: Ignore percpu threads for imbalance pulls

2021-04-02 Thread Vincent Guittot
On Thu, 1 Apr 2021 at 21:30, Valentin Schneider wrote: > > From: Lingutla Chandrasekhar > > During load balance, LBF_SOME_PINNED will bet set if any candidate task > cannot be detached due to CPU affinity constraints. This can result in > setting env->sd->parent->sgc->group_imbalance, which can l

Re: [PATCH 01/16] staging: rtl8723bs: remove RT_TRACE logs in core/rtw_xmit.c

2021-04-02 Thread Fabio Aiuto
On Fri, Apr 02, 2021 at 02:47:10PM +0200, Greg KH wrote: > On Fri, Apr 02, 2021 at 02:40:46PM +0200, Fabio Aiuto wrote: > > On Fri, Apr 02, 2021 at 02:56:26PM +0300, Dan Carpenter wrote: > > > On Fri, Apr 02, 2021 at 12:01:21PM +0200, Fabio Aiuto wrote: > > > > @@ -568,20 +561,11 @@ static s32 upda

Re: [PATCH v4 2/3] sched/fair: Clean up active balance nr_balance_failed trickery

2021-04-02 Thread Vincent Guittot
On Thu, 1 Apr 2021 at 21:30, Valentin Schneider wrote: > > When triggering an active load balance, sd->nr_balance_failed is set to > such a value that any further can_migrate_task() using said sd will ignore > the output of task_hot(). > > This behaviour makes sense, as active load balance intenti

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-02 Thread Russell King - ARM Linux admin
On Fri, Apr 02, 2021 at 03:10:49AM +0200, Danilo Krummrich wrote: > On Thu, Apr 01, 2021 at 09:48:58AM +0100, Russell King - ARM Linux admin > wrote: > > Do you actually have a requirement for this? > > > Yes, the Marvell 88Q2112 1000Base-T1 PHY. But actually, I just recognize that > it > should

[PATCH] ARM: dts: at91: change the key code of the gpio key

2021-04-02 Thread nicolas.ferre
From: Ludovic Desroches Having a button code and not a key code causes issues with libinput. udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug within libinput. Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sam9x60ek.dts | 3

Re: [PATCH 2/2] staging:r8188eu: remove dummy handlers from OnAction()

2021-04-02 Thread Greg Kroah-Hartman
On Sun, Mar 28, 2021 at 07:33:25PM +0300, Ivan Safonov wrote: > on_action_spct() do nothing, because rtw_get_stainfo() has no side > effects. Other action handlers are trivial. > > Signed-off-by: Ivan Safonov Same here, wrong driver name :(

Re: [PATCH 1/2] staging:r8188eu: refactor OnAction(): use switch instead table lookup

2021-04-02 Thread Greg Kroah-Hartman
On Sun, Mar 28, 2021 at 07:33:23PM +0300, Ivan Safonov wrote: > The switch is easier to read and refactor. Your subject line is incorrect :(

Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-02 Thread Vincent Guittot
On Thu, 1 Apr 2021 at 21:30, Valentin Schneider wrote: > > During load-balance, groups classified as group_misfit_task are filtered > out if they do not pass > > group_smaller_max_cpu_capacity(, ); > > which itself employs fits_capacity() to compare the sgc->max_capacity of > both groups. > > Du

Re: [PATCH] alpha/kernel/traps: Use find_vma_intersection() in traps for setting si_code

2021-04-02 Thread Liam Howlett
* Michel Lespinasse [210401 16:25]: > You are correct that find_vma is insufficient for what's intended > here, and that find_vma_intersection fixes it. > > I'll let the arch maintainers speak of what the consequences of the > changed si_code would be - the bug has been here so long, that I would

Re: [PATCH v1 3/7] PCI: New Primary to Sideband (P2SB) bridge support library

2021-04-02 Thread Enrico Weigelt, metux IT consult
On 09.03.21 09:42, Henning Schild wrote: The device will respond to MMIO while being hidden. I am afraid nothing stops a collision, except for the assumption that the BIOS is always right and PCI devices never get remapped. But just guessing here. What could go wrong if it is remapped, except

Re: [PATCH -next] staging/speakup: Switch to kmemdup_nul()

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:21:11PM +0800, Yang Yingliang wrote: > Use kmemdup_nul() helper instead of open-coding to > simplify the code. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/accessibility/speakup/i18n.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deleti

Re: [PATCH] USB:ohci:fix ohci interruption problem

2021-04-02 Thread Greg KH
On Fri, Apr 02, 2021 at 05:27:59PM +0800, Longfang Liu wrote: > The operating method of the system entering S4 sleep mode: > echo disk > /sys/power/state > > When OHCI enters the S4 sleep state, the USB sleep process will call > check_root_hub_suspend() and ohci_bus_suspend() instead of > ohci_sus

[PATCH] genirq: reduce irqdebug bouncing cachelines

2021-04-02 Thread Nicholas Piggin
note_interrupt increments desc->irq_count for each interrupt even for percpu interrupt handlers, even when they are handled successfully. This causes cacheline bouncing and limits scalability. Instead of incrementing irq_count every time, only start incrementing it after seeing an unhandled irq, w

[PATCH] eeprom: at24: avoid adjusting offset for 24AA025E{48, 64}

2021-04-02 Thread Claudiu Beznea
Some EEPROMs could be used only for MAC storage. In this case the EEPROM areas where MACs resides could be modeled as NVMEM cells (directly via DT bindings) such that the already available networking infrastructure to read properly the MAC addresses (via of_get_mac_address()). Add "atmel,24mac02e4"

linux-kernel@vger.kernel.org

2021-04-02 Thread Matthew Wilcox
On Fri, Apr 02, 2021 at 04:13:05AM +0100, Matthew Wilcox wrote: > + for (;;) { > + xas_load(xas); > + if (!xas_is_node(xas)) > + break; > + xas_delete_node(xas); > + xas->xa_index -= XA_CHUNK_SIZE; > + if (xas->xa_i

Re: [PATCH] coda: Remove various instances of an unused variable 'outp'

2021-04-02 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yang-Li/coda-Remove-various-instances-of-an-unused-variable-outp/20210402-173111 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1678e493d530e7977cce34e59a86bb86f3c56

Re: [PATCH] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Enrico Weigelt, metux IT consult
On 01.04.21 23:31, Tomas Winkler wrote: Hi, During PCH manufacturing a global reset has to be induced in order for configuration changes take affect upon following platform reset. This setting was commonly done by accessing PMC registers via /dev/mem but due to security concern /dev/mem access

<    1   2   3   4   5   6   7   8   9   >