From: zuoqilin <zuoqi...@yulong.com> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: zuoqilin <zuoqi...@yulong.com> --- fs/debugfs/file.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 686e0ad..d670ca3 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -1045,7 +1045,7 @@ void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs, } EXPORT_SYMBOL_GPL(debugfs_print_regs32); -static int debugfs_show_regset32(struct seq_file *s, void *data) +static int regset32_show(struct seq_file *s, void *data) { struct debugfs_regset32 *regset = s->private; @@ -1060,17 +1060,7 @@ static int debugfs_show_regset32(struct seq_file *s, void *data) return 0; } -static int debugfs_open_regset32(struct inode *inode, struct file *file) -{ - return single_open(file, debugfs_show_regset32, inode->i_private); -} - -static const struct file_operations fops_regset32 = { - .open = debugfs_open_regset32, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(regset32); /** * debugfs_create_regset32 - create a debugfs file that returns register values @@ -1091,7 +1081,7 @@ void debugfs_create_regset32(const char *name, umode_t mode, struct dentry *parent, struct debugfs_regset32 *regset) { - debugfs_create_file(name, mode, parent, regset, &fops_regset32); + debugfs_create_file(name, mode, parent, regset, ®set32_fops); } EXPORT_SYMBOL_GPL(debugfs_create_regset32); -- 1.9.1