[PATCH] linux/spi: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct spi_transfer is declared twice. One is declared at 24th line. The blew one is not needed though. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/linux/spi/spi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index 592897fa

[PATCH net] net: udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-04-01 Thread Norman Maurer
From: Norman Maurer Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP

RE: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

2021-04-01 Thread Daejun Park
Hi, Can Guo > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c ... > > req->end_io_data = &wait; > - free_slot = req->tag; > WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs); I think this line should be removed. Thanks, Daejun

Re: [PATCH v5 2/5] powercap/drivers/dtpm: Create a registering system

2021-04-01 Thread Daniel Lezcano
On 01/04/2021 08:02, Greg KH wrote: > On Wed, Mar 31, 2021 at 10:46:48PM +0200, Daniel Lezcano wrote: >> >> Hi Greg, >> >> On 31/03/2021 20:06, Greg KH wrote: >>> On Wed, Mar 31, 2021 at 01:00:45PM +0200, Daniel Lezcano wrote: +struct dtpm *dtpm_lookup(const char *name); + +int dtpm_

Re: [PATCH] udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...)

2021-04-01 Thread Norman Maurer
> On 1. Apr 2021, at 02:18, David Ahern wrote: > > On 3/31/21 7:10 AM, Norman Maurer wrote: >> Friendly ping… >> >> As this missing change was most likely an oversight in the original commit I >> do think it should go into 5.12 and subsequently stable as well. That’s also >> the reason why

RE: [PATCH v3 06/10] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero

2021-04-01 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: Ritesh Harjani > Sent: Thursday, April 1, 2021 2:45 PM > Subject: Re: [PATCH v3 06/10] fsdax: Add dax_iomap_cow_copy() for > dax_iomap_zero > > On 21/03/19 09:52AM, Shiyang Ruan wrote: > > Punch hole on a reflinked file needs dax_copy_edge() too. Otherwise,

[PATCH] ext4: Delete redundant uptodate check for buffer

2021-04-01 Thread Shaokun Zhang
From: Yang Guo The buffer uptodate state has been checked in function set_buffer_uptodate, there is no need use buffer_uptodate before calling set_buffer_uptodate and delete it. Cc: "Theodore Ts'o" Cc: Andreas Dilger Signed-off-by: Yang Guo Signed-off-by: Shaokun Zhang --- fs/ext4/inode.c |

RE: [PATCH v3 05/10] fsdax: Replace mmap entry in case of CoW

2021-04-01 Thread ruansy.f...@fujitsu.com
> -Original Message- > From: Ritesh Harjani > Sent: Thursday, April 1, 2021 2:40 PM > Subject: Re: [PATCH v3 05/10] fsdax: Replace mmap entry in case of CoW > > On 21/03/19 09:52AM, Shiyang Ruan wrote: > > We replace the existing entry to the newly allocated one in case of CoW. > > Also

RE: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-01 Thread Liu, Yi L
Hi Jason, > From: Liu, Yi L > Sent: Thursday, April 1, 2021 12:39 PM > > > From: Jason Gunthorpe > > Sent: Wednesday, March 31, 2021 8:41 PM > > > > On Wed, Mar 31, 2021 at 07:38:36AM +, Liu, Yi L wrote: > > > > > The reason is /dev/ioasid FD is per-VM since the ioasid allocated to > > > th

Re: [PATCH v6 00/27] Memory Folios

2021-04-01 Thread Christoph Hellwig
On Wed, Mar 31, 2021 at 07:47:01PM +0100, Matthew Wilcox (Oracle) wrote: > - Mirror members of struct page (for pagecache / anon) into struct folio, >so (eg) you can use folio->mapping instead of folio->page.mapping Eww, why?

Re: [PATCH 7/7] devcoredump: fix kernel-doc warning

2021-04-01 Thread Johannes Berg
On Wed, 2021-03-31 at 18:26 -0500, Pierre-Louis Bossart wrote: > remove make W=1 warnings > > drivers/base/devcoredump.c:208: warning: > Function parameter or member 'data' not described in > 'devcd_free_sgtable' > > drivers/base/devcoredump.c:208: warning: > Excess function parameter 'table' des

Re: [PATCH] soundwire: qcom: wait for fifo space to be available before read/write

2021-04-01 Thread Vinod Koul
On 31-03-21, 18:00, Srinivas Kandagatla wrote: > If we write registers very fast we can endup in a situation where some > of the writes will be dropped without any notice. > > So wait for the fifo space to be available before reading/writing the > soundwire registers. > > Signed-off-by: Srinivas

[PATCH v5 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix

2021-04-01 Thread Maxime Chevallier
Add prefix for Techwell, Inc. Acked-by: Rob Herring Signed-off-by: Maxime Chevallier --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendo

[PATCH v5 0/3] media: i2c: Introduce driver for the TW9900 decoder

2021-04-01 Thread Maxime Chevallier
Hello everyone, This is the fifth version of the series adding support for the Techwell TW9900 multi standard decoder. It's a pretty simple decoder compared to the TW9910, since it doesn't have a built-in scaler/crop engine. this fifth version addresses reviews by Hans and Rob, with the notable a

[PATCH v5 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900

2021-04-01 Thread Maxime Chevallier
The Techwell TW9900 is a video decoder supporting multiple input standards, such as PAL, NTSC and SECAM, and outputs a BT.656 video signal. It's designed to be low-power, posesses some features such as a programmable comb-filter, and automatic input standard detection. Signed-off-by: Maxime Cheva

[PATCH v5 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder

2021-04-01 Thread Maxime Chevallier
The Techwell video decoder supports PAL, NTSC and SECAM input formats, and outputs a BT.656 signal. This commit adds support for this device, with basic support for NTSC and PAL, along with brightness and contrast controls. The TW9900 is capable of doing automatic standard detection, this is impl

[PATCH] include: net: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct ctl_table_header is declared twice. One is declared at 46th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/net/net_namespace.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h index

Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer

2021-04-01 Thread Greg Kroah-Hartman
On Wed, Mar 31, 2021 at 11:52:20PM -0700, Kees Cook wrote: > On Thu, Apr 01, 2021 at 07:16:56AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Mar 31, 2021 at 07:21:45PM -0700, Kees Cook wrote: > > > The sysfs interface to seq_file continues to be rather fragile > > > (seq_get_buf() should not be use

Re: [PATCH] misc: vmw_vmci: initialize payload passed to vmci_send_datagram()

2021-04-01 Thread Greg Kroah-Hartman
On Thu, Apr 01, 2021 at 03:53:02PM +0900, Tetsuo Handa wrote: > On 2021/04/01 15:18, Greg Kroah-Hartman wrote: > > On Thu, Apr 01, 2021 at 02:57:47PM +0900, Tetsuo Handa wrote: > >> KMSAN complains that the vmci_use_ppn64() == false path in > >> vmci_dbell_register_notification_bitmap() left upper

Re: [PATCH v3 07/10] iomap: Introduce iomap_apply2() for operations on two files

2021-04-01 Thread Ritesh Harjani
On 21/03/19 09:52AM, Shiyang Ruan wrote: > Some operations, such as comparing a range of data in two files under > fsdax mode, requires nested iomap_open()/iomap_end() on two file. Thus, > we introduce iomap_apply2() to accept arguments from two files and > iomap_actor2_t for actions on two files.

Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer

2021-04-01 Thread Michal Hocko
On Wed 31-03-21 19:21:45, Kees Cook wrote: > The sysfs interface to seq_file continues to be rather fragile > (seq_get_buf() should not be used outside of seq_file), as seen with > some recent exploits[1]. Move the seq_file buffer to the vmap area > (while retaining the accounting flag), since it h

[PATCH] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Ye Bin
As read_mmp_block return 1 when failed, so just pass retval to save_error_info. Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()") Reported-by: Liu Zhi Qiang Signed-off-by: Ye Bin --- fs/ext4/mmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v4 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

2021-04-01 Thread Can Guo
On 2021-04-01 14:44, Daejun Park wrote: Hi, Can Guo diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c ... req->end_io_data = &wait; - free_slot = req->tag; WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs); I think this line should be removed.

[PATCH] iommu/vt-d: Force to flush iotlb before creating superpage

2021-04-01 Thread Longpeng(Mike)
The translation caches may preserve obsolete data when the mapping size is changed, suppose the following sequence which can reveal the problem with high probability. 1.mmap(4GB,MAP_HUGETLB) 2. while (1) { (a)DMA MAP 0,0xa (b)DMA UNMAP 0,0xa (c)DMA MAP 0,0xc0

[rcu:for-mingo-rcu] BUILD SUCCESS ab6ad3dbddaf09f7df2d830766a2fb68d6ad669f

2021-04-01 Thread kernel test robot
330 x86_64 randconfig-a006-20210330 i386 randconfig-a004-20210330 i386 randconfig-a006-20210330 i386 randconfig-a003-20210330 i386 randconfig-a002-20210330 i386 randconfig-a001-20210330 i386 randconfig-a005-20210

linux-next: build warning after merge of the drm tree

2021-04-01 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' Introduced by commit cf41a8f1dc1e ("drm/i915: Finally remove obj->mm.

Re: [PATCH] tools: perf: util: Remove duplicate struct declaration

2021-04-01 Thread Namhyung Kim
Hello, On Thu, Apr 1, 2021 at 3:25 PM Wan Jiabing wrote: > > struct target is declared twice. One has been declared > at 21st line. Remove the duplicate. > > Signed-off-by: Wan Jiabing Acked-by: Namhyung Kim I think we can move all the forward declarations to the top (and sort them) as well.

[PATCH] crypto: api - fix coding style

2021-04-01 Thread Zhiqi Song
Fixed following checkpatch error: - do not use assignment in if condition Fixed following checkpatch warning: - prefer strscpy over strlcpy - delete repeated word Signed-off-by: Zhiqi Song --- crypto/api.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/

[PATCH] linux/bpf.h: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct btf_type is declared twice. One is declared at 35th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/linux/bpf.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 3625f019767d..2fd8e775a17e 1006

Re: [PATCH] soundwire: intel_init: test link->cdns

2021-04-01 Thread Vinod Koul
On 31-03-21, 09:02, Bard Liao wrote: > intel_link_probe() could return error and dev_get_drvdata() will return > null in such case. So we have to test link->cdns after > link->cdns = dev_get_drvdata(&ldev->auxdev.dev); > Otherwise, we will meet the "kernel NULL pointer dereference" error. This fai

Re: [PATCH] soundwire: stream: fix memory leak in stream config error path

2021-04-01 Thread Vinod Koul
On 31-03-21, 08:46, Bard Liao wrote: > From: Rander Wang > > When stream config is failed, master runtime will release all > slave runtime in the slave_rt_list, but slave runtime is not > added to the list at this time. This patch frees slave runtime > in the config error path to fix the memory l

Re: [PATCH v4 0/5] soundwire: add static port map support

2021-04-01 Thread Vinod Koul
On 15-03-21, 16:56, Srinivas Kandagatla wrote: > In some cases, SoundWire device ports are statically mapped to Controller > ports during design, however there is no way to expose this information > to the controller. Controllers like Qualcomm ones use this info to setup > static bandwidth paramete

Re: [PATCH 1/2] soundwire: add macro to selectively change error levels

2021-04-01 Thread Vinod Koul
On 31-03-21, 09:13, Bard Liao wrote: > From: Pierre-Louis Bossart > > We sometimes discard -ENODATA when reporting errors and lose all > traces of issues in the console log, add a macro to add use dev_dbg() > in such cases. > > Signed-off-by: Pierre-Louis Bossart > Reviewed-by: Rander Wang > R

Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer

2021-04-01 Thread Kees Cook
On Thu, Apr 01, 2021 at 09:10:05AM +0200, Greg Kroah-Hartman wrote: > On Wed, Mar 31, 2021 at 11:52:20PM -0700, Kees Cook wrote: > > On Thu, Apr 01, 2021 at 07:16:56AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Mar 31, 2021 at 07:21:45PM -0700, Kees Cook wrote: > > > > The sysfs interface to se

[tip:master] BUILD REGRESSION a0af5201360a0e33399d2b65b3874c27ac29432b

2021-04-01 Thread kernel test robot
0210330 x86_64 randconfig-a016-20210330 x86_64 randconfig-a013-20210330 x86_64 randconfig-a011-20210330 x86_64 randconfig-a004-20210401 x86_64 randconfig-a005-20210401 x86_64 randconfig-a003-20210401 x86_64 r

[PATCH] crypto: cbc - fix coding style

2021-04-01 Thread Zhiqi Song
Fixed following checkpatch error: - do not use assignment in if condition Signed-off-by: Zhiqi Song --- crypto/cbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/cbc.c b/crypto/cbc.c index 6c03e96..152d48d 100644 --- a/crypto/cbc.c +++ b/crypto/cbc.c @@ -140,7 +14

[PATCH v2] ext4: Fix ext4_error_err save negative errno into superblock

2021-04-01 Thread Ye Bin
As read_mmp_block return 1 when failed. read_mmp_block return -EIO when buffer isn't uptodate. Fixes: 54d3adbc29f0 ("ext4: save all error info in save_error_info() and drop ext4_set_errno()") Reported-by: Liu Zhi Qiang Signed-off-by: Ye Bin --- fs/ext4/mmp.c | 2 +- 1 file changed, 1 insertion(

linux-next: build warnings after merge of the drm tree

2021-04-01 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function pa

[PATCH 00/18] Implement RSASSA-PSS signature verification

2021-04-01 Thread Varad Gautam
Linux currently supports RSA PKCSv1.5 encoding scheme for signing / verification. This adds support for RSASSA PSS signature verification as described in RFC8017 [1]. Patch 1 extends the x509 certificate parser to unpack PSS signature parameters. Patches 2-8 pull out the common functions / struc

[Discussion] Uninitialized variable in wiz_mode_select()

2021-04-01 Thread Muhammad Usama Anjum
Hi, `mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP or PHY_TYPE_QSGMII. I've checked the dtsi (k3-j721e-common-proc- board.dts) and possible values of `lane_phy_type` are justPHY_TYPE_USB3 and PHY_TYPE_PCIE. If this is correct, the mode will remain uninitialized with garbage

Re: [PATCH] nvme: Export fast_io_fail_tmo to sysfs

2021-04-01 Thread Daniel Wagner
Hi Chaitanya, On Wed, Mar 31, 2021 at 08:34:31PM +, Chaitanya Kulkarni wrote: > > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > > Consider using octal permissions '0644'. > > For now keep the current style. Okay, I thought so too. I am just wondering if a patch fo

Re: [PATCH v2 2/3] drivers/tty/serial/8250: add DT property for aspeed vuart sirq polarity

2021-04-01 Thread Zev Weiss
On Thu, Apr 01, 2021 at 12:34:04AM CDT, Andrew Jeffery wrote: On Thu, 1 Apr 2021, at 15:48, Zev Weiss wrote: On Wed, Mar 31, 2021 at 11:15:44PM CDT, Joel Stanley wrote: >On Thu, 1 Apr 2021 at 00:57, Zev Weiss wrote: >> >> This provides a simple boolean to use instead of the deprecated >> aspe

Re: [PATCH v3] sysfs: Unconditionally use vmalloc for buffer

2021-04-01 Thread Kees Cook
On Thu, Apr 01, 2021 at 09:14:25AM +0200, Michal Hocko wrote: > On Wed 31-03-21 19:21:45, Kees Cook wrote: > > The sysfs interface to seq_file continues to be rather fragile > > (seq_get_buf() should not be used outside of seq_file), as seen with > > some recent exploits[1]. Move the seq_file buffe

Re: [Discussion] Uninitialized variable in wiz_mode_select()

2021-04-01 Thread Kishon Vijay Abraham I
Hi Usama, On 01/04/21 1:03 pm, Muhammad Usama Anjum wrote: > Hi, > > `mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP > or > PHY_TYPE_QSGMII. I've checked the dtsi (k3-j721e-common-proc- > board.dts) > and possible values of `lane_phy_type` are justPHY_TYPE_USB3 and > PHY_TY

[PATCH v5 1/2] scsi: ufs: Fix task management request completion timeout

2021-04-01 Thread Can Guo
ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()), but since blk_mq_tagset_busy_iter() only iterates over all reserved tags and requests which are not in IDLE state, ufshcd_compl_tm() never gets a chance to run. Thus, TMR always ends up with completion timeout. Fix it by ca

[PATCH v5 2/2] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

2021-04-01 Thread Can Guo
In __ufshcd_issue_tm_cmd(), it is not right to use hba->nutrs + req->tag as the Task Tag in one TMR UPIU. Directly use req->tag as the Task Tag. Fixes: e293313262d3 ("scsi: ufs: Fix broken task management command implementation") Reviewed-by: Bart Van Assche Signed-off-by: Can Guo --- drivers

Re: [Discussion] Uninitialized variable in wiz_mode_select()

2021-04-01 Thread Kishon Vijay Abraham I
Hi, On 01/04/21 1:08 pm, Kishon Vijay Abraham I wrote: > Hi Usama, > > On 01/04/21 1:03 pm, Muhammad Usama Anjum wrote: >> Hi, >> >> `mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP >> or >> PHY_TYPE_QSGMII. I've checked the dtsi (k3-j721e-common-proc- >> board.dts) >> and po

Re: [PATCH v6 14/24] iio: buffer: wrap all buffer attributes into iio_dev_attr

2021-04-01 Thread Marek Szyprowski
Hi On 15.02.2021 11:40, Alexandru Ardelean wrote: > This change wraps all buffer attributes into iio_dev_attr objects, and > assigns a reference to the IIO buffer they belong to. > > With the addition of multiple IIO buffers per one IIO device, we need a way > to know which IIO buffer is being ena

Re: [PATCH 1/1] tee: optee: do not check memref size on return from Secure World

2021-04-01 Thread Jens Wiklander
On Thu, Mar 25, 2021 at 3:18 PM Sumit Garg wrote: > > On Mon, 22 Mar 2021 at 16:11, Jerome Forissier via OP-TEE > wrote: > > > > When Secure World returns, it may have changed the size attribute of the > > memory references passed as [in/out] parameters. The GlobalPlatform TEE > > Internal Core A

Re: [PATCH v1 3/3] KEYS: trusted: Introduce support for NXP CAAM-based trusted keys

2021-04-01 Thread Ahmad Fatoum
Hello Jarkko, On 01.04.21 01:30, Jarkko Sakkinen wrote: >> Option (C) sounds reasonable to me but I would rather prefer an info >> message rather than warning as otherwise it would reflect that we are >> enforcing kernel RNG choice for a user to trust upon. > > I gave some though on this. > > I

Re: [PATCH v3 1/2] kunit: add a KUnit test for SLUB debugging functionality

2021-04-01 Thread Vlastimil Babka
On 3/31/21 10:51 AM, glit...@gmail.com wrote: > From: Oliver Glitta > > SLUB has resiliency_test() function which is hidden behind #ifdef > SLUB_RESILIENCY_TEST that is not part of Kconfig, so nobody > runs it. KUnit should be a proper replacement for it. > > Try changing byte in redzone after a

Re: [PATCH 01/18] X.509: Parse RSASSA-PSS style certificates

2021-04-01 Thread Varad Gautam
On 4/1/21 3:09 AM, Herbert Xu wrote: > On Tue, Mar 30, 2021 at 10:28:12PM +0200, Varad Gautam wrote: >> An X.509 wrapper for a RSASSA-PSS signature contains additional >> signature parameters over the PKCSv.15 encoding scheme. Extend the >> x509 parser to allow parsing RSASSA-PSS encoded certificat

Re: [PATCH -next v2] staging: greybus: camera: Switch to memdup_user_nul()

2021-04-01 Thread Dan Carpenter
On Thu, Apr 01, 2021 at 11:17:52AM +0800, Yang Yingliang wrote: > Use memdup_user_nul() helper instead of open-coding to > simplify the code. > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang > --- > drivers/staging/greybus/camera.c | 13 +++-- > 1 file changed, 3 insertions(+

Re: [PATCH v14 1/2] scsi: ufs: Enable power management for wlun

2021-04-01 Thread Adrian Hunter
On 1/04/21 4:40 am, Asutosh Das (asd) wrote: > On 3/31/2021 11:19 AM, Adrian Hunter wrote: >> On 31/03/21 1:31 am, Asutosh Das wrote: >>> During runtime-suspend of ufs host, the scsi devices are >>> already suspended and so are the queues associated with them. >>> But the ufs host sends SSU (START_

Re: [PATCH 3/4] USB: serial: add support for multi-interface functions

2021-04-01 Thread Johan Hovold
On Wed, Mar 31, 2021 at 01:21:15PM +0200, Oliver Neukum wrote: > Am Mittwoch, den 31.03.2021, 09:08 +0200 schrieb Oliver Neukum: > > Am Dienstag, den 30.03.2021, 17:22 +0200 schrieb Johan Hovold: > > > On Tue, Mar 30, 2021 at 04:44:32PM +0200, Oliver Neukum wrote: > > > > Am Dienstag, den 30.03.202

Re: [PATCH -next v2] staging: greybus: camera: Switch to memdup_user_nul()

2021-04-01 Thread Dan Carpenter
On Thu, Apr 01, 2021 at 10:43:32AM +0300, Dan Carpenter wrote: > On Thu, Apr 01, 2021 at 11:17:52AM +0800, Yang Yingliang wrote: > > Use memdup_user_nul() helper instead of open-coding to > > simplify the code. > > > > Reported-by: Hulk Robot > > Signed-off-by: Yang Yingliang > > --- > > driver

Re: [PATCH net-next v1 3/3] net: fec: add basic selftest support

2021-04-01 Thread Oleksij Rempel
On Wed, Mar 31, 2021 at 02:27:19PM +0200, Andrew Lunn wrote: > On Tue, Mar 30, 2021 at 03:54:07PM +0200, Oleksij Rempel wrote: > > Port some parts of the stmmac selftest to the FEC. This patch was tested > > on iMX6DL. > > With this tests it is possible to detect some basic issues like: > > - MAC l

[PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static

2021-04-01 Thread Zucheng Zheng
symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c, so this commit marks it static. Signed-off-by: Zucheng Zheng --- drivers/tty/serial/8250/8250_bcm7271.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/

Re: [PATCH -next] i2c: gpio: use DEFINE_SPINLOCK() for spinlock

2021-04-01 Thread Dan Carpenter
On Thu, Apr 01, 2021 at 11:38:30AM +0800, chenlifu wrote: > Kindly pinging ... > > Best Regards, > Chen Lifu > > 在 2021/3/27 17:52, Chen Lifu 写道: It's to early to start asking for a response. Please wait at least two weeks. (Probably four weeks if the merge window was open). regards, dan carp

Re: [PATCH v6 4/7] pwm: pca9685: Support staggered output ON times

2021-04-01 Thread Clemens Gruber
Hi Thierry, On Wed, Mar 31, 2021 at 06:21:32PM +0200, Thierry Reding wrote: > On Wed, Mar 31, 2021 at 02:26:14PM +0200, Clemens Gruber wrote: > > On Mon, Mar 29, 2021 at 08:02:06PM +0200, Uwe Kleine-König wrote: > > > On Mon, Mar 29, 2021 at 07:16:38PM +0200, Clemens Gruber wrote: > > > > On Mon,

Re: [PATCH] psi: allow unprivileged users with CAP_SYS_RESOURCE to write psi files

2021-04-01 Thread Kees Cook
On Wed, Mar 31, 2021 at 11:36:28PM -0500, Eric W. Biederman wrote: > Josh Hunt writes: > > > Currently only root can write files under /proc/pressure. Relax this to > > allow tasks running as unprivileged users with CAP_SYS_RESOURCE to be > > able to write to these files. > > The test for CAP_SY

[PATCH] fs: cifs: Remove unnecessary struct declaration

2021-04-01 Thread Wan Jiabing
struct cifs_readdata is declared twice. One is declared at 208th line. And struct cifs_readdata is defined blew. The declaration here is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- fs/cifs/cifsglob.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/cifs/cifsglob.h b/f

[PATCH] cifsd: fix memory leak when loop ends

2021-04-01 Thread Muhammad Usama Anjum
Memory is being allocated and if veto_list is zero, the loop breaks without cleaning up the allocated memory. In this patch, the length check has been moved before allocation. If loop breaks, the memory isn't allocated in the first place. Thus the memory is being protected from leaking. Signed-off

Re: [PATCH v9 0/6] ARM: STM32: add art-pi(stm32h750xbh6) board support

2021-04-01 Thread Alexandre TORGUE
Hi Dillon On 3/31/21 10:28 AM, dillon.min...@gmail.com wrote: From: dillon min This patchset intend to add art-pi board support, this board developed by rt-thread(https://www.rt-thread.org/). Board resources: 8MiB QSPI flash 16MiB SPI flash 32MiB SDRAM AP6212 wifi,bt,fm comb sw context: - as

Re: [PATCH v2 00/21] ipmi: Allow raw access to KCS devices

2021-04-01 Thread Zev Weiss
On Fri, Mar 19, 2021 at 01:19:30AM CDT, Andrew Jeffery wrote: >Hello, > >This series is a bit of a mix of things, but its primary purpose is to >expose BMC KCS IPMI devices to userspace in a way that enables userspace >to talk to host firmware using protocols that are not IPMI. > >v1 can be found h

Re: [PATCH] USB: serial: iuu_phoenix: remove redundant variable 'error'

2021-04-01 Thread Johan Hovold
On Sat, Mar 27, 2021 at 11:27:44PM +, Colin King wrote: > From: Colin Ian King > > The variable error is initialized to 0 and is set to 1 this > value is never read as it is on an immediate return path. The > only read of error is to check it is 0 and this check is always > true at that point

Re: [PATCH v2] powerpc/traps: Enhance readability for trap types

2021-04-01 Thread Nicholas Piggin
Excerpts from Michael Ellerman's message of April 1, 2021 12:39 pm: > Segher Boessenkool writes: >> On Wed, Mar 31, 2021 at 08:58:17PM +1100, Michael Ellerman wrote: >>> So perhaps: >>> >>> EXC_SYSTEM_RESET >>> EXC_MACHINE_CHECK >>> EXC_DATA_STORAGE >>> EXC_DATA_SEGMENT >>> EXC_INST_STO

Re: [PATCH] init: add support for zstd compressed modules

2021-04-01 Thread torvic9
Thanks Piotr, good work! Question: Is `-T0` really faster in this particular case than the default `-T1`? Are modules installed sequentially? I also saw that Masahiro did some work on modules_install, moving MODULE_COMPRESS from the base Makefile to scripts/Makefile.modinst, so perhaps this shou

[PATCH] fs: btrfs: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct btrfs_inode is declared twice. One is declared at 67th line. The blew declaration is not needed. Remove the duplicate. struct btrfs_fs_info should be declared in the forward declarations. Move it to the forward declarations. Signed-off-by: Wan Jiabing --- fs/btrfs/extent_io.h | 4 +--- 1

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Lee Jones
On Wed, 31 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > wrote: > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > > wrote: > > ... > > > > > + return 24000; > > > > >

Re: [PATCH] binder: tell userspace to dump current backtrace when detecting oneway spamming

2021-04-01 Thread Hang Lu
On 3/31/2021 3:44 PM, Greg KH wrote: > On Wed, Mar 31, 2021 at 03:34:16PM +0800, Hang Lu wrote: >> When async binder buffer got exhausted, some normal oneway transaction >> will also be discarded and finally caused system/app stop. By that time, >> the binder debug information we dump may not relev

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

2021-04-01 Thread Matthias Schiffer
On Thu, 2021-04-01 at 09:04 +0100, Lee Jones wrote: > On Wed, 31 Mar 2021, Andy Shevchenko wrote: > > > On Wed, Mar 31, 2021 at 4:33 PM Matthias Schiffer > > wrote: > > > On Wed, 2021-03-31 at 15:37 +0300, Andy Shevchenko wrote: > > > > On Wed, Mar 31, 2021 at 2:38 PM Matthias Schiffer > > > > w

Re: [PATCH 0/4] USB: serial: add support for multi-interface functions

2021-04-01 Thread Johan Hovold
On Tue, Mar 30, 2021 at 04:50:02PM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 30, 2021 at 04:38:16PM +0200, Johan Hovold wrote: > > A single USB function can be implemented using a group of interfaces and > > this is for example commonly used for Communication Class devices. > > > > This s

Re: [PATCH v9 0/6] ARM: STM32: add art-pi(stm32h750xbh6) board support

2021-04-01 Thread dillon min
On Thu, Apr 1, 2021 at 4:00 PM Alexandre TORGUE wrote: > > Hi Dillon > > On 3/31/21 10:28 AM, dillon.min...@gmail.com wrote: > > From: dillon min > > > > This patchset intend to add art-pi board support, this board developed > > by rt-thread(https://www.rt-thread.org/). > > > > Board resources: >

[RFC] ext4: Fix fs can't panic when abort by user

2021-04-01 Thread Ye Bin
Test steps: 1. mount /dev/sda -o errors=panic test 2. mount /dev/sda -o remount,ro test 3. mount /dev/sda -o remount,abort test Before 014c9caa29d3 not been merged there will trigger panic. But 014c9caa29d3 change this behavior. Fixes: 014c9caa29d3 ("ext4: make ext4_abort() use __ext4_error()") S

Re: [PATCH v6] RISC-V: enable XIP

2021-04-01 Thread Alex Ghiti
Hi, Le 3/30/21 à 4:04 PM, Alex Ghiti a écrit : Le 3/30/21 à 3:33 PM, Palmer Dabbelt a écrit : On Tue, 30 Mar 2021 11:39:10 PDT (-0700), a...@ghiti.fr wrote: Le 3/30/21 à 2:26 AM, Vitaly Wool a écrit : On Tue, Mar 30, 2021 at 8:23 AM Palmer Dabbelt wrote: On Sun, 21 Mar 2021 17:12:15 PDT

RE: [PATCH] cifsd: fix memory leak when loop ends

2021-04-01 Thread Namjae Jeon
> > Memory is being allocated and if veto_list is zero, the loop breaks without > cleaning up the allocated > memory. In this patch, the length check has been moved before allocation. If > loop breaks, the memory > isn't allocated in the first place. Thus the memory is being protected from > le

[PATCH] drm/drm_internal.h: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct drm_gem_object is declared twice. One is declared at 40th line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/drm_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.

Re: [PATCH -next] ACPI: processor: Fix a prepocessor warning

2021-04-01 Thread Vitaly Kuznetsov
Shixin Liu writes: > When compiling with defconfig on x86_64, I got a warning: > > drivers/acpi/processor_idle.c: In function ‘acpi_idle_play_dead’: > drivers/acpi/processor_idle.c:542:15: warning: extra tokens at end of #ifdef > directive > 542 | #ifdef defined(CONFIG_X86) && defined(CONFIG_H

Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC

2021-04-01 Thread schowdhu
On 2021-03-30 01:04, Stephen Boyd wrote: Quoting Souradeep Chowdhury (2021-03-25 01:02:32) diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml new file mode 100644 index 000..c6e0a9c --- /dev/null +++ b/Documentation

Re: [linux-sunxi] [PATCH] arm64: dts: allwinner: h6: beelink-gs1: Remove ext. 32 kHz osc reference

2021-04-01 Thread Maxime Ripard
On Wed, Mar 31, 2021 at 03:43:37PM +0200, Clément Péron wrote: > Hi Jernej, > > On Tue, 30 Mar 2021 at 20:42, Jernej Skrabec wrote: > > > > Although every Beelink GS1 seems to have external 32768 Hz oscillator, > > it works only on one from four tested. There are more reports of RTC > > issues el

Re: [PATCH v2] nvme-tcp: Check if request has started before processing it

2021-04-01 Thread Sagi Grimberg
request tag can't be zero? I forget... Of course it can. But the reserved tags are before the normal tags, so 0 would be a reserved tag for nvme. Right.

Re: [PATCH v6 14/24] iio: buffer: wrap all buffer attributes into iio_dev_attr

2021-04-01 Thread Jonathan Cameron
On Thu, 1 Apr 2021 09:39:47 +0200 Marek Szyprowski wrote: > Hi > > On 15.02.2021 11:40, Alexandru Ardelean wrote: > > This change wraps all buffer attributes into iio_dev_attr objects, and > > assigns a reference to the IIO buffer they belong to. > > > > With the addition of multiple IIO buffers

Re: [PATCH 4/4] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml

2021-04-01 Thread Vignesh Raghavendra
On 3/29/21 11:52 PM, Pratyush Yadav wrote: >>> + cdns,fifo-depth: >>> +description: >>> + Size of the data FIFO in words. >>> +$ref: "/schemas/types.yaml#/definitions/uint32" >>> +enum: [ 128, 256 ] >>> +default: 128 >>> + >>> + cdns,fifo-width: >>> +$ref: /schemas/typ

[PATCH v2] binder: tell userspace to dump current backtrace when detecting oneway spamming

2021-04-01 Thread Hang Lu
When async binder buffer got exhausted, some normal oneway transaction will also be discarded and finally caused system/app stop. By that time, the binder debug information we dump may not relevant to the root cause. And this issue is difficult to debug if without the backtrace of thread sending sp

Re: [PATCH v8 3/6] stack: Optionally randomize kernel stack offset each syscall

2021-04-01 Thread Will Deacon
On Tue, Mar 30, 2021 at 01:57:47PM -0700, Kees Cook wrote: > diff --git a/include/linux/randomize_kstack.h > b/include/linux/randomize_kstack.h > new file mode 100644 > index ..351520803006 > --- /dev/null > +++ b/include/linux/randomize_kstack.h > @@ -0,0 +1,55 @@ > +/* SPDX-License-I

Re: [PATCH] clocksource/arm_arch_timer: add __ro_after_init and __init

2021-04-01 Thread Marc Zyngier
On Tue, 30 Mar 2021 07:04:44 +0100, Jisheng Zhang wrote: > > Some functions are not needed after booting, so mark them as __init > to move them to the .init section. > > Some global variables are never modified after init, so can be > __ro_after_init. > > Signed-off-by: Jisheng Zhang Acked-by

Re: [PATCH v7 5/6] arm64: entry: Enable random_kstack_offset support

2021-04-01 Thread Will Deacon
On Fri, Mar 19, 2021 at 02:28:34PM -0700, Kees Cook wrote: > Allow for a randomized stack offset on a per-syscall basis, with roughly > 5 bits of entropy. (And include AAPCS rationale AAPCS thanks to Mark > Rutland.) > > In order to avoid unconditional stack canaries on syscall entry (due to > the

linux-next: Tree for Apr 1

2021-04-01 Thread Stephen Rothwell
Hi all, News: there will be no linux-next release tomorrow or next Monday. Changes since 20210331: The mediatek tree gained a conflict against the imx-mxs tree. The drm-intel tree gained a conflict against the drm tree. Non-merge commits (relative to Linus' tree): 8329 8117 files changed, 470

Re: [PATCH 05/12] lib: extend the scope of small_const_nbits() macro

2021-04-01 Thread Andy Shevchenko
On Thu, Apr 1, 2021 at 3:41 AM Yury Norov wrote: > > find_bit would also benefit from small_const_nbits() optimizations. > The detailed comment is provided by Rasmus Villemoes. Thanks, now it looks good! Acked-by: Andy Shevchenko > Suggested-by: Rasmus Villemoes > Signed-off-by: Yury Norov >

Re: [PATCH 07/12] lib: inline _find_next_bit() wrappers

2021-04-01 Thread Andy Shevchenko
On Thu, Apr 1, 2021 at 3:42 AM Yury Norov wrote: > > lib/find_bit.c declares five single-line wrappers for _find_next_bit(). > We may turn those wrappers to inline functions. It eliminates unneeded > function calls and opens room for compile-time optimizations. Acked-by: Andy Shevchenko > Signe

Re: [PATCH v9 0/6] Optionally randomize kernel stack offset each syscall

2021-04-01 Thread Will Deacon
Hi Kees, On Wed, Mar 31, 2021 at 01:54:52PM -0700, Kees Cook wrote: > Hi Will (and Mark and Catalin), > > Can you take this via the arm64 tree for v5.13 please? Thomas has added > his Reviewed-by, so it only leaves arm64's. :) Sorry, these got mixed up in my inbox so I just replied to v7 and v8

Re: [RFC] NUMA balancing: reduce TLB flush via delaying mapping on hint page fault

2021-04-01 Thread Mel Gorman
On Wed, Mar 31, 2021 at 09:36:04AM -0700, Nadav Amit wrote: > > > > On Mar 31, 2021, at 6:16 AM, Mel Gorman wrote: > > > > On Wed, Mar 31, 2021 at 07:20:09PM +0800, Huang, Ying wrote: > >> Mel Gorman writes: > >> > >>> On Mon, Mar 29, 2021 at 02:26:51PM +0800, Huang Ying wrote: > For NUM

Re: [PATCH v5 2/5] phy: Add LVDS configuration options

2021-04-01 Thread Liu Ying
Hi Kishon, First of all, thanks for your review. On Wed, 2021-03-31 at 19:02 +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 25/03/21 2:30 pm, Liu Ying wrote: > > This patch allows LVDS PHYs to be configured through > > the generic functions and through a custom structure > > added to the gene

[PATCH] net: smc: Remove repeated struct declaration

2021-04-01 Thread Wan Jiabing
struct smc_clc_msg_local is declared twice. One is declared at 301st line. The blew one is not needed. Remove the duplicate. Signed-off-by: Wan Jiabing --- net/smc/smc_core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/smc/smc_core.h b/net/smc/smc_core.h index e8e448771f85..6d6fd1397c

Re: [RESEND PATCH v4 1/2] dt-bindings: drm/bridge: anx7625: Add power supplies

2021-04-01 Thread Robert Foss
Hey Hsin-Yi, Thanks for the reminder, just merged the series. https://cgit.freedesktop.org/drm/drm-misc/commit/?id=2f240cdb23e9cde551d99c77f4e60062188d8d81 On Thu, 1 Apr 2021 at 07:32, Hsin-Yi Wang wrote: > > anx7625 requires 3 power supply regulators. > > Signed-off-by: Hsin-Yi Wang > Reviewe

Re: Fix hibernation in FIPS mode?

2021-04-01 Thread Ard Biesheuvel
On Tue, 30 Mar 2021 at 21:56, Simo Sorce wrote: > > On Tue, 2021-03-30 at 21:45 +0200, Ard Biesheuvel wrote: > > On Tue, 30 Mar 2021 at 20:05, Simo Sorce wrote: > > > On Tue, 2021-03-30 at 16:46 +0200, Rafael J. Wysocki wrote: > > > > On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui wrote: > > > > >

Re: [PATCH 09/12] lib: add fast path for find_next_*_bit()

2021-04-01 Thread Andy Shevchenko
On Thu, Apr 1, 2021 at 3:41 AM Yury Norov wrote: > > Similarly to bitmap functions, find_next_*_bit() users will benefit > if we'll handle a case of bitmaps that fit into a single word inline. > In the very best case, the compiler may replace a function call with > a few instructions. > > This is

linux-next: Fixes tag needs some work in the soundwire tree

2021-04-01 Thread Stephen Rothwell
Hi all, In commit 187c59cdcfe9 ("soundwire: stream: fix memory leak in stream config error path") Fixes tag Fixes: bbe7379d8040a ("soundwire: Add support for SoundWire stream management") has these problem(s): - Subject does not match target commit subject Just use git log

Re: [PATCH 2/2] net: mdio: support c45 peripherals on c22 busses

2021-04-01 Thread Russell King - ARM Linux admin
On Thu, Apr 01, 2021 at 03:23:05AM +0200, danilokrummr...@dk-develop.de wrote: > On 2021-03-31 20:35, Russell King - ARM Linux admin wrote: > > On Wed, Mar 31, 2021 at 07:58:33PM +0200, danilokrummr...@dk-develop.de > > wrote: > > > For this cited change the only thing happening is that if > > > ge

  1   2   3   4   5   6   7   8   9   10   >