Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

2020-08-27 Thread Alex Dewar
On Wed, Aug 26, 2020 at 08:41:20PM -0500, Gustavo A. R. Silva wrote: > On Wed, Aug 26, 2020 at 09:11:49PM -0300, Jason Gunthorpe wrote: > > On Wed, Aug 26, 2020 at 02:18:59PM -0500, Gustavo A. R. Silva wrote: > > > Hi, > > > > > > On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote

Re: [PATCH 26/35] kasan, arm64: Enable TBI EL1

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:08PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 152d74f2cc9c..6880ddaa5144 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -38,7 +38,7 @@ > /* PTWs cacheable, inner/outer WBWA */ > #define T

Re: [EXT] Re: [PATCH] edac: nxp: Add L1 and L2 error detection for A53 and A72 cores

2020-08-27 Thread Borislav Petkov
On Wed, Aug 26, 2020 at 03:03:15AM +, Alison Wang wrote: > [Alison] I have a look at this patch. This patch doesn't complete all > the functions in my patch. Yep, but pls work together to see if a single driver can support your hw too. > It is just to report errors, but error injection functi

Re: [PATCH 28/35] kasan: define KASAN_GRANULE_SIZE for HW_TAGS

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:10PM +0200, Andrey Konovalov wrote: > Hardware tag-based KASAN has granules of MTE_GRANULE_SIZE. Define > KASAN_GRANULE_SIZE to MTE_GRANULE_SIZE for CONFIG_KASAN_HW_TAGS. > > Signed-off-by: Andrey Konovalov > --- > mm/kasan/kasan.h | 6 ++ > 1 file changed, 6 in

Re: [PATCH 21/35] arm64: mte: Add in-kernel tag fault handler

2020-08-27 Thread Vincenzo Frascino
On 8/27/20 10:54 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:03PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c >> index 5e832b3387f1..c62c8ba85c0e 100644 >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -33,6 +33,7

Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes

2020-08-27 Thread Ard Biesheuvel
On Thu, 27 Aug 2020 at 11:20, Arnd Bergmann wrote: > > On Thu, Aug 27, 2020 at 10:42 AM Ard Biesheuvel wrote: > > > > In that case, I suppose we should simply disable instrumentation for > > chacha_permute()? It is a straight-forward arithmetic transformation > > on a u32[16] array, where ubsan h

Re: [PATCH 22/35] arm64: mte: Enable in-kernel MTE

2020-08-27 Thread Vincenzo Frascino
On 8/27/20 11:01 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:04PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c >> index 4d3abb51f7d4..4d94af19d8f6 100644 >> --- a/arch/arm64/kernel/cpufeature.c >> +++ b/arch/arm64/kern

Re: [PATCH 01/16] wireless: ath5k: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Allen Pais
Hi, > > Allen Pais wrote: > > > In preparation for unconditionally passing the > > struct tasklet_struct pointer to all tasklet > > callbacks, switch to using the new tasklet_setup() > > and from_tasklet() to pass the tasklet pointer explicitly. > > > > Signed-off-by: Romain Perier > > Signed-off

Re: drivers/net/wireless/realtek/rtw88/rtw8821c.c:71:8: warning: type qualifiers ignored on function return type

2020-08-27 Thread Kalle Valo
c5c0f82a434cefb41c57844e rtw88: 8821c: Add 8821CE to > Kconfig and Makefile > date: 6 weeks ago > config: arm-randconfig-r012-20200827 (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget > https://raw.gith

Re: [PATCH 31/35] kasan, arm64: implement HW_TAGS runtime

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:13PM +0200, Andrey Konovalov wrote: > diff --git a/mm/kasan/mte.c b/mm/kasan/mte.c > new file mode 100644 > index ..43b7d74161e5 > --- /dev/null > +++ b/mm/kasan/mte.c Since this is an arm64-specific kasan backend, I wonder whether it makes more sense to k

Re: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

2020-08-27 Thread Kalle Valo
+ linux-wireless kernel test robot writes: > Hi Zong-Zhe, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > commit: 72f256c2b948622cc45ff8bc0456dd6039d8fe36 rtw88

Re: [PATCH 32/35] kasan, arm64: print report from tag fault handler

2020-08-27 Thread Catalin Marinas
On Fri, Aug 14, 2020 at 07:27:14PM +0200, Andrey Konovalov wrote: > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > index c62c8ba85c0e..cf00b3942564 100644 > --- a/arch/arm64/mm/fault.c > +++ b/arch/arm64/mm/fault.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include

Re: [net-next v5 1/2] seg6: inherit DSCP of inner IPv4 packets

2020-08-27 Thread Ahmed Abdelsalam
On 26/08/2020 21:41, David Ahern wrote: On 8/26/20 6:12 AM, Ahmed Abdelsalam wrote: On 26/08/2020 02:45, David Ahern wrote: On 8/25/20 5:45 PM, Ahmed Abdelsalam wrote: Hi David The seg6 encap is implemented through the seg6_lwt rather than seg6_local_lwt. ok. I don't know the seg6 code

Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 12:27 +0300, Kalle Valo wrote: > Larry Finger writes: > > On 7/27/20 9:52 AM, Joe Perches wrote: > > > On Mon, 2020-07-27 at 09:04 +, Pkshih wrote: > > > > So, I think you would like to have parenthesis intentionally. > > > > If so, > > > > test1 ? : (test2 ? :) > > > > w

Re: [PATCH 3/5] Add manpage for fspick(2)

2020-08-27 Thread Michael Kerrisk (man-pages)
Hello David, On 8/24/20 2:24 PM, David Howells wrote: > Add a manual page to document the fspick() system call. > > Signed-off-by: David Howells > --- > > man2/fspick.2 | 180 > + > 1 file changed, 180 insertions(+) > create mode 10064

Re: [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable property

2020-08-27 Thread Peter Chen
On 20-08-25 15:00:58, Roger Quadros wrote: > Controller version 0x0002450D has USB2 PHY RX sensitivity issues > that needs to be worked around by enabling phyrst-a-enable bit > in PHYRST_CFG register. > > There is no way to distinguish between the controller version > before the device controller

Re: [PATCH] lib: kunit: add list_sort test conversion to KUnit

2020-08-27 Thread Vitor Massaru Iha
On Thu, Aug 27, 2020 at 7:23 AM Marco Elver wrote: > > On Wed, Jul 29, 2020 at 04:23PM -0300, Vitor Massaru Iha wrote: > > This adds the conversion of the runtime tests of test_list_sort, > > from `lib/test_list_sort.c` to KUnit tests. > > > > Please apply this commit first (linux-kselftest/kunit-

Re: [PATCH] drm: Parse Colorimetry data block from EDID

2020-08-27 Thread Ville Syrjälä
On Wed, Aug 26, 2020 at 10:23:28PM +0800, Algea Cao wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. And what exactly do you want to do with that data? > > Signed-off-by: Algea Cao > --- > > drivers/gpu/drm/drm_edid.c

Re: [PATCH 20/35] arm64: mte: Add in-kernel MTE helpers

2020-08-27 Thread Vincenzo Frascino
On 8/27/20 12:10 PM, Catalin Marinas wrote: > On Thu, Aug 27, 2020 at 11:31:56AM +0100, Vincenzo Frascino wrote: >> On 8/27/20 10:38 AM, Catalin Marinas wrote: >>> On Fri, Aug 14, 2020 at 07:27:02PM +0200, Andrey Konovalov wrote: +void * __must_check mte_set_mem_tag_range(void *addr, size_t

Re: [PATCH v2 05/10] dt-bindings: renesas,rcar-dmac: Document r8a7742 support

2020-08-27 Thread Lad, Prabhakar
Hi Vinod, On Sun, May 3, 2020 at 10:47 PM Lad Prabhakar wrote: > > Renesas RZ/G SoC also have the R-Car gen2/3 compatible DMA controllers. > Document RZ/G1H (also known as R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > > Reviewed-by: Geert Uytt

[PATCH] net: Fix some comments

2020-08-27 Thread Miaohe Lin
Fix some comments, including wrong function name, duplicated word and so on. Signed-off-by: Miaohe Lin --- include/linux/skbuff.h | 4 ++-- include/uapi/linux/in.h | 2 +- net/core/sock.c | 2 +- net/ipv4/raw.c | 2 +- net/l3mdev/l3mdev.c | 2 +- net/socket.c| 4

Re: [PATCH 3/3] usb: cdns3: Enable workaround for USB2.0 PHY Rx compliance test PHY lockup

2020-08-27 Thread Peter Chen
On 20-08-25 15:00:59, Roger Quadros wrote: > From: Pawel Laszczak > > USB2.0 PHY hangs in Rx Compliance test when the incoming packet > amplitude is varied below and above the Squelch Level of > Receiver during the active packet multiple times. > > Version 1 of the controller allows PHY to be re

Re: [PATCH 01/16] iio: accel: bma180: Simplify with dev_err_probe()

2020-08-27 Thread Krzysztof Kozlowski
On Thu, Aug 27, 2020 at 12:26:05PM +0100, Jonathan Cameron wrote: > On Wed, 26 Aug 2020 16:51:38 +0200 > Krzysztof Kozlowski wrote: > > > Common pattern of handling deferred probe can be simplified with > > dev_err_probe(). Less code and also it prints the error value. > > > > Signed-off-by: Kr

Re: [PATCH 25/35] kasan: introduce CONFIG_KASAN_HW_TAGS

2020-08-27 Thread Vincenzo Frascino
Hi Andrey, On 8/14/20 6:27 PM, Andrey Konovalov wrote: > +config·KASAN_HW_TAGS > +» bool·"Hardware·tag-based·mode" > +» depends·on·HAVE_ARCH_KASAN_HW_TAGS > +» depends·on·SLUB > +» help > +» ··Enables·hardware·tag-based·KASAN·mode. > + > +» ··This·mode·requires·both·Memory·Tagging·Extension·and·To

Re: [PATCH][next] ath11k: fix error check on return from call to ath11k_core_firmware_request

2020-08-27 Thread Kalle Valo
Colin King wrote: > From: Colin Ian King > > The call to ath11k_core_firmware_request is returning a pointer that > can be set to an error code, however, this is not being checked. > Instead ret is being incorrecly checked for the error return. Fix the > error checking. > > Addresses-Coverity:

[PATCH v2 00/15] kprobes: Unify kretprobe trampoline handlers

2020-08-27 Thread Masami Hiramatsu
Hi, Here is the 2nd version of the series to unify the kretprobe trampoline handler implementation across all architectures which are currently kprobes supported. Previous version is here; https://lkml.kernel.org/r/159844957216.510284.17683703701627367133.stgit@devnote2 This series removes the

Re: [PATCH 20/35] arm64: mte: Add in-kernel MTE helpers

2020-08-27 Thread Catalin Marinas
On Thu, Aug 27, 2020 at 11:31:56AM +0100, Vincenzo Frascino wrote: > On 8/27/20 10:38 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:02PM +0200, Andrey Konovalov wrote: > >> +void * __must_check mte_set_mem_tag_range(void *addr, size_t size, u8 tag) > >> +{ > >> + void *ptr = addr; >

Re: [PATCH] net: Set trailer iff skb1 is the last one

2020-08-27 Thread Eric Dumazet
On Thu, Aug 27, 2020 at 4:31 AM Miaohe Lin wrote: > > Set trailer iff skb1 is the skbuff where the tailbits space begins. > > Signed-off-by: Miaohe Lin > --- > net/core/skbuff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > ind

[PATCH v2 02/15] x86/kprobes: Use generic kretprobe trampoline handler

2020-08-27 Thread Masami Hiramatsu
Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/core.c | 109 +--- 1 file changed, 4 insertions(+), 105 deletions(-) diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c index fdadc37d72af..7c6473a12cee 100644 --- a/arch/x8

[PATCH v2 05/15] arc: kprobes: Use generic kretprobe trampoline handler

2020-08-27 Thread Masami Hiramatsu
Signed-off-by: Masami Hiramatsu --- arch/arc/kernel/kprobes.c | 55 ++--- 1 file changed, 3 insertions(+), 52 deletions(-) diff --git a/arch/arc/kernel/kprobes.c b/arch/arc/kernel/kprobes.c index 7d3efe83cba7..da615684240b 100644 --- a/arch/arc/kernel/kp

[PATCH v2 03/15] arm: kprobes: Use generic kretprobe trampoline handler

2020-08-27 Thread Masami Hiramatsu
Use the generic kretprobe trampoline handler. Use regs->ARM_fp for framepointer verification. Signed-off-by: Masami Hiramatsu --- Changes in v2: - Fix to cast frame_pointer type to void *. --- arch/arm/probes/kprobes/core.c | 79 ++-- 1 file changed, 4

[PATCH v2 04/15] arm64: kprobes: Use generic kretprobe trampoline handler

2020-08-27 Thread Masami Hiramatsu
Use the generic kretprobe trampoline handler, and use the kernel_stack_pointer(regs) for framepointer verification. Signed-off-by: Masami Hiramatsu --- arch/arm64/kernel/probes/kprobes.c | 79 ++-- 1 file changed, 4 insertions(+), 75 deletions(-) diff --git a/a

[PATCH v2 12/15] sh: kprobes: Use generic kretprobe trampoline handler

2020-08-27 Thread Masami Hiramatsu
Signed-off-by: Masami Hiramatsu --- arch/sh/kernel/kprobes.c | 59 +++--- 1 file changed, 4 insertions(+), 55 deletions(-) diff --git a/arch/sh/kernel/kprobes.c b/arch/sh/kernel/kprobes.c index 318296f48f1a..118927ab63af 100644 --- a/arch/sh/kernel/kprob

[PATCH v2 14/15] kprobes: Remove NMI context check

2020-08-27 Thread Masami Hiramatsu
Since the commit 9b38cc704e84 ("kretprobe: Prevent triggering kretprobe from within kprobe_flush_task") sets a dummy current kprobe in the trampoline handler by kprobe_busy_begin/end(), it is not possible to run a kretprobe pre handler in kretprobe trampoline handler context even with the NMI. If t

[PATCH v1 0/8] seqlock: Introduce seqcount_latch_t

2020-08-27 Thread Ahmed S. Darwish
Latch sequence counters are a multiversion concurrency control mechanism where the embedded seqcount_t counter even/odd value is used to switch between two copies of protected data. This allows the sequence counter read side to be invoked from NMIs and safely interrupt its own write side critical s

[PATCH v1 4/8] time/sched_clock: Use seqcount_latch_t

2020-08-27 Thread Ahmed S. Darwish
Latch sequence counters have unique read and write APIs, and thus seqcount_latch_t was recently introduced at seqlock.h. Use that new data type instead of plain seqcount_t. This adds the necessary type-safety and ensures only latching-safe seqcount APIs are to be used. Signed-off-by: Ahmed S. Dar

[PATCH v1 8/8] seqlock: seqcount latch APIs: Only allow seqcount_latch_t

2020-08-27 Thread Ahmed S. Darwish
All latch sequence counter call-sites have now been converted from plain seqcount_t to the new seqcount_latch_t data type. Enforce type-safety by modifying seqlock.h latch APIs to only accept seqcount_latch_t. Signed-off-by: Ahmed S. Darwish --- include/linux/seqlock.h | 36 +++-

[PATCH] net: exit immediately when encounter ipv6 fragment in skb_checksum_setup_ipv6()

2020-08-27 Thread Miaohe Lin
skb_checksum_setup_ipv6() always return -EPROTO if ipv6 packet is fragment. So we should not continue to parse other header type in this case. Also remove unnecessary local variable 'fragment'. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [PATCH 1/4] qla2xxx: Reset done and free callback pointer on release

2020-08-27 Thread Daniel Wagner
> How about setting them to a dummy function that prints a big fat > warning? Good idea. I'll update the patch accordingly. This might even help to find the real cause.

Re: WARNING: ODEBUG bug in get_signal

2020-08-27 Thread syzbot
syzbot has bisected this issue to: commit a9ed4a6560b8562b7e2e2bed9527e88001f7b682 Author: Marc Zyngier Date: Wed Aug 19 16:12:17 2020 + epoll: Keep a reference on files added to the check list bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15e5775190 start commit:

Re: [PATCH 01/16] iio: accel: bma180: Simplify with dev_err_probe()

2020-08-27 Thread Jonathan Cameron
On Wed, 26 Aug 2020 16:51:38 +0200 Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and also it prints the error value. > > Signed-off-by: Krzysztof Kozlowski Please make sure to send v2 to linux-...@vger.kernel.org >

[PATCH v2 1/2] drm/ingenic: Fix leak of device_node pointer

2020-08-27 Thread Paul Cercueil
of_graph_get_remote_node() requires of_node_put() to be called on the device_node pointer when it's no more in use. Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") Signed-off-by: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 2/2] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-27 Thread Paul Cercueil
Even if support for the IPU was compiled in, we may run on a device (e.g. the Qi LB60) where the IPU is not available, or simply with an old devicetree without the IPU node. In that case the ingenic-drm refused to probe. Fix the driver so that it will probe even if the IPU node is not present in d

Re: [PATCH 5/5] Add manpage for fsconfig(2)

2020-08-27 Thread Michael Kerrisk (man-pages)
Hello David, On 8/24/20 2:25 PM, David Howells wrote: > Add a manual page to document the fsconfig() system call. > > Signed-off-by: David Howells > --- > > man2/fsconfig.2 | 277 > +++ > 1 file changed, 277 insertions(+) > create mode 100

[PATCH] net: exit immediately when off = 0 in skb_headers_offset_update()

2020-08-27 Thread Miaohe Lin
In the case of off = 0, skb_headers_offset_update() do nothing indeed. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 18ed56316e56..f67f0da20a5b 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff

Re: [PATCH 4/4] qla2xxx: Handle incorrect entry_type entries

2020-08-27 Thread Daniel Wagner
On Thu, Aug 27, 2020 at 12:17:13PM +0200, Martin Wilck wrote: > Should we perhaps log an error message when we detect a mismatch > between sp->type and entry_type? Sure can do, but does it really help? Not much we can do in the driver. I hope the firmware gets fixed eventually. I am not against it

Re: [PATCH 4/5] Add manpage for fsopen(2) and fsmount(2)

2020-08-27 Thread Michael Kerrisk (man-pages)
Hello David, On 8/24/20 2:25 PM, David Howells wrote: > Add a manual page to document the fsopen() and fsmount() system calls. > > Signed-off-by: David Howells > --- > > man2/fsmount.2 |1 > man2/fsopen.2 | 245 > > 2 files chang

[PATCH] fs/binfmt_elf: Fix memleak in load_elf_binary

2020-08-27 Thread Dinghao Liu
When arch_setup_additional_pages() fails, interp_elf_ex may not have been freed, which leads to memleak. It's the same when create_elf_tables() fails. Signed-off-by: Dinghao Liu --- fs/binfmt_elf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_elf.c b/fs

[PATCH v5 7/7] mm: Remove the now-unnecessary mmget_still_valid() hack

2020-08-27 Thread Jann Horn
The preceding patches have ensured that core dumping properly takes the mmap_lock. Thanks to that, we can now remove mmget_still_valid() and all its users. Signed-off-by: Jann Horn --- drivers/infiniband/core/uverbs_main.c | 3 --- drivers/vfio/pci/vfio_pci.c | 38 +---

[PATCH v5 2/7] coredump: Let dump_emit() bail out on short writes

2020-08-27 Thread Jann Horn
dump_emit() has a retry loop, but there seems to be no way for that retry logic to actually be used; and it was also buggy, writing the same data repeatedly after a short write. Let's just bail out on a short write. Suggested-by: Linus Torvalds Signed-off-by: Jann Horn --- fs/coredump.c | 22 +

Re: lib/crypto/chacha.c:65:1: warning: the frame size of 1604 bytes is larger than 1024 bytes

2020-08-27 Thread Herbert Xu
On Thu, Aug 27, 2020 at 12:41:53PM +0200, Ard Biesheuvel wrote: > > That does not help, unfortunately. > > What does seem to work is > > struct chacha_state { u32 x[16]; }; > > struct chacha_state chacha_permute(struct chacha_state st, int nrounds) Passing 64 bytes by value is not good. Passin

[PATCH v5 6/7] mm/gup: Take mmap_lock in get_dump_page()

2020-08-27 Thread Jann Horn
Properly take the mmap_lock before calling into the GUP code from get_dump_page(); and play nice, allowing the GUP code to drop the mmap_lock if it has to sleep. As Linus pointed out, we don't actually need the VMA because __get_user_pages() will flush the dcache for us if necessary. Signed-off-b

[PATCH v5 5/7] binfmt_elf, binfmt_elf_fdpic: Use a VMA list snapshot

2020-08-27 Thread Jann Horn
In both binfmt_elf and binfmt_elf_fdpic, use a new helper dump_vma_snapshot() to take a snapshot of the VMA list (including the gate VMA, if we have one) while protected by the mmap_lock, and then use that snapshot instead of walking the VMA list without locking. An alternative approach would be t

Re: [PATCH v1 0/5] irqdomain: clean up, add irq_domain_create_legacy()

2020-08-27 Thread Andy Shevchenko
On Sun, Jul 26, 2020 at 12:12:02PM +0300, Andy Shevchenko wrote: > On Wed, Jul 08, 2020 at 07:21:30PM +0300, Andy Shevchenko wrote: > > In order to make users OF independent provide irq_domain_create_legacy() > > API. > > Last patch is an example of such user. First three patches are little > > c

Re: [PATCH v2 15/15] kprobes: Free kretprobe_instance with rcu callback

2020-08-27 Thread Masami Hiramatsu
On Thu, 27 Aug 2020 13:48:07 +0200 pet...@infradead.org wrote: > On Thu, Aug 27, 2020 at 08:37:49PM +0900, Masami Hiramatsu wrote: > > Free kretprobe_instance with rcu callback instead of directly > > freeing the object in the kretprobe handler context. > > > > This will make kretprobe run safer

[PATCH] selftests/livepatch: Do not check order when using "comm" for dmesg checking

2020-08-27 Thread Miroslav Benes
check_result() uses "comm" to check expected results of selftests output in dmesg. Everything works fine if timestamps in dmesg are unique. If not, like in this example [ 86.844422] test_klp_callbacks_demo: pre_unpatch_callback: test_klp_callbacks_mod -> [MODULE_STATE_LIVE] Normal state [ 86.

Re: [PATCH v2 15/15] kprobes: Free kretprobe_instance with rcu callback

2020-08-27 Thread peterz
On Thu, Aug 27, 2020 at 08:37:49PM +0900, Masami Hiramatsu wrote: > +void recycle_rp_inst(struct kretprobe_instance *ri) Also note, that at this point there is no external caller of this function anymore.

Re: [PATCH 1/2] Add a manpage for watch_queue(7)

2020-08-27 Thread Michael Kerrisk (man-pages)
Hi David, It would be helpful if you labelled the subject "[PATCH v2 1/2]" so that one could quickly see which of the patch series in my inbox is the newest. (I nearly replied to the wrong draft.) On 8/24/20 5:30 PM, David Howells wrote: > Add a manual page for the notifications/watch_queue faci

Re: [PATCH 19/35] kasan: don't allow SW_TAGS with ARM64_MTE

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 11:52 AM Vincenzo Frascino wrote: > > Hi Andrey, > > On 8/27/20 9:04 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:01PM +0200, Andrey Konovalov wrote: > >> Software tag-based KASAN provides its own tag checking machinery that > >> can conflict with MTE. Don't

[PATCH 2/2] docs: admin-guide: Not every security bug should be kept hidden

2020-08-27 Thread Krzysztof Kozlowski
Document describes the process of handling security bugs but does not mention any criteria what is a "security bug". Unlike submitting-patches.rst which explicitly says - publicly exploitable bug. Many NULL pointer exceptions, off-by-one errors or overflows tend to look like security bug, so ther

[PATCH] vdpa/mlx5: Remove duplicate include

2020-08-27 Thread Jing Xiangfeng
Remove linux/mlx5/device.h which is included more than once Signed-off-by: Jing Xiangfeng --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index 70676a6d1691..b4bdbe062b7c 100644 --- a/

[PATCH 1/2] docs: process: Add cross-link to security-bugs

2020-08-27 Thread Krzysztof Kozlowski
The submitting patches mentions criteria for a fix to be called "security fix". Add a link to document explaining the entire process of handling security bugs. Cc: Greg KH Cc: Marek Szyprowski Cc: Linus Torvalds Cc: Kees Cook Signed-off-by: Krzysztof Kozlowski --- Documentation/process/subm

Re: [PATCH 28/35] kasan: define KASAN_GRANULE_SIZE for HW_TAGS

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 1:05 PM Vincenzo Frascino wrote: > > > > On 8/27/20 11:41 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:10PM +0200, Andrey Konovalov wrote: > >> Hardware tag-based KASAN has granules of MTE_GRANULE_SIZE. Define > >> KASAN_GRANULE_SIZE to MTE_GRANULE_SIZE for

Re: [PATCH 1/2] cpufreq: No need to verify cpufreq_driver in show_scaling_cur_freq()

2020-08-27 Thread Rafael J. Wysocki
On Thu, Aug 27, 2020 at 7:24 AM Viresh Kumar wrote: > > "cpufreq_driver" is guaranteed to be valid here, no need to check it > here. > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/cpufreq/cpufre

Re: WARNING: at drivers/opp/core.c:678 dev_pm_opp_set_rate+0x4cc/0x5d4 - on arm x15

2020-08-27 Thread Naresh Kamboju
On Thu, 27 Aug 2020 at 15:16, Viresh Kumar wrote: > > On 27-08-20, 15:04, Naresh Kamboju wrote: > > While boot testing arm x15 devices the Kernel warning noticed with linux > > next > > tag 20200825. > > > > BAD: next-20200825 > > GOOD: next-20200824 > > > > metadata: > > git branch: master >

Re: [PATCH 1/2] docs: process: Add cross-link to security-bugs

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 12:53:18PM +0200, Krzysztof Kozlowski wrote: > The submitting patches mentions criteria for a fix to be called > "security fix". Add a link to document explaining the entire process > of handling security bugs. > > Cc: Greg KH > Cc: Marek Szyprowski > Cc: Linus Torvalds

Re: PROBLEM: Long Workqueue delays V2

2020-08-27 Thread Jim Baxter
Has anyone any ideas of how to investigate this delay further? Comparing the perf output for unplugging the USB stick and using umount which does not cause these delays in other workqueues the main difference is that the problem case is executing the code in invalidate_mapping_pages() and a large

Re: [PATCH] vdpa/mlx5: Remove duplicate include

2020-08-27 Thread Eli Cohen
On Thu, Aug 27, 2020 at 08:05:47PM +0800, Jing Xiangfeng wrote: > Remove linux/mlx5/device.h which is included more than once > > Signed-off-by: Jing Xiangfeng Acked-by: Eli Cohen > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vdpa/m

Re: [PATCH 32/35] kasan, arm64: print report from tag fault handler

2020-08-27 Thread Vincenzo Frascino
On 8/27/20 11:48 AM, Catalin Marinas wrote: > On Fri, Aug 14, 2020 at 07:27:14PM +0200, Andrey Konovalov wrote: >> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c >> index c62c8ba85c0e..cf00b3942564 100644 >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -14,6 +14,7

Re: [PATCH 2/2] docs: admin-guide: Not every security bug should be kept hidden

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 12:53:19PM +0200, Krzysztof Kozlowski wrote: > Document describes the process of handling security bugs but does not > mention any criteria what is a "security bug". Unlike > submitting-patches.rst which explicitly says - publicly exploitable bug. > > Many NULL pointer exc

[PATCH] sched: idle: Change the cpu_idle_poll() return type to void

2020-08-27 Thread Frank Lee
From: Yangtao Li No one cares about the return value of this function, which only increases the time spent in idle loop. Let's drop it. Signed-off-by: Yangtao Li --- kernel/sched/idle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/sched/idle.c b/kernel/sched/i

Re: [PATCH] crypto: sun8i-ss - remove redundant memzero_explicit()

2020-08-27 Thread Denis Efremov
On 8/27/20 11:03 AM, Corentin Labbe wrote: > Could you add: > Fixes: 453431a54934 ("mm, treewide: rename kzfree() to kfree_sensitive()") I doubt this change deserves fixes tag, since this is just a cleanup. Anyway, I will send v2 with it. Thanks, Denis

[PATCH] sched: idle: Change the cpu_idle_poll() return type to void

2020-08-27 Thread Frank Lee
From: Yangtao Li No one cares about the return value of this function, which only increases the time spent in idle loop. Let's drop it. Signed-off-by: Yangtao Li --- kernel/sched/idle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/sched/idle.c b/kernel/sched/i

Re: [PATCH] opp: Drop unnecessary check frmo dev_pm_opp_attach_genpd()

2020-08-27 Thread Stephan Gerhold
On Thu, Aug 27, 2020 at 03:35:15PM +0530, Viresh Kumar wrote: > Since commit c0ab9e0812da ("opp: Allocate genpd_virt_devs from > dev_pm_opp_attach_genpd()"), the allocation of the virtual devices is > moved to dev_pm_opp_attach_genpd() and this check isn't required anymore > as it will always fail.

Re: [PATCH 00/30] Set 3: Rid W=1 warnings in Wireless

2020-08-27 Thread Lee Jones
On Thu, 27 Aug 2020, Kalle Valo wrote: > Lee Jones writes: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > There are quite a few W=1 warnings in the Wireless. My plan > >

Re: [PATCH 25/35] kasan: introduce CONFIG_KASAN_HW_TAGS

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 1:31 PM Vincenzo Frascino wrote: > > Hi Andrey, > > On 8/14/20 6:27 PM, Andrey Konovalov wrote: > > +config·KASAN_HW_TAGS > > +» bool·"Hardware·tag-based·mode" > > +» depends·on·HAVE_ARCH_KASAN_HW_TAGS > > +» depends·on·SLUB > > +» help > > +» ··Enables·hardware·tag-based·K

[PATCH] vdpa/mlx5: Make vdpa core driver a distinct module

2020-08-27 Thread Eli Cohen
Change core vdpa functionality into a loadbale module such that upcoming block implementation will be able to use it. Signed-off-by: Eli Cohen --- drivers/vdpa/Kconfig | 6 +++--- drivers/vdpa/Makefile | 2 +- drivers/vdpa/mlx5/Makefile | 7 +-- drivers/

Re: [PATCH v10 4/4] media: open.rst: document mc-centric and video-node-centric

2020-08-27 Thread Sakari Ailus
Hi Mauro, On Thu, Aug 27, 2020 at 09:21:48AM +0200, Mauro Carvalho Chehab wrote: > When we added support for omap3, back in 2010, we added a new > type of V4L2 devices that aren't fully controlled via the V4L2 > device node. > > Yet, we have never clearly documented in the V4L2 specification > th

Race between freeing and waking page

2020-08-27 Thread Matthew Wilcox
On Thu, Aug 27, 2020 at 12:01:00AM -0700, Hugh Dickins wrote: > It was a crash from checking PageWaiters on a Tail in wake_up_page(), > called from end_page_writeback(), from ext4_finish_bio(): yet the > page a tail of a shmem huge page. Linus's wake_up_page_bit() changes? > No, I don't think so.

Re: [PATCH v4 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-27 Thread Mark Brown
On Thu, Aug 27, 2020 at 07:56:47AM +0100, Lee Jones wrote: > On Wed, 26 Aug 2020, Mark Brown wrote: > > [2/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC > > commit: 53be8bbc2f4058d4a6bfff3dadf34164bcaafa87 > Que? This is yet to be reviewed. Sorry, meant to only fetc

Re: [PATCH] fs: Optimized fget to improve performance

2020-08-27 Thread Matthew Wilcox
On Thu, Aug 27, 2020 at 06:19:44PM +0800, Shaokun Zhang wrote: > From: Yuqi Jin > > It is well known that the performance of atomic_add is better than that of > atomic_cmpxchg. I don't think that's well-known at all. > +static inline bool get_file_unless_negative(atomic_long_t *v, long a) > +{

Re: [PATCH 05/30] atmel: Demote non-kerneldoc header to standard comment block

2020-08-27 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/atmel/atmel.c:4232: warning: Cannot understand This > file is part of net.russotto.AtmelMACFW, hereto referred to > > Cc: Simon Kelley > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub Kicin

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-27 Thread Vlastimil Babka
On 8/26/20 7:12 AM, Joonsoo Kim wrote: > 2020년 8월 25일 (화) 오후 6:43, Vlastimil Babka 님이 작성: >> >> >> On 8/25/20 6:59 AM, js1...@gmail.com wrote: >> > From: Joonsoo Kim >> > >> > memalloc_nocma_{save/restore} APIs can be used to skip page allocation >> > on CMA area, but, there is a missing case and

Re: [PATCH 32/35] kasan, arm64: print report from tag fault handler

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 12:48 PM Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:14PM +0200, Andrey Konovalov wrote: > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > index c62c8ba85c0e..cf00b3942564 100644 > > --- a/arch/arm64/mm/fault.c > > +++ b/arch/arm64/mm/fault.c >

Aw: [PATCH 00/18] Convert arch/arm to use iommu-dma

2020-08-27 Thread Frank Wunderlich
Tested full series on bananapi r2 (mt7623/mt2701, 5.9-rc1 + hdmi-patches), works so far fbcon+x without issues Tested-by: Frank Wunderlich regards Frank

Re: [PATCH] tools build feature: cleanup feature files on make clean

2020-08-27 Thread Jiri Olsa
On Thu, Aug 27, 2020 at 10:53:36AM +0200, Jesper Dangaard Brouer wrote: > The system for "Auto-detecting system features" located under > tools/build/ are (currently) used by perf, libbpf and bpftool. It can > contain stalled feature detection files, which are not cleaned up by > libbpf and bpftool

Re: [PATCH 26/35] kasan, arm64: Enable TBI EL1

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 1:15 PM Vincenzo Frascino wrote: > > > > On 8/27/20 12:13 PM, Catalin Marinas wrote: > > On Thu, Aug 27, 2020 at 12:05:55PM +0100, Vincenzo Frascino wrote: > >> On 8/27/20 11:40 AM, Catalin Marinas wrote: > >>> On Fri, Aug 14, 2020 at 07:27:08PM +0200, Andrey Konovalov wrot

Re: [PATCH v4 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-27 Thread Lee Jones
On Thu, 27 Aug 2020, Mark Brown wrote: > On Thu, Aug 27, 2020 at 07:56:47AM +0100, Lee Jones wrote: > > On Wed, 26 Aug 2020, Mark Brown wrote: > > > > [2/2] mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC > > > commit: 53be8bbc2f4058d4a6bfff3dadf34164bcaafa87 > > > Que?

[PATCH] staging: ion: remove from the tree

2020-08-27 Thread Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel. It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android de

Re: [PATCH 4/4] qla2xxx: Handle incorrect entry_type entries

2020-08-27 Thread Martin Wilck
On Thu, 2020-08-27 at 13:46 +0200, Daniel Wagner wrote: > On Thu, Aug 27, 2020 at 12:17:13PM +0200, Martin Wilck wrote: > > Should we perhaps log an error message when we detect a mismatch > > between sp->type and entry_type? > > Sure can do, but does it really help? Not much we can do in the > dr

Re: linux-next: build failure after merge of the akpm-current tree

2020-08-27 Thread Mike Rapoport
On Thu, Aug 27, 2020 at 06:20:58PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the akpm-current tree, today's linux-next build (mips > cavium_octeon_defconfig) failed like this: > > arch/mips/cavium-octeon/dma-octeon.c:205:7: error: ‘mem’ undeclared (first > use in this function);

Re: [PATCH] mtd: ck804xrom: fix missing pci device put in error paths

2020-08-27 Thread Miquel Raynal
Hi James, James Bond wrote on Fri, 21 Aug 2020 02:05:36 -0500: > pci_dev_get increases the refcount of "pdev". > In the error paths, pci_dev_put should be called > to handle the "pdev" and decrease the corresponding refcount. > > Fixes: 90afffc8bd79 ("[MTD] [MAPS] Support for BIOS flash chips o

Re: [PATCH v10 3/4] media: docs: add glossary.rst with common terms used at V4L2 spec

2020-08-27 Thread Mauro Carvalho Chehab
Em Thu, 27 Aug 2020 14:08:11 +0300 Sakari Ailus escreveu: > Hi Mauro, > > On Thu, Aug 27, 2020 at 09:21:47AM +0200, Mauro Carvalho Chehab wrote: > > Add a glossary of terms used within the media userspace API > > documentation, as several concepts are complex enough to cause > > misunderstanding

[PATCH v2 0/2] media: v4l2-mem2mem: fix poll() bug

2020-08-27 Thread Alexandre Courbot
Thanks to the feedback on the first version, this one removes even more code. I have simplified patch 1/1 to just address the issue without moving code, since this is easier to understand and needs to be done for 2/2 anyway. As a consequence the code has changed a bit and I did not carry the Revie

Re: [PATCH 20/35] arm64: mte: Add in-kernel MTE helpers

2020-08-27 Thread Andrey Konovalov
On Thu, Aug 27, 2020 at 11:38 AM Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:02PM +0200, Andrey Konovalov wrote: > > diff --git a/arch/arm64/include/asm/mte.h b/arch/arm64/include/asm/mte.h > > index 1c99fcadb58c..733be1cb5c95 100644 > > --- a/arch/arm64/include/asm/mte.h > > +++ b/ar

[PATCH v2 2/2] media: v4l2-mem2mem: simplify poll logic

2020-08-27 Thread Alexandre Courbot
Factorize redundant checks into a single code block, remove unneeded checks (a buffer in done_list is necessarily in the DONE or ERROR state), and we end up with a much simpler version of this function. Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-mem2mem.c | 26 +---

[PATCH v2 1/2] media: v4l2-mem2mem: always consider OUTPUT queue during poll

2020-08-27 Thread Alexandre Courbot
If poll() is called on a m2m device with the EPOLLOUT event after the last buffer of the CAPTURE queue is dequeued, any buffer available on OUTPUT queue will never be signaled because v4l2_m2m_poll_for_data() starts by checking whether dst_q->last_buffer_dequeued is set and returns EPOLLIN in this

Re: [PATCH v2 5/7][next] printk: ringbuffer: add finalization/extension support

2020-08-27 Thread Petr Mladek
Hi, this mail is based on my review that I did last two days. I haven't seen the last code that tried to handle the finalize issues. Anyway, this feedback might give some clueue as well. IMPORTANT: It seems that we both had different understanding of the DESC_FINAL_MASK behavior. It might explain

Re: [PATCH v6 5/5] KVM: MIPS: clean up redundant kvm_run parameters in assembly

2020-08-27 Thread Tianjia Zhang
Hi, Paolo Do you need any other comments on this patch? Thanks, Tianjia On 7/16/20 10:10 AM, Jiaxun Yang wrote: 在 2020/6/23 21:14, Tianjia Zhang 写道: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function pa

[PATCH v3] memory: omap-gpmc: Fix build error without CONFIG_OF

2020-08-27 Thread YueHaibing
If CONFIG_OF is n, gcc fails: drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings': omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt' Add gpmc_read_settings_dt() helper function, which zero the gpmc_settings so the caller doesn't proceed with random/inv

<    1   2   3   4   5   6   7   8   9   10   >