[PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread sbates
From: Stephen Bates If the amount of resources allocated to a gen_pool exceeds 2^32 then the avail atomic overflows and this causes problems when clients try and borrow resources from the pool. This is only expected to be an issue on 64 bit systems. Add the header to pull in atomic_long* operat

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 07:40:49PM +0530, PrasannaKumar Muralidharan wrote: > Hi Jarkko, > > On 26 October 2017 at 19:24, Jarkko Sakkinen > wrote: > > Device number (the character device index) is not a stable identifier > > for a TPM chip. That is the reason why every call site passes > > TPM_AN

Re: [PATCH] iio/accel/stk8312: Improve unlocking of a mutex in two functions

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 20:55:23 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Oct 2017 20:46:18 +0200 > > * Adjust jump targets so that a call of the function "mutex_unlock" > is mostly stored at the end of these function implementations. > > * Replace four calls by goto

[PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

2017-10-26 Thread Philippe Cornu
The pixel clock is optional. When available, it offers a better preciseness for timing computations. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridg

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

2017-10-26 Thread Alan Cox
> > +static int __init dell_uart_bl_init(void) > > +{ > > + ftty = filp_open("/dev/ttyS0", O_RDWR | O_NOCTTY | O_NDELAY, 0); > You have no idea what name is assigned. This doesn't work. This isn't the way to do it any more because the 'tty from kernel' problem finally got fixed. You can att

[PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-26 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 26 Oct 2017 17:54:15 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/main.c | 10

[PATCH] dt-bindings: display: stm32: add pixel clock mandatory property

2017-10-26 Thread Philippe Cornu
Add the DPI/RGB input pixel clock in mandatory properties because it really offers a better preciseness for timing computations. Note: Fix also the DSI panel example where "ref" & "pclk" clocks were swapped. Signed-off-by: Philippe Cornu --- Documentation/devicetree/bindings/display/st,stm32-ltd

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Dmitry Vyukov
On Thu, Oct 26, 2017 at 5:49 PM, Xin Long wrote: > On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: >> On Thu, Oct 26, 2017 at 10:53 AM, ChunYu Wang wrote: >>> Hi all, >>> >>> I am failed to reproduce it on target kernel with the reproducer file >>> or replaying the target syzkaller descri

Re: [PATCH 2/2] mm: oom: dump single excessive slab cache when oom

2017-10-26 Thread Yang Shi
On 10/26/17 7:53 AM, Michal Hocko wrote: On Thu 26-10-17 06:49:00, Yang Shi wrote: Per the discussion with David [1], it looks more reasonable to just dump Please try to avoid external references in the changelog as much as possible. OK. the single excessive slab cache instead of dumpi

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread Mathieu Desnoyers
- On Oct 26, 2017, at 6:04 PM, Stephen Bates sba...@raithlin.com wrote: > From: Stephen Bates > > If the amount of resources allocated to a gen_pool exceeds 2^32 then > the avail atomic overflows and this causes problems when clients try > and borrow resources from the pool. This is only exp

Re: [PATCH] iio/proximity/srf08: Improve unlocking of a mutex in srf08_read_ranging()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 17:00:07 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 16:51:08 +0200 > > Add a jump target so that a call of the function "mutex_unlock" is stored > only once at the end of this function implementation. > Replace two calls by goto statements

Re: [PATCH] iio/pressure/mpl3115: Improve unlocking of a mutex in mpl3115_trigger_handler()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 16:23:45 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 16:10:46 +0200 > > Adjust jump targets so that a call of the function "mutex_unlock" is stored > at the end of this function implementation. > Replace three calls by goto statements. > >

Re: [PATCH] serial: 8250: Convert timers to use timer_setup()

2017-10-26 Thread Andy Shevchenko
On Tue, 2017-10-24 at 02:59 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. Reviewed-by: Andy Shevchenko > > Cc: Greg K

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-26 Thread PrasannaKumar Muralidharan
On 26 October 2017 at 00:41, Jarkko Sakkinen wrote: > On Wed, Oct 25, 2017 at 08:21:16PM +0530, PrasannaKumar Muralidharan wrote: >> >> > 2. Moving struct tpm_rng to the TPM client is architecturally >> >> >uacceptable. >> >> >> >> As there was no response to the patch there is no way to know

Re: [PATCH] iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 15:45:43 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 15:34:46 +0200 > > Add a jump target so that a specific error message is stored only once > at the end of this function implementation. > Replace two calls of the function "dev_err" by go

Re: [PATCH 03/14] VFS: Implement a filesystem superblock creation/configuration context [ver #6]

2017-10-26 Thread David Howells
Miklos Szeredi wrote: > > +/** > > + * vfs_parse_mount_option - Add a single mount option to a superblock > > config > > Mount options are those that refer to the mount > (nosuid,nodev,noatime,etc..); this function is not parsing those, > AFAICT. I'd quibble that those are "mountpoint" options

Proposal: single defconfig for all ARM

2017-10-26 Thread Pintu Kumar
Hi, My proposal is to maintain a common base defconfig file for all ARM products and only add the additional configs in the new defconfig file. I am not sure if this is already possible. If this is possible please let us know the steps. For example: Under arch/arm/configs , there are more than 10

Re: [PATCH 2/2] mm: oom: dump single excessive slab cache when oom

2017-10-26 Thread Michal Hocko
On Fri 27-10-17 00:15:17, Yang Shi wrote: > > > On 10/26/17 7:53 AM, Michal Hocko wrote: > > On Thu 26-10-17 06:49:00, Yang Shi wrote: > > > Per the discussion with David [1], it looks more reasonable to just dump > > > > Please try to avoid external references in the changelog as much as > > po

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

2017-10-26 Thread PrasannaKumar Muralidharan
On 26 October 2017 at 21:39, Jarkko Sakkinen wrote: > On Thu, Oct 26, 2017 at 07:40:49PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jarkko, >> >> On 26 October 2017 at 19:24, Jarkko Sakkinen >> wrote: >> > Device number (the character device index) is not a stable identifier >> > for a TPM ch

Re: 4.13 (and probably all recent) kernels refuse to boot on one Nokia N950, work or another

2017-10-26 Thread Pavel Machek
Hi! > > > Glad you got it working :) For backlight you can add this > > > in drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c: > > > > > > add the following code at the end of dsicm_probe: > > > > You did not actually include code to paste into panel-dsi-cm, can you > > try a again? > > I added

Re: [PATCH] iio/light/max44000: Use common error handling code in max44000_probe()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 10:40:12 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 10:30:57 +0200 > > * Add a jump target so that a specific error message is stored only once > at the end of this function implementation. > > * Replace two calls of the function "dev_e

Re: [PATCH] iio/light/gp2ap020a00f: Use common error handling code in gp2ap020a00f_adjust_lux_mode()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 10:00:21 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 09:50:21 +0200 > > * Add jump targets so that two error messages are stored only once > at the end of this function implementation. > > * Adjust condition checks. > > This issue was d

Re: [PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-26 Thread Jesus Sanchez-Palencia
Hi Jose, On 10/26/2017 03:08 AM, Jose Abreu wrote: > Hi Andrew, > > On 26-10-2017 10:03, Andrew Lunn wrote: >>> These parameters may also need to change in runtime depending on >>> the scheduled traffic. Unfortunately, net subsystem does not yet >>> support TSN so this will have to wait and for

Re: [PATCH] iio/adc/palmas: Use common error handling code in palmas_gpadc_calibrate()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 08:08:49 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 07:58:03 +0200 > > * Add a jump target so that a specific error message is stored only once > at the end of this function implementation. > > * Adjust condition checks. > > This issue

Re: [PATCH net-next 0/2] net: stmmac: Support DWMAC5 and TSN

2017-10-26 Thread Jesus Sanchez-Palencia
Hi Jose, On 10/25/2017 07:02 AM, Jose Abreu wrote: > Hi, > > This adds support for a new IP version (5) of dwmac and for > TSN features as defined by IEEE802.1Qbv-2015 and IEEE802.1Qbu. Just out of curiosity, are you aware of any NICs that are publicly available which use this IP version? Tha

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Craig Bergstrom
Yes, not much time left for 4.14, it might be reasonable to pull the change out since it's causing problems. The 0day testing robot failure is relatively simple (definitely aided by the reproduction instructions), but I'm still pulling apart the qemu failure. Another alternative that I considered

[GIT PULL] Kernel lockdown for secure boot

2017-10-26 Thread David Howells
a medium that can then be accessed. .P Use of debugfs is not permitted as this allows a whole range of actions including direct configuration of, access to and driving of hardware. .RE .\""""""""""""""

Re: WARNING in handle_ept_misconfig

2017-10-26 Thread Dmitry Vyukov
On Thu, Oct 26, 2017 at 6:35 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 9829d9f31f6c0e4984545e03032f14ccca6eeb68 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is

[GIT PULL] Power management fix for v4.14-rc7

2017-10-26 Thread Rafael J. Wysocki
Hi Linus, It is late in the cycle, but the bug in question is in the "user space can trigger unexpected behavior" category and the fix is stable-candidate, so here it goes. Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-4.14-rc7 with top-most c

Re: KASAN: use-after-free Read in get_work_pool

2017-10-26 Thread Dmitry Vyukov
On Thu, Oct 26, 2017 at 6:35 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > ad9a19d003703ae06a6e8efc64cf26a939d9e84d > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is a

Re: iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read()

2017-10-26 Thread SF Markus Elfring
> The advantages of this are very limited. Would anybody like to check corresponding effects in more detail? > Hence I am not going to apply it. This is a pity that you like such a kind of source code adjustment not so much so far. Regards, Markus

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Ingo Molnar
* Craig Bergstrom wrote: > Yes, not much time left for 4.14, it might be reasonable to pull the > change out since it's causing problems. [...] Ok, I'll queue up a revert tomorrow morning and send it to Linus ASAP if there's no good fix by then. In hindsight I should have queued it for v4.15

Re: [PATCH 1/2] iio/accel/stk8ba50: Use common error handling code in stk8ba50_probe()

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 22:16:31 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Oct 2017 21:36:03 +0200 > > * Add a jump target so that a specific error message is stored only once > at the end of this function implementation. > > * Replace two calls of the function "dev_e

Re: [PATCH 1/3] x86/entry: Fix idtentry unwind hint

2017-10-26 Thread Andrei Vagin
On Thu, Oct 26, 2017 at 10:24:29AM -0500, Josh Poimboeuf wrote: > On Wed, Oct 25, 2017 at 02:07:38PM -0700, Andrei Vagin wrote: > > Hi Josh, > > > > Here is one more warning: > > [5.852094] WARNING: can't dereference iret registers at > > b6ce01b7ffe0 for ip entry_SYSCALL_64_fastpath+0xa/

Re: iio/pressure/hp206c: Use common error handling code in hp206c_conv_and_read()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 18:38:14 +0200 SF Markus Elfring wrote: > > The advantages of this are very limited. > > Would anybody like to check corresponding effects in more detail? No readabilty is reduced. It is a very rare patch that is accepted where that is the case and the reasons have to be e

Re: [PATCH] iio/light/max44000: Use common error handling code in max44000_probe()

2017-10-26 Thread SF Markus Elfring
>> @@ -596,6 +592,10 @@ static int max44000_probe(struct i2c_client *client, >> } >> >> return iio_device_register(indio_dev); >> + >> +report_failure: >> +dev_err(&client->dev, "failed to write init config: %d\n", ret); > This reduces readability of the code for a very minor gain.

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

2017-10-26 Thread Jason Gunthorpe
On Thu, Oct 26, 2017 at 09:57:12PM +0530, PrasannaKumar Muralidharan wrote: > I do not what value my rb tag provides as I have not contributed code > to it before. Is it encouraged by kernel community? Yes. People will judge the quality of your rb tag based on other reviews they have seen you mak

Re: [PATCH v1] PCI: Fixup the RTIT_BAR of Intel TH on Denverton

2017-10-26 Thread Bjorn Helgaas
On Thu, Oct 26, 2017 at 05:28:17PM +0300, Alexander Shishkin wrote: > On some integrations of the Intel(R) Trace Hub (for a reference and > overview see Documentation/trace/intel_th.txt) the reported size of > one of its resources (RTIT_BAR) doesn't match its actual size, which > leads to overlaps

Re: [PATCH v5 0/2] thermal: add brcmstb AVS TMON driver

2017-10-26 Thread Florian Fainelli
On 09/26/2017 02:27 PM, Markus Mayer wrote: > From: Markus Mayer > > This series adds the brcmstb AVS TMON driver. > > The driver was originally written by Brian Norris. Rui, Eduardo, what's going on here? Can either one of you merge this driver or are we going to miss another merge window?

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Xin Long
On Fri, Oct 27, 2017 at 12:13 AM, Dmitry Vyukov wrote: > On Thu, Oct 26, 2017 at 5:49 PM, Xin Long wrote: >> On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: >>> On Thu, Oct 26, 2017 at 10:53 AM, ChunYu Wang wrote: Hi all, I am failed to reproduce it on target kernel with t

Re: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-26 Thread Brijesh Singh
On 10/26/2017 08:56 AM, Borislav Petkov wrote: On Mon, Oct 23, 2017 at 02:57:04PM -0500, Brijesh Singh wrote: Calling PLATFORM_GET_STATUS is not required, we can manage the state through a simple ref count variable. Issuing PSP commands will always be much more expensive compare to accessing a

Re: [PATCH] alpha/pci: Fix pci_map_irq()/pci_swizzle() functions section markers

2017-10-26 Thread Bjorn Helgaas
On Thu, Oct 26, 2017 at 03:54:15PM +0100, Lorenzo Pieralisi wrote: > The introduction of {map/swizzle}_irq() hooks in the > struct pci_host_bridge allowed to replace the pci_fixup_irqs() > PCI IRQ allocation in alpha arch PCI code with per-bridge > map/swizzle functions with commit 0e4c2eeb758a ("a

Re: [PATCH] MAINTAINERS: thermal: Remove Eduardo's git tree

2017-10-26 Thread Florian Fainelli
On 09/24/2017 02:18 PM, Florian Fainelli wrote: > Eduardo's git tree at: > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git > > has not been updated in months, remove it to avoid any confusing and > patch submissions to stall. > > Signed-off-by: Florian Fainelli > ---

Re: [PATCH v2] iio : Add cm3218 smbus ara and acpi support

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 16:55:15 +0200 Marc CAPDEVILLE wrote: > On asus T100, Capella cm3218 chip is implemented as ambiant light > sensor. This chip expose an smbus ARA protocol device on standard > address 0x0c. The chip is not functional before all alerts are > acknowledged. > On asus T100, this d

Re: Fixing CVE-2017-15361

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 03:42:27PM +, alexander.stef...@infineon.com wrote: > As far as I know, the kernel itself is not using any of the affected > functionalities, so there is no need for an immediate mitigation > within the kernel. But I'd like to hear about how similar issues were > handled

Re: Fixing CVE-2017-15361

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 04:57:48PM +0200, Michal Suchánek wrote: > On Thu, 26 Oct 2017 16:06:02 +0200 > Jarkko Sakkinen wrote: > > > On Thu, Oct 26, 2017 at 02:59:02PM +0200, Michal Suchánek wrote: > > > It does not really matter. People ignore the messages unless looking > > > for something spec

Re: Fixing CVE-2017-15361

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 07:02:37PM +0200, Jarkko Sakkinen wrote: > On Thu, Oct 26, 2017 at 04:57:48PM +0200, Michal Suchánek wrote: > > On Thu, 26 Oct 2017 16:06:02 +0200 > > Jarkko Sakkinen wrote: > > > > > On Thu, Oct 26, 2017 at 02:59:02PM +0200, Michal Suchánek wrote: > > > > It does not real

Re: [PATCH] MAINTAINERS: thermal: Remove Eduardo's git tree

2017-10-26 Thread Daniel Lezcano
On 26/10/2017 18:59, Florian Fainelli wrote: > On 09/24/2017 02:18 PM, Florian Fainelli wrote: >> Eduardo's git tree at: >> git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git >> >> has not been updated in months, remove it to avoid any confusing and >> patch submissions to

Re: Fixing CVE-2017-15361

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 03:46:26PM +, alexander.stef...@infineon.com wrote: > > On Thu, Oct 26, 2017 at 12:26:10AM +0200, Peter Huewe wrote: > > > > > > > > > Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen > > : > > > >On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote:

Re: iio/accel/stk8ba50: Use common error handling code in stk8ba50_probe()

2017-10-26 Thread SF Markus Elfring
> Again, a general kernel development rule is to float only one > patch of a given type until you have had feedback on it. Some update suggestions according also to this general source code transformation pattern were already integrated in other software areas. > These backwards goto cases are s

Re: [PATCH 05/14] VFS: Implement fsopen() to prepare for a mount [ver #6]

2017-10-26 Thread Jeff Layton
On Fri, 2017-10-06 at 16:49 +0100, David Howells wrote: > Provide an fsopen() system call that starts the process of preparing to > mount, using an fd as a context handle. fsopen() is given the name of the > filesystem that will be used: > > int mfd = fsopen(const char *fsname, int open_fla

Re: [PATCH 2/2] mm: oom: dump single excessive slab cache when oom

2017-10-26 Thread Michal Hocko
On Thu 26-10-17 18:27:01, Michal Hocko wrote: > On Fri 27-10-17 00:15:17, Yang Shi wrote: > > > > > > On 10/26/17 7:53 AM, Michal Hocko wrote: > > > On Thu 26-10-17 06:49:00, Yang Shi wrote: > > > > Per the discussion with David [1], it looks more reasonable to just dump > > > > > > Please try t

Re: [PATCH 07/14] VFS: Add a sample program for fsopen/fsmount [ver #6]

2017-10-26 Thread Jeff Layton
On Fri, 2017-10-06 at 16:50 +0100, David Howells wrote: > Add a sample program for driving fsopen/fsmount. > > Signed-off-by: David Howells > --- > > samples/fsmount/test-fsmount.c | 94 > > 1 file changed, 94 insertions(+) > create mode 100644 sampl

Re: lost some call trace for sleep function

2017-10-26 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 26, 2017 at 06:24:56PM +0800, yuzhoujian escreveu: > Hi, all. > I find a strange problem. Perf cannot record call stack which contains sleep > functions. > The last function of the call trace is always "__GI___libc_nanosleep" for > each sample. > one of the sample for perf script is b

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread Linus Torvalds
On Tue, Oct 24, 2017 at 1:57 PM, John Johansen wrote: > > actually a lot of work and testing has been done. A regression was > found, the fix is in testing and it should land soon, but its not the > regression you are having issues with. Stop gthis f*cking idiocy already! As far as the kernel is

Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat

2017-10-26 Thread Peter Zijlstra
On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote: > The basic cpu stat is currently shown with "cpu." prefix in > cgroup.stat, and the same information is duplicated in cpu.stat when > cpu controller is enabled. This is ugly and not very scalable as we > want to expand the coverage of sta

Re: [Part2 PATCH v6 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-26 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 11:56:57AM -0500, Brijesh Singh wrote: > The variable is used as ref counter. ... and it can't be converted to a boolean because...? > In your previous reply you comments on global semaphore (fw_init_mutex) and > in response I tried to highlight why we need the global sema

Re: [PATCH v2 3/3] iio: adc: stm32: add support for differential channels

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 11:27:45 +0200 Fabrice Gasnier wrote: > STM32H7 ADC channels can be configured either as single ended or > differential with 'st,adc-channels' or 'st,adc-diff-channels' > (positive and negative input pair: , ...). > > Differential channels have different offset and scale, fro

Re: [PATCH v2 1/3] dt-bindings: iio: adc: stm32: add support for diff channels

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 11:27:43 +0200 Fabrice Gasnier wrote: > STM32H7 ADC channels may be configured either as single-ended or > differential. > Add 'st,adc-diff-channels' property to support differential channels. > Differential channels are defined as a pair of positive and negative > inputs: vin

Re: [PATCH v2 2/3] iio: adc: stm32: remove const channel names definition

2017-10-26 Thread Jonathan Cameron
On Wed, 25 Oct 2017 11:27:44 +0200 Fabrice Gasnier wrote: > Remove const array that defines channels. Build channels definition > at probe time, when initializing channels (only for requested ones). > This will ease adding differential channels support. > > Signed-off-by: Fabrice Gasnier Looks

Re: [PATCH] iio/light/max44000: Use common error handling code in max44000_probe()

2017-10-26 Thread Jonathan Cameron
On Thu, 26 Oct 2017 18:50:14 +0200 SF Markus Elfring wrote: > >> @@ -596,6 +592,10 @@ static int max44000_probe(struct i2c_client *client, > >>} > >> > >>return iio_device_register(indio_dev); > >> + > >> +report_failure: > >> + dev_err(&client->dev, "failed to write init config: %d\n"

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Craig Bergstrom
Sander, thanks for the details, they've been very useful. I suspect that your host system's mem=2048M parameter is causing the problem. Any chance you can confirm by removing the parameter and running the guest code path? More specifically, since you're telling the kernel that it's high memory a

Re: [PATCH] workqueue: Fix NULL pointer dereference

2017-10-26 Thread Tejun Heo
Hello, On Thu, Oct 26, 2017 at 11:55:00PM +0800, Lai Jiangshan wrote: > I remember that softirq can be invoked when irq_eixt(), > and in this case the current->current_pwq is also NULL > if __queue_work() is called in the soft irq. > > So in_task() might be better than !in_irq() for the fix? Rev

Re: [PATCH cgroup/for-4.15] cgroup, sched: Move basic cpu stats from cgroup.stat to cpu.stat

2017-10-26 Thread Tejun Heo
On Mon, Oct 23, 2017 at 04:18:27PM -0700, Tejun Heo wrote: > The basic cpu stat is currently shown with "cpu." prefix in > cgroup.stat, and the same information is duplicated in cpu.stat when > cpu controller is enabled. This is ugly and not very scalable as we > want to expand the coverage of sta

Re: KASAN: use-after-free Read in get_work_pool

2017-10-26 Thread Tejun Heo
Hello, On Thu, Oct 26, 2017 at 09:35:44AM -0700, syzbot wrote: > BUG: KASAN: use-after-free in __read_once_size > include/linux/compiler.h:276 [inline] > BUG: KASAN: use-after-free in atomic64_read > arch/x86/include/asm/atomic64_64.h:21 [inline] > BUG: KASAN: use-after-free in atomic_long_read >

Re: [PATCH 10/18] x86/asm/32: Pull MSR_IA32_SYSENTER_CS update code out of native_load_sp0()

2017-10-26 Thread Brian Gerst
On Thu, Oct 26, 2017 at 4:26 AM, Andy Lutomirski wrote: > This causees the MSR_IA32_SYSENTER_CS write to move out of the > paravirt hook. This shouldn't affect Xen PV: Xen already ignores > MSR_IA32_SYSENTER_ESP writes. In any event, Xen doesn't support > vm86() in a useful way. > > Note to any

Re: [PATCH v3] cpuset: Enable cpuset controller in default hierarchy

2017-10-26 Thread Waiman Long
On 10/26/2017 10:39 AM, Tejun Heo wrote: > Hello, Waiman. > > On Wed, Oct 25, 2017 at 11:50:34AM -0400, Waiman Long wrote: >> Ping! Any comment on this patch? > Sorry about the lack of response. Here are my two thoughts. > > 1. I'm not really sure about the memory part. Mostly because of the >

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread Linus Torvalds
On Thu, Oct 26, 2017 at 11:11 AM, Thorsten Leemhuis wrote: > > All that afaics doesn't matter. If a new kernel breaks things for people > (that especially includes people that do *not* update their userland) > then it's a kernel regression, even if the root of the problem is in > usersland. Linus

[PATCH v3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

2017-10-26 Thread Pierre-Hugues Husson
The documentation already mentions "cec" optional clock, but currently the driver doesn't enable it. Changes: v3: - Drop useless braces v2: - Separate ENOENT errors from others - Propagate other errors (especially -EPROBE_DEFER) Signed-off-by: Pierre-Hugues Husson --- drivers/gpu/drm/bridge/sy

Re: [PATCH v6 12/13] xen/pvcalls: implement release command

2017-10-26 Thread Stefano Stabellini
On Thu, 26 Oct 2017, Boris Ostrovsky wrote: > On 10/25/2017 07:00 PM, Stefano Stabellini wrote: > > On Wed, 25 Oct 2017, Boris Ostrovsky wrote: > >> On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > >>> Send PVCALLS_RELEASE to the backend and wait for a reply. Take both > >>> in_mutex and out_mut

Re: [GIT PULL] Kernel lockdown for secure boot

2017-10-26 Thread Mimi Zohar
On Thu, 2017-10-26 at 17:37 +0100, David Howells wrote: > Hi James, > > Can you pull this patchset into security/next please? > > It adds kernel lockdown support for EFI secure boot. Note that it doesn't yet > cover: > > bpf - No agreement as to how > ftrace - Recently suggeste

Re: [PATCH v5 0/2] thermal: add brcmstb AVS TMON driver

2017-10-26 Thread Eduardo Valentin
On Thu, Oct 26, 2017 at 09:55:50AM -0700, Florian Fainelli wrote: > On 09/26/2017 02:27 PM, Markus Mayer wrote: > > From: Markus Mayer > > > > This series adds the brcmstb AVS TMON driver. > > > > The driver was originally written by Brian Norris. > > Rui, Eduardo, what's going on here? Can eit

Re: [PATCH] CLK: ARC: Set initial pll output frequency specified in device tree

2017-10-26 Thread Vineet Gupta
Hi folks, On 09/29/2017 06:13 AM, Eugeniy Paltsev wrote: Add option to set initial output frequency of plls via "clock-frequency" property in pll's device tree node. This frequency will be set while pll driver probed. The usage example is setting CPU clock frequency on boot See discussion: htt

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-26 Thread kbuild test robot
Hi Dmitry, Thank you for the patch! Yet we hit a small issue. [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.14-rc6 next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

Re: BUG: unable to handle kernel paging request in vsock_diag_dump

2017-10-26 Thread Cong Wang
#syz fix: vsock: always call vsock_init_tables()

Re: [PATCH v7 0/6] vfs: Use dlock list for SB's s_inodes list

2017-10-26 Thread Waiman Long
On 10/05/2017 02:43 PM, Waiman Long wrote: > > This is a follow up of the following patchset: > > [PATCH v7 0/4] vfs: Use per-cpu list for SB's s_inodes list > https://lkml.org/lkml/2016/4/12/1009 > > This patchset provides new APIs for a set of distributed locked lists > (one/CPU core) to mini

Re: KASAN: use-after-free Read in tipc_group_self

2017-10-26 Thread Cong Wang
#syz fix: tipc: fix a dangling pointer

Re: general protection fault in __list_del_entry_valid

2017-10-26 Thread Cong Wang
#syz fix: ipsec: Fix aborted xfrm policy dump crash

Re: KASAN: slab-out-of-bounds Read in tipc_nametbl_lookup_dst_nodes

2017-10-26 Thread Cong Wang
#syz fix: tipc: eliminate KASAN warning

[PATCH] clockevents: Update clockevents device next_event

2017-10-26 Thread Prasad Sodagudi
Usually clockevent device's next_event is updated in clockevents_program_event() and next_event indicates the next timer event on that cpu. Whenever there are no timers on a CPU, corresponding clockevent device is going into ONESHOT_STOPPED state but clockevent device next_event is not updated, bec

Re: [PATCH v5 0/2] thermal: add brcmstb AVS TMON driver

2017-10-26 Thread Eduardo Valentin
On Thu, Oct 26, 2017 at 11:24:33AM -0700, Eduardo Valentin wrote: > On Thu, Oct 26, 2017 at 09:55:50AM -0700, Florian Fainelli wrote: > > On 09/26/2017 02:27 PM, Markus Mayer wrote: > > > From: Markus Mayer > > > > > > This series adds the brcmstb AVS TMON driver. > > > > > > The driver was orig

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Xin Long
On Fri, Oct 27, 2017 at 12:56 AM, Xin Long wrote: > On Fri, Oct 27, 2017 at 12:13 AM, Dmitry Vyukov wrote: >> On Thu, Oct 26, 2017 at 5:49 PM, Xin Long wrote: >>> On Thu, Oct 26, 2017 at 10:49 PM, Dmitry Vyukov wrote: On Thu, Oct 26, 2017 at 10:53 AM, ChunYu Wang wrote: > Hi all,

Re: [PATCH] leds: Convert timers to use timer_setup()

2017-10-26 Thread Jacek Anaszewski
Hi Kees, Thanks for the patch. On 10/25/2017 12:30 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Richard Purdie > Cc

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > I'm *very* unhappy with the security layer as is What are you unhappy with? -- James Morris

[PATCH] Input-as5011: Use common error handling code in as5011_configure_chip()

2017-10-26 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 26 Oct 2017 20:48:49 +0200 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace four calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle software.

Re: [PATCH v3 4/5] efi: call get_event_log before ExitBootServices

2017-10-26 Thread Jarkko Sakkinen
On Tue, Oct 17, 2017 at 10:00:15AM +0200, Thiebaud Weksteen wrote: > This patch was mainly developed and tested on Kabylake with PTT as well. > > It could be a few things. Are you booting with the EFI stub? Is the > TPM enabled within the BIOS? Does tpm_tis get loaded? Does it produce > any log?

Re: [PATCH 05/14] VFS: Implement fsopen() to prepare for a mount [ver #6]

2017-10-26 Thread Jeff Layton
On Fri, 2017-10-06 at 16:49 +0100, David Howells wrote: > Provide an fsopen() system call that starts the process of preparing to > mount, using an fd as a context handle. fsopen() is given the name of the > filesystem that will be used: > > int mfd = fsopen(const char *fsname, int open_fla

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-26 Thread Ingo Molnar
* Craig Bergstrom wrote: > Sander, thanks for the details, they've been very useful. > > I suspect that your host system's mem=2048M parameter is causing the > problem. Any chance you can confirm by removing the parameter and > running the guest code path? > > More specifically, since you're

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread Linus Torvalds
On Thu, Oct 26, 2017 at 8:54 PM, James Morris wrote: > On Thu, 26 Oct 2017, Linus Torvalds wrote: > >> I'm *very* unhappy with the security layer as is > > What are you unhappy with? We had two big _fundamental_ problems this merge window: - untested code that clearly didn't do what it claimed

Re: [PATCH v2] iio : Add cm3218 smbus ara and acpi support

2017-10-26 Thread Peter Meerwald-Stadler
> On asus T100, Capella cm3218 chip is implemented as ambiant light > sensor. This chip expose an smbus ARA protocol device on standard > address 0x0c. The chip is not functional before all alerts are > acknowledged. > On asus T100, this device is enumerated on ACPI bus and the description > give

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-26 Thread James Morris
On Thu, 26 Oct 2017, Linus Torvalds wrote: > On Thu, Oct 26, 2017 at 8:54 PM, James Morris > wrote: > > On Thu, 26 Oct 2017, Linus Torvalds wrote: > > > >> I'm *very* unhappy with the security layer as is > > > > What are you unhappy with? > > We had two big _fundamental_ problems this merge wi

Re: Fixing CVE-2017-15361

2017-10-26 Thread Jarkko Sakkinen
On Thu, Oct 26, 2017 at 03:51:27PM +, alexander.stef...@infineon.com wrote: > > > On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote: > > > > On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen > > > > wrote: > > > > > I'm implementing a fix for CVE-2017-15361 that simply blacklists

[PATCH v7 00/13] introduce the Xen PV Calls frontend

2017-10-26 Thread Stefano Stabellini
Hi all, this series introduces the frontend for the newly introduced PV Calls procotol. PV Calls is a paravirtualized protocol that allows the implementation of a set of POSIX functions in a different domain. The PV Calls frontend sends POSIX function calls to the backend, which implements them a

[PATCH v7 03/13] xen/pvcalls: connect to the backend

2017-10-26 Thread Stefano Stabellini
Implement the probe function for the pvcalls frontend. Read the supported versions, max-page-order and function-calls nodes from xenstore. Only one frontend<->backend connection is supported at any given time for a guest. Store the active frontend device to a static pointer. Introduce a stub func

[PATCH v7 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend

2017-10-26 Thread Stefano Stabellini
Introduce a xenbus frontend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle

[PATCH v7 08/13] xen/pvcalls: implement accept command

2017-10-26 Thread Stefano Stabellini
Introduce a waitqueue to allow only one outstanding accept command at any given time and to implement polling on the passive socket. Introduce a flags field to keep track of in-flight accept and poll commands. Send PVCALLS_ACCEPT to the backend. Allocate a new active socket. Make sure that only on

[PATCH v7 10/13] xen/pvcalls: implement recvmsg

2017-10-26 Thread Stefano Stabellini
Implement recvmsg by copying data from the "in" ring. If not enough data is available and the recvmsg call is blocking, then wait on the inflight_conn_req waitqueue. Take the active socket in_mutex so that only one function can access the ring at any given time. Signed-off-by: Stefano Stabellini

[PATCH v7 12/13] xen/pvcalls: implement release command

2017-10-26 Thread Stefano Stabellini
Send PVCALLS_RELEASE to the backend and wait for a reply. Take both in_mutex and out_mutex to avoid concurrent accesses. Then, free the socket. For passive sockets, check whether we have already pre-allocated an active socket for the purpose of being accepted. If so, free that as well. Signed-off

[PATCH v7 05/13] xen/pvcalls: implement connect command

2017-10-26 Thread Stefano Stabellini
Send PVCALLS_CONNECT to the backend. Allocate a new ring and evtchn for the active socket. Introduce fields in struct sock_mapping to keep track of active sockets. Introduce a waitqueue to allow the frontend to wait on data coming from the backend on the active socket (recvmsg command). Two mutex

[PATCH v7 04/13] xen/pvcalls: implement socket command and handle events

2017-10-26 Thread Stefano Stabellini
Send a PVCALLS_SOCKET command to the backend, use the masked req_prod_pvt as req_id. This way, req_id is guaranteed to be between 0 and PVCALLS_NR_REQ_PER_RING. We already have a slot in the rsp array ready for the response, and there cannot be two outstanding responses with the same req_id. Wait

<    1   2   3   4   5   6   7   8   >