Re: [PATCH] Staging:skein: Fix trailing whitespace error

2014-11-22 Thread Sudip Mukherjee
On Sat, Nov 22, 2014 at 01:20:13PM +0530, anjana s wrote: > Just now I resend the same patch by making necessary changes. > Kindly please go through it you replied only to me. You should always use reply to all unless there is some specific reason not to send the reply to all. thanks sudip -- To

[PATCH] phy: remove the old lookup method

2014-11-22 Thread Kishon Vijay Abraham I
From: Heikki Krogerus The users of the old method are now converted to the new one. Signed-off-by: Heikki Krogerus [ kis...@ti.com : made phy-berlin-usb.c and phy-miphy28lp.c to use the updated devm_phy_create API.] Signed-off-by: Kishon Vijay Abraham I --- Two new PHY driver

Re: [PATCH] drivers:staging:skein:skein_generic.c: Fixed a whitespace error

2014-11-22 Thread Sudip Mukherjee
On Sat, Nov 22, 2014 at 01:11:59PM +0530, Anjana Sasindran wrote: > This patch fixes the checkpatch.pl error: > it still does not apply to next-20141121 > ERROR: trailing whitespace and i am not seeing any trailing whitespace at line 191 of this file. if you base your patch on next-2014

Re: [PATCH] phy: remove the old lookup method

2014-11-22 Thread Kishon Vijay Abraham I
Hi Linus, Thierry, On Saturday 22 November 2014 01:57 PM, Kishon Vijay Abraham I wrote: > From: Heikki Krogerus > > The users of the old method are now converted to the new one. One of the files in pinctrl is being modified in this patch to use the new devm_phy_create signature. I'm merging thi

Re: [GIT PULL] overlay filesystem fixes for 3.18

2014-11-22 Thread Sedat Dilek
On Fri, Nov 21, 2014 at 11:50 AM, Miklos Szeredi wrote: > On Fri, Nov 21, 2014 at 11:43 AM, Sedat Dilek wrote: >>> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git >>> overlayfs-current >>> >> >> This seems to be the place where overlayfs-fixes are collected for a >> git-pull req

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-22 Thread Kishon Vijay Abraham I
On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: > On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: >> The series has dependency on >> a) "[PATCH v7 0/7] Enable support for Samsung Exynos7 SoC" >>http://www.spinics.net/lists/linux-samsung-soc/msg38734.html >> b) "[GIT PUL

[PATCH v4 0/4] ARM: kprobes: introduces instruction checker.

2014-11-22 Thread Wang Nan
This the 4th version of instruction checker patch. Version 10 of ARM OPTPROBE patch series can be rebase to this series cleanly. Previous discussion can be found from: https://lkml.org/lkml/2014/11/21/55 https://lkml.org/lkml/2014/11/18/26 https://lkml.org/lkml/2014/10/25/48 https://lkml.org/lkml

[PATCH v4 2/4] ARM: kprobes: collects stack consumption for store instructions

2014-11-22 Thread Wang Nan
This patch uses the previously introduced checker functionality on store instructions to record their stack consumption information to arch_probes_insn. Signed-off-by: Wang Nan Signed-off-by: Jon Medhurst Reviewed-by: Jon Medhurst --- v1 -> v2: - Bugfix and code improvements following Tixy's

[PATCH v4 1/4] ARM: kprobes: introduces checker

2014-11-22 Thread Wang Nan
This patch introdces 'checker' to decoding phase, and calls checkers when instruction decoding. This allows further decoding for specific instructions. This patch introduces a stub call of checkers in kprobe arch_prepare_kprobe() as an example and for further expansion. Signed-off-by: Wang Nan R

[PATCH v4 4/4] ARM: kprobes: Add test cases for stack consuming instructions

2014-11-22 Thread Wang Nan
From: Jon Medhurst These have extra 'checker' functions associated with them so lets make sure those get covered by testing. Signed-off-by: Jon Medhurst --- arch/arm/kernel/kprobes-test-arm.c | 17 +++-- arch/arm/kernel/kprobes-test-thumb.c | 12 2 files changed, 27

[PATCH v4 3/4] ARM: kprobes: disallow probing stack consuming instructions

2014-11-22 Thread Wang Nan
This patch prohibits probing instructions for which the stack requirements are unable to be determined statically. Some test cases are found not work again after the modification, this patch also removes them. Signed-off-by: Wang Nan Reviewed-by: Jon Medhurst --- v1 -> v2: - Use MAX_STACK_SIZ

Re: [PATCH v4 6/7] ARM: mvebu: add PHY support to the dts for the USB controllers on Armada 375

2014-11-22 Thread Gregory CLEMENT
Hi Jason, On 22/11/2014 03:08, Jason Cooper wrote: > On Thu, Nov 13, 2014 at 12:47:48PM +0100, Gregory CLEMENT wrote: >> Now that the USB cluster node has been added, use it as a PHY provider >> for the USB controller linked to it: the first EHCI and the xHCI. >> >> Signed-off-by: Gregory CLEMENT

Re: [PATCH v3] x86/mce: Try printing all machine check banks known before panic

2014-11-22 Thread Borislav Petkov
On Sat, Nov 22, 2014 at 10:16:49AM +0800, rui wang wrote: > I think both possibilities are valid. But experiments show that the > error logs are not in the dmesg preserved by kdump in /var/crash/ > after panic and reboot, and not in the mcelog.entry[] array in the > kernel. So they must be somewher

[PATCH]: cross-compiling x86_64 kernel on i386 user-space fails

2014-11-22 Thread Chris Clayton
Hi, Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 kernel in an i386. The change added a call to objdump but neglected to cater for cross-compiling. The patch below fixes the problem for me. I see the commit is now in 3.14 and 3.17 -stable, so the patch needs to go the

[PATCH 1/1] ARM: OMAP2: Deletion of unnecessary checks before three function calls

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 10:50:33 +0100 The functions clk_disable(), of_node_put() and omap_device_delete() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: Your editor/IDE settings for autocompletion and other easiness

2014-11-22 Thread Oussama Jabbari
On Sat, Nov 22, 2014 at 4:58 AM, Andrey Utkin wrote: > (I was asked to research this topic to help students. So please ignore > this topic if all you want to say is that it is OK to code in editor > without autocompletion and any other integration, and that there's LXR > website. We all know that.

[PATCH 1/1] ARM-kernel: Deletion of unnecessary checks before two function calls

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 11:33:16 +0100 The functions smp_set_ops() and unwind_table_del() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: M

Re: [PATCH v2] iio: imu: Add support for Kionix KMX61 sensor

2014-11-22 Thread Jonathan Cameron
On 17/11/14 12:12, Daniel Baluta wrote: > On Sun, Nov 16, 2014 at 11:10 PM, Jonathan Cameron wrote: >> On 10/11/14 17:24, Daniel Baluta wrote: >>> Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It >>> exports >>> raw accel/magn readings together with scale and sampling freque

Re: [PATCH v3] iio: imu: Add support for Kionix KMX61 sensor

2014-11-22 Thread Jonathan Cameron
On 18/11/14 16:47, Daniel Baluta wrote: > Minimal implementation for KMX61 6-axis accelerometer/magnetometer. It exports > raw accel/magn readings together with scale and sampling frequency. > > Datasheet will be available at: > http://www.kionix.com/6-axis-accelerometer-magnetometer/kmx61 > > Si

[PATCH v2] hid-multitouch: Add quirk for VTL touch panels

2014-11-22 Thread Mathieu Magnaudet
VTL panels do not switch to the multitouch mode until the input mode feature is read by the host. This should normally be done by usbhid, but it looks like an other bug prevents usbhid to properly retrieve the feature state. As a workaround, we force the reading of the feature in mt_set_input_mode

Re: [PATCH v4 6/7] iio: dummy: Demonstrate the usage of new channel types

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > Adds support for the new channel types in the dummy driver: > * a new channel IIO_ACTIVITY > * two state transition events (running and walking) > * a new channel IIO_STEPS and support for reading and writing > pedometer step counter > * step de

Re: [PATCH v4 1/7] iio: dummy: Add virtual registers for dummy device

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > We need a way to store events generated by iio_dummy_evgen module, > in order to correctly process IRQs in iio_simple_dummy_events. > > For the moment, we add two registers: > > * id_reg - ID register, stores the source of the event > * id_data - DATA re

Re: [PATCH v4 2/7] iio: core: Introduce IIO_ACTIVITY channel

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > This channel will be used for exposing information about > activity composite sensors. Activities supported so far: > * running > * jogging > * walking > * still > > THRESHOLD event is used to signal a change in the activity > state

Re: [PATCH v4 3/7] iio: core: Introduce IIO_EV_DIR_NONE

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > From: Irina Tirdea > > For some events (e.g.: step detector) a direction does not make sense. > > Add IIO_EV_DIR_NONE to be used with such events and generate sysfs event > attributes that do not contain direction. > > Signed-off-by: Irina Tirdea > Sig

Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails

2014-11-22 Thread Borislav Petkov
On Sat, Nov 22, 2014 at 09:51:10AM +, Chris Clayton wrote: > Hi, Yeah, next time make sure you actually CC people :-) I've added them to CC now. > Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 > kernel in an i386. The change added a call to > objdump but neglected

Re: [PATCH v4 4/7] iio: core: Introduce STEPS channel, ENABLE mask and INSTANCE event

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > From: Irina Tirdea > > These changes are needed to support the functionality of a pedometer. > A pedometer has two basic functionalities: step counter and step detector. > > The step counter needs to be enabled and then it will count the steps > in its h

Re: [PATCH v4 5/7] iio: core: Introduce IIO_CHAN_INFO_CALIBHEIGHT

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > From: Irina Tirdea > > Some devices need the height of the user to compute various > parameters. One of this devices is Freescale's MMA9553L > (http://www.freescale.com/files/sensors/doc/ref_manual/MMA9553LSWRM.pdf) > that needs the height of the user to

Re: [PATCH v4 6/7] iio: dummy: Demonstrate the usage of new channel types

2014-11-22 Thread Jonathan Cameron
On 22/11/14 11:05, Jonathan Cameron wrote: > On 10/11/14 12:45, Daniel Baluta wrote: >> Adds support for the new channel types in the dummy driver: >> * a new channel IIO_ACTIVITY >> * two state transition events (running and walking) >> * a new channel IIO_STEPS and support for reading and w

Re: [PATCH v4 7/7] iio: event_monitor: Add support for new channel types

2014-11-22 Thread Jonathan Cameron
On 10/11/14 12:45, Daniel Baluta wrote: > We have the following testing scenario: > > $ insmod iio_dummy_evgen.ko > $ insmod iio_dummy.ko > > ./iio_event_monitor /dev/iio:device0 > Event: time: 1412786467971335337, type: activity(running), channel: 0, > evtype: thresh, direction: rising > Event:

getrandom.2: treatment of interrupts

2014-11-22 Thread Heinrich Schuchardt
Hello Theodore, I created the test program below. While running it I issued kill -SIGUSR1 and kill -SIGUSR2 What I found was rather strange. No matter whether specifying GRND_NONBLOCK or not, signals do not interrupt the execution of getrandom() while reading from the /dev/urandom pool.

Re: [PATCH 0/2] kmx61: Small cleanups

2014-11-22 Thread Jonathan Cameron
On 17/11/14 15:09, Daniel Baluta wrote: > On Mon, Nov 17, 2014 at 4:59 PM, Jonathan Cameron wrote: >> >> >> On November 17, 2014 1:18:34 PM GMT+00:00, Daniel Baluta >> wrote: >>> This is a small cleanup patchset, that: >>> * makes it clear that kmx61 uses only the micro part of scale >>>

Re: [PATCH v4 2/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

2014-11-22 Thread Jonathan Cameron
On 18/11/14 08:23, Ivan T. Ivanov wrote: > > On Mon, 2014-11-17 at 23:12 +0100, Hartmut Knaack wrote: >> Ivan T. Ivanov schrieb am 12.11.2014 09:55: >>> On Tue, 2014-11-11 at 23:39 +0100, Hartmut Knaack wrote: Ivan T. Ivanov schrieb am 11.11.2014 09:21: > Hi Hartmut, > > On Mon, 2

[PATCH 1/1] x86: PCI-Calgary: Deletion of an unnecessary check before the function call "free_tce_table"

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 12:55:28 +0100 The free_tce_table() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- ar

Re: [PATCH 1/1 linux-next] iio: common: remove unnecessary sizeof(u8)

2014-11-22 Thread Jonathan Cameron
On 22/11/14 01:26, Hartmut Knaack wrote: > Fabian Frederick schrieb am 16.11.2014 13:33: >> sizeof(u8) is always 1. >> >> Signed-off-by: Fabian Frederick > Acked-by: Hartmut Knaack Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Tha

Re: [PATCH v2 1/5] misc: sensorhub: Add sensorhub driver

2014-11-22 Thread Jonathan Cameron
On 21/11/14 19:38, Arnd Bergmann wrote: > On Friday 21 November 2014 19:19:13 Karol Wrona wrote: >> Sensorhub is MCU dedicated to collect data and manage several sensors. >> Sensorhub is a spi device which provides a layer for IIO devices. It provides >> some data parsing and common mechanism for

Ukranian Linux kernel developers meetup?

2014-11-22 Thread Andrey Utkin
Ukraine residents working on kernel, what about a meetup with some beer/coffee? -- Andrey Utkin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Pleas

Re: [GIT PULL] ftrace/x86: Add frames pointers to trampoline as necessary

2014-11-22 Thread Steven Rostedt
On Fri, 21 Nov 2014 17:35:10 -0800 Linus Torvalds wrote: > On Fri, Nov 21, 2014 at 6:50 AM, Steven Rostedt wrote: > > +.macro create_frame parent rip > > +#ifdef CC_USING_FENTRY > > + pushq \parent > > + pushq %rbp > > + movq %rsp, %rbp > > This is a very strange frame. > > W

[PATCH 1/1] x86: AMD-perf_event: Deletion of unnecessary checks before the function call "free_percpu"

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 14:01:27 +0100 The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 10:08:08AM -0600, Felipe Balbi wrote: > On Fri, Nov 21, 2014 at 01:28:43AM +0400, Alexander Kochetkov wrote: > > In a multimaster environment, after IP software reset, BB-bit value doesn't > > correspond to the current bus state. It may happen what BB-bit will be 0, > > whil

Re: [PATCH 01/11] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-22 Thread Alim Akhtar
Hi Vivek, On Fri, Nov 21, 2014 at 7:05 PM, Vivek Gautam wrote: > USB and Power regulator on Exynos7 require gpios available > in BUS1 pin controller block. > So adding the BUS1 pinctrl support. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > Cc: Linus Walleij > --- > driv

Re: [PATCH 09/11] arm64: exynos: Add bus1 pinctrl node on exynos7

2014-11-22 Thread Alim Akhtar
Hi Vivek, On Fri, Nov 21, 2014 at 7:05 PM, Vivek Gautam wrote: > BUS1 pinctrl provides gpios for usb and power regulator > available on exynos7-espresso board. So add relevant device > node for pinctrl-bus1. > > Signed-off-by: Naveen Krishna Ch > Signed-off-by: Vivek Gautam > --- > arch/arm64/

Re: [PATCH] ipc,sem block sem_lock on sma->lock during sma initialization

2014-11-22 Thread Manfred Spraul
Hi Rik, good catch - I completely forgot to check the initialization On 11/22/2014 04:40 AM, Rik van Riel wrote: newary initializes a bunch of things after the call to ipc_addid, however some things are initialized inside ipc_addid as well Looking closer at newary, I suppose that it should be

Re: [PATCH] Revert "staging: sm7xxfb: remove driver"

2014-11-22 Thread Greg Kroah-Hartman
On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote: > 2) most important - I do not have the hardware. So from the TODO list > dual head and 2D acceleration support will be tough without actually > checking on the hardware. For a driver like this, if you don't have the hardware, I woul

[PATCH 1/1] s390/pci: Deletion of unnecessary checks before the function call "debug_unregister"

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 15:00:55 +0100 The debug_unregister() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/s390/pci/pci_debug

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Alexander Kochetkov
22 нояб. 2014 г., в 16:23, Wolfram Sang написал(а): > Huh, I can't apply this one? Which kernel version is this based on? v.3.13-rc8 It depends on PATCH 1/4 alexander@ubuntu:git.kernel.org.pub.scm.linux.kernel.git.stable.linux-stable$ git log --pretty=oneline --abbrev-commit -6 204c058 i2c: o

Re: Remove Code in psb_drb.h

2014-11-22 Thread Patrik Jakobsson
On Sat, Nov 22, 2014 at 2:45 PM, nick wrote: > Greetings again David and other maintainers, > I am wondering if I can remove the following code below my message in > psb_drv.h as you state it's unneeded in a TODO. > Cheers Nick > /* TODO: To get rid of */ > #define PSB_TT_PRIV0_LIMIT (256*1

Re: [PATCH 1/2] ARM: dts: add pwm node for exynos4412-trats2

2014-11-22 Thread Kukjin Kim
On 11/20/14 23:26, Jaewon Kim wrote: > This patch add PWM(Pulse Width Modulation) node and > handle to use pwm property. > > Signed-off-by: Jaewon Kim > --- > arch/arm/boot/dts/exynos4412-trats2.dts |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-

[Intel-gfx] drm/i915: vblank wait timed out

2014-11-22 Thread Salvatore Sisinni
Hello! It used to be ok but in the last releases of kernel packages for Fedora of 3.16.x and 3.17.x I did notice these WARNINGs. I did not try Vanilla Kernel so I beg your pardon and I seek help since I had already posted an intel_wait_for_vblank issue on fedoraforum several weeks ago [ 101.497

[PATCH percpu/for-3.18-fixes] percpu-ref: fix DEAD flag contamination of percpu pointer

2014-11-22 Thread Tejun Heo
While decoupling ATOMIC and DEAD flags, f47ad4578461 ("percpu_ref: decouple switching to percpu mode and reinit") updated __ref_is_percpu() so that it only tests ATOMIC flag to determine whether the ref is in percpu mode or not; however, while DEAD implies ATOMIC, the two flags are set separately d

[PATCH] KVM: nVMX: nested MSR auto load/restore emulation.

2014-11-22 Thread Wincy Van
Some hypervisors need MSR auto load/restore feature. We read MSRs from vm-entry MSR load area which specified by L1, and load them via kvm_set_msr in the nested entry. When nested exit occurs, we get MSRs via kvm_get_msr, writing them to L1`s MSR store area. After this, we read MSRs from vm-exit M

Re: [PATCH 1/4] ARM: dts: Add usb3503 pinctrl to exynos5250-spring

2014-11-22 Thread Kukjin Kim
On 11/20/14 01:59, Javier Martinez Canillas wrote: > Hello Andreas, > > On 11/19/2014 04:56 PM, Andreas Färber wrote: >> Reported-by: Doug Anderson >> Signed-off-by: Andreas Färber > > Even though the patch is simple and is true that the subject explains > the change, I think that is always goo

Re: [PATCH v2 5/9] percpu: Replace smp_read_barrier_depends() with lockless_dereference()

2014-11-22 Thread Tejun Heo
On Fri, Nov 21, 2014 at 10:05:59AM -0500, Pranith Kumar wrote: > Recently lockless_dereference() was added which can be used in place of > hard-coding smp_read_barrier_depends(). The following PATCH makes the change. > > Signed-off-by: Pranith Kumar Applied to percpu/for-3.19. Thanks. -- teju

Re: FIX ME locking is implemented?

2014-11-22 Thread Kalle Valo
nick writes: > I am wondering why the fix me in the code below still exists as this > code is clearly being locked properly with a spin lock on the lock > related to the created linked list in this code. It would be nice to mention what driver and file you are referring to. So this is from ath6k

[PATCH 2/6] i7core_edac: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 5/6] ib_srpt: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 6/6] dmaengine: ste_dma40: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 4/6] solos-pci: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 3/6] HSI: nokia-modem: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 1/6] NFC: pn533: fix error return code

2014-11-22 Thread Julia Lawall
From: Julia Lawall Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret =

[PATCH 0/6] fix error return code

2014-11-22 Thread Julia Lawall
The complate semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @ok exists@ identifier f,ret,i; expression e; constant c; @@ // identify a function that returns a negative return value at least once. f(...) { ... when any ( return -c@i; | ret = -c@i; ... when !

[PATCH] usb: dwc3: return error code from the most recent call

2014-11-22 Thread Julia Lawall
From: Julia Lawall Copy-paste error from the previous block of error handling code. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; @@ if (IS_ERR(e)) { ... ( ret = PTR_ERR(e); | * ret = PTR_ERR(e1); )

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-22 Thread Kukjin Kim
On 11/22/14 17:40, Kishon Vijay Abraham I wrote: > > On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: >> On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: >>> The series has dependency on >>> a) "[PATCH v7 0/7] Enable support for Samsung Exynos7 SoC" >>>http://www.spinics.n

[PATCH v3 0/4] spi: Add support for Amlogic Meson SPIFC

2014-11-22 Thread Beniamino Galvani
Hi, this patchset adds a driver for the SPIFC (SPI flash controller) available in Amlogic Meson6 and Meson8 SoCs. The driver has been tested on a Meson8 based device to communicate with a Macronix mx25l1606e serial flash. Changes since v2 [ https://lkml.org/lkml/2014/11/17/669 ]: - introduce spi

[PATCH v3 4/4] ARM: dts: meson: add node for SPIFC

2014-11-22 Thread Beniamino Galvani
This adds a node for the SPI Flash Controller to the Amlogic Meson DTS. Signed-off-by: Beniamino Galvani Acked-by: Mark Brown --- arch/arm/boot/dts/meson.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/meson.dtsi b/arch/arm/boot/dts/meson.dtsi index b91e430..

[PATCH v3 2/4] spi: meson: Add device tree bindings documentation for SPIFC

2014-11-22 Thread Beniamino Galvani
This adds documentation of device tree bindings for the Amlogic Meson SPIFC (SPI Flash Controller). Signed-off-by: Beniamino Galvani --- .../devicetree/bindings/spi/spi-meson.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/b

[PATCH v3 3/4] spi: meson: Add support for Amlogic Meson SPIFC

2014-11-22 Thread Beniamino Galvani
This is a driver for the Amlogic Meson SPIFC (SPI flash controller), which is one of the two SPI controllers available on the SoC. It doesn't support DMA and has a 64-byte unified transmit/receive buffer. The device is optimized for interfacing with SPI NOR memories and allows the execution of sta

[PATCH v3 1/4] spi: core: Add spi_transfer_is_last() helper

2014-11-22 Thread Beniamino Galvani
This adds the function spi_transfer_is_last() which can be used by drivers to know whether a given transfer is the last one in the current message. Signed-off-by: Beniamino Galvani --- include/linux/spi/spi.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/spi/spi.h b/inc

Re: Is the list moderated or not?

2014-11-22 Thread Jones, Peter A
Sorry Joe. This list has traditionally always been moderated but I guess something was changed at some point (probably when we joined Intel). I have adjusted the list to be moderated and it behaved as expected in my tests. Thanks for drawing our attention to this! On 11/20/14, 3:48 PM, "Joe Perche

[PATCH 1/1] PowerPC-83xx: Deletion of an unnecessary check before the function call "of_node_put"

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 16:18:20 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/

Re: [PATCH v3] x86/mce: Try printing all machine check banks known before panic

2014-11-22 Thread rui wang
On 11/22/14, Borislav Petkov wrote: > On Sat, Nov 22, 2014 at 10:16:49AM +0800, rui wang wrote: >> I think both possibilities are valid. But experiments show that the >> error logs are not in the dmesg preserved by kdump in /var/crash/ >> after panic and reboot, and not in the mcelog.entry[] array

Re: [PATCH] ipc,sem block sem_lock on sma->lock during sma initialization

2014-11-22 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/22/2014 08:56 AM, Manfred Spraul wrote: > Hi Rik, > > good catch - I completely forgot to check the initialization > > On 11/22/2014 04:40 AM, Rik van Riel wrote: >> >> newary initializes a bunch of things after the call to ipc_addid, >> howev

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-22 Thread Alan Stern
On Fri, 21 Nov 2014, Benson Leung wrote: > Sorry for the delay in my response. I did some more checking of my > particular failure, and my commit message is incorrect. The > usb_kill_urb is actually not the cause of this problem. It does not > result in autosuspend_check() itself, and is only serv

Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails

2014-11-22 Thread Kees Cook
On Sat, Nov 22, 2014 at 3:14 AM, Borislav Petkov wrote: > On Sat, Nov 22, 2014 at 09:51:10AM +, Chris Clayton wrote: >> Hi, > > Yeah, next time make sure you actually CC people :-) > > I've added them to CC now. > >> Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 >>

[PATCH 1/1] video: fbdev-LCDC: Deletion of an unnecessary check before the function call "vfree"

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 22 Nov 2014 16:51:31 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/fbdev/sh_mobile_lcdc

Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup

2014-11-22 Thread Alan Stern
On Sat, 22 Nov 2014, Alan Stern wrote: > There is no USB wrapper for pm_runtime_idle calls, but one could be > added. Still, in the meantime can you check to see what happens if you > add > > pm_runtime_idle(&usbhid->intf->dev); > > in usbhid_close() just after needs_remote_wakeup is set

Re: [PATCH 3/7] pinctrl: pinconf-generic: Allow driver to specify DT params

2014-11-22 Thread Sören Brinkmann
Hi Ivan, On Fri, 2014-11-21 at 09:35AM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-20 at 08:22 -0800, Sören Brinkmann wrote: > > > > > > Also, I hope all my changes here don't break the current behavior. So, > > those 27 driver should still be able to do what they currently do. But I > > h

Re: [PATCH] sony-laptop: add support for Sony Vaio Fit multi-flip laptop/presentation/tablet transformation

2014-11-22 Thread Darren Hart
On Thu, Nov 20, 2014 at 11:51:12AM +0300, Alexander Gavrilenko wrote: > Current mode is exported via sysfs: > /sys/devices/platform/sony-laptop/tablet > Merging with your reply and a few updates from me, you OK with: sony-laptop: Support Sony Vaio Fit multi-flip tablet transformations T

Testing Only; Please Ignore

2014-11-22 Thread Teo En Ming (Zhang Enming)
Testing only, please ignore. Many apologies for the inconvenience caused. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) Singapore Citizen Teo En Ming's 1st Communication to the United Nations Human Rights Council Dated 10 Oct 2014.pdf Description: Adobe PDF document

Re: [PATCH] Revert "staging: sm7xxfb: remove driver"

2014-11-22 Thread Sudip Mukherjee
On Sat, Nov 22, 2014 at 06:00:40AM -0800, Greg Kroah-Hartman wrote: > On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote: > > 2) most important - I do not have the hardware. So from the TODO list > > dual head and 2D acceleration support will be tough without actually > > checking on t

Re: [PATCH] kvm: x86: move assigned-dev.c and iommu.c to arch/x86/

2014-11-22 Thread Paolo Bonzini
On 21/11/2014 22:21, Radim Krčmář wrote: > Now that ia64 is gone, we can hide deprecated device assignment in x86. > > Notable changes: > - kvm_vm_ioctl_assigned_device() was moved to x86/kvm_arch_vm_ioctl() > > The easy parts were removed from generic kvm code, remaining > - kvm_iommu_(un)ma

Re: [PATCH v3] x86/mce: Try printing all machine check banks known before panic

2014-11-22 Thread Borislav Petkov
On Sat, Nov 22, 2014 at 11:32:00PM +0800, rui wang wrote: > But that means mcelog buffer will have to become circular, and we can > only dump the last 32 errors. There must be a reason why it wasn't > designed as circular. Is there? Please do tell because I don't know the reason why. -- Regards/

Bls: May peace and grace never depart from your Home

2014-11-22 Thread Mrs.Aaliyah H. Al-Ghrari
My name is Mrs. Aaliyah H. Al-Ghrari, the surving widow of late mr Al-Ghrari, i have a charity/orphanage proposal for you, your social and financial status is an expection, please contact me on my private email if you are interested and i will send you complete details and procedure of the proje

[PATCH] remove asm-generic arch_bprm_mm_init()

2014-11-22 Thread Dave Hansen
From: Dave Hansen This is a follow-on to commit: https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=x86/mpx&id=62e88b1c00de9cb30d937841ed5debed871070b8 I removed the asm-generic version of arch_unmap() in that patch, but missed arch_bprm_mm_init(). So this broke the build for

Re: [PATCH] can: eliminate banner[] variable and switch to pr_info()

2014-11-22 Thread Oliver Hartkopp
On 22.11.2014 08:42, Jeremiah Mahler wrote: Several CAN modules use a design pattern with a banner[] variable at the top which defines a string that is used once during init to print the banner. The string is also embedded with KERN_INFO which makes it printk() specific. Improve the code by eli

Re: [PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME

2014-11-22 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 01:26:07PM -0800, Andy Lutomirski wrote: > x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set > but not on non-paranoid returns. I suspect that this is a mistake > and that the code only works because int3 is paranoid. > > Setting _TIF_NOTIFY_RESUME in the

Re: 3.18-rc regression: drm/nouveau: use shared fences for readable objects

2014-11-22 Thread Maarten Lankhorst
Hey, Op 22-11-14 om 01:19 schreef Michael Marineau: > On Thu, Nov 20, 2014 at 12:53 AM, Maarten Lankhorst > wrote: >> Op 20-11-14 om 05:06 schreef Michael Marineau: >>> On Wed, Nov 19, 2014 at 12:10 AM, Maarten Lankhorst >>> wrote: Hey, On 19-11-14 07:43, Michael Marineau wrote: >

Re: [PATCH] can: eliminate banner[] variable and switch to pr_info()

2014-11-22 Thread Marc Kleine-Budde
On 11/22/2014 08:42 AM, Jeremiah Mahler wrote: > Several CAN modules use a design pattern with a banner[] variable at the > top which defines a string that is used once during init to print the > banner. The string is also embedded with KERN_INFO which makes it > printk() specific. > > Improve th

Re: [PATCH percpu/for-3.18-fixes] percpu-ref: fix DEAD flag contamination of percpu pointer

2014-11-22 Thread Shaohua Li
On Sat, Nov 22, 2014 at 09:22:42AM -0500, Tejun Heo wrote: > While decoupling ATOMIC and DEAD flags, f47ad4578461 ("percpu_ref: > decouple switching to percpu mode and reinit") updated > __ref_is_percpu() so that it only tests ATOMIC flag to determine > whether the ref is in percpu mode or not; how

Re: [PATCH percpu/for-3.18-fixes] percpu-ref: fix DEAD flag contamination of percpu pointer

2014-11-22 Thread Tejun Heo
On Sat, Nov 22, 2014 at 09:04:48AM -0800, Shaohua Li wrote: ... > > + /* > > +* Theoretically, the following could test just ATOMIC; however, > > +* then we'd have to mask off DEAD separately as DEAD may be > > +* visible without ATOMIC if we race with percpu_ref_kill(). DEAD > > +

Re: [PATCH v4 2/5] x86, traps: Track entry into and exit from IST context

2014-11-22 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 01:26:08PM -0800, Andy Lutomirski wrote: > We currently pretend that IST context is like standard exception > context, but this is incorrect. IST entries from userspace are like > standard exceptions except that they use per-cpu stacks, so they are > atomic. IST entries fr

Re: [RFC] situation with csum_and_copy_... API

2014-11-22 Thread Linus Torvalds
On Fri, Nov 21, 2014 at 8:28 PM, Al Viro wrote: > OK, here's the next bunch. Looks like good patches to me. Not that I actually _tested_ it, or even have a good test-case (yeah, that "historical" ATM fix? I don't think anybody cares ;), but it all seemed sane. Linus -- To u

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Wolfram Sang
On Sat, Nov 22, 2014 at 05:06:10PM +0300, Alexander Kochetkov wrote: > > 22 нояб. 2014 г., в 16:23, Wolfram Sang написал(а): > > > Huh, I can't apply this one? Which kernel version is this based on? > > v.3.13-rc8 Wow, that's old. Can you please rebase the series on top of 3.18-rc4? Or my i2c/

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-22 Thread Darren Hart
On Wed, Nov 19, 2014 at 09:41:20PM +0100, Pali Rohár wrote: > Hello, Hi Pali, > > I removed other lines so mail is not too long. > > On Wednesday 19 November 2014 19:34:16 Darren Hart wrote: ... > > > +} > > > + > > > +static unsigned int kbd_get_max_level(void) > > > +{ > > > + if (kbd_info.le

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-22 Thread Wolfram Sang
Hi, Please quote only relevant parts of the message (like I did). This improves readability a lot. > > +static int i2c_slave_eeprom_slave_cb(struct i2c_client *client, > > +enum i2c_slave_event event, u8 *val) > > +{ > > + struct eeprom_data *eeprom = i2c

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-22 Thread Wolfram Sang
Hi Uwe, please don't quote so much :) > > > + case I2C_SLAVE_REQ_READ_END: > > > + eeprom->buffer_idx++; > > You don't check here for buffer_idx >= ARRAY_SIZE(buffer)? > > Ditto in the I2C_SLAVE_REQ_WRITE_END case. > I just noticed that buffer_idx is an u8, so it overflows at 255+1. So >

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-22 Thread Wolfram Sang
> this mail is thematically more a reply to patch 1 and maybe just serves > my understanding of the slave support. Sure. This shows how badly needed the documentation is :) ... > > + break; > > + > > + case I2C_SLAVE_STOP: > > + eeprom->first_write = true; > > + b

[patch] tracing: remove unneeded NULL check

2014-11-22 Thread Dan Carpenter
We checked "iter->trace" earlier so there is no need to check here. Signed-off-by: Dan Carpenter diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 9ddd6aa..52fbbc5 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3019,7 +3019,7 @@ __tracing_open(struct inode *inode,

[spi/of] WARNING: CPU: 0 PID: 1 at drivers/spi/spi.c:2434 spi_init()

2014-11-22 Thread Fengguang Wu
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is git://git.kernel.org/pub/scm/linux/kernel/git/glikely/linux devicetree/next-overlay commit 9b84294398291359d6c8f4ac4f36c7c666c6948a Author: Pantelis Antoniou AuthorDate: Tue Oct 28 22:36:05 2014 +0200 Comm

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-22 Thread Ivaylo Dimitrov
Hi, Can you capture raw bayer images correctly? I assume green means YUV buffers that are all zero. Do you know more specifically which patch breaks it? CCing freemangordon (Ivaylo Dimitrov). He tried to debug it months ago but without success. Should know more info about this problem. I th

Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

2014-11-22 Thread Pali Rohár
On Friday 21 November 2014 21:39:30 Darren Hart wrote: > On Wed, Nov 19, 2014 at 09:41:20PM +0100, Pali Rohár wrote: > > Hello, > > Hi Pali, > > > I removed other lines so mail is not too long. > > > On Wednesday 19 November 2014 19:34:16 Darren Hart wrote: > ... > > > > > +} > > > > + > > > >

  1   2   >