Re: [PATCH 6/6] fs:sysfs pass NULL as second parameter for set_anon_super

2012-11-29 Thread Greg Kroah-Hartman
On Thu, Nov 29, 2012 at 12:05:45PM +0530, Abhijit Pawar wrote: > set_anon_super does not use the second parameter in its implementation. > So there is no need to pass on the second parameter. Why not just remove the second parameter from the call then? thanks, greg k-h -- To unsubscribe from thi

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread chas williams - CONTRACTOR
On Wed, 28 Nov 2012 22:18:35 + David Woodhouse wrote: > diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c > index 9851093..3720670 100644 > --- a/drivers/atm/solos-pci.c > +++ b/drivers/atm/solos-pci.c > @@ -92,6 +92,7 @@ struct pkt_hdr { > }; > > struct solos_skb_cb { > +

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 16:09 +0100, Krzysztof Mazur wrote: > > I don't like two thinks about this patch: > > - if allos_skb(sizeof(*header), GFP_ATOMIC) at beginning of > pclose() fails we will crash > > - if card wakes up after this timeout we will probably crash too >

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Jiang Liu
On 11/29/2012 06:38 PM, Yasuaki Ishimatsu wrote: > Hi Tony, > > 2012/11/29 6:34, Luck, Tony wrote: >>> 1. use firmware information >>>According to ACPI spec 5.0, SRAT table has memory affinity structure >>>and the structure has Hot Pluggable Filed. See "5.2.16.2 Memory >>>Affinity Stru

RE: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-29 Thread Fujinaka, Todd
Someone else pointed this out to me locally. If you have a non-client BIOS, you should be able to set the MaxPayloadSize using setpci. You have to make sure that you're being consistent throughout all the associated links. Todd Fujinaka Technical Marketing Engineer LAN Access Division (LAD) Inte

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Jiang Liu
Hi Yasuaki, Forgot to mention that I have no objection to this patchset. I think it's a good start point, but we still need to improve usabilities of memory hotplug by passing platform specific information from BIOS. And mechanism provided by this patchset will/may be used to improve usabil

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 10:37 -0500, chas williams - CONTRACTOR wrote: > you shouldnt clear ATM_VF_ADDR until the vpi/vci is actually closed and > ready for reuse. at this point, it isnt. So I should always wait for the completion of my PKT_CLOSE and only clear ATM_VF_ADDR when it's actually done?

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread chas williams - CONTRACTOR
On Thu, 29 Nov 2012 15:47:57 + David Woodhouse wrote: > @@ -1020,12 +1048,15 @@ static uint32_t fpga_tx(struct solos_card *card) > if (vcc) { > atomic_inc(&vcc->stats->tx); > solos_pop(vcc, oldskb); > -

Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized

2012-11-29 Thread Tux9
Hans, I think there are something wrong in your patch, while Vitalii's is right. The variable "ret" is reused in line 292 and line 295, so the value of "ret" would be overridden (if it goto err_map in line 284 when mi>=1). Best, Cong On Wed, Nov 28, 2012 at 10:05 PM, Hans J. Koch wrote: > On Wed

Re: [PATCH] char/tpm: Use true and false for bools

2012-11-29 Thread Kent Yoder
On Thu, Nov 29, 2012 at 01:42:47AM +0100, Peter Huewe wrote: > Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro: > > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote: > > > - itpm = (probe == 0) ? 0 : 1; > > > + itpm = (probe == 0) ? false : true; > > > > Charm

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 03:00 AM, Mel Gorman wrote: > > I've not been paying a whole pile of attention to this because it's not an > area I'm active in but I agree that configuring ZONE_MOVABLE like > this at boot-time is going to be problematic. As awkward as it is, it > would probably work out better to o

Re: [PATCH] gpio: New driver for GPO emulation using PWM generators

2012-11-29 Thread Grant Likely
On Wed, 28 Nov 2012 09:54:57 +0100, Peter Ujfalusi wrote: > Hi Grant, Lars, Thierry, > > On 11/26/2012 04:46 PM, Grant Likely wrote: > > You're effectively asking the pwm layer to behave like a gpio (which > > is completely reasonable). Having a completely separate translation node > > really do

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread chas williams - CONTRACTOR
On Thu, 29 Nov 2012 15:59:08 + David Woodhouse wrote: > On Thu, 2012-11-29 at 10:37 -0500, chas williams - CONTRACTOR wrote: > > you shouldnt clear ATM_VF_ADDR until the vpi/vci is actually closed and > > ready for reuse. at this point, it isnt. > > So I should always wait for the completio

Re: [PATCH 0/3] Volatile Ranges (v7) & Lots of words

2012-11-29 Thread Mike Hommey
On Fri, Nov 02, 2012 at 09:59:07PM +0100, Michael Kerrisk wrote: > John, > > A question at on one point: > > On Wed, Oct 3, 2012 at 12:38 AM, John Stultz wrote: > > On 10/02/2012 12:39 AM, NeilBrown wrote: > [...] > >> The SIGBUS interface could have some merit if it really reduces > >> overhe

Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized

2012-11-29 Thread Vitalii Demianets
On Thursday 29 November 2012 18:05:27 Tux9 wrote: > Hans, I think there are something wrong in your patch, while Vitalii's > is right. The variable "ret" is reused in line 292 and line 295, so > the value of "ret" would be overridden (if it goto err_map in line 284 > when mi>=1). > Actually, both

Re: [BUG] NULL pointer dereference in 3.7-rc7 (syscall_trace_enter)

2012-11-29 Thread Ian Kumlien
On Thu, Nov 29, 2012 at 03:22:20PM +0100, Borislav Petkov wrote: > On Thu, Nov 29, 2012 at 01:27:08PM +0100, Ian Kumlien wrote: > > I think that chrome does traceing all the time as a part of it's > > sandbox - this is most likely chrome monitoring flash... > > Ah, ok. [ --8<--8<-- ] > Right, so

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 10:59 -0500, chas williams - CONTRACTOR wrote: > the part that bothers me (and i dont have the programmer's guide for > the solos hardware) is that you are watching for the PKT_PCLOSE to be > sent to the card. shouldnt you be watching for the PKT_PCLOSE to be > returned from

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Grant Likely
On Mon, 26 Nov 2012 11:20:54 -0700, Jason Gunthorpe wrote: > On Mon, Nov 26, 2012 at 02:03:16PM +, Grant Likely wrote: > > On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe > > wrote: > > > 'assigned-addresses' is used for certain PCI device type nodes in > > > lieu of 'reg', since this

Re: [linux-keystone] [PATCH] watchdog: davinci_wdt: add OF support

2012-11-29 Thread Grant Likely
On Mon, 26 Nov 2012 16:41:35 -0500, Murali Karicheri wrote: > This adds OF support for davinci_wdt driver. > > Signed-off-by: Murali Karicheri Acked-by: Grant Likely > --- > .../devicetree/bindings/watchdog/davinci-wdt.txt | 12 > drivers/watchdog/davinci_wdt.c

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread Krzysztof Mazur
On Thu, Nov 29, 2012 at 03:47:57PM +, David Woodhouse wrote: > On Thu, 2012-11-29 at 16:09 +0100, Krzysztof Mazur wrote: > > > > I don't like two thinks about this patch: > > > > - if allos_skb(sizeof(*header), GFP_ATOMIC) at beginning of > > pclose() fails we will crash > >

[PATCH] cifs: Add handling of blank password option

2012-11-29 Thread Jesper Nilsson
The option to have a blank "pass=" already exists, and with a password specified both "pass=%s" and "password=%s" are supported. Also, both blank "user=" and "username=" are supported, making "password=" the odd man out. Signed-off-by: Jesper Nilsson --- fs/cifs/connect.c | 1 + 1 file changed,

Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized

2012-11-29 Thread Cong Ding
No, there are some exceptions. Imagine this case, when mi=0, everything works correct in the loop, and then mi=1, if the kzalloc in line 286 fails, you patch will goto err_map with ret=-ENOMEM, while Hans's patch will goto err_map with ret=0 (the ret=0 is from line 295 when mi=0). On Thu, Nov 29,

Re: [PATCH v2] drivers/of: Constify device_node->name and ->path_component_name

2012-11-29 Thread Grant Likely
On Wed, 28 Nov 2012 10:46:04 +1100, Michael Neuling wrote: > > Neither of these should ever be changed once set. Make them const and > > fix up the users that try to modify it in-place. In one case > > kmalloc+memcpy is replaced with kstrdup() to avoid modifying the string. > > > > Build tested w

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-11-29 Thread Mark Brown
On Thu, Nov 29, 2012 at 10:35:35AM +0530, Naveen Krishna Chatradhi wrote: > The arbitrator is a general purpose function which uses two GPIOs to > communicate with another device to claim/release a bus. We use it to > arbitrate an i2c port between the AP and the EC. Should this not be layerd on t

Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized

2012-11-29 Thread Vitalii Demianets
> On Thursday 29 November 2012 18:05:27 Tux9 wrote: > > Hans, I think there are something wrong in your patch, while Vitalii's > > is right. The variable "ret" is reused in line 292 and line 295, so > > the value of "ret" would be overridden (if it goto err_map in line 284 > > when mi>=1). > > Actu

Re: [PATCH v3 0/9] Media Controller capture driver for DM365

2012-11-29 Thread Mauro Carvalho Chehab
Em Thu, 29 Nov 2012 18:15:39 +0530 Manjunath Hadli escreveu: > > So, in summary: > > > > Prabhakar/Manju: > > > > If you'll be committed to make sure that no regressions will happen when > > this > > driver will be promoted and replace the existing driver, please update > > the TODO to point t

[PATCH] fs/configfs: allow to create groups on demand

2012-11-29 Thread Sebastian Andrzej Siewior
This patch adds a function add a group to an existing one and its counterart. The newly created group behaves as it would be created via default_groups[] which means the user can't rmdir it. This should be used by the upcomming USB gadget interface in order to add the currently available UDCs as a

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 11:03 +0100, Rafael J. Wysocki wrote: > On Wednesday, November 28, 2012 06:15:42 PM Toshi Kani wrote: > > On Wed, 2012-11-28 at 18:02 -0700, Toshi Kani wrote: > > > On Thu, 2012-11-29 at 00:49 +0100, Rafael J. Wysocki wrote: > > > > On Wednesday, November 28, 2012 02:02:48 PM

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 12:30:30 PM Vasilis Liaskovitis wrote: > On Thu, Nov 29, 2012 at 11:03:05AM +0100, Rafael J. Wysocki wrote: > > On Wednesday, November 28, 2012 06:15:42 PM Toshi Kani wrote: > > > On Wed, 2012-11-28 at 18:02 -0700, Toshi Kani wrote: > > > > On Thu, 2012-11-29 at 00:49

Re: Acpi deadlocks with 3.7.0-rc4

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 01:26:48 PM Zdenek Kabelac wrote: > Dne 29.11.2012 11:59, Rafael J. Wysocki napsal(a): > > On Thursday, November 29, 2012 11:13:10 AM Zdenek Kabelac wrote: > >> Dne 28.11.2012 20:07, Linus Torvalds napsal(a): > >>> whole "prefix_node" pointer is bogus. It seems to hav

Re: [PATCH] cifs: Add handling of blank password option

2012-11-29 Thread Steve French
merged into cifs-2.6.git On Thu, Nov 29, 2012 at 10:31 AM, Jesper Nilsson wrote: > The option to have a blank "pass=" already exists, and with > a password specified both "pass=%s" and "password=%s" are supported. > Also, both blank "user=" and "username=" are supported, making > "password=" the

Re: kswapd craziness in 3.7

2012-11-29 Thread Johannes Weiner
On Thu, Nov 29, 2012 at 04:30:12PM +0100, Thorsten Leemhuis wrote: > Mel Gorman wrote on 29.11.2012 00:54: > > On Wed, Nov 28, 2012 at 02:52:15PM -0800, Andrew Morton wrote: > >> On Wed, 28 Nov 2012 10:13:59 + > >> Mel Gorman wrote: > >> > >> > Based on the reports I've seen I expect the foll

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Paul E. McKenney
On Thu, Nov 29, 2012 at 02:47:52PM +0100, Markus Trippelsdorf wrote: > With gcc-4.8 I get: > > CC kernel/rcutree.o > kernel/rcutree.c: In function ‘rcu_init_one’: > kernel/rcutree.c:2850:13: warning: array subscript is above array bounds > [-Warray-bounds] > rsp->level[i] = rsp->l

Re: 3.7-rc6 soft lockup in kswapd0

2012-11-29 Thread Johannes Weiner
On Thu, Nov 29, 2012 at 09:54:14AM -0500, George Spelvin wrote: > Mel Gorman wrote: > > On Tue, Nov 27, 2012 at 04:25:14PM -0500, George Spelvin wrote: > >> Well, it just made it to 24 hours, > >> it did before. I'm going to wait a couple more days before declaring > >> victory, but it looks goo

RE: [PATCH -next] hv: hv_balloon: remove duplicated include from hv_balloon.c

2012-11-29 Thread KY Srinivasan
> -Original Message- > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Wednesday, November 28, 2012 9:23 PM > To: KY Srinivasan; Haiyang Zhang > Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subject: [PATCH -next] hv: hv_balloon:

Re: [RFC PATCH v3 0/3] acpi: Introduce prepare_remove device operation

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 11:15 +0100, Rafael J. Wysocki wrote: > On Wednesday, November 28, 2012 11:41:36 AM Toshi Kani wrote: > > On Wed, 2012-11-28 at 19:05 +0800, Hanjun Guo wrote: > > > On 2012/11/24 1:50, Vasilis Liaskovitis wrote: > > > > As discussed in https://patchwork.kernel.org/patch/158158

RE: [PATCH -next] hv: hv_balloon: remove duplicated include from hv_balloon.c

2012-11-29 Thread KY Srinivasan
> -Original Message- > From: Wei Yongjun [mailto:weiyj...@gmail.com] > Sent: Wednesday, November 28, 2012 9:23 PM > To: KY Srinivasan; Haiyang Zhang > Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subject: [PATCH -next] hv: hv_balloon:

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread chas williams - CONTRACTOR
On Thu, 29 Nov 2012 16:24:29 + David Woodhouse wrote: > On Thu, 2012-11-29 at 10:59 -0500, chas williams - CONTRACTOR wrote: > > the part that bothers me (and i dont have the programmer's guide for > > the solos hardware) is that you are watching for the PKT_PCLOSE to be > > sent to the card.

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Wed, Nov 28, 2012 at 2:01 PM, Mikulas Patocka wrote: > > This sounds sensible. I'm sending this patch. This looks much better. I think I'll apply this for 3.7 (since it's too late to do anything fancier), and then for 3.8 I will rip out all the locking entirely, because looking at the fs/buff

Re: [PATCH 2/4] Input: RMI4 - move sensor driver and F01 handler into the core

2012-11-29 Thread Dmitry Torokhov
Hi Chris, On Wed, Nov 28, 2012 at 08:54:32PM -0800, Christopher Heiny wrote: > On 11/27/2012 01:21 AM, Dmitry Torokhov wrote: > >There is no point in having the sensor driver and F01 handler separate > >from the RMI core since it is not useful without them and having them > >all together simplifies

[PATCH 1/1] kbuild: solve the DSO link change issue

2012-11-29 Thread Cong Ding
when make menuconfig, it reports this error: /usr/bin/ld: scripts/kconfig/lxdialog/checklist.o: undefined reference to symbol 'acs_map' /usr/bin/ld: note: 'acs_map' is defined in DSO /lib64/libtinfo.so.5 so try adding it to the linker command line /lib64/libtinfo.so.5: could not read symbols: In

Re: [net-next RFC] pktgen: don't wait for the device who doesn't free skb immediately after sent

2012-11-29 Thread Stephen Hemminger
On Thu, 29 Nov 2012 13:30:13 +0200 "Michael S. Tsirkin" wrote: > On Thu, Nov 29, 2012 at 06:13:13PM +0800, Jason Wang wrote: > > On Wednesday, November 28, 2012 08:53:05 AM Stephen Hemminger wrote: > > > On Wed, 28 Nov 2012 14:48:52 +0800 > > > > > > Jason Wang wrote: > > > > On 11/28/2012 12:4

Re: [RFC PATCH v2] Add rcu user eqs exception hooks for async page fault

2012-11-29 Thread Gleb Natapov
On Thu, Nov 29, 2012 at 03:40:05PM +0100, Frederic Weisbecker wrote: > 2012/11/29 Li Zhong : > > On Wed, 2012-11-28 at 13:55 +0100, Frederic Weisbecker wrote: > >> > With rcu_user_exit() at the beginning, now rcu_irq_enter() only protects > >> > the cpu idle eqs, but it's not good to call rcu_irq_e

Re: [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow)

2012-11-29 Thread Chris Mason
On Thu, Nov 29, 2012 at 07:12:49AM -0700, Chris Mason wrote: > On Wed, Nov 28, 2012 at 11:16:21PM -0700, Linus Torvalds wrote: > > On Wed, Nov 28, 2012 at 6:58 PM, Linus Torvalds > > wrote: > > > > > > But the fact that the code wants to do things like > > > > > > block = (sector_t)page->i

Re: [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow)

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 6:12 AM, Chris Mason wrote: > > Jumping in based on Linus original patch, which is doing something like > this: > > set_blocksize() { > block new calls to writepage, prepare/commit_write > set the block size > unblock > > < --- can race in he

[RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Jesper Nilsson
Hi! Connecting with a default security mechanism prompts an KERN_ERROR output warning to the user that the default mechanism will be changed in Linux 3.3. We're now at 3.7, so we either could remove the warning completely (if the default has been changed), or we could bump the number to what our

Re: [PATCH -next] hv: hv_balloon: remove duplicated include from hv_balloon.c

2012-11-29 Thread Greg KH
On Thu, Nov 29, 2012 at 05:09:42PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Wei Yongjun [mailto:weiyj...@gmail.com] > > Sent: Wednesday, November 28, 2012 9:23 PM > > To: KY Srinivasan; Haiyang Zhang > > Cc: yongjun_...@trendmicro.com.cn; de...@linuxdriverproject.o

Re: [3.5.y.z extended stable] Linux 3.5.7.1

2012-11-29 Thread Arkadiusz Miskiewicz
On Thursday 29 of November 2012, Herton Ronaldo Krzesinski wrote: > I am announcing the release of the 3.5.7.1 tree of stable patches. > > This tree picks up the latest 3.5 stable release upstream, and add patches > on top that were later marked for stable but can't be added to 3.5, as > it is not

Re: How about a gpio_get(device *, char *) function?

2012-11-29 Thread Grant Likely
On Wed, 28 Nov 2012 12:38:38 +0900, Alex Courbot wrote: > On Monday 26 November 2012 19:14:31 Grant Likely wrote: > > I don't have any problem with a gpio_get function, but I do agree that > > making it return an opaque handle is how it should be written with a new > > set of accessors. The handle

[PATCH] Input: gpio_keys_polled - switch to using gpio_request_one()

2012-11-29 Thread Dmitry Torokhov
This saves us a few lines of code. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys_polled.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c index d72d0e5..

[PATCH] Input: gpio_keys - switch to using gpio_request_one()

2012-11-29 Thread Dmitry Torokhov
This saves us a few lines of code. Signed-off-by: Dmitry Torokhov --- drivers/input/keyboard/gpio_keys.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 79435de..d327f5a 100644 --- a/driv

RE: [PATCH -next] hv: hv_balloon: remove duplicated include from hv_balloon.c

2012-11-29 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 29, 2012 12:31 PM > To: KY Srinivasan > Cc: Wei Yongjun; Haiyang Zhang; de...@linuxdriverproject.org; > yongjun_...@trendmicro.com.cn; linux-kernel@vger.kernel.org > Subject: Re: [PATCH -ne

[PATCH v2 1/1] uio.c: solve memory leak

2012-11-29 Thread Cong Ding
In version 1, I forgot to modify the same bug in the first loop. we have to call kobject_put() to clean up the kobject after function kobject_init(), kobject_add(), or kobject_uevent() is called. Signed-off-by: Cong Ding --- drivers/uio/uio.c | 16 ++-- 1 files changed, 10 inserti

Re: [PATCH 0/5] Alter steal time reporting in KVM

2012-11-29 Thread Michael Wolf
On 11/28/2012 02:55 PM, Glauber Costa wrote: On 11/28/2012 10:43 PM, Michael Wolf wrote: On 11/27/2012 05:24 PM, Marcelo Tosatti wrote: On Mon, Nov 26, 2012 at 02:36:24PM -0600, Michael Wolf wrote: In the case of where you have a system that is running in a capped or overcommitted environment

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Markus Trippelsdorf
On 2012.11.29 at 09:02 -0800, Paul E. McKenney wrote: > On Thu, Nov 29, 2012 at 02:47:52PM +0100, Markus Trippelsdorf wrote: > > With gcc-4.8 I get: > > > > CC kernel/rcutree.o > > kernel/rcutree.c: In function ‘rcu_init_one’: > > kernel/rcutree.c:2850:13: warning: array subscript is ab

[GIT PULL] cputime: Cleanups on adjusted cputime code

2012-11-29 Thread Frederic Weisbecker
Ingo, Please pull the latest cputime adjustment cleanups that can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git cputime/adjustment-v2 for you to fetch changes up to fa09205783d11cc05122ad6e4ce06074624b2c0c: cputime: Comment cputime's adjusting code

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Ilya Zykov
On 29.11.2012 17:54, Alan Cox wrote: >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c >> index 6c9b7cd..4f02f9c 100644 >> --- a/drivers/tty/tty_buffer.c >> +++ b/drivers/tty/tty_buffer.c >> @@ -114,11 +114,14 @@ static void __tty_buffer_flush(struct tty_struct *tty) >> { >>

[PATCH] mfd: wm5102: Treat future revisions as revision B

2012-11-29 Thread Mark Brown
The expectation is that future revisions will behave as revision B. Signed-off-by: Mark Brown --- drivers/mfd/wm5102-tables.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c index 447b00b..b82a003 100644 --- a/dr

Re: [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow)

2012-11-29 Thread Chris Mason
On Thu, Nov 29, 2012 at 10:26:56AM -0700, Linus Torvalds wrote: > On Thu, Nov 29, 2012 at 6:12 AM, Chris Mason wrote: > > > > Jumping in based on Linus original patch, which is doing something like > > this: > > > > set_blocksize() { > > block new calls to writepage, prepare/commit_write >

Re: [RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Steve French
This has already been changed in the cifs-2.6.git for-next branch. We had run into problems with Apple Server with ntlmv2 so it took longer than expected to test it, and it was too late for 3.7 so the patch to move to ntlmssp encapsulated ntlmv2 which removes this warning is in cifs-2.6.git and qu

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 12:04 +0100, Vasilis Liaskovitis wrote: > Hi, > > On Wed, Nov 28, 2012 at 06:15:42PM -0700, Toshi Kani wrote: > > On Wed, 2012-11-28 at 18:02 -0700, Toshi Kani wrote: > > > On Thu, 2012-11-29 at 00:49 +0100, Rafael J. Wysocki wrote: > > > > On Wednesday, November 28, 2012 02:

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 12:30 +0100, Vasilis Liaskovitis wrote: > On Thu, Nov 29, 2012 at 11:03:05AM +0100, Rafael J. Wysocki wrote: > > On Wednesday, November 28, 2012 06:15:42 PM Toshi Kani wrote: > > > On Wed, 2012-11-28 at 18:02 -0700, Toshi Kani wrote: > > > > On Thu, 2012-11-29 at 00:49 +0100,

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Paul E. McKenney
On Thu, Nov 29, 2012 at 06:43:58PM +0100, Markus Trippelsdorf wrote: > On 2012.11.29 at 09:02 -0800, Paul E. McKenney wrote: > > On Thu, Nov 29, 2012 at 02:47:52PM +0100, Markus Trippelsdorf wrote: > > > With gcc-4.8 I get: > > > > > > CC kernel/rcutree.o > > > kernel/rcutree.c: In functi

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread David Woodhouse
On Thu, 2012-11-29 at 12:17 -0500, chas williams - CONTRACTOR wrote: > most atm hardware that i am familiar with, wont deliver vpi/vci data > unless you are actually trying to receive it. however, this hardware > is generally doing its reassembly in hardware and delivering aal5 > pdu's and needs t

Re: [PATCH] Introduce a method to catch mmap_region (was: Recent kernel "mount" slow)

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 9:51 AM, Chris Mason wrote: > > The bigger question is do we have users that expect to be able to set > the blocksize after mmaping the block device (no writes required)? I > actually feel a little bad for taking up internet bandwidth asking, but > it is a change in behavi

Re: Supermicro X9SRL-F - channel enumeration error & ACPI/firmware bug question

2012-11-29 Thread Bjorn Helgaas
On Thu, Nov 29, 2012 at 1:55 AM, Justin Piszcz wrote: > > > -Original Message- > From: Robert Hancock [mailto:hancock...@gmail.com] > Sent: Wednesday, November 28, 2012 7:55 PM > To: Justin Piszcz > Cc: Bjorn Helgaas; Bruno Prémont; supp...@supermicro.com; > linux-kernel@vger.kernel.org; D

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Markus Trippelsdorf
On 2012.11.29 at 10:10 -0800, Paul E. McKenney wrote: > On Thu, Nov 29, 2012 at 06:43:58PM +0100, Markus Trippelsdorf wrote: > > On 2012.11.29 at 09:02 -0800, Paul E. McKenney wrote: > > > On Thu, Nov 29, 2012 at 02:47:52PM +0100, Markus Trippelsdorf wrote: > > > > With gcc-4.8 I get: > > > > > >

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Mikulas Patocka
On Thu, 29 Nov 2012, Linus Torvalds wrote: > On Wed, Nov 28, 2012 at 2:01 PM, Mikulas Patocka wrote: > > > > This sounds sensible. I'm sending this patch. > > This looks much better. > > I think I'll apply this for 3.7 (since it's too late to do anything > fancier), and then for 3.8 I will ri

Re: [PATCH 2/2] ARM: tegra: moving stuff away from mach/clk.h

2012-11-29 Thread Stephen Warren
On 11/28/2012 11:12 PM, Prashant Gaikwad wrote: > On Tuesday 27 November 2012 12:29 PM, Sivaram Nair wrote: >> This patch moves some stuff away from mach/clk.h to other mach-tegra >> files. This is part of the efforts to get rid of mach/clk.h which in >> turn will help to enable single zImage. >> >

Re: [RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Jeff Layton
On Thu, 29 Nov 2012 18:30:53 +0100 Jesper Nilsson wrote: > Hi! > > Connecting with a default security mechanism prompts an KERN_ERROR > output warning to the user that the default mechanism will be changed > in Linux 3.3. > > We're now at 3.7, so we either could remove the warning completely >

Re: [PATCH] bonding: rlb mode of bond should not alter ARP originating via bridge

2012-11-29 Thread Jay Vosburgh
Zheng Li wrote: >Do not modify or load balance ARP packets passing through balance-alb >mode (wherein the ARP did not originate locally, and arrived via a bridge). > >Modifying pass-through ARP replies causes an incorrect MAC address >to be placed into the ARP packet, rendering peers unable to c

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-29 Thread chas williams - CONTRACTOR
On Thu, 29 Nov 2012 18:11:48 + David Woodhouse wrote: > We do see the 'packet received for unknown VCC' complaint, after we > reboot the host without resetting the card. And as shown in the commit I > just referenced, we rely on the !ATM_VF_READY check in order to prevent > a use-after-free w

Re: [Suggestion] drivers/tty: drivers/char/: for MAX_ASYNC_BUFFER_SIZE

2012-11-29 Thread Greg KH
On Thu, Nov 29, 2012 at 01:57:59PM +0800, Chen Gang wrote: > > And, I really don't understand here, why do you want to change this? > > What is it going to change? And why? > > > > Why: > for the context MGSLPC_INFO *info in drivers/char/pcmcia/synclink_cs.c > info->max_frame_size can be t

Re: [PATCH 1/5] ACPI dock: remove unnecessary newline from exception message

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 11:53 +, Colin King wrote: > From: Colin Ian King > > ACPI_EXCEPTION() already appends a newline, so there is no > need for the failed _DCK messaged to include one too. > > Signed-off-by: Colin Ian King > --- > drivers/acpi/dock.c | 2 +- > 1 file changed, 1 insertion

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-11-29 Thread Stephen Warren
On 11/29/2012 03:21 AM, Terje Bergström wrote: > On 28.11.2012 23:23, Thierry Reding wrote: ... >>> + regs = platform_get_resource(dev, IORESOURCE_MEM, 0); >>> + intr0 = platform_get_resource(dev, IORESOURCE_IRQ, 0); >>> + intr1 = platform_get_resource(dev, IORESOURCE_IRQ, 1); >>> + >>>

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-11-29 Thread Stephen Warren
On 11/29/2012 04:47 AM, Thierry Reding wrote: > On Thu, Nov 29, 2012 at 12:21:04PM +0200, Terje Bergström wrote: >> On 28.11.2012 23:23, Thierry Reding wrote: >>> This could be problematic. Since drivers/video and >>> drivers/gpu/drm are separate trees, this would entail a >>> continuous burden on

Re: [RFC v2 2/8] video: tegra: Add syncpoint wait and interrupts

2012-11-29 Thread Stephen Warren
On 11/29/2012 01:44 AM, Thierry Reding wrote: > On Mon, Nov 26, 2012 at 03:19:08PM +0200, Terje Bergstrom wrote: >> diff --git a/drivers/video/tegra/host/host1x/host1x_intr.c >> b/drivers/video/tegra/host/host1x/host1x_intr.c > [...] >> +/* Spacing between sync registers */ +#define REGISTER_STRID

[PATCH 0/2] Remove __dev* sections from the kernel

2012-11-29 Thread Greg Kroah-Hartman
With the recent work to remove CONFIG_HOTPLUG, we are starting to get a bunch of __devinit section warnings, despite CONFIG_HOTPLUG always being enabled. So lets remove these false warnings by removing the check for them in the modpost.c tool. Also, lets stop marking the sections entirely, so def

Re: [PATCH 1/2] modpost.c: Stop checking __dev* section mismatches

2012-11-29 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman Now that the __dev* sections are not being generated, we don't need to check for them in modpost.c. Signed-off-by: Greg Kroah-Hartman --- scripts/mod/modpost.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/scripts/mod

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Andi Kleen
Kent Overstreet writes: > This implements a refcount with similar semantics to > atomic_get()/atomic_dec_and_test(), that starts out as just an atomic_t > but dynamically switches to per cpu refcounting when the rate of > gets/puts becomes too high. This will only work if you put on the same CPU

[PATCH 1/2] init.h: Remove __dev* sections from the kernel

2012-11-29 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman With the recent work to remove CONFIG_HOTPLUG, we are starting to get a bunch of __devinit section warnings, despite CONFIG_HOTPLUG always being enabled. So, stop marking the sections entirely, by defining them away the section markings in init.h Signed-off-by: Greg Kro

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 10:23 AM, Mikulas Patocka wrote: > > > If you remove that percpu rw lock, you also need to rewrite direct i/o > code. > > In theory, block device direct i/o doesn't need buffer block size at all. > But in practice, it shares a lot of code with filesystem direct i/o, it > re

Re: [RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Jesper Nilsson
On Thu, Nov 29, 2012 at 11:52:03AM -0600, Steve French wrote: > This has already been changed in the cifs-2.6.git for-next branch. > We had run into problems with Apple Server with ntlmv2 so it took > longer than expected to test it, and it was too late for 3.7 so the > patch to move to ntlmssp en

Re: [RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Steve French
On Thu, Nov 29, 2012 at 12:25 PM, Jeff Layton wrote: > On Thu, 29 Nov 2012 18:30:53 +0100 > Jesper Nilsson wrote: > >> Hi! >> >> Connecting with a default security mechanism prompts an KERN_ERROR >> output warning to the user that the default mechanism will be changed >> in Linux 3.3. >> >> We're

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 10:45:04AM -0800, Andi Kleen wrote: > Kent Overstreet writes: > > > This implements a refcount with similar semantics to > > atomic_get()/atomic_dec_and_test(), that starts out as just an atomic_t > > but dynamically switches to per cpu refcounting when the rate of > > get

Re: [PATCH v2] audit: create explicit AUDIT_SECCOMP event type

2012-11-29 Thread Will Drewry
Thanks! Acked-by: Will Drewry On Wed, Nov 28, 2012 at 5:15 PM, Kees Cook wrote: > The seccomp path was using AUDIT_ANOM_ABEND from when seccomp mode 1 > could only kill a process. While we still want to make sure an audit > record is forced on a kill, this should use a separate record type sinc

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Andi Kleen
On Thu, Nov 29, 2012 at 10:57:20AM -0800, Kent Overstreet wrote: > On Thu, Nov 29, 2012 at 10:45:04AM -0800, Andi Kleen wrote: > > Kent Overstreet writes: > > > > > This implements a refcount with similar semantics to > > > atomic_get()/atomic_dec_and_test(), that starts out as just an atomic_t >

Re: [PATCH 00/25] AIO performance improvements/cleanups

2012-11-29 Thread Kent Overstreet
On Wed, Nov 28, 2012 at 04:03:03PM -0800, Zach Brown wrote: > On Wed, Nov 28, 2012 at 08:43:24AM -0800, Kent Overstreet wrote: > > Bunch of performance improvements and cleanups Zach Brown and I have > > been working on. The code should be pretty solid at this point, though > > it could of course u

Re: [PATCH 1/5] device_cgroup: fix locking in devcgroup_destroy()

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > Cc: Tejun Heo > Cc: Serge Hallyn Acked-by: Serge Hallyn > Signed-off-by: Aristeu Rozanski > --- > security/device_cgroup.c |4 > 1 file changed, 4 insertions(+) > > Index: github/security/device_cgroup.c > ==

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2012-11-29 Thread Andi Kleen
Dave Chinner writes: > > Comments, thoughts and flames all welcome. Doing the reclaim per CPU sounds like a big change in the VM balance. Doesn't this invalidate some zone reclaim mode settings? How did you validate all this? -Andi -- a...@linux.intel.com -- Speaking for myself only -- To uns

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 9:19 AM, Linus Torvalds wrote: > > I think I'll apply this for 3.7 (since it's too late to do anything > fancier), and then for 3.8 I will rip out all the locking entirely, > because looking at the fs/buffer.c patch I wrote up, it's all totally > unnecessary. > > Adding a A

Re: [PATCH 2/5] device_cgroup: prepare exception list handling functions for two lists

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > In the following patches, device_cgroup structure will have two sets of > behavior and exceptions list (actual one, another with the local settings) > so rework the functions to use exception list, not a device_cgroup. > > Cc: Tejun Heo > Cc: Serge Ha

[GIT PULL] target fixes for v3.7.0

2012-11-29 Thread Nicholas A. Bellinger
Hi Linus, So just a single target fix for v3.7.0 this time around from Roland to address a aborted command bug w/ tcm_qla2xxx fabric ports. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master Also, there is one outstanding IBLOCK + virtio

Re: vmalloc_sync_all(), 64bit kernel, patches 9c48f1c629ecfa114850c03f875c6691003214de, a79e53d85683c6dd9f99c90511028adc2043031f

2012-11-29 Thread Andi Kleen
Prasad Koya writes: > Hi > > Before going into crashkernel, nmi_shootdown_cpus() calls > register_die_notifier(), which calls vmalloc_sync_all(). I'm seeing > lockup in sync_global_pgds() (init_64.c). From 3.2 and up, > register_die_notifier() is replaced with register_nmi_handler() (patch > 9c48

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 07:59:53PM +0100, Andi Kleen wrote: > On Thu, Nov 29, 2012 at 10:57:20AM -0800, Kent Overstreet wrote: > > On Thu, Nov 29, 2012 at 10:45:04AM -0800, Andi Kleen wrote: > > > Kent Overstreet writes: > > > > > > > This implements a refcount with similar semantics to > > > > a

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Chris Mason
On Thu, Nov 29, 2012 at 12:02:17PM -0700, Linus Torvalds wrote: > On Thu, Nov 29, 2012 at 9:19 AM, Linus Torvalds > wrote: > > > > I think I'll apply this for 3.7 (since it's too late to do anything > > fancier), and then for 3.8 I will rip out all the locking entirely, > > because looking at the

Regression with initramfs and nfsroot (appears to be in the dcache)

2012-11-29 Thread Patrick McLean
With 3.6-rc1 and up, when using a (dracut) initramfs with a read-only nfs root, all accesses to /proc. /sys and /dev return EBUSY. Bisecting finds this commit as where this was introduced: > ee3efa91e240f513898050ef305a49a653c8ed90 is the first bad commit > commit ee3efa91e240f513898050ef305a49a6

Re: [PATCH 1/2] mfd: tps65910: remove unused data

2012-11-29 Thread Laxman Dewangan
On Thursday 29 November 2012 02:18 PM, Kim, Milo wrote: The 'io_mutex' is not used anywhere. The regmap API supports the mutex internally, so no additional mutex required. And 'domain' private data is unnecessary because the irq domain is already registered by using regmap_add_irq_chip()

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Andi Kleen
> The trick is that we don't watch for the refcount hitting 0 until we're > shutting down - so this only works if you keep track of your initial > refcount. As long as we're not shutting down, we know the refcount can't > hit 0 because we haven't released the initial refcount. This seems dangerous

Re: [PATCH 3/3] mfd: tps65910: fix wrong ack_base register

2012-11-29 Thread Laxman Dewangan
On Thursday 29 November 2012 12:12 PM, Kim, Milo wrote: The interrupt status registers of TPS65910/1 should be cleared when the associated interrupt event occurs. This work is done in the regmap irq thread - using 'ack_base' register. The ACK registers should be fixed as status register,

<    1   2   3   4   5   6   >