Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Scott Wood
Kumar Gala wrote: So I'll ask, what serial input are you waiting for from the boot wrapper? The bootwrapper has a command line editing prompt. It's fairly gratuitous in the presence of semi-decent firmware, but it's there nonetheless. -Scott -- To unsubscribe from this list: send the line

Re: [PATCH 1/4] SUNRPC: spin svc_rqst initialization to its own function

2008-01-18 Thread J. Bruce Fields
On Fri, Jan 18, 2008 at 04:48:44PM -0500, Jeff Layton wrote: > On Fri, 18 Jan 2008 15:59:43 -0500 > "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: > > > On Mon, Jan 14, 2008 at 09:05:15AM -0500, Jeff Layton wrote: > > > Move the initialzation in __svc_create_thread that happens prior to > > > thread

Re: [PATCH 1/3] Improve type handling in interrupt handlers

2008-01-18 Thread Rusty Russell
On Saturday 19 January 2008 07:41:41 Jeff Garzik wrote: > You should be using irq_handler_t for all these. Well, these are your drivers, but for mine I dislike the obfuscation. It's not like you can declare the function itself to be an irq_handler_t, so it's a strange turd to drop in a driver.

Re: [PATCH] [5/7] Remove CONFIG_X86_TSC for 32bit II

2008-01-18 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > Andi Kleen <[EMAIL PROTECTED]> writes: > > > The config option protects so little code that it is fairly pointless. > > Also a lot of its code was related to itself only (as in panicing without > > TSC). And TSC less CPUs are completely handled at runtim

Re: crash in kmem_cache_init

2008-01-18 Thread Mel Gorman
On (18/01/08 10:47), Christoph Lameter didst pronounce: > On Thu, 17 Jan 2008, Olaf Hering wrote: > > > early_node_map[1] active PFN ranges > > 1:0 -> 892928 > > Could not find start_pfn for node 0 > > Corrupted min_pfn? > Doubtful. Node 0 has no memory but it is still being initi

something odd in emu10k1/emufx

2008-01-18 Thread Al Viro
In copy_tlv() we have tlv = kmalloc(data[1] * 4 + sizeof(data), GFP_KERNEL); if (!tlv) return NULL; memcpy(tlv, data, sizeof(data)); if (copy_from_user(tlv + 2, _tlv + 2, data[1])) { kfree(tlv); return NULL; } w

[PATCH 0/6] lguest patches for compiling x86_64

2008-01-18 Thread Glauber de Oliveira Costa
Right now, I have lguest in-tree module compiling on x86_64. It's not yet on a sendable state, since the module itself isn't loading. However, this subset of the series is pretty straightforward, and I'm sending it now aiming at reducing the delta size in the future ;-) Have fun, -- To unsubscr

Re: [PATCH 1/10] add missing parameter for lookup_address

2008-01-18 Thread Andi Kleen
On Fri, Jan 18, 2008 at 12:26:13PM -0800, Chris Wright wrote: > * Glauber de Oliveira Costa ([EMAIL PROTECTED]) wrote: > > lookup_address() receives two parameters, but efi_64.c call > > is passing only one. It's actually preventing the tree from compiling > > > > Signed-off-by: Glauber de Oliveir

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
Tejun Heo wrote: > James Bottomley wrote: >> On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: >>> aha152x.c and fdomain are built twice - once for the isa driver and >>> once for the PCMCIA one. Through #ifdefs, the compiled codes are >>> slightly different; thus, global symbols need to be give

Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

2008-01-18 Thread Matt Mackall
On Fri, 2008-01-18 at 22:09 +0100, Ingo Molnar wrote: > * Matt Mackall <[EMAIL PROTECTED]> wrote: > > > > Sounds fine! Don't hesitate to let us know about the lower-hanging > > > fruit you're thinking about. Here are the main things I have so far: > > > > > > * Ideas in the existing Linux-T

Re: [PATCH] cgroup: limit block I/O bandwidth

2008-01-18 Thread Naveen Gupta
>Paul Menage wrote: >> On Jan 18, 2008 7:36 AM, Dhaval Giani <[EMAIL PROTECTED]> wrote: >>> On Fri, Jan 18, 2008 at 12:41:03PM +0100, Andrea Righi wrote: Allow to limit the block I/O bandwidth for specific process containers (cgroups) imposing additional delays on I/O requests for t

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-18 Thread Tejun Heo
Matt Mackall wrote: > On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote: >> And mprintk the following. >> >> code: >> DEFINE_MPRINTK(mp, 2 * 80); >> >> mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(&mp, "ATA %d", 7); >> mprintk_push(&mp, ", %u sectors\n", 1024);

Re: [PATCH 0/10] Tree fixes for PARAVIRT

2008-01-18 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: Why are we rushing so much to do 64-bit paravirt that we are breaking working configurations? If the developement is going to be this chaotic, it should be done and tested out of tree until it can stabilize. x86.git is out of the mainline tree, and it seems to be worki

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

2008-01-18 Thread Linus Torvalds
On Sat, 19 Jan 2008, Anton Salikhmetov wrote: > > The page_check_address() function is called from the > page_mkclean_one() routine as follows: .. and the page_mkclean_one() function is totally different. Lookie here, this is the correct and complex sequence: > entry = ptep_cl

Re: [PATCH 0/10] Tree fixes for PARAVIRT

2008-01-18 Thread Zachary Amsden
On Fri, 2008-01-18 at 22:37 +0100, Ingo Molnar wrote: > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > The first fix is not even specific for PARAVIRT, and it's actually > > > preventing the whole tree from booting. > > > > on CONFIG_EFI, indeed :) > > but in exchange you broke all of 32-bit

CPA self-test failures

2008-01-18 Thread Jeremy Fitzhardinge
When booting under KVM, I get a pile of messages out of the CPA self-test. It makes it to usermode OK though. J Linux version 2.6.24-rc8 ([EMAIL PROTECTED]) (gcc version 4.1.2 20070925 (Red Hat 4.1.2-33)) #1879 SMP PREEMPT Fri Jan 18 11:58:38 PST 2008 BIOS-provided physical RAM map: BIOS-e

Re: PROBLEM: Celeron Core

2008-01-18 Thread Andi Kleen
Chodorenko Michail <[EMAIL PROTECTED]> writes: > I have a laptop "Extensa 5220", with the processor Celeron based on 'core' > technology. > There is ~ / arch/i386/kernel/cpu/cpufreq/p4-clockmod.c in the kernel > source code > but there's no line identification of my CPU for apply freqency change >

Re: [git pull] x86 fixes for v2.6.24

2008-01-18 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > @@ -1088,7 +1088,7 @@ CLEAN_FILES +=vmlinux System.map \ > > .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map > > > > # Directories & files removed with 'make mrproper' > > -MRPROPER_DIRS += include/config include

Re: [PATCH 4/5] x86: Add config variables for SMP_MAX

2008-01-18 Thread Ingo Molnar
* Mike Travis <[EMAIL PROTECTED]> wrote: > >> +config THREAD_ORDER > >> + int "Kernel stack size (in page order)" > >> + range 1 3 > >> + depends on X86_64_SMP > >> + default "3" if X86_SMP_MAX > >> + default "1" > >> + help > >> +Increases kernel stack size. > >> + > > > > Could you p

Re: [PATCH 4/5] x86: Add config variables for SMP_MAX

2008-01-18 Thread Ingo Molnar
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > +config THREAD_ORDER > + int "Kernel stack size (in page order)" > + range 1 3 > + depends on X86_64_SMP > + default "3" if X86_SMP_MAX > + default "1" > + help > + Increases kernel stack size. nack on kernel stack bl

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Alan Cox
On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Alan, > > >> If a freescale watchdog device node is present, reset the watchdog > >> while waiting for serial input. > > > > Why ? We normally rely on user space for watchdog management as only the > > fact user

Re: [PATCH 1/3] Improve type handling in interrupt handlers

2008-01-18 Thread Jeff Garzik
Rusty Russell wrote: This improves typechecking of interrupt handlers by removing unnecessary (void *) casts and storing handlers in correctly-typed variables. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Ash Willis <[EMAIL PROTECTED]> Cc: [EMAIL PROTE

Re: [PATCH 9/10] provide __parainstructions section

2008-01-18 Thread Sam Ravnborg
On Fri, Jan 18, 2008 at 03:20:24PM -0200, Glauber de Oliveira Costa wrote: > This patch adds the __parainstructions section to vmlinux.lds.S. > It's needed for the patching system. > > Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> > --- > arch/x86/kernel/vmlinux_64.lds.S |8 +++

Re: [PATCH 1/10] add missing parameter for lookup_address

2008-01-18 Thread Chris Wright
* Glauber de Oliveira Costa ([EMAIL PROTECTED]) wrote: > lookup_address() receives two parameters, but efi_64.c call > is passing only one. It's actually preventing the tree from compiling > > Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Good catch, I know I don't test with CONFIG

Re: [PATCH 10/10] change function orders in paravirt.h

2008-01-18 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: __pmd, pmd_val and set_pud are used before they are defined (as static) We move them a little up in the file, so it doesn't happen. Hm, in my original patches I put the #ifdef CONFIG_X86_PAE below the PAGETABLE_LEVELS section. Does that work? Or is that an

Re: BUG? 2.6.24-rc*[-mm*] - debugfs subdirs missing on x86_64

2008-01-18 Thread Greg KH
On Fri, Jan 18, 2008 at 03:12:33PM -0500, Lee Schermerhorn wrote: > I searched around the archives and web and didn't find any reports on > this [maybe just missed them?], so I MUST be doing something > wrong/stupid. My config [included] may be the culprit. Apologies for > the long cc list. I'm

BUG? 2.6.24-rc*[-mm*] - debugfs subdirs missing on x86_64

2008-01-18 Thread Lee Schermerhorn
I searched around the archives and web and didn't find any reports on this [maybe just missed them?], so I MUST be doing something wrong/stupid. My config [included] may be the culprit. Apologies for the long cc list. I'm copying the kprobes and blktrace maintainers [addresses from MAINTAINERS]

[PATCH 6/10] provide read and write cr8 paravirt hooks

2008-01-18 Thread Glauber de Oliveira Costa
Since the cr8 manipulation functions ended up staying in the tree, they can't be defined just when PARAVIRT is off: In this patch, those functions are defined for the PARAVIRT case too. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> --- include/asm-x86/system.h | 30 ++

[PATCH 4/10] put generic mm_hooks include into PARAVIRT

2008-01-18 Thread Glauber de Oliveira Costa
With PARAVIRT, we actually have arch_{dup,exit}_mmap functions, so we can't include the generic header Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> --- include/asm-x86/mmu_context_64.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/asm-x86/mmu_co

[PATCH 2/10] add stringify header

2008-01-18 Thread Glauber de Oliveira Costa
We use a __stringify construction at paravirt_patch_64.c. It's better practice to include the stringify header directly Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> --- arch/x86/kernel/paravirt_patch_64.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arc

Re: [PATCH 4/5] x86: Add config variables for SMP_MAX

2008-01-18 Thread Ingo Oeser
Hi Mike, On Friday 18 January 2008, [EMAIL PROTECTED] wrote: > +config THREAD_ORDER > + int "Kernel stack size (in page order)" > + range 1 3 > + depends on X86_64_SMP > + default "3" if X86_SMP_MAX > + default "1" > + help > + Increases kernel stack size. > + Could

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-18 Thread Mike Snitzer
On Jan 18, 2008 12:46 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 18 Jan 2008, Mel Gorman wrote: > > > > Right, and this is consistent with other complaints about the PFN of the > > page mattering to some hardware. > > I don't think it's actually the PFN per se. > > I think it's sim

Re: [PATCH 1/5] x86: Change size of node ids from u8 to u16 fixup

2008-01-18 Thread Mike Travis
Jan Engelhardt wrote: > On Jan 18 2008 10:30, [EMAIL PROTECTED] wrote: >> --- a/include/linux/numa.h >> +++ b/include/linux/numa.h >> @@ -10,4 +10,10 @@ >> >> #define MAX_NUMNODES(1 << NODES_SHIFT) >> >> +#if MAX_NUMNODES > 256 >> +typedef u16 numanode_t; >> +#else >> +typedef u8 numanode_t; >>

Re: SLUB: Increasing partial pages

2008-01-18 Thread Matthew Wilcox
On Wed, Jan 16, 2008 at 02:01:08PM -0800, Christoph Lameter wrote: > Dec 6th? I was on vacation then and it seems that I was unable to > reproduce the oopses. Can I get some backtraces or other information > that would allow me to diagnose the problem? I've found one backtrace which seems to be

Re: [PATCH] Documentation: mention email-clients.txt in SubmittingPatches

2008-01-18 Thread Randy Dunlap
On Fri, 18 Jan 2008 11:20:02 +0100 Michael Opdenacker wrote: > Applies to 2.6.24-rc8-git2 > > I was struggling to get my email-client no to mangle my patch files, > and I didn't find enough information in the SubmittingPatches file. > By looking for more information on the web, I eventually found

Re: [PATCH 1/1] Net: e100, fix iomap mem accesses

2008-01-18 Thread Jeff Garzik
Jiri Slaby wrote: readX functions are not permitted on iomap-ped space change to ioreadX, also pci_unmap pci_map-ped space on exit (instead of iounmap). Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- drivers/net/e100.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH] Add chip driver for WM9705 touchscreen

2008-01-18 Thread Mark Brown
Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> Signed-off-by: Graeme Gregory <[EMAIL PROTECTED]> Signed-off-by: Mike Arthur <[EMAIL PROTECTED]> Signed-off-by: Mark Brown <[EMAIL PROTECTED]> Cc: Stanley Cai <[EMAIL PROTECTED]> Cc: Rodolfo Giometti <[EMAIL PROTECTED]> Cc: Russell King <[EMAIL PROTE

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-18 Thread Linus Torvalds
On Fri, 18 Jan 2008, Martin Knoblauch wrote: > > just to make one thing clear - I am not so much concerned about the > performance of AACRAID. It is OK with or without Mel's patch. It is > better with Mel's patch. The regression in DIO compared to 2.6.19.2 is > completely independent of Mel's st

Re: [git pull] x86 fixes for v2.6.24

2008-01-18 Thread Sam Ravnborg
On Fri, Jan 18, 2008 at 04:48:09PM +0100, Ingo Molnar wrote: > > Linus, please pull the latest x86 git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git > > two fixes: a "make mrproper" bug and a new cpuid for oprofile, both > build/boot tested. > > In

Re: Why not creating a GIT RT tree ?

2008-01-18 Thread Steven Rostedt
On Fri, 18 Jan 2008, Francis Moreau wrote: > > > > The answer to this is pretty much the same as why the -mm tree isn't in > > git either. > > > > Well not exactly. Unlike the mm tree which is made of a lots of patches > dealing with totaly unrelated subjects, the rt patches only hopefully deal >

Re: Why is the kfree() argument const?

2008-01-18 Thread ecolbus
Olivier Galibert wrote: > On Fri, Jan 18, 2008 at 05:45:49PM +0100, [EMAIL PROTECTED] wrote: > > The malloc attribute is exactly about this : giving the compiler the > > indication that no other pointer aliases this object, allowing for > > better optimizations. > > If you put a malloc attribute

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-18 Thread Matt Mackall
On Fri, 2008-01-18 at 11:44 -0700, Matthew Wilcox wrote: > On Fri, Jan 18, 2008 at 12:41:08PM -0600, Matt Mackall wrote: > > On Wed, 2008-01-16 at 10:00 +0900, Tejun Heo wrote: > > > And mprintk the following. > > > > > > code: > > > DEFINE_MPRINTK(mp, 2 * 80); > > > > > > mprintk_set_heade

Re: Why is the kfree() argument const?

2008-01-18 Thread Vadim Lobanov
On Friday 18 January 2008 03:47:01 am Giacomo A. Catenazzi wrote: > Changing the name of variables in your example: > > extern print_int(const int *); > > int main(int argc, char **argv) > { >extern int errno; > >errno = 0; >print_int(&i); >return errno; > } Except that changing in

Re: Why is the kfree() argument const?

2008-01-18 Thread Chris Friesen
David Schwartz wrote: 2) The 'kfree' operation changes the logical state of the object pointed to, as the object goes from existent to non-existent. I don't think that kfree() itself changes the state of the object. It doesn't call a destructor or anything like that, so the object itself mu

Re: [Patch] document ext3 requirements (was Re: [RFD] Incremental fsck)

2008-01-18 Thread Ric Wheeler
Theodore Tso wrote: On Thu, Jan 17, 2008 at 04:31:48PM -0800, Bryan Henderson wrote: But I heard some years ago from a disk drive engineer that that is a myth just like the rotational energy thing. I added that to the discussion, but admitted that I haven't actually seen a disk drive write a p

[PATCH 0/2] Relax restrictions on setting CONFIG_NUMA on x86

2008-01-18 Thread Mel Gorman
A fix[1] was merged to the x86.git tree that allowed NUMA kernels to boot on normal x86 machines (and not just NUMA-Q, Summit etc.). I took a look at the restrictions on setting NUMA on x86 to see if they could be lifted. The following two patches remove the restrictions on pagetable layout and ar

Re: Why is the kfree() argument const?

2008-01-18 Thread Olivier Galibert
On Fri, Jan 18, 2008 at 05:45:49PM +0100, [EMAIL PROTECTED] wrote: > The malloc attribute is exactly about this : giving the compiler the > indication that no other pointer aliases this object, allowing for > better optimizations. If you put a malloc attribute on the allocator and no free attribut

Re: [PATCH 0/3] enhanced ESTALE error handling

2008-01-18 Thread Peter Staubach
Chuck Lever wrote: On Jan 18, 2008, at 12:30 PM, Peter Staubach wrote: Chuck Lever wrote: On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote: Chuck Lever wrote: Hi Peter- On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote: Hi. Here is a patch set which modifies the system to enhance the ES

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-18 Thread Andi Kleen
On Fri, Jan 18, 2008 at 08:46:02AM -0800, Jesse Barnes wrote: > On Friday, January 18, 2008 5:12 am Andi Kleen wrote: > > > (AMD machines apparently don't need it > > > > That's not true -- we had AMD systems in the past with broken MTRRs for > > large memory configurations too, Mostly it was pre

Re: UML is leaking memory in arch_dup_mmap

2008-01-18 Thread Jeff Dike
On Fri, Jan 18, 2008 at 03:42:54PM +0100, Miklos Szeredi wrote: > uml:~# grep arch_dup_mmap /proc/slab_allocators > size-32: 10861 arch_dup_mmap+0x9f/0x130 Whoops - try the patch below. Jeff -- Work email - jdike at linux dot intel dot com Index: linux-2.6.22/a

Re: [PATCH] printk deadlocks if called with runqueue lock held

2008-01-18 Thread Jan Kiszka
Steven Rostedt wrote: ... > @@ -978,7 +980,13 @@ void release_console_sem(void) > console_locked = 0; > up(&console_sem); Hmm, just looking at this fragment: Doesn't up() include the risk of running onto the runqueue lock as well? > spin_unlock_irqrestore(&logbuf_lock, flags); >

Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-18 Thread Steven Rostedt
On Fri, 18 Jan 2008, Frank Ch. Eigler wrote: > > All this complexity is to be justified by keeping the raw prev/next > pointers from being sent to a naive tracer? It seems to me way out of > proportion. Damn, and I just blew away all my marker code for something like this ;-) Actually, you jus

Re: Why is the kfree() argument const?

2008-01-18 Thread Jakob Oestergaard
On Fri, Jan 18, 2008 at 12:47:01PM +0100, Giacomo A. Catenazzi wrote: ... > "restrict" exists for this reason. const is only about lvalue. You think that I try to put more meaning into const than I do - but I don't. Please read what I wrote, not what you want to think I wrote. I agree that if I

Re: [Announce] Development release 0.1 of the LatencyTOP tool

2008-01-18 Thread Zan Lynx
On Fri, 2008-01-18 at 09:36 -0800, Arjan van de Ven wrote: > The Intel Open Source Technology Center is pleased to announce the > release of version 0.1 of LatencyTOP, a tool for developers to visualize > system latencies. > > http://www.latencytop.org > > Slow servers, Skipping audio, Jerky vid

Re: regression: 100% io-wait with 2.6.24-rcX

2008-01-18 Thread Martin Knoblauch
--- Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 18 Jan 2008, Mel Gorman wrote: > > > > Right, and this is consistent with other complaints about the PFN > > of the page mattering to some hardware. > > I don't think it's actually the PFN per se. > > I think it's simply that some c

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

2008-01-18 Thread Miklos Szeredi
> > That would need a new page flag (PG_mmap_dirty?). Do we have one > > available? > > Yeah, that would be bad. We probably have flags free, but those page flags > are always a pain. Scratch that. > > How about just setting a per-vma dirty flag, and then instead of updating > the mtime when t

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:47:05AM -0800, Venki Pallipadi wrote: > >This exclusion is going to be a real pain in the ass for > >distro kernels. > >It's impossible for example to build a kernel that will now support > >the MTRR-alike registers on the AMD K6/early Cyrix etc and also > >support

Re: [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses

2008-01-18 Thread Christoph Lameter
On Fri, 18 Jan 2008, Andi Kleen wrote: > On Friday 18 January 2008 19:30:16 [EMAIL PROTECTED] wrote: > > Provide a means to trap usages of per_cpu map variables before > > they are setup. Define CONFIG_DEBUG_PER_CPU_MAPS to activate. > > Are you sure that debug option is generally useful enough

Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-18 Thread Frank Ch. Eigler
Hi - On Fri, Jan 18, 2008 at 06:19:29PM -0500, Mathieu Desnoyers wrote: > [...] > Almost.. I would add : > > static int trace_switch_to_enabled; > > > static inline trace_switch_to(struct task_struct *prev, > > struct task_struct *next) > > { > if (likely(!trace_switch_to

Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-18 Thread Frank Ch. Eigler
Hi - On Fri, Jan 18, 2008 at 05:49:19PM -0500, Steven Rostedt wrote: > [...] > > But I have not seen a lot of situations where that kind of glue-code was > > needed, so I think it makes sense to keep markers simple to use and > > efficient for the common case. > > > > Then, in this glue-code, we c

Re: [PATCH] X86: fix typo PAT to X86_PAT

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 10:02:10PM +0100, Ingo Molnar wrote: > > * Dave Jones <[EMAIL PROTECTED]> wrote: > > > > you mean modifies MTRRs? Which code is that? (besides the > > > /proc/mtrr userspace API) > > > > This exclusion is going to be a real pain in the ass for distro > > kerne

Re: [PATCH] x86: make clflush a required feature on x86_64

2008-01-18 Thread Andi Kleen
On Fri, Jan 18, 2008 at 08:56:43AM -0500, H. Peter Anvin wrote: > Andi Kleen wrote: > >>Simulators can be fixed, > > > >They could, but why? I don't know of a good reason to require CLFLUSH. > > Well, simulators are generally expected to follow the architecture, not > vice versa. I would tend t

Re: [PATCH -mm 1/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap - enhance bt_ioremap

2008-01-18 Thread Ian Campbell
On Fri, 2008-01-18 at 09:27 -0800, Jeremy Fitzhardinge wrote: > Ingo Molnar wrote: > > * Ian Campbell <[EMAIL PROTECTED]> wrote: > > > > > >>> Eric Biederman had a patchset that makes a PAE kernel use PAE page > >>> tables from the start. That is really The Right Thing[TM]. > >>> > >>

RE: [ofa-general] InfiniBand/RDMA merge plans for 2.6.25

2008-01-18 Thread Sean Hefty
>> Sean Hefty (6): >> IB/mad: Fix incorrect access to items on local_list > >It wasn't clear to me that this issue was ever really nailed. Was the >loop on this closed ? The error that this patches addresses is fairly obvious if you inspect the code. There's a strong chance that the patch fi

[patch 1/3] LatencyTOP infrastructure patch

2008-01-18 Thread Arjan van de Ven
This patch is the core LatencyTOP kernel infrastructure; it measures latencies in the scheduler and tracks it system wide and per process --- fs/proc/base.c | 61 + include/linux/latencytop.h | 62 + include/linux/sched.h |6 kernel/Makefile|

[Announce] Development release 0.1 of the LatencyTOP tool

2008-01-18 Thread Arjan van de Ven
The Intel Open Source Technology Center is pleased to announce the release of version 0.1 of LatencyTOP, a tool for developers to visualize system latencies. http://www.latencytop.org Slow servers, Skipping audio, Jerky video --everyone knows the symptoms of latency. But to know what's really go

Re: [PATCH 1/3] enhanced ESTALE error handling

2008-01-18 Thread Peter Staubach
J. Bruce Fields wrote: On Fri, Jan 18, 2008 at 11:45:52AM -0500, Peter Staubach wrote: Matthew Wilcox wrote: On Fri, Jan 18, 2008 at 10:36:01AM -0500, Peter Staubach wrote: static int path_lookup_create(int dfd, const char *name, - unsigned int looku

Re: [PATCH] printk deadlocks if called with runqueue lock held

2008-01-18 Thread Linus Torvalds
On Fri, 18 Jan 2008, Jan Kiszka wrote: > Steven Rostedt wrote: > ... > > @@ -978,7 +980,13 @@ void release_console_sem(void) > > console_locked = 0; > > up(&console_sem); > > Hmm, just looking at this fragment: Doesn't up() include the risk of > running onto the runqueue lock as well? I

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Scott Wood schrieb: +void watchdog_poke(void) +{ +if (wdt) { +out_be16(&wdt->swsrr, 0x556c); +out_be16(&wdt->swsrr, 0xaa39); +} +} This should be a function pointer, to allow for other watchdog types. Thanks for the comments. Stephen Rothwell also asked if the filenam

Re: [PATCH 0/3] enhanced ESTALE error handling

2008-01-18 Thread Peter Staubach
Chuck Lever wrote: On Jan 18, 2008, at 11:55 AM, Peter Staubach wrote: Chuck Lever wrote: Hi Peter- On Jan 18, 2008, at 10:35 AM, Peter Staubach wrote: Hi. Here is a patch set which modifies the system to enhance the ESTALE error handling for system calls which take pathnames as arguments.

Re: [PATCH -mm 1/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap - enhance bt_ioremap

2008-01-18 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: * Ian Campbell <[EMAIL PROTECTED]> wrote: Eric Biederman had a patchset that makes a PAE kernel use PAE page tables from the start. That is really The Right Thing[TM]. That's much saner than dup'ing up the early ioremap stuff to support both PAE and non-PAE at run

Re: [2.6.24 patch] x86: allow 64bit setting in Kconfig

2008-01-18 Thread Adrian Bunk
On Fri, Jan 18, 2008 at 06:00:37PM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > # Select 32 or 64 bit > > > config 64BIT > > > - bool "64-bit kernel" if ARCH = "x86" > > > + bool "64-bit kernel" > > > def

[PATCH] [7/7] Add generic clearcpuid=... option

2008-01-18 Thread Andi Kleen
Add a generic option to clear any cpuid bit. I added it because it was very easy to add with the new generic cpuid disable bitmap and perhaps it will be useful in the future. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt | 13 + arch/x86/ker

Re: Why is the kfree() argument const?

2008-01-18 Thread Andy Lutomirski
Giacomo Catenazzi wrote: And to demostrate that Linus is not the only person with this view, I copy some paragraphs from C99 rationale (you can find standard, rationale and other documents in http://clc-wiki.net/wiki/C_standardisation:ISO ) Page 75 of C99 rationale: Type qualifiers were introdu

Re: [REGRESSION] 2.6.24-rc7: e1000: Detected Tx Unit Hang

2008-01-18 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Fri, 18 Jan 2008 14:00:57 +0100 > I don't understand the idea with semaphore for enabling/disabling > irq's either the overall logic must safer/better without it. They must have had code paths where they didn't know if IRQs were enabled or not al

Re: 2.6.24-rc8-mm1: broken suspend (due to git-cpufreq.patch)

2008-01-18 Thread Dave Jones
On Fri, Jan 18, 2008 at 02:34:59PM +0100, Rafael J. Wysocki wrote: > On Thursday, 17 of January 2008, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > > > > - selinux is busted on one of my two selinux-enabled test machin

Re: Why is the kfree() argument const?

2008-01-18 Thread Björn Steinbrink
On 2008.01.18 10:48:26 +0100, Jakob Oestergaard wrote: > On Thu, Jan 17, 2008 at 01:25:39PM -0800, Linus Torvalds wrote: > ... > > Why do you make that mistake, when it is PROVABLY NOT TRUE! > > > > Try this trivial program: > > > > int main(int argc, char **argv) > > { > > in

Re: crash in kmem_cache_init

2008-01-18 Thread Christoph Lameter
On Thu, 17 Jan 2008, Olaf Hering wrote: > Normal 892928 -> 892928 > Movable zone start PFN for each node > early_node_map[1] active PFN ranges > 1:0 -> 892928 > Could not find start_pfn for node 0 We only have a single node that is node 1? And then we initialize nodes 0 to

Re: [PATCH 5/5] x86: Add debug of invalid per_cpu map accesses

2008-01-18 Thread Mike Travis
Andi Kleen wrote: > On Friday 18 January 2008 19:30:16 [EMAIL PROTECTED] wrote: >> Provide a means to trap usages of per_cpu map variables before >> they are setup. Define CONFIG_DEBUG_PER_CPU_MAPS to activate. > > Are you sure that debug option is generally useful enough > to merge? It seems ver

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Jochen Friedrich
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux k

2.6.24-rc8 oops ext3_clear_inode+0x25/0xa0

2008-01-18 Thread Soeren Sonnenburg
Dear all, I've just got this oops (causing the machine to hang finally)... Any ideas? Soeren BUG: unable to handle kernel paging request at virtual address 66e88e66 printing eip: c01fac85 *pde = Oops: 0002 [#1] PREEMPT SMP Modules linked in: hci_usb hidp rfcomm l2cap bluetooth tun cpu

Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.

2008-01-18 Thread Alan Cox
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves

Re: crash in kmem_cache_init

2008-01-18 Thread Christoph Lameter
On Fri, 18 Jan 2008, Olaf Hering wrote: > calls cache_grow with nodeid 0 > > [c075bbd0] [c00f82d0] .cache_alloc_refill+0x234/0x2c0 > calls cache_grow with nodeid 0 > > [c075bbe0] [c00f7f38] .cache_alloc_node+0x17c/0x1e8 > > calls cache_grow with nodeid 1 > > [c

Re: [PATCH] update checkpatch.pl to version 0.13

2008-01-18 Thread Benny Halevy
On Jan. 18, 2008, 13:37 +0200, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote: >> On Thu, 17 Jan 2008 16:23:51 - Andy Whitcroft <[EMAIL PROTECTED]> wrote: >> >>> This version brings a large number of fixes which have built up over >>> t

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-18 Thread Andi Kleen
> (AMD machines apparently don't need it That's not true -- we had AMD systems in the past with broken MTRRs for large memory configurations too, Mostly it was pre revE though. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: [PATCH 1/2] x86: move warning message of polling idle and HT enabled

2008-01-18 Thread Ingo Molnar
* Hiroshi Shimamoto <[EMAIL PROTECTED]> wrote: > The warning message at idle_setup() is never shown because > smp_num_sibling hasn't been updated at this point yet. > > Move this polling idle and HT enabled warning to > select_idle_routine(). I also implement this warning on 64-bit kernel. th

Re: build #343 issue for v2.6.24-rc8-29-g03bbe08 : Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87')

2008-01-18 Thread WANG Cong
On Fri, Jan 18, 2008 at 01:46:27PM +0100, Sam Ravnborg wrote: >On Fri, Jan 18, 2008 at 08:29:17PM +0800, WANG Cong wrote: >> On Fri, Jan 18, 2008 at 01:18:27PM +0100, Toralf Förster wrote: >> >Hello, >> > >> >the build with the attached .config was successful however I got during >> >make : >> >

Re: [PATCH -mm 1/3] i386 boot: replace boot_ioremap with enhanced bt_ioremap - enhance bt_ioremap

2008-01-18 Thread Ingo Molnar
* Ian Campbell <[EMAIL PROTECTED]> wrote: > Shouldn't these, and the rest of the file, be using the PTE accessor > macros set_pte,clear_pte etc? The boot_ioremap it replaces seems to > have done. Otherwise these patches don't appear to be paravirt_ops > clean. I haven't had a chance to investi

Re: [PATCH] cgroup: limit block I/O bandwidth

2008-01-18 Thread Paul Menage
On Jan 18, 2008 7:36 AM, Dhaval Giani <[EMAIL PROTECTED]> wrote: > On Fri, Jan 18, 2008 at 12:41:03PM +0100, Andrea Righi wrote: > > Allow to limit the block I/O bandwidth for specific process containers > > (cgroups) imposing additional delays on I/O requests for those processes > > that exceed th

Re: [PATCH] cgroup: limit block I/O bandwidth

2008-01-18 Thread Dhaval Giani
On Fri, Jan 18, 2008 at 12:41:03PM +0100, Andrea Righi wrote: > Allow to limit the block I/O bandwidth for specific process containers > (cgroups) imposing additional delays on I/O requests for those processes > that exceed the limits defined in the control group filesystem. > > Example: > # mkd

Re: [PATCH] x86: fold _PAGE_GLOBAL into __PAGE_KERNEL

2008-01-18 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > With the iounmap problem resolved, it should be OK to always set > _PAGE_GLOBAL in __PAGE_KERNEL*. thanks Jeremy, applied. > [ Did this patch cause problems before? ] not that i remember. Ingo -- To unsubscribe from this list: send t

[PATCH] [3/7] Don't disable RDTSC in userland for 32bit notsc

2008-01-18 Thread Andi Kleen
Modern 32bit userland doesn't even boot when the TSC is disabled because ld.so tends to contain RDTSCs. So make notsc only effective for the kernel, similar to 64bit. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/cpu/common.c |1 - 1 file changed, 1 deletion(-) Index:

Re: Why is the kfree() argument const?

2008-01-18 Thread Olivier Galibert
On Fri, Jan 18, 2008 at 08:53:44AM -0500, Andy Lutomirski wrote: > I'd say this implies the exact opposite. It almost sounds like the > compiler is free to change: > > void foo(const int *x); > foo(x); > printf("%d", x); > > to: > > void foo(const int *x); > printf("%d", x); > foo(x); That's

Re: [PATCH] Core driver for WM97xx touchscreens

2008-01-18 Thread Dmitry Torokhov
Hi Mark, On Fri, Jan 18, 2008 at 04:27:06PM +, Mark Brown wrote: > This patch series adds support for the touchscreen controllers provided > by Wolfson Microelectronics WM97xx series chips in both polled and > streaming modes. > Thank you for the patches. Some comments below. > +static int w

mount: can not restrict mode of iso9660 files

2008-01-18 Thread Ilya N. Golubev
Versions: `2.6.17-1.2142_FC4' (fedora core) for x86_64; `kernel-syms-2.6.22.5-31' (opensuse 10.3) for i586. File system may contain data not to let any logged in user read. Wish to specify more restrictive mode of files in it - files of all types, including not only regular ones, but also directo

Re: [Announce] Development release 0.1 of the LatencyTOP tool

2008-01-18 Thread Arjan van de Ven
Roberto Fichera wrote: At 18.36 18/01/2008, Arjan van de Ven wrote: The Intel Open Source Technology Center is pleased to announce the release of version 0.1 of LatencyTOP, a tool for developers to visualize system latencies. http://www.latencytop.org [...snip...] The most basic annotation

Re: [patch 02/11] PAT x86: Map only usable memory in x86_64 identity map and kernel text

2008-01-18 Thread Dave Jones
On Thu, Jan 10, 2008 at 05:50:41PM -0500, [EMAIL PROTECTED] wrote: > (Personally, I keep a copy of Arjan's "restrict devmem" patch from Fedora > around, so I guess that says which camp I belong in, and the fact it's a > Fedora > patch and not mainstream says something too...) The way that pa

[PATCH 0/7] percpu: Per cpu code simplification fixup

2008-01-18 Thread travis
This patchset simplifies the code that arches need to maintain to support per cpu functionality. Most of the code is moved into arch independent code. Only a minimal set of definitions is kept for each arch. The patch also unifies the x86 arch so that there is only a single asm-x86/percpu.h Base

[PATCH 1/7] Modules: Fold percpu_modcopy into module.c

2008-01-18 Thread travis
percpu_modcopy() is defined multiple times in arch files. However, the only user is module.c. Put a static definition into module.c and remove the definitions from the arch files. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Christoph Lameter <[EMAIL PRO

[PATCH 5/5] x86: Add debug of invalid per_cpu map accesses

2008-01-18 Thread travis
Provide a means to trap usages of per_cpu map variables before they are setup. Define CONFIG_DEBUG_PER_CPU_MAPS to activate. Signed-off-by: Mike Travis <[EMAIL PROTECTED]> --- arch/x86/Kconfig.debug | 12 arch/x86/mm/numa_64.c |3 +++ include/asm-x86/topology.h |7

<    1   2   3   4   5   6   7   >