Re: [PATCH] Documentation: fix getdelays.c example -l option and segv

2007-08-15 Thread Balbir Singh
Michael Neuling wrote: > Fix a couple of minor issues with the getdelays.c example code. > > Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> > --- > Documentation/accounting/getdelays.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > Index: linux-2.6-ozl

Re: [patch 1/2] i386: use asm() like the other atomic operations already do.

2007-08-15 Thread Sebastian Siewior
* Andi Kleen | 2007-08-15 02:20:35 [+0200]: >> My config with march=pentium-m and gcc (GCC) 4.1.2 (Gentoo 4.1.2): >> textdata bss dec hex filename >> 3434150 249176 176128 3859454 3ae3fe atomic_normal/vmlinux >> 3435308 249176 176128 3860612 3ae884 atomic_inlineasm/vmlinux

Re: [RFC: 2.6 patch] allow disabling DNOTIFY without EMBEDDED

2007-08-15 Thread Stephen Rothwell
On Tue, 14 Aug 2007 23:27:12 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > This patch allows disabling DNOTIFY with CONFIG_EMBEDDED=n. > > I'm currently running a kernel with dnotify disabled and I haven't run > into any problem. Is there any popular application left that breaks > without dno

Re: [PATCH] libata: Correct IORDY handling

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Debugging a report of a problem with an ancient solid state disk showed up some problems in the IORDY handling 1. We check the wrong bit to see if the device has IORDY 2. Even then some ancient creaking piles of crap don't support SETXFER at all. I think this s

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-15 Thread Balbir Singh
Guillaume Chazarain wrote: > [Resent with different recipients as [EMAIL PROTECTED] bounced with > a User unknown] > > Hi, > > This patch adds all thread accounting stats for the global tgid stats. > As a shameless plug, this fixes iotop -P > (http://guichaz.free.fr/misc/iotop.py). > Since thi

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 14 2007 16:21, Jason Uhlenkott wrote: >On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: >> NULL is not 0 though. > >It is. Its representation isn't guaranteed to be all-bits-zero, C guarantees that. >but the constant value 0 when used in pointer context is always a >null p

[PATCH] RTC v3020 fixes

2007-08-15 Thread Mike Rapoport
Fix off-by-one in month calculations Add delay for bus accesses to satisfy Tw > 500ns Signed-off-by: Mike Rapoport <[EMAIL PROTECTED]> drivers/rtc/rtc-v3020.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-v3020.c b/drivers/rtc/rtc-v3020.c index

Re: do_coredump and O_NOFOLLOW

2007-08-15 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > I found that O_NOFOLLOW is used for opened core file in Linux 2.6.10. I think that is for security reasons, otherwise one has to (atomically) check who is the owner of the symlink and where it points to. If you dont have hostile users on your system you

Re: two questions about the boot_delay

2007-08-15 Thread Dave Young
>On 8/12/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Wed, 8 Aug 2007 07:39:33 + Dave Young wrote: > > > Hi, > > I have tried the "slow down printk" , and I have two questions. > > > > 1. why it depends the DEBUG_KERNEL? Sometimes we only need boot_delay > > to see the printk infomations.

Re: [2.6 patch] remove Documentation/networking/net-modules.txt

2007-08-15 Thread Geert Uytterhoeven
On Tue, 14 Aug 2007, Adrian Bunk wrote: > According to git, the only one who touched this file during the last > 5 years was me when removing drivers... > > modinfo offers less ancient information. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> For the m68k net drivers: Acked-by: Geert Uytt

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-gi

Re: do_coredump and O_NOFOLLOW

2007-08-15 Thread gshan
Bernd Eckenfels wrote: In article <[EMAIL PROTECTED]> you wrote: I found that O_NOFOLLOW is used for opened core file in Linux 2.6.10. I think that is for security reasons, otherwise one has to (atomically) check who is the owner of the symlink and where it points to. If you dont have

Re: [patch 4/4] libata: send event when AN received

2007-08-15 Thread Jeff Garzik
applied the attached slightly modified patch. main changes: * SCSI stuff has not been applied yet, so libata's notify is a no-op for now * fixed endian bug in SDB FIS handling diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 757369e..c41bd2c 100644 --- a/drivers/ata/ahci.c +++ b/dri

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry "media_change_notify", which will be 1 if it is supported, and 0 if not supported. Create a routine which allows scsi device

Re: [PATCH] Documentation: fix getdelays.c example -l option and segv

2007-08-15 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > Michael Neuling wrote: > > Fix a couple of minor issues with the getdelays.c example code. > > > > Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> > > --- > > Documentation/accounting/getdelays.c | 21 +++-- > > 1 file changed, 11

Re: [patch 1/4] Store interrupt value

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> applied, after adding "ahci: " prefix to subject lin

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-15 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R] it is UDMA6 (not UDMA5): * Fix the problem by adding missing struct ata_port_info to artop_init_one(). * Use the right naming (s/626/628/). * Bump driver version. Fixes IDE->lib

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-15 Thread Heiko Carstens
On Wed, Aug 15, 2007 at 02:49:03PM +0800, Herbert Xu wrote: > Chris Snook <[EMAIL PROTECTED]> wrote: > > > > Because atomic operations are generally used for synchronization, which > > requires > > volatile behavior. Most such codepaths currently use an inefficient > > barrier(). > > Some fo

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-15 Thread Alan Cox
On Wed, 15 Aug 2007 10:10:38 +0200 Stefan Richter <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > >> > Actually I think the entire thing is a > >> > bad idea but thats another matter. > > > Working off the git tree as it shows who actually is making > > changes/updating stuff recently and why whic

Re: [PATCH] [70/2many] MAINTAINERS - ARPD SUPPORT

2007-08-15 Thread Stefan Richter
Alan Cox wrote: >> > Actually I think the entire thing is a >> > bad idea but thats another matter. > Working off the git tree as it shows who actually is making > changes/updating stuff recently and why which is a major clue when > tracing bugs Adrian Bunk wrote in http://lkml.org/lkml/2007/6/30

Re: linux kernel 2.6.18-20 bug: rcu_read_unlock in __sock_create

2007-08-15 Thread Herbert Xu
oleg 123 <[EMAIL PROTECTED]> wrote: > > There is a bug in __sock_create() function (net/socket.c). > If an error occur in LSM hook security_socket_post_create, then unneeded > rcu_read_unlock() is made in __sock_create. Well spotted! Please cc [EMAIL PROTECTED] for networking issues. [NET]: Fix u

Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators

2007-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2007 at 07:53:01AM +0100, Al Viro wrote: > On Wed, Aug 15, 2007 at 02:37:41PM +0800, Fengguang Wu wrote: > > static void *ct_seq_next(struct seq_file *s, void *v, loff_t *pos) > > { > > loff_t *spos = (loff_t *) v; > > *pos = ++(*spos); > > return spos; > > }

Re: [patch 1/2] i386: use asm() like the other atomic operations already do.

2007-08-15 Thread Herbert Xu
Andi Kleen <[EMAIL PROTECTED]> wrote: >> My config with march=pentium-m and gcc (GCC) 4.1.2 (Gentoo 4.1.2): >> textdata bss dec hex filename >> 3434150 249176 176128 3859454 3ae3fe atomic_normal/vmlinux >> 3435308 249176 176128 3860612 3ae884 atomic_inlineasm/vmlinux > > Wh

Re: kfree(0) - ok?

2007-08-15 Thread Rene Herman
On 08/15/2007 09:28 AM, Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, C guarantees that. C guarantees what? If you'

Linux 2.4.35.1

2007-08-15 Thread Willy Tarreau
I've just released Linux 2.4.35.1. This version includes some minor build fixes for people using GCC 4.x. It now successfully builds with 4.2. Please also note the security update : CVE-2007-3848. Limited impact, but really depends on the setuid binaries provided by your distribution. The patch

Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

2007-08-15 Thread YAMAMOTO Takashi
> YAMAMOTO Takashi wrote: > >> + lock_meta_page(page); > >> + /* > >> + * Check if somebody else beat us to allocating the meta_page > >> + */ > >> + race_mp = page_get_meta_page(page); > >> + if (race_mp) { > >> + kfree(mp); > >> + mp = race_mp; > >> + atomic_inc

Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators

2007-08-15 Thread Fengguang Wu
Al Viro, Does this sounds like a good fix? === seq_file version fixes - f_version is 'unsigned long', it's pointless to do more than that. - m->version should not be reset when we are bumping up the buf size. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- fs/seq_file.c|1 -

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-15 Thread WU Fengguang
On Tue, Aug 14, 2007 at 10:10:58AM -0700, Andy Isaacson wrote: > On Sun, Aug 12, 2007 at 08:27:46PM +0800, WU Fengguang wrote: > > On Sun, Aug 12, 2007 at 05:27:52PM +0530, Balbir Singh wrote: > > > For some reason my mailer keeps removing you from the cc. > > > > Or maybe it's my SMTP server's pr

Re: [PATCH again] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Sonic Zhang
On 8/14/07, Alan Cox <[EMAIL PROTECTED]> wrote: > > +/** > > + * Register transfer timing table > > + */ > > Libata has a complete set of transfer mode tables and timing functions - > any reason for not using them ? > After a bit investigation, I find the timing paramters difined in struct ata_tim

[PATCH] seqfile: fix uninitialized memory allocation in mounts_open()

2007-08-15 Thread Fengguang Wu
proc_mounts.m.buf is not explicitly zeroed at allocation time, which may later confuse the seqfile code and triggle an kfree(m->buf). Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- --- linux.orig/fs/proc/base.c +++ linux/fs/proc/base.c @@ -380,7 +380,7 @@ static int mounts_open(struct inode

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 09:28:54 +0200, Jan Engelhardt wrote: > > On Aug 14 2007 16:21, Jason Uhlenkott wrote: > >On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: > >> NULL is not 0 though. > > > >It is. Its representation isn't guaranteed to be all-bits-zero, > > C guarantees tha

Re: [PATCH] seqfile: fix uninitialized memory allocation in mounts_open()

2007-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2007 at 04:56:37PM +0800, Fengguang Wu wrote: > proc_mounts.m.buf is not explicitly zeroed at allocation time, which > may later confuse the seqfile code and triggle an kfree(m->buf). It's weird it did not show up in real world. Could I be wrong? > --- linux.orig/fs/proc/base.c >

Re: [PATCH] seqfile: fix uninitialized memory allocation in mounts_open()

2007-08-15 Thread Alexey Dobriyan
On 8/15/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > proc_mounts.m.buf is not explicitly zeroed at allocation time, which > may later confuse the seqfile code and triggle an kfree(m->buf). It's cleared in seq_open(). > --- linux.orig/fs/proc/base.c > +++ linux/fs/proc/base.c > @@ -380,7 +380,7 @

[PATCH] seqfile: merge duplite code to seq_open_private()

2007-08-15 Thread Fengguang Wu
There are dozens of calls to seq_open() that need to set m->private. Introduce seq_open_private() to remove code duplications. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- Andrew: more conversions will be made if this patch is ok. fs/nfs/client.c | 24 ++--

Re: [PATCH] seqfile: fix uninitialized memory allocation in mounts_open()

2007-08-15 Thread Fengguang Wu
On Wed, Aug 15, 2007 at 01:04:05PM +0400, Alexey Dobriyan wrote: > On 8/15/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > proc_mounts.m.buf is not explicitly zeroed at allocation time, which > > may later confuse the seqfile code and triggle an kfree(m->buf). > > It's cleared in seq_open(). So i

[PATCH] sched: Reduce overhead in balance_tasks()

2007-08-15 Thread Peter Williams
At the moment, balance_tasks() provides low level functionality for both move_tasks() and move_one_task() (indirectly) via the load_balance() function (in the sched_class interface) which also provides dual functionality. This dual functionality complicates the interfaces and internal mechani

Re: Thinking outside the box on file systems

2007-08-15 Thread Tim Tassonis
The ACLs that were added to Linux were a step in the right direction but very incomplete. What should be is a complex permission system that would allow fine grained permissions and inherentance masks to control what permission are granted when someone moves new files into a directory. Instead of

[1/1] w1: fix w1_remove_master_device() searching.

2007-08-15 Thread Evgeniy Polyakov
In case bus master driver provided bogus value as its private data, search can be incorrect. Problem found by Adrian Bunk. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c index 2fbd8dd..6840dfe 100644 --- a/drivers/w1/w1_int.c +++ b/drive

Re: kfree(0) - ok?

2007-08-15 Thread Andreas Schwab
Jan Engelhardt <[EMAIL PROTECTED]> writes: > On Aug 14 2007 16:21, Jason Uhlenkott wrote: >>On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: >>> NULL is not 0 though. >> >>It is. Its representation isn't guaranteed to be all-bits-zero, > > C guarantees that. Linux C does it. But

[PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Sonic Zhang
Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1581

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 15 2007 10:37, Rene Herman wrote: > On 08/15/2007 09:28 AM, Jan Engelhardt wrote: >> On Aug 14 2007 16:21, Jason Uhlenkott wrote: > >> > On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: >> > > NULL is not 0 though. >> > It is. Its representation isn't guaranteed to be all-bi

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

2007-08-15 Thread Stefan Richter
Linus Torvalds wrote: > #!/bin/sh > git log --since=6.months.ago -- "$@" | > grep -i '^[-a-z]*by:.*@' | > sort | uniq -c | > sort -r -n | head > > and it gives you a rather good picture of who is involved with a > particular subdirectory o

Re: kfree(0) - ok?

2007-08-15 Thread Giacomo A. Catenazzi
Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, C guarantees that. Hmm. It depends on your interpretation of "representa

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

2007-08-15 Thread Stefan Richter
Joe Perches wrote: > On Tue, 2007-08-14 at 18:31 -0700, Junio C Hamano wrote: >>On the other hand, git-send-email _is_ all about sending it >>out, and it needs to know who your patch should reach. I >>think it makes sense to have one script that, [...] > Yes please. > > The LK MAINTA

Re: kfree(0) - ok?

2007-08-15 Thread Jason Uhlenkott
On Wed, Aug 15, 2007 at 11:20:33 +0200, Jan Engelhardt wrote: > > On Aug 15 2007 10:37, Rene Herman wrote: > > On 08/15/2007 09:28 AM, Jan Engelhardt wrote: > >> On Aug 14 2007 16:21, Jason Uhlenkott wrote: > > > >> > On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: > >> > > NULL is

[git patches] libata fixes

2007-08-15 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |9 - drivers/ata/libata-core.c |2 +- drivers/ata/pata_artop.c | 19 ++---

[patch 01/10] m68k: needs

2007-08-15 Thread Geert Uytterhoeven
m68k: needs because of __attribute_const__ Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- include/asm-m68k/page.h |2 ++ 1 file changed, 2 insertions(+) --- a/include/asm-m68k/page.h +++ b/include/asm-m68k/page.h @@ -27,6 +27,8 @@ #ifndef __ASSEMBLY__ +#include + #include

[patch 00/10] m68k patches for 2.6.23-rc3

2007-08-15 Thread Geert Uytterhoeven
Hi Linus, Andrew, Here are a few m68k-specific patches for 2.6.23-rc3: [1] m68k: needs [2] m68k: Don't include RODATA into text segment [3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible [4] m68k: Kill superfluous extern [5] m68k: Remove unnecessary m68

[patch 02/10] m68k: Dont include RODATA into text segment

2007-08-15 Thread Geert Uytterhoeven
From: Roman Zippel <[EMAIL PROTECTED]> Don't include RODATA into text segment as it includes the kallsyms data and can cause spurious link failures (layout differences can change the number of symbols in kallsyms, i.e. when a symbol is equal to _etext it's not included). Signed-off-by: Roman Zipp

[patch 04/10] m68k: Kill superfluous extern

2007-08-15 Thread Geert Uytterhoeven
Kill a superfluous extern declaration Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/m68k/mm/motorola.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) --- a/arch/m68k/mm/motorola.c +++ b/arch/m68k/mm/motorola.c @@ -210,11 +210,7 @@ void __init paging_init(void)

[patch 05/10] m68k: Remove unnecessary m68k_memoffset export and init

2007-08-15 Thread Geert Uytterhoeven
From: Roman Zippel <[EMAIL PROTECTED]> Remove an unnecessary m68k_memoffset export and initialization Signed-off-by: Roman Zippel <[EMAIL PROTECTED]> Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- arch/m68k/kernel/setup.c |2 -- 1 file changed, 2 deletions(-) --- a/arch/m68k/kern

[patch 07/10] m68k: Use _AC() instead of #ifdef __ASSEMBLY__

2007-08-15 Thread Geert Uytterhoeven
m68k: Use _AC() instead of #ifdef __ASSEMBLY__ hackery when needed, remove hackery when unused. Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- include/asm-m68k/page.h |8 +++- include/asm-m68k/processor.h |4 2 files changed, 3 insertions(+), 9 deletions(-) --- a

[patch 03/10] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-08-15 Thread Geert Uytterhoeven
From: Geert Uytterhoeven <[EMAIL PROTECTED]> m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible drivers/char/keyboard.c: In function 'kbd_keycode': drivers/char/keyboard.c:1142: error: implicit declaration of function 'mac_hid_mouse_emulate_buttons' The forward declaration of ma

[patch 10/10] zorro: Make sysfs `config attribute read-only

2007-08-15 Thread Geert Uytterhoeven
zorro: Make the sysfs `config' attribute read-only, as you cannot write to it (there's no .write function neither). Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- drivers/zorro/zorro-sysfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/zorro/zorro-sysfs.c +++

[patch 08/10] m68k: Enable arbitary speed tty support

2007-08-15 Thread Geert Uytterhoeven
From: Alan Cox <[EMAIL PROTECTED]> Add the needed constants and defines to activate the existing code. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- include/asm-m68k/ioctls.h |8 ++-- include/asm-m68k/termbits.h |5 - inc

[patch 09/10] m68k: Fix a few hickups in drivers/scsi/Kconfig

2007-08-15 Thread Geert Uytterhoeven
m68k: Fix a few hickups in drivers/scsi/Kconfig Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> --- drivers/scsi/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -1561,7 +1561,7 @@ config A3000_SCSI buil

[patch 06/10] remove dead code in via-pmu68k

2007-08-15 Thread Geert Uytterhoeven
From: Johannes Berg <[EMAIL PROTECTED]> When suspend is ever implemented for pmu68k it really should follow the generic pm_ops concept and not mirror the platform-specific /dev/pmu device with ioctls on it. Hence, this patch removes the unused code there; should the implementers need it they can l

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Alan Cox
On Wed, 15 Aug 2007 17:14:15 +0800 Sonic Zhang <[EMAIL PROTECTED]> wrote: > Update: > 1. Condition branch code instead of while loop from Alan Cox. > 2. Condtinue in PIO mode after failing to request DMA. > > Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]>

Re: kfree(0) - ok?

2007-08-15 Thread Rene Herman
On 08/15/2007 11:20 AM, Jan Engelhardt wrote: On Aug 15 2007 10:37, Rene Herman wrote: On 08/15/2007 09:28 AM, Jan Engelhardt wrote: On Aug 14 2007 16:21, Jason Uhlenkott wrote: On Tue, Aug 14, 2007 at 15:55:48 -0700, Arjan van de Ven wrote: NULL is not 0 though. It is. Its representati

Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

2007-08-15 Thread Balbir Singh
YAMAMOTO Takashi wrote: >> YAMAMOTO Takashi wrote: + lock_meta_page(page); + /* + * Check if somebody else beat us to allocating the meta_page + */ + race_mp = page_get_meta_page(page); + if (race_mp) { + kfree(mp); + mp = race_mp; >

Re: kfree(0) - ok?

2007-08-15 Thread Jan Engelhardt
On Aug 15 2007 11:58, Rene Herman wrote: >> > > > > NULL is not 0 though. >> > > > It is. Its representation isn't guaranteed to be all-bits-zero, >> > > > > He said the null _pointer_ isn't guaranteed to be all-bits zero. And it > isn't. Read the standard or the faq. 0 is all-bits-zero. NULL i

Re: kfree(0) - ok?

2007-08-15 Thread Rene Herman
On 08/15/2007 12:20 PM, Jan Engelhardt wrote: On Aug 15 2007 11:58, Rene Herman wrote: NULL is not 0 though. It is. Its representation isn't guaranteed to be all-bits-zero, He said the null _pointer_ isn't guaranteed to be all-bits zero. And it isn't. Read the standard or the faq. 0 is a

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-15 Thread Stefan Richter
Satyam Sharma wrote: > [ BTW, why do we want the compiler to not optimize atomic_read()'s in > the first place? Atomic ops guarantee atomicity, which has nothing > to do with "volatility" -- users that expect "volatility" from > atomic ops are the ones who must be fixed instead, IMHO. ] LDD3

[PATCH 2.6.22] [0/5] x86 updates for 2.6.22-stable

2007-08-15 Thread Andi Kleen
Should all go into the next stable release. Two of the patches (cfi probe and rept fix) are only pending for mainline (I hope Linus applies them today). They should not go in before hitting mainline. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH 2.6.22] [1/5] i386: allow debuggers to access the vsyscall page with compat vDSO

2007-08-15 Thread Andi Kleen
From: "Jan Beulich" <[EMAIL PROTECTED]> Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> arch/i386/kernel/sysenter.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6.22-stable/arch/i386/kernel/sysenter.c ===

[PATCH 2.6.22] [2/5] x86_64: Check for .cfi_rel_offset in CFI probe

2007-08-15 Thread Andi Kleen
Very old binutils have .cfi_startproc/endproc, but no .cfi_rel_offset. Check for .cfi_rel_offset too. Cc: [EMAIL PROTECTED] --- arch/i386/Makefile |4 ++-- arch/x86_64/Makefile |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.22-stable/arch/x86_64/Makefile =

[PATCH 2.6.22] [3/5] x86_64: Change PMDS invocation to single macro

2007-08-15 Thread Andi Kleen
Very old binutils (2.12.90...) seem to have trouble with newlines in assembler macro invocation. They put them into the resulting argument expansion. In this case this lead to a parse error because a .rept expression ended up spread over multiple lines. Change the PMDS() invocation to a single li

[PATCH 2.6.22] [4/5] i386: Fix double fault handler

2007-08-15 Thread Andi Kleen
From: Chuck Ebbert <[EMAIL PROTECTED]> The new percpu code has apparently broken the doublefault handler when CONFIG_DEBUG_SPINLOCK is set. Doublefault is handled by a hardware task, making the check SPIN_BUG_ON(lock->owner == current, lock, "recursion"); fault because it uses the FS re

[PATCH 2.6.22] [5/5] i386: Handle P6s without performance counters in nmi watchdog

2007-08-15 Thread Andi Kleen
I got an oops while booting a 32bit kernel on KVM because it doesn't implement performance counters used by the NMI watchdog. Handle this case. Cc: [EMAIL PROTECTED] Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/perfctr-watchdog.c |4 +++- 1 file changed, 3 insert

Re: ignoring unimplemented functions that are old and crusty on shiny new ports

2007-08-15 Thread Robin Getz
On Mon 13 Aug 2007 22:05, Mike Frysinger pondered: > would it be possible to get the class of "old and crusty" functions > permanently ignored ? i'm thinking of course of "uselib" and "sysfs" > ... > Blackfin does not implement either of these and i think that's a good > thing > > Signed-off-by:

Testing the Current Upstream Kernel

2007-08-15 Thread Jan Blunck
Andrew Morton has spoken at different occasions about testing of the Linux kernel and asked users to test the current development version and report their findings. For our openSUSE releases we have in general a frozen version and add only fixes for bugs that are encountered during testing - but s

Re: [PATCH] [443/2many] MAINTAINERS - HIBERNATION (aka Software Suspend, aka swsusp):

2007-08-15 Thread Rafael J. Wysocki
On Wednesday, 15 August 2007 04:51, Kyle Moffett wrote: > On Aug 14, 2007, at 19:24:30, Dave Jones wrote: > > On Tue, Aug 14, 2007 at 11:22:37AM -0700, Andrew Morton wrote: > >> On Tue, 14 Aug 2007 11:15:41 -0700 (PDT) Linus Torvalds > >> <[EMAIL PROTECTED]> wrote: > >>> In other words, it would

Re: Testing the Current Upstream Kernel

2007-08-15 Thread Sam Ravnborg
On Wed, Aug 15, 2007 at 01:08:51PM +0200, Jan Blunck wrote: > (besides those we need for building a RPM). Are these openSUSE specific or something we ought to apply to mainline? If I sometimes are a bit reluctant aplying rpm specific patches it is simply because I do not use the functionality mys

Re: [2.6 patch] make kernel/power/main.c:suspend_enter() static

2007-08-15 Thread Rafael J. Wysocki
On Tuesday, 14 August 2007 23:26, Adrian Bunk wrote: > suspend_enter() can now become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]> > --- > > This patch has been sent on: > - 29 Jul 2007 > > --- linux-2.6.23-rc1-mm1/kernel/power/main

Re: [PATCH] Documentation: fix getdelays.c example -l option and segv

2007-08-15 Thread Balbir Singh
>> Is this really required? a sleep() in the code. Why do we do multiple >> send_cmd()'s in the do loop? I'll test and get back. > > I needed to send another command to receive more data. Without the per > loop send_cmd, I never got any more stats. > > Should we receive more data without the

Re: Testing the Current Upstream Kernel

2007-08-15 Thread Jan Blunck
On Wed, 15 Aug 2007 13:14:04 +0200, Sam Ravnborg wrote: > On Wed, Aug 15, 2007 at 01:08:51PM +0200, Jan Blunck wrote: >> (besides those we need for building a RPM). > > Are these openSUSE specific or something we ought to apply to mainline? > If there are patches (at the moment there are none)

Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer

2007-08-15 Thread Ralf Baechle
On Tue, Aug 14, 2007 at 02:14:41AM +0200, Andi Kleen wrote: > meth is only used on SGI O2s which are not that slow and unlikely > to work in tree anyways. O2 doesn't enable CONFIG_ZONE_DMA so there is no point in using GFP_DMA in an O2-specific device driver. Will send out patch in separate mail

Adding a security parameter to VFS functions

2007-08-15 Thread David Howells
Hi Linus, Al, Would you object greatly to functions like vfs_mkdir() gaining a security parameter? What I'm thinking of is this: int vfs_mkdir(struct inode *dir, struct dentry *dentry, int mode, struct security *security) Where the security context is the state of

Re: [PATCH] [1/2many] - FInd the maintainer(s) for a patch - scripts/get_maintainer.pl

2007-08-15 Thread Rene Herman
On 08/15/2007 11:39 AM, Stefan Richter wrote: Note, maintainer contacts - should be available to patch submitters and - must be available to *problem reporters* without having to have git and a .git repo. That "must" seems rather strong. But those few non-developer users that could care a

Re: [PATCH V3] limit minixfs printks on corrupted dir i_size, CVE-2006-6058

2007-08-15 Thread Bodo Eggert
On Mon, 13 Aug 2007, Eric Sandeen wrote: > Bodo Eggert wrote: > > Warning: I'm only looking at the patch. > > > > You are supposed to print an error message for a user, not to write in a > > chat window to a 1337 script kiddie. OK, you just matched the current style, > > and your patch is IMHO OK

Re: [PATCH] Documentation: fix getdelays.c example -l option and segv

2007-08-15 Thread Michael Neuling
> Interesting, we never used -l that way. We used -l to get data for all > exiting tasks > > ./getdelays -d -l > > For the usage you've mentioned, I'd use > > while : > do > sleep 2 > ./getdelays -p 1 -d > done > > I guess your changes change getdelays and since there are other ways

Re: [PATCH] fix panic in jbd by adding locks

2007-08-15 Thread Jan Kara
Hello, > It is possible to panic the box by a race condition that exists in the > journalling code where we do not take the j_revoke_lock when traversing the > journal's revoked record list. This patch has been tested and we haven't seen > the issue yet, its a rather straightforward and correct

Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer

2007-08-15 Thread Andi Kleen
On Wed, Aug 15, 2007 at 12:37:49PM +0100, Ralf Baechle wrote: > On Tue, Aug 14, 2007 at 02:14:41AM +0200, Andi Kleen wrote: > > > meth is only used on SGI O2s which are not that slow and unlikely > > to work in tree anyways. > > O2 doesn't enable CONFIG_ZONE_DMA so there is no point in using GFP_

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-15 Thread Herbert Xu
On Wed, Aug 15, 2007 at 12:35:31PM +0200, Stefan Richter wrote: > > LDD3 says on page 125: "The following operations are defined for the > type [atomic_t] and are guaranteed to be atomic with respect to all > processors of an SMP computer." > > Doesn't "atomic WRT all processors" require volatil

[PATCH] Documentation: fix getdelays.c printf bug

2007-08-15 Thread Michael Neuling
b663a79c191508f27cd885224b592a878c0ba0f6 incorrectly removed a comma from a printf statement. This causes corruption in the output printing or a seg fault. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> --- Documentation/accounting/getdelays.c |2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH] fix panic in jbd by adding locks

2007-08-15 Thread Josef Bacik
On Wed, Aug 15, 2007 at 01:37:37PM +0200, Jan Kara wrote: > Hello, > > > It is possible to panic the box by a race condition that exists in the > > journalling code where we do not take the j_revoke_lock when traversing the > > journal's revoked record list. This patch has been tested and we ha

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-15 Thread Satyam Sharma
On Wed, 15 Aug 2007, Stefan Richter wrote: > Satyam Sharma wrote: > > [ BTW, why do we want the compiler to not optimize atomic_read()'s in > > the first place? Atomic ops guarantee atomicity, which has nothing > > to do with "volatility" -- users that expect "volatility" from > > atomic o

Re: [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC)

2007-08-15 Thread Nick Piggin
On Tue, Aug 14, 2007 at 07:21:03AM -0700, Christoph Lameter wrote: > The following patchset implements recursive reclaim. Recursive reclaim > is necessary if we run out of memory in the writeout patch from reclaim. > > This is f.e. important for stacked filesystems or anything that does > complica

Re: [PATCH] [3/4] x86_64: Change PMDS invocation to single macro

2007-08-15 Thread Clemens Koller
Andi Kleen schrieb: Very old binutils (2.12.90...) seem to have trouble with newlines in assembler macro invocation. They put them into the resulting argument expansion. In this case this lead to a parse error because a .rept expression ended up spread over multiple lines. Change the PMDS() invo

Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer

2007-08-15 Thread Ralf Baechle
On Wed, Aug 15, 2007 at 02:59:20PM +0200, Andi Kleen wrote: > On Wed, Aug 15, 2007 at 12:37:49PM +0100, Ralf Baechle wrote: > > On Tue, Aug 14, 2007 at 02:14:41AM +0200, Andi Kleen wrote: > > > > > meth is only used on SGI O2s which are not that slow and unlikely > > > to work in tree anyways. >

Bad CD disk disables IDE DMA

2007-08-15 Thread Zoltan Boszormenyi
Hi, I noticed that a bad CD of mine makes DMA disabled: hda: selected mode 0x44 hda: cdrom_decode_status: status=0x51 { DriveReady SeekComplete Error } hda: cdrom_decode_status: error=0x40 { LastFailedSense=0x04 } ide: failed opcode was: unknown hda: cdrom_decode_status: status=0x51 { DriveReady

Re: [patch 1/2] i386: use asm() like the other atomic operations already do.

2007-08-15 Thread Satyam Sharma
On Wed, 15 Aug 2007, Herbert Xu wrote: > Andi Kleen <[EMAIL PROTECTED]> wrote: > >> My config with march=pentium-m and gcc (GCC) 4.1.2 (Gentoo 4.1.2): > >> textdata bss dec hex filename > >> 3434150 249176 176128 3859454 3ae3fe atomic_normal/vmlinux > >> 3435308 249176 176

[PATCH 1/25][V3] header file move

2007-08-15 Thread Glauber de Oliveira Costa
Later on, the paravirt_ops patch will deference the vm_area_struct in asm/pgtable.h. It means this define must be after the struct definition Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- include/linux/mm.h | 14 +-

[PATCH 2/25][V3] tlb flushing routines

2007-08-15 Thread Glauber de Oliveira Costa
This patch turns the flush_tlb routines into native versions. In case paravirt is not defined, the natives are defined into the actually used ones. flush_tlb_others() goes in smp.c, unless smp is not in the game Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Ros

[PATCH 4/25][V3] Add debugreg/load_rsp native hooks

2007-08-15 Thread Glauber de Oliveira Costa
This patch adds native hooks for debugreg handling functions, and for the native load_rsp0 function. The later also have its call sites patched. [ updates from v2 * there were still a raw reference to cr4 missing ] Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: St

[PATCH 5/25][V3] native versions for system.h functions

2007-08-15 Thread Glauber de Oliveira Costa
This patch adds the native hook for the functions in system.h They are the read/write_crX, clts and wbinvd. The later, also gets its call sites patched. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86_64/kernel/tce.c|

[PATCH 6/25][V3] add native_apic read and write functions, as well as boot clocks ones

2007-08-15 Thread Glauber de Oliveira Costa
Time for the apic handling functions to get their native counterparts. Also, put the native hook for the boot clocks functions in the apic.h header Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86_64/kernel/apic.c|

[PATCH 7/25][V3] interrupt related native paravirt functions.

2007-08-15 Thread Glauber de Oliveira Costa
The interrupt initialization routine becomes native_init_IRQ and will be overriden later in case paravirt is on. [ updates from v1 * After a talk with Jeremy Fitzhardinge, it turned out that making the interrupt vector global was not a good idea. So it is removed in this patch ] Signed-o

[PATCH 8/25][V3] use macro for sti/cli in spinlock definitions

2007-08-15 Thread Glauber de Oliveira Costa
This patch switches the cli and sti instructions into macros. In this header, they're just defined to the instructions they refer to. Later on, when paravirt is defined, they will be defined to something with paravirt abilities. Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-o

[PATCH 9/25][V3] report ring kernel is running without paravirt

2007-08-15 Thread Glauber de Oliveira Costa
When paravirtualization is disabled, the kernel is always running at ring 0. So report it in the appropriate macro Signed-off-by: Glauber de Oliveira Costa <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- include/asm-x86_64/segment.h |4 1 files changed, 4 insert

  1   2   3   4   5   6   >