[RFC 6/8]KVM: introduce kvm_mmu_zap_pagetbl

2007-07-23 Thread Shaohua Li
add a routine to zap all shadow pgtble for a gfn. If kvm supports SMP, the API should zap pgtble for all vcpus, but kvm shadow page table really should be per-vm, instead of per-vcpu. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/mmu.c | 28 ++

[RFC 7/8]KVM: swap out guest pages

2007-07-23 Thread Shaohua Li
Make KVM guest pages be allocated dynamically and able to be swaped out. One issue: all inodes returned from anon_inode_getfd are shared, if one module changes field of the inode, other moduels might break. Should we introduce a new API to not share inode? Signed-off-by: Shaohua Li <[EMAIL PROTEC

[RFC 8/8]KVM: cache pages

2007-07-23 Thread Shaohua Li
KVM use gfn_to_page very frequestly, which makes find_get_page a bottleneck, so cache pages found to speed up. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |1 + drivers/kvm/kvm_main.c |9 + 2 files changed, 10 insertions(+) Index: linux/drivers/kvm/kv

Re: [PATCH] AFS: Fix file locking

2007-07-23 Thread Nick Piggin
Linus Torvalds wrote: On Fri, 20 Jul 2007, Nick Piggin wrote: So you did. Then to answer that, yes it could be faster because there are stupid volatiles sprinkled all over the bitops code so you could easily end up having to do more loads. Does it make a real difference? Unlikely, but David lo

Re: [GIT PATCH 0/2] stripe-queue for 2.6.23 consideration

2007-07-23 Thread Neil Brown
On Sunday July 22, [EMAIL PROTECTED] wrote: > Andrew, Neil, > > The stripe-queue patches are showing solid performance improvement. > > git://lost.foo-projects.org/~dwillia2/git/iop md-for-linus > > drivers/md/raid5.c | 1484 > > inclu

alpha, i386,mips,powerpc,ppc,xtensa compile brakage (was Re: Linus 2.6.23-rc1)

2007-07-23 Thread Jan Dittmer
Linus Torvalds wrote: Ok, right on time, two weeks afetr 2.6.22, there's a 2.6.23-rc1 out there. Compared to 2.6.22> # alpha/defconfig: broke LD .tmp_vmlinux1 arch/alpha/kernel/built-in.o(.text+0xcdf8): In function `module_frob_arch_sections': include/linux/slub_def.h:154: undefined r

Re: "build-id" changes break sparc64

2007-07-23 Thread Roland McGrath
> Should be doable without to much pain. > Alan can you please share with us exactly why this is better and what we may > run into of problems doing so. > A sample script would be nice too This about does it. Polish left as an exercise to the reader. ld does "interesting" things if the linker

Re: [bug] pcwd_init_module(): WARNING: at lib/kref.c:33 kref_get()

2007-07-23 Thread Cornelia Huck
On Sun, 22 Jul 2007 20:23:20 +0530, "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > On 7/22/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > enabling CONFIG_PCWATCHDOG=y crashes bzImage bootup, see below. Tested > > on latest -git. > > > > Ingo > > > > ---> > > Calling initc

Re: drivers/hwmon/lm93.c: array overruns

2007-07-23 Thread Hans-Jürgen Koch
Am Montag 23 Juli 2007 02:54 schrieb Adrian Bunk: > The Coverity checker spotted the following array overruns > in drivers/hwmon/lm93.c: > > <-- snip --> > > ... > struct lm93_data { > ... > struct { > u8 min; > u8 max; > } temp_lim[3]; > ... > };

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Stefan Richter
Manuel Lauss wrote: > I too experience these bugs with the new fw stack; this time with a TI > OHCI-1394a combo chip in 2 different laptops and a Via 1394 pci addon card. > The target is a an external hd enclosure with an Oxford Semi chip. Thanks for the info. Then there is definitely a driver pr

Re: Fix compiling UML

2007-07-23 Thread Al Viro
On Sun, Jul 22, 2007 at 10:52:13PM -0700, Ulrich Drepper wrote: > .aio_buf= (unsigned long) buf, > .aio_nbytes = len, > .aio_offset = offset, > + .aio_flags = 0

Re: net/bluetooth/rfcomm/tty.c: use-after-free

2007-07-23 Thread Marcel Holtmann
Hi Adrian, > Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following > use-after-free in net/bluetooth/rfcomm/tty.c: > > <-- snip --> > > ... > static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc) > { > ... > if (IS_ERR(dev->tty_dev)) { >

Re: alpha, i386,mips,powerpc,ppc,xtensa compile brakage (was Re: Linus 2.6.23-rc1)

2007-07-23 Thread Stephen Rothwell
On Mon, 23 Jul 2007 09:14:12 +0200 Jan Dittmer <[EMAIL PROTECTED]> wrote: > > # powerpc/iseries_defconfig: broke > >CC [M] drivers/scsi/scsi_transport_sas.o >CC [M] drivers/scsi/scsi_wait_scan.o >LD drivers/scsi/ibmvscsi/built-in.o >CC [M] drivers/scsi/ibmvscsi/ibmvscsi.o >

Re: Problems with timerfd()

2007-07-23 Thread Michael Kerrisk
Andrew Morton wrote: > On Sun, 22 Jul 2007 23:38:26 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > >>> Davide has already submitted a patch to you to make read() from a timerfd >>> file descriptor return an 8 byte integer, and I understand it to have been >>> accepted into -mm. >> argh. Nobod

Re: crash with 2.6.22.1 crash:ll_rw_blk.c blk_remove_plug()

2007-07-23 Thread walter harms
Satyam Sharma wrote: > Hi Walter, > > Thanks for reporting this. > > On 7/22/07, walter harms <[EMAIL PROTECTED]> wrote: >> hello all, >> on my asus notebook tm620 there is a crash with 2.6.22 and 2.6.21 > > Did this happen when you were resuming from a suspend-to-ram/disk? > [ I ask because I

Re: [PATCH 6/7] radixtree: introduce radix_tree_scan_hole()

2007-07-23 Thread Nick Piggin
Fengguang Wu wrote: Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree for the first hole. It will be used in interleaved readahead. The implementation is dumb and obviously correct. It can help debug(and document) the possible smart one in future. Reasonable function to

[PATCH] [2.6.22] Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c

2007-07-23 Thread Micah Gruber
This patch fixes a potential null dereference bug where we dereference pegasus before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> --- --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -768,11 +7

Linux 2.6.16.53-rc1

2007-07-23 Thread Adrian Bunk
Security fixes since 2.6.16.52: - CVE-2007-2876: {ip,nf}_conntrack_sctp: fix remotely triggerable NULL dereference Location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of t

[2.6 patch] drm_rmmap_ioctl(): remove dead code

2007-07-23 Thread Adrian Bunk
This patch removes some obviously dead code spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc6-mm1/drivers/char/drm/drm_bufs.c.old2007-07-23 01:09:04.0 +0200 +++ linux-2.6.22-rc6-mm1/drivers/char/drm/drm_bufs.c2007-07-23

[2.6 patch] dvb-usb/af9005-fe.c: error check fixes

2007-07-23 Thread Adrian Bunk
This patch: - adds a missing error check and - removes an error check that could never be true Both spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/media/dvb/dvb-usb/af9005-fe.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) ---

[2.6 patch] ocfs2_insert_extent(): remove dead code

2007-07-23 Thread Adrian Bunk
This patch removes some now dead code. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fs/ocfs2/alloc.c |4 1 file changed, 4 deletions(-) --- linux-2.6.22-rc6-mm1/fs/ocfs2/alloc.c.old 2007-07-23 01:29:25.0 +0200 +++ linux-2.6.22-rc6-mm1

[2.6 patch] kernel/auditsc.c: fix an off-by-one

2007-07-23 Thread Adrian Bunk
This patch fixes an off-by-one in a BUG_ON() spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc6-mm1/kernel/auditsc.c.old 2007-07-23 02:08:09.0 +0200 +++ linux-2.6.22-rc6-mm1/kernel/auditsc.c 2007-07-23 02:08:32.0 +02

[2.6 patch] drivers/net/acenic.c: fix check-after-use

2007-07-23 Thread Adrian Bunk
The Coverity checker noted that we've already dereferenced "dev" when we check whether it's NULL. Since it's impossible that "dev" is NULL at this place this patch removes the NULL check. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc6-mm1/drivers/net/acenic.c.old

Re: vdso.so mislinked by buggy linker was Re: Linus 2.6.23-rc1

2007-07-23 Thread Andi Kleen
> These options are fairly new, before they were ignored (like all unknown > -z options). They were added 2006-05-30 to CVS binutils. > > I guess the problem is caused by the gap being too big and old binutils. Can you think of a workaround Jakub? -Andi - To unsubscribe from this list: send th

[2.6.23 regression fix] usbvision: don't return an uninitialized value

2007-07-23 Thread Adrian Bunk
Commit c5f48367fe54c46805774eeea8e828de54a5ad7b introduced this return of an uninitialized variable. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/media/video/usbvision/usbvision-video.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Andreas Messer
On Monday, 23. Juli 2007 01:34 Stefan Richter wrote: > (quoting in full for linux1394-devel, Cc added) > > Andreas Messer wrote at LKML: > > Hello, > > > > I tried the new firewire stack with a external harddisc and a external > > dvd writer and get massive i/o problems. Here is the kernel output f

Re: [PATCH] Move --build-id option

2007-07-23 Thread Roland McGrath
> > -LDFLAGS_vmlinux += $(LDFLAGS_BUILD_ID) > This needed to go otherwise you had to rely on all arch makefiles > used += for LDFLAGS_vmlinux assignments. This line appears well after include $(srctree)/arch/$(ARCH)/Makefile. > This will not work as LDFLAGS_BUILD_ID is not exported. Oops! I wa

[PATCH] Use LDFLAGS_MODULE only for .ko links

2007-07-23 Thread Roland McGrath
This replaces the "Move --build-id option" patch. Thanks, Roland --- Sam Ravnborg pointed out that Documentation/kbuild/makefiles.txt already says this is what it's for. This patch makes the reality live up to the documentation. This fixes the problem of LDFLAGS_BUILD_ID getting into too many

Re: "build-id" changes break sparc64

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 12:26:13AM -0700, Roland McGrath wrote: > > Should be doable without to much pain. > > Alan can you please share with us exactly why this is better and what we may > > run into of problems doing so. > > A sample script would be nice too > > This about does it. Polish l

Re: [PATCH] Use LDFLAGS_MODULE only for .ko links

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 01:12:08AM -0700, Roland McGrath wrote: > This replaces the "Move --build-id option" patch. > > Thanks, > Roland > > --- > > Sam Ravnborg pointed out that Documentation/kbuild/makefiles.txt already > says this is what it's for. This patch makes the reality live up to the

Re: [PATCH 6/7] radixtree: introduce radix_tree_scan_hole()

2007-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2007 at 05:58:02PM +1000, Nick Piggin wrote: > Fengguang Wu wrote: > >Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree > >for the first hole. It will be used in interleaved readahead. > > > >The implementation is dumb and obviously correct. > >It can help deb

Re: [RFH] Partition table recovery

2007-07-23 Thread Rene Herman
On 07/22/2007 06:28 PM, Theodore Tso wrote: [ Al -- don't drop CCs please ] Well, let's think about this a bit. What are the requirements? 1) The partition manager should be able explicitly request that a new backup of the partition tables be stashed in each filesystem that has room for such

Re: "build-id" changes break sparc64

2007-07-23 Thread Roland McGrath
> > -cmd_link_multi-m = $(LD) $(ld_flags) $(LDFLAGS_MODULE) -o $@ > > $(link_multi_deps) > > +cmd_link_multi-m = $(cmd_link_multi-y) > This signel change looks wrong. We do not want to generate a linker > script for modules. multi-m has nothing to do with modules, really. It's just for another "

[PATCH] spinlock in function hugetlb_fault could be deleted

2007-07-23 Thread Zhang, Yanmin
Function hugetlb_fault needn't hold spinlock mm->page_table_lock, because when hugetlb_fault is called: 1) mm->mmap_sem is held already; 2) hugetlb_instantiation_mutex is held by hugetlb_fault, which prevents other threads/processes from entering this critical area. It's impossible for other thread

[PATCH 1/1] fs: remove the unused mempages parameter

2007-07-23 Thread Denis Cheng
Since the mempages parameter is actually not used, they should be removed. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- If applied, now there is only files_init use the mempages parameter, files_init(mempages); but i don't think the adaptation to mempages in files_init is really usef

Re: "build-id" changes break sparc64

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 01:18:14AM -0700, Roland McGrath wrote: > > > -cmd_link_multi-m = $(LD) $(ld_flags) $(LDFLAGS_MODULE) -o $@ > > > $(link_multi_deps) > > > +cmd_link_multi-m = $(cmd_link_multi-y) > > This signel change looks wrong. We do not want to generate a linker > > script for modules.

Re: [PATCH 6/7] radixtree: introduce radix_tree_scan_hole()

2007-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2007 at 04:04:05PM +0800, Fengguang Wu wrote: > On Mon, Jul 23, 2007 at 05:58:02PM +1000, Nick Piggin wrote: > > Fengguang Wu wrote: > > >Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree > > >for the first hole. It will be used in interleaved readahead. > > >

Re: 2.6.22-git17 boot failure

2007-07-23 Thread Andi Kleen
Tilman Schmidt <[EMAIL PROTECTED]> writes: > on Mon, 23 Jul 2007 01:47:30 +0200, /me wrote: > > On my test machine with a Pentium D 940 processor, Intel DQ965GF > > mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails > > to come up because it cannot find the disk drives. Same issue

Re: [RFH] Partition table recovery

2007-07-23 Thread Jan-Benedict Glaw
On Mon, 2007-07-23 10:15:21 +0200, Rene Herman <[EMAIL PROTECTED]> wrote: > /* > * Public Domain 2007, Rene Herman > */ > > #define _LARGEFILE64_SOURCE > > #include > #include > #include > #include > > #include > #include > #include > #include > #include > > enum { > DOS_EXTEND

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-23 Thread Jarek Poplawski
On Mon, Jul 23, 2007 at 07:44:58AM +0200, Marcin Ślusarz wrote: > Ok, I've bisected this problem and found that this patch broke my NIC: Congratulations! > > 76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit > commit 76d2160147f43f982dfe881404cfde9fd0a9da21 > Author: Ingo Molnar <[EMA

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Manuel Lauss
Hi, On Mon, Jul 23, 2007 at 09:40:21AM +0200, Stefan Richter wrote: > Manuel Lauss wrote: > > I too experience these bugs with the new fw stack; this time with a TI > > OHCI-1394a combo chip in 2 different laptops and a Via 1394 pci addon card. > > The target is a an external hd enclosure with an

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Christoph Hellwig
On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > First of all, if you could break this up into chunks (even if they > aren't useful individually) just to make it easier to review. No, please don't do that I have no idea why people say that except for drinking too much "small patches

Re: [PATCH] AFS: Fix file locking

2007-07-23 Thread Satyam Sharma
Hi, On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Linus Torvalds wrote: > > On Fri, 20 Jul 2007, Nick Piggin wrote: > >>So you did. Then to answer that, yes it could be faster because there are >>stupid volatiles sprinkled all over the bitops code so you could easily >>end up having to do m

Re: 2.6.22-git17 boot failure

2007-07-23 Thread Jeremy Fitzhardinge
Tilman Schmidt wrote: > on Mon, 23 Jul 2007 01:47:30 +0200, /me wrote: > >> On my test machine with a Pentium D 940 processor, Intel DQ965GF >> mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails >> to come up because it cannot find the disk drives. Same issue >> with a clone of t

[patch 0/9] s390 update for 2.6.23-rc1

2007-07-23 Thread Martin Schwidefsky
The shortlog speaks for itself: Christian Borntraeger (1): [S390] add types.h include to s390_ext.h Cornelia Huck (3): [S390] cio: css_sch_device_register() can be made static. [S390] cio: Remove remains of _ccw_device_get_device_number(). [S390] cio: Remove deprecated rdc

[patch 1/9] Convert to smp_call_function_single.

2007-07-23 Thread Martin Schwidefsky
From: Heiko Carstens <[EMAIL PROTECTED]> smp_call_function_single now has the same semantics as s390's smp_call_function_on. Therefore convert to the *single variant and get rid of some architecture specific code. Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky

[patch 2/9] Improve __smp_call_function_map.

2007-07-23 Thread Martin Schwidefsky
From: Heiko Carstens <[EMAIL PROTECTED]> There is no need to disable bottom halves when holding call_lock. Also this could imply that it is legal to call smp_call_function* from bh context, which it is not. Also test if func will be executed locally before disabling and aterwards enabling interrup

[patch 3/9] cio: css_sch_device_register() can be made static.

2007-07-23 Thread Martin Schwidefsky
From: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- drivers/s390/cio/css.c |2 +- drivers/s390/cio/css.h |1 - 2 files changed, 1 insertion(+), 2 deletions(-) Index: quilt-2.6/drivers/s390/cio

[patch 4/9] cio: Remove remains of _ccw_device_get_device_number().

2007-07-23 Thread Martin Schwidefsky
From: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- drivers/s390/cio/device_ops.c |7 --- 1 file changed, 7 deletions(-) Index: quilt-2.6/drivers/s390/cio/device_ops.c

[patch 5/9] sclp: kill unused SCLP config option.

2007-07-23 Thread Martin Schwidefsky
From: Heiko Carstens <[EMAIL PROTECTED]> sclp is always compiled in. Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- drivers/s390/char/Kconfig | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Index: quilt-2.6/drive

[patch 6/9] Get rid of new section mismatch warnings.

2007-07-23 Thread Martin Schwidefsky
From: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- arch/s390/kernel/head.S|1 + arch/s390/kernel/vmlinux.lds.S |1 + arch/s390/mm/vmem.c|6 +++--- drivers/s390/char/r

[patch 7/9] cio: Remove deprecated rdc/rcd.

2007-07-23 Thread Martin Schwidefsky
From: Cornelia Huck <[EMAIL PROTECTED]> http://marc.info/?l=linux-kernel&m=118481061928246&w=2 seems to indicate disfavour of "deprecated", so let's just kill it now. Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- Documentation/feature

[patch 8/9] add types.h include to s390_ext.h

2007-07-23 Thread Martin Schwidefsky
From: Christian Borntraeger <[EMAIL PROTECTED]> The header file for external interrupts uses the _u16 type. Make sure that _u16 is defined by including linux/types.h. This prevents compile failures, if asm/s390_ext.h is the first include file. Signed-off-by: Christian Borntraeger <[EMAIL PROTECT

[patch 9/9] Wire up sys_fallocate.

2007-07-23 Thread Martin Schwidefsky
From: Martin Schwidefsky <[EMAIL PROTECTED]> This patch implements support of fallocate system call on s390(x) platform. A wrapper is added to address the issue which s390 ABI has with the arguments of this system call. Signed-off-by: Martin Schwidefsky <[EMAIL PROTECTED]> --- arch/s390/kernel

Please pull git390 'for-linus' branch

2007-07-23 Thread Martin Schwidefsky
Please pull from 'for-linus' branch of git://git390.osdl.marist.edu/pub/scm/linux-2.6.git for-linus to receive the following updates: Documentation/feature-removal-schedule.txt | 16 -- arch/s390/appldata/appldata_base.c | 12 +- arch/s390/kernel/compat_wrapper.S |

Re: [linux-pm] Power Management framework proposal

2007-07-23 Thread Ondrej Zajicek
On Sun, Jul 22, 2007 at 09:19:17PM -0700, Arjan van de Ven wrote: > let me give you a real world example then, and the numbers I'm using are > ballpark the same as you'll find in a (mobile) core 2 duo datasheet, I > just rounded them a little so that the math works out nice. > > power at full spee

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote: > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > > First of all, if you could break this up into chunks (even if they > > aren't useful individually) just to make it easier to review. > > No, please don't do that I

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Christoph Hellwig
On Mon, Jul 23, 2007 at 11:00:38AM +0200, Sam Ravnborg wrote: > On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote: > > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > > > First of all, if you could break this up into chunks (even if they > > > aren't useful individua

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-23 Thread Nick Piggin
Rusty Russell wrote: On Sun, 2007-07-22 at 16:10 +0800, Fengguang Wu wrote: So I opt for it being made tunable, safe, and turned off by default. I hate tunables :) Unless we have workload A that gets a reasonable benefit from something and workload B that gets a significant regression, and n

Re: [PATCH] AFS: Fix file locking

2007-07-23 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > I thought we long long since removed the volatiles. They're certainly still there in i386 and x86_64. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] AFS: Fix file locking

2007-07-23 Thread Satyam Sharma
[ Restricting discussion to the i386 bitops implementation. ] Hi Nick, On 7/23/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: Hi, On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: > > > > On Fri, 20 Jul 2007, Nick Piggin wrote: > > > >>So you did. Then to answer that, ye

Re: [PATCH] virtual sched_clock() for s390

2007-07-23 Thread Jan Glauber
On Fri, 2007-07-20 at 09:22 +0200, Ingo Molnar wrote: > * Paul Mackerras <[EMAIL PROTECTED]> wrote: > > As with s390, 64-bit PowerPC also uses CONFIG_VIRT_CPU_ACCOUNTING. > > That affects how tsk->utime and tsk->stime are accumulated (we call > > account_user_time and account_system_time directly

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 10:01:01AM +0100, Christoph Hellwig wrote: > On Mon, Jul 23, 2007 at 11:00:38AM +0200, Sam Ravnborg wrote: > > On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote: > > > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > > > > First of all, if you

Re: [PATCH][19/37] Clean up duplicate includes in fs/gfs2/

2007-07-23 Thread Steven Whitehouse
Hi, Now applied to the -nmw GFS2 git tree. Thanks, Steve. On Sat, 2007-07-21 at 17:03 +0200, Jesper Juhl wrote: > Hi, > > This patch cleans up duplicate includes in > fs/gfs2/ > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c

[1/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Andi Kleen 4 Linus Torvalds

Re: [2/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Andi Kleen 4 Linus Torvalds

2.6.23-rc1: known regressions with patches

2007-07-23 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc1 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Andi Kleen 4

Re: Linus 2.6.23-rc1: ACPI-related oops on x86_64

2007-07-23 Thread Mel Gorman
On (22/07/07 14:04), Linus Torvalds didst pronounce: > > Ok, right on time, two weeks afetr 2.6.22, there's a 2.6.23-rc1 out there. > This was seen on a machine on test.kernel.org; Unable to handle kernel NULL pointer dereference at RIP: [] acpi_processor_throttling_seq_show+

Re: Pin-pointing the root of unusual application latencies

2007-07-23 Thread Ingo Molnar
* John Sigler <[EMAIL PROTECTED]> wrote: > Here's a /proc/latency_trace dump. What is there to understand? > > # cat /proc/latency_trace > preemption latency trace v1.1.5 on 2.6.20.7-rt8 > > latency: 26 us, #2/2, CPU#0 | (M:rt

Re: [PATCH] spinlock in function hugetlb_fault could be deleted

2007-07-23 Thread Zhang, Yanmin
On Mon, 2007-07-23 at 16:18 +0800, Zhang, Yanmin wrote: > Function hugetlb_fault needn't hold spinlock mm->page_table_lock, > because when hugetlb_fault is called: > 1) mm->mmap_sem is held already; > 2) hugetlb_instantiation_mutex is held by hugetlb_fault, which prevents > other threads/processes

Re: [v4l-dvb-maintainer] [2.6.23 regression fix] usbvision: don't return an uninitialized value

2007-07-23 Thread Trent Piepho
On Mon, 23 Jul 2007, Adrian Bunk wrote: > Commit c5f48367fe54c46805774eeea8e828de54a5ad7b introduced this return > of an uninitialized variable. > > Spotted by the Coverity checker. It spotted that, but it seems it missed the bigger bug, reg->val is unsigned. Since reg->val can't be less than 0,

[PATCH] add __GFP_ZERP to GFP_LEVEL_MASK

2007-07-23 Thread Peter Zijlstra
Daniel recently spotted that __GFP_ZERO is not (and has never been) part of GFP_LEVEL_MASK. I could not find a reason for this in the original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk tree. This of course is in stark contradiction with the comment accompanying GFP_LEVEL_MASK. S

Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size

2007-07-23 Thread Jörn Engel
On Sun, 22 July 2007 18:44:03 +0200, Jens Axboe wrote: > > > > > I agree with the low point of 128k. > > > > Perhaps that should be enforced then, because currently a system with > > <64M will get less. > > I think it should remain the low point. I believe this whole thing is fundamentally fla

Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size

2007-07-23 Thread Jens Axboe
On Mon, Jul 23 2007, Jörn Engel wrote: > On Sun, 22 July 2007 18:44:03 +0200, Jens Axboe wrote: > > > > > > > I agree with the low point of 128k. > > > > > > Perhaps that should be enforced then, because currently a system with > > > <64M will get less. > > > > I think it should remain the low

Re: [PATCH][37/37] Clean up duplicate includes in sound/soc/

2007-07-23 Thread Richard Purdie
On Sat, 2007-07-21 at 17:04 +0200, Jesper Juhl wrote: > This patch cleans up duplicate includes in > sound/soc/ > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: Richard Purdie <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Andreas Micklei
Am Montag, 23. Juli 2007 schrieb Andreas Messer: > The first System, where harddisc don't work at all with the new stack: > Nvidia NForce2 Ultra Chipset; 1GB RAM; XP-M 2600; FW-Controller is > PCI addon card; lspci says Via Additional note: On the machine where my iPod 3G corruption occure I have

Re: [1/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Al Viro
On Mon, Jul 23, 2007 at 11:47:30AM +0200, Michal Piotrowski wrote: > Subject : drivers/misc/asus-laptop.c:*: error: 'struct led_classdev' > has no member named 'class_dev' > References : http://lkml.org/lkml/2007/7/22/299 > Last known good : ? > Submitter : Gabriel C <[EMAIL PRO

[2.6.23 regression fix] include/asm-xtensa/io.h must #include

2007-07-23 Thread Adrian Bunk
This patch fixes the following compile error: <-- snip --> ... CC kernel/time/clocksource.o In file included from /home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/include/linux/clocksource.h:18, from /home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/kernel/time/clocksou

Re: 2.6.23-rc1: known regressions with patches

2007-07-23 Thread Ingo Molnar
* Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Subject : Regression with sys_time() speedup patch > References : http://lkml.org/lkml/2007/7/20/205 > Last known good : ? > Submitter : Takashi Iwai <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Ingo Molnar <[EMA

Re: sound/core/init.c - address of 'snd_shutdown_f_ops' will always evaluate as 'true' , warning

2007-07-23 Thread Takashi Iwai
At Mon, 23 Jul 2007 02:43:29 +0200, Gabriel C wrote: > > Hi, > > I got this warning on current git using gcc 4.2.1: > > ... > > sound/core/init.c: In function 'snd_card_disconnect': > sound/core/init.c:307: warning: the address of 'snd_shutdown_f_ops' will > always evaluate as 'true' > > ...

Re: [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: This patch series make kvm guest pages be able to be swapped out and dynamically allocated. Without it, all guest memory is allocated at guest start time. patches are against latest git, and you need first patch Avi's kvm-sch integration patch (http://sourceforge.net/mailarchiv

Re: [linux-pm] Re: Hibernation considerations

2007-07-23 Thread Miklos Szeredi
> > The only thing to do is what Rafael has been working on: unfreeze > > things, hope the tasks sort themselves out, and try again. > > That's what I'm questioning. Is there a more reliable way and we've > just given up too quickly? There obviously _are_ more reliable ways. A trivial one seems

Re: [RFC 1/1] lro: Generic Large Receive Offload for TCP traffic

2007-07-23 Thread Evgeniy Polyakov
Hi Jan-Bernd. On Fri, Jul 20, 2007 at 05:41:48PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: > Generic LRO patch > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> Besides couple trivial codyng/formatting nits I did not found any problematic places after review. Details below. Th

Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: fix some bugs in kvm-sch patch. There is now a 'preempt-hooks' branch on kvm.git with the preempt-hooks work. I'll continually update and rebase it against master. 1. vmcs_readl/vmcs_writel are called with preempt enabled Why is that bad? 2. preempt_count check

Re: [linux-pm] Power Management framework proposal

2007-07-23 Thread Igor Stoppa
On Sun, 2007-07-22 at 14:21 -0700, ext [EMAIL PROTECTED] wrote: [snip] > this is another one. I'd be happy to get pointers to prior ones to learn > from. https://lists.linux-foundation.org/pipermail/linux-pm/2007-March/011204.html This is probably one of the latest. Previously there was some c

SCSI vs SATA

2007-07-23 Thread BuraphaLinux Server
Hello, I have had a hard time determining if /dev/sda is SCSI or SATA from my boot scripts. It matters for smartd which needs an added parameter -d sat in the configuration file for SATA drives. Finally I came up with this, but I wonder if there is a better way? It appears that vendor is "A

Re: [RFH] Partition table recovery

2007-07-23 Thread Rene Herman
On 07/23/2007 10:41 AM, Jan-Benedict Glaw wrote: As multibyte on-disk variables, these will need LE/BE conversion. Indeed, thanks -- has been updated in the version that is attached. Also fixes a bug that snuck in (failed to add offset to entry->start). struct entry { uint8_t flags;

Re: SCSI vs SATA

2007-07-23 Thread Michael Tokarev
BuraphaLinux Server wrote: > Hello, > >I have had a hard time determining if /dev/sda is SCSI or SATA > from my boot scripts. It matters for smartd which needs an added > parameter -d sat in the configuration file for SATA drives. Finally I Just FYI: Recent smartmontools (5.36+) can figure

Re: [RFC 3/8]KVM: convert vm lock to a mutex

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: convert kvm lock to a mutex. TBD: after this change, a lot of logic in kvm can be simplified, eg, we don't need release lock and then do operation blocking. This is now in the preempt-hooks branch. -- error compiling committee.c: too many arguments to function - To unsu

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Lars Ellenberg
On Mon, Jul 23, 2007 at 11:19:40AM +0200, Sam Ravnborg wrote: > The message is quite clear. > For a driver like this do something like: > - Describe the functionality / the problem is solved > - Describe the overall design (maybe as a file in Documentation/?) I'm currently writing the paper for li

Re: SCSI vs SATA

2007-07-23 Thread Rene Herman
On 07/23/2007 12:52 PM, BuraphaLinux Server wrote: #! /bin/bash drive="sda" vendor=$( This is probably not a useful comment and a reasonable script in your local setting but still thought I'd point out that these days most anything is sda, so if !SATA it can generally also be USB, or FW, or

Re: [RFC 6/8]KVM: introduce kvm_mmu_zap_pagetbl

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: add a routine to zap all shadow pgtble for a gfn. If kvm supports SMP, the API should zap pgtble for all vcpus, but kvm shadow page table really should be per-vm, instead of per-vcpu. kvm shadow page tables _are_ per-vm. Current kvm.git even makes that more explicit wher

Re: [1/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Trent Piepho
On Mon, 23 Jul 2007, Michal Piotrowski wrote: > ACPI > > Subject : drivers/misc/asus-laptop.c:*: error: 'struct led_classdev' > has no member named 'class_dev' > References : http://lkml.org/lkml/2007/7/22/299 > Last known good : ? > Submitter : Gabriel C <[EMAIL PROTECTED]> > C

Re: [PATCH] add __GFP_ZERP to GFP_LEVEL_MASK

2007-07-23 Thread Mel Gorman
On (23/07/07 12:03), Peter Zijlstra didst pronounce: > > Daniel recently spotted that __GFP_ZERO is not (and has never been) > part of GFP_LEVEL_MASK. I could not find a reason for this in the > original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk > tree. > > This of course is in s

Re: [1/2] 2.6.23-rc1: known regressions

2007-07-23 Thread Al Viro
On Mon, Jul 23, 2007 at 04:17:05AM -0700, Trent Piepho wrote: > Here's a trivial patch for this one. > > asus-laptop: Sync with changes to led class > > Driver was broken by commit f8a7c6fe14f556ca8eeddce258cb21392d0c3a2f >

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Stefan Richter
Andreas Messer wrote: > On Monday, 23. Juli 2007 01:34 Stefan Richter wrote: >> Are you sure the FireWire controller is from VIA? Check with lscpi. >> The NVidia nForce2 chipset has an own FireWire controller, and that one >> is only "supported" by a gross hack in ohci1394 and at the moment >> uns

Re: [RFC 7/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: Make KVM guest pages be allocated dynamically and able to be swaped out. One issue: all inodes returned from anon_inode_getfd are shared, if one module changes field of the inode, other moduels might break. Should we introduce a new API to not share inode? Signed-off-by: Shaoh

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-23 Thread Stefan Richter
Manuel Lauss wrote: > I noticed the failures start when there are 2 concurrent disk accesses > (copy something from fw disk on shell 1 and it runs fine; start to > copy something TO the fw disk on shell 2 and a "management write failed" > error appears after 1-2 sec. with the orb timeout after a lo

2.6.23-rc1 section mismatch warnings

2007-07-23 Thread markus reichelt
Hi, 2.6.23-rc1 (as well as 2.6.22.x) produces some section mismatch warnings during compile on slackware 11 (gcc-3.4.6, glibc-2.3.6): LD vmlinux.o MODPOST vmlinux.o WARNING: vmlinux.o(.text+0x139c1): Section mismatch: reference to .init.data:trampoline_end (between 'setup_trampoline' and

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

2007-07-23 Thread Peter Zijlstra
On Mon, 2007-07-23 at 12:21 +0100, Mel Gorman wrote: > Does this patch compile though? Ugh, the fix landed in another patch :-( updated patch below. --- Daniel recently spotted that __GFP_ZERO is not (and has never been) part of GFP_LEVEL_MASK. I could not find a reason for this in the original

  1   2   3   4   5   6   >