On Mon, Jul 23, 2007 at 04:17:05AM -0700, Trent Piepho wrote: > Here's a trivial patch for this one. > ------------------------------------------------------------------------ > asus-laptop: Sync with changes to led class > > Driver was broken by commit f8a7c6fe14f556ca8eeddce258cb21392d0c3a2f > leds: Convert from struct class_device to struct device > > Convert the LEDs class from struct class_device to struct device > since class_device is scheduled for removal. > > Use (struct led_classdev).dev instead of (struct led_classdev).class_dev
It doesn't fix the real bug in there - if you look carefully at the code, you'll see that we don't get to these checks if allocation fails halfway through (and we leak in that case) *and* these checks are not needed at all if failure happens elsewhere. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/