On Mon, Jul 23, 2007 at 11:00:38AM +0200, Sam Ravnborg wrote: > On Mon, Jul 23, 2007 at 09:49:03AM +0100, Christoph Hellwig wrote: > > On Sun, Jul 22, 2007 at 09:32:02PM -0400, Kyle Moffett wrote: > > > First of all, if you could break this up into chunks (even if they > > > aren't useful individually) just to make it easier to review. > > > > No, please don't do that I have no idea why people say that except for > > drinking too much "small patches" koolaid. > > It is much more preferred to have code available in the mailer than > being forced to copy it from some big patch somewhere when you > want to point out something.
While that's a valid point I totally agree on for small patches it just doesn't matter for a complex driver where you need to sit down for an hour or more to actually do a useful review. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/