[PATCH bpf 0/2] bpf: Avoid RCU context warning when unpinning htab with internal structs

2025-10-03 Thread KaFai Wan
This small patchset is about avoid RCU context warning when unpinning htab with internal structs (timer, workqueue, or task_work). --- KaFai Wan (2): bpf: Avoid RCU context warning when unpinning htab with internal structs selftests/bpf: Add test for unpinning htab with internal timer

[PATCH bpf 1/2] bpf: Avoid RCU context warning when unpinning htab with internal structs

2025-10-03 Thread KaFai Wan
When unpinning a BPF hash table (htab or htab_lru) that contains internal structures (timer, workqueue, or task_work) in its values, a BUG warning is triggered: BUG: sleeping function called from invalid context at kernel/bpf/hashtab.c:244 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid

Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

2025-09-29 Thread Dev Jain
On 29/09/25 5:24 pm, Sidharth Seela wrote: Fix warning caused from declaration under a case label. The proper way is to declare variable at the beginning of the function. The warning came from running clang using LLVM=1; and is as follows: -- -test_cachestat.c:260:3: warning: label followed by

Re: [PATCH v1] selftests: cachestat: Fix warning on declaration under label

2025-09-29 Thread SeongJae Park
On Mon, 29 Sep 2025 17:24:06 +0530 Sidharth Seela wrote: > Fix warning caused from declaration under a case label. The proper way > is to declare variable at the beginning of the function. The warning > came from running clang using LLVM=1; and is as follows: > -- > -test_ca

[PATCH v1] selftests: cachestat: Fix warning on declaration under label

2025-09-29 Thread Sidharth Seela
Fix warning caused from declaration under a case label. The proper way is to declare variable at the beginning of the function. The warning came from running clang using LLVM=1; and is as follows: -- -test_cachestat.c:260:3: warning: label followed by a declaration is a C23 extension [-Wc23

Re: [PATCH] Net: psock_tpacket: Fix null argument warning in walk_tx

2025-09-24 Thread Willem de Bruijn
[PATCH net-next] Wake Liu wrote: > The sendto() call in walk_tx() was passing NULL as the buffer argument, > which can trigger a -Wnonnull warning with some compilers. > > Although the size is 0 and no data is actually sent, passing a null > pointer is technically incorrect. &

[RESEND PATCH] selftests/filesystems: Fix build warning on anon_inode_test

2025-09-19 Thread Ranganath V N
clang warning null passed where non-null argument is expected. anon_inode_test.c:45:19: warning: argument 3 null where non-null expected [-Wnonnull] 45 | ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), 0); | ^~~~ Signed-off-by: R

[PATCH v4 22/63] objtool: Fix "unexpected end of section" warning for alternatives

2025-09-17 Thread Josh Poimboeuf
h can trigger a confusing "unexpected end of section" warning which blames .altinstr_replacement rather than the offending fallthrough function. Fix that by not caching the section. There's no point in doing that anyway. Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 5 +---

Re: [syzbot] [net?] WARNING: suspicious RCU usage in corrupted (3)

2025-09-14 Thread Charalampos Mitrodimas
syzbot writes: > syzbot suspects this issue was fixed by commit: > > commit 7f12c33850482521c961c5c15a50ebe9b9a88d1e > Author: Charalampos Mitrodimas > Date: Wed Jun 11 17:20:43 2025 + > > net, bpf: Fix RCU usage in task_cls_state() for BPF programs > > bisection log: https://syzkalle

[PATCH] selftests/filesystems: Fix build warning on anon_inode_test

2025-09-10 Thread Ranganath V N
>clang warning null passed where non-null argument is expected. > >anon_inode_test.c:45:19: warning: argument 3 null where non-null expected >[-Wnonnull] > 45 | ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), > 0); > |

Re: [syzbot] [net?] WARNING: suspicious RCU usage in corrupted (3)

2025-09-08 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 7f12c33850482521c961c5c15a50ebe9b9a88d1e Author: Charalampos Mitrodimas Date: Wed Jun 11 17:20:43 2025 + net, bpf: Fix RCU usage in task_cls_state() for BPF programs bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=137

Re: [PATCH v2] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-09-08 Thread Will Deacon
On Thu, 07 Aug 2025 17:12:29 +0530, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. > > Fixes compiler warning

Re: [PATCH] Fixed the build warning in init_trace_printk_function_export():

2025-09-07 Thread kernel test robot
-base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Fidal-Palamparambil/Fixed-the-build-warning-in-init_trace_printk_function_export/20250907-221041 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH] Fixed the build warning in init_trace_printk_function_export():

2025-09-07 Thread kernel test robot
Hi Fidal, kernel test robot noticed the following build warnings: [auto build test WARNING on trace/for-next] [also build test WARNING on linus/master v6.17-rc4 next-20250905] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] Fixed the build warning in init_trace_printk_function_export():

2025-09-07 Thread Fidal Palamparambil
From: Fidal palamparambil Changed int ret to struct dentry *dentry Changed if (ret) to if (IS_ERR_OR_NULL(dentry)) Fixed memory leak in hold_module_trace_bprintk_format(): Added proper cleanup when fmt allocation fails Set tb_fmt = NULL after freeing to prevent dangling pointers Fixed NULL p

Re: next-20250805: ampere: WARNING: kernel/cgroup/cpuset.c:1352 at remote_partition_disable

2025-09-03 Thread Naresh Kamboju
ot seen after this. Reference: - https://regressions.linaro.org/lkft/linux-next-master-ampere/next-20250805/log-parser-test/exception-warning-kernelcgroupcpuset-at-remote_partition_disable/history/?page=1 - Naresh > > Thanks, > Michal

Re: next-20250805: ampere: WARNING: kernel/cgroup/cpuset.c:1352 at remote_partition_disable

2025-09-02 Thread Waiman Long
On 9/2/25 6:58 AM, Naresh Kamboju wrote: On Tue, 26 Aug 2025 at 19:56, Michal Koutný wrote: Hi. On Thu, Aug 07, 2025 at 01:57:34PM +0530, Naresh Kamboju wrote: Regressions noticed intermittently on AmpereOne while running selftest cgroup testing with Linux next-20250805 and earlier seen o

Re: next-20250805: ampere: WARNING: kernel/cgroup/cpuset.c:1352 at remote_partition_disable

2025-08-26 Thread Michal Koutný
Hi. On Thu, Aug 07, 2025 at 01:57:34PM +0530, Naresh Kamboju wrote: > Regressions noticed intermittently on AmpereOne while running selftest > cgroup testing > with Linux next-20250805 and earlier seen on next-20250722 tag also. > > Regression Analysis: > - New regression? Yes > - Reproducibili

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-18 Thread Will Deacon
; > > > > > > > > > > > > > syzbot has tested the proposed patch but the reproducer is still > > > > > > > triggering an issue: > > > > > > > WARNING in virtio_transport_send_pkt_info > > > > > >

[PATCH 2/3] kselftest/arm64: Supress warning and improve readability

2025-08-16 Thread vivekyadav1207731111
From: Vivek Yadav The comment was correct, but `checkpatch` script flagged it with a warning as shown in the output section. The comment is slightly modified to improve readability, which also suppresses the warning. ``` [command] ./script/checkpatch.pl --strict -f tools/testing

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-16 Thread Michael S. Tsirkin
gt; On Tue, Aug 12, 2025 at 06:15:46AM -0400, Michael S. Tsirkin wrote: > > > > > On Tue, Aug 12, 2025 at 03:03:02AM -0700, syzbot wrote: > > > > > > Hello, > > > > > > > > > > > > syzbot has tested the

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
> > On Tue, Aug 12, 2025 at 03:03:02AM -0700, syzbot wrote: > > > > > Hello, > > > > > > > > > > syzbot has tested the proposed patch but the reproducer is still > > > > > triggering an issue: > > > > &

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
ote: > > > > Hello, > > > > > > > > syzbot has tested the proposed patch but the reproducer is still > > > > triggering an issue: > > > > WARNING in virtio_transport_send_pkt_info > > > > > > OK so the issue triggers on > > > com

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Michael S. Tsirkin
ed patch but the reproducer is still > > > triggering an issue: > > > WARNING in virtio_transport_send_pkt_info > > > > OK so the issue triggers on > > commit 6693731487a8145a9b039bc983d77edc47693855 > > Author: Will Deacon > > Date: Thu Jul 17 10:01:16 2025

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-15 Thread Will Deacon
On Tue, Aug 12, 2025 at 06:15:46AM -0400, Michael S. Tsirkin wrote: > On Tue, Aug 12, 2025 at 03:03:02AM -0700, syzbot wrote: > > Hello, > > > > syzbot has tested the proposed patch but the reproducer is still triggering > > an issue: > > WARNING in virtio_trans

Re: [PATCH v2] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-13 Thread Anshuman Khandual
On 07/08/25 5:12 PM, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. > > Fixes compiler warning (similar f

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-12 Thread Michael S. Tsirkin
On Tue, Aug 12, 2025 at 03:03:02AM -0700, syzbot wrote: > Hello, > > syzbot has tested the proposed patch but the reproducer is still triggering > an issue: > WARNING in virtio_transport_send_pkt_info OK so the issue triggers on commit 6693731487a8145a9b039bc983d77edc476938

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-12 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: WARNING in virtio_transport_send_pkt_info [ cut here ] 'send_pkt()' returns 0, but 65536 expected WARNING: CPU: 0 PID: 5936 at net/vmw_vsock/virtio_transport_co

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-12 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-by: syzbot+b4d960daf7a3c7c2b...@syzkaller.appspotmail.com Tested-by: syzbot+b4d960daf7a3c7c2b...@syzkaller.appspotmail.com Tested on: commit: 8ca76151 vsock/virtio: Rename virtio_vsock_sk

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-12 Thread Michael S. Tsirkin
se add the following tag to the commit: > Reported-by: syzbot+b4d960daf7a3c7c2b...@syzkaller.appspotmail.com > > ----[ cut here ] > 'send_pkt()' returns 0, but 65536 expected > WARNING: CPU: 0 PID: 5503 at net/vmw_vsock/virtio_transport_common.c:428 > virtio_tr

Re: [syzbot] [kvm?] [net?] [virt?] WARNING in virtio_transport_send_pkt_info

2025-08-12 Thread Michael S. Tsirkin
se add the following tag to the commit: > Reported-by: syzbot+b4d960daf7a3c7c2b...@syzkaller.appspotmail.com > > ----[ cut here ] > 'send_pkt()' returns 0, but 65536 expected > WARNING: CPU: 0 PID: 5503 at net/vmw_vsock/virtio_transport_common.c:428 > virtio_tr

Re: next-20250805: ampere: WARNING: kernel/cgroup/cpuset.c:1352 at remote_partition_disable

2025-08-07 Thread Waiman Long
-20250722 and after next-20250805. Test regression: next-20250805 ampere WARNING kernel cgroup cpuset.c at remote_partition_disable Reported-by: Linux Kernel Functional Testing ## Test log selftests: cgroup: test_cpuset_prs.sh Running state tRunning state transition test ... ransition test

Re: [PATCH v2] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-07 Thread Mark Brown
On Thu, Aug 07, 2025 at 05:12:29PM +0530, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. Not just maintaining,

Re: [PATCH] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-07 Thread Mark Brown
On Thu, Aug 07, 2025 at 02:09:26AM +0530, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. Ouch, good spot. Annoyingly

[PATCH v2] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-07 Thread Bala-Vignesh-Reddy
Resolve compiler warning about always true condition in ksft_test_result in tpidr2, passing actual function. This silences -Waddress warning while maintaining test functionality. Fixes compiler warning (similar for other functions): warning: the address of 'write_read' will always e

next-20250805: ampere: WARNING: kernel/cgroup/cpuset.c:1352 at remote_partition_disable

2025-08-07 Thread Naresh Kamboju
regression: next-20250805 ampere WARNING kernel cgroup cpuset.c at remote_partition_disable Reported-by: Linux Kernel Functional Testing ## Test log selftests: cgroup: test_cpuset_prs.sh Running state tRunning state transition test ... ransition test ... Running test 0 ... Running test 1 ... Running

Re: [PATCH] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-06 Thread Anshuman Khandual
On 07/08/25 2:09 AM, Bala-Vignesh-Reddy wrote: > Resolve compiler warning about always true condition in ksft_test_result > in tpidr2, passing actual function. > > This silences -Waddress warning while maintaining test functionality. Might be better to just add the compiler warning i

Re: [PATCH -next] selftests/bpf: Fix warning comparing pointer to 0

2025-08-06 Thread Alexei Starovoitov
On Wed, Aug 6, 2025 at 6:54 PM Jiapeng Chong wrote: > > Avoid pointer type value compared with 0 to make code clear. > > ./tools/testing/selftests/bpf/progs/mem_rdonly_untrusted.c:221:10-11: WARNING > comparing pointer to 0. > > Reported-by: Abaci Robot Hey Abaci folks, s

[PATCH -next] selftests/bpf: Fix warning comparing pointer to 0

2025-08-06 Thread Jiapeng Chong
Avoid pointer type value compared with 0 to make code clear. ./tools/testing/selftests/bpf/progs/mem_rdonly_untrusted.c:221:10-11: WARNING comparing pointer to 0. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=23403 Signed-off-by: Jiapeng Chong --- tools

[PATCH] selftests: arm64: Fix -Waddress warning in tpidr2 test

2025-08-06 Thread Bala-Vignesh-Reddy
Resolve compiler warning about always true condition in ksft_test_result in tpidr2, passing actual function. This silences -Waddress warning while maintaining test functionality. Signed-off-by: Bala-Vignesh-Reddy --- tools/testing/selftests/arm64/abi/tpidr2.c | 8 1 file changed, 4

Re: [syzbot] [rcu?] WARNING in srcu_invoke_callbacks (2)

2025-08-06 Thread Youngmin Nam
assets: > >>> disk image: > >>> https://storage.googleapis.com/syzbot-assets/c0a862fcec77/disk-a64dcfb4.raw.xz > >>> vmlinux: > >>> https://storage.googleapis.com/syzbot-assets/f03793fc001b/vmlinux-a64dcfb4.xz > >>> kernel image: > >>>

[PATCH v2] selftests/proc: Fix string literal warning in proc-maps-race.c

2025-08-04 Thread Sukrut Heroorkar
This change resolves non literal string format warning invoked for proc-maps-race.c while compiling. proc-maps-race.c:205:17: warning: format not a string literal and no format arguments [-Wformat-security] 205 | printf(text); | ^~ proc-maps-race.c:209

Re: [PATCH] selftests/proc: Fix string literal warning in proc-maps-race.c

2025-08-04 Thread sukrut heroorkar
Hi Suren, On Mon, Aug 4, 2025 at 9:47 PM Suren Baghdasaryan wrote: > > On Sun, Aug 3, 2025 at 1:48 PM Sukrut Heroorkar wrote: > > > > This change resolves non literal string format warning invoked > > for proc-maps-race.c while compiling. > > > > proc-maps-

Re: [PATCH] selftests/proc: Fix string literal warning in proc-maps-race.c

2025-08-04 Thread Suren Baghdasaryan
On Sun, Aug 3, 2025 at 1:48 PM Sukrut Heroorkar wrote: > > This change resolves non literal string format warning invoked > for proc-maps-race.c while compiling. > > proc-maps-race.c:205:17: warning: format not a string literal and no format > arguments [-Wformat

[PATCH] selftests/proc: Fix string literal warning in proc-maps-race.c

2025-08-03 Thread Sukrut Heroorkar
This change resolves non literal string format warning invoked for proc-maps-race.c while compiling. proc-maps-race.c:205:17: warning: format not a string literal and no format arguments [-Wformat-security] 205 | printf(text); | ^~ proc-maps-race.c:209

[PATCH] selftests/filesystems: Fix build warning on anon_inode_test

2025-07-30 Thread Ranganath V N
clang warning null passed where non-null argument is expected. anon_inode_test.c:45:19: warning: argument 3 null where non-null expected [-Wnonnull] 45 | ASSERT_LT(execveat(fd_context, "", NULL, NULL, AT_EMPTY_PATH), 0); | ^~~~ Signed-off-by: R

[PATCH v3 20/64] objtool: Fix "unexpected end of section" warning for alternatives

2025-06-26 Thread Josh Poimboeuf
h can trigger a confusing "unexpected end of section" warning which blames .altinstr_replacement rather than the offending fallthrough function. Fix that by not caching the section. There's no point in doing that anyway. Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 5 +---

[syzbot] [wpan?] WARNING in lowpan_xmit (2)

2025-06-24 Thread syzbot
, please add the following tag to the commit: Reported-by: syzbot+5b74e0e96f12e3728...@syzkaller.appspotmail.com ieee802154 phy0 wpan0: encryption failed: -22 ieee802154 phy1 wpan1: encryption failed: -22 [ cut here ] WARNING: CPU: 1 PID: 1302 at ./include/linux/skbuff.h:3157

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
On Mon, Jun 23, 2025 at 12:22 PM Muhammad Usama Anjum wrote: > > On 6/20/25 7:55 PM, Chen Linxuan wrote: > > On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum > > wrote: > >> > >> On 6/20/25 8:50 AM, Chen Linxuan wrote: > >>> When running `ma

[PATCH v3] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir

[PATCH] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-23 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-22 Thread Muhammad Usama Anjum
On 6/20/25 7:55 PM, Chen Linxuan wrote: > On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum > wrote: >> >> On 6/20/25 8:50 AM, Chen Linxuan wrote: >>> When running `make kselftest`, the following compilation warning was >>> encountered: >

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum wrote: > > On 6/20/25 8:50 AM, Chen Linxuan wrote: > > When running `make kselftest`, the following compilation warning was > > encountered: > > > > mount-notify_test.c: In function ‘fanotify_rmdir’: > >

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Muhammad Usama Anjum
On 6/20/25 8:50 AM, Chen Linxuan wrote: > When running `make kselftest`, the following compilation warning was > encountered: > > mount-notify_test.c: In function ‘fanotify_rmdir’: > mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ > decla

[PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-19 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 5:41 AM Shuah Khan wrote: > > On 6/19/25 13:00, John Hubbard wrote: > > On 6/19/25 10:00 AM, Shuah Khan wrote: > >> On 6/19/25 01:46, Chen Linxuan wrote: > >>> On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan > >>> wrote: > On 6/9/25 20:07, Chen Linxuan wrote: > > ... > >>

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 15:40, Shuah Khan wrote: On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems/mount-notify/mount- notify_test.c b

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread John Hubbard
On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems/mount-notify/mount- notify_test.c b/tools/testing/selftests/filesystems/mou

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Chen Linxuan
On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: > > On 6/9/25 20:07, Chen Linxuan wrote: > > When running `make kselftest`, the following compilation warning was > > encountered: > > > > mount-notify_test.c: In function ‘fanotify_rmdir’: > > mount-notify_tes

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-18 Thread Shuah Khan
On 6/9/25 20:07, Chen Linxuan wrote: When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result

clang: selftests mm pkey_sighandler_tests.c warning duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier]

2025-06-16 Thread Naresh Kamboju
regression: selftests mm pkey_sighandler_tests.c warning duplicate 'inline' declaration specifier [-Wduplicate-decl-specifier] Build regression: selftests mm mremap_test.c warning pointer comparison always evaluates to false [-Wtautological-compare] Reported-by: Linux Kernel Function

Re: selftests/filesystem: clang warning null passed to a callee that requires a non-null argument [-Wnonnull]

2025-06-11 Thread Nathan Chancellor
__path, char *const __argv[], char *const __envp[], int __flags) __THROW __nonnull ((2, 3)); so I think the warning is valid in this case. I will note that tools/testing/selftests/exec/recursion-depth.c uses execve() with a NULL argv and disables -Wnonnull so maybe that

Re: selftests/filesystem: clang warning null passed to a callee that requires a non-null argument [-Wnonnull]

2025-06-11 Thread Dan Carpenter
ecute program relative to a directory file descriptor. */ > extern int execveat (int __fd, const char *__path, char *const __argv[], >char *const __envp[], int __flags) > __THROW __nonnull ((2, 3)); > > so I think the warning is valid in this case. I wil

Re: selftests/filesystem: clang warning null passed to a callee that requires a non-null argument [-Wnonnull]

2025-06-11 Thread Dan Carpenter
x next-20250603 > > Regressions found on arm, arm64 and x86_64 > - selftests/filesystem > > Regression Analysis: > - New regression? Yes > - Reproducible? Yes > > First seen on the next-20250603 > Good: next-20250530 > Bad: next-20250603 > > Test regressio

[PATCH v3 0/9] selftests: vDSO: Some cleanups and (warning) fixes

2025-06-11 Thread Thomas Weißschuh
Fixes and cleanups for various issues in the vDSO selftests. Signed-off-by: Thomas Weißschuh --- Changes in v3: - Rebase on v6.16-rc1 - Preserve vgetrandom_put_state() - Pick up vdso_standalone_test_x86 into this series - Link to v2: https://lore.kernel.org/r/20250505-selftests-vdso-fixes-v2-0-3

[PATCH RESEND] selftests: Suppress unused variable warning

2025-06-09 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir

selftests/filesystem: clang warning null passed to a callee that requires a non-null argument [-Wnonnull]

2025-06-05 Thread Naresh Kamboju
: next-20250530 Bad: next-20250603 Test regression: arm arm64 x86_64 clang warning null passed to a callee that requires a non-null argument [-Wnonnull] Reported-by: Linux Kernel Functional Testing ## Build warnings make[4]: Entering directory '/builds/linux/tools/testing/selftests/filesy

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Paolo Abeni : On Tue, 27 May 2025 11:11:38 +0530 you wrote: > On linux-next, build for bpf selftest displays a warning: > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' > differs from late

Re: [PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-28 Thread Daniel Borkmann
On 5/27/25 7:41 AM, Saket Kumar Bhaskar wrote: On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UA

[PATCH net-next] selftests/bpf: Fix bpf selftest build warning

2025-05-26 Thread Saket Kumar Bhaskar
On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers&q

[PATCH] selftests: Suppress unused variable warning

2025-05-13 Thread Chen Linxuan
When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 490 | chdir

Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-12 Thread Alexei Starovoitov
On Mon, May 12, 2025 at 2:23 AM Greg KH wrote: > > On Mon, May 12, 2025 at 02:45:11PM +0530, Saket Kumar Bhaskar wrote: > > On linux-next, build for bpf selftest displays a warning: > > > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h'

Re: [RESEND PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-12 Thread Greg KH
On Mon, May 12, 2025 at 02:45:11PM +0530, Saket Kumar Bhaskar wrote: > On linux-next, build for bpf selftest displays a warning: > > Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' > differs from latest version at 'include/uapi/linux/if_xdp.h'

[RESEND PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-12 Thread Saket Kumar Bhaskar
On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers&q

[PATCH v2 20/62] objtool: Fix "unexpected end of section" warning for alternatives

2025-05-09 Thread Josh Poimboeuf
h can trigger a confusing "unexpected end of section" warning which blames .altinstr_replacement rather than the offending fallthrough function. Fix that by not caching the section. There's no point in doing that anyway. Signed-off-by: Josh Poimboeuf --- tools/objtool/check.c | 5 +---

Re: [PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-09 Thread Venkat Rao Bagalkote
On 09/05/25 6:08 pm, Saket Kumar Bhaskar wrote: On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UA

[PATCH] selftests/bpf: Fix bpf selftest build warning

2025-05-09 Thread Saket Kumar Bhaskar
On linux-next, build for bpf selftest displays a warning: Warning: Kernel ABI header at 'tools/include/uapi/linux/if_xdp.h' differs from latest version at 'include/uapi/linux/if_xdp.h'. Commit 8066e388be48 ("net: add UAPI to the header guard in various network headers&q

[PATCH v4 03/14] selftests: harness: Ignore unused variant argument warning

2025-05-05 Thread Thomas Weißschuh
For tests without fixtures the variant argument is unused. This is intentional, prevent to compiler from complaining. Example warning: harness-selftest.c: In function 'wrapper_standalone_pass': ../kselftest_harness.h:181:52: error: unused parameter 'variant' [-Wer

[PATCH v2 0/8] selftests: vDSO: Some cleanups and (warning) fixes

2025-05-05 Thread Thomas Weißschuh
Fixes and cleanups for various issues in the vDSO selftests. Signed-off-by: Thomas Weißschuh --- Changes in v2: - Refer to -Wstrict-prototypes over -Wold-style-prototypes - Pick up Acks - Enable fixed warnings in Makefile - Link to v1: https://lore.kernel.org/r/20250502-selftests-vdso-fixes-v1-0

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-19 Thread Sahil Siddiq
email id. Yes, please do this. I have sent a new patch series. The email ids should match now. I have also addressed the build warning that had appeared earlier so those changes won't have to be made manually using "git fixup". Thanks, Sahil

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-18 Thread Stafford Horne
> > > > > > > > ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch > > > > > > > > --

Re: [PATCH v3 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-18 Thread Muhammad Usama Anjum
On 4/11/25 2:00 PM, Thomas Weißschuh wrote: > For tests without fixtures the variant argument is unused. > This is intentional, prevent to compiler from complaining. > > Example warning: > > harness-selftest.c: In function 'wrapper_standalone_pass': > ../ks

[PATCH 2/4] rcu: Add warning to ensure rcu_seq_done_exact() is working

2025-04-18 Thread Joel Fernandes
The previous patch improved the rcu_seq_done_exact() function by adding a meaningful constant for the guardband. Ensure that this is working for the future by a quick check during rcu_gp_init(). Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 6 ++ 1 fil

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-18 Thread Sahil Siddiq
--- WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq ' != 'Signed-off-by: Sahil Siddiq ' total: 0 errors, 1 warnings, 102 lines checked As you can see above the scripts/checkpatch.pl is failing with the warning about your email and signed-off-by no

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-18 Thread Stafford Horne
t; ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch > > > > --- > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil > > Siddiq &#

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-18 Thread Sahil Siddiq
: --- ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch --- WARNING: From:/Signed-off-by

Re: [PATCH] openrisc: Fix build warning in cache.c

2025-04-18 Thread Stafford Horne
0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch ------- WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq ' != 'Signed-off-by: Sahil Siddiq ' total: 0 errors, 1 warnings

Re: [PATCH v3 9/9] vhost: add WARNING if log_num is more than limit

2025-04-15 Thread Dongli Zhang
gt;> Since long time ago, the only user of vq->log is vhost-net. The concern is >>>> to add support for more devices (i.e. vhost-scsi or vsock) may reveals >>>> unknown issue in the vhost API. Add a WARNING. >>>> >>>> Suggested-by: Joao Martins

Re: [PATCH v3 9/9] vhost: add WARNING if log_num is more than limit

2025-04-15 Thread Michael S. Tsirkin
is > >> to add support for more devices (i.e. vhost-scsi or vsock) may reveals > >> unknown issue in the vhost API. Add a WARNING. > >> > >> Suggested-by: Joao Martins > >> Signed-off-by: Dongli Zhang > > > > > > Userspace can trigger

Re: [PATCH v3 9/9] vhost: add WARNING if log_num is more than limit

2025-04-14 Thread Dongli Zhang
gt; unknown issue in the vhost API. Add a WARNING. >> >> Suggested-by: Joao Martins >> Signed-off-by: Dongli Zhang > > > Userspace can trigger this I think, this is a problem since > people run with reboot on warn. I think it will be a severe kernel bug (page faul

Re: [PATCH v3 9/9] vhost: add WARNING if log_num is more than limit

2025-04-14 Thread Michael S. Tsirkin
On Wed, Apr 02, 2025 at 11:29:54PM -0700, Dongli Zhang wrote: > Since long time ago, the only user of vq->log is vhost-net. The concern is > to add support for more devices (i.e. vhost-scsi or vsock) may reveals > unknown issue in the vhost API. Add a WARNING. > > Suggeste

[PATCH v3 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-11 Thread Thomas Weißschuh
For tests without fixtures the variant argument is unused. This is intentional, prevent to compiler from complaining. Example warning: harness-selftest.c: In function 'wrapper_standalone_pass': ../kselftest_harness.h:181:52: error: unused parameter 'variant' [-Wer

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-10 Thread David Hildenbrand
On 09.04.25 12:31, David Hildenbrand wrote: On 09.04.25 12:25, Anshuman Khandual wrote: On 4/9/25 15:51, David Hildenbrand wrote: On 09.04.25 12:09, Anshuman Khandual wrote: On 4/9/25 15:27, David Hildenbrand wrote: On 09.04.25 11:50, Anshuman Khandual wrote: Following build warning

Re: [PATCH v2 03/32] selftests: harness: Ignore unused variant argument warning

2025-04-10 Thread Shuah Khan
On 4/7/25 00:52, Thomas Weißschuh wrote: For tests without fixtures the variant argument is unused. This is intentional, prevent to compiler from complaining. Include the warning in the change log for reference. Signed-off-by: Thomas Weißschuh --- tools/testing/selftests

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-09 Thread Anshuman Khandual
On 4/9/25 15:51, David Hildenbrand wrote: > On 09.04.25 12:09, Anshuman Khandual wrote: >> >> >> On 4/9/25 15:27, David Hildenbrand wrote: >>> On 09.04.25 11:50, Anshuman Khandual wrote: >>>> Following build warning comes up for cow test as 'tran

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-09 Thread David Hildenbrand
On 09.04.25 12:25, Anshuman Khandual wrote: On 4/9/25 15:51, David Hildenbrand wrote: On 09.04.25 12:09, Anshuman Khandual wrote: On 4/9/25 15:27, David Hildenbrand wrote: On 09.04.25 11:50, Anshuman Khandual wrote: Following build warning comes up for cow test as 'transferred'

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-09 Thread David Hildenbrand
On 09.04.25 12:09, Anshuman Khandual wrote: On 4/9/25 15:27, David Hildenbrand wrote: On 09.04.25 11:50, Anshuman Khandual wrote: Following build warning comes up for cow test as 'transferred' variable has not been initialized. Fix the warning via zero init for the variabl

Re: [PATCH] selftests/mm: Fix compiler -Wmaybe-uninitialized warning

2025-04-09 Thread Anshuman Khandual
On 4/9/25 15:27, David Hildenbrand wrote: > On 09.04.25 11:50, Anshuman Khandual wrote: >> Following build warning comes up for cow test as 'transferred' variable has >> not been initialized. Fix the warning via zero init for the variable. >> >>

  1   2   3   4   5   6   7   8   9   10   >