Hi Stafford,
On 4/18/25 1:17 PM, Stafford Horne wrote:
On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
[...]
Hi Sahil,
Sorry for delay in getting back on this.
No worries :)
I was working on getting this patches ready for upstreaming and noticed one
thing:
---------------------------------------------------------------------------------------
./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
---------------------------------------------------------------------------------------
WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq
<icegambi...@gmail.com>' != 'Signed-off-by: Sahil Siddiq <sahil...@proton.me>'
total: 0 errors, 1 warnings, 102 lines checked
As you can see above the scripts/checkpatch.pl is failing with the warning
about your email and signed-off-by not matching. You can see more about it
in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.
Ok, this makes sense. I configured git-send-email to use gmail because
protonmail does not work with git-send-email without a paid account.
How would you like to resolve this?
Is this a warning that cannot be ignored? I can:
1. submit the patch series with another email address that won't have issues
with git-send-email, or
2. submit the patch series using protonmail's web client (which might not be
the best option).
I would prefer not to use "icegambit91" in the signed-off-by tag.
What are your thoughts on this?
Thanks,
Sahil
