On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
> Hi Stafford,
>
> On 4/3/25 7:36 PM, Stafford Horne wrote:
> > [...]
> > I will just take this fix and apply it to the series (git fixup) rather than
> > take this patch as is. Also, as registers should be unsigned short, I think
> > we should change the type to that.
> >
> > I will fixup patches in place.
> >
>
> Sure thing. Will you be changing the register types as well in place with this
> fix? Let me know if I should send v2 of this patch so the changes are
> together.
Hi Sahil,
Sorry for delay in getting back on this. I was working on getting this patches
ready for upstreaming and noticed one thing:
---------------------------------------------------------------------------------------
./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
---------------------------------------------------------------------------------------
WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq
<icegambi...@gmail.com>' != 'Signed-off-by: Sahil Siddiq <sahil...@proton.me>'
total: 0 errors, 1 warnings, 102 lines checked
As you can see above the scripts/checkpatch.pl is failing with the warning
about your email and signed-off-by not matching. You can see more about it
in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.
How would you like to resolve this?
-Stafford
[0] https://docs.kernel.org/dev-tools/checkpatch.html
