Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-26 Thread Dominique Martinet
Eric Van Hensbergen wrote on Fri, Jul 26, 2013 : > It depends on the flags you use with 9p. If you mount with nodevmap it'll > treat them like normal files. Alternatively you can use synthetics from > fuse or even 9p file systems from Plan 9 port. Ok, thank you for the explanation. Now I need to

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-26 Thread Dominique Martinet
I think I need to stop sending mails before triple-checking things! So sorry for the multiple mails again. Dominique Martinet wrote on Thu, Jul 25, 2013 : > [rdma_cancelled] > There is one problem though - if the server handles the original request > before getting the flush, the receive buffer wi

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-25 Thread Dominique Martinet
Eric Van Hensbergen wrote on Thu, Jul 25, 2013 : > So, the cancel function should be used to flush any pending requests that > haven't actually been sent yet. Looking at the 9p RDMA code, it looks like > the thought was that this wasn't going to be possible. Regardless of > removing unsent reques

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-25 Thread David Miller
From: Andi Shyti Date: Thu, 25 Jul 2013 10:27:41 +0200 > I would prefer to NACK my patch, it messes up things more than > fixes. Your patch it already applied to my tree, so you must send me something which fixes things. > If we really want to get rid of this function we should > completely rev

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-25 Thread Andi Shyti
Hi, > To be more precise, there's a single call to c->trans_mode->cancelled in > net/9p/client.c, in p9_client_flush, which is called on subfunction returning > -ERESTARTSYS... which never happens as far as I could see. > > This will be useful once/if we start working on client recovery, though >

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-24 Thread Dominique Martinet
Hard morning, sorry for the double mail. Dominique Martinet wrote on Thu, Jul 25, 2013 : > Well, I do care - but I couldn't find where the trans->cancelled member > function was supposed to be called anyway... > So adding it to the struct and fixing the warning is well and fine, but > if it's stil

Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function

2013-07-24 Thread Dominique Martinet
Hi, David Miller wrote on Wed, Jul 24, 2013 : > From: Paul Bolle > Date: Thu, 25 Jul 2013 01:09:47 +0200 > > After this patch one might as well revert the rest of commit > > 80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It > > seems the entire cancelled callback stuff is n