Hard morning, sorry for the double mail. Dominique Martinet wrote on Thu, Jul 25, 2013 : > Well, I do care - but I couldn't find where the trans->cancelled member > function was supposed to be called anyway... > So adding it to the struct and fixing the warning is well and fine, but > if it's still never called in the end I don't see much point and there's > nothing to test.
To be more precise, there's a single call to c->trans_mode->cancelled in net/9p/client.c, in p9_client_flush, which is called on subfunction returning -ERESTARTSYS... which never happens as far as I could see. This will be useful once/if we start working on client recovery, though - so the function in itself definitely does interest me, and I guess that thinking about I would have preferred to have the hook added rather than the function removed. But there definitely is no hurry to add this cancelled function till then. Regards, -- Dominique Martinet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
