Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-22 Thread Jan Engelhardt
On Dec 22 2006 09:43, Robert P. J. Day wrote: > >that's the name as it *already* existed in kernel.h. however, since >no one was actually using it yet, it's a piece of cake to give it a >better name. either FIELD_SIZE or MEMBER_SIZE would work just fine. I 'd go for MEMBER_SIZE. (Compare the pr

Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-22 Thread Robert P. J. Day
On Fri, 22 Dec 2006, Christoph Hellwig wrote: > On Wed, Dec 20, 2006 at 04:46:51PM -0800, Andrew Morton wrote: > > On Sun, 17 Dec 2006 07:43:39 -0500 (EST) > > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > > > as with ARRAY_SIZE(), there are a number of places (mercifully, far > > > fewer)

Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-22 Thread Christoph Hellwig
On Wed, Dec 20, 2006 at 04:46:51PM -0800, Andrew Morton wrote: > On Sun, 17 Dec 2006 07:43:39 -0500 (EST) > "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > > as with ARRAY_SIZE(), there are a number of places (mercifully, far > > fewer) that recode what could be done with the FIELD_SIZEOF() ma

Re: [RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-20 Thread Andrew Morton
On Sun, 17 Dec 2006 07:43:39 -0500 (EST) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > as with ARRAY_SIZE(), there are a number of places (mercifully, far > fewer) that recode what could be done with the FIELD_SIZEOF() macro in > kernel.h. > Looks sane. > include/acpi/actbl.h

[RFC][PATCH] Rewrite unnecessary duplicated code to use FIELD_SIZEOF().

2006-12-17 Thread Robert P. J. Day
as with ARRAY_SIZE(), there are a number of places (mercifully, far fewer) that recode what could be done with the FIELD_SIZEOF() macro in kernel.h. i wrote a short script to handle that and this is the result (after a minor amount of hand tweaking): arch/m68k/kernel/signal.c