Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-23 Thread Shawn Guo
On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Add regmap based imx syscon driver. > This is usually used for access misc bits in registers which does not belong > to a specific module, for example, IOMUXC GPR and ANATOP. > With this driver, we provide a st

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-23 Thread Dong Aisheng
On Thu, Aug 23, 2012 at 07:06:47PM +0800, Mark Brown wrote: > On Thu, Aug 23, 2012 at 03:26:30PM +0800, Dong Aisheng wrote: > > On Thu, Aug 23, 2012 at 12:02:41AM +0800, Mark Brown wrote: > > > > It'd be good to provide a way of retrieving the regmap so that drivers > > > for subsystems with gener

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-23 Thread Mark Brown
On Thu, Aug 23, 2012 at 03:26:30PM +0800, Dong Aisheng wrote: > On Thu, Aug 23, 2012 at 12:02:41AM +0800, Mark Brown wrote: > > It'd be good to provide a way of retrieving the regmap so that drivers > > for subsystems with generic regmap code could use the framework features > > (regulator is one

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-23 Thread Dong Aisheng
On Thu, Aug 23, 2012 at 12:02:41AM +0800, Mark Brown wrote: > On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > > > From: Dong Aisheng > > > Add regmap based imx syscon driver. > > Nice to see more regmap-mmio usage! > > Reviwed-by: Mark Brown > > from a regmap point of view. >

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-23 Thread Dong Aisheng
On Thu, Aug 23, 2012 at 01:16:33PM +0800, Stephen Warren wrote: > On 08/22/2012 04:57 AM, Dong Aisheng wrote: > > On Wed, Aug 22, 2012 at 04:29:41PM +0800, Zhao Richard-B20223 wrote: > >> On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > >>> Add regmap based imx syscon driver. > >>> T

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Richard Zhao
On Wed, Aug 22, 2012 at 11:16:33PM -0600, Stephen Warren wrote: > On 08/22/2012 04:57 AM, Dong Aisheng wrote: > > On Wed, Aug 22, 2012 at 04:29:41PM +0800, Zhao Richard-B20223 wrote: > >> On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > >>> Add regmap based imx syscon driver. > >>> T

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Stephen Warren
On 08/22/2012 04:57 AM, Dong Aisheng wrote: > On Wed, Aug 22, 2012 at 04:29:41PM +0800, Zhao Richard-B20223 wrote: >> On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: >>> Add regmap based imx syscon driver. >>> This is usually used for access misc bits in registers which does not belon

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > Add regmap based imx syscon driver. Nice to see more regmap-mmio usage! Reviwed-by: Mark Brown from a regmap point of view. > +int imx_syscon_write(struct device_node *np, u32 reg, u32 val) > +{ > + str

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Dong Aisheng
On Wed, Aug 22, 2012 at 04:29:41PM +0800, Zhao Richard-B20223 wrote: > On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > > From: Dong Aisheng > > > > Add regmap based imx syscon driver. > > This is usually used for access misc bits in registers which does not belong > > to a specifi

Re: [PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Richard Zhao
On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Add regmap based imx syscon driver. > This is usually used for access misc bits in registers which does not belong > to a specific module, for example, IOMUXC GPR and ANATOP. > With this driver, we provide a st

[PATCH 1/7] mfd: add imx syscon driver based on regmap

2012-08-22 Thread Dong Aisheng
From: Dong Aisheng Add regmap based imx syscon driver. This is usually used for access misc bits in registers which does not belong to a specific module, for example, IOMUXC GPR and ANATOP. With this driver, we provide a standard API for client driver to call to access registers which are registe