On Thu, Aug 23, 2012 at 12:02:41AM +0800, Mark Brown wrote:
> On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote:
>
> > From: Dong Aisheng <dong.aish...@linaro.org>
>
> > Add regmap based imx syscon driver.
>
> Nice to see more regmap-mmio usage!
>
> Reviwed-by: Mark Brown <broo...@opensource.wolfsonmicro.com>
>
> from a regmap point of view.
>
Thanks
> > +int imx_syscon_write(struct device_node *np, u32 reg, u32 val)
> > +{
> > + struct device *dev;
> > + struct imx_syscon *syscon;
> > + int ret = 0;
> > +
> > + dev = driver_find_device(&imx_syscon_driver.driver, NULL, np,
> > + imx_syscon_match);
> > + if (!dev)
> > + return -EPROBE_DEFER;
> > +
> > + syscon = dev_get_drvdata(dev);
> > + ret = regmap_write(syscon->regmap, reg, val);
>
> It'd be good to provide a way of retrieving the regmap so that drivers
> for subsystems with generic regmap code could use the framework features
> (regulator is one example that I just mentioned in my other mail).
Do you mean something like:
regmap = syscon_regmap_dev_lookup(np, "fsl,anatop");
regmap_write(regmap, reg, val);
Then drivers can use generic regmap framework features rather than depend
on what imx-syscon implemented, is that correct?
Regards
Dong Aisheng
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
