On Wed, Aug 22, 2012 at 03:18:42PM +0800, Dong Aisheng wrote: > From: Dong Aisheng <dong.aish...@linaro.org>
> Add regmap based imx syscon driver.
Nice to see more regmap-mmio usage!
Reviwed-by: Mark Brown <broo...@opensource.wolfsonmicro.com>
from a regmap point of view.
> +int imx_syscon_write(struct device_node *np, u32 reg, u32 val)
> +{
> + struct device *dev;
> + struct imx_syscon *syscon;
> + int ret = 0;
> +
> + dev = driver_find_device(&imx_syscon_driver.driver, NULL, np,
> + imx_syscon_match);
> + if (!dev)
> + return -EPROBE_DEFER;
> +
> + syscon = dev_get_drvdata(dev);
> + ret = regmap_write(syscon->regmap, reg, val);
It'd be good to provide a way of retrieving the regmap so that drivers
for subsystems with generic regmap code could use the framework features
(regulator is one example that I just mentioned in my other mail).
signature.asc
Description: Digital signature
