Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-08 Thread Daniel Walker
On Sun, 2007-04-08 at 10:33 +0200, Thomas Gleixner wrote: > > Oh well, this is a leftover from the days where we tried to use TSC > despite of frequency changes. It still modifies the scale factor of the > tsc clocksource. > > I agree that it can be removed as we switch off TSC anyway in that ca

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-08 Thread Thomas Gleixner
On Sat, 2007-04-07 at 14:30 -0700, Daniel Walker wrote: > On Sat, 2007-04-07 at 22:50 +0200, Thomas Gleixner wrote: > > On Sat, 2007-04-07 at 10:43 -0700, Daniel Walker wrote: > > > Looks like this path , > > > > > > arch/i386/kernel/tsc.c: time_cpufreq_notifier(); <-- takes xtime_lock > > >

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Daniel Walker
On Sat, 2007-04-07 at 22:50 +0200, Thomas Gleixner wrote: > On Sat, 2007-04-07 at 10:43 -0700, Daniel Walker wrote: > > Looks like this path , > > > > arch/i386/kernel/tsc.c: time_cpufreq_notifier(); <-- takes xtime_lock > > mark_tsc_unstable(); > >

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Thomas Gleixner
On Sat, 2007-04-07 at 10:43 -0700, Daniel Walker wrote: > Looks like this path , > > arch/i386/kernel/tsc.c: time_cpufreq_notifier(); <-- takes xtime_lock >mark_tsc_unstable(); > clocksource_change_rating(&clocksource_tsc, 0); >

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Daniel Walker
On Sat, 2007-04-07 at 03:19 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Before this change the timekeeping code would poll the clocksource > > list every interrupt. This changes that so the clocksource list is > > only checked whe

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Andrew Morton
On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > Before this change the timekeeping code would poll the clocksource > list every interrupt. This changes that so the clocksource list is > only checked when there has been and update, and no longer checks > in interrupt c

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-06 Thread Daniel Walker
On Fri, 2007-04-06 at 18:21 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Boot tested on i386, compile tested on x86_64 .. However, I couldn't > > find a !GENERIC_TIME that compiled without this change so it's untested.. > > I'm sc

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-06 Thread Andrew Morton
On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > Boot tested on i386, compile tested on x86_64 .. However, I couldn't > find a !GENERIC_TIME that compiled without this change so it's untested.. I'm scratching my head over this statement. Do you mean that none of grep

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread john stultz
On Thu, 2007-04-05 at 14:36 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:25:19 -0700 > john stultz <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > > Before this change the timekeeping code would poll the clocksource > > > list every interrupt. T

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread john stultz
On Thu, 2007-04-05 at 14:29 -0700, Daniel Walker wrote: > On Thu, 2007-04-05 at 14:25 -0700, john stultz wrote: > > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > > Before this change the timekeeping code would poll the clocksource > > > list every interrupt. This changes that so the c

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread Andrew Morton
On Thu, 05 Apr 2007 14:25:19 -0700 john stultz <[EMAIL PROTECTED]> wrote: > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > Before this change the timekeeping code would poll the clocksource > > list every interrupt. This changes that so the clocksource list is > > only checked when th

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread Daniel Walker
On Thu, 2007-04-05 at 14:25 -0700, john stultz wrote: > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > Before this change the timekeeping code would poll the clocksource > > list every interrupt. This changes that so the clocksource list is > > only checked when there has been and upda

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread john stultz
On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > Before this change the timekeeping code would poll the clocksource > list every interrupt. This changes that so the clocksource list is > only checked when there has been and update, and no longer checks > in interrupt context. > > This als

[PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread Daniel Walker
Before this change the timekeeping code would poll the clocksource list every interrupt. This changes that so the clocksource list is only checked when there has been and update, and no longer checks in interrupt context. This also has a few small space and line cleanups. Boot tested on i386, com