On Thu, 2007-04-05 at 14:36 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:25:19 -0700 > john stultz <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > > Before this change the timekeeping code would poll the clocksource > > > list every interrupt. This changes that so the clocksource list is > > > only checked when there has been and update, and no longer checks > > > in interrupt context. > > > > > > This also has a few small space and line cleanups. > > > > > > Boot tested on i386, compile tested on x86_64 .. However, I couldn't > > > find a !GENERIC_TIME that compiled without this change so it's untested.. > > > > > > Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> > > > > Err.. I think you need to be holding a write on the xtime_lock (as is > > done before calling update_wall_time()) when changing the clocksource. > > The patch does add the appropriate locking to change_clocksource(), > doesn't it?
Yep. Sorry for the confusion, reading too hastily. > It looks like a good change to me - we avoid taking the kernel-wide > clocksource_lock every tick? Agreed. Acked-by: John Stultz <[EMAIL PROTECTED]> -john - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
