Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-12 Thread Andreas Dilger
David writes: > Alexander Viro writes: > > OK, how about wider testing? Theory: prune_dcache() goes through the > > list of immediately killable dentries and tries to free given amount. > > It has a "one warning" policy - it kills dentry if it sees it twice without > > lookup finding that dent

Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-12 Thread Alexander Viro
On Thu, 12 Apr 2001, Marcin Kowalski wrote: > Hi > > Regarding the patch > > I don't have experience with the linux kernel internals but could this patch > not lead to a run-loop condition as the only thing that can break our of the > for(;;) loop is the tmp==&dentry_unused statement.

Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-12 Thread Yoann Vandoorselaere
Marcin Kowalski <[EMAIL PROTECTED]> writes: > Hi > > Regarding the patch > > I don't have experience with the linux kernel internals but could this patch > not lead to a run-loop condition as the only thing that can break our of the > for(;;) loop is the tmp==&dentry_unused statement. So

Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-12 Thread Marcin Kowalski
Hi Regarding the patch I don't have experience with the linux kernel internals but could this patch not lead to a run-loop condition as the only thing that can break our of the for(;;) loop is the tmp==&dentry_unused statement. So if the required number of dentries does not exist and thi

Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-12 Thread David S. Miller
Alexander Viro writes: > OK, how about wider testing? Theory: prune_dcache() goes through the > list of immediately killable dentries and tries to free given amount. > It has a "one warning" policy - it kills dentry if it sees it twice without > lookup finding that dentry in the interval. Unf

[CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

2001-04-11 Thread Alexander Viro
On Thu, 12 Apr 2001, Jeff Garzik wrote: > Alexander Viro wrote: > > We _have_ VM pressure there. However, such loads had never been used, so > > there's no wonder that system gets unbalanced under them. > > > > I suspect that simple replacement of goto next; with continue; in the > > fs/dcache