Re: [PATCH 5/6] dma: mic_x100_dma: no need to check return value of debugfs_create functions

2019-06-12 Thread Sudeep Dutt
On Wed, 2019-06-12 at 14:25 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > Thanks Greg. Reviewed-by: Sudeep

Re: [PATCH] mic: no need to check return value of debugfs_create functions

2019-06-12 Thread Sudeep Dutt
On Tue, 2019-06-11 at 20:43 +0200, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > Thanks Greg. Reviewed-by: Sudeep

Re: scif_insert_vma()

2019-03-17 Thread Sudeep Dutt
llocation during the open(..) callback succeeds or fails. The close(..) callback cleans up the data structures from the mmap(..) or open(..) callbacks if any. Thanks, Sudeep Dutt

Re: [PATCH] mic: vop: Fix broken virtqueues

2019-01-30 Thread Sudeep Dutt
_virtqueue() was added way back in commit > 2a2d1382fe9dcc ("virtio: Add improved queue allocation API") in order to > address mic's usecase, according to the commit message. > Thank you for fixing this up Vincent. Reviewed-by: Sudeep Dutt > Signed-off-by: Vincent

Re: [PATCH v2] misc: mic: fix a DMA pool free failure

2019-01-02 Thread Sudeep Dutt
lt, dma_pool_free() will not succeed. > > To avoid the above issue, this patch introduces a new data structure, i.e., > scif_cb_arg, to store the arguments required by the call back function. A > variable 'cb_arg' is allocated in _scif_prog_signal() to pass the > arguments. 'cb_ar

Re: [PATCH] misc: mic: fix a DMA pool free failure

2018-11-04 Thread Sudeep Dutt
+ cb_arg->ep = ep; > tx->callback = scif_prog_signal_cb; > - tx->callback_param = status; > + tx->callback_param = cb_arg; > } cb_arg should be freed if there is a dma_submit_error(..) below in the dma_fail path. Wenwen, can you please fix these up and resend the patch? Thanks, Sudeep Dutt

Re: rdma-core doesn't install driver.h, broke libibscif

2018-10-18 Thread Sudeep Dutt
ly. > > Does this mean we can kill the kernel scif code as well? The MIC COSM drivers are using the kernel SCIF code. These drivers have been upstream since 2015 and we are not sure who is using them. Our preference will be to keep these drivers in the kernel for now. Thanks, Sudeep Dutt

Re: [PATCH] misc: mic: SCIF Fix scif_get_new_port() error handling

2018-08-08 Thread Sudeep Dutt
43c9a7 ("misc: mic: SCIF open close bind and listen APIs") > Signed-off-by: Dan Carpenter > --- > I have not tested this patch. Please review carefully. Thanks for the patch Dan. Reviewed-by: Sudeep Dutt > > diff --git a/drivers/misc/mic/scif/scif_api.c > b/drivers

Re: ERROR: "vring_del_virtqueue" [drivers/misc/mic/vop/vop.ko] undefined!

2016-04-30 Thread Sudeep Dutt
tps://lkml.org/lkml/2016/4/5/7 Greg, can you please please apply the patch? Thanks, Sudeep Dutt > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: c3b46c73264b03000d1e18b22f5caf63332547c9 > > commit: 8810d

Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error

2016-04-04 Thread Sudeep Dutt
On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote: > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote: > > Fixes randconfig build error reported at > > https://lkml.org/lkml/2016/4/3/135 by ensuring that > > the VOP driver selects VIRTIO. > > &g

[PATCH char-misc-linus] misc: mic: Fix randconfig build error

2016-04-04 Thread Sudeep Dutt
Fixes randconfig build error reported at https://lkml.org/lkml/2016/4/3/135 by ensuring that the VOP driver selects VIRTIO. Reported-by: Fengguang Wu Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH char-misc-testing v2 2/8] misc: mic: Remove MIC X100 card virtio functionality

2016-02-08 Thread Sudeep Dutt
This patch deletes the virtio functionality from the MIC X100 card driver. A subsequent patch will re-enable this functionality by consolidating the hardware independent logic in a new Virtio over PCIe (VOP) driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic

[PATCH char-misc-testing v2 1/8] misc: mic: Remove MIC X100 host virtio functionality

2016-02-08 Thread Sudeep Dutt
This patch deletes the virtio functionality from the MIC X100 host driver. A subsequent patch will re-enable this functionality by consolidating the hardware independent logic in a new Virtio over PCIe (VOP) driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic

[PATCH char-misc-testing v2 7/8] misc: mic: Enable VOP debugfs and driver build

2016-02-08 Thread Sudeep Dutt
This patch moves the virtio specific debugfs hooks previously in mic_debugfs.c in the MIC host driver into the VOP driver. The Kconfig/Makefile is also updated to allow building the VOP driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 20

[PATCH char-misc-testing v2 5/8] misc: mic: Enable VOP host side functionality

2016-02-08 Thread Sudeep Dutt
from being moved into a separate driver the functionality is essentially unchanged. See the above mentioned commit for a description of this functionality. Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/vop/vop_vringh.c | 1164 +++

[PATCH char-misc-testing v2 6/8] misc: mic: Enable VOP card side functionality

2016-02-08 Thread Sudeep Dutt
c/mic/card/mic_virtio.c. Apart from being moved into a separate driver the functionality is essentially unchanged. See the above mentioned commit for a description of this functionality. Signed-off-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/vop/vop_ma

[PATCH char-misc-testing v2 3/8] misc: mic: MIC VOP Bus

2016-02-08 Thread Sudeep Dutt
: Sudeep Dutt --- drivers/misc/mic/Kconfig | 17 drivers/misc/mic/bus/Makefile | 1 + drivers/misc/mic/bus/vop_bus.h | 140 drivers/misc/mic/bus/vop_bus.c | 203 + 4 files changed, 361 insertions(+) create mode

[PATCH char-misc-testing v2 4/8] misc: mic: Add data structures for the VOP driver

2016-02-08 Thread Sudeep Dutt
This patch adds VOP driver data structures used in subsequent patches. These data structures are refactored from similar data structures used in the virtio parts of previous MIC host and card drivers. Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/vop/vop_main.h

[PATCH char-misc-testing v2 0/8] Enable Virtio Over PCIe (VOP) driver

2016-02-08 Thread Sudeep Dutt
Enables VOP debugfs and driver build 8) Implements the MIC host and card driver changes to enable VOP Ashutosh Dixit (1): misc: mic: Enable VOP card side functionality Sudeep Dutt (7): misc: mic: Remove MIC X100 host virtio functionality misc: mic: Remove MIC X100 card virtio functionality

[PATCH char-misc-testing v2 8/8] misc: mic: MIC host and card driver changes to enable VOP

2016-02-08 Thread Sudeep Dutt
Signed-off-by: Sudeep Dutt --- Documentation/mic/mic_overview.txt | 54 drivers/misc/mic/Kconfig | 7 ++- drivers/misc/mic/card/mic_device.h | 3 + drivers/misc/mic/host/mic_device.h | 3 + Documentation/mic/mpssd/mpssd.c| 2 +- drivers/misc/mic/card

Re: [PATCH char-misc-next 3/8] misc: mic: MIC VOP Bus

2016-02-08 Thread Sudeep Dutt
On Sun, 2016-02-07 at 22:57 -0800, Greg Kroah-Hartman wrote: > On Mon, Feb 01, 2016 at 08:23:40PM -0800, Sudeep Dutt wrote: > > The Virtio Over PCIe (VOP) bus abstracts the low level hardware > > details like interrupts and mapping remote memory so that the same VOP > > dr

[PATCH char-misc-next 0/8] Enable Virtio Over PCIe (VOP) driver

2016-02-01 Thread Sudeep Dutt
ality 7) Enables VOP debugfs and driver build 8) Implements the MIC host and card driver changes to enable VOP Ashutosh Dixit (1): misc: mic: Enable VOP card side functionality Sudeep Dutt (7): misc: mic: Remove MIC X100 host virtio functionality misc: mic: Remove MIC X100 card virtio funct

[PATCH char-misc-next 1/8] misc: mic: Remove MIC X100 host virtio functionality

2016-02-01 Thread Sudeep Dutt
This patch deletes the virtio functionality from the MIC X100 host driver. A subsequent patch will re-enable this functionality by consolidating the hardware independent logic in a new Virtio over PCIe (VOP) driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic

[PATCH char-misc-next 3/8] misc: mic: MIC VOP Bus

2016-02-01 Thread Sudeep Dutt
: Sudeep Dutt --- drivers/misc/mic/Kconfig | 17 drivers/misc/mic/bus/Makefile | 1 + drivers/misc/mic/bus/vop_bus.h | 142 drivers/misc/mic/bus/vop_bus.c | 204 + 4 files changed, 364 insertions(+) create mode

[PATCH char-misc-next 2/8] misc: mic: Remove MIC X100 card virtio functionality

2016-02-01 Thread Sudeep Dutt
This patch deletes the virtio functionality from the MIC X100 card driver. A subsequent patch will re-enable this functionality by consolidating the hardware independent logic in a new Virtio over PCIe (VOP) driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic

[PATCH char-misc-next 8/8] misc: mic: MIC host and card driver changes to enable VOP

2016-02-01 Thread Sudeep Dutt
Signed-off-by: Sudeep Dutt --- Documentation/mic/mic_overview.txt | 54 +--- drivers/misc/mic/Kconfig | 7 ++- drivers/misc/mic/card/mic_device.h | 3 + drivers/misc/mic/host/mic_device.h | 3 + Documentation/mic/mpssd/mpssd.c| 2 +- drivers/misc/mic/card

[PATCH char-misc-next 6/8] misc: mic: Enable VOP card side functionality

2016-02-01 Thread Sudeep Dutt
c/mic/card/mic_virtio.c. Apart from being moved into a separate driver the functionality is essentially unchanged. See the above mentioned commit for a description of this functionality. Signed-off-by: Sudeep Dutt Signed-off-by: Ashutosh Dixit --- drivers/misc/mic/vop/vop_ma

[PATCH char-misc-next 5/8] misc: mic: Enable VOP host side functionality

2016-02-01 Thread Sudeep Dutt
from being moved into a separate driver the functionality is essentially unchanged. See the above mentioned commit for a description of this functionality. Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/vop/vop_vringh.c | 1164 +++

[PATCH char-misc-next 7/8] misc: mic: Enable VOP debugfs and driver build

2016-02-01 Thread Sudeep Dutt
This patch moves the virtio specific debugfs hooks previously in mic_debugfs.c in the MIC host driver into the VOP driver. The Kconfig/Makefile is also updated to allow building the VOP driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 20

[PATCH char-misc-next 4/8] misc: mic: Add data structures for the VOP driver

2016-02-01 Thread Sudeep Dutt
This patch adds VOP driver data structures used in subsequent patches. These data structures are refactored from similar data structures used in the virtio parts of previous MIC host and card drivers. Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/vop/vop_main.h

Re: [PATCH] misc: mic: fix incorrect use of error codes in SCIF DMA driver

2015-12-11 Thread Sudeep Dutt
On Fri, 2015-12-11 at 20:09 -0600, Eric Biggers wrote: > The error code passed to ERR_PTR() always should be negated. Also, the > return value of scif_add_mmu_notifier() was never checked. > Thanks for the patch Eric. Reviewed-by: Sudeep Dutt > Signed-off-by: Eric Biggers >

Re: [PATCH char-misc-next 4/4] misc: mic: use common error path

2015-12-11 Thread Sudeep Dutt
command_line() fails. > Thanks for this patch series Sudip. All 4 patches look good. Reviewed-by: Sudeep Dutt > Signed-off-by: Sudip Mukherjee > --- > drivers/misc/mic/host/mic_x100.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/driv

Re: [PATCH 1/3] misc:scif: do not define list_entry_next

2015-11-18 Thread Sudeep Dutt
On Wed, 2015-11-18 at 21:10 +0900, Sergey Senozhatsky wrote: > Cosmetic. > > Do not define list_entry_next() and use list_next_entry() > from list.h. > Hi Sergey, A similar patch was posted @ https://lkml.org/lkml/2015/11/16/328 Regards, Sudeep Dutt > Signed-off-by:

Re: [PATCH 1/3] misc: mic/scif: use list_next_entry instead of list_entry_next

2015-11-16 Thread Sudeep Dutt
On Mon, 2015-11-16 at 21:46 +0800, Geliang Tang wrote: > list_next_entry has been defined in list.h, so I replace list_entry_next > with it. > Thanks for the cleanup. Reviewed-by: Sudeep Dutt > Signed-off-by: Geliang Tang > --- > drivers/misc/mic/sc

Re: [patch 2/2] misc: mic/scif: fix wrap around tests

2015-10-13 Thread Sudeep Dutt
eturn -EINVAL; > > might_sleep(); > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t > len, off_t offset, > if ((map_flags & SCIF_MAP_FIXED) && > ((ALIGN(offset, PAGE_SIZE) != offset) || > (offset

[PATCH char-misc-next v2 1/1] MAINTAINERS: Add maintainership for MIC drivers

2015-10-13 Thread Sudeep Dutt
Add entry for MIC drivers to the MAINTAINERS file Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- MAINTAINERS | 16 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe5bbfe..994a7ae 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH char-misc-next 1/1] MAINTAINERS: Add maintainership for MIC drivers

2015-10-13 Thread Sudeep Dutt
Add entry for MIC drivers to the MAINTAINERS file Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fe5bbfe..840993b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5575,6

Re: [PATCH] misc: mic: fix memory leak

2015-10-13 Thread Sudeep Dutt
On Tue, 2015-10-13 at 22:46 +0530, Sudip Mukherjee wrote: > On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote: > > > > + struct scif_hw_dev *sdev = scifdev->sdev; > > > + > > &

Re: [PATCH char-misc-next v3] misc: mic: fix memory leak

2015-10-13 Thread Sudeep Dutt
we will have a leak. > Lets deinitialize and release the resources connected to p2p_ij. > Reviewed-by: Sudeep Dutt Thanks again for the fix. > Signed-off-by: Sudip Mukherjee > --- > > v3: added unmapping the aperture > v2: missed making the function as static > > d

Re: [PATCH] misc: mic: fix memory leak

2015-10-13 Thread Sudeep Dutt
L); Can you please resubmit this patch with the change above? Also you should mention [PATCH char-misc-next] in the next revision. Thanks for the fix! Sudeep Dutt > + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_MMIO]); > + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_APER]); > + kfr

Re: [patch] misc: mic/scif: re-take a lock on error path

2015-10-13 Thread Sudeep Dutt
On Tue, 2015-10-13 at 15:52 +0300, Dan Carpenter wrote: > The caller expects that we take this lock again before returning > otherwise it you get double unlocks and races. > Reviewed-by: Sudeep Dutt Thanks for the fix! > Fixes: ba612aa8b487 ('misc: mic: SCIF memory

Re: [patch 1/2] misc: mic/scif: fix error code in scif_create_remote_lookup()

2015-10-11 Thread Sudeep Dutt
On Fri, 2015-10-09 at 09:41 +0300, Dan Carpenter wrote: > We should be returning -ENOMEM here instead of success. > Reviewed-by: Sudeep Dutt Thanks for the fix! > Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration') > Signed-off-by: Dan Carpen

Re: [patch 2/2] misc: mic/scif: fix wrap around tests

2015-10-11 Thread Sudeep Dutt
+ (len > LONG_MAX - offset))) > return -EINVAL; > > might_sleep(); > @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t > len, off_t offset, > if ((map_flags & SCIF_MAP_FIXED) && > ((ALIGN(off

Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT

2015-10-06 Thread Sudeep Dutt
On Tue, 2015-10-06 at 09:33 +0100, gre...@linuxfoundation.org wrote: > On Tue, Oct 06, 2015 at 01:05:27AM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote: > > > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > >

Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT

2015-10-06 Thread Sudeep Dutt
On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote: > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote: > > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundatio

Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT

2015-10-05 Thread Sudeep Dutt
On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote: > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundation.org wrote: > > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote: > > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: &g

Re: [PATCH char-misc-next v2 04/22] iommu: Allow iova to be used without requiring IOMMU_SUPPORT

2015-10-05 Thread Sudeep Dutt
On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote: > On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote: > > From: Sudeep Dutt > > > > iova is a library which can be built without IOMMU_SUPPORT > > > > Signed-off-by: Sudeep Dutt > > The firs

[PATCH char-misc-testing 1/1] Revert "iommu: Allow iova to be used without requiring IOMMU_SUPPORT"

2015-10-05 Thread Sudeep Dutt
4.3-rc4. The correct long term solution is to move the iova library from drivers/iommu into lib/iova which will be done in a future patch. Cc: David Woodhouse Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/iommu/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH char-misc-next 1/1] misc: mic: Fix SCIF build failure with IOMMU_SUPPORT disabled

2015-10-04 Thread Sudeep Dutt
SCIF depends on IOVA which requires IOMMU_SUPPORT to be enabled. The long term fix is to move IOVA from drivers/iommu to lib/ but this current patch should fix the reported issue. Reported-by: Fengguang Wu Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 2

Re: [PATCH char-misc-next 11/19] dma: Add support to program MIC x100 status descriptiors

2015-08-21 Thread Sudeep Dutt
On Fri, 2015-08-21 at 13:59 +0530, Vinod Koul wrote: > On Thu, Aug 20, 2015 at 10:30:50AM -0700, Sudeep Dutt wrote: > > On Thu, 2015-08-20 at 10:50 +0530, Vinod Koul wrote: > > > On Mon, Jul 27, 2015 at 04:58:17PM -0700, As

Re: [PATCH char-misc-next 11/19] dma: Add support to program MIC x100 status descriptiors

2015-08-20 Thread Sudeep Dutt
MA descriptors prior to the status descriptor. The DMA engine API does not allow drivers to pass a 8 byte value. We are allowed to pass a source physical address but we cannot determine the source value within the DMA driver using that information specifically with the IOMMU enabled. We have added this workar

Re: [PATCH char-misc-next 10/19] lib: convert iova.c into a library

2015-07-28 Thread Sudeep Dutt
> > > > > Cc: Joerg Roedel > > > > Reviewed-by: Anil S Keshavamurthy > > > > > > > > Reviewed-by: Sudeep Dutt > > > > Signed-off-by: Harish Chegondi > > > > > > Where is this going to be used outside of the IOMMU wo

[PATCH char-misc-next 2/2] misc: mic: Fix reported static checker warning

2015-06-09 Thread Sudeep Dutt
Delete unnecessary prints resulting in an "spdev could be null" warning from a static checker in scif_peer_remove(..). Reported-by: Dan Carpenter Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_main.c | 4 1 file changed, 4 deletions(-) di

[PATCH char-misc-next 0/2] misc: mic: bug fixes

2015-06-09 Thread Sudeep Dutt
This patch series fixes reported issues including a randconfig build error and a warning from a static checker. Sudeep Dutt (2): misc: mic: Fix randconfig build error by including errno.h misc: mic: Fix reported static checker warning drivers/misc/mic/scif/scif_main.c | 4 drivers/misc

[PATCH char-misc-next 1/2] misc: mic: Fix randconfig build error by including errno.h

2015-06-09 Thread Sudeep Dutt
This issue was reported @ https://lkml.org/lkml/2015/6/9/731 Reported-by: Jim Davis Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mic/scif/scif_rb.c b/drivers/misc/mic/scif/scif_rb.c

Re: randconfig build error with next-20150609, in drivers/misc/mic/scif/scif_rb.c

2015-06-09 Thread Sudeep Dutt
gt;return -ENOMEM; >^ > drivers/misc/mic/scif/scif_rb.c:115:11: note: each undeclared > identifier is reported only once for each function it appears in Thanks for the report Jim. I will post a patch with the fix. Sudeep Dutt -- To unsubscribe from this list: send the

Re: [PATCH char-misc-next v4 00/13] misc: mic: SCIF driver

2015-04-29 Thread Sudeep Dutt
On Wed, 2015-04-29 at 13:27 +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 28, 2015 at 01:45:12PM -0700, Sudeep Dutt wrote: > > On Mon, 2015-03-30 at 18:36 -0700, Sudeep Dutt wrote: > > > ChangeLog: > > > = > > > > > > v3 => v4: > > &g

[PATCH char-misc-next v4 02/13] misc: mic: SCIF ring buffer infrastructure

2015-04-29 Thread Sudeep Dutt
endpoint has a receive queue for messages from its peer. This pair of receive queues is referred to as a SCIF queue pair. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rb.h | 100 drivers/misc/mic/scif/scif_rb.c

[PATCH char-misc-next v4 03/13] misc: mic: SCIF Hardware Bus

2015-04-29 Thread Sudeep Dutt
by the host and card drivers on the SCIF hardware bus resulting in probing the SCIF driver. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig| 17 drivers/misc/mic/Makefile | 2 +- drivers/misc/mic/bus/Makefile

[PATCH char-misc-next v4 04/13] misc: mic: SCIF Peer Bus

2015-04-29 Thread Sudeep Dutt
client drivers (e.g. netdev over SCIF) Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_peer_bus.h | 65 ++ drivers/misc/mic/scif/scif_peer_bus.c | 124 ++ 2 files changed, 189

[PATCH char-misc-next v4 06/13] misc: mic: SCIF module initialization

2015-04-29 Thread Sudeep Dutt
Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_main.h| 252 ++ drivers/misc/mic/scif/scif_map.h | 113 ++ drivers/misc/mic/scif/scif_debugfs.c | 85 drivers/misc/mic/scif/scif_main.c| 391 +++ 4 files

[PATCH char-misc-next v4 05/13] misc: mic: Common MIC header file changes in preparation for SCIF

2015-04-29 Thread Sudeep Dutt
Update mic_bootparam and define the maximum number of DMA channels Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/common/mic_dev.h | 3 +++ include/uapi/linux/mic_common.h | 12 2 files changed, 15 insertions(+) diff --git

[PATCH char-misc-next v4 10/13] misc: mic: SCIF messaging and node enumeration APIs

2015-04-29 Thread Sudeep Dutt
be submitted in a future patch series is recommended for larger transfers. The node enumeration API enables a user to query for the number of nodes online in the SCIF network and their node ids. Reviewed-by: Ashutosh Dixit Signed-off-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/s

[PATCH char-misc-next v4 09/13] misc: mic: SCIF connections APIs i.e. accept and connect

2015-04-29 Thread Sudeep Dutt
asynchronously or synchronously. Thanks to Johnnie S Peters for authoring parts of this patch during early bring up of the SCIF driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt Signed-off-by: Nikhil Rao --- drivers/misc/mic/scif/scif_epd.h| 8 + drivers/misc/mic/scif/scif_api.c

[PATCH char-misc-next v4 12/13] misc: mic: MIC card driver specific changes to enable SCIF

2015-04-29 Thread Sudeep Dutt
MIC card driver specific changes to enable SCIF. This patch implements the SCIF hardware bus operations and registers a SCIF device on the SCIF hardware bus. Reviewed-by: Nikhil Rao Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 2

[PATCH char-misc-next v4 07/13] misc: mic: SCIF node queue pair setup management

2015-04-29 Thread Sudeep Dutt
Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_nodeqp.h | 173 + drivers/misc/mic/scif/scif_nm.c | 184 + drivers/misc/mic/scif/scif_nodeqp.c | 1264 +++ 3 files changed, 1621 insertions(+) create mode

[PATCH char-misc-next v4 11/13] misc: mic: MIC host driver specific changes to enable SCIF

2015-04-29 Thread Sudeep Dutt
MIC host driver specific changes to enable SCIF. This patch implements the SCIF hardware bus operations and registers a SCIF device on the SCIF hardware bus. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig| 2

[PATCH char-misc-next v4 13/13] misc: mic: add support for loading/unloading SCIF driver

2015-04-29 Thread Sudeep Dutt
modprobe SCIF driver upon start and remove it upon unload Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- Documentation/mic/mpssd/mpss | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/Documentation/mic/mpssd/mpss

[PATCH char-misc-next v4 00/13] misc: mic: SCIF driver

2015-04-29 Thread Sudeep Dutt
port for loading/unloading SCIF driver Nikhil Rao (1): misc: mic: SCIF connections APIs i.e. accept and connect Sudeep Dutt (12): misc: mic: SCIF header file and IOCTL interface misc: mic: SCIF ring buffer infrastructure misc: mic: SCIF Hardware Bus misc: mic: SCIF Peer Bus misc: m

[PATCH char-misc-next v4 08/13] misc: mic: SCIF open close bind and listen APIs

2015-04-29 Thread Sudeep Dutt
SCIF character device file operations and kernel APIs for opening and closing a user and kernel mode SCIF endpoint. This patch also enables binding to a SCIF port and listening for incoming SCIF connections. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt

[PATCH char-misc-next v4 01/13] misc: mic: SCIF header file and IOCTL interface

2015-04-29 Thread Sudeep Dutt
: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- Documentation/mic/mic_overview.txt | 28 +- Documentation/mic/scif_overview.txt | 98 include/uapi/linux/Kbuild | 1 + include/linux/scif.h| 993 include/uapi/linux/scif_ioctl.h

Re: [PATCH char-misc-next v4 00/13] misc: mic: SCIF driver

2015-04-28 Thread Sudeep Dutt
On Mon, 2015-03-30 at 18:36 -0700, Sudeep Dutt wrote: > ChangeLog: > = > > v3 => v4: > a) Delete unused IOCTL definitions and IOCTL interface fixes as per > feedback from Greg Kroah-Hartman > b) Couple of tiny bug fixes since v3 > > v2 => v3 @ https:

Re: [PATCH char-misc-next v4 08/13] misc: mic: SCIF open close bind and listen APIs

2015-03-31 Thread Sudeep Dutt
On Tue, 2015-03-31 at 10:39 +0200, Paul Bolle wrote: > On Mon, 2015-03-30 at 18:36 -0700, Sudeep Dutt wrote: > > --- a/drivers/misc/mic/Kconfig > > +++ b/drivers/misc/mic/Kconfig > > +comment "SCIF Driver" > > + > > +config SCIF > > + tristate &qu

[PATCH char-misc-next v4 02/13] misc: mic: SCIF ring buffer infrastructure

2015-03-30 Thread Sudeep Dutt
endpoint has a receive queue for messages from its peer. This pair of receive queues is referred to as a SCIF queue pair. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rb.h | 100 drivers/misc/mic/scif/scif_rb.c

[PATCH char-misc-next v4 01/13] misc: mic: SCIF header file and IOCTL interface

2015-03-30 Thread Sudeep Dutt
: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- Documentation/mic/mic_overview.txt | 28 +- Documentation/mic/scif_overview.txt | 98 include/uapi/linux/Kbuild | 1 + include/linux/scif.h| 993 include/uapi/linux/scif_ioctl.h

[PATCH char-misc-next v4 03/13] misc: mic: SCIF Hardware Bus

2015-03-30 Thread Sudeep Dutt
by the host and card drivers on the SCIF hardware bus resulting in probing the SCIF driver. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig| 17 drivers/misc/mic/Makefile | 2 +- drivers/misc/mic/bus/Makefile

[PATCH char-misc-next v4 04/13] misc: mic: SCIF Peer Bus

2015-03-30 Thread Sudeep Dutt
client drivers (e.g. netdev over SCIF) Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_peer_bus.h | 65 ++ drivers/misc/mic/scif/scif_peer_bus.c | 124 ++ 2 files changed, 189

[PATCH char-misc-next v4 07/13] misc: mic: SCIF node queue pair setup management

2015-03-30 Thread Sudeep Dutt
Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_nodeqp.h | 173 + drivers/misc/mic/scif/scif_nm.c | 184 + drivers/misc/mic/scif/scif_nodeqp.c | 1264 +++ 3 files changed, 1621 insertions(+) create mode

[PATCH char-misc-next v4 09/13] misc: mic: SCIF connections APIs i.e. accept and connect

2015-03-30 Thread Sudeep Dutt
asynchronously or synchronously. Thanks to Johnnie S Peters for authoring parts of this patch during early bring up of the SCIF driver. Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt Signed-off-by: Nikhil Rao --- drivers/misc/mic/scif/scif_epd.h| 8 + drivers/misc/mic/scif/scif_api.c

[PATCH char-misc-next v4 08/13] misc: mic: SCIF open close bind and listen APIs

2015-03-30 Thread Sudeep Dutt
SCIF character device file operations and kernel APIs for opening and closing a user and kernel mode SCIF endpoint. This patch also enables binding to a SCIF port and listening for incoming SCIF connections. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt

[PATCH char-misc-next v4 12/13] misc: mic: MIC card driver specific changes to enable SCIF

2015-03-30 Thread Sudeep Dutt
MIC card driver specific changes to enable SCIF. This patch implements the SCIF hardware bus operations and registers a SCIF device on the SCIF hardware bus. Reviewed-by: Nikhil Rao Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 2

[PATCH char-misc-next v4 05/13] misc: mic: Common MIC header file changes in preparation for SCIF

2015-03-30 Thread Sudeep Dutt
Update mic_bootparam and define the maximum number of DMA channels Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/common/mic_dev.h | 3 +++ include/uapi/linux/mic_common.h | 12 2 files changed, 15 insertions(+) diff --git

[PATCH char-misc-next v4 10/13] misc: mic: SCIF messaging and node enumeration APIs

2015-03-30 Thread Sudeep Dutt
be submitted in a future patch series is recommended for larger transfers. The node enumeration API enables a user to query for the number of nodes online in the SCIF network and their node ids. Reviewed-by: Ashutosh Dixit Signed-off-by: Nikhil Rao Signed-off-by: Sudeep Dutt --- drivers/misc/mic/s

[PATCH char-misc-next v4 13/13] misc: mic: add support for loading/unloading SCIF driver

2015-03-30 Thread Sudeep Dutt
modprobe SCIF driver upon start and remove it upon unload Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- Documentation/mic/mpssd/mpss | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/Documentation/mic/mpssd/mpss

[PATCH char-misc-next v4 11/13] misc: mic: MIC host driver specific changes to enable SCIF

2015-03-30 Thread Sudeep Dutt
MIC host driver specific changes to enable SCIF. This patch implements the SCIF hardware bus operations and registers a SCIF device on the SCIF hardware bus. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig| 2

[PATCH char-misc-next v4 06/13] misc: mic: SCIF module initialization

2015-03-30 Thread Sudeep Dutt
Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_main.h| 252 ++ drivers/misc/mic/scif/scif_map.h | 113 ++ drivers/misc/mic/scif/scif_debugfs.c | 85 drivers/misc/mic/scif/scif_main.c| 391 +++ 4 files

[PATCH char-misc-next v4 00/13] misc: mic: SCIF driver

2015-03-30 Thread Sudeep Dutt
port for loading/unloading SCIF driver Nikhil Rao (1): misc: mic: SCIF connections APIs i.e. accept and connect Sudeep Dutt (12): misc: mic: SCIF header file and IOCTL interface misc: mic: SCIF ring buffer infrastructure misc: mic: SCIF Hardware Bus misc: mic: SCIF Peer Bus misc: m

Re: [PATCH char-misc-next v3 01/13] misc: mic: SCIF header file and IOCTL interface

2015-03-26 Thread Sudeep Dutt
On Wed, 2015-03-25 at 12:04 +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 26, 2015 at 04:32:42PM -0800, Sudeep Dutt wrote: > > This patch introduces the SCIF documentation in the header file > > and describes the IOCTL interface for user mode. mic_overview.txt > > is updated

Re: [PATCH char-misc-next v3 00/13] misc: mic: SCIF driver

2015-03-23 Thread Sudeep Dutt
On Mon, 2015-03-09 at 09:13 -0700, Sudeep Dutt wrote: > On Mon, 2015-02-23 at 16:45 -0800, Sudeep Dutt wrote: > > On Mon, 2015-01-26 at 16:32 -0800, Sudeep Dutt wrote: > > > ChangeLog: > > > = > > > > > > v2 => v3: > > > a) Forma

Re: [PATCH char-misc-next v3 00/13] misc: mic: SCIF driver

2015-03-09 Thread Sudeep Dutt
On Mon, 2015-02-23 at 16:45 -0800, Sudeep Dutt wrote: > On Mon, 2015-01-26 at 16:32 -0800, Sudeep Dutt wrote: > > ChangeLog: > > = > > > > v2 => v3: > > a) Formatting fixes for SCIF header file documentation, data type fixes > >for SCIF

Re: [PATCH char-misc-next v3 00/13] misc: mic: SCIF driver

2015-02-23 Thread Sudeep Dutt
On Mon, 2015-01-26 at 16:32 -0800, Sudeep Dutt wrote: > ChangeLog: > = > > v2 => v3: > a) Formatting fixes for SCIF header file documentation, data type fixes >for SCIF IOCTL interface and added SCIF user space documentation in >scif_overview.txt as per

Re: [PATCH] misc: mic: fixup return type of wait_for_completion_timeout

2015-02-09 Thread Sudeep Dutt
On Mon, 2015-02-09 at 14:09 -0500, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. The > rc variable is renamed timeout to reflect its use and the type adjusted to > unsigned long. > Acked-by: Sudeep Dutt Thanks for the patch! >

[PATCH char-misc-next v3 12/13] misc: mic: MIC card driver specific changes to enable SCIF

2015-01-26 Thread Sudeep Dutt
MIC card driver specific changes to enable SCIF. This patch implements the SCIF hardware bus operations and registers a SCIF device on the SCIF hardware bus. Reviewed-by: Nikhil Rao Signed-off-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig | 2

[PATCH char-misc-next v3 01/13] misc: mic: SCIF header file and IOCTL interface

2015-01-26 Thread Sudeep Dutt
: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- Documentation/mic/mic_overview.txt | 28 +- Documentation/mic/scif_overview.txt | 98 include/uapi/linux/Kbuild | 1 + include/linux/scif.h| 993 include/uapi/linux/scif_ioctl.h

[PATCH char-misc-next v3 07/13] misc: mic: SCIF node queue pair setup management

2015-01-26 Thread Sudeep Dutt
Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_nodeqp.h | 172 + drivers/misc/mic/scif/scif_nm.c | 184 + drivers/misc/mic/scif/scif_nodeqp.c | 1259 +++ 3 files changed, 1615 insertions(+) create mode

[PATCH char-misc-next v3 03/13] misc: mic: SCIF Hardware Bus

2015-01-26 Thread Sudeep Dutt
by the host and card drivers on the SCIF hardware bus resulting in probing the SCIF driver. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/Kconfig| 17 drivers/misc/mic/Makefile | 2 +- drivers/misc/mic/bus/Makefile

[PATCH char-misc-next v3 04/13] misc: mic: SCIF Peer Bus

2015-01-26 Thread Sudeep Dutt
client drivers (e.g. netdev over SCIF) Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_peer_bus.h | 65 ++ drivers/misc/mic/scif/scif_peer_bus.c | 124 ++ 2 files changed, 189

[PATCH char-misc-next v3 02/13] misc: mic: SCIF ring buffer infrastructure

2015-01-26 Thread Sudeep Dutt
endpoint has a receive queue for messages from its peer. This pair of receive queues is referred to as a SCIF queue pair. Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/scif/scif_rb.h | 100 drivers/misc/mic/scif/scif_rb.c

[PATCH char-misc-next v3 00/13] misc: mic: SCIF driver

2015-01-26 Thread Sudeep Dutt
IC host driver specific changes to enable SCIF 12) MIC card driver specific changes to enable SCIF 13) Add support for loading/unloading SCIF driver Nikhil Rao (1): misc: mic: SCIF connections APIs i.e. accept and connect Sudeep Dutt (12): misc: mic: SCIF header file and IOCTL interface

[PATCH char-misc-next v3 05/13] misc: mic: Common MIC header file changes in preparation for SCIF

2015-01-26 Thread Sudeep Dutt
Update mic_bootparam and define the maximum number of DMA channels Reviewed-by: Nikhil Rao Reviewed-by: Ashutosh Dixit Signed-off-by: Sudeep Dutt --- drivers/misc/mic/common/mic_dev.h | 3 +++ include/uapi/linux/mic_common.h | 12 2 files changed, 15 insertions(+) diff --git

  1   2   3   >