On Tue, 2015-10-13 at 22:46 +0530, Sudip Mukherjee wrote: > On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote: > > On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote: > <snip> > > > + struct scif_hw_dev *sdev = scifdev->sdev; > > > + > > > + dma_unmap_sg(&sdev->dev, p2p->ppi_sg[SCIF_PPI_MMIO], > > > + p2p->sg_nentries[SCIF_PPI_MMIO], DMA_BIDIRECTIONAL); > > > > Hi Sudip, > > > > You missed unmapping the aperture here: > > > > dma_unmap_sg(&sdev->dev, p2p->ppi_sg[SCIF_PPI_APER], > > p2p->sg_nentries[SCIF_PPI_APER], DMA_BIDIRECTIONAL); > > > > Can you please resubmit this patch with the change above? > > Hi Sudeep, > v3 sent for your review. > > > > Also you should mention [PATCH char-misc-next] in the next revision. > > Ohhh... yes, I keep forgetting that Fengguang will need this tag for > his build bot. > > But I have one more doubt. If scif_nodeqp_send() fails then shouldn't we > remove these two nodes of the p2p connection from the lists and release > the resources?
The resources will get cleaned up via scif_destroy_p2p(..) once they are added to the lists. Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
