On Thu, 23 Mar 2017, Austin S. Hemmelgarn wrote:
> On 2017-03-22 21:32, Scot Doyle wrote:
> > On Wed, 22 Mar 2017, Tim Gardner wrote:
> > > BugLink: http://bugs.launchpad.net/bugs/869017
> > >
> > > Console blanking is not enabling DPMS power saving (the
On Wed, 22 Mar 2017, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/869017
>
> Console blanking is not enabling DPMS power saving (thereby negating any
> power-saving benefit), and is simply turning the screen content blank. This
> means that any crash output is invisible which is un
When resizing a vt its selection may exceed the new size, resulting in
an invalid memory access [1]. Clear the selection before resizing.
[1]
http://lkml.kernel.org/r/CACT4Y+acDTwy4umEvf5ROBGiRJNrxHN4Cn5szCXE5Jw-d1B=x...@mail.gmail.com
Reported-and-tested-by: Dmitry Vyukov
Signed-off-by: Scot
> On Tue, Oct 11, 2016 at 3:43 AM, Scot Doyle wrote:
> > I wonder if the text selection is outside the newly resized vc?
> > Does this patch help?
> >
> > --- vt.c2016-10-11 00:32:43.079605599 -
> > +++ vt.c.new2016-10-11 00:36:12.744650759 -00
On Fri, 7 Oct 2016, Dmitry Vyukov wrote:
> On Sat, Sep 3, 2016 at 9:20 PM, Dmitry Vyukov wrote:
> > Hello,
> >
> > The following program causes use-after-free in fbcon_invert_region:
> >
> > https://gist.githubusercontent.com/dvyukov/d657f9a9ca39f34c430dcf63ec1153ac/raw/04e1b94aef0fc9eb770d11373b5
On Fri, 20 May 2016, Scot Doyle wrote:
> On Fri, 20 May 2016, Jeremy Kerr wrote:
> > Hi Ming,
> >
> > >Then looks there are two fix patches acked & tested:
> > >
> > > - the patch in this thread
> > > - another one "[PATCH] tty: vt: Fi
On Fri, 20 May 2016, Jeremy Kerr wrote:
> Hi Ming,
>
> >Then looks there are two fix patches acked & tested:
> >
> > - the patch in this thread
> > - another one "[PATCH] tty: vt: Fix soft lockup in fbcon cursor
> >blink timer."
> > https://lkml.org/lkml/2016/5/17/455
> >
> >So which one will be p
is to initialize vc_cur_blink_ms before calling the con_init()
> function.
>
> Signed-off-by: David Daney
> Cc: sta...@vger.kernel.org
Acked-by: Scot Doyle
Two systems are locking on boot [1] because ops->cur_blink_jiffies
is set to zero from vc->vc_cur_blink_ms.
Ignore such invalid intervals and log a warning.
[1] https://bugs.launchpad.net/bugs/1574814
Suggested-by: David Daney
Signed-off-by: Scot Doyle
Cc: [v4.2]
---
drivers/video/c
On Thu, 19 May 2016, David Daney wrote:
> On 05/18/2016 09:21 PM, Scot Doyle wrote:
> > Two current [1] and three previous [2] systems locked during boot
> > because the cursor flash timer was set using an ops->cur_blink_jiffies
> > value of 0. Previous patches attempted
On Thu, 19 May 2016, Pavel Machek wrote:
> Hi!
>
> > Two current [1] and three previous [2] systems locked during boot
> > because the cursor flash timer was set using an ops->cur_blink_jiffies
> > value of 0. Previous patches attempted to solve the problem by moving
> > variable initialization ea
64a8af, a1e533ec07d5
Signed-off-by: Scot Doyle
Cc: [v4.2]
---
drivers/video/console/fbcon.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 6e92917..da61d87 100644
--- a/drivers/video/console/f
On Wed, 18 May 2016, Ming Lei wrote:
> On Wed, May 18, 2016 at 4:49 AM, Pavel Machek wrote:
> > On Tue 2016-05-17 11:41:04, David Daney wrote:
> >> From: David Daney
> >>
> >> We are getting somewhat random soft lockups with this signature:
> >>
> >> [ 86.992215] [] el1_irq+0xa0/0x10c
> >> [
On Wed, 21 Oct 2015, Benjamin Herrenschmidt wrote:
> On Fri, 2015-10-09 at 15:08 +0000, Scot Doyle wrote:
> > Since commit 27a4c827c34ac4256a190cc9d24607f953c1c459
> > fbcon: use the cursor blink interval provided by vt
> >
> > a PPC64LE kernel fails to boot when
b_set_par.
Reported-and-tested-by: Alistair Popple
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 1aaf893..92f3949 100644
--- a/drivers/video/console/fbcon.c
+++
On Sat, 3 Oct 2015, Alistair Popple wrote:
> Hi,
>
> We have been intermittently seeing the below RCU stall at boot on a
> PPC64LE 4.2.1 kernel which has been preventing the system from booting.
> Further investigation indicates that ops->cur_blink_jiffies is
> potentially being used uninitialis
On Tue, 4 Aug 2015, Pavel Machek wrote:
> On Tue 2015-08-04 12:33:32, Scot Doyle wrote:
> > A sun7i-a20-olinuxino-micro fails to boot when kernel parameter
> > vt.global_cursor_default=0. The value is copied to vc->vc_deccm
> > causing the initialization of ops->cur_
A sun7i-a20-olinuxino-micro fails to boot when kernel parameter
vt.global_cursor_default=0. The value is copied to vc->vc_deccm
causing the initialization of ops->cur_blink_jiffies to be skipped.
Unconditionally initialize it.
Reported-and-tested-by: Jonathan Liu
Signed-off-by: Scot
On Tue, 21 Jul 2015, Michael Kerrisk (man-pages) wrote:
> On 5 July 2015 at 19:41, Scot Doyle wrote:
> > On Thu, 26 Mar 2015, Scot Doyle wrote:
> >> Add a Console Private CSI sequence to specify the current console's
> >> cursor blink interval. The inte
On Thu, 26 Mar 2015, Scot Doyle wrote:
> Add a Console Private CSI sequence to specify the current console's
> cursor blink interval. The interval is specified as a number of
> milliseconds until the next cursor display state toggle, from 50 to
> 65535.
>
> Si
On Wed, 27 May 2015, Andrey Wagin wrote:
...
> I regularly execute criu tests on linux-next. For this, I use virtual
> machine from the digitalocean clould. The current version of
> linux-next hangs after a few seconds. I use git bisect to find the
> commit where the problem is appeaed. And it look
and I'll come up with a
> proper commit message.
>
> Thierry
Hi all, sorry for the trouble.
The timer delete was to prevent blink stutter when updating the interval.
Since the stutter isn't so noticable when changing from the default 200ms,
and since most people seem to prefer l
Add a Console Private CSI sequence to specify the current console's
cursor blink interval. The interval is specified as a number of
milliseconds until the next cursor display state toggle, from 50 to
65535.
Signed-off-by: Scot Doyle
---
man4/console_codes.4 | 1 +
1 file changed, 1 inse
vt now provides a cursor blink interval via vc_data. Use this
interval instead of the currently hardcoded 200 msecs. Store it in
fbcon_ops to avoid locking the console in cursor_timer_handler().
Signed-off-by: Scot Doyle
Acked-by: Pavel Machek
---
drivers/video/console/fbcon.c | 10
to 50 msecs since slower hardware wasn't tested.
Store the interval in the vc_data structure for later access by fbcon,
initializing the value to fbcon's current hardcoded value of 200 msecs.
Signed-off-by: Scot Doyle
Acked-by: Pavel Machek
---
drivers/tty/vt/vt.c| 9 +
v2: Add documentation to console_codes man page (man-pages repo)
This patch series adds an escape sequence to specify the current console's
cursor blink interval. The default interval is set to fbcon's currently
hardcoded 200 msecs.
Scot Doyle (3):
vt: add cursor blink inter
set
# CONFIG_TCG_CRB is not set
[0.236145] tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
[0.292769] tpm_tis 00:08: [Firmware Bug]: TPM interrupt not working, polling
instead
and suspend/resume continue to function.
Tested-by: Scot Doyle
--
To unsubscribe from this list: send the line "u
On Fri, 27 Feb 2015, Scot Doyle wrote:
> Add an escape sequence to specify the current console's cursor blink
> interval. The interval is specified as a number of milliseconds until
> the next cursor display state toggle, from 50 to 65535. /proc/loadavg
> did not show a differenc
vt now provides a cursor blink interval via vc_data. Use this
interval instead of the currently hardcoded 200 msecs. Store it in
fbcon_ops to avoid locking the console in cursor_timer_handler().
Signed-off-by: Scot Doyle
Acked-by: Pavel Machek
---
drivers/video/console/fbcon.c | 10
to 50 msecs since slower hardware wasn't tested.
Store the interval in the vc_data structure for later access by fbcon,
initializing the value to fbcon's current hardcoded value of 200 msecs.
Signed-off-by: Scot Doyle
Acked-by: Pavel Machek
---
drivers/tty/vt/vt.c| 9 +
blink interval via sysfs"
Michael, I plan to send a documentation patch if these are accepted.
This patch series adds an escape sequence to specify the current console's
cursor blink interval. The default interval is set to fbcon's currently
hardcoded 200 msecs.
Scot Doyle (2):
On Wed, 25 Feb 2015, Pavel Machek wrote:
> On Mon 2015-01-26 20:41:53, Scot Doyle wrote:
> > The fbcon cursor, when set to blink, is hardcoded to toggle display state
> > five times per second. Expose this setting via
> > /sys/class/graphics/fbcon/cursor_blink_ms
> >
On Wed, 25 Feb 2015, Zheng, Lv wrote:
...
> > I was using "+"/"#"/"*" to filter different EC log entries
> > which makes debugging easier.
> > And, if we changed this from pr_info into pr_debug, then we will have
> > nothing in the suspend/resume logs for the EC device.
> > While ther
Remove unusual pr_info() visual emphasis introduced in ad479e7f47ca
"ACPI / EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag".
Signed-off-by: Scot Doyle
---
drivers/acpi/ec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/ec.c b/drivers
On Thu, 5 Feb 2015, Tormod Volden wrote:
> On Thu, Feb 5, 2015 at 9:45 PM, Scot Doyle wrote:
> > On Wed, 4 Feb 2015, Nicholas Mc Guire wrote:
> >> The if and the else branch code are identical - so the condition has no
> >> effect on the effective code - this patch re
On Wed, 4 Feb 2015, Nicholas Mc Guire wrote:
> The if and the else branch code are identical - so the condition has no
> effect on the effective code - this patch removes the condition and the
> duplicated code.
>
> Signed-off-by: Nicholas Mc Guire
> ---
>
> This code has been in here since comm
via the 'cursor_blink' boolean
setting or some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 65 +++
fbcon toggles cursor display state every 200 milliseconds when blinking.
Since users prefer different toggle intervals, prepare to expose the
interval via sysfs by moving it to fbdev_ops and setting the default
to 200 milliseconds.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5
error messages as suggested by Tomi Valkeinen
v4: Add rationale into the patches as suggested by Richard Weinberger
v5: Return error codes instead of logging error messages (my mistake)
v6: Uncomment the correct line (my mistake again!)
Scot Doyle (2):
fbcon: store cursor blink interval in
via the 'cursor_blink' boolean
setting or some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 66 +++
fbcon toggles cursor display state every 200 milliseconds when blinking.
Since users prefer different toggle intervals, prepare to expose the
interval via sysfs by moving it to fbdev_ops and setting the default
to 200 milliseconds.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5
error messages as suggested by Tomi Valkeinen
v4: Add rationale into the patches as suggested by Richard Weinberger
v5: Return error codes instead of logging error messages (my mistake)
Scot Doyle (2):
fbcon: store cursor blink interval in fbcon_ops
fbcon: expose cursor blink interval via sysfs
tis.c | 26 +-
> 5 files changed, 34 insertions(+), 39 deletions(-)
Resume still functions on TPM 1.2 chip, with and without CONFIG_TCG_CRB.
Tested-by: Scot Doyle
On Thu, 29 Jan 2015, Michael Kerrisk (man-pages) wrote:
> On 29 January 2015 at 02:27, Scot Doyle wrote:
> > On Wed, 28 Jan 2015, Vivek Goyal wrote:
> >> On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote:
> >> > On Wed, 28 Jan 2015, Vivek Goyal wrote:
>
On Wed, 28 Jan 2015, Vivek Goyal wrote:
> On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote:
> > Hello Vivek,
> >
> > >> I've made various adjustments to the page in the light of your comments
> > >> above. Thanks!
> > >
> > > Thank you for following it up and improving k
On Wed, 28 Jan 2015, Vivek Goyal wrote:
> On Wed, Jan 28, 2015 at 10:10:59PM +0000, Scot Doyle wrote:
> > On Wed, 28 Jan 2015, Vivek Goyal wrote:
> > > On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote:
> > > > When I tested, kexec_file_load required C
On Wed, 28 Jan 2015, Vivek Goyal wrote:
> On Wed, Jan 28, 2015 at 09:14:03PM +0000, Scot Doyle wrote:
> > On Wed, 28 Jan 2015, Vivek Goyal wrote:
> > > On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages)
> > > wrote:
> > > > Hello Vivek
On Tue, 27 Jan 2015, Jarkko Sakkinen wrote:
> Fixed suspend/resume paths for TPM 2.0 and consolidated all the
> associated code to the tpm_pm_suspend() and tpm_pm_resume()
> functions. Resume path should be handled by the firmware, i.e.
> Startup(CLEAR) for hibernate and Startup(STATE) for suspend.
On Tue, 27 Jan 2015, Richard Weinberger wrote:
> Am 27.01.2015 um 00:09 schrieb Scot Doyle:
> > Since users prefer different fbcon cursor blink intervals, allow the
> > interval to be set via sysfs. The current interval of 200 milliseconds
> > is retained as the default
via the 'cursor_blink' boolean
setting or some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 79 +++
fbcon toggles cursor display state every 200 milliseconds when blinking.
Since users prefer different toggle intervals, prepare to expose the
interval via sysfs by moving it to fbdev_ops and setting the default
to 200 milliseconds.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5
error messages as suggested by Tomi Valkeinen
v4: Add rationale into patch descriptions as suggested by
Richard Weinberger
Scot Doyle (2):
fbcon: store cursor blink interval in fbcon_ops
fbcon: expose cursor blink interval via sysfs
drivers/video/console/fbcon.c | 84
some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 79 +++
1 file changed, 79 insertions(+)
diff -
The fbcon cursor, when set to blink, is hardcoded to toggle display
state five times per second. Move this setting to the driver's fbdev_ops
structure, retaining the default blink interval.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5 +++--
drivers/video/console/fbcon.
Allow users to set fbcon's cursor blink interval. The current interval
of 200 milliseconds is retained as the default. Tested with intelfb.
v2: Use kstrtos16() instead of kstrtoul() and min_t() as suggested by
Geert Uytterhoeven
v3: Add error messages as suggested by Tomi Valkeinen
some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Tested with intelfb.
Signed-off-by: Scot Doyle
---
v2: Use kstrtos16() instead of kstrtoul() and min_t(). Thanks Geert!
drivers/video/
The fbcon cursor, when set to blink, is hardcoded to toggle display state
five times per second. Move this setting to a the driver's fbdev_ops
structure, retaining the default blink interval.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5 +++--
drivers/video/console/fb
some other mechanism, the 'cursor_blink_ms' setting may still
be modified. The new value will be used if the blink is reactivated.
Tested with intelfb.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 75 +++
1 file changed, 75 inser
The fbcon cursor, when set to blink, is hardcoded to toggle display state
five times per second. Move this setting to a the driver's fbdev_ops
structure, retaining the default blink interval.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 5 +++--
drivers/video/console/fb
Allow users to set fbcon's cursor blink interval. The current interval
of 200 milliseconds is retained as the default.
Tested with intelfb.
Scot Doyle (2):
fbcon: store cursor blink interval in fbcon_ops
fbcon: expose cursor blink interval via sysfs
drivers/video/console/fbcon.c
commit 1fa0b29f3a43 ("fbdev: Kill Atari vblank cursor blinking")
rendered vbl_cursor_cnt and therefore CURSOR_DRAW_DELAY unused in fbcon.c,
so remove them.
Signed-off-by: Scot Doyle
---
drivers/video/console/fbcon.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/vid
On Sat, 10 Jan 2015, Joe Perches wrote:
> On Sat, 2015-01-10 at 22:21 +0000, Scot Doyle wrote:
> > Call printk twice since this log entry has two lines and headings.
> >
> > [0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
> > Last level dTLB entri
Call printk twice since this log entry has two lines and headings.
[0.009285] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
Signed-off-by: Scot Doyle
---
arch/x86/kernel/cpu/common.c | 10 +-
1 file changed, 5
On Sun, 14 Dec 2014, Stefan Berger wrote:
> On 12/14/2014 10:40 AM, Jarkko Sakkinen wrote:
> > On Sun, Dec 14, 2014 at 09:48:26AM -0500, Stefan Berger wrote:
> > > On 12/12/2014 02:46 PM, Jarkko Sakkinen wrote:
> > > > Detect TPM 2.0 by sending idempotent TPM 2.x command. Ordinals for
> > > > TPM 2
tpm/tpm2-cmd.c
> create mode 100644 drivers/char/tpm/tpm_crb.c
>
> --
> 2.1.0
>
This patchset works on a TPM 1.2 Toshiba CB35-A3120 using either
CONFIG_TCG_TPM=y
CONFIG_TCG_TIS=y
# CONFIG_TCG_TIS_I2C_ATMEL is not set
# CONFIG_TCG_TIS_I2C_INFINEON is not set
# CONFIG_TCG_TIS_I2C_NUVOTON
Hi Jarkko,
On Thu, 4 Dec 2014, Jarkko Sakkinen wrote:
> From: Will Arthur
>
> Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
> instead of calling tpm_get_timeouts(), assign duration and timeout
> values defined in the TPM 2.0 PTP specification.
>
> Signed-off-by: Will Ar
Hi Jarkko, will you explain why the free_irq call was removed in
tpm_tis_init around line 693?
I'm wondering if the free_irq call in disable_irq in
https://lkml.org/lkml/2014/9/24/1179 should be removed since it's also
invoked during tpm_tis_init.
On Mon, 27 Oct 2014, Jarkko Sakkinen wrote:
On Mon, 22 Sep 2014, Peter Hüwe wrote:
> Am Montag, 22. September 2014, 19:13:38 schrieb Jason Gunthorpe:
>
> >
> > This does look much nicer, lets use this version.
> >
> > I think Peter were prefer a new clean patch that superceeds the
> > original.
> >
> > > + if (!priv->irq_tested) {
> >
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
USB: fix LANGID=0 regression
defaults to a langid of 0x0409 if it's not properly implemented by the
device. Explain with a higher level error message what this means.
Signed-off-by: Scot Doyle
---
drivers/usb/core/message.c | 4 +---
1
Commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
USB: fix LANGID=0 regression
defaults to a langid of 0x0409 if it's not properly implemented by the
device. Explain with a higher level error message what this means.
Signed-off-by: Scot Doyle
---
drivers/usb/core/message.c | 4 +---
1
module should receive an IRQ during
module init. Fall back to polling mode if none is received when expected.
Signed-off-by: Scot Doyle
Tested-by: Michael Mullin
---
drivers/char/tpm/tpm_tis.c | 75 +-
1 file changed, 61 insertions(+), 14 deletions(-)
diff
On Tue, 23 Sep 2014, Stefan Berger wrote:
> On 09/23/2014 07:55 AM, Scot Doyle wrote:
>> On Tue, 23 Sep 2014, Scot Doyle wrote:
>> +static void disable_interrupts(struct tpm_chip *chip)
>> +{
>> +u32 intmask;
>> +intmask =
>>
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote:
On Tue, Sep 23, 2014 at 07:12:40PM +, Scot Doyle wrote:
According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
USB: fix LANGID=0 regression
usb devices are not required to report string descriptors. Since they are
optional, log an
On Tue, 23 Sep 2014, Greg Kroah-Hartman wrote:
> On Tue, Sep 23, 2014 at 10:28:49PM +0000, Scot Doyle wrote:
>> I'd like to change this error message:
>> [3.325837] usb 1-4: string descriptor 0 malformed (err = -61),
>> defaulting to 0x0409
>>
>> int
I'd like to change this error message:
[3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting
to 0x0409
into an error message followed by a debug message:
[3.324726] usb 1-4: malformed string descriptor; unknown language,
defaulting to English
[3.327514] usb 1-4: s
According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
USB: fix LANGID=0 regression
usb devices are not required to report string descriptors. Since they are
optional, log an info message instead of an error message.
Signed-off-by: Scot Doyle
---
drivers/usb/core/message.c | 8
On Tue, 23 Sep 2014, Alan Stern wrote:
> -ENODATA doesn't mean the string was unavailable. It means that the
> second byte of the reply was different from USB_DT_STRING, i.e., the
> reply was malformed.
Thank you for the correction!
> And down here is where you should call either dev_info() or d
On Tue, 23 Sep 2014, Scot Doyle wrote:
Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do
not send IRQs while also having an ACPI TPM entry indicating that they
will be sent. These machines freeze on resume while the tpm_tis module
waits for an IRQ, eventually timing out
module should receive an IRQ during
module init. Fall back to polling mode if none is received when expected.
Signed-off-by: Scot Doyle
Tested-by: Michael Mullin
Reviewed-By: Jason Gunthorpe
---
drivers/char/tpm/tpm_tis.c | 76 +-
1 file changed, 62
On Mon, 22 Sep 2014, Jason Gunthorpe wrote:
On Thu, Sep 11, 2014 at 12:50:00AM +, Scot Doyle wrote:
+ if (!priv->irq_tested) {
I think the sleep and check is still needed here, the IRQ delivery
could race relative to the MMIO read of completion, a sleep is the
only way we co
to a debug message.
Tested with USB device 0930:021c.
Signed-off-by: Scot Doyle
---
drivers/usb/core/message.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 0c8a7fc..6b95de7 100644
--- a/drivers
On Thu, 11 Sep 2014, Scot Doyle wrote:
>
> On Mon, 8 Sep 2014, Jason Gunthorpe wrote:
>> On Tue, Sep 02, 2014 at 08:22:58PM +, Scot Doyle wrote:
>>
>>> It's spending that time (now 3 seconds) in tpm_tis_send_data.
>>
>> Due to request_locality?
>
On Mon, 8 Sep 2014, Jason Gunthorpe wrote:
> On Tue, Sep 02, 2014 at 08:22:58PM +0000, Scot Doyle wrote:
>
>> It's spending that time (now 3 seconds) in tpm_tis_send_data.
>
> Due to request_locality?
The first command transmitted (TPM_CAP_PROP) in tpm_get_timeouts goe
On Tue, 9 Sep 2014, Scot Doyle wrote:
Some machines, such as the Acer C720 and Toshiba CB35, have TPMs that do
not send IRQs while also having an ACPI TPM entry indicating that they
will be sent. These machines freeze on resume while the tpm_tis module
waits for an IRQ, eventually timing out
module should receive an IRQ during
module init. Fall back to polling mode if none is received when expected.
Signed-off-by: Scot Doyle
Tested-by: Michael Mullin
Reviewed-By: Jason Gunthorpe
---
drivers/char/tpm/tpm_tis.c | 75 +++---
1 file changed, 57
Commit-ID: 6b44f519017b219a12b37173c7eef8dfce2c0100
Gitweb: http://git.kernel.org/tip/6b44f519017b219a12b37173c7eef8dfce2c0100
Author: Scot Doyle
AuthorDate: Sun, 24 Aug 2014 17:12:27 +
Committer: Ingo Molnar
CommitDate: Fri, 5 Sep 2014 12:37:10 +0200
sched/wait: Document timeout
On Tue, 2 Sep 2014, Jason Gunthorpe wrote:
> On Sat, Aug 30, 2014 at 11:23:56PM +0000, Scot Doyle wrote:
>> The output is now
>> [1.526798] tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
>> [5.914732] tpm_tis 00:08: [Firmware Bug]: TPM interrupt not working,
>&g
On Sat, 30 Aug 2014, Jason Gunthorpe wrote:
> On Fri, Aug 29, 2014 at 11:59:32PM +0000, Scot Doyle wrote:
>
>> I tried calling tpm_get_timeouts only during the interrupt test, but again
>> was timed out after 30 seconds. The interrupt wait in tis_send calls
>> tpm_calc
On Thu, 28 Aug 2014, Jason Gunthorpe wrote:
> On Thu, Aug 28, 2014 at 12:35:16AM +0000, Scot Doyle wrote:
>
>>> To move it means we have to understand why you are getting timeouts:
>>>
>>> [ 33.247720] tpm_tis 00:08: tpm_transmit: tpm_send: error -62
>>&g
On Wed, 27 Aug 2014, Jason Gunthorpe wrote:
> On Wed, Aug 27, 2014 at 09:32:10PM +0000, Scot Doyle wrote:
>>>> -if (tpm_do_selftest(chip)) {
>>>> -dev_err(dev, "TPM self test failed\n");
>>>> -rc = -ENODEV;
>>
On Wed, 27 Aug 2014, Jason Gunthorpe wrote:
> On Wed, Aug 27, 2014 at 04:31:56AM +0000, Scot Doyle wrote:
>> It doesn't enable stock SeaBIOS machines to suspend/resume before the 30
>> second interrupt timeout, unless using interrupts=0 or force=1.
>
> ? Can y
On Mon, 25 Aug 2014, Jason Gunthorpe wrote:
> On Mon, Aug 25, 2014, Scot Doyle wrote:
>> 3. Custom SeaBIOS. Blacklist the tpm_tis module so that it doesn't load
>>and therefore doesn't issue startup(clear) to the TPM chip.
>
> It seems to me at least in this cas
possible for the return value to be 1 after receiving
an interrupt, but this should be rare. The condition is not double-
checked because of possible side effects.
Signed-off-by: Scot Doyle
---
Patch for wait_event_interruptible_timeout documentation:
https://lkml.kernel.org/g/alpine.LNX
On Fri, 22 Aug 2014, Jason Gunthorpe wrote:
> On Fri, Aug 22, 2014 at 08:17:27PM +0000, Scot Doyle wrote:
>> On Fri, 22 Aug 2014, Jason Gunthorpe wrote:
>>> On Fri, Aug 22, 2014 at 12:58:41AM +, Scot Doyle wrote:
>>>> Some machines, such as the Acer C720 and Tos
The timeout may elapse without 0 being returned, such as when waiting
on an unused queue. Document this possibility.
Signed-off-by: Scot Doyle
---
include/linux/wait.h | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/linux/wait.h b/include/linux
On Fri, 22 Aug 2014, Jason Gunthorpe wrote:
> On Fri, Aug 22, 2014 at 12:58:41AM +0000, Scot Doyle wrote:
>> Some machines, such as the Acer C720 and Toshiba CB35, have TPMs
>> that do not use interrupts while also having an ACPI TPM entry
>
> How do these machines work in W
interrupt. If none is received, then
fall back to polling mode.
Signed-off-by: Scot Doyle
Tested-by: James Duley
Tested-by: Michael Mullin
---
drivers/char/tpm/tpm_tis.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char
On Fri, 1 Aug 2014, Oliver Neukum wrote:
On Thu, 2014-07-10 at 14:11 +0100, Scot Doyle wrote:
Hi Olof,
Have these been applied? If not, where should I watch for them?
Hi,
could you tell me from which tree I could get these patches?
Regards
Oliver
Sure, they'
Hi Olof,
Have these been applied? If not, where should I watch for them?
Thank you,
Scot
On Mon, 30 Jun 2014, Olof Johansson wrote:
No, not yet. I'll do a pass of merges of this (and arm-soc) on Wednesday.
-Olof
On Mon, Jun 30, 2014 at 5:05 PM, Scot Doyle wrote:
Hi Olof, did you
Hi Olof, did you apply these patches? I haven't seen them in 3.16-rc3,
linux-next, kernel/git/olof/chrome-platform, kernel/git/olof/misc, or
kernel/git/arm/arm-soc.
Thanks,
Scot
On Tue, 17 Jun 2014, Benson Leung wrote:
Looks like -rc1 is here, so I'll respin these and send them out again.
On
1 - 100 of 107 matches
Mail list logo
