Hi Laurent,
On Thu, May 15, 2025 at 03:03:40PM +0200, Laurent Pinchart wrote:
> On Thu, May 15, 2025 at 02:54:54PM +0300, Sakari Ailus wrote:
> > On Thu, May 15, 2025 at 10:58:46AM +0200, Laurent Pinchart wrote:
> > > On Tue, May 06, 2025 at 08:24:03AM +, Sakari Ailus wro
Hi Laurent,
On Thu, May 15, 2025 at 10:58:46AM +0200, Laurent Pinchart wrote:
> Hi Sakari,
>
> On Tue, May 06, 2025 at 08:24:03AM +0000, Sakari Ailus wrote:
> > On Mon, May 05, 2025 at 11:05:56PM +0200, André Apitzsch via B4 Relay wrote:
> > > From: André Apitzsch
>
Hi André,
On Tue, May 06, 2025 at 10:16:23PM +0200, André Apitzsch wrote:
> Hi Sakari,
>
> thanks for the feedback. One question below.
>
> Am Dienstag, dem 06.05.2025 um 08:05 + schrieb Sakari Ailus:
> > Hi André,
> >
> > A few more comments below.
>
is, the clock-frequency should
be deprecated (or even removed from bingings).
I wonder what others think. Cc'd Laurent in any case.
> ret = imx214_get_regulators(dev, imx214);
> if (ret < 0)
> return dev_err_probe(dev, ret, "failed to get regulators\n");
>
--
Regards,
Sakari Ailus
p),
>"failed to initialize CCI\n");
>
> - ret = imx214_parse_fwnode(dev);
> + ret = imx214_parse_fwnode(dev, imx214);
> if (ret)
> return ret;
>
> @@ -1310,7 +1435,9 @@ static int imx214_probe(struct i2c_client *client)
>* Enable power initially, to avoid warnings
>* from clk_disable on power_off
>*/
> - imx214_power_on(imx214->dev);
> + ret = imx214_power_on(imx214->dev);
> + if (ret < 0)
> + goto error_fwnode;
>
> ret = imx214_identify_module(imx214);
> if (ret)
> @@ -1341,6 +1468,12 @@ static int imx214_probe(struct i2c_client *client)
> pm_runtime_set_active(imx214->dev);
> pm_runtime_enable(imx214->dev);
>
> + ret = imx214_pll_update(imx214);
> + if (ret < 0) {
> + dev_err_probe(dev, ret, "failed to update PLL\n");
> + goto error_subdev_cleanup;
> + }
> +
> ret = v4l2_async_register_subdev_sensor(&imx214->sd);
> if (ret < 0) {
> dev_err_probe(dev, ret,
> @@ -1366,6 +1499,9 @@ static int imx214_probe(struct i2c_client *client)
> error_power_off:
> imx214_power_off(imx214->dev);
>
> +error_fwnode:
> + v4l2_fwnode_endpoint_free(&imx214->bus_cfg);
> +
> return ret;
> }
>
> @@ -1378,6 +1514,8 @@ static void imx214_remove(struct i2c_client *client)
> v4l2_subdev_cleanup(sd);
> media_entity_cleanup(&imx214->sd.entity);
> v4l2_ctrl_handler_free(&imx214->ctrls);
> + v4l2_fwnode_endpoint_free(&imx214->bus_cfg);
> +
> pm_runtime_disable(&client->dev);
> if (!pm_runtime_status_suspended(&client->dev)) {
> imx214_power_off(imx214->dev);
>
--
Regards,
Sakari Ailus
y relevant for ancient systems and ACPI today.
https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html>
> if (ret)
> return dev_err_probe(dev, ret,
>"failed to set xclk frequency\n");
>
--
Kind regards,
Sakari Ailus
mx214->regmap),
>"failed to initialize CCI\n");
>
> - ret = imx214_parse_fwnode(dev);
> + ret = imx214_parse_fwnode(dev, imx214);
> if (ret)
> return ret;
>
> @@ -1310,7 +1431,9 @@ static int imx214_probe(struct i2c_client *client)
>* Enable power initially, to avoid warnings
>* from clk_disable on power_off
>*/
> - imx214_power_on(imx214->dev);
> + ret = imx214_power_on(imx214->dev);
> + if (ret < 0)
> + goto error_fwnode;
>
> ret = imx214_identify_module(imx214);
> if (ret)
> @@ -1341,6 +1464,8 @@ static int imx214_probe(struct i2c_client *client)
> pm_runtime_set_active(imx214->dev);
> pm_runtime_enable(imx214->dev);
>
> + imx214_pll_update(imx214);
> +
> ret = v4l2_async_register_subdev_sensor(&imx214->sd);
> if (ret < 0) {
> dev_err_probe(dev, ret,
> @@ -1366,6 +1491,9 @@ static int imx214_probe(struct i2c_client *client)
> error_power_off:
> imx214_power_off(imx214->dev);
>
> +error_fwnode:
> + v4l2_fwnode_endpoint_free(&imx214->bus_cfg);
> +
> return ret;
> }
>
> @@ -1378,6 +1506,8 @@ static void imx214_remove(struct i2c_client *client)
> v4l2_subdev_cleanup(sd);
> media_entity_cleanup(&imx214->sd.entity);
> v4l2_ctrl_handler_free(&imx214->ctrls);
> + v4l2_fwnode_endpoint_free(&imx214->bus_cfg);
> +
> pm_runtime_disable(&client->dev);
> if (!pm_runtime_status_suspended(&client->dev)) {
> imx214_power_off(imx214->dev);
>
--
Kind regards,
Sakari Ailus
driver could use the CCS PLL calculator? The PLL appears
to be compliant. The AR0234 driver will do the same. (The sensor might just
work with the CCS driver, too, but that's another discussion.)
--
Kind regards,
Sakari Ailus
Hi André,
On Sun, Feb 09, 2025 at 10:51:58PM +0100, André Apitzsch via B4 Relay wrote:
> + .of_match_table = of_match_ptr(dw9719_of_table),
Please drop of_match_ptr(), that fixes the problem.
--
Sakari Ailus
gt; +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +i2c {
> +#address-cells = <1>;
> +#size-cells = <0>;
> +
> +camera-lens@c {
> +compatible = "dongwoon,dw9761";
> +reg = <0x0c>;
> +vdd-supply = <&pm8916_l10>;
> +};
> +};
>
--
Regards,
Sakari Ailus
tree, and if built as a module like major linux distributions do.
>
> Signed-off-by: André Apitzsch
How about the DT bindings?
The configuration should be documented, too. See e.g. for an example
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9768.yaml .
--
Regards,
Sakari Ailus
On Thu, Jan 09, 2025 at 08:59:43AM +, Sakari Ailus wrote:
> I tried to find a good example but the few I found are buggy. :-( Getting
> runtime PM right is just hard. I'll drop the last patch and post another to
I meant to say this patch, not the last one.
--
Sakari Ailus
Hi André,
On Wed, Jan 08, 2025 at 10:46:51PM +0100, André Apitzsch wrote:
> Hi Sakari,
>
> Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus:
> > Hi André,
> >
> > Thanks for the update.
> >
> > On Fri, Dec 20, 2024 at 02:26:11PM +0100
imx214->ctrls);
>
> pm_runtime_disable(&client->dev);
> + if (!pm_runtime_status_suspended(&client->dev))
> + imx214_power_off(&client->dev);
> pm_runtime_set_suspended(&client->dev);
> }
>
>
--
Regards,
Sakari Ailus
; + if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
> + imx214->cur_mode = mode;
While the patch is a major improvement as of now, it'd be nice to get rid
of the cur_mode field. Could you instead obtai nthe mode using
v4l2_find_nearest_size()?
I'm fine with changing this in a new patch on top of the set.
--
Regards,
Sakari Ailus
IN,
> > > + IMX214_VTS_MAX - mode-
> > > >height, 2,
> > > + mode->vts_def - mode-
> > > >height);
> >
> > Is the handler->lock held when we call this function?
>
> I'm not sure how to test this.
I'd say "yes" because the first patch sets the control handler lock to the
sub-device state lock.
--
Regards,
Sakari Ailus
Hi André,
On Sat, Dec 14, 2024 at 11:45:16PM +0100, André Apitzsch wrote:
> Hi,
>
> Am Dienstag, dem 10.12.2024 um 12:34 + schrieb Sakari Ailus:
> > On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado
> > wrote:
> >
t; + goto error_power_off;
The error handling was wrong in the driver, the code under the
error_power_off label only disables the regulator (and runtime PM, which
hasn't been enabled) but it does not disable or unprepare the clock. Could
you fix these in a new patch, please?
> +
> pm_runtime_set_active(imx214->dev);
> pm_runtime_enable(imx214->dev);
> pm_runtime_idle(imx214->dev);
>
--
Kind regards,
Sakari Ailus
ber of MIPI CSI2 data lanes */
> + if (bus_cfg.bus.mipi_csi2.num_data_lanes != 4) {
> + ret = dev_err_probe(dev, -EINVAL,
> + "only 4 data lanes are currently
> supported\n");
> + goto done;
> + }
> +
> for (i = 0; i < bus_cfg.nr_of_link_frequencies; i++)
> if (bus_cfg.link_frequencies[i] == IMX214_DEFAULT_LINK_FREQ)
> break;
>
--
Sakari Ailus
On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado wrote:
> > > + state = v4l2_subdev_get_locked_active_state(&imx214->sd);
> >
> > Sakari, I see that other drivers assume that the active is locked in
> > set_ctrl. Is this correct?
&
t message?
>
> I think it is a combination of both. There will be products out there
> that after applying this change will get different frames using the
> same configuration.
>
> @Sakari Ailus What do we usually do in these cases?
Good question. Always when something is
25aeccb46a400fa93146f14ea..5d411452d342fdb177619cd1c9fd9650d31089bb
> > 100644
> > --- a/drivers/media/i2c/imx214.c
> > +++ b/drivers/media/i2c/imx214.c
> > @@ -24,7 +24,7 @@
> > #define IMX214_MODE_STREAMING 0x01
> >
> > #define IMX214_DEFAULT_CLK_FREQ2400
> > -#define IMX214_DEFAULT_LINK_FREQ 48000
> > +#define IMX214_DEFAULT_LINK_FREQ 6
> > #define IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10)
> > #define IMX214_FPS 30
> > #define IMX214_MBUS_CODE MEDIA_BUS_FMT_SRGGB10_1X10
> >
--
Kind regards,
Sakari Ailus
On Tue, Apr 20, 2021 at 05:54:57PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 20, 2021 at 05:37:27PM +0300, Sakari Ailus wrote:
> > On Tue, Apr 20, 2021 at 02:55:33PM +0300, Andy Shevchenko wrote:
> > > On Tue, Apr 20, 2021 at 01:56:40PM +0300, Sakari Ailus wrote:
> > >
On Tue, Apr 20, 2021 at 02:55:33PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 20, 2021 at 01:56:40PM +0300, Sakari Ailus wrote:
> > On Tue, Apr 20, 2021 at 06:34:26PM +0800, Bingbu Cao wrote:
> > > On 4/20/21 6:20 PM, Andy Shevchenko wrote:
> > > > On Tue, Apr 20, 20
busted. */
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x2a40, quirk_iommu_igfx);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x2e00, quirk_iommu_igfx);
> @@ -5657,6 +5683,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x1632,
> quirk_iommu_igfx);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x163A, quirk_iommu_igfx);
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x163D, quirk_iommu_igfx);
>
> +/* disable IPU dmar support */
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, PCI_ANY_ID, quirk_iommu_ipu);
> +
> static void quirk_iommu_rwbf(struct pci_dev *dev)
> {
> if (risky_device(dev))
--
Kind regards,
Sakari Ailus
gt; I noticed there was a typo in the recipient list:
> stable.vger.kernel.org -> sta...@vger.kernel.org
>
> no code change for resent.
When you're submitting a patch and want it reach the stable kernels, you'll
need to add a Cc tag:
Cc: sta...@vger.kernel.org
But not actually add the address to cc. I dropped stable@vger address from
distribution.
Please change this for v3.
--
Kind regards,
Sakari Ailus
hat.
>
> Checkpatch is a perl script that searches for patterns that often indicate
> code that is hard to understand. It is not a precise definition of what
> is allowed in the Linux kernel. Humans have to amke compromises.
Yeah... but I'd think if this is a preferred style then the warning could
be omitted. It might not be that difficult.
--
Sakari Ailus
Hi Dan,
On Fri, Apr 16, 2021 at 08:49:41AM +0300, Dan Carpenter wrote:
> On Fri, Apr 16, 2021 at 12:21:58AM +0300, Sakari Ailus wrote:
> > On Thu, Apr 15, 2021 at 08:59:41PM +0100, Matthew Wilcox wrote:
> > > On Thu, Apr 15, 2021 at 08:57:04PM +0100, Matthew Wilcox wrote:
>
On Thu, Apr 15, 2021 at 08:59:41PM +0100, Matthew Wilcox wrote:
> On Thu, Apr 15, 2021 at 08:57:04PM +0100, Matthew Wilcox wrote:
> > On Thu, Apr 15, 2021 at 10:49:55PM +0300, Sakari Ailus wrote:
> > > On Thu, Apr 15, 2021 at 06:14:09PM +0100, Matthew Wilcox wrote:
> > >
e a space before the asterisk though.
--
Sakari Ailus
On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro wrote:
> Format all comments according to the coding-style.
> Issue detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro
Thanks!
Acked-by: Sakari Ailus
--
Sakari Ailus
On Wed, Apr 14, 2021 at 03:55:42PM -0300, ascordeiro wrote:
> Em qua, 2021-04-14 às 21:33 +0300, Sakari Ailus escreveu:
> > Hi Aline,
> >
> > Thanks for the patch.
> >
> > On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro
> > wrote:
> &
sequence_temp,
> @@ -1247,7 +1249,8 @@ void atomisp_buf_done(struct atomisp_sub_device *asd,
> int error,
>
> if (IS_ISP2401) {
> /* If there are no buffers queued then
This should begin with:
/*
*
And the same for the rest. Apart from this the patch seems fine.
--
Kind regards,
Sakari Ailus
> * 2 least significant bits represent the fractional part
> > >
> > > Just remove the spaces, don't remove the tab. It's looks silly now.
> > >
> > Okay Sir, do I have to send a v4 patch on this now?
>
> Yes. If you get feedback on a patch, you should send a new version.
v2 of this patch can be used as well, it's fine. (I missed this change in
v3.)
--
Sakari Ailus
On Tue, Apr 13, 2021 at 08:58:19PM +0530, Mitali Borkar wrote:
> Changes from v2:- Rebased these four patces and made changes against
> mailine code
Thanks for the update, Mitali.
For the set:
Acked-by: Sakari Ailus
--
Sakari Ailus
Hi Laurent,
On Tue, Apr 13, 2021 at 04:45:17PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
>
> Thank you for the patch.
>
> On Mon, Apr 12, 2021 at 02:11:20PM +0300, Sakari Ailus wrote:
> > The header defines the user space interface but may be mistaken as
> > ke
On Tue, Apr 13, 2021 at 04:26:36PM +0530, Mitali Borkar wrote:
> On Tue, Apr 13, 2021 at 01:44:32PM +0300, Sakari Ailus wrote:
> > On Tue, Apr 13, 2021 at 04:13:04PM +0530, Mitali Borkar wrote:
> > > On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
On Tue, Apr 13, 2021 at 04:13:04PM +0530, Mitali Borkar wrote:
> On Tue, Apr 13, 2021 at 01:01:34PM +0300, Sakari Ailus wrote:
> > Hi Mitali,
> >
> > Thanks for the update.
> >
> > On Tue, Apr 13, 2021 at 10:46:06AM +0530, Mitali Borkar wrote:
> > > Redu
On Sun, Apr 11, 2021 at 04:48:41PM +0300, dev.dra...@bk.ru wrote:
> From: Dmitrii Wolf
>
> Fixed a coding style issue.
>
> Signed-off-by: Dmitrii Wolf
Acked-by: Sakari Ailus
--
Sakari Ailus
oesn't apply
here due to the different attribute syntax.
> struct ipu3_uapi_ae_ccm ae_ccm __aligned(32);
> } __packed;
>
--
Kind regards,
Sakari Ailus
ins de Carvalho
>
Acked-by: Sakari Ailus
--
Sakari Ailus
Hi Mitali,
On Mon, Apr 12, 2021 at 07:59:29PM +0530, Mitali Borkar wrote:
> On Mon, Apr 12, 2021 at 12:43:15PM +0300, Sakari Ailus wrote:
> > Hi Mitali,
> >
> > On Mon, Apr 12, 2021 at 04:38:59AM +0530, Mitali Borkar wrote:
> > > This patch fixes the warning
The header defines the user space interface but may be mistaken as
kernel-only header due to its location. Add "uapi" directory under
driver's include directory and move the header there.
Suggested-by: Greg KH
Signed-off-by: Sakari Ailus
---
Documentation/admin-guide/media/ipu
On Mon, Apr 12, 2021 at 12:55:52PM +0200, Greg KH wrote:
> On Mon, Apr 12, 2021 at 01:44:35PM +0300, Sakari Ailus wrote:
> > Hi Greg,
> >
> > On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote:
> > > On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari
Hi Greg,
On Mon, Apr 12, 2021 at 11:49:43AM +0200, Greg KH wrote:
> On Mon, Apr 12, 2021 at 12:42:30PM +0300, Sakari Ailus wrote:
> > Hi Mitali,
> >
> > On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote:
> > > Added #include and replaced bit shifts
ight_elem weights[
> - IPU3_UAPI_AE_WEIGHTS] __aligned(32);
> + struct ipu3_uapi_ae_weight_elem weights[IPU3_UAPI_AE_WEIGHTS]
> __aligned(32);
Could you still wrap it to stay under 80?
> struct ipu3_uapi_ae_ccm ae_ccm __aligned(32);
> } __packed;
>
--
Sakari Ailus
user space header, it's not
under include/uapi/linux.
--
Kind regards,
Sakari Ailus
B_RGBS_THR_B_EN (1 << 14)
> -#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT(1 << 15)
> +#define IPU3_UAPI_AWB_RGBS_THR_B_EN BIT(14)
> +#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SATBIT(15)
>
> /**
> * struct ipu3_uapi_grid_config - Grid plane config
--
Kind regards,
Sakari Ailus
o would just duplicate other examples. So let's just remove the
> example.
>
> Cc: Mauro Carvalho Chehab
> Cc: Sakari Ailus
> Cc: Laurent Pinchart
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Rob Herring
Thanks!
Reviewed-by: Sakari Ailus
--
Sakari Ailus
Hi Laurent and Jacopo,
Thanks for cc'ing me.
On Sat, Mar 20, 2021 at 05:42:12PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> CC'ing Sakari on v3 to get feedback.
>
> On Fri, Mar 19, 2021 at 05:41:34PM +0100, Jacopo Mondi wr
Hi Laurent,
On Fri, Mar 12, 2021 at 03:25:11AM +0200, Laurent Pinchart wrote:
> Hi Rob,
>
> Thank you for the patch.
>
> On Thu, Mar 11, 2021 at 04:40:42PM -0700, Rob Herring wrote:
> > Now that we have the graph schema, convert the video-mux binding to DT
> > schema
ACPI: Constify acpi_bus helper functions, switch to
> macros")
> Cc: Sakari Ailus
> Signed-off-by: Andy Shevchenko
Thanks!
Reviewed-by: Sakari Ailus
--
Sakari Ailus
-)maintainers do the review.
> +
> +The sub-maintainers work on specific areas of the subsystem, as
> +described below:
> +
> +Digital TV:
> + Sean Young
> +
> +HDMI CEC:
> + Hans Verkuil
> +
> +Media controller drivers:
> + Laurent Pinchart
> +
&g
ync subdev from the
> subdev_list with the corresponding list_head not initialized.
>
> Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
IMO this can be merged through another tree once the first patch is agreed
on. Cc Hans and Mauro, too.
> ---
> drivers/media/v4l2-core/
ou think of issuing a warning if one is NULL but the other one
isn't? That could happen if the memory is uninitialised by the caller. It
should return true in that case, too.
> +}
> +
> #ifdef CONFIG_DEBUG_LIST
> extern bool __list_add_valid(struct list_head *new,
> struct list_head *prev,
--
Kind regards,
Sakari Ailus
lash->fault is the equivalent of "rval" for non-negative returns so
> this condition can never be true. We should never be returning these
> weird firmware ADP1653_REG_FAULT_FLT_SCP fault codes to the v4l2 layers.
I think this could be fixed and cleaned up by always retuning zero on
success, and checking for flash->faults while holding the mutex in
adp1653_init_device. I could fix that, too, just let me know...
--
Regards,
Sakari Ailus
s: 22f2b47517a6 ("media: dt-bindings: media: i2c: Add OV8865 bindings
> documentation")
> Fixes: 29a202fa7acc ("media: dt-bindings: media: i2c: Add OV5648 bindings
> documentation")
> Cc: Sakari Ailus
> Cc: Mauro Carvalho Chehab
> Cc: Dave Stevenson
> C
On Wed, Feb 17, 2021 at 01:14:42PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 16.02.21 um 16:57 schrieb Sakari Ailus:
> > Hi all,
> >
> > On merging --- it would seem everyone is happy with merging this
> > through the drm-misc tree. The last patch sh
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
Acked-by: Mauro Carvalho Chehab
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
- Added V4L2 core conversion to %p4cc, as well as change the DRM
fourcc printing function to use %p4cc.
- Add missing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (4):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourC
The %p4cc printk format modifier was recently added to print fourcc codes,
replacing drm_get_format_name(). The function is no longer needed, so
remove it.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/gpu/drm/drm_fourcc.c | 25
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
Acked-by: Thomas Zimmermann
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
The %p4cc printk format modifier was recently added to print fourcc codes,
replacing drm_get_format_name(). The function is no longer needed, so
remove it.
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/gpu/drm/drm_fourcc.c | 25
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
Acked-by: Mauro Carvalho Chehab
Reviewed-by: Petr Mladek
Reviewed-by: Andy Shevchenko
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file
ssing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (4):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourCC codes
drm: Switch to %p4cc format modifier
drm: Remove drm_get_format_name()
Documentation/core-a
Hi Thomas,
Thanks for the review.
On Tue, Feb 16, 2021 at 09:37:45AM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 15.02.21 um 12:40 schrieb Sakari Ailus:
> > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> > large number of temporary varia
} else {
> seq_printf();
> }
>
> ?
I could, but it'd repeat a lot of the same format string that is very
complicated right now. Therefore I thought it's better to split.
Or do you mean seq_printf() vs. seq_puts()? checkpatch.pl (rightly) warns
about it.
>
> >fb ? fb->modifier : 0,
> >fb ? fb->width : 0, fb ? fb->height : 0,
> >plane_visibility(plane_state),
--
Sakari Ailus
On Mon, Feb 15, 2021 at 06:05:45PM +0100, Mauro Carvalho Chehab wrote:
> Em Mon, 15 Feb 2021 17:56:27 +0100
> Petr Mladek escreveu:
>
> > On Mon 2021-02-15 13:40:29, Sakari Ailus wrote:
> > > Now that we can print FourCC codes directly using printk, make use of the
&g
Hi Petr,
On Mon, Feb 15, 2021 at 05:51:40PM +0100, Petr Mladek wrote:
> On Mon 2021-02-15 17:54:47, Andy Shevchenko wrote:
> > On Mon, Feb 15, 2021 at 03:56:50PM +0200, Sakari Ailus wrote:
> > > On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> > > >
Hi Andy,
On Mon, Feb 15, 2021 at 03:31:29PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:28PM +0200, Sakari Ailus wrote:
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding is th
Hi Andy,
On Mon, Feb 15, 2021 at 03:34:04PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:29PM +0200, Sakari Ailus wrote:
> > Now that we can print FourCC codes directly using printk, make use of the
> > feature in V4L2 core.
>
> Reviewed-by: Andy Shevche
Hi Andy,
On Mon, Feb 15, 2021 at 03:41:14PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 15, 2021 at 01:40:30PM +0200, Sakari Ailus wrote:
> > Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
> > large number of temporary variables at the same time.
>
&
Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
pixel formats denoted by fourccs. The fourcc encoding is the same for both
so the same implementation can be used.
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Sakari Ailus
Reviewed-by: Petr Mladek
Reviewed-by
Switch DRM drivers from drm_get_format_name() to %p4cc. This gets rid of a
large number of temporary variables at the same time.
Signed-off-by: Sakari Ailus
---
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c| 5 ++--
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c| 5 ++--
drivers/gpu/drm/amd
Now that we can print FourCC codes directly using printk, make use of the
feature in V4L2 core.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-ioctl.c | 85 +++-
1 file changed, 21 insertions(+), 64 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2
ll as change the DRM
fourcc printing function to use %p4cc.
- Add missing checkpatch.pl checks for %p4cc modifier.
Sakari Ailus (3):
lib/vsprintf: Add support for printing V4L2 and DRM fourccs
v4l: ioctl: Use %p4cc printk modifier to print FourCC codes
drm: Switch to %p4cc format modifier
Hi Petr,
Thanks for the comments.
On Thu, Feb 11, 2021 at 06:14:28PM +0100, Petr Mladek wrote:
> On Tue 2021-02-09 19:47:55, Sakari Ailus wrote:
> > Hi Andy,
> >
> > On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote:
> > > On Tue, Feb 09, 2021 at
Hi Petr,
On Thu, Feb 11, 2021 at 05:31:46PM +0100, Petr Mladek wrote:
> On Mon 2021-02-08 22:09:02, Sakari Ailus wrote:
> > Now that we can print FourCC codes directly using printk, make use of the
> > feature in V4L2 core.
> >
> > Signed-off-by: Sakari Ailus
>
8184afc77 ("device property: Move FW type specific functionality to
> FW specific files")
> Reported-by: Calvin Johnson
> Cc: 4.13+ # 4.13+
> Signed-off-by: Rafael J. Wysocki
Thanks for addressing this.
Reviewed-by: Sakari Ailus
--
Sakari Ailus
ename probe_powered_off struct device field as probe_low_power and
reflect the similar naming to the patches overall.
- Work with CONFIG_PM disabled, too.
Rajmohan Mani (1):
media: i2c: imx319: Support device probe in non-zero ACPI D state
Sakari Ailus (6):
ACPI: scan: Obtain device's desi
From: Rajmohan Mani
Tell ACPI device PM code that the driver supports the device being in
non-zero ACPI D state when the driver's probe function is entered.
Signed-off-by: Rajmohan Mani
Signed-off-by: Sakari Ailus
Reviewed-by: Tomasz Figa
Reviewed-by: Bingbu Cao
---
drivers/medi
).
Signed-off-by: Sakari Ailus
Reviewed-by: Tomasz Figa
---
drivers/misc/eeprom/at24.c | 43 +++---
1 file changed, 26 insertions(+), 17 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 926408b41270c..427520af9961e 100644
dd a field called "flags" into struct i2c_driver for driver flags, and a
flag I2C_DRV_ACPI_WAIVE_D0_PROBE to tell a driver supports probe in ACPI D
states other than 0.
Signed-off-by: Sakari Ailus
Reviewed-by: Tomasz Figa
Acked-by: Wolfram Sang
---
drivers/i2c/i2c-core-acpi.c | 10 +++
Document the use of the _DSE object for setting desirable power state
during probe.
Signed-off-by: Sakari Ailus
Reviewed-by: Tomasz Figa
---
Documentation/firmware-guide/acpi/index.rst | 1 +
.../firmware-guide/acpi/non-d0-probe.rst | 78 +++
2 files changed, 79
Store a device's desired enumeration power state in struct
acpi_device_power during acpi_device object's initialisation.
Signed-off-by: Sakari Ailus
---
drivers/acpi/scan.c | 4
include/acpi/acpi_bus.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/acpi/scan.c
Tell ACPI device PM code that the driver supports the device being in a
non-zero D state when the driver's probe function is entered.
Also do identification on the first access of the device, whether in probe
or when starting streaming.
Signed-off-by: Sakari Ailus
Reviewed-by: Tomasz
Add a convenience function to tell whether a device is in D0 state,
primarily for use in drivers' probe or remove functions on busses where
the custom is to power on the device for the duration of both.
Returns false on non-ACPI systems.
Suggested-by: Mika Westerberg
Signed-off-by: Sakari
t v11 soon.
> name of the define because I think it is clear enough that this is a
> flag. If you need to resend anyhow, maybe it is worth a thought. It is
> not a big issue, so anyway:
>
> Acked-by: Wolfram Sang
>
> because I assume this will go in via the ACPI tree?
>
--
Sakari Ailus
s/media/i2c/imx334.c: In function 'imx334_parse_hw_config':
include/linux/dev_printk.h:112:2: warning: 'ret' may be used uninitialized
in this function [-Wmaybe-uninitialized]
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~
drivers/media/i2c
On Wed, Feb 10, 2021 at 01:26:51PM +0100, Bartosz Golaszewski wrote:
> On Wed, Feb 10, 2021 at 9:41 AM Sakari Ailus
> wrote:
> >
> > On Tue, Feb 09, 2021 at 05:58:12PM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Feb 9, 2021 at 5:54 PM Sakari Ailus
> > > w
x27;ll remove _FL for v11.
> not a big issue, so anyway:
>
> Acked-by: Wolfram Sang
Thank you!
>
> because I assume this will go in via the ACPI tree?
I think so, yes, if no-one has objections. Most of the changes are for ACPI
framework and docs.
--
Kind regards,
Sakari Ailus
On Tue, Feb 09, 2021 at 05:58:12PM +0100, Rafael J. Wysocki wrote:
> On Tue, Feb 9, 2021 at 5:54 PM Sakari Ailus
> wrote:
> >
> > On Tue, Feb 09, 2021 at 05:42:45PM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Feb 9, 2021 at 5:23 PM Sakari Ailus
> > > wrote
Hi Andy,
On Tue, Feb 09, 2021 at 11:58:40AM +0200, Andy Shevchenko wrote:
> On Tue, Feb 09, 2021 at 11:20:32AM +0200, Sakari Ailus wrote:
> > On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> > > On Mon, Feb 8, 2021 at 10:11 PM Sakari
On Tue, Feb 09, 2021 at 05:42:45PM +0100, Rafael J. Wysocki wrote:
> On Tue, Feb 9, 2021 at 5:23 PM Sakari Ailus
> wrote:
> >
> > Hi Bartosz, Rafael,
> >
> > On Tue, Feb 09, 2021 at 04:49:37PM +0100, Bartosz Golaszewski wrote:
> > > On Mon, Feb 8, 2021 at
Hi Bartosz, Rafael,
On Tue, Feb 09, 2021 at 04:49:37PM +0100, Bartosz Golaszewski wrote:
> On Mon, Feb 8, 2021 at 5:54 PM Rafael J. Wysocki wrote:
> >
> > On Mon, Feb 8, 2021 at 5:44 PM Bartosz Golaszewski
> > wrote:
> > >
> > > On Fri, Feb 5, 20
Hi Andy,
On Mon, Feb 08, 2021 at 10:43:30PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 8, 2021 at 10:11 PM Sakari Ailus
> wrote:
> >
> > Add a printk modifier %p4cc (for pixel format) for printing V4L2 and DRM
> > pixel formats denoted by fourccs. The fourcc encoding is
Hi Daniel,
Thanks for the comments.
On Tue, Feb 09, 2021 at 08:27:10AM +0100, Daniel Vetter wrote:
> On Mon, Feb 8, 2021 at 9:20 PM Sakari Ailus
> wrote:
> >
> > Instead of constructing the FourCC code manually, use the %p4cc printk
> > modifier to print it. Also leave
1 - 100 of 1023 matches
Mail list logo
