On Tue, Nov 21, 2023 at 06:10:03PM -0500, Steven Rostedt wrote:
> Mark Rutland reported some crashes from the latest eventfs updates.
> This fixes most of them.
>
> He still has one splat that he can trigger but I can not. Still looking
> into that.
Reviewed-by: Josef Bacik
Thanks,
Josef
On 4/15/21 1:53 PM, Luis Chamberlain wrote:
On Wed, Aug 23, 2017 at 3:31 PM Jeff Mahoney wrote:
On 8/15/14 5:29 AM, Al Viro wrote:
On Thu, Aug 14, 2014 at 07:58:56PM -0700, Luis R. Rodriguez wrote:
Christoph had noted that this seemed associated to the problem
that the btrfs uses different
On 4/14/21 11:21 AM, xiaojun.zhao...@gmail.com wrote:
On Wed, 14 Apr 2021 13:27:43 +0200 (CEST)
Miroslav Benes wrote:
Hi,
On Wed, 14 Apr 2021, xiaojun.zhao...@gmail.com wrote:
I found the qemu-nbd process(started with qemu-nbd -t -c /dev/nbd0
nbd.qcow2) will automatically exit when I patche
On 3/18/21 1:42 AM, Kai-Heng Feng wrote:
On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik wrote:
[snipped]
"shutdown now" works fine with and without your patch. Thanks,
Rafael,
Please revert the patch while we are working on it.
Josef,
Can you please test the following patch:
Th
On 3/17/21 12:14 PM, Kai-Heng Feng wrote:
On Wed, Mar 17, 2021 at 11:19 PM Josef Bacik wrote:
On 3/16/21 10:50 PM, Kai-Heng Feng wrote:
Hi,
On Wed, Mar 17, 2021 at 10:17 AM Josef Bacik wrote:
This reverts commit d60cd06331a3566d3305b3c7b566e79edf4e2095.
This patch causes a panic when
On 3/16/21 10:50 PM, Kai-Heng Feng wrote:
Hi,
On Wed, Mar 17, 2021 at 10:17 AM Josef Bacik wrote:
This reverts commit d60cd06331a3566d3305b3c7b566e79edf4e2095.
This patch causes a panic when rebooting my Dell Poweredge r440. I do
not have the full panic log as it's lost at that sta
again.
Signed-off-by: Josef Bacik
---
- apologies, I mistyped the lkml list email.
kernel/reboot.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/reboot.c b/kernel/reboot.c
index eb1b15850761..a6ad5eb2fa73 100644
--- a/kernel/reboot.c
+++ b/kernel/reboot.c
@@ -244,8 +244,6 @@
On 3/16/21 8:43 PM, Linus Torvalds wrote:
[ Adding btrfs people explicitly, maybe they see this on the fs-devel
list, but maybe they don't react .. ]
On Tue, Mar 16, 2021 at 12:07 PM Matthew Wilcox wrote:
This isn't a problem with this patch per se, but I'm concerned about
private2 and expect
On 2/22/21 3:25 AM, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:f40ddce8 Linux 5.11
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=179e8d22d0
kernel config: https://syzkaller.appspot.com/x/.config?x=e53d04227c52a0df
dashboar
On 2/22/21 4:34 AM, Hillf Danton wrote:
Mon, 22 Feb 2021 00:25:18 -0800
Hello,
syzbot found the following issue on:
HEAD commit:f40ddce8 Linux 5.11
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=179e8d22d0
kernel config: https://syzkaller.appspot.co
tch.
v3: Do not use unlock and add put_nbd.
v2: Use jump target unlock.
Sun Ke (2):
nbd: Fix NULL pointer in flush_workqueue
nbd: share nbd_put and return by goto put_nbd
drivers/block/nbd.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
You can add
Reviewed-by: Jo
On 2/5/21 1:56 AM, Sun Ke wrote:
Open /dev/nbdX first, the config_refs will be 1 and
the pointers in nbd_device are still null. Disconnect
/dev/nbdX, then reference a null recv_workq. The
protection by config_refs in nbd_genl_disconnect is useless.
[ 656.366194] BUG: kernel NULL pointer derefer
On 2/6/21 2:10 AM, winnd...@163.com wrote:
From: Liao Pingfang
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Liao Pingfang
Reviewed-by: Josef Bacik
Thanks,
Josef
On 1/27/21 8:57 AM, Michal Rostecki wrote:
From: Michal Rostecki
Before this change, the btrfs_get_io_geometry() function was calling
btrfs_get_chunk_map() to get the extent mapping, necessary for
calculating the I/O geometry. It was using that extent mapping only
internally and freeing the poi
On 1/27/21 3:11 AM, Abaci Team wrote:
Fix the following coccicheck warnings:
./fs/btrfs/delayed-inode.c:1157:39-41: WARNING !A || A && B is
equivalent to !A || B.
Reported-by: Abaci Robot
Suggested-by: Jiapeng Zhong
Signed-off-by: Abaci Team
Reviewed-by: Josef Bacik
Thanks,
Josef
On 1/19/21 12:05 AM, Chaitanya Kulkarni wrote:
Hi,
This is a *compile only RFC* which adds a generic helper to initialize
the various fields of the bio that is repeated all the places in
file-systems, block layer, and drivers.
The new helper allows callers to initialize various members such as
-off-by: Josh Triplett
Reviewed-by: Josef Bacik
Thanks,
Josef
On 12/9/20 10:38 PM, Bart Van Assche wrote:
On 12/7/20 10:55 AM, Palmer Dabbelt wrote:
All in all, I've found it a bit hard to figure out what sort of interest
people
have in dm-user: when I bring this up I seem to run into people who've done
similar things before and are vaguely interested, but
le as possible.
We hope that you and your families continue to stay safe and health. Thank you
on behalf of the program committee:
Josef Bacik (Filesystems)
Amir Goldstein (Filesystems)
Martin K. Petersen (Storage)
Omar Sandoval (Storage)
Michal Hock
On 11/3/20 1:05 AM, Nick Terrell wrote:
From: Nick Terrell
Please pull from
g...@github.com:terrelln/linux.git tags/v5-zstd-1.4.6
to get these changes. Alternatively the patchset is included.
Where did we come down on the code formatting question? Personally I'm of the
mind that as lo
pr_warn("BTRFS: ZSTD_initCStream_advanced returned
%s\n",
+ ZSTD_getErrorName(ret2));
+ ret = -EIO;
+ goto out;
+ }
+ }
Please don't do this, you can just add size_t ret2 at the top and not put this
in a block. Other than that
On 11/4/20 1:16 AM, kernel test robot wrote:
Greeting,
FYI, we noticed a -59.7% regression of fio.write_iops due to commit:
commit: 96bed17ad9d425ff6958a2e6f87179453a3d76f2 ("btrfs: simplify the logic in
need_preemptive_flushing")
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.g
aid that if we could have
mnt->mnt_ns change in between checks that we were just trading a possible NULL
deref with a UAF, but we're under RCU here so we're good there as well. You can add
Reviewed-by: Josef Bacik
Thanks,
Josef
On 8/27/20 3:43 AM, Dinghao Liu wrote:
When lookup_root_entry() fails, ref should be freed
just like when insert_ref_entry() fails.
Signed-off-by: Dinghao Liu
Reviewed-by: Josef Bacik
Thanks,
Josef
On 10/4/20 2:04 PM, Matthew Wilcox (Oracle) wrote:
On 32-bit systems, this shift will overflow for files larger than 4GB.
Cc: sta...@vger.kernel.org
Fixes: 53b381b3abeb ("Btrfs: RAID5 and RAID6")
Signed-off-by: Matthew Wilcox (Oracle)
Reviewed-by: Josef Bacik
Thanks,
Josef
Reviewed-by: Josef Bacik
Thanks,
Josef
path after orphanization of a
directory")
Signed-off-by: kernel test robot
Signed-off-by: Julia Lawall
Reviewed-by: Josef Bacik
Thanks,
Josef
: fix panic when trying to destroy a newly
allocated")
Addresses-Coverity: CID 1497103: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar
Reviewed-by: Josef Bacik
Thanks,
Josef
t doesn't matter. You can add
Reviewed-by: Josef Bacik
To the series, thanks,
Josef
27;s no cleanup that's needed, there isn't,
you can add
Reviewed-by: Josef Bacik
Thanks,
Josef
On 8/13/20 5:10 PM, David Laight wrote:
From: Josef Bacik
Sent: 13 August 2020 18:19
...
We wouldn't even need the extra +1 part, since we're only copying in how much
the user wants anyway, we could just go ahead and convert this to
left -= snprintf(buffer, left, "0x%04x\n&q
The buffer coming from higher up the stack has an extra byte to handle
the NULL terminator in the string. Instead of using a temporary buffer
to sprintf into and then copying into the buffer, just scnprintf
directly into the buffer and update lenp as appropriate.
Signed-off-by: Josef Bacik
Now that we're allocating an extra slot for the NULL terminated string,
use scnprintf() and write directly into the buffer.
Signed-off-by: Josef Bacik
---
net/sunrpc/sysctl.c| 10 ++
net/sunrpc/xprtrdma/svc_rdma.c | 16 ++--
2 files changed, 4 insertions(+
ned-off-by: Josef Bacik
---
kernel/sysctl.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index 287862f91717..d8cc8737f58f 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -484,6 +484,7 @@ static int proc_get_long(
This initialy started with
[PATCH 1/6] proc: use vmalloc for our kernel buffer
Which came about because we were getting page alloc failures when cat tried to
do a read with a 64kib buffer, triggering an order 4 allocation. We need to
switch to kvmalloc for this buffer to avoid these high order
7;cat' binary was 64kib. Order-4 allocations are not
awesome, and since we can potentially allocate up to our maximum order,
use vmalloc for these buffers.
Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
Signed-off-by: Josef Bacik
---
fs/proc/proc_sysct
separate, but start with allocating the extra byte to handle the
null termination of strings.
Signed-off-by: Josef Bacik
---
fs/proc/proc_sysctl.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index
This helper uses kvmalloc, not vmalloc, so rename it to kvmemdup_user to
make it clear we're using kvmalloc() and will need to use kvfree().
Signed-off-by: Josef Bacik
---
arch/x86/kvm/cpuid.c | 6 +++---
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 2 +-
drivers/t
On 8/13/20 1:31 PM, Al Viro wrote:
On Thu, Aug 13, 2020 at 01:19:18PM -0400, Josef Bacik wrote:
in sunrpc proc_dodebug() turns into
left -= snprintf(buffer, left, "0x%04x\n",
left
On 8/13/20 12:20 PM, Al Viro wrote:
On Thu, Aug 13, 2020 at 05:41:17PM +0200, Christoph Hellwig wrote:
On Thu, Aug 13, 2020 at 11:40:00AM -0400, Josef Bacik wrote:
On 8/13/20 11:37 AM, Christoph Hellwig wrote:
On Thu, Aug 13, 2020 at 11:33:56AM -0400, Josef Bacik wrote:
Since
sysctl
On 8/13/20 12:19 PM, David Laight wrote:
From: Josef Bacik
Sent: 13 August 2020 15:53
sysctl: pass kernel pointers to ->proc_handler
we have been pre-allocating a buffer to copy the data from the proc
handlers into, and then copying that to userspace. The problem is this
just bl
This helper uses kvmalloc, not vmalloc, so rename it to kvmemdup_user to
make it clear we're using kvmalloc() and will need to use kvfree().
Signed-off-by: Josef Bacik
---
arch/x86/kvm/cpuid.c | 6 +++---
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 2 +-
drivers/t
7;cat' binary was 64kib. Order-4 allocations are not
awesome, and since we can potentially allocate up to our maximum order,
use vmalloc for these buffers.
Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
Signed-off-by: Josef Bacik
---
v2-&g
On 8/13/20 11:37 AM, Christoph Hellwig wrote:
On Thu, Aug 13, 2020 at 11:33:56AM -0400, Josef Bacik wrote:
Since
sysctl: pass kernel pointers to ->proc_handler
we have been pre-allocating a buffer to copy the data from the proc
handlers into, and then copying that to userspace.
7;cat' binary was 64kib. Order-4 allocations are not
awesome, and since we can potentially allocate up to our maximum order,
use vmalloc for these buffers.
Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
Signed-off-by: Josef Bacik
---
v1->v2:
- Mak
On 8/13/20 10:59 AM, Matthew Wilcox wrote:
On Thu, Aug 13, 2020 at 10:53:05AM -0400, Josef Bacik wrote:
+/**
+ * vmemdup_user - duplicate memory region from user space and NUL-terminate
vmemdup_user_nul()
+void *vmemdup_user_nul(const void __user *src, size_t len)
+{
+ void *p
7;cat' binary was 64kib. Order-4 allocations are not
awesome, and since we can potentially allocate up to our maximum order,
use vmalloc for these buffers.
Fixes: 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler")
Signed-off-by: Josef Bacik
---
fs/proc/proc_sysct
On 7/29/20 2:41 PM, Eric Sandeen wrote:
On 7/29/20 11:32 AM, Josef Bacik wrote:
Hello,
Eric reported a problem to me where we were clearing SB_I_VERSION on remount of a btrfs
file system. After digging through I discovered it's because we expect the proper flags
that we want to be pass
Hello,
Eric reported a problem to me where we were clearing SB_I_VERSION on remount of
a btrfs file system. After digging through I discovered it's because we expect
the proper flags that we want to be passed in via the mount() syscall, and
because we didn't have "iversion" in our show_option
re
exact")
Signed-off-by: Josef Bacik
---
kernel/trace/ftrace.c | 3 ---
kernel/trace/trace.h | 7 ++-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 1903b80db6eb..7d879fae3777 100644
--- a/kernel/trace/ftrace.c
+++ b/k
163, read_one_chunk
marking the device with IN_FS_METADATA was wallpapering over it, which
this patch breaks. I will be sending a subsequent fix for the seed replace
issue which will also fix btrfs/163.
Signed-off-by: Boris Burkov
Reviewed-by: Josef Bacik
Thanks,
Josef
On 7/9/20 8:44 PM, Boris Burkov wrote:
It is possible to cause a btrfs mount to fail by racing it with a slow
umount. The crux of the sequence is generic_shutdown_super not yet
calling sop->put_super before btrfs_mount_root calls btrfs_open_devices.
If that occurs, btrfs_open_devices will decide
On 6/17/20 2:11 PM, Filipe Manana wrote:
On Wed, Jun 17, 2020 at 6:43 PM Chris Mason wrote:
On 17 Jun 2020, at 13:20, Filipe Manana wrote:
On Wed, Jun 17, 2020 at 5:32 PM Boris Burkov wrote:
---
fs/btrfs/extent_io.c | 45
1 file changed, 29
On Tue, Sep 03, 2019 at 04:06:33PM +0800, kernel test robot wrote:
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: 3ae92b3782182d282a92573abe95c96d34ca6e73 ("btrfs: change the minimum
> global reserve size")
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/next/li
On Fri, Aug 16, 2019 at 12:57:41PM +0200, Paolo Valente wrote:
> Hi,
> I happened to test the io.latency controller, to make a comparison
> between this controller and BFQ. But io.latency seems not to work,
> i.e., not to reduce latency compared with what happens with no I/O
> control at all. Her
bd2]
>? remove_wait_queue+0x60/0x60
>kthread+0xf8/0x130
>? commit_timeout+0x10/0x10 [jbd2]
>? kthread_bind+0x10/0x10
>ret_from_fork+0x35/0x40
>
> With __invalidate_device(), I no longer hit the BUG_ON with sync or
> unmount on the disconnected device.
>
Jeeze I swear I see this same patch go by every 6 months or so, not sure what
happens to it. Anyway
Reviewed-by: Josef Bacik
Thanks,
Josef
Yup go for it, thanks,
Josef
Sent from my iPhone
> On Jul 9, 2019, at 9:09 AM, Steven Rostedt wrote:
>
> On Fri, 20 Nov 2015 15:57:26 -0500
> Josef Bacik wrote:
>
>> We need a few functions to disable/enable tracing as well as add events to be
>> enabled on the
On Fri, Jun 28, 2019 at 04:49:13PM -0400, Rik van Riel wrote:
> Flatten the hierarchical runqueues into just the per CPU rq.cfs runqueue.
>
> Iteration of the sched_entity hierarchy is rate limited to once per jiffy
> per sched_entity, which is a smaller change than it seems, because load
> averag
On Fri, Jun 28, 2019 at 04:49:12PM -0400, Rik van Riel wrote:
> Add helper functions to make the flattened runqueue patch a little smaller.
>
> The task_se_h_weight function is similar to task_se_h_load, but scales the
> task weight by the group weight, without taking the task's duty cycle into
>
Riel
Reviewed-by: Josef Bacik
Thanks,
Josef
it will be used later.
>
> No functional changes.
>
> Signed-off-by: Rik van Riel
Reviewed-by: Josef Bacik
Thanks,
Josef
On Mon, Jul 01, 2019 at 12:47:35PM -0400, Rik van Riel wrote:
> On Mon, 2019-07-01 at 12:29 -0400, Josef Bacik wrote:
> > On Fri, Jun 28, 2019 at 04:49:06PM -0400, Rik van Riel wrote:
> > > The runnable_load magic is used to quickly propagate information
> > > about
On Fri, Jun 28, 2019 at 04:49:06PM -0400, Rik van Riel wrote:
> The runnable_load magic is used to quickly propagate information about
> runnable tasks up the hierarchy of runqueues. The runnable_load_avg is
> mostly used for the load balancing code, which only examines the value at
> the root cfs_
On Wed, Jun 26, 2019 at 10:39:36AM +0800, Rong Chen wrote:
> On 6/25/19 10:22 PM, Josef Bacik wrote:
> > On Fri, Jun 21, 2019 at 08:48:03AM +0800, Huang, Ying wrote:
> > > "Huang, Ying" writes:
> > >
> > > > "Huang, Ying" writes:
>
On Fri, Jun 21, 2019 at 08:48:03AM +0800, Huang, Ying wrote:
> "Huang, Ying" writes:
>
> > "Huang, Ying" writes:
> >
> >> Hi, Josef,
> >>
> >> kernel test robot writes:
> >>
> >>> Greeting,
> >>>
> >>> FYI, we noticed a -11.7% regression of aim7.jobs-per-min due to commit:
> >>>
> >>>
> >>> com
On Tue, Jun 18, 2019 at 07:42:46AM +, Naohiro Aota wrote:
> On 2019/06/13 23:09, Josef Bacik wrote:
> > On Fri, Jun 07, 2019 at 10:10:14PM +0900, Naohiro Aota wrote:
> >> If the btrfs volume has mirrored block groups, it unconditionally makes
> >> un-mirrored bloc
t;
> Signed-off-by: Tejun Heo
> Cc: Chris Mason
Reviewed-by: Josef Bacik
Thanks,
Josef
On Thu, Jun 13, 2019 at 05:33:44PM -0700, Tejun Heo wrote:
> Add a helper to determine the target blkcg from wbc.
>
> Signed-off-by: Tejun Heo
Reviewed-by: Josef Bacik
Thanks,
Josef
allow disabling wbc accounting. This will be used
> make btfs compression work well with cgroup IO control.
>
> Signed-off-by: Tejun Heo
Reviewed-by: Josef Bacik
Thanks,
Josef
prevent recurrences.
>
>
> Pavel Begunkov (2):
> blk-iolatency: Fix zero mean in previous stats
> blk-stats: Introduce explicit stat staging buffers
>
I don't have a problem with this, but it's up to Jens I suppose
Acked-by: Josef Bacik
Thanks,
Josef
On Wed, Jun 12, 2019 at 07:31:44PM +0300, roman.stratiie...@globallogic.com
wrote:
> From: Roman Stratiienko
>
> Adding support to nbd to use it as a root device. This code essentially
> provides a minimal nbd-client implementation within the kernel. It opens
> a socket and makes the negotiation
On Fri, Jun 07, 2019 at 10:10:08PM +0900, Naohiro Aota wrote:
> If a zoned block device is found, get its zone information (number of zones
> and zone size) using the new helper function btrfs_get_dev_zonetypes(). To
> avoid costly run-time zone report commands to test the device zones type
> duri
On Fri, Jun 07, 2019 at 10:10:15PM +0900, Naohiro Aota wrote:
> When in HMZONED mode, make sure that device super blocks are located in
> randomly writable zones of zoned block devices. That is, do not write super
> blocks in sequential write required zones of host-managed zoned block
> devices as
On Fri, Jun 07, 2019 at 10:10:17PM +0900, Naohiro Aota wrote:
> Sequential allocation is not enough to maintain sequential delivery of
> write IOs to the device. Various features (async compress, async checksum,
> ...) of btrfs affect ordering of the IOs. This patch introduces submit
> buffer to so
On Fri, Jun 07, 2019 at 10:10:22PM +0900, Naohiro Aota wrote:
> When truncating a file, file buffers which have already been allocated but
> not yet written may be truncated. Truncating these buffers could cause
> breakage of a sequential write pattern in a block group if the truncated
> blocks ar
On Fri, Jun 07, 2019 at 10:10:24PM +0900, Naohiro Aota wrote:
> Currently, dev-replace copy all the device extents on source device to the
> target device, and it also clones new incoming write I/Os from users to the
> source device into the target device.
>
> Cloning incoming IOs can break the se
On Fri, May 24, 2019 at 03:46:17PM +0800, Huang, Ying wrote:
> "Huang, Ying" writes:
>
> > "Huang, Ying" writes:
> >
> >> Hi, Josef,
> >>
> >> kernel test robot writes:
> >>
> >>> Greeting,
> >>>
> >>> FYI, we noticed a -12.4% regression of fio.write_bw_MBps due to commit:
> >>>
> >>>
> >>> com
flect the change.
>
> Cc: Josef Bacik
> Signed-off-by: Yang Shi
> ---
Reviewed-by: Josef Bacik
Thanks,
Josef
On Thu, Mar 14, 2019 at 09:54:07AM +0200, Nikolay Borisov wrote:
>
>
> On 14.03.19 г. 9:50 ч., Kangjie Lu wrote:
> > btrfs_lookup_block_group may fail and return NULL. The fix goes
> > to out when it fails to avoid NULL pointer dereference.
>
> Actually no, in this case btrfs_lookup_block_group
On Thu, Mar 07, 2019 at 07:08:31PM +0100, Andrea Righi wrote:
> = Problem =
>
> When sync() is executed from a high-priority cgroup, the process is forced to
> wait the completion of the entire outstanding writeback I/O, even the I/O that
> was originally generated by low-priority cgroups potentia
ng the
> previous behavior by default).
>
> When this flag is enabled any cgroup can write out only dirty pages that
> belong to the cgroup itself (except for the root cgroup that would still
> be able to write out all pages globally).
>
> Signed-off-by: Andrea Righi
Reviewed-by: Josef Bacik
Thanks,
Josef
On Thu, Mar 07, 2019 at 07:08:32PM +0100, Andrea Righi wrote:
> Prevent priority inversion problem when a high-priority blkcg issues a
> sync() and it is forced to wait the completion of all the writeback I/O
> generated by any other low-priority blkcg, causing massive latencies to
> processes that
On Thu, Mar 07, 2019 at 07:08:34PM +0100, Andrea Righi wrote:
> Keep track of the inodes that have been dirtied by each blkcg cgroup and
> make sure that a blkcg issuing a sync() can trigger the writeback + wait
> of only those pages that belong to the cgroup itself.
>
> This behavior is applied o
On Mon, Feb 11, 2019 at 09:40:29PM +0100, Andrea Righi wrote:
> On Mon, Feb 11, 2019 at 10:39:34AM -0500, Josef Bacik wrote:
> > On Sat, Feb 09, 2019 at 03:07:49PM +0100, Andrea Righi wrote:
> > > This is an attempt to mitigate the priority inversion problem of a
> > >
On Sat, Feb 09, 2019 at 03:07:49PM +0100, Andrea Righi wrote:
> This is an attempt to mitigate the priority inversion problem of a
> high-priority blkcg issuing a sync() and being forced to wait the
> completion of all the writeback I/O generated by any other low-priority
> blkcg, causing massive l
On Tue, Jan 29, 2019 at 07:39:38PM +0100, Andrea Righi wrote:
> On Mon, Jan 28, 2019 at 02:26:20PM -0500, Vivek Goyal wrote:
> > On Mon, Jan 28, 2019 at 06:41:29PM +0100, Andrea Righi wrote:
> > > Hi Vivek,
> > >
> > > sorry for the late reply.
> > >
> > > On Mon, Jan 21, 2019 at 04:47:15PM -0500
On Tue, Jan 29, 2019 at 01:17:17PM -0500, Josef Bacik wrote:
> On Mon, Jan 28, 2019 at 04:24:33PM -0500, Dennis Zhou wrote:
> > The previous patch added generic helpers for get_workspace() and
> > put_workspace(). Now, we can migrate ownership of the workspace_manager
> > to
ompression level.
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
On Mon, Jan 28, 2019 at 04:24:33PM -0500, Dennis Zhou wrote:
> The previous patch added generic helpers for get_workspace() and
> put_workspace(). Now, we can migrate ownership of the workspace_manager
> to be in the compression type code as the compression code itself
> doesn't care beyond being a
priate compression type. It also introduces
> btrfs_put_workspace() and btrfs_get_workspace() to be the generic
> implementations of the higher interface.
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
methods that will be the generic implementation for btrfs workspace
> management.
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
On Mon, Jan 28, 2019 at 04:24:30PM -0500, Dennis Zhou wrote:
> Make the workspace_manager own the interface operations rather than
> managing index-paired arrays for the workspace_manager and compression
> operations.
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
On Mon, Jan 28, 2019 at 04:24:28PM -0500, Dennis Zhou wrote:
> This is in preparation for zstd compression levels. As each level will
> require different sized workspaces, workspaces_list is no longer a
> really fitting name.
>
> Signed-off-by: Dennis Zhou
> ---
Review
On Mon, Jan 28, 2019 at 04:24:27PM -0500, Dennis Zhou wrote:
> It is very easy to miss places that rely on a certain bitshifting for
> decyphering the type_level overloading. Make macros handle this instead.
>
> Signed-off-by: Dennis Zhou
Reviewed-by: Josef Bacik
Thanks,
Josef
On Fri, Jan 18, 2019 at 07:44:03PM +0100, Andrea Righi wrote:
> On Fri, Jan 18, 2019 at 11:35:31AM -0500, Josef Bacik wrote:
> > On Fri, Jan 18, 2019 at 11:31:24AM +0100, Andrea Righi wrote:
> > > This is a redesign of my old cgroup-io-throttle controller:
> > > http
On Fri, Jan 18, 2019 at 06:07:45PM +0100, Paolo Valente wrote:
>
>
> > Il giorno 18 gen 2019, alle ore 17:35, Josef Bacik
> > ha scritto:
> >
> > On Fri, Jan 18, 2019 at 11:31:24AM +0100, Andrea Righi wrote:
> >> This is a redesign of my old cgroup-io-th
On Fri, Jan 18, 2019 at 11:31:24AM +0100, Andrea Righi wrote:
> This is a redesign of my old cgroup-io-throttle controller:
> https://lwn.net/Articles/330531/
>
> I'm resuming this old patch to point out a problem that I think is still
> not solved completely.
>
> = Problem =
>
> The io.max cont
On Wed, Jan 09, 2019 at 07:08:09PM +0300, Kirill Tkhai wrote:
> Hi, Josef,
>
> On 09.01.2019 18:49, Josef Bacik wrote:
> > On Wed, Jan 09, 2019 at 03:20:18PM +0300, Kirill Tkhai wrote:
> >> On nodes without memory overcommit, it's common a situation,
> >>
On Wed, Jan 09, 2019 at 03:20:18PM +0300, Kirill Tkhai wrote:
> On nodes without memory overcommit, it's common a situation,
> when memcg exceeds its limit and pages from pagecache are
> shrinked on reclaim, while node has a lot of free memory.
> Further access to the pages requires real device IO,
1 - 100 of 502 matches
Mail list logo
