rb_set_parent_color(node, NULL, RB_BLACK);
break;
} else if (rb_is_black(parent))
break;
- gparent = rb_parent(parent);
+ gparent = rb_red_parent(parent);
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
|
Missing a "be" here: ---------
Ack from me after those two corrections.
Reviewed-by: Joey Pabalinas
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
be treated properly a few lines above.
Good catch, acked. After thinking through the logic a bit your solution
seems like the simplest fix.
Now, I didn't do _extensive_ testing but a quick compile and bootup of
the patch with CONFIG_KASAN_INLINE enabled has yet to throw any GFPs,
so take th
On Mon, Dec 31, 2018 at 12:08:54PM -0800, Paul E. McKenney wrote:
> On Sat, Dec 29, 2018 at 09:40:20PM -1000, Joey Pabalinas wrote:
> > On Sun, Dec 30, 2018 at 08:08:46AM +0100, Willy Tarreau wrote:
> > > Definitely! Same, I won't emit a patch just for this, Paul a
On Sun, Dec 30, 2018 at 08:08:46AM +0100, Willy Tarreau wrote:
> Definitely! Same, I won't emit a patch just for this, Paul already queued it.
Yeah, not that big a deal :)
Reviewed-by: Joey Pabalinas
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
n with a capitalized "The" for
consistency?
> /* some archs (at least aarch64) don't expose the regular syscalls anymore by
> * default, either because they have an "_at" replacement, or because there
> are
> * more modern alternatives. For now we'd rath
r10", "r11", "memory", "cc" \
> );\
> _ret; \
> })
> @@ -290,7 +290,7 @@ struct stat {
> : "=a" (_ret) \
> : "r"(_arg1), "r"(_arg2), "r"(_arg3), \
> "0"(_num) \
> - : "rcx", "r8", "r9", "r10", "r11", "memory", "cc"
> \
> + : "rcx", "r8", "r9", "r10", "r11", "memory", "cc" \
> );\
> _ret; \
> })
> --
> 2.9.0
>
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ing I do myself, it requires a lot of up front work.
I don't think it's realistic to expect others to be doing this
instead of just subscribing to the topic lists.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
en I have some free time I'm just going to give it another go with
the public-inbox conversion.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
then actually needed.
>
> Fix this by only pinning what are needed for doing this write I/O.
>
> Signed-off-by: Long Li
> Cc: sta...@vger.kernel.org
Looks sane to me.
Reviewed-by: Joey Pabalinas
> ---
> fs/cifs/file.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-
less incomplete messages with this delay than without
>* it, but we don't know why. Help is appreciated.
>*/
> - udelay(100);
> + usleep_range(0, 100);
>
> return IRQ_HANDLED;
> }
> --
> 2.7.4
>
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Sun, Dec 16, 2018 at 02:55:05PM -0500, Konstantin Ryabitsev wrote:
> On Sun, Dec 16, 2018 at 09:21:35AM -1000, Joey Pabalinas wrote:
> > That was my first attempt, but the ducumentation for the public-inbox
> > format is sort of terrible,
>
> I'm surprised you think
On Sun, Dec 16, 2018 at 02:46:49PM -0500, Konstantin Ryabitsev wrote:
> On Sun, Dec 16, 2018 at 09:06:39AM -1000, Joey Pabalinas wrote:
> > I spent a lot of time trying to find an LKML archive in Maildir format
> > that I could use for local searches with nutmuch or something,
On Sun, Dec 16, 2018 at 11:17:34AM -0800, Joe Perches wrote:
> On Sun, 2018-12-16 at 09:06 -1000, Joey Pabalinas wrote:
> > I spent a lot of time trying to find an LKML archive in Maildir format
> > that I could use for local searches with nutmuch or something, but all
> > th
epos with that many files, hah.
Open to suggestions, thanks!
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ports zram idle page writeback feature.
Revisions look good to me. Will also try to give it some testing this
week.
Reviewed-by: Joey Pabalinas
> * Admin can define what is idle page "no access since X time ago"
> * Admin can define when zram should writeback them
> * Admin can de
On Sun, Dec 02, 2018 at 12:02:54PM +0300, Alexey Dobriyan wrote:
> Empty function will be inlined so asmlinkage doesn't do anything.
Yes, that is an example of a perfect explanation to have in the
commit message :) Ack from me after that addition.
Acked-by: Joey Pabalinas
--
Chee
ine asmlinkage void dump_stack(void)
> +static inline void dump_stack(void)
> {
> }
>
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
> CC: Peter Zijlstra
> CC: linux-kernel@vger.kernel.org
Ack, earlier assignments in the function like:
if (nr_running > 1)
*overload = true;
use `= true`, so this change keeps things consistent.
Reviewed-by: Joey Pabalinas
> ---
> kernel/sched/fair.c |
On Fri, Nov 30, 2018 at 08:26:30PM -0500, Yangtao Li wrote:
> We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
> such a macro,so remove BINDER_DEBUG_ENTRY.
>
> Signed-off-by: Yangtao Li
Good catch.
Reviewed-by: Joey Pabalinas
On Fri, Nov 30, 2018 at 08:2
On Wed, Nov 28, 2018 at 11:20:32PM +0100, Sebastian Andrzej Siewior wrote:
> Start refactoring __fpu__restore_sig() by inlining
> copy_user_to_fpregs_zeroing().
>
> Signed-off-by: Sebastian Andrzej Siewior
Reviewed-by: Joey Pabalinas
--
Cheers,
Joey Pabalinas
signature.asc
Desc
On Wed, Nov 28, 2018 at 11:05:49PM +0100, Christian Brauner wrote:
> On Wed, Nov 28, 2018 at 11:45:34AM -1000, Joey Pabalinas wrote:
> > On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote:
> > > + if (info) {
> > > + ret = __copy_siginfo_
opagate up the errors from
__copy_siginfo_from_user()?
Granted, I admit that -E2BIG is kind of weird to return, but -EFAULT seems like
a
fairly sane error.
Or is there some reason it's more useful to just return -EINVAL for all of the
failure cases here?
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Wed, Nov 28, 2018 at 06:32:27AM +, David CARLIER wrote:
> Bad entrance with bad idea I m afraid :-) sorry for the noise.
We all start somewhere, no worries :)
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote:
> > +def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1):
> > +fmt = '>HII IIH16sHBHH'
> > +cmd = struct.pack(fmt,
> > +
lf, pcrs, bank_alg = TPM2_ALG_SHA1,
> + digest_alg = TPM2_ALG_SHA1):
> +x = []
Is there a reason for using `'\0' * 16` there instead of just 0?
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ROP,
> > };
>
> I'm with Matthew, I'd prefer not: the first looks a more readable,
> less cluttered comment to me than the second: this is just an arg
> to an internal helper in mm/filemap.c, itself not kernel-doc'ed.
>
> But the comment is not there for me: if consensus is that the
> second is preferable, then sure, we can change it over.
For something which is internal to a single file I strongly prefer
the first as well.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Tue, Nov 27, 2018 at 11:13:27AM +0900, Minchan Kim wrote:
> On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote:
> > On Mon, Nov 26, 2018 at 05:28:11PM +0900, Minchan Kim wrote:
> > > + strlcpy(mode_buf, buf, sizeof(mode_buf));
> > > + /* ignore tra
On Mon, Nov 26, 2018 at 04:27:50PM -0500, Steven Rostedt wrote:
> On Mon, 26 Nov 2018 00:02:07 -1000
> Joey Pabalinas wrote:
>
> > On Wed, Nov 21, 2018 at 08:27:16PM -0500, Steven Rostedt wrote:
> > > The static inline function task_curr_ret_stack() is unused, remove it.
h -O1 (making sure to use the target
variable so it isn't optimized out) and compare the assembly generated
with and without that assignment.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Sun, Nov 25, 2018 at 11:47:37PM -1000, Joey Pabalinas wrote:
> > + if ((mode & IDLE_WRITEBACK &&
> > + !zram_test_flag(zram, index, ZRAM_IDLE)) &&
> > + (mode & HUGE_WRITEBACK &&
> > +
arrier_data(s);
> }
> EXPORT_SYMBOL(memzero_explicit);
Could you elaborate on the optimization that this patch performs?
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
=
-1`?
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
g if there might be other useful
information which could be passed back to the caller instead. I can't
immediately think of any such information, though, so it's possible I'm
just daydreaming :)
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
that definitely makes sense.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
t; from syscall-exit-stops using PTRACE_GETEVENTMSG request.
Is there an advantage to using two constants instead of a single
sys_exit bit (set/unset for syscall-exit-stop/syscall-enter-stop)?
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ichael Ellerman
> Signed-off-by: Sasha Levin
Acked-by: Joey Pabalinas
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
en source code is
definitely intended for the public as well.
If I post an ad targeted at dog owners in my local town hall, it
doesn't mean it's not intended for the public. Even though it is
only for dog owners (or those who wish to be), it is still
available freely to the general public.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
sider "private information".
> How do you reconcile working on a public project while keeping email
> address secret?
This is a little more delicate, and I admit that I can't really
think of any real solutions for this part...
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
community, to
> escalate the rhetoric --- either in the pro- or anti- CoC direction,
> and whether on mailing lists, github comment threads, Twitter, or
> Reddit --- is not helpful.
I completely agree with this; very eagerly seconded.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
wanted to say "thank you" for dealing with all
our trite crap over the years and in the years to come. Sure, maybe you haven't
always been right, but you are human too, just like the rest of us, and, in
my humble opinion, don't need to feel this ashamed for trying to run this ship
as best you knew how.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
wanted to say "thank you" for dealing with all
our trite crap over the years and in the years to come. Sure, maybe you haven't
always been right, but you are human too, just like the rest of us, and, in
my humble opinion, don't need to feel this ashamed for trying to run this ship
as best you knew how.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Thu, Aug 09, 2018 at 01:39:16PM -1000, Joey Pabalinas wrote:
> The firmware found in the touch screen of the Surface Pro 3 is slightly
> buggy and occasionally doesn't send lift off reports for contacts; add
> MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the mi
devices, but I don't
> think it should be done for all devices.
>
> All in all, it won't change much.
Hm, that sounds sane. I'll do a bit more research on this and see if
restricting it to just Win8 devices is simple enough to be worthwhile.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
d a device that required this, so you are probably
> the lucky one :)
Ah, you are completely right. After giving that pdf a read over
I will definitely be dropping this patch from the v2.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
hich series on top of the other, but someone between us will
> have to do it :)
Somehow also missed this reply... I guess I messed up my LKML
filters somewhere. Noted, thanks for the review; I'll check
your trees for the refactor when (if) I do my v2.
--
Cheers,
Joey Pabalinas
sign
cial
case would be a better way to handle it, so I'll do a bit more research
on the quirk thing and then revise my patches (assuming they end up
as something still worth sending). Appreciate the comments, thanks.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
Elide lone `else` cases and replace `else if` clauses
with plain `if` conditionals when they occur immediately
after return statements.
Signed-off-by: Joey Pabalinas
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index
The firmware found in the touch screen of the Surface Pro 3 is slightly
buggy and occasionally doesn't send lift off reports for contacts; add
MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed
reports.
Signed-off-by: Joey Pabalinas
1 file changed, 2 insertions(+), 1 del
Avoid processing reports containing invalid values to reduce
multitouch input stutter.
Signed-off-by: Joey Pabalinas
1 file changed, 9 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index c0654db0b736543ca0..08b50e5908cecdda66 100644
--- a/drivers/hid
Pro 3 for a
couple months without any problems, as well as being run in my
Arch Linux AUR kernel package [1] without a single complaint
so far.
[1] https://aur.archlinux.org/packages/linux-surfacepro3-git
Joey Pabalinas (4):
HID: multitouch: add MT_QUIRK_NOT_SEEN_MEANS_UP to MT_CLS_WIN_8 quirks
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial
protocol, so avoid setting `td->serial_maybe = true;` in order to avoid
an unnecessary mt_post_parse_default_settings() call
Signed-off-by: Joey Pabalinas
1 file changed, 3 insertions(+), 1 deletion(-)
diff --gi
On Thu, Jul 26, 2018 at 02:55:11PM -1000, Joey Pabalinas wrote:
> I thought the exact same thing; opened the thread and was a bit confused
> at first. In my opinion the name feels slightly misleading.
Oooh, reading more of the thread I see there is some fun wordplay going
on which I didn&#
ot;error fs". ;-)
I thought the exact same thing; opened the thread and was a bit confused
at first. In my opinion the name feels slightly misleading.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
The firmware found in the touch screen of the Surface Pro 3 is slightly
buggy and occasionally doesn't send lift off reports for contacts; add
MT_QUIRK_NOT_SEEN_MEANS_UP to .quirks to compensate for the missed
reports.
Signed-off-by: Joey Pabalinas
1 file changed, 2 insertions(+), 1 del
Elide lone `else` cases and replace `else if` clauses
with plain `if` conditionals when they occur immediately
after return statements.
Signed-off-by: Joey Pabalinas
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index
The Surface Pro 3 firmware doesn't reliably send contact lift off
reports nor handle invalid report values gracefully.
To reduce touchscreen input jitter:
- add MT_QUIRK_NOT_SEEN_MEANS_UP to the MT_CLS_WIN_8
- drop invalid report values
Joey Pabalinas (4):
HID: multitouch
The HID_GROUP_MULTITOUCH_WIN_8 group never needs to check for the serial
protocol, so avoid setting `td->serial_maybe = true;` in order to avoid
an unnecessary mt_post_parse_default_settings() call
Signed-off-by: Joey Pabalinas
1 file changed, 3 insertions(+), 1 deletion(-)
diff --gi
Avoid processing reports containing invalid values to reduce
multitouch input stutter.
Signed-off-by: Joey Pabalinas
1 file changed, 9 insertions(+)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index c0654db0b736543ca0..08b50e5908cecdda66 100644
--- a/drivers/hid
On Tue, May 22, 2018 at 09:59:02PM +0900, Masahiro Yamada wrote:
>
> Applied to linux-kbuild. Thanks!
Cheers :)
--
Joey Pabalinas
signature.asc
Description: PGP signature
inline the
arch generation into the surrounding conditional.
Signed-off-by: Joey Pabalinas
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/scripts/tags.sh b/scripts/tags.sh
index 78e546ff689c2d5f40..e587610d149271171d 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -26,24 +26,
h the other find commands in the script.
The ' %f' was changed to '%f ' so that you don't get that weird leading
space; I couldn't think of a way this could break anything but I wanted
to be 100% sure instead of needing to make a v6, heh.
The commit message will definitely be fixed as well.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Tue, May 22, 2018 at 03:01:07PM +0900, Masahiro Yamada wrote:
> The commit log is wrong.
>
>
> 2018-05-18 20:56 GMT+09:00 Joey Pabalinas :
> > Parsing `ls` is fragile at best and _will_ fail when $tree
> > contains spaces.
>
> This statement is wrong.
>
Parsing `ls` is fragile at best and _will_ fail when $tree
contains spaces. Replace this with a find-generated string
and directly assign it to $ALLSOURCE_ARCHS; a subshell is
implied by $(), so `cd` doesn't affect the current working
directory.
Signed-off-by: Joey Pabalinas
1 file chang
hat is worth worrying
about here in my opinion either.
I'll use this in my v4 then, thanks.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
wanted to be sure this didn't surprise someone in the
future by squeezing the newlines into spaces.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ot;${tree}arch/" && find . -maxdepth 1 -type d |
> paste -sd' ')"
> ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS//[.\/]}"
> fi
If something like that if acceptable, I'll use that for the v4.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
directory.
Signed-off-by: Joey Pabalinas
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/scripts/tags.sh b/scripts/tags.sh
index 78e546ff689c2d5f40..e4aba2983f6272fc44 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -29,14 +29,12 @@ fi
ignore="$ignore ( -path ${tree}to
on ia64 m68k microblaze mips
> nds32 nios2 openrisc parisc powerpc riscv s390 sh sparc um unicore32 x86
> xtensa
However, if there really is no reason for that being there, I
have no complaints against fixing it. I'll send a v3 in a bit.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
Parsing `ls` is fragile at best and _will_ fail when $tree
contains spaces. Replace this with a glob-generated string
and directly assign it to $ALLSOURCE_ARCHS; a subshell is
implied by $(), so `cd` doesn't affect the current working
directory.
Signed-off-by: Joey Pabalinas
1 file chang
On Tue, May 15, 2018 at 02:13:11PM -1000, Joey Pabalinas wrote:
> and directly assign it to $ALLSOURCE_ARCHS; use a subshell
> so `cd` doesn't affect the current working directory.
Whoops, turns out the inner `()` isn't needed, so going to
revise and send a v2.
--
Cheers
Parsing `ls` is fragile at best and _will_ fail when $tree
contains spaces. Replace this with a glob-generated string
and directly assign it to $ALLSOURCE_ARCHS; use a subshell
so `cd` doesn't affect the current working directory.
Signed-off-by: Joey Pabalinas
1 file changed, 1 insertion(
I do end up seeing something I can improve will definitely cook up
a patch and send it in, thanks again!
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
On Wed, Apr 25, 2018 at 08:09:31AM +0200, Greg Kroah-Hartman wrote:
> Ah, never seen that before. Just use the defaults and you should be
> fine. Having the normal diffstat is good.
Yes, will definitely do from now on.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
ion.
Sorry about all the mess; I mostly have only sent single
patches before this.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
Correct misaligned indentation and remove extraneous spaces.
Signed-off-by: Joey Pabalinas
---
drivers/tty/nozomi.c | 74 ++--
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index
Replace snprint() with strscpy() and use min_t() instead of
the conditional operator to clamp buffer length.
Signed-off-by: Joey Pabalinas
---
drivers/tty/nozomi.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty
MAX : len__`
with `min_t(u32, len__, TMP_BUF_MAX)` and function calls like
snprintf(tbuf, ..., "%s", ...). with strscpy(tbuf, ..., ...).
- Correct inconsistently indented lines and extraneous whitespace.
CC: Greg Kroah-Hartman
CC: Arnd Bergmann
CC: Jiri Slaby
Joey Pabalin
about that.
Going to resend.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
Replace snprint() with strscpy() and use min_t() instead of
the conditional operator to clamp buffer length.
Signed-off-by: Joey Pabalinas
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index b57b35066ebea94639..f26bf1d1e9ee0e74eb
MAX : len__`
with `min_t(u32, len__, TMP_BUF_MAX)` and function calls like
snprintf(tbuf, ..., "%s", ...). with strscpy(tbuf, ..., ...).
- Correct inconsistently indented lines and extraneous whitespace.
CC: Greg Kroah-Hartman
CC: Arnd Bergmann
CC: Jiri Slaby
Joey Pabalin
Correct misaligned indentation and remove extraneous spaces.
Signed-off-by: Joey Pabalinas
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644
--- a/drivers/tty/nozomi.c
+++ b/drivers
On Mon, Apr 23, 2018 at 10:51:31AM +0200, Greg Kroah-Hartman wrote:
> Something is really odd here, look at what is in your changelog above :(
>
> Same for all of these patches. Can you please fix up and resend?
Ah whoops, will do.
--
Cheers,
Joey Pabalinas
signature.asc
Descrip
> __VMALLOC_BASE_L4
> arch/x86/include/asm/pgtable_64_types.h:108: #define __VMALLOC_BASE_L4
> 0xc900
__VMALLOC_BASE_L4 would be better written as 0xc900UL, which would
indeed shut up sparse.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
patch [2] and apply it directly to
the v0.5.2 release to suppress the deluge of warnings (-Wpointer-arith
is off by defaultl so no need to change any of you configurations).
[1] https://lkml.org/lkml/2018/4/10/923
[2] https://patchwork.kernel.org/patch/10334353/raw/
--
Cheers,
Joey Pab
Li
CC: Joey Pabalinas
CC: Luc Van Oostenryck
Signed-off-by: Joey Pabalinas
Signed-off-by: Luc Van Oostenryck
5 files changed, 64 insertions(+), 2 deletions(-)
diff --git a/evaluate.c b/evaluate.c
index b96696d3a51396800a..8f07d08cf5b494f8f0 100644
--- a/evaluate.c
+++ b/evaluate.c
@@ -2169,7
On Tue, Apr 10, 2018 at 12:09:44PM -1000, Joey Pabalinas wrote:
> Not a problem; I will rebase it on the v0.5.2-rc1 tag and
> take out the function pointer test-case.
Sorry, I meant v0.5.2, heh. Sending the v4 now.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
nters.
> So, for the master tree, I propose to use a version with these
> tests removed:
> git://github.com/lucvoo/sparse-dev.git pointer-arith-v3
Not a problem; I will rebase it on the v0.5.2-rc1 tag and
take out the function pointer test-case.
--
Cheers,
Joey Pabalinas
s
Torvalds
CC: Martin Uecker
CC: Al Viro
CC: Christopher Li
CC: Joey Pabalinas
CC: Luc Van Oostenryck
Signed-off-by: Joey Pabalinas
Signed-off-by: Luc Van Oostenryck
evaluate.c | 6 --
lib.c| 2 ++
lib.h| 1 +
sparse.1
On Mon, Apr 09, 2018 at 12:51:01PM -1000, Joey Pabalinas wrote:
> Ah, so should I include that change in the patch itself when I make a V3?
Sending a v3 now incorporating the suggestions.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
case, I don't think this part should belong to the man page.
Also have no problem eliding this section if no one else has any
good arguments for keeping it.
--
Cheers,
Joey Pabalinas
signature.asc
Description: PGP signature
hold 0 or -ENOENT as a return value or an
`unsigned nmemb` meant to refer to the number of valid
members in some arbitrary array.
Change relevant variable / return types from int to bool and
prefer a true / false value for predicate expressions versus
a plain 1 / 0 value.
Signed-off-by: Joey
3c8ba0d61d04ced9f8 (kernel.h: Retain constant expression
output for max()/min()).
Update the manpage to document the new flag.
CC: Kees Cook
CC: Linus Torvalds
CC: Martin Uecker
CC: Al Viro
CC: Christopher Li
CC: Joey Pabalinas
CC: Luc Van Oostenryck
Signed-off-by: Joey Pabalinas
Signed-off-by: Luc Van
On Mon, Mar 26, 2018 at 01:52:26AM +0900, Masahiro Yamada wrote:
> I want to see Kconfig improvements in a bigger picture.
>
> The changes below are noise.
That's understandable; I do agree that nothing here is _fundamentally_
broken at all, so no worries.
--
Cheers,
Improve code clarity by renaming identifiers and reorganizing
function control flow.
Signed-off-by: Joey Pabalinas
1 file changed, 92 insertions(+), 91 deletions(-)
1 file changed, 76 insertions(+), 90 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index
nes and extraneous whitespace.
CC: Greg Kroah-Hartman
CC: Arnd Bergmann
CC: Jiri Slaby
CC: Tomasz Kramkowsk
Joey Pabalinas (4):
tty/nozomi: cleanup DUMP() macro
tty/nozomi: fix inconsistent indentation
tty/nozomi: improve code readability and style
tty/nozomi: refactor conditional statem
Correct misaligned indentation and remove extraneous spaces.
Signed-off-by: Joey Pabalinas
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index f26bf1d1e9ee0e74eb..0fcb4db721d2a42f08 100644
--- a/drivers/tty/nozomi.c
+++ b/drivers
Replace snprint() with strscpy() and use max_t() instead of
the conditional operator.
Signed-off-by: Joey Pabalinas
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index b57b35066ebea94639..f26bf1d1e9ee0e74eb 100644
--- a/drivers/tty
Reduce unnecessarily deep nesting of blocks and simplify
control flow (e.g. "if/else" constructs changed to "if/return"
and single case "switch" statements changed to "if" conditionals
where possible).
Signed-off-by: Joey Pabalinas
1 file changed, 52 in
iri Slaby
CC: Tomasz Kramkowsk
Joey Pabalinas (4):
tty/nozomi: cleanup DUMP() macro
tty/nozomi: fix inconsistent indentation
tty/nozomi: improve code readability and style
tty/nozomi: refactor conditional statements
drivers/tty/nozomi.c | 362 +-
1 - 100 of 130 matches
Mail list logo
