On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote:
> +     if (info) {
> +             ret = __copy_siginfo_from_user(sig, &kinfo, info);
> +             if (unlikely(ret))
> +                     goto err;

What's the reason you don't propagate up the errors from 
__copy_siginfo_from_user()?
Granted, I admit that -E2BIG is kind of weird to return, but -EFAULT seems like 
a
fairly sane error.

Or is there some reason it's more useful to just return -EINVAL for all of the
failure cases here?

-- 
Cheers,
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature

Reply via email to