Re: [PATCH 3/3] MAINTAINERS: Update AT91 entries

2017-01-27 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 28, 2017, at 1:00 AM, Alexandre Belloni > wrote: > > On 28/01/2017 at 00:51:13 +0800, Jean-Christophe Plagniol-Villard wrote: >> this does not mean I do not follow the ML >> > > That's not what I'm implying. Many people are following var

Re: [PATCH 3/3] MAINTAINERS: Update AT91 entries

2017-01-27 Thread Jean-Christophe PLAGNIOL-VILLARD
from the maintainers >> >> Also, merge both AT91 pinctrl drivers entries. >> >> Cc: Jean-Christophe Plagniol-Villard >> Signed-off-by: Alexandre Belloni > > Yes: > > Acked-by: Nicolas Ferre > > Thanks, regards, > >> --- >> Also, as po

Re: [PATCH] MAINTAINERS: update DT binding doc locations

2015-11-14 Thread Jean-Christophe PLAGNIOL-VILLARD
7;t want to be copied on all of bindings/display/. So I've > dropped them. > > Reported-by: Thierry Reding > Cc: Thierry Reding > Cc: Jianwei Wang > Cc: Alison Wang > Cc: Philipp Zabel > Cc: Mark Yao > Cc: Benjamin Gaignard > Cc: Vincent Abriou > Cc: Jean

Re: [PATCH] pinctrl: at91: fix null pointer dereference

2015-07-13 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jul 13, 2015, at 9:00 PM, Ludovic Desroches > wrote: > > On Mon, Jul 13, 2015 at 02:14:51PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: >> >>> On Jul 3, 2015, at 12:06 AM, David Dueck wrote: >>> >>> Not all gpio banks are necessaril

Re: [PATCH] pinctrl: at91: fix null pointer dereference

2015-07-13 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jul 3, 2015, at 12:06 AM, David Dueck wrote: > > Not all gpio banks are necessarily enabled, in the current code this can > lead to null pointer dereferences. > > [ 51.13] Unable to handle kernel NULL pointer dereference at virtual > address 0058 > [ 51.13] pgd = dee04000

Re: Device Tree Blob (DTB) licence

2015-05-30 Thread Jean-Christophe PLAGNIOL-VILLARD
> On May 29, 2015, at 11:10 PM, Enrico Weigelt, metux IT consult > wrote: > > Am 29.05.2015 um 05:31 schrieb Rob Landley: > > >> What's the big deal with having DTS/DTB under GPL ? >> >> One problem is that there's no such thing as "The GPL" anymore. > > There are different versions. The ker

Re: [PATCH 35/35 linux-next] pinctrl: constify of_device_id array

2015-03-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On 20:59 Mon 16 Mar , Fabian Frederick wrote: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > > Signed-off-by: Fabian Frederick Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > drivers/pinctrl/bcm

Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

2015-03-04 Thread Jean-Christophe PLAGNIOL-VILLARD
been created to address this > problem. > > Move gpiochip_lock/unlock_as_irq calls into > irq_request/release_resources functions to prevent using a gpio as an irq > if the gpiochip_lock_as_irq call failed. > > Signed-off-by: Boris Brezillon Linus Acked-by: Jean-Christoph

Re: [PATCH] ARM: at91/dt: add uart0 to sama5d3 DT

2015-03-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:26 Wed 04 Mar , Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre please keep in Cc for at91 related work Best Regards, J. > --- > arch/arm/boot/dts/sama5d3.dtsi | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/ar

Re: [PATCH] ARM: at91: pm: fix SRAM allocation

2015-03-02 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Mar 2, 2015, at 6:57 PM, Alexandre Belloni > wrote: > > On 02/03/2015 at 18:50:27 +0800, Jean-Christophe PLAGNIOL-VILLARD wrote : >> >>> On Mar 2, 2015, at 6:42 PM, Alexandre Belloni >>> wrote: >>> >>> On some platforms, th

Re: [PATCH] ARM: at91: pm: fix SRAM allocation

2015-03-02 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Mar 2, 2015, at 6:42 PM, Alexandre Belloni > wrote: > > On some platforms, there are multiple SRAM nodes defined in the device tree > but > some of them are disabled, leading to allocation failure. Try to find the > first > enabled SRAM node and allocate from it. > > Signed-off-by: Alex

Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

2015-02-26 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Feb 26, 2015, at 9:32 PM, Nicolas Ferre wrote: > > Le 08/02/2015 19:23, Boris Brezillon a écrit : >> The gpiochip_lock_as_irq call can fail and return an error, while the >> irq_startup is not expected to fail (returns an unsigned int which is not >> checked by irq core code). >> >> irq_re

Re: [PATCH] net: cadence: Enable MACB driver for ARM64

2015-02-24 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Feb 24, 2015, at 3:45 PM, Michal Simek wrote: > > This driver is used on new Xilinx ZynqMP SoC. > > Signed-off-by: Michal Simek > Acked-by: Sören Brinkmann > --- > > drivers/net/ethernet/cadence/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers

Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

2015-02-19 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Feb 9, 2015, at 10:50 PM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > >> On Feb 9, 2015, at 2:23 AM, Boris Brezillon >> wrote: >> >> The gpiochip_lock_as_irq call can fail and return an error, while the >> irq_startup is not expected to

Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods

2015-02-09 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Feb 9, 2015, at 2:23 AM, Boris Brezillon > wrote: > > The gpiochip_lock_as_irq call can fail and return an error, while the > irq_startup is not expected to fail (returns an unsigned int which is not > checked by irq core code). > > irq_request/release_resources functions have been create

Re: [PATCH] ARM: /proc/atags: Export also for DT

2015-01-28 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 28, 2015, at 3:19 PM, Pavel Machek wrote: > > Hi! > >>> In other words, what prevents someone from creating, say, a custom >>> minimal Barebox version that sits on top of the existing N900 >>> bootloader? Wouldn't that provide a much better user experience? >> >> I do agree with Ni

Re: [PATCH] ARM: /proc/atags: Export also for DT

2015-01-28 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 28, 2015, at 9:58 PM, Pali Rohár wrote: > > On Wednesday 28 January 2015 01:50:33 Tony Lindgren wrote: >> * Russell King - ARM Linux [150127 > 09:51]: >>> We _could_ (and have in the past) turned round and refused >>> to support these kinds of hacks - which IMHO is quite a >>> reasona

Re: [PATCH] ARM: /proc/atags: Export also for DT

2015-01-28 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 28, 2015, at 11:57 PM, Rob Herring wrote: > > On Wed, Jan 28, 2015 at 8:33 AM, Nicolas Pitre wrote: >> On Wed, 28 Jan 2015, Pali Rohár wrote: >> >>> On Wednesday 28 January 2015 01:50:33 Tony Lindgren wrote: On omaps, the bootrom passes the bootreason in r1 to the bootloader

Re: [PATCH] ARM: /proc/atags: Export also for DT

2015-01-27 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 28, 2015, at 10:07 AM, Nicolas Pitre wrote: > > On Tue, 27 Jan 2015, Russell King - ARM Linux wrote: > >> On Tue, Jan 27, 2015 at 04:34:47PM -0500, Nicolas Pitre wrote: >>> On Tue, 27 Jan 2015, Russell King - ARM Linux wrote: Or we pass both the ATAGs and wrapped DT to the kernel

Re: [PATCH v2] ARM: at91: fix PM initialization for newer SoCs

2015-01-23 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 23, 2015, at 12:07 AM, Nicolas Ferre wrote: > > Newer SoCs: at91sam9x5, at91sam9n12, sama5d3 and sama5d4 embed a DDR > controller > and have a different PMC status register layout than the at91sam9g45. Create > another at91_sam9x5_pm_init() function to match this compatibility. > > Si

Re: [PATCH 1/6] ARM: at91: pm: rework cpu detection

2015-01-14 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 15, 2015, at 4:21 AM, Boris Brezillon > wrote: > > Hi Jean-Christophe, > > On Wed, 14 Jan 2015 20:14:12 +0100 > Jean-Christophe PLAGNIOL-VILLARD wrote: > >> On 22:23 Mon 12 Jan , Alexandre Belloni wrote: >>> Store SoC differenc

Re: [PATCH 1/6] ARM: at91: pm: rework cpu detection

2015-01-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:23 Mon 12 Jan , Alexandre Belloni wrote: > Store SoC differences in a struct to remove cpu_is_* usage. > > Signed-off-by: Alexandre Belloni > --- > arch/arm/mach-at91/pm.c | 54 > ++--- > 1 file changed, 33 insertions(+), 21 deletions(-) >

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-13 Thread Jean-Christophe PLAGNIOL-VILLARD
> On Jan 14, 2015, at 12:16 AM, Sascha Hauer wrote: > > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: I am worried that there is something in your reasoning that sort of assumes all pin controllers mux pins one-by-one and not in groups. How do we make it impossibl

Re: [PATCH 3/3] ARM: at91/tclib: mask interruptions at shutdown and probe

2014-08-19 Thread Jean-Christophe PLAGNIOL-VILLARD
Hi, This is a bit weird as the clock of the TC should be off and the irq free so this should never happened we need to investigate more why this append Best Regards, J. On Aug 20, 2014, at 6:07 AM, Gaël PORTAY wrote: > > Shutdown properly the timer counter block by masking i

Re: [PATCH] ARM: at91: spi: request all csgpio in spi probe

2014-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On Aug 1, 2014, at 12:48 AM, Alexandre Belloni wrote: > > On 01/08/2014 at 00:10:05 +0800, Jean-Christophe PLAGNIOL-VILLARD wrote : >>>>> While this solves the particular issue Jiří is seeing, this will not >>>>> solve the case where PA14 (CS0) is n

Re: [PATCH] ARM: at91: spi: request all csgpio in spi probe

2014-07-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 31, 2014, at 11:59 PM, Alexandre Belloni wrote: > On 29/07/2014 at 10:00:17 +0200, Boris Brezillon wrote : >> Hi Alexandre, >> >>> While this solves the particular issue Jiří is seeing, this will not >>> solve the case where PA14 (CS0) is not used by the spi driver at all. It >>> will r

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:06 Fri 04 Jul , Maxime Ripard wrote: > On Fri, Jul 04, 2014 at 09:14:43AM +0200, Boris BREZILLON wrote: > > On Fri, 4 Jul 2014 11:08:20 +0800 > > Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > > > > On Jul 3, 2014, at 10:59 PM, Maxime Ripa

Re: [PATCH 1/5] memory: add a driver for atmel ram controllers

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:19 Mon 07 Jul , Alexandre Belloni wrote: > > Atmel SoCs have one or multiple RAM controllers that need one or multiple > clocks > to run. > This driver handle those clocks. > > Signed-off-by: Alexandre Belloni > --- > .../devicetree/bindings/arm/atmel-at91.txt | 1 + > drive

Re: [PATCH 09/18] AT91: Call at91_register_devices in the board files

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:52 Thu 03 Jul , Maxime Ripard wrote: > Hi, > > On Thu, Jul 03, 2014 at 10:29:58PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > no do this at SoC level > > Since it has to be done at init_machine, I don't see any other easy > way to do this at

Re: [PATCH 3/5] ARM: at91/dt: sama5d3: define mpddr clock and ramc clocks

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:19 Mon 07 Jul , Alexandre Belloni wrote: > > Define the available clock for mprddr and take both mpddr_clk and ddrck in the > ram controller driver. > > Signed-off-by: Alexandre Belloni > --- > arch/arm/boot/dts/sama5d3.dtsi | 9 - > 1 file changed, 8 insertions(+), 1 deletion

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard wrote: > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: >>> +++ b/drivers/power/reset/at91-reset.c >>> @@ -0,0 +1,202 @@ >>> +/* >>> + * Atmel AT91 SAM9 SoCs reset code

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard wrote: > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: >>> +++ b/drivers/power/reset/at91-reset.c >>> @@ -0,0 +1,202 @@ >>> +/* >>> + * Atmel AT91 SAM9 SoCs reset code

Re: [PATCH 09/18] AT91: Call at91_register_devices in the board files

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
no do this at SoC level Best Regards, J. On Jul 3, 2014, at 10:14 PM, Maxime Ripard wrote: > > Make every board call the register_devices callback so that the devices > declared by the SoC are registered. > > Signed-off-by: Maxime Ripard > --- > arch/arm/mach-at91/board-afeb-9260v1.c | 2 ++

Re: [PATCH 04/18] AT91: Rework ramc mapping code

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
patch 4 and 18 what is the difference? Best Regards, J. On Jul 3, 2014, at 10:14 PM, Maxime Ripard wrote: > > Adapt the ramc mapping code to handle multiple ram controllers in the DT. > > Signed-off-by: Maxime Ripard > --- > arch/arm/mach-at91/setup.c | 26 ++ > 1 file

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
NACK On Jul 3, 2014, at 10:14 PM, Maxime Ripard wrote: > > Implement the reset behaviour of the various AT91 SoCS in drivers/power/reset. > > It used to be (and still is) located in arch/arm/mach-at91, and in order to > preserve bisectability is not removed yet, but every board should be con

Re: [PATCH 12/18] power: reset: Add AT91 poweroff driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:14 PM, Maxime Ripard wrote: > > Add a driver to handle the shutdown of the Atmel SoCs. This code used to be > (and still is) in arch/arm/mach-at91. We didn't removed it yet so that we can > convert all the boards to using this driver, before removing it entirely in a > se

Re: [GIT PULL] at91: DT for 3.16 #2

2014-05-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 20, 2014, at 1:50 PM, Olof Johansson wrote: > > On Wed, May 14, 2014 at 11:19:22AM +0200, Nicolas Ferre wrote: >> Arnd, Olof, Kevin, >> >> More DT material for AT91. Some fixes that apply on what was merged for 3.15 >> but that are not very critical. >> The other patches are feature add

Re: [PATCH] ARM: at91: remove ISI code for AT91SAM9263

2014-05-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On May 15, 2014, at 4:34 PM, Paul Bolle wrote: > > In v2.6.25 code was added for an Image Sensor Interface (ISI) for > AT91SAM9263. That code depended on the Kconfig macro > CONFIG_VIDEO_AT91_ISI and its MODULE variant. The related Kconfig symbol > has never been added to the tree. The net effe

Re: [PATCH] fbdev: fix possible NULL pointer derefernce

2014-04-16 Thread Jean-Christophe PLAGNIOL-VILLARD
On Apr 16, 2014, at 5:40 PM, Daeseok Youn wrote: > > The spec->modedb can be NULL by fb_create_modedb(). > > And also smatch says: > drivers/video/fbdev/core/fbmon.c:975 fb_edid_to_monspecs() error: > potential null dereference 'specs->modedb'. > (fb_create_modedb returns null) > > Signed-off

Re: [PATCH v5 4/9] at91: dt: Add at91sam9261 dt SoC support

2014-03-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:05 Mon 03 Mar , Jean-Jacques Hiblot wrote: > This patch adds support for the Device Tree on a sam9261-based platform > > Signed-off-by: Jean-Jacques Hiblot > --- > arch/arm/boot/dts/at91sam9261.dtsi | 740 > + > arch/arm/mach-at91/at91sam9261.c |

Re: [PATCH v5 6/9] at91: dt: sam9261: Device Tree support for the at91sam9261ek

2014-03-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:05 Mon 03 Mar , Jean-Jacques Hiblot wrote: > This patch implements a DTS to boot a at91sam9261ek with a dt-enabled > kernel (at91_dt_defconfig). > supported features are: > * dbgu > * lcdc > * usb host > * usb gadget, > * spi dataflash > * nand flash > * touchscreen > * leds > * user butt

Re: [PATCH for 3.14] ARM: at91: fix network interface ordering for sama5d36

2014-03-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On Mar 10, 2014, at 10:37 PM, Nicolas Ferre wrote: > From: Boris BREZILLON > > On the newly introduced sama5d36, Gigabit and 10/100 Ethernet network > interfaces are probed in a different order than for the sama5d35. > Moreover, users are accustomed to this order in bootloaders and backports >

Re: [PATCH] pinctrl: at91: add the config GPIO_OUTPUT_x

2014-03-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On Mar 11, 2014, at 2:54 PM, Yang, Wenyou wrote: > > >> -Original Message----- >> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com] >> Sent: Tuesday, March 11, 2014 12:16 PM >> To: Yang, Wenyou >> Cc: Jean-Christophe PLAGNIOL-VILLA

Re: [PATCH] pinctrl: at91: add the config GPIO_OUTPUT_x

2014-03-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On Mar 11, 2014, at 9:28 AM, Yang, Wenyou wrote: > Hi JC, > >> -Original Message- >> From: Yang, Wenyou >> Sent: Wednesday, March 05, 2014 1:32 PM >> To: Jean-Christophe PLAGNIOL-VILLARD >> Cc: linus.wall...@linaro.org; b.brezil...@overkiz.com; &

Re: [PATCH] pinctrl: at91: add the config GPIO_OUTPUT_x

2014-03-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On Mar 5, 2014, at 9:53 AM, Wenyou Yang wrote: > In order to support the pinctrl sleep state. As I said before NACK this is not the job of the pinctrl to describe gpio output or input state Best Regards, J. > > Signed-off-by: Wenyou Yang > --- > Hi Linus, > > The patch is based on branch:

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:37 Fri 07 Feb , Nicolas Ferre wrote: > On 07/02/2014 09:01, Jean-Christophe PLAGNIOL-VILLARD : > > On 09:35 Wed 05 Feb , Nicolas Ferre wrote: > >> Add DT file for new SAMA5D3 Xpained board. > >> This board is based on Atmel's SAMA5D36 Cortex-A5 SoC.

Re: [GIT PULL] at91: fixes for 3.14 #1

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:36 Fri 07 Feb , Nicolas Ferre wrote: > Arnd, Olof, Kevin, > > This is a first "fixes" series for AT91 on 3.14. > The content is only DT-related and quite boring. > I took the opportunity of this early "fixes" pull-request to collect > some Documentation patches that were lying around and

Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:06 Tue 21 Jan , Nicolas Ferre wrote: > On 21/01/2014 09:12, Bo Shen : > > Hi J, > > > > On 01/21/2014 01:49 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> On 11:39 Mon 20 Jan , Bo Shen wrote: > >>> Hi J, > >>> > >>&

Re: [PATCH v2 07/12] at91: dt: smc: Added smc bus driver

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:31 Thu 09 Jan , Jean-Jacques Hiblot wrote: > The EBI/SMC external interface is used to access external peripherals (NAND > and Ethernet controller in the case of sam9261ek). Different configurations > and > timings are required for those peripherals. This bus driver can be used to > setu

Re: [PATCH v2] ARM: at91: add Atmel's SAMA5D3 Xplained board

2014-02-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:35 Wed 05 Feb , Nicolas Ferre wrote: > Add DT file for new SAMA5D3 Xpained board. > This board is based on Atmel's SAMA5D36 Cortex-A5 SoC. > > Signed-off-by: Nicolas Ferre > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 233

Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter

2014-01-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:39 Mon 20 Jan , Bo Shen wrote: > Hi J, > > On 01/18/2014 01:20 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 10:59 Fri 17 Jan , Bo Shen wrote: > >>In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS > >>is only 7. So, fix it for

Re: [PATCH 1/2] USB: at91: fix the number of endpoint parameter

2014-01-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:59 Fri 17 Jan , Bo Shen wrote: > In sama5d3 SoC, there are 16 endpoints. As the USBA_NR_ENDPOINTS > is only 7. So, fix it for sama5d3 SoC using the udc->num_ep. > > Signed-off-by: Bo Shen > --- > > drivers/usb/gadget/atmel_usba_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH 3/3] Binding: atmel-wm8904: add option to choose clock

2014-01-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:25 Tue 14 Jan , Bo Shen wrote: > Add the option to choose clock output on which pin connect to SSC. > Default is on TK pin to SSC, add clk_from_rk_pin option, the clock > is on RK pin to SSC. > > Signed-off-by: Bo Shen > --- > > Documentation/devicetree/bindings/sound/atmel-wm8904.txt

Re: [PATCH v2 09/12] at91: dt: sam9261: Pinmux DT entries for the SMC/EBI interface

2014-01-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:31 Thu 09 Jan , Jean-Jacques Hiblot wrote: > Signed-off-by: Jean-Jacques Hiblot > --- > arch/arm/boot/dts/at91sam9261.dtsi | 54 > ++ > 1 file changed, 54 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9261.dtsi > b/arch/arm/boot/dts/at91s

Re: [PATCH v2 01/12] at91: dt: Add at91sam9261 dt SoC support

2014-01-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:01 Tue 14 Jan , Nicolas Ferre wrote: > On 09/01/2014 13:31, Jean-Jacques Hiblot : > > This patch adds the basics to support the Device Tree on a sam9261-based > > platform > > > > Signed-off-by: Jean-Jacques Hiblot > > --- > > arch/arm/boot/dts/at91sam9261.dtsi | 476 > >

Re: [PATCH v2 12/12] at91: dt: sam9261: Added DM9000 in the device tree

2014-01-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:31 Thu 09 Jan , Jean-Jacques Hiblot wrote: > Signed-off-by: Jean-Jacques Hiblot > --- > arch/arm/boot/dts/at91sam9261ek.dts | 32 > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/at91sam9261ek.dts > b/arch/arm/boot/dts/at91sam9261e

Re: [PATCH v2 03/12] at91: dt: sam9261: Added support for the lcd display

2014-01-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:07 Thu 09 Jan , boris brezillon wrote: > On 09/01/2014 13:31, Jean-Jacques Hiblot wrote: > >Signed-off-by: Jean-Jacques Hiblot > >--- > > arch/arm/boot/dts/at91sam9261.dtsi | 37 > > - > > arch/arm/boot/dts/at91sam9261ek.dts | 31 +++

Re: [PATCH 1/2] ARM: AT91: PIT: Remove irq handler when clock event is unused

2013-12-20 Thread Jean-Christophe PLAGNIOL-VILLARD
ACK On Dec 20, 2013, at 6:45 PM, Sebastian Andrzej Siewior wrote: > From: Benedikt Spranger > > Setup and remove the interrupt handler in clock event mode selection. > This avoids calling the (shared) interrupt handler when the device is > not used. > > Signed-off-by: Benedikt Spranger > Sig

Re: [PATCH] ARM: at91: remove AT91_PROGRAMMABLE_CLOCKS configuration option

2013-12-13 Thread Jean-Christophe PLAGNIOL-VILLARD
s option is not selected, it causes certain drivers to fail > to build. We simply remove this option instead of adding code just > to build a workaround. > > Signed-off-by: Nicolas Ferre Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > Olof, Kevin, > > This

Re: [PATCH v3] video: add OpenCores VGA/LCD framebuffer driver

2013-11-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 06:34 Fri 22 Nov , Stefan Kristiansson wrote: > This adds support for the VGA/LCD core available from OpenCores: > http://opencores.org/project,vga_lcd > > The driver have been tested together with both OpenRISC and > ARM (socfpga) processors. > > Signed-off-by: Stefan Kristiansson Tomi

Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver

2013-11-22 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:03 Wed 20 Nov , ivan.khoronzhuk wrote: > On 11/20/2013 08:21 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >> + the chip select signal. > >> + Minimum value is 1 (0 treated as 1). > >> + > >> +- ti

Re: [PATCH 2/2] memory: ti-aemif: add bindings for AEMIF driver

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
> + the chip select signal. > + Minimum value is 1 (0 treated as 1). > + > +- ti,cs-wsetup: write setup width, ns > + Time between the beginning of a memory cycle > + and the

Re: [PATCH 8/9] ARM: at91/dt: add new at91rm9200ek_mmc board

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:31 Wed 20 Nov , boris brezillon wrote: > On 20/11/2013 16:02, Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 14:37 Wed 28 Aug , Boris BREZILLON wrote: > >>Add a new at91rm9200ek_mmc board (based on at91rm9200ek board) which enables > >>mmc0/slot0. > &g

Re: [PATCH 5/9] ARM: at91/dt: add mmc0 slot0 support to at91rm9200ek board

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:14 Wed 20 Nov , boris brezillon wrote: > On 20/11/2013 15:59, Jean-Christophe PLAGNIOL-VILLARD wrote: > >On 13:06 Wed 28 Aug , Boris BREZILLON wrote: > >>Add slot0 of mmc0 pinctrl pins definitions: > >> - detect pin > >> - write protect pin &

Re: [PATCH 8/9] ARM: at91/dt: add new at91rm9200ek_mmc board

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:37 Wed 28 Aug , Boris BREZILLON wrote: > Add a new at91rm9200ek_mmc board (based on at91rm9200ek board) which enables > mmc0/slot0. no for multiple dts this need to handle at user space level Best Regards, J. > > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/at91rm9200ek_

Re: [PATCH 3/9] ARM: at91/dt: add usb1 vbus and pullup pins

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:04 Wed 28 Aug , Boris BREZILLON wrote: > Add vbus and pullup pinctrl definitions. > Request the vbus and pullup pins in usb1 node. > > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/at91rm9200ek.dts | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/

Re: [PATCH 1/9] ARM: at91/dt: add rm9200 spi0 chip select pins definitions

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:02 Wed 28 Aug , Boris BREZILLON wrote: > Add spi0 cs pinctrl pins definitions. > > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/at91rm9200.dtsi | 20 > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm/boot/dts/at91rm9200.dtsi > b/arch/arm/

Re: [PATCH 5/9] ARM: at91/dt: add mmc0 slot0 support to at91rm9200ek board

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:06 Wed 28 Aug , Boris BREZILLON wrote: > Add slot0 of mmc0 pinctrl pins definitions: > - detect pin > - write protect pin > - enable slot0 pin: this pin is connected to an external switch which >enable mmc0 slot0 or spi dataflash connected to cs3 > > The mmc0 device is not enabled

Re: [PATCH 7/9] ARM: at91/dt: add i2c devices connected to at91rm9200ek board

2013-11-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:08 Wed 28 Aug , Boris BREZILLON wrote: > Signed-off-by: Boris BREZILLON > --- > arch/arm/boot/dts/at91rm9200ek.dts | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/at91rm9200ek.dts > b/arch/arm/boot/dts/at91rm9200ek.dts > index b3e7425..fd2601

Re: [PATCH] ARM: at91/dt: binding: add precision to AIC documentation

2013-11-15 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Nicolas Ferre Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > Documentation/devicetree/bindings/arm/atmel-aic.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/atmel-aic.txt > b/Documentation/devicet

Re: [PATCH v7 1/2] PWM: atmel-pwm: add PWM controller driver

2013-11-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:53 Fri 15 Nov , Bo Shen wrote: > Add Atmel PWM controller driver based on PWM framework. > > This is the basic function implementation of Atmel PWM controller. > It can work with PWM based led and backlight. > > Signed-off-by: Bo Shen > Acked-by: Alexandre Belloni > --- > Changes in v

Re: [PATCH v7 2/2] PWM: atmel-pwm: add device tree binding document

2013-11-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:53 Fri 15 Nov , Bo Shen wrote: > Add atmel pwm driver device tree binding document > > Signed-off-by: Bo Shen > Acked-by: Alexandre Belloni > Acked-by: Kumar Gala Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > Changes in v7: None >

Re: [PATCH] ARM: at91/dt: binding: add missing compatibility string in SDRAM/DDR documentation

2013-11-15 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:10 Fri 15 Nov , Nicolas Ferre wrote: > The "atmel,at91rm9200-sdramc" was missing from binding documentation. > > Signed-off-by: Nicolas Ferre Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > Documentation/devicetree/bindings/arm/atmel-a

Re: [PATCH v6 1/2] PWM: atmel-pwm: add PWM controller driver

2013-11-14 Thread Jean-Christophe PLAGNIOL-VILLARD
> >>+MODULE_DEVICE_TABLE(of, atmel_pwm_dt_ids); > >>+#endif > >>+ > >>+static int atmel_pwm_probe(struct platform_device *pdev) > >>+{ > >>+ const struct of_device_id *of_id = > >>+ of_match_device(atmel_pwm_dt_ids, &pdev->dev); > >>+ const struct atmel_pwm_data *data; > >>+ struct

Re: [PATCH v6 1/2] PWM: atmel-pwm: add PWM controller driver

2013-11-13 Thread Jean-Christophe PLAGNIOL-VILLARD
On 15:59 Fri 01 Nov , Bo Shen wrote: > Add Atmel PWM controller driver based on PWM framework. > > This is the basic function implementation of Atmel PWM controller. > It can work with PWM based led and backlight. > > Signed-off-by: Bo Shen > > --- > Changes in v6: > - using relaxed versi

Re: [PATCH] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions

2013-11-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 19:34 Thu 07 Nov , Rob Herring wrote: > On Thu, Nov 7, 2013 at 1:20 PM, Stephen Boyd wrote: > > If we're running on a v7 ARM CPU, detect if the CPU supports the > > sdiv/udiv instructions and replace the signed and unsigned > > division library functions with an sdiv/udiv instruction. > >

Re: [PATCH] ARM: Use udiv/sdiv for __aeabi_{u}idiv library functions

2013-11-08 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:20 Thu 07 Nov , Stephen Boyd wrote: > If we're running on a v7 ARM CPU, detect if the CPU supports the > sdiv/udiv instructions and replace the signed and unsigned > division library functions with an sdiv/udiv instruction. > > Running the perf messaging benchmark in pipe mode > > $ pe

Re: [PATCH v2] efifb: prevent null-deref when iterating dmi_list

2013-11-01 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:17 Thu 31 Oct , David Herrmann wrote: > Hi > > On Thu, Oct 31, 2013 at 11:45 AM, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > On 18:40 Wed 02 Oct , David Herrmann wrote: > >> The dmi_list array is initialized using gnu designated initializers, and >

Re: [PATCH v2] efifb: prevent null-deref when iterating dmi_list

2013-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:40 Wed 02 Oct , David Herrmann wrote: > The dmi_list array is initialized using gnu designated initializers, and > therefore may contain fewer explicitly defined entries as there are > elements in it. This is because the enum above with M_xyz constants > contains more items than the desig

Re: [PATCH] watchdog: at91sam9_wdt: various fixes

2013-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:27 Tue 29 Oct , Guenter Roeck wrote: > On Tue, Oct 29, 2013 at 06:22:47PM +0100, boris brezillon wrote: > > On 29/10/2013 17:43, Guenter Roeck wrote: > > >On Tue, Oct 29, 2013 at 05:22:50PM +0100, boris brezillon wrote: > > >>On 29/10/2013 16:45, Guenter Roeck wrote: > > >>>On Tue, Oct 29

Re: [PATCH v5] PWM: atmel-pwm: add PWM controller driver

2013-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 17:10 Mon 30 Sep , Bo Shen wrote: > Add Atmel PWM controller driver based on PWM framework. > > This is the basic function implementation of Atmel PWM controller. > It can work with PWM based led and backlight. > > Signed-off-by: Bo Shen > > --- > Changes in v5: > - call clk_disable di

Re: [PATCH 2/2] misc: atmel_pwm: set initcall level to subsys

2013-10-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:19 Thu 31 Oct , Bo Shen wrote: > Hi Arnd, > > On 10/31/2013 04:46, Arnd Bergmann wrote: > >On Wednesday 30 October 2013, Johan Hovold wrote: > >>>I really hate this type of patch, as it's papering over the real > >>>problem. What happens when someone else moves their driver to this > >>

Re: [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one

2013-10-30 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:20 Tue 29 Oct , Johan Hovold wrote: > On Fri, Oct 25, 2013 at 01:15:43PM +0200, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > On 11:55 Wed 23 Oct , Johan Hovold wrote: > > > Use devm_gpio_request_one rather than requesting and setting direction > > >

Re: [PATCH 4/9] backlight: atmel-pwm-bl: clean up probe error handling

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > Clean up probe error handling by checking parameters before any > allocations and removing an obsolete error label. Also remove > unnecessary reset of private gpio number. > > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold > --- > drivers/vide

Re: [PATCH 5/9] backlight: atmel-pwm-bl: clean up get_intensity

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > Clean up get_intensity to increase readability. > > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold this ok > --- > drivers/video/backlight/atmel-pwm-bl.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/

Re: [PATCH 9/9] backlight: atmel-pwm-bl: use gpio_request_one

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > Use devm_gpio_request_one rather than requesting and setting direction > in two calls. this is the same I do not see any advantage and as I said for ather backligth It's wrong to enable or disable it at probe as the bootloader might have already ena

Re: [PATCH 8/9] backlight: atmel-pwm-bl: refactor gpio_on handling

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > Add helper function to control the gpio_on signal. > > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold ok > --- > drivers/video/backlight/atmel-pwm-bl.c | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > dif

Re: [PATCH 1/9] backlight: atmel-pwm-bl: fix reported brightness

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > The driver supports 16-bit brightness values, but the value returned > from get_brightness was truncated to eight bits. > > Cc: sta...@vger.kernel.org > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold > --- > drivers/video/backlight/atmel-pwm-b

Re: [PATCH 2/9] backlight: atmel-pwm-bl: fix gpio polarity in remove

2013-10-25 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:55 Wed 23 Oct , Johan Hovold wrote: > Make sure to honour gpio polarity also at remove so that the backlight > is actually disabled on boards with active-low enable pin. > > Cc: sta...@vger.kernel.org > Acked-by: Jingoo Han > Signed-off-by: Johan Hovold > --- > drivers/video/backlight

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:53 Thu 17 Oct , Lee Jones wrote: > On Thu, 17 Oct 2013, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > > > On 17/10/13 08:27, Maxime COQUELIN wrote: > > > > ... > > > >>> >>

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:33 Thu 17 Oct , srinivas kandagatla wrote: > On 17/10/13 08:27, Maxime COQUELIN wrote: > > ... > >>> >> + > >>> >> +static struct of_device_id st_i2c_match[] = { > >>> >> + { .compatible = "st,comms-ssc-i2c", }, > >> > the rules is to put the first soc that use the ip in the compatibl

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:27 Thu 17 Oct , Maxime COQUELIN wrote: > Hi Jean-Christophe, > > On 10/16/2013 05:14 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > ... > >> + > >> +static inline void st_i2c_set_bits(void __iomem *reg, u32 mask) > >>

Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller

2013-10-16 Thread Jean-Christophe PLAGNIOL-VILLARD
> +/** > + * struct st_i2c_dev - private data of the controller > + * @adap: I2C adapter for this controller > + * @dev: device for this controller > + * @base: virtual memory area > + * @complete: completion of I2C message > + * @irq: interrupt line for th controller > + * @clk: hw ssc block clock

Re: [PATCH 2/3] ARM: at91/dt/trivial: before sama5d3, Atmel MPU were using at91 prefix

2013-10-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:46 Mon 14 Oct , Nicolas Ferre wrote: > Change the sha/aes/tdes compatibility string to match common > case for the at91sam9g45 family which is to keep the at91 prefix. > > Signed-off-by: Nicolas Ferre > --- > arch/arm/boot/dts/sama5d3.dtsi | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] ARM: at91: remove init_machine() as default is suitable

2013-10-14 Thread Jean-Christophe PLAGNIOL-VILLARD
ber of lines. > > Signed-off-by: Nicolas Ferre Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J. > --- > arch/arm/mach-at91/board-dt-rm9200.c | 7 --- > arch/arm/mach-at91/board-dt-sam9.c | 7 --- > 2 files changed, 14 deletions(-) > > diff --git a/arch/arm/m

Re: [PATCH 2/2] tty/serial: at91: add a fallback option to determine uart/usart property

2013-10-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:43 Thu 10 Oct , Nicolas Ferre wrote: > On older SoC, the "name" field is not filled in the register map. > Fix the way to figure out if the serial port is an uart or an usart for these > older products (with corresponding properties). > > Signed-off-by: Nicolas Ferre > --- > drivers/tt

Re: [PATCH 1/2] tty/serial: at91: fix uart/usart selection for older products

2013-10-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:43 Thu 10 Oct , Nicolas Ferre wrote: > Since commit 055560b04a8cd063aea916fd083b7aec02c2adb8 (serial: at91: > distinguish usart and uart) the older products which do not have a > name field in their register map are unable to use their serial output. > As the main console output is usuall

Re: [RFC PATCH 3/4] pinctrl: at91: improve pinconf_set/get function robustness

2013-09-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:49 Fri 13 Sep , Boris BREZILLON wrote: > Reset caller's config variable before setting current config flags to avoid > erronous config return. > > DEBOUNCE and DEGLITCH options are mutually exclusive. Return an error if they > are both defined in the config. > Do not call set_deglitch if

Re: [RFC PATCH 2/4] pinctrl: at91: fix sam9x5 debounce/deglitch functions

2013-09-14 Thread Jean-Christophe PLAGNIOL-VILLARD
ut Filter). > > Fix at91_mux_pio3_set_debounce function to avoid disabling the deglitch > filter ("Input Filter") when debounce filter is disabled. > Acked-by: Jean-Christophe PLAGNIOL-VILLARD > Signed-off-by: Boris BREZILLON > --- > drivers/pinctrl/pinctrl-at9

Re: [RFC PATCH alt 4/4] pinctrl: at91: rework debounce configuration

2013-09-14 Thread Jean-Christophe PLAGNIOL-VILLARD
On 16:40 Fri 13 Sep , Stephen Warren wrote: > On 09/13/2013 01:53 AM, Boris BREZILLON wrote: > > AT91 SoCs do not support per pin debounce time configuration. > > Instead you have to configure a debounce time which will be used for all > > pins of a given bank (PIOA, PIOB, ...). > > > diff --g

  1   2   3   4   >