Hi Donald,
On 2/8/21 19:41, Donald Buczek wrote:
Dear Guoqing,
On 08.02.21 15:53, Guoqing Jiang wrote:
On 2/8/21 12:38, Donald Buczek wrote:
5. maybe don't hold reconfig_mutex when try to unregister
sync_thread, like this.
/* resync has finished, collect r
On 2/8/21 12:38, Donald Buczek wrote:
5. maybe don't hold reconfig_mutex when try to unregister sync_thread,
like this.
/* resync has finished, collect result */
mddev_unlock(mddev);
md_unregister_thread(&mddev->sync_thread);
mddev_lock(mddev);
As above:
Hi Donald,
On 1/26/21 17:05, Donald Buczek wrote:
Dear Guoqing,
On 26.01.21 15:06, Guoqing Jiang wrote:
On 1/26/21 13:58, Donald Buczek wrote:
Hmm, how about wake the waiter up in the while loop of raid5d?
@@ -6520,6 +6532,11 @@ static void raid5d(struct md_thread *thread
On 1/26/21 13:58, Donald Buczek wrote:
Hmm, how about wake the waiter up in the while loop of raid5d?
@@ -6520,6 +6532,11 @@ static void raid5d(struct md_thread *thread)
md_check_recovery(mddev);
spin_lock_irq(&conf->device_lock);
Hi Donald,
On 1/26/21 10:50, Donald Buczek wrote:
[...]
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 2d21c298ffa7..f40429843906 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4687,11 +4687,13 @@ action_store(struct mddev *mddev, const char
*page, size_t len)
cle
On 1/25/21 23:55, Shiyang Ruan wrote:
With the support of ->rmap(), it is possible to obtain the superblock on
a mapped device.
If a pmem device is used as one target of mapped device, we cannot
obtain its superblock directly. With the help of SYSFS, the mapped
device can be found on the tar
Hi Donald,
On 1/25/21 22:32, Donald Buczek wrote:
On 25.01.21 09:54, Donald Buczek wrote:
Dear Guoqing,
a colleague of mine was able to produce the issue inside a vm and were
able to find a procedure to run the vm into the issue within minutes
(not unreliably after hours on a physical syst
Hi Donald,
On 1/19/21 12:30, Donald Buczek wrote:
Dear md-raid people,
I've reported a problem in this thread in December:
"We are using raid6 on several servers. Occasionally we had failures,
where a mdX_raid6 process seems to go into a busy loop and all I/O to
the md device blocks. We've s
Hi Donald,
On 12/2/20 18:28, Donald Buczek wrote:
Dear Guoqing,
unfortunately the patch didn't fix the problem (unless I messed it up
with my logging). This is what I used:
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9305,6 +9305,14 @@ void md_check_recovery(struct mddev *
On 11/28/20 13:25, Donald Buczek wrote:
Dear Linux mdraid people,
we are using raid6 on several servers. Occasionally we had failures,
where a mdX_raid6 process seems to go into a busy loop and all I/O to
the md device blocks. We've seen this on various kernel versions.
The last time this
On 7/15/20 8:51 AM, Christoph Hellwig wrote:
On Tue, Jul 14, 2020 at 12:34:45PM -0700, Linus Torvalds wrote:
On Tue, Jul 14, 2020 at 12:06 PM Christoph Hellwig wrote:
this series starts to move the early init code away from requiring
KERNEL_DS to be implicitly set during early startup. It doe
On 7/8/20 3:23 PM, Matthew Wilcox wrote:
On Wed, Jul 08, 2020 at 03:17:31PM +0200, Guoqing Jiang wrote:
On 7/8/20 2:25 PM, Christoph Hellwig wrote:
-static int md_media_changed(struct gendisk *disk)
-{
- struct mddev *mddev = disk->private_data;
-
- return mddev->changed;
-}
On 7/8/20 2:25 PM, Christoph Hellwig wrote:
-static int md_media_changed(struct gendisk *disk)
-{
- struct mddev *mddev = disk->private_data;
-
- return mddev->changed;
-}
Maybe we can remove "changed" from struct mddev since no one reads it
after the change.
Thanks,
Guoqing
On 5/26/20 11:54 PM, Mike Marshall wrote:
I apologize for not mentioning that I ran this patch set
through orangefs xfstests at 5.7 rc5 with no problems
or regressions.
Glad to hear that, thanks for your effort.
Thanks,
Guoqing
Change it to inline function to make callers use the proper argument.
And no need for it to be macro per Andrew's comment [1].
[1]
https://lore.kernel.org/lkml/20200518221235.1fa32c38e5766113f78e3...@linux-foundation.org/
Signed-off-by: Guoqing Jiang
---
include/linux/mm_types.h | 6
On 5/23/20 1:53 AM, Andrew Morton wrote:
On Fri, 22 May 2020 09:18:25 +0200 Guoqing Jiang
wrote:
- ClearPagePrivate(page);
- set_page_private(newpage, page_private(page));
- set_page_private(page, 0);
- put_page(page);
+ set_page_private(newpage
Hi Dave,
On 5/22/20 12:52 AM, Dave Chinner wrote:
On Sun, May 17, 2020 at 11:47:18PM +0200, Guoqing Jiang wrote:
We can cleanup code a little by call detach_page_private here.
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
mm/migrate.c | 5 +
1 file changed, 1 insertion
We can cleanup code a little by call detach_page_private here.
Signed-off-by: Guoqing Jiang
---
Add the cast to fix type mismatch warning, sorry for the mistake.
mm/migrate.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 7160c1556f79
Hi Andrew,
On 5/19/20 9:35 AM, Guoqing Jiang wrote:
On 5/19/20 7:12 AM, Andrew Morton wrote:
On Sun, 17 May 2020 23:47:18 +0200 Guoqing Jiang
wrote:
We can cleanup code a little by call detach_page_private here.
...
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -804,10 +804,7 @@ static int
On 5/19/20 12:06 PM, Gao Xiang wrote:
On Tue, May 19, 2020 at 09:35:59AM +0200, Guoqing Jiang wrote:
On 5/19/20 7:12 AM, Andrew Morton wrote:
On Sun, 17 May 2020 23:47:18 +0200 Guoqing Jiang
wrote:
We can cleanup code a little by call detach_page_private here.
...
--- a/mm/migrate.c
On 5/19/20 7:12 AM, Andrew Morton wrote:
On Sun, 17 May 2020 23:47:18 +0200 Guoqing Jiang
wrote:
We can cleanup code a little by call detach_page_private here.
...
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -804,10 +804,7 @@ static int __buffer_migrate_page(struct address_space
*mapping
Since the new pair function is introduced, we can call them to clean the
code in btrfs.
Cc: Chris Mason
Cc: Josef Bacik
Cc: David Sterba
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private
All the callers have replaced attach_page_buffers with the new function
attach_page_private, so remove it.
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
No change since RFC.
include/linux/buffer_head.h | 8
We can cleanup code a little by call detach_page_private here.
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
mm/migrate.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 5fed0305d2ec..f99502bc113c 100644
--- a/mm/migrate.c
Since the new pair function is introduced, we can call them to clean the
code in orangefs.
Cc: Mike Marshall
Cc: Martin Brandenburg
Cc: de...@lists.orangefs.org
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
After introduce attach/detach_page_private in pagemap.h, we can remove
the duplicat code and call the new functions.
Cc: Song Liu
Cc: linux-r...@vger.kernel.org
Acked-by: Song Liu
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private
Since the new pair function is introduced, we can call them to clean the
code in f2fs.h.
Cc: Jaegeuk Kim
Cc: Chao Yu
Cc: linux-f2fs-de...@lists.sourceforge.net
Acked-by: Chao Yu
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private
Call the new function since attach_page_buffers will be removed.
Cc: Anton Altaparmakov
Cc: linux-ntfs-...@lists.sourceforge.net
Signed-off-by: Guoqing Jiang
---
No change since RFC V2.
RFC -> RFC V2
1. change the name of new function to attach_page_private.
fs/ntfs/aops.c | 2 +-
fs/n
Since the new pair function is introduced, we can call them to clean the
code in iomap.
Cc: Christoph Hellwig
Cc: "Darrick J. Wong"
Cc: linux-...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_
angefs.
[1].
https://lore.kernel.org/linux-fsdevel/20200420221424.gh5...@bombadil.infradead.org/
[2].
https://lore.kernel.org/lkml/e4d5ddc0-877f-6499-f697-2b7c0ddbf...@cloud.ionos.com/
Guoqing Jiang (10):
include/linux/pagemap.h: introduce attach/detach_page_private
md: remove __clear_page_b
aparmakov
Cc: linux-ntfs-...@lists.sourceforge.net
Cc: Mike Marshall
Cc: Martin Brandenburg
Cc: de...@lists.orangefs.org
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3:
1. rename clear_page_priva
Since the new pair function is introduced, we can call them to clean the
code in buffer.c.
Cc: Alexander Viro
Signed-off-by: Guoqing Jiang
---
No change since RFC V3.
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RFC V2
1. change the name of new functi
Call the new function since attach_page_buffers will be removed.
Cc: Anton Altaparmakov
Cc: linux-ntfs-...@lists.sourceforge.net
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3: no change
RFC -> RFC V2
1. change the name of new function to attach_page_private.
fs/ntfs/aops.c | 2
After introduce attach/detach_page_private in pagemap.h, we can remove
the duplicat code and call the new functions.
Cc: Song Liu
Cc: linux-r...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RFC V2
1. chan
Since the new pair function is introduced, we can call them to clean the
code in btrfs.
Cc: Chris Mason
Cc: Josef Bacik
Cc: David Sterba
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RF
Since the new pair function is introduced, we can call them to clean the
code in f2fs.h.
Cc: Jaegeuk Kim
Cc: Chao Yu
Cc: linux-f2fs-de...@lists.sourceforge.net
Acked-by: Chao Yu
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -&g
Since the new pair function is introduced, we can call them to clean the
code in orangefs.
Cc: Mike Marshall
Cc: Martin Brandenburg
Cc: de...@lists.orangefs.org
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RFC V2
1. chan
aparmakov
Cc: linux-ntfs-...@lists.sourceforge.net
Cc: Mike Marshall
Cc: Martin Brandenburg
Cc: de...@lists.orangefs.org
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3:
1. rename clear_page_priva
Since the new pair function is introduced, we can call them to clean the
code in buffer.c.
Cc: Alexander Viro
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_p
We can cleanup code a little by call detach_page_private here.
Cc: Andrew Morton
Cc: linux...@kvack.org
Signed-off-by: Guoqing Jiang
---
Added since RFC V3.
mm/migrate.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 7160c1556f79
Since the new pair function is introduced, we can call them to clean the
code in iomap.
Cc: Christoph Hellwig
Cc: "Darrick J. Wong"
Cc: linux-...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC V2 -> RFC V3
1. rename clear_page_private to detach_page_private.
RFC -> RFC
All the callers have replaced attach_page_buffers with the new function
attach_page_private, so remove it.
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
No change since RFC.
include/linux/buffer_head.h | 8
s.
[1].
https://lore.kernel.org/linux-fsdevel/20200420221424.gh5...@bombadil.infradead.org/
[2].
https://lore.kernel.org/lkml/e4d5ddc0-877f-6499-f697-2b7c0ddbf...@cloud.ionos.com/
Thanks,
Guoqing
Guoqing Jiang (10):
include/linux/pagemap.h: introduce attach/detach_page_private
md:
On 5/2/20 2:41 AM, Matthew Wilcox wrote:
On Sat, May 02, 2020 at 12:42:15AM +0200, Guoqing Jiang wrote:
On 5/2/20 12:16 AM, Matthew Wilcox wrote:
On Thu, Apr 30, 2020 at 11:44:41PM +0200, Guoqing Jiang wrote:
include/linux/pagemap.h: introduce attach/clear_page_private
md: remove
On 5/2/20 12:16 AM, Matthew Wilcox wrote:
On Thu, Apr 30, 2020 at 11:44:41PM +0200, Guoqing Jiang wrote:
include/linux/pagemap.h: introduce attach/clear_page_private
md: remove __clear_page_buffers and use attach/clear_page_private
btrfs: use attach/clear_page_private
fs/buffer.c
On 5/1/20 3:49 AM, Al Viro wrote:
On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote:
On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote:
+/**
+ * clear_page_private - clear page's private field and PG_private.
+ * @page: page to be cleared.
+ *
+ * The counterpart function of
On 5/1/20 12:13 AM, Matthew Wilcox wrote:
On Thu, Apr 30, 2020 at 11:44:42PM +0200, Guoqing Jiang wrote:
+/**
+ * attach_page_private - attach data to page's private field and set
PG_private.
+ * @page: page to be attached and set flag.
+ * @data: data to attach to page's pri
On 5/1/20 12:10 AM, Andreas Grünbacher wrote:
Hi,
Am Do., 30. Apr. 2020 um 23:56 Uhr schrieb Guoqing Jiang
:
The logic in attach_page_buffers and __clear_page_buffers are quite
paired, but
1. they are located in different files.
2. attach_page_buffers is implemented in buffer_head.h, so it
...@lists.orangefs.org
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2: Address the comments from Christoph Hellwig
1. change function names to attach/clear_page_private and add comments.
Since the new pair function is introduced, we can call them to clean the
code in btrfs.
Cc: Chris Mason
Cc: Josef Bacik
Cc: David Sterba
Cc: linux-bt...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_private.
2. c
Since the new pair function is introduced, we can call them to clean the
code in orangefs.
Cc: Mike Marshall
Cc: Martin Brandenburg
Cc: de...@lists.orangefs.org
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_private.
2. avoid potent
in orangefs.
[1].
https://lore.kernel.org/linux-fsdevel/20200420221424.gh5...@bombadil.infradead.org/
Thanks,
Guoqing
Guoqing Jiang (9):
include/linux/pagemap.h: introduce attach/clear_page_private
md: remove __clear_page_buffers and use attach/clear_page_private
btrfs: use attach/clear_page_priv
After introduce attach/clear_page_private in pagemap.h, we can remove
the duplicat code and call the new functions.
Cc: Song Liu
Cc: linux-r...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_private.
drivers/md
Since the new pair function is introduced, we can call them to clean the
code in buffer.c.
Cc: Alexander Viro
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_private.
fs/buffer.c | 16
1 file changed, 4 insertions(+),
Since the new pair function is introduced, we can call them to clean the
code in iomap.
Cc: Christoph Hellwig
Cc: "Darrick J. Wong"
Cc: linux-...@vger.kernel.org
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_pri
Call the new function since attach_page_buffers will be removed.
Cc: Anton Altaparmakov
Cc: linux-ntfs-...@lists.sourceforge.net
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new function to attach_page_private.
fs/ntfs/aops.c | 2 +-
fs/ntfs/mft.c | 2 +-
2 fi
Since the new pair function is introduced, we can call them to clean the
code in f2fs.h.
Cc: Jaegeuk Kim
Cc: linux-f2fs-de...@lists.sourceforge.net
Acked-by: Chao Yu
Signed-off-by: Guoqing Jiang
---
RFC -> RFC V2
1. change the name of new functions to attach/clear_page_private.
fs/f
All the callers have replaced attach_page_buffers with the new function
attach_page_private, so remove it.
Cc: Thomas Gleixner
Cc: Sebastian Andrzej Siewior
Cc: Roman Gushchin
Cc: Andreas Dilger
Signed-off-by: Guoqing Jiang
---
include/linux/buffer_head.h | 8
1 file changed, 8
On 3/5/19 6:48 AM, Aditya Pakki wrote:
mddev->sync_thread can be set to NULL on kzalloc failure downstream.
The patch checks for such a scenario and frees allocated resources.
Signed-off-by: Aditya Pakki
---
drivers/md/raid10.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
On 2/14/19 11:27 PM, Wolfgang Walter wrote:
Am Donnerstag, 14. Februar 2019, 10:09:56 schrieb Guoqing Jiang:
On 2/12/19 7:20 PM, Wolfgang Walter wrote:
Am Dienstag, 12. Februar 2019, 16:20:11 schrieb Guoqing Jiang:
On 2/11/19 11:12 PM, Wolfgang Walter wrote:
With 4.19.19 we see sometimes
On 2/12/19 7:20 PM, Wolfgang Walter wrote:
Am Dienstag, 12. Februar 2019, 16:20:11 schrieb Guoqing Jiang:
On 2/11/19 11:12 PM, Wolfgang Walter wrote:
With 4.19.19 we see sometimes the following issue (practically only with
blk_mq, though):
Feb 4 20:04:46 tettnang kernel: [252300.060165
cc list, anyway, Acked-by: Guoqing Jiang
Thanks,
Guoqing
---
drivers/md/md.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index fc488cb30a94..42e018f014cb 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -207,15 +207,10
On 1/3/19 1:13 AM, Jens Axboe wrote:
Hi,
I've got some very sad news to share with you - over Christmas, Shaohua
Li passed away after battling cancer for most of last year.
It is really a sad news and a big lost for the community consider Shaohua's
great contribution!
As you know, Shaohua
On 01/10/2018 02:13 PM, Paolo Valente wrote:
Il giorno 10 gen 2018, alle ore 02:41, Guoqing Jiang ha
scritto:
On 01/09/2018 05:27 PM, Paolo Valente wrote:
For each pair [device for which bfq is selected as I/O scheduler,
group in blkio/io], bfq maintains a corresponding bfq group. Each
vein,
bfqg_stats_xfer_dead is not executed for a root group.
This commit fixes bfq_pd_offline so that the latter executes the above
missing operations for a root group too.
Reported-by: Holger Hoffstätte
Reported-by: Guoqing Jiang
Signed-off-by: Davide Ferrari
Signed-off-by: Paolo Valente
This macro is not used after commit 3b9ab374a1e6
("ppdev: convert to y2038 safe"), so let's remove
it.
Signed-off-by: Guoqing Jiang
---
drivers/char/ppdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
index 3e73bcd..d2561
a good idea, and even the two patches can be put into
one, so how about the following patch?
Looks good.
Acked-by: Guoqing Jiang
Thanks,
Guoqing
Shaohua, what do you think of this one?
---
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 3d957ac1e109..7ffc622dd7fa 100644
--- a/drivers
On 06/26/2017 08:09 PM, Ming Lei wrote:
We will support multipage bvec soon, so initialize bvec
table using the standardy way instead of writing the
talbe directly. Otherwise it won't work any more once
multipage bvec is enabled.
Cc: Shaohua Li
Cc: linux-r...@vger.kernel.org
Signed-off-by: Mi
xes: b98938d16a10 ("md-cluster: introduce cluster_check_sync_size")
Reviewed-by: Guoqing Jiang
Thanks,
Guoqing
Signed-off-by: Christophe JAILLET
---
drivers/md/md-cluster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md-cluster.c b/dr
On 01/10/2017 12:38 AM, Coly Li wrote:
Hi Folks,
I'd like to propose a general md raid discussion, it is quite necessary
for most of active md raid developers sit together to discuss current
challenge of Linux software raid and development trends.
In the last years, we have many development a
On 01/12/2017 12:59 AM, Jes Sorensen wrote:
On 01/11/17 11:52, Shaohua Li wrote:
On Tue, Jan 10, 2017 at 11:49:04AM -0600, Bruce Dubbs wrote:
Jes Sorensen wrote:
I am pleased to announce the availability of
mdadm version 4.0
It is available at the usual places:
http://www.kernel.o
On 09/28/2016 03:55 PM, Jes Sorensen wrote:
SF Markus Elfring writes:
From: Markus Elfring
Date: Tue, 27 Sep 2016 15:46:22 +0200
Adjust jump labels according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/md/bitmap.c | 18 +-
1 f
On 09/14/2016 04:39 PM, Marion & Christophe JAILLET wrote:
I don't share your feeling.
bitmap_create() can return ERR_PTR(-ENOMEM) or ERR_PTR(-EINVAL).
In such cases 'if (!bitmap)' will not be helpful.
Maybe it should be turned into 'if (IS_ERR_OR_NULL(bitmap))' to handle
errors returned by
On 09/13/2016 01:24 PM, Shaohua Li wrote:
On Mon, Sep 12, 2016 at 09:09:48PM +0200, Christophe JAILLET wrote:
Hi,
I'm puzzled by commit f9a67b1182e5 ("md/bitmap: clear bitmap if
bitmap_create failed").
Hi Christophe,
Thank you very much to help check this!
Part of the commit is:
@@ -1865,
: Martin Kepplinger
Cc: Andrew Morton
Cc: Denys Vlasenko
Cc: Sasha Levin
Cc:
Reviewed-by: NeilBrown
Signed-off-by: Guoqing Jiang
---
drivers/md/md.c | 27 ++-
drivers/md/raid1.c | 4 ++--
drivers/md/raid10.c | 8
drivers/md/raid5-cache.c
Hi David,
David Teigland wrote:
> On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote:
>
>> Do you consider take the following clean up? If yes, I will send a
>> formal patch, otherwise pls ignore it.
>>
>
> On first glance, the old and new cod
Hi David,
David Teigland wrote:
> On Wed, Jun 10, 2015 at 11:10:44AM +0800, Guoqing Jiang wrote:
>
>> The remove_from_waiters could only be invoked after failed to
>> create_message, right?
>> Since send_message always returns 0, this patch doesn't touch anything
Bob Peterson wrote:
>
>>>>
>>>>
>>>>> - Original Message -
>>>>>
>>>>>
>>>>>
>>>>>> We don't need the redundant logic since se
Bob Peterson wrote:
> - Original Message -
>
>> Hi Bob,
>>
>> Bob Peterson wrote:
>>
>>> - Original Message -
>>>
>>>
>>>> We don't need the redundant logic since send_message always retur
Hi Bob,
Bob Peterson wrote:
> - Original Message -
>
>> We don't need the redundant logic since send_message always returns 0.
>>
>> Signed-off-by: Guoqing Jiang
>> ---
>> fs/dlm/lock.c | 10 ++
>> 1 file changed, 2 insertio
We don't need the redundant logic since send_message always returns 0.
Signed-off-by: Guoqing Jiang
---
fs/dlm/lock.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 35502d4..6fc3de9 100644
--- a/fs/dlm/lock.c
+++ b/f
Stephen Rothwell wrote:
> Hi Neil,
>
> On Mon, 2 Mar 2015 17:11:49 +1100 Stephen Rothwell
> wrote:
>
>> On Mon, 2 Mar 2015 17:03:45 +1100 NeilBrown wrote:
>>
>>> I think
>>> + bm_blocks = DIV_ROUND_UP(bm_blocks, 4096);
>>>
>>> needs DIV_ROUND_UP_SECTOR_T()
>>>
>> I t
82 matches
Mail list logo
