Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

2021-02-23 Thread Avi Fishman
I%3D&reserved=0 > > > > Please use latest from uboot.bin github. > > > > Regards, > > Ofer > > > > > > -Original Message- > > From: Avi Fishman > > Sent: Monday, February 22, 2021 12:21 PM > > To: Anton Kachalov > > Cc: Tomer Maimon ; Be

Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

2021-02-22 Thread Avi Fishman
Ofer, Can you check why u-boot doesn't work with SD cards? On Mon, Feb 22, 2021 at 11:27 AM Anton Kachalov wrote: > > Hi, Tom. > > Yes, I'm using it for testing on real hardware. > > BTW. Recent u-boot doesn't work with SD cards. The card doesn't > detect. The last working version was this one:

Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

2021-01-10 Thread Avi Fishman
ed in DT. > > I removed the mention of "flags for falling edge", because the timer > controller uses high-level interrupts rather than falling-edge > interrupts, and whether flags should be specified is up the interrupt > controller's DT binding. > > Signed-o

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Avi Fishman
appreciate if this will be accepted. On Thu, Oct 1, 2020 at 9:27 PM Alex Qiu wrote: > > On Thu, Oct 1, 2020 at 10:41 AM Andy Shevchenko > wrote: > > > > On Thu, Oct 01, 2020 at 08:13:49PM +0300, Avi Fishman wrote: > > > Hi Andy, > > > > > > Custom

Re: [PATCH v1] i2c: npcm7xx: Support changing bus speed using debugfs.

2020-10-01 Thread Avi Fishman
Hi Andy, Customers using BMC with complex i2c topology asked us to support changing bus frequency at run time, for example same device will communicate with one slave at 100Kbp/s and another with 400kbp/s and maybe also with smae device at different speed (for example an i2c mux). This is not only

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-31 Thread Avi Fishman
Please ignore my last mail, Tali already sent v3. On Mon, Aug 31, 2020 at 10:57 AM Avi Fishman wrote: > > On Sun, Aug 30, 2020 at 9:01 PM Andy Shevchenko > wrote: > > > > On Sun, Aug 30, 2020 at 3:23 PM Tali Perry wrote: > > > > > > > > i2c: n

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-31 Thread Avi Fishman
On Sun, Aug 30, 2020 at 9:01 PM Andy Shevchenko wrote: > > On Sun, Aug 30, 2020 at 3:23 PM Tali Perry wrote: > > > > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > This commit message is awful. Please read [1] as a tutorial how to > write a commit messages. > Would this be better: i2

Re: [PATCH v2] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-30 Thread Avi Fishman
On Sun, Aug 30, 2020 at 3:21 PM Tali Perry wrote: > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > Signed-off-by: Tali Perry Reviewed-by: Avi Fishman > --- > drivers/i2c/busses/i2c-npcm7xx.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >

Re: [PATCH v1] i2c: npcm7xx: bug fix timeout (usec instead of msec)

2020-08-30 Thread Avi Fishman
Hi Tali, On Sun, Aug 30, 2020 at 11:09 AM Tali Perry wrote: > > i2c: npcm7xx: bug fix timeout (usec instead of msec) > > Signed-off-by: Tali Perry > --- > drivers/i2c/busses/i2c-npcm7xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-npcm7xx.c

Re: [PATCH v11 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-20 Thread Avi Fishman
Thanks Andy, Question below: On Wed, May 20, 2020 at 1:24 PM Andy Shevchenko wrote: > > On Wed, May 20, 2020 at 12:51:12PM +0300, Tali Perry wrote: > > Add Nuvoton NPCM BMC I2C controller driver. > > ... > > > +#ifdef CONFIG_DEBUG_FS > > Why?! It is made to save code size if CONFIG_DEBUG_FS is n

[tip: timers/core] clocksource/drivers/npcm: Fix GENMASK and timer operation

2019-08-26 Thread tip-bot2 for Avi Fishman
The following commit has been merged into the timers/core branch of tip: Commit-ID: a2b58537b4a1cc08fd254fb8d1c24191ce286ae1 Gitweb: https://git.kernel.org/tip/a2b58537b4a1cc08fd254fb8d1c24191ce286ae1 Author:Avi Fishman AuthorDate:Mon, 29 Jul 2019 20:03:54 +03:00

Re: [PATCH] [v5] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-08-21 Thread Avi Fishman
Thanks Daniel, It seems more clear now :) Good to know about the need for Fixes tag. On Wed, Aug 21, 2019 at 1:11 PM Daniel Lezcano wrote: > > On 29/07/2019 19:03, Avi Fishman wrote: > > NPCM7XX_Tx_OPER GENMASK bits where wrong, > > Since NPCM7XX_REG_TICR0 register reset v

Re: [PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-06 Thread Avi Fishman
Thanks for the input Willem, Before I will submit a new version please help me with some questions: On Thu, Aug 1, 2019 at 8:26 PM Willem de Bruijn wrote: > > On Thu, Aug 1, 2019 at 3:28 AM Avi Fishman wrote: > > > > EMC Ethernet Media Access Controller supports 10/100

[PATCH v1 1/2] dt-binding: net: document NPCM7xx EMC 10/100 DT bindings

2019-08-01 Thread Avi Fishman
Added device tree binding documentation for Nuvoton NPCM7xx Ethernet MAC Controller (EMC) 10/100 RMII Signed-off-by: Avi Fishman --- .../bindings/net/nuvoton,npcm7xx-emc.txt | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v1 2/2] net: npcm: add NPCM7xx EMC 10/100 Ethernet driver

2019-08-01 Thread Avi Fishman
EMC Ethernet Media Access Controller supports 10/100 Mbps and RMII. This driver has been working on Nuvoton BMC NPCM7xx. Signed-off-by: Avi Fishman --- drivers/net/ethernet/nuvoton/Kconfig | 21 +- drivers/net/ethernet/nuvoton/Makefile |2 + drivers/net/ethernet/nuvoton

[PATCH v1 0/2] add NPCM7xx EMC 10/100 Ethernet driver

2019-08-01 Thread Avi Fishman
EMC Ethernet Media Access Controller supports 10/100 Mbps and RMII. This driver has been working on Nuvoton BMC NPCM7xx. Avi Fishman (2): dt-binding: net: document NPCM7xx EMC 10/100 DT bindings net: npcm: add NPCM7xx EMC 10/100 Ethernet driver .../bindings/net/nuvoton,npcm7xx-emc.txt

Re: RFC: remove Nuvoton w90x900/nuc900 platform?

2019-07-30 Thread Avi Fishman
Note that we we are going to add soon drivers/net/ethernet/nuvoton/npcm7xx_emc.c so maybe don't remove drivers/net/ethernet/nuvoton On Tue, Jul 30, 2019 at 4:01 PM Arnd Bergmann wrote: > > That wasn't it either, sorry for spamming the rest. I found one more > address for Zongshun at Huawei. > > O

[PATCH v2] mtd: spi-nor: Add Winbond w25q256jvm

2019-07-30 Thread Avi Fishman
Similar to w25q256 (besides not supporting QPI mode) but with different ID. The "JVM" suffix is in the datasheet. The datasheet indicates DUAL and QUAD are supported. https://www.winbond.com/resource-files/w25q256jv%20spi%20revi%2010232018%20plus.pdf Signed-off-by: Avi Fishman --- d

[PATCH] [v5] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-29 Thread Avi Fishman
ffect. npcm7xx_timer_periodic() was not wrong but it wrote to NPCM7XX_REG_TICR0 in a middle of read modify write to NPCM7XX_REG_TCSR0 which is confusing. npcm7xx_timer_oneshot() did wrong calculation Signed-off-by: Avi Fishman --- drivers/clocksource/timer-npcm7xx.c | 9 +++-- 1 file changed, 3 inser

Re: [PATCH] [v4] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-29 Thread Avi Fishman
Please discard this. my mail tool corruppted it again. On Mon, Jul 29, 2019 at 7:50 PM Avi Fishman wrote: > > NPCM7XX_Tx_OPER GENMASK bits where wrong, > Since NPCM7XX_REG_TICR0 register reset value of those bits was 0, > it did not cause an issue. > in npcm7xx_timer_oneshot

[PATCH] [v4] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-29 Thread Avi Fishman
ffect. npcm7xx_timer_periodic() was not wrong but it wrote to NPCM7XX_REG_TICR0 in a middle of read modify write to NPCM7XX_REG_TCSR0 which is confusing. npcm7xx_timer_oneshot() did wrong calculation Signed-off-by: Avi Fishman --- drivers/clocksource/timer-npcm7xx.c | 9 +++-- 1 file changed, 3 inser

Re: [PATCH] [v2] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-15 Thread Avi Fishman
On Mon, Jul 15, 2019 at 6:25 PM Joe Perches wrote: > > On Mon, 2019-07-15 at 18:19 +0300, Avi Fishman wrote: > > clocksource/drivers/npcm: fix GENMASK and timer operation > > > > NPCM7XX_Tx_OPER GENMASK() changed from (27, 3) to (28, 27) > > > > in

[PATCH] [v3] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-15 Thread Avi Fishman
masking it with ~NPCM7XX_Tx_OPER so the masking didn't take effect. npcm7xx_timer_periodic() was not wrong but it wrote to NPCM7XX_REG_TICR0 in a middle of read modify write to NPCM7XX_REG_TCSR0 which is confusing. Signed-off-by: Avi Fishman --- drivers/clocksource/timer-npcm7xx.

[PATCH] [v2] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-15 Thread Avi Fishman
iodic() was not wrong but it wrote to NPCM7XX_REG_TICR0 in a middle of read modify write to NPCM7XX_REG_TCSR0 which is confusing. Signed-off-by: Avi Fishman --- drivers/clocksource/timer-npcm7xx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/

Re: [PATCH] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-15 Thread Avi Fishman
Hi Thomas, Thanks, Avi On Mon, Jul 15, 2019 at 3:37 PM Thomas Gleixner wrote: > > Avi, > > On Mon, 15 Jul 2019, Avi Fishman wrote: > > > NPCM7XX_Tx_OPER GENMASK was wrong, > > That part is already fixed upstream: > > 9bdd7bb3a844 ("clocksource/drivers/np

[PATCH] clocksource/drivers/npcm: fix GENMASK and timer operation

2019-07-15 Thread Avi Fishman
NPCM7XX_Tx_OPER GENMASK was wrong, npcm7xx_timer_oneshot() did wrong calculation Signed-off-by: Avi Fishman --- drivers/clocksource/timer-npcm7xx.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer

Re: [PATCH 02/12] clocksource/drivers/npcm: Fix misuse of GENMASK macro

2019-07-15 Thread Avi Fishman
Hi, I noticed that this is totaly wrong, so I will fix here. If you wan I will put a separate patch. On Wed, Jul 10, 2019 at 8:04 AM Joe Perches wrote: > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/clocksource/timer-npcm7xx.c | 2 +- > 1

Re: [PATCH] mtd: spi-nor: Add Winbond w25q256jvm

2019-07-14 Thread Avi Fishman
Hi Tudor, Boris & Tudor, I see that you pushed this kind of commit of Winbond chip previously, can you please approve also this? On Tue, Jul 2, 2019 at 5:23 PM Avi Fishman wrote: > > Similar to w25q256 (besides not supporting QPI mode) but with different ID. > The "JVM

[PATCH] mtd: spi-nor: Add Winbond w25q256jvm

2019-07-02 Thread Avi Fishman
Similar to w25q256 (besides not supporting QPI mode) but with different ID. The "JVM" suffix is in the datasheet. The datasheet indicates DUAL and QUAD are supported. https://www.winbond.com/resource-files/w25q256jv%20spi%20revi%2010232018%20plus.pdf Signed-off-by: Avi Fishman --- d

[PATCH] mtd: spi-nor: Add Winbond w25q256jvm

2019-07-02 Thread Avi Fishman
Similar to w25q256 (besides not supporting QPI mode) but with different ID. The "JVM" suffix is in the datasheet. The datasheet indicates DUAL and QUAD are supported. https://www.winbond.com/resource-files/w25q256jv%20spi%20revi%2010232018%20plus.pdf Signed-off-by: Avi Fishman --- d

Re: [PATCH 5.2 v2 2/2] dt-binding: edac: add NPCM ECC documentation

2019-06-06 Thread Avi Fishman
On Wed, Jun 5, 2019 at 5:19 PM George Hung wrote: > > Add device tree documentation for Nuvoton BMC ECC > > Signed-off-by: George Hung Reviewed-by: Avi Fishman > --- > .../bindings/edac/npcm7xx-sdram-edac.txt| 17 + > 1 file changed, 17 inserti

Re: [PATCH 5.2 v2 1/2] edac: npcm: Add Nuvoton NPCM7xx EDAC driver

2019-06-06 Thread Avi Fishman
n assert fwc (force write check) > bit to 'b1' (mem base: 0xf0824000, xor_check_bits reg addr: 0x178) > > $ devmem 0xf0824178 32 0x7501 > > To force a double-bit un-correctable error for the user-word space, > write 0x03 into that byte of the xor_check_bits parameter > &

Re: [PATCH v2 06/15] arm: npcm: fix a leaked reference by adding missing of_node_put

2019-03-06 Thread Avi Fishman
count incremented on line 60, but without a > corresponding object release within this function. > > Signed-off-by: Wen Yang > Reviewed-by: Florian Fainelli > Cc: Avi Fishman > Cc: Tomer Maimon > Cc: Patrick Venture > Cc: Nancy Yuen > Cc: Brendan Higgins > Cc: Russ

Re: [PATCH 06/15] arm: npcm: fix a leaked reference by addingmissing of_node_put

2019-03-04 Thread Avi Fishman
Reviewed-by: Avi Fishman Thanks On Fri, Mar 1, 2019 at 10:57 AM Wen Yang wrote: > > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following

Re: [PATCH] clk: npcm7xx: fix memory allocation

2018-08-26 Thread Avi Fishman
gt; > > sizeof(npcm7xx_clk_data) should be sizeof(*npcm7xx_clk_data) > > > > Fix this bug by using struct_size() in kzalloc() > > > > This issue was detected with the help of Coccinelle. > > > > Cc: sta...@vger.kernel.org > > Signed-off-by: Gus

Re: [RFC PATCH v2 1/4] dt-bindings: misc: Add bindings for misc. BMC control fields

2018-07-15 Thread Avi Fishman
+ my vote as Nuvoton's BMC FW provider. On Fri, Jul 13, 2018 at 10:07 PM wrote: > > >> Dell - Internal Use - Confidential > >Really? To a public mailing list? odd... > > Ha yea sorry - I was so excited to show my support, that I jumped the gun :) >

[PATCH v2 1/1] MAINTAINERS: add subfolders for nuvoton *npcm*

2018-07-01 Thread avi . fishman
From: Avi Fishman Add several subfolders to look for *npcm* files under ARM/NUVOTON NPCM ARCHITECTURE Signed-off-by: Avi Fishman --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e0ce3c5f32e5..23c450adad44 100644 --- a/MAINTAINERS +++ b

[PATCH v2 0/1] MAINTAINERS: add subfolders for nuvoton *npcm*

2018-07-01 Thread avi . fishman
From: Avi Fishman Changes since version 1: - Follow Greg KH comment to add changelog test in addition to the commit subject Add several subfolders to look for *npcm* files under ARM/NUVOTON NPCM ARCHITECTURE Avi Fishman (1): MAINTAINERS: add subfolders for nuvoton *npcm

Re: [PATCH ipmi/kcs_bmc v1] ipmi: add an NPCM7xx KCS BMC driver

2018-03-27 Thread Avi Fishman
Thanks Haiyue, this works for us, I am adding Tested-by: Avi Fishman On Thu, Mar 22, 2018 at 3:50 PM, Haiyue Wang wrote: > This driver exposes the Keyboard Controller Style (KCS) interface on > Novoton NPCM7xx SoCs as a character device. Such SOCs are commonly used > as a BaseBoard M

Re: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements

2018-03-08 Thread Avi Fishman
So at least replace CACHE_L2X0 with MIGHT_HAVE_CACHE_L2X0 then CACHE_L2X0 will be selected by default and user can still remove it. On Thu, Mar 8, 2018 at 4:12 AM, Joel Stanley wrote: > On Thu, Mar 8, 2018 at 2:54 AM, Arnd Bergmann wrote: >> While looking at the build regression, I noticed that

Re: [PATCH] serial: 8250: Add Nuvoton NPCM UART

2018-02-15 Thread Avi Fishman
> From: joel.s...@gmail.com [mailto:joel.s...@gmail.com] On Behalf Of Joel > Stanley > Sent: Thursday, February 15, 2018 4:00 AM > > On Wed, Feb 14, 2018 at 3:22 AM, Andy Shevchenko > wrote: >> On Mon, Feb 12, 2018 at 6:48 AM, Joel Stanley wrote: >>> The Nuvoton UART is almost compatible with t

Re: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree

2018-02-13 Thread Avi Fishman
Signed-off-by: Brendan Higgins >> Reviewed-by: Tomer Maimon >> Reviewed-by: Avi Fishman >> Reviewed-by: Joel Stanley >> Reviewed-by: Rob Herring >> Tested-by: Tomer Maimon >> Tested-by: Avi Fishman > ... >> + enable-method = "nuvoton,npc

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Avi Fishman
Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue wrote: > > > On 2018-01-17 07:06, Joel Stanley wrote: >> >> On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: >>> >>> On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) in

Re: [PATCH v4 1/3] arm: npcm: add basic support for Nuvoton BMCs

2017-09-07 Thread Avi Fishman
On Thu, Sep 7, 2017 at 8:09 AM, Brendan Higgins wrote: > On Wed, Sep 6, 2017 at 2:04 PM, Avi Fishman wrote: >> Sorry for sending again some mailing list rejected it due to HTML >> involved (althoug I tried Plain Text), Trying again. >> >> 2017-09-06 11:07 GMT+03:00

Re: [PATCH v4 1/3] arm: npcm: add basic support for Nuvoton BMCs

2017-09-06 Thread Avi Fishman
Sorry for sending again some mailing list rejected it due to HTML involved (althoug I tried Plain Text), Trying again. 2017-09-06 11:07 GMT+03:00 Brendan Higgins : > Adds basic support for the Nuvoton NPCM750 BMC. > > Signed-off-by: Brendan Higgins > --- > arch/arm/Kconfig | 2 + >