Reviewed-by: Avi Fishman <avifishma...@gmail.com>
Thanks
On Fri, Mar 1, 2019 at 10:57 AM Wen Yang <wen.yan...@zte.com.cn> wrote:
>
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-npcm/platsmp.c:52:1-7: ERROR: missing of_node_put; acquired a
> node pointer with refcount incremented on line 31, but without a
> corresponding object release within this function.
> ./arch/arm/mach-npcm/platsmp.c:68:2-8: ERROR: missing of_node_put; acquired a
> node pointer with refcount incremented on line 60, but without a
> corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
> Cc: Avi Fishman <avifishma...@gmail.com>
> Cc: Tomer Maimon <tmaimo...@gmail.com>
> Cc: Patrick Venture <vent...@google.com>
> Cc: Nancy Yuen <yu...@google.com>
> Cc: Brendan Higgins <brendanhigg...@google.com>
> Cc: Russell King <li...@armlinux.org.uk>
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: open...@lists.ozlabs.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/mach-npcm/platsmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-npcm/platsmp.c b/arch/arm/mach-npcm/platsmp.c
> index 21633c7..fe63edc 100644
> --- a/arch/arm/mach-npcm/platsmp.c
> +++ b/arch/arm/mach-npcm/platsmp.c
> @@ -35,6 +35,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu,
> goto out;
> }
> gcr_base = of_iomap(gcr_np, 0);
> + of_node_put(gcr_np);
> if (!gcr_base) {
> pr_err("could not iomap gcr");
> ret = -ENOMEM;
> @@ -63,6 +64,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int
> max_cpus)
> return;
> }
> scu_base = of_iomap(scu_np, 0);
> + of_node_put(scu_np);
> if (!scu_base) {
> pr_err("could not iomap scu");
> return;
> --
> 2.9.5
>
--
Regards,
Avi
