From: Alexander Kochetkov
DMA-based transfer will be enabled if data length is larger than FIFO size
(64 bytes for A64). This greatly reduce number of interrupts for
transferring data.
For smaller data size PIO mode will be used. In PIO mode whole buffer will
be loaded into FIFO.
If driver
> 19 окт. 2020 г., в 11:21, Maxime Ripard написал(а):
>
> Hi!
>
> On Thu, Oct 15, 2020 at 06:47:40PM +0300, Alexander Kochetkov wrote:
>> DMA-based transfer will be enabled if data length is larger than FIFO size
>> (64 bytes for A64). This greatly redu
From: Alexander Kochetkov
If SPI is used for periodic polling any sensor, significant delays
sometimes appear. Switching on module clocks during resume lead to delays.
Enabling autosuspend mode causes the controller to not suspend between
SPI transfers and the delays disappear.
The commit also
From: Alexander Kochetkov
DMA-based transfer will be enabled if data length is larger than FIFO size
(64 bytes for A64). This greatly reduce number of interrupts for
transferring data.
For smaller data size PIO mode will be used. In PIO mode whole buffer will
be loaded into FIFO.
If driver
Hi, Maxime! Thanks for reviewing patches!
>>
>> +static int sun6i_spi_prepare_dma(struct sun6i_spi *sspi,
>> + struct spi_transfer *tfr)
>> +{
>> +struct dma_async_tx_descriptor *rxdesc, *txdesc;
>> +struct spi_master *master = sspi->master;
>> +
>> +rxdes
If SPI is used for periodic polling any sensor, significant delays
sometimes appear. Switching on module clocks during resume lead to delays.
Enabling autosuspend mode causes the controller to not suspend between
SPI transfers and the delays disappear.
Signed-off-by: Alexander Kochetkov
If SPI is used for periodic polling any sensor, significant delays
sometimes appear. Switching on module clocks during resume lead to delays.
Enabling autosuspend mode causes the controller to not suspend between
SPI transfers and the delays disappear.
Signed-off-by: Alexander Kochetkov
then it fallback for PIO mode.
Tested on SOPINE (https://www.pine64.org/sopine/)
Signed-off-by: Alexander Kochetkov
---
drivers/spi/spi-sun6i.c | 171 +---
1 file changed, 159 insertions(+), 12 deletions(-)
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi
From: Alexander Kochetkov
Signed-off-by: Alexander Kochetkov
---
arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index
size = mmc->max_req_size;
> 21 марта 2019 г., в 5:31, Shawn Lin написал(а):
>
> + Caesar Wang
>
> On 2019/3/21 1:48, Alexander Kochetkov wrote:
>> I've found that sometimes dw_mmc in my rk3188 based board stop transfer
>> any data with error:
>> kernel:
The init_slot() hook allow platform driver override slot defaults
provided by generic dw_mmc driver. It's required to fix EDMA based
transfer hangs observed on rockchip rk3188.
Signed-off-by: Alexander Kochetkov
---
drivers/mmc/host/dw_mmc.c |4
drivers/mmc/host/dw_mmc.h |2
scatterlist for one transfer.
I guess that all other rk3xxx chips that lacks FLUSHP also affected by
the problem. So I made fix for all rk3xxx chips from rk2928 to rk3188.
Signed-off-by: Alexander Kochetkov
---
drivers/mmc/host/dw_mmc-rockchip.c | 19 +++
1 file changed, 19
Hello!
I found, that sometimes dw_mmc driver stop transfer data to
eMMC card on my rk3188 based board. One of tranfers hangs then
doing EDMA transfer and controller gives HTO. And here is a fix.
Alexander Kochetkov (2):
mmc: dw_mmc: add init_slot() hook to platform function table
mmc: dw_mmc
рта 2018 г., в 1:33, Sasha Levin
> написал(а):
>
> From: Alexander Kochetkov
>
> [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ]
>
> The clocksource and the sched_clock provided by the arm_global_timer
> are quite unstable because their rates depend on the
рта 2018 г., в 1:31, Sasha Levin
> написал(а):
>
> From: Alexander Kochetkov
>
> [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ]
>
> The clocksource and the sched_clock provided by the arm_global_timer
> are quite unstable because their rates depend on the
; 4 марта 2018 г., в 1:29, Sasha Levin
> написал(а):
>
> From: Alexander Kochetkov
>
> [ Upstream commit 500d0aa918a2ea6bb918fee8adcf27dc2912bcd1 ]
>
> The clocksource and the sched_clock provided by the arm_global_timer
> are quite unstable because their rates depend on the
> 29 дек. 2017 г., в 3:14, Stephen Boyd написал(а):
>
> I'm asking if the rate is capped on the consumer side with
> clk_set_max_rate() or if it's capped on the clk provider side to
> express a hardware constraint.
I do that using clk_set_max_rate() at provider size inside clk-rk3188.c.
>
> So
Initial thread here:
https://www.spinics.net/lists/linux-clk/msg21682.html
> 27 дек. 2017 г., в 4:06, Stephen Boyd написал(а):
>
> Are these limits the min/max limits that the parent clk can
> output at? Or the min/max limits that software has constrained on
> the clk?
>
Don’t know how to ans
> 21 дек. 2017 г., в 23:07, Stephen Boyd написал(а):
>
> Can you convert to the determine_rate op instead of round_rate?
> That function should tell you the min/max limits so that you
> don't need to query that information from the core.
I converted rockchip_fractional_approximation() to rockch
larger than one configured using
clk_set_max_rate().
Signed-off-by: Alexander Kochetkov
---
drivers/clk/clk.c| 14 --
include/linux/clk-provider.h |2 ++
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index c8d83ac.
proximation to fix up fractional clk's jitter").
Alexander Kochetkov (2):
clk: rename clk_core_get_boundaries() to clk_hw_get_boundaries() and
expose
clk: rockchip: limit clock rate in the
rockchip_fractional_approximation()
drivers/clk/clk.c| 14 --
dri
ecial approximation
to fix up fractional clk's jitter").
Signed-off-by: Alexander Kochetkov
---
drivers/clk/rockchip/clk.c |7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 35dbd63..3c1fb0d 100644
--- a/drivers/clk
> 19 дек. 2017 г., в 18:22, David Miller написал(а):
>
> From: Alexander Kochetkov
> Date: Fri, 15 Dec 2017 20:20:06 +0300
>
>> arc_emac_rx() has some issues found by code review.
>>
>> In case netdev_alloc_skb_ip_align() or dma_map_single() failure
>>
not be provided to EMAC.
Signed-off-by: Alexander Kochetkov
---
Changes in v2:
- Rebased against stable linux-4.14.y branch
drivers/net/ethernet/arc/emac_main.c | 53 --
1 file changed, 31 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/arc
ake a broadcast storm. For example, running on
PC 'ping' to some IP address triggers ARP-request storm. After some
time (~10sec), EMAC on rk3188 will stall.
Observed and tested on rk3188 radxarock.
[1] https://en.wikipedia.org/wiki/Broadcast_radiation
Signed-off-by: Alexander Kochetkov
---
not be provided to EMAC.
Signed-off-by: Alexander Kochetkov
---
drivers/net/ethernet/arc/emac_main.c | 53 --
1 file changed, 31 insertions(+), 22 deletions(-)
diff --git a/drivers/net/ethernet/arc/emac_main.c
b/drivers/net/ethernet/arc/emac_main.c
index b2e0051
ake a broadcast storm. For example, running on
PC 'ping' to some IP address triggers ARP-request storm. After some
time (~10sec), EMAC on rk3188 will stall.
Observed and tested on rk3188 radxarock.
[1] https://en.wikipedia.org/wiki/Broadcast_radiation
Signed-off-by: Alexander Kochetkov
-
,
Alexander.
> 4 окт. 2017 г., в 14:37, Alexander Kochetkov написал(а):
>
> If two concurrent threads call pl330_get_desc() when DMAC descriptor
> pool is empty it is possible that allocation for one of threads will fail
> with message:
>
> kernel: dma-pl330 20078000.dma-contr
thread A will fail.
Using on-stack pool for new descriptor allow avoid the issue described.
The patch modify pl330_get_desc() to use on-stack pool for allocation
new descriptors.
Signed-off-by: Alexander Kochetkov
---
drivers/dma/pl330.c | 39 ---
1 file changed
descriptor
[1.344912] dma-pl330 20078000.dma-controller: pl330_get_desc:2458 Allocated
one more descriptor
--- rest of similar lines omitted ---
Signed-off-by: Alexander Kochetkov
---
drivers/dma/pl330.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/pl330.c b
Here is the patch fixing descriptor allocation issue.
Could someone with pl330 hardware test it and confirm that
it doesn't brake current pl330 driver? I will be very grateful
to you!
Changes in v2:
- removed wrappers add_desc(), pluck_desc()
- fix code intendation
Alexander Kochetk
Hello Vinod! Thanks for review!
> 26 сент. 2017 г., в 20:37, Vinod Koul написал(а):
>
> Tested-by please...
In order to test the patch the driver should be rebuild with NR_DEFAULT_DESC
defined to 1
and with some trace code included. Is it OK if I provide second patch I used
for testing
with t
described will nether happen.
Signed-off-by: Alexander Kochetkov
---
drivers/dma/pl330.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index f37f497..0e7f6c9 100644
--- a/drivers/dma/pl330.c
Hello!
Just to let you know, that I got following test report from Stephen (thanks a
lot!).
The patch won’t work due to full cyclic transfer doesn’t fit into mcbufsz (256
bytes long).
His application requested driver to do cyclic transfer with large number of
cycles.
pl330 microcode has restri
Hello David!
> 25 апр. 2017 г., в 17:36, David Miller написал(а):
>
> So... what are we doing here?
>
> My understanding is that this should fix the same problem that commit
> 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto
> negotiation on startup") fixed and that this mic
> 21 апр. 2017 г., в 17:18, Roger Quadros написал(а):
>
> I think the following commit broke functionality with interrupt driven PHYs
> 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not
> polling.")
Probably this one[1] broke, according to Alexandre’s commit[2].
And it was
p MAC startup time for boards with Micrel PHY
on 3~5 sec (auto-negotiation time[2]). Could you check that also?
Regards,
Alexander.
[1] https://lkml.org/lkml/2017/4/20/357
[2] http://www.ieee802.org/3/af/public/jan02/brown_1_0102.pdf
> 20 апр. 2017 г., в 14:00, Alexander Kochetkov
> написал(а
> 20 апр. 2017 г., в 13:06, Jaehoon Chung написал(а):
>
> I think you are not using the latest kernel. which version do you use?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce69e2fea093b7fa3991c87849c4955cd47796c9
>
> Could you check this?
Commit ce69e2fe
phy_start_aneg() to phy_start().
Also the patch add call to phy_stop() to arc_emac_stop() to allow
the PHY device to be fully suspended when the interface is unused.
Signed-off-by: Alexander Kochetkov
---
Changes in v2:
- Updated commit message to clarify changes
drivers/net/ethernet/arc
HY and it won't get it.
Signed-off-by: Alexander Kochetkov
Cc: stable # v4.9+
---
drivers/net/phy/phy.c | 40
include/linux/phy.h |1 +
2 files changed, 37 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy
] and this
one patch will get upstream instead of patch[2]. Could you
please test it?
Regards,
Alexander.
[1] http://patchwork.ozlabs.org/patch/743773/
[2] https://lkml.org/lkml/2017/3/30/517
Alexander Kochetkov (1):
net: phy: fix auto-negotiation stall due to unavailable interrupt
dri
):
>
> On 04/19/2017 05:29 PM, Alexander Kochetkov wrote:
>
>> The patch replace phy_start_aneg() with phy_start(). phy_start() call
>
> Replaces.
>
>> phy_start_aneg() as a part of startup sequence and allow recover from
>> error (PHY_HALTED) state.
>
> 19 апр. 2017 г., в 19:32, Florian Fainelli написал(а):
>
> http://patchwork.ozlabs.org/patch/743773/
>
> Roger can you also test Alexander's patch?
If MAC use phy_start_aneg() instead of phy_start() my patch will not work as
expected. Roger, if patch don’t work for you please check what MAC
ce setup bus if active slots exist")
Signed-off-by: Alexander Kochetkov
---
drivers/mmc/host/dw_mmc.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 73db085..faaf2c1 100644
--- a/drivers/mmc/host/dw_mmc.c
++
The patch replace phy_start_aneg() with phy_start(). phy_start() call
phy_start_aneg() as a part of startup sequence and allow recover from
error (PHY_HALTED) state.
Also added call phy_stop() to arc_emac_remove() to stop PHY state machine
when MAC is down.
Signed-off-by: Alexander Kochetkov
Just found similar problem fixed in another PHY. See commit 99f81afc139c
("phy: micrel: Disable auto negotiation on startup»)
> 19 апр. 2017 г., в 16:46, Alexander Kochetkov
> написал(а):
>
> The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using
> interru
interrupt.
Signed-off-by: Alexander Kochetkov
---
drivers/net/phy/phy.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 7cc1b7d..da8f03d 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -1169,6 +1169,18
The patch remove one iteration outer loop in the _loop().
Removing loop saves 4 bytes of MicroCode buffer. This
savings make sense for free-running cyclic transfer
implementation.
DMALP_0 0
...
DMALPENDA_0 bjmpto_9
Signed-off-by: Alexander Kochetkov
---
drivers/dma/pl330.c |8
ntion. As a result,
lost samples and clicks gone.
Signed-off-by: Alexander Kochetkov
---
drivers/dma/pl330.c | 192 +--
1 file changed, 94 insertions(+), 98 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 7539f73..56a2377 1
his. I would not like
pl330 to be broken again
Now I was asked about the series[1] again by guys from Rockchip,
so I send rebased against 4.10.10 version. Hope, someone might test it
and confirm that patches work fine.
Regards,
Alexander.
Alexander Kochetkov (2):
dmaengine: pl330: make cycl
like clksrc-of»).
What do you think?
[1] https://lkml.org/lkml/2017/3/29/286
[2] https://lkml.org/lkml/2017/1/31/401
[3] https://lkml.org/lkml/2017/3/22/508
[4] https://lkml.org/lkml/2017/3/22/420
[5] https://lkml.org/lkml/2017/3/22/426
> 22 марта 2017 г., в 18:48, Alexander Kochetkov
>
is due to high i2s0_pre rate.
Probably rk3188 has some sort of frequency restrictions imposed. Haven't
found anything in the RK3188 TRM, so this is my assumption.
Anyway, with the patch, all the issues gone.
Signed-off-by: Alexander Kochetkov
---
drivers/clk/rockchip/clk-rk3188.c |9 +
s://github.com/0day-ci/linux/commits/Alexander-Kochetkov/Implement-clocksource-for-rockchip-SoC-using-rockchip-timer/20170324-113008
> config: arm64-defconfig (attached as .config)
> compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>wget
> https://ra
> 22 марта 2017 г., в 20:04, Alexander Kochetkov
> написал(а):
>
> Ok. Let leave as is for now.
>
> My radxa worked stable for a year with this settings.
Ok, I not sure what my radxa worked stable with this settings.
Hieko, thanks for catching that.
Sorry for your time.
> 22 марта 2017 г., в 19:47, Heiko Stuebner написал(а):
>
> sorry, but I will not apply this patch at this time.
> When testing on my radxarock with the card I always use upon entering the
> rootfs everything explodes with -110 errors, while without that patch the
> card
> runs stable as far
Hello, Heiko!
> 22 марта 2017 г., в 18:54, Heiko Stuebner написал(а):
>
> I've applied a slightly different variant in [0] with your commit message and
> moved the dma properties to the mmc/emmc nodes in rk3xxx.dtsi - as the dma
> channels are the same on both rk3188 and rk3066.
Thank you! I ha
the stable rockchip clocksource.
Let's disable the arm_global_timer in order to have the rockchip
clocksource selected by default.
Signed-off-by: Alexander Kochetkov
Reviewed-by: Heiko Stuebner
---
arch/arm/boot/dts/rk3188.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm
solve them 'clockevent' attribute should be added to the
timer.
rk3288 (and probably anything newer) is irrelevant to this patch,
as it has the arch timer interface. This patch may be useful
for Cortex-A9/A5 based parts.
Signed-off-by: Alexander Kochetkov
---
arch/arm/mach-rockchip/
Make all properties description in form '"rockchip,-timer",
"rockchip,rk3288-timer"' for all chips found in linux kernel.
Suggested-by: Heiko Stübner
Signed-off-by: Alexander Kochetkov
Acked-by: Rob Herring
Reviewed-by: Heiko Stuebner
---
.../bindin
arm-global-timer clocksource and sched clock. It run
at stable frequency 24MHz.
Signed-off-by: Alexander Kochetkov
Reviewed-by: Heiko Stuebner
---
arch/arm/boot/dts/rk3188.dtsi | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot
Property set to '"rockchip,rk3228-timer", "rockchip,rk3288-timer"'
to match devicetree bindings.
Signed-off-by: Alexander Kochetkov
Suggested-by: Heiko Stübner
Reviewed-by: Heiko Stuebner
---
arch/arm/boot/dts/rk322x.dtsi |2 +-
1 file changed, 1 insertion(+
because clock
framework will try initialize them as clocksource.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3036.dtsi|1 +
arch/arm/boot/dts/rk322x.dtsi|1 +
arch/arm/boot/dts/rk3288.dtsi|1 +
arch/arm64/boot/dts/rockchip/rk3368.dtsi
rockchip.c.
This series should be applied after the commit:
https://lkml.org/lkml/2017/3/22/426
As without the commit, you will get linker error ("clkevt-probe.c:63:
undefined reference to `__clkevt_of_table’")
Regards,
Alexander.
Alexander Kochetkov (6):
dt-bindings: clarify com
approach, we allow a mechanism to clearly define a clocksource or a
clockevent without aerobatics we can find around in some drivers:
timer-sp804.c, arc-timer.c, dw_apb_timer_of.c, mps2-timer.c,
renesas-ostm.c, time-efm32.c, time-lpc32xx.c.
Signed-off-by: Daniel Lezcano
Signed-off-b
uot;
Fixes: 0c8893c9095d ("clockevents: Add a clkevt-of mechanism like clksrc-of")
Signed-off-by: Alexander Kochetkov
---
include/asm-generic/vmlinux.lds.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/include/asm-generic/vmlinux.lds.h
b/include/asm-generic/vmlinux.lds.h
index 24
The patch fix syntax errors introduced by commit 0c8893c9095d
("clockevents: Add a clkevt-of mechanism like clksrc-of").
Fixes: 0c8893c9095d ("clockevents: Add a clkevt-of mechanism like clksrc-of")
Signed-off-by: Alexander Kochetkov
---
drivers/clocksource/clkevt-probe.
fter patch: 'mmc_host mmc0: Bus speed (slot 0) = 9600Hz
(slot req 5000Hz, actual 4800HZ div = 1)'
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3188-radxarock.dts |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
b/arch
).
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3188.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi
index 44da3d42..de786f8 100644
--- a/arch/arm/boot/dts/rk3188.dtsi
+++ b/arch/arm/boot/dts/rk3188
/scm/linux/kernel/git/next/linux-next.git/commit/drivers/clocksource?id=376bc27150f180d9f5eddec6a14117780177589d
Regards,
Alexander.
> 31 янв. 2017 г., в 15:43, Alexander Kochetkov
> написал(а):
>
> From: Alexander Kochetkov
>
> Hello, Daniel, Heiko.
>
> Here is t
Property set to '"rockchip,rk3228-timer", "rockchip,rk3288-timer"'
to match devicetree bindings.
Signed-off-by: Alexander Kochetkov
Suggested-by: Heiko Stübner
---
arch/arm/boot/dts/rk322x.dtsi |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
arm-global-timer clocksource and sched clock. It run
at stable frequency 24MHz.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3188.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi
index 31f81b2
the stable rockchip clocksource.
Let's disable the arm_global_timer in order to have the rockchip
clocksource selected by default.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3188.dtsi |1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arc
may be useful
for Cortex-A9/A5 based parts.
Signed-off-by: Alexander Kochetkov
---
drivers/clocksource/Kconfig |1 +
drivers/clocksource/rockchip_timer.c | 218 --
2 files changed, 158 insertions(+), 61 deletions(-)
diff --git a/drivers/clocksource
From: Alexander Kochetkov
Hello, Daniel, Heiko.
Here is try 6 :) Thanks a lot for helping me to bring the code
into kernel!
This patch series contain:
- devicetree bindings clarification for rockchip timers
- dts files fixes for rk3228-evb, rk3229-evb and rk3188
- implementation of clocksource
Make all properties description in form '"rockchip,-timer",
"rockchip,rk3288-timer"' for all chips found in linux kernel.
Suggested-by: Heiko Stübner
Signed-off-by: Alexander Kochetkov
Acked-by: Rob Herring
---
.../bindings/timer/rockchip,rk-timer.txt
> 30 янв. 2017 г., в 16:12, Daniel Lezcano
> написал(а):
>
> I don't get the point of these changes. The patch does not explain why they
> are
> needed.
I’d like to extract timer API from current implementation.
And to make code more readable I’d like to introduce 'struct rk_timer’ what can
> 30 янв. 2017 г., в 15:04, Daniel Lezcano
> написал(а):
>
> There is no case when the rockchip timer is used for the clockevent.
The is already timer entry for rk3228 in the DT. And it act as clockevent. I
guess it work as backup,
but I cannot test it also. In order to not break DT compatibil
> 30 янв. 2017 г., в 14:04, Daniel Lezcano
> написал(а):
>
> t is up to the RTC to wake up the system from suspend and there is no
> idle state stopping the local timers on these SoCs. So, the rockchip timers
> won't be ever used on the rk3188, right ?
No rockchip timers where used on rk3188 b
> 25 янв. 2017 г., в 15:21, Daniel Lezcano
> написал(а):
>
> Hopefully, that can help to do some housework in the directory, perhaps
> split the drivers in to entities, for example:
> - clksrc-rockchip.c
> - clkevt-rockchip.c
>
> Also, it gives the possibility to declare clocksourc
apply the patches without the tag.
Let me know is all ok with series now? Or may be I have to do something else?
Regards,
Alexander.
> 23 янв. 2017 г., в 20:57, Daniel Lezcano
> написал(а):
>
> On Mon, Jan 23, 2017 at 08:24:47PM +0300, Alexander Kochetkov wrote:
>> Heiko, D
> 24 янв. 2017 г., в 18:02, Heiko Stübner написал(а):
>
> Please don't add Reviewed-by tags without explicit mention of them by
> reviewers. (Also it's spelled wrong).
>
> I haven't looked that deeply into the driver itself and the changes made to
> feel comfortable with a "Reviewed-by".
Tha
patch/9443977/
https://patchwork.kernel.org/patch/9443991/
Alexander Kochetkov (8):
dt-bindings: clarify compatible property for rockchip timers
ARM: dts: rockchip: update compatible property for rk322x timer
ARM: dts: rockchip: add timer entries to rk3188 SoC
ARM: dts: rockchip: disable arm-glo
at the same time. Because arm-global-timer
looks like a better candidate for the kernel: it has higher
frequency and rating.
Disabling arm-global-timer doesn't leave kernel without
clockevents as there is another clockevent provider (smp-twd).
Signed-off-by: Alexander Kochetkov
Reviwed-by:
Property set to '"rockchip,rk3228-timer", "rockchip,rk3288-timer"'
to match devicetree bindings.
Signed-off-by: Alexander Kochetkov
Suggested-by: Heiko Stübner
---
arch/arm/boot/dts/rk322x.dtsi |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
commit.
This is refactoring step without functional changes.
Signed-off-by: Alexander Kochetkov
Reviwed-by: Heiko Stübner
---
drivers/clocksource/rockchip_timer.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/clocksource
Pass rk_timer instead of clock_event_device to low lever timer routines.
So that code could be reused by clocksource implementation.
Drop rk_base() and rk_ctrl().
This is refactoring step without functional changes.
Signed-off-by: Alexander Kochetkov
Reviwed-by: Heiko Stübner
---
drivers
may be usefull
for Cortex-A9/A5 based parts.
Signed-off-by: Alexander Kochetkov
Reviwed-by: Heiko Stübner
---
drivers/clocksource/rockchip_timer.c | 137 +-
1 file changed, 117 insertions(+), 20 deletions(-)
diff --git a/drivers/clocksource/rockchip_timer.c
b
This allow to enable timer without enabling interrupts from it.
As that mode will be used in clocksource implementation.
This is refactoring step without functional changes.
Signed-off-by: Alexander Kochetkov
Reviwed-by: Heiko Stübner
---
drivers/clocksource/rockchip_timer.c |8
arm-global-timer clocksource and sched clock. It run
at stable frequency 24MHz.
Signed-off-by: Alexander Kochetkov
Reviwed-by: Heiko Stübner
---
arch/arm/boot/dts/rk3188.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts
Make all properties description in form '"rockchip,-timer",
"rockchip,rk3288-timer"' for all chips found in linux kernel.
Suggested-by: Heiko Stübner
Signed-off-by: Alexander Kochetkov
Acked-by: Rob Herring
---
.../bindings/timer/rockchip,rk-timer.txt
ag, 23. Januar 2017, 15:47:44 CET schrieb Daniel Lezcano:
>> On Wed, Dec 21, 2016 at 05:21:05PM +0300, Alexander Kochetkov wrote:
>>> Hello Heiko, Daniel!
>>>
>>> Are there any reasons why the patches [1][2] are not applied yet into
>>> kernel? How can I hel
Daniel, thanks for reviewing patches!
> 23 янв. 2017 г., в 19:26, Daniel Lezcano
> написал(а):
>
> On Tue, Nov 29, 2016 at 07:14:49PM +0300, Alexander Kochetkov wrote:
>> The patch move ce field out of struct bc_timer into struct
>> rk_clock_event_device and rename s
Hello Daniel!
:
> +
> +&timer {
> + compatible = "rockchip,rk3228-timer", "rockchip,rk3288-timer";
> +};
> 23 янв. 2017 г., в 18:40, Daniel Lezcano
> написал(а):
>
> I'm not sure this is correct, to which timer &timer will refer ?
>
>timer {
>compatible = "arm,armv
rockchip SoC using rockchip timer
[2]
http://lists.infradead.org/pipermail/linux-rockchip/2016-December/013308.html
> 29 нояб. 2016 г., в 19:14, Alexander Kochetkov
> написал(а):
>
> Hello,
>
> This patch series contain:
> - devicetree bindings clarification for rockchip
> 1 дек. 2016 г., в 0:30, Rob Herring написал(а):
>
> 1st and 2nd are ambiguous. Plus this is an OS implementation detail that
> doesn't belong in the binding.
>
>> +If you want to bind specific timer as clockevent (i.e. one from alive
>> subsystem)
>> +and specific timer as clocksource, you
Make all properties description in form '"rockchip,-timer",
"rockchip,rk3288-timer"' for all chips found in linux kernel.
Suggested-by: Heiko Stübner
Signed-off-by: Alexander Kochetkov
---
.../bindings/timer/rockchip,rk-timer.txt | 12 +---
may be usefull
for Cortex-A9/A5 based parts.
Signed-off-by: Alexander Kochetkov
---
drivers/clocksource/rockchip_timer.c | 137 +-
1 file changed, 117 insertions(+), 20 deletions(-)
diff --git a/drivers/clocksource/rockchip_timer.c
b/drivers/clocksource
Property set to '"rockchip,rk3228-timer", "rockchip,rk3288-timer"'
to match devicetree bindings.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3228-evb.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3228-evb.dts b/ar
Property set to '"rockchip,rk3229-timer", "rockchip,rk3288-timer"'
to match devicetree bindings.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3229-evb.dts |4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-evb.dts b/ar
arm-global-timer clocksource and sched clock. It run
at stable frequency 24MHz.
Signed-off-by: Alexander Kochetkov
---
arch/arm/boot/dts/rk3188.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3188.dtsi b/arch/arm/boot/dts/rk3188.dtsi
index 31f81b2
1 - 100 of 234 matches
Mail list logo
