> 20 апр. 2017 г., в 0:08, Florian Fainelli <f.faine...@gmail.com> написал(а): > > This looks fine. If you wanted to go further, you could move the > phy_connect(), phy_disconnect() calls down to the arc_emac_open() > respectively arc_emac_stop() as this would also allow the PHY device to > be fully suspended when the interface is unused.
I’ve checked patch phy_connect() is called from arc_emac_open() and phy_disconnect() is called from arc_emac_stop(). So, I’ve made mistake in the commit message. Thank you for review. > > 19 апр. 2017 г., в 21:22, Sergei Shtylyov > <sergei.shtyl...@cogentembedded.com> написал(а): > > On 04/19/2017 05:29 PM, Alexander Kochetkov wrote: > >> The patch replace phy_start_aneg() with phy_start(). phy_start() call > > Replaces. > >> phy_start_aneg() as a part of startup sequence and allow recover from >> error (PHY_HALTED) state. >> >> Also added call phy_stop() to arc_emac_remove() to stop PHY state machine > > To arc_emac_stop() maybe? > Sergei, thanks for spell and gramma checking. Regards, Alexander.
