RE: [EXTERNAL] Re: [PATCH v2 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

>> Added support to read the vendor-specific PCI capability to identify the >> type of device being emulated. >> >> Signed-off-by: Shijith Thotton >> --- >> drivers/vdpa/octeon_ep/octep_vdpa.h | 24 + >> drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 34 >+++-

Re: [PATCH v2 1/2] selftests/watchdog: add -c option to limit the ping loop

On 11/19/24 08:01, Laura Nao wrote: In order to run the watchdog selftest in a non-interactive environment, the loop responsible for pinging the watchdog should be finite. Introduce a new '-c' option to adjust the number of pings as needed. Signed-off-by: Laura Nao --- tools/testing/selftests

Re: [PATCH v2 4/4] vdpa/octeon_ep: add interrupt handler for virtio crypto device

On Thu, Nov 21, 2024 at 9:43 PM Shijith Thotton wrote: > > Introduced an interrupt handler for the virtio crypto device, as its > queue usage differs from that of network devices. While virtio network > device receives packets only on even-indexed queues, virtio crypto > device utilize all availab

Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

On Fri, Dec 6, 2024 at 9:25 AM Jason Wang wrote: > > On Thu, Nov 21, 2024 at 9:45 PM Shijith Thotton wrote: > > > > Updated the driver to utilize all the MSI-X interrupt vectors supported > > by each OCTEON endpoint VF, instead of relying on a single vector. > > Enabling more interrupts allows pa

Re: [PATCH v2 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

On Thu, Nov 21, 2024 at 9:43 PM Shijith Thotton wrote: > > Added support to read the vendor-specific PCI capability to identify the > type of device being emulated. > > Signed-off-by: Shijith Thotton > --- > drivers/vdpa/octeon_ep/octep_vdpa.h | 24 + > drivers/vdpa/octeon_e

Re: [PATCH v2 2/4] vdpa/octeon_ep: handle device config change events

On Thu, Nov 21, 2024 at 9:43 PM Shijith Thotton wrote: > > From: Satha Rao > > The first interrupt of the device is used to notify the host about > device configuration changes, such as link status updates. The ISR > configuration area is updated to indicate a config change event when > triggered

Re: [PATCH v2 1/4] vdpa/octeon_ep: enable support for multiple interrupts per device

On Thu, Nov 21, 2024 at 9:45 PM Shijith Thotton wrote: > > Updated the driver to utilize all the MSI-X interrupt vectors supported > by each OCTEON endpoint VF, instead of relying on a single vector. > Enabling more interrupts allows packets from multiple rings to be > distributed across multiple

[PATCH net v4 6/6] virtio_net: ensure netdev_tx_reset_queue is called on bind xsk for tx

virtnet_sq_bind_xsk_pool() flushes tx skbs and then resets tx queue, so DQL counters need to be reset when flushing has actually occurred, Add virtnet_sq_free_unused_buf_done() as a callback for virtqueue_resize() to handle this. Fixes: 21a4e3ce6dc7 ("virtio_net: xsk: bind/unbind xsk for tx") Sign

[PATCH net v4 5/6] virtio_ring: add a func argument 'recycle_done' to virtqueue_reset()

When virtqueue_reset() has actually recycled all unused buffers, additional work may be required in some cases. Relying solely on its return status is fragile, so introduce a new function argument 'recycle_done', which is invoked when it really occurs. Signed-off-by: Koichiro Den --- drivers/net

[PATCH net v4 4/6] virtio_net: ensure netdev_tx_reset_queue is called on tx ring resize

virtnet_tx_resize() flushes remaining tx skbs, requiring DQL counters to be reset when flushing has actually occurred. Add virtnet_sq_free_unused_buf_done() as a callback for virtqueue_reset() to handle this. Fixes: c8bd1f7f3e61 ("virtio_net: add support for Byte Queue Limits") Cc: # v6.11+ Signe

[PATCH net v4 3/6] virtio_ring: add a func argument 'recycle_done' to virtqueue_resize()

When virtqueue_resize() has actually recycled all unused buffers, additional work may be required in some cases. Relying solely on its return status is fragile, so introduce a new function argument 'recycle_done', which is invoked when the recycle really occurs. Cc: # v6.11+ Signed-off-by: Koichi

[PATCH net v4 2/6] virtio_net: replace vq2rxq with vq2txq where appropriate

While not harmful, using vq2rxq where it's always sq appears odd. Replace it with the more appropriate vq2txq for clarity and correctness. Fixes: 89f86675cb03 ("virtio_net: xsk: tx: support xmit xsk buffer") Signed-off-by: Koichiro Den --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 inser

[PATCH net v4 1/6] virtio_net: correct netdev_tx_reset_queue() invocation point

When virtnet_close is followed by virtnet_open, some TX completions can possibly remain unconsumed, until they are finally processed during the first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash [1]. Commit b96ed2c97c79 ("virtio_net: move netdev_tx_reset_queue() call before RX

[PATCH net v4 0/6] virtio_net: correct netdev_tx_reset_queue() invocation points

When virtnet_close is followed by virtnet_open, some TX completions can possibly remain unconsumed, until they are finally processed during the first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash [1]. Commit b96ed2c97c79 ("virtio_net: move netdev_tx_reset_queue() call before RX

Re: [PATCH bpf v2 1/1] selftests/bpf: Actuate tx_metadata_len in xdp_hw_metadata

Hello: This patch was applied to bpf/bpf-next.git (net) by Martin KaFai Lau : On Thu, 5 Dec 2024 12:42:58 +0800 you wrote: > set XDP_UMEM_TX_METADATA_LEN flag to reserve tx_metadata_len bytes of > per-chunk metadata. > > Fixes: d5e726d9143c ("xsk: Require XDP_UMEM_TX_METADATA_LEN to actuate >

[RFC PATCH v1 2/2] selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC

Add tests to ensure that F_SEAL_FUTURE_EXEC behaves as expected. Cc: Suren Baghdasaryan Cc: Kalesh Singh Cc: John Stultz Signed-off-by: Isaac J. Manjarres --- tools/testing/selftests/memfd/memfd_test.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tools/testing/s

[RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

Android currently uses the ashmem driver [1] for creating shared memory regions between processes. Ashmem buffers can initially be mapped with PROT_READ, PROT_WRITE, and PROT_EXEC. Processes can then use the ASHMEM_SET_PROT_MASK ioctl command to restrict--never add--the permissions that the buffer

[RFC PATCH v1 0/2] Add file seal to prevent future exec mappings

Android uses the ashmem driver [1] for creating shared memory regions between processes. The ashmem driver exposes an ioctl command for processes to restrict the permissions an ashmem buffer can be mapped with. Buffers are created with the ability to be mapped as readable, writable, and executable

Re: [PATCH bpf-next v2 1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata

Hello: This patch was applied to bpf/bpf-next.git (net) by Martin KaFai Lau : On Thu, 5 Dec 2024 13:19:36 +0800 you wrote: > Currently, user needs to manually enable transmit hardware timestamp > feature of certain Ethernet drivers, e.g. stmmac and igc drivers, through > following command after

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Thu, Dec 05, 2024 at 10:17:59AM -0500, Michael S. Tsirkin wrote: > On Thu, Dec 05, 2024 at 10:16:35PM +0900, Koichiro Den wrote: > > On Thu, Dec 05, 2024 at 09:43:38PM +0900, Koichiro Den wrote: > > > On Thu, Dec 05, 2024 at 05:33:36AM -0500, Michael S. Tsirkin wrote: > > > > On Wed, Dec 04, 202

[PATCH v4] riscv: selftests: Fix warnings pointer masking test

Link to v3: https://lore.kernel.org/r/20241205-fix_warnings_pointer_masking_tests-v3-1-5c28b0f96...@rivosinc.com Changes in v3: - Fix sysctl enabled test case (Drew/Alex) - Move pwrite err condition into goto (Drew) - Link to v2: https://lore.kernel.org/r/20241204-fix_warnings_pointer_masking_te

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 01:30:59PM -0800, Charlie Jenkins wrote: > On Thu, Dec 05, 2024 at 09:04:12AM +0100, Andrew Jones wrote: > > On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: > > > When compiling the pointer masking tests with -Wall this warning > > > is present: > > > > > >

[PATCH v3] riscv: selftests: Fix warnings pointer masking test

When compiling the pointer masking tests with -Wall this warning is present: pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’ declared with attribute ‘warn_unused_result’ [-Wunused-result] 203 | pwrite(fd, &

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 09:11:46AM +0100, Alexandre Ghiti wrote: > Hi Charlie, > > On 05/12/2024 03:57, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: > > pointer_mas

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 09:04:12AM +0100, Andrew Jones wrote: > On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: > > When compiling the pointer masking tests with -Wall this warning > > is present: > > > > pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: > > pointer_ma

[PATCH v1 0/3] module: Don't fail module loading when setting ro_after_init section RO failed

This series reworks module loading to avoid leaving the module in a stale state when protecting ro_after_init section fails. Once module init has succeded it is too late to cancel loading. If setting ro_after_init data section to read-only fails, all we can do is to inform the user through a warni

Re: [PATCH v1] selftests/memfd: Run sysctl tests when PID namespace support is enabled

On Thu, Dec 5, 2024 at 11:29 AM Isaac J. Manjarres wrote: > > The sysctl tests for vm.memfd_noexec rely on the kernel to support PID > namespaces (i.e. the kernel is built with CONFIG_PID_NS=y). If the > kernel the test runs on does not support PID namespaces, the first > sysctl test will fail whe

[PATCH] cgroup/cpuset: Prevent leakage of isolated CPUs into sched domains

Isolated CPUs are not allowed to be used in a non-isolated partition. The only exception is the top cpuset which is allowed to contain boot time isolated CPUs. Commit ccac8e8de99c ("cgroup/cpuset: Fix remote root partition creation problem") introduces a simplified scheme of including only partiti

[PATCH v1 3/3] module: pre-test setting ro_after_init data read-only

To be on the safe side, try to set ro_after_init data section readonly at the same time as rodata. If it fails it will likely fail again later so let's cancel module loading while we still can do it. If it doesn't fail, put it back to read-write, continue module loading and cross fingers so that it

[PATCH v1 2/3] module: Don't fail module loading when setting ro_after_init section RO failed

Once module init has succeded it is too late to cancel loading. If setting ro_after_init data section to read-only fails, all we can do is to inform the user through a warning. Reported-by: Thomas Gleixner Closes: https://lore.kernel.org/all/20230915082126.4187913-1-ruanjin...@huawei.com/ Fixes:

[PATCH v1 1/3] module: Split module_enable_rodata_ro()

module_enable_rodata_ro() is called twice, once before module init to set rodata sections readonly and once after module init to set rodata_after_init section readonly. The second time, only the rodata_after_init section needs to be set to read-only, no need to re-apply it to already set rodata.

[PATCH v1] selftests/memfd: Run sysctl tests when PID namespace support is enabled

The sysctl tests for vm.memfd_noexec rely on the kernel to support PID namespaces (i.e. the kernel is built with CONFIG_PID_NS=y). If the kernel the test runs on does not support PID namespaces, the first sysctl test will fail when attempting to spawn a new thread in a new PID namespace, abort the

Re: [PATCH bpf-next 1/1] selftests/bpf: Enable Tx hwtstamp in xdp_hw_metadata

On 12/05, Song, Yoong Siang wrote: > On Wednesday, December 4, 2024 11:49 PM, Stanislav Fomichev > wrote: > >On 12/04, Song Yoong Siang wrote: > >> Set tx_type to HWTSTAMP_TX_ON to enable hardware timestamping for all > >> outgoing packets. > >> > >> Besides, set XDP_UMEM_TX_METADATA_LEN flag to

Re: [PATCH] selftests/mm: add fork CoW guard page test

* Lorenzo Stoakes [241205 14:07]: > When we fork anonymous pages, apply a guard page then remove it, the > previous CoW mapping is cleared. > > This might not be obvious to an outside observer without taking some time > to think about how the overall process functions, so document that this is >

[PATCH] selftests/mm: add fork CoW guard page test

When we fork anonymous pages, apply a guard page then remove it, the previous CoW mapping is cleared. This might not be obvious to an outside observer without taking some time to think about how the overall process functions, so document that this is the case through a test, which also usefully as

Re: [PATCH] openrisc: place exception table at the head of vmlinux

Hello, This looks ok to me too. I also confirmed that the symbols that end up in the .init.text of head.o are correct. I will queue this to go in the next rc. -Stafford On Mon, Dec 02, 2024 at 12:59:27PM -0800, Rong Xu wrote: > This looks good to me. > > Reviewed-by: Rong Xu > > -Rong > > O

[PATCH 1/4] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

Most users use this function through the BIN_ATTR_SIMPLE* macros, they can handle the switch transparently. Also adapt the two non-macro users in the same change. Signed-off-by: Thomas Weißschuh --- arch/powerpc/platforms/powernv/opal.c | 2 +- fs/sysfs/file.c | 2 +- inclu

Re: [PATCH v2 0/2] Modify the watchdog selftest for execution in non-interactive environments

On 11/19/24 08:01, Laura Nao wrote: This series is a follow-up to v1[1], aimed at making the watchdog selftest more suitable for CI environments. Currently, in non-interactive setups, the watchdog kselftest can only run with oneshot parameters, preventing the testing of the WDIOC_KEEPALIVE ioctl

Re: [PATCH v2 2/2] selftests/watchdog: convert the test output to KTAP format

On 11/19/24 08:01, Laura Nao wrote: Conform the test output to the KTAP format standard. The number of tests executed is determined by the script arguments, and options such as -c, -f, -h, -i, and -p do not impact the total test count. Didn't I review this patche before and say I don't see valu

Re: [PATCH v15 3/8] remoteproc: Introduce load_fw and release_fw optional operation

Hello Mathieu, Thanks for the review! I just need to clarify a point below before preparing the next revision. On 12/3/24 18:22, Mathieu Poirier wrote: > On Thu, Nov 28, 2024 at 09:42:10AM +0100, Arnaud Pouliquen wrote: >> This patch updates the rproc_ops structures to include two new optional >>

Re: [PATCH v2 1/2] riscv/ptrace: add new regset to access original a0 register

Hi Celeste, On 03/12/2024 10:30, Celeste Liu wrote: The orig_a0 is missing in struct user_regs_struct of riscv, and there is no way to add it without breaking UAPI. (See Link tag below) Like NT_ARM_SYSTEM_CALL do, we add a new regset name NT_RISCV_ORIG_A0 to access original a0 register from use

[PATCH 3/4] btf: Switch vmlinux BTF attribute to sysfs_bin_attr_simple_read()

The generic function from the sysfs core can replace the custom one. Signed-off-by: Thomas Weißschuh --- This is a replacement for [0], as Alexei was not happy about BIN_ATTR_SIMPLE_RO() [0] https://lore.kernel.org/lkml/20241122-sysfs-const-bin_attr-bpf-v1-1-823aea399...@weissschuh.net/ ---

[PATCH 2/4] platform/x86: wmi-bmof: Switch to sysfs_bin_attr_simple_read()

The generic function from the sysfs core can replace the custom one. Signed-off-by: Thomas Weißschuh --- drivers/platform/x86/wmi-bmof.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/wmi-bmof.c b/drivers/platform/x86/wmi-bmof.c index df6f

[PATCH 4/4] btf: Switch module BTF attribute to sysfs_bin_attr_simple_read()

The generic function from the sysfs core can replace the custom one. Signed-off-by: Thomas Weißschuh --- kernel/bpf/btf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index e7a59e6462a9331d0acb17a88a4ebf641509c050..69ca

[PATCH 0/4] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

Most users use this function through the BIN_ATTR_SIMPLE* macros, they can handle the switch transparently. This series is meant to be merged through the driver core tree. Signed-off-by: Thomas Weißschuh --- Thomas Weißschuh (4): sysfs: constify bin_attribute argument of sysfs_bin_attr_sim

Re: [PATCH] remoteproc: mtk_scp: Only populate devices SCP cores

Good day, On Mon, Dec 02, 2024 at 02:28:25PM +0800, Chen-Yu Tsai wrote: > When multi-core SCP support was added, the driver was made to populate > platform devices for all the sub-nodes. This ended up adding platform > devices for the rpmsg sub-nodes as well, which never actually get used, > since

[PATCH] preempt: Move PREEMPT_RT before PREEMPT in vermagic.

Since the dynamic preemption has been enabled for PREEMPT_RT we have now CONFIG_PREEMPT and CONFIG_PREEMPT_RT set simultaneously. This affects the vermagic strings which comes now PREEMPT with PREEMPT_RT enabled. The PREEMPT_RT module usually can not be loaded on a PREEMPT kernel because some symb

Re: [PATCH v6 01/18] tools: Add gendwarfksyms

Hi, On Thu, Dec 5, 2024 at 5:46 AM Masahiro Yamada wrote: > > On Wed, Nov 27, 2024 at 3:26 AM Luis Chamberlain wrote: > > > > On Tue, Nov 26, 2024 at 12:50:48PM +0900, Masahiro Yamada wrote: > > > On Tue, Nov 26, 2024 at 8:30 AM Luis Chamberlain > > > wrote: > > > > > > > > On Thu, Nov 21, 202

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Thu, Dec 05, 2024 at 10:16:35PM +0900, Koichiro Den wrote: > On Thu, Dec 05, 2024 at 09:43:38PM +0900, Koichiro Den wrote: > > On Thu, Dec 05, 2024 at 05:33:36AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 04, 2024 at 02:07:18PM +0900, Koichiro Den wrote: > > > > When virtnet_close is fol

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Thu, Dec 05, 2024 at 10:16:35PM +0900, Koichiro Den wrote: > On Thu, Dec 05, 2024 at 09:43:38PM +0900, Koichiro Den wrote: > > On Thu, Dec 05, 2024 at 05:33:36AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Dec 04, 2024 at 02:07:18PM +0900, Koichiro Den wrote: > > > > When virtnet_close is fol

[PATCH RT 1/1] Linux 4.19.325-rt140

v4.19.325-rt140-rc1 stable review patch. If anyone has any objections, please let me know. --- Signed-off-by: Daniel Wagner --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index e0b93414dc30..e27678f73d17 100644

[PATCH RT 0/1] Linux v4.19.325-rt140-rc1

Dear RT Folks, This is the RT stable review cycle of patch 4.19.325-rt140-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release is also available on kernel.org https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git on the v4.19-rt-nex

[ANNOUNCE] 4.19.324-rt139

Hello RT-list! I'm pleased to announce the 4.19.324-rt139 stable release. Just a stable update, no RT specific changes. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git branch: v4.19-rt Head SHA1: b33e0cf394c4dfb11c91395dd2

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Thu, Dec 05, 2024 at 09:43:38PM +0900, Koichiro Den wrote: > On Thu, Dec 05, 2024 at 05:33:36AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 04, 2024 at 02:07:18PM +0900, Koichiro Den wrote: > > > When virtnet_close is followed by virtnet_open, some TX completions can > > > possibly remain u

Re: [PATCH net-next v3 3/7] virtio_net: introduce virtnet_sq_free_unused_buf_done()

On Thu, Dec 05, 2024 at 05:40:33AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 04, 2024 at 02:07:20PM +0900, Koichiro Den wrote: > > This will be used in the following commits, to ensure DQL reset occurs > > iff. all unused buffers are actually recycled. > > > > Cc: # v6.11+ > > Signed-off-by:

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Thu, Dec 05, 2024 at 05:33:36AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 04, 2024 at 02:07:18PM +0900, Koichiro Den wrote: > > When virtnet_close is followed by virtnet_open, some TX completions can > > possibly remain unconsumed, until they are finally processed during the > > first NAPI

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Thu, Dec 05, 2024 at 12:15:16PM +0100, Alexandre Ghiti wrote: ... > Your mails often end up in my junk folder, am I the only one? Any idea what > could be wrong? > I'm constantly pulling legitimate mails out of Spam, usually ones from @google.com, which I heard was because spam filters, includi

Re: [PATCH RT 0/1] Linux v4.19.324-rt139-rc1

Hi! > This is the RT stable review cycle of patch 4.19.324-rt139-rc1. > > Please scream at me if I messed something up. Please test the patches > too. 4.19.324-rt139 would be very useful for our -cip-rt release, can we hope to get it soon? :-). We can also help, if required. Best regards,

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

Hi Drew, On 05/12/2024 09:04, Andrew Jones wrote: On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: When compiling the pointer masking tests with -Wall this warning is present: pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: pointer_masking.c:203:9: warning: ignori

Re: [PATCH net-next v3 0/7] virtio_net: correct netdev_tx_reset_queue() invocation points

On Wed, Dec 04, 2024 at 02:07:17PM +0900, Koichiro Den wrote: > When virtnet_close is followed by virtnet_open, some TX completions can > possibly remain unconsumed, until they are finally processed during the > first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash > [1]. Commit b

Re: [PATCH net v8 0/3] vsock/test: fix wrong setsockopt() parameters

Hello: This series was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 3 Dec 2024 09:06:53 -0600 you wrote: > Parameters were created using wrong C types, which caused them to be of > wrong size on some architectures, causing problems. > > The problem with SO_RCVLOWAT was found on s39

Re: [PATCH net-next v3 3/7] virtio_net: introduce virtnet_sq_free_unused_buf_done()

On Wed, Dec 04, 2024 at 02:07:20PM +0900, Koichiro Den wrote: > This will be used in the following commits, to ensure DQL reset occurs > iff. all unused buffers are actually recycled. > > Cc: # v6.11+ > Signed-off-by: Koichiro Den to avoid adding an unused function, squash with a patch that use

Re: [PATCH net-next v3 2/7] virtio_net: replace vq2rxq with vq2txq where appropriate

On Wed, Dec 04, 2024 at 02:07:19PM +0900, Koichiro Den wrote: > While not harmful, using vq2rxq where it's always sq appears odd. > Replace it with the more appropriate vq2txq for clarity and correctness. > > Fixes: 89f86675cb03 ("virtio_net: xsk: tx: support xmit xsk buffer") > Signed-off-by: Koi

Re: [PATCH net-next v3 1/7] virtio_net: correct netdev_tx_reset_queue() invocation point

On Wed, Dec 04, 2024 at 02:07:18PM +0900, Koichiro Den wrote: > When virtnet_close is followed by virtnet_open, some TX completions can > possibly remain unconsumed, until they are finally processed during the > first NAPI poll after the netdev_tx_reset_queue(), resulting in a crash > [1]. So it'

Re: [PATCH net-next v12 12/22] ovpn: implement multi-peer support

On 02/12/2024 16:07, Antonio Quartulli wrote: [...] + +/** + * ovpn_peer_unhash - remove peer reference from all hashtables + * @peer: the peer to remove + * @reason: the delete reason to attach to the peer + */ +static void ovpn_peer_unhash(struct ovpn_peer *peer, +en

Re: [PATCH net-next] selftests: net: cleanup busy_poller.c

On Tue, Dec 03, 2024 at 08:35:53AM -0800, Joe Damato wrote: > On Tue, Dec 03, 2024 at 08:26:11AM -0800, Joe Damato wrote: > > On Mon, Dec 02, 2024 at 09:14:58PM -0800, Stanislav Fomichev wrote: > > > On 12/03, Joe Damato wrote: > > > > Fix various integer type conversions by using strtoull and a te

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

Hi Charlie, On 05/12/2024 03:57, Charlie Jenkins wrote: When compiling the pointer masking tests with -Wall this warning is present: pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’ declared with attribute ‘warn_un

Re: RE: [RT,1/1] tty/serial/sifive: Make the locking RT aware

On 2024-12-04 15:24:38 [+], EnDe Tan wrote: > > -Original Message- > > You need to state which kernel this needs to be applied to. > > The change you looking for is > > 32c694ec3efc2 ("serial: sifive: Use uart_prepare_sysrq_char() to > > handle sysrq.") > > Thanks for pointing this

Re: [PATCH v2] riscv: selftests: Fix warnings pointer masking test

On Wed, Dec 04, 2024 at 06:57:10PM -0800, Charlie Jenkins wrote: > When compiling the pointer masking tests with -Wall this warning > is present: > > pointer_masking.c: In function ‘test_tagged_addr_abi_sysctl’: > pointer_masking.c:203:9: warning: ignoring return value of ‘pwrite’ > declared with