Re: [PATCH v2 3/4] vdpa/octeon_ep: read vendor-specific PCI capability

[Jason Wang]

On Thu, Nov 21, 2024 at 9:43 PM Shijith Thotton <sthot...@marvell.com> wrote:
>
> Added support to read the vendor-specific PCI capability to identify the
> type of device being emulated.
>
> Signed-off-by: Shijith Thotton <sthot...@marvell.com>
> ---
>  drivers/vdpa/octeon_ep/octep_vdpa.h      | 24 +++++++++++++++++
>  drivers/vdpa/octeon_ep/octep_vdpa_hw.c   | 34 +++++++++++++++++++++++-
>  drivers/vdpa/octeon_ep/octep_vdpa_main.c |  4 ++-
>  3 files changed, 60 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/octeon_ep/octep_vdpa.h 
> b/drivers/vdpa/octeon_ep/octep_vdpa.h
> index 2d4bb07f91b3..0f83a1eca408 100644
> --- a/drivers/vdpa/octeon_ep/octep_vdpa.h
> +++ b/drivers/vdpa/octeon_ep/octep_vdpa.h
> @@ -8,6 +8,7 @@
>  #include <linux/pci_regs.h>
>  #include <linux/vdpa.h>
>  #include <linux/virtio_pci_modern.h>
> +#include <uapi/linux/virtio_crypto.h>
>  #include <uapi/linux/virtio_net.h>
>  #include <uapi/linux/virtio_blk.h>
>  #include <uapi/linux/virtio_config.h>
> @@ -52,6 +53,28 @@ struct octep_vring_info {
>         phys_addr_t notify_pa;
>  };
>
> +enum octep_pci_vndr_cfg_type {
> +       OCTEP_PCI_VNDR_CFG_TYPE_VIRTIO_ID,
> +       OCTEP_PCI_VNDR_CFG_TYPE_MAX,
> +};
> +
> +struct octep_pci_vndr_data {
> +       u8 cap_vndr;
> +       u8 cap_next;
> +       u8 cap_len;
> +       u8 cfg_type;
> +       u16 vendor_id;

Is this better to define the above in uapi/linux/virtio_pci.h?

Others look good.

Thanks