Re: [PATCH v4 29/30] x86/mm, mm/vmalloc: Defer flush_tlb_kernel_range() targeting NOHZ_FULL CPUs

2025-02-26 Thread Valentin Schneider
On 20/02/25 09:38, Dave Hansen wrote: > On 2/20/25 09:10, Valentin Schneider wrote: >>> The LDT and maybe the PEBS buffers are the only implicit supervisor >>> accesses to vmalloc()'d memory that I can think of. But those are both >>> handled specially and shouldn't ever get zapped while in use. Th

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Lorenzo Stoakes
On Wed, Feb 26, 2025 at 05:26:04PM +0100, Oleg Nesterov wrote: > On 02/24, jef...@chromium.org wrote: > > > > Unlike other system mappings, the uprobe mapping is not > > established during program startup. However, its lifetime is the same > > as the process's lifetime. It could be sealed from crea

Re: [PATCH v7 4/7] mseal, system mappings: enable arm64

2025-02-26 Thread Lorenzo Stoakes
On Wed, Feb 26, 2025 at 09:17:10AM -0800, Jeff Xu wrote: > On Wed, Feb 26, 2025 at 9:12 AM Liam R. Howlett > wrote: > > > > * Lorenzo Stoakes [250226 00:26]: > > > On Tue, Feb 25, 2025 at 02:26:50PM -0800, Jeff Xu wrote: > > > > On Mon, Feb 24, 2025 at 10:20 PM Lorenzo Stoakes > > > > wrote: >

[PATCH v2 5/6] gpio: max77759: add Maxim MAX77759 gpio driver

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This driver supports the GPIO functions using the platform device registered by the core MFD driver. Sig

[PATCH v2 6/6] nvmem: max77759: add Maxim MAX77759 NVMEM driver

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This driver exposes the non volatile memory using the platform device registered by the core MFD driver.

[PATCH v2 0/6] Maxim Integrated MAX77759 PMIC MFD-based drivers

2025-02-26 Thread André Draszik
Hi, This series improves support for the Maxim Integrated MAX77759 companion PMIC for USB Type-C applications using the MFD framework. This series must be applied in-order, due to interdependencies of some of the patches: * to avoid use of undocumented compatibles by the newly added drivers, th

[PATCH v2 3/6] dt-bindings: mfd: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes the top-level device. Signed-off-by: André Draszik --- v2: * rename expected nvmem subd

[PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its GPIO module. Signed-off-by: André Draszik --- v2: * drop 'interrupts' property and

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-26 Thread André Draszik
I had just 'nvmem' initially, > but that doesn't work: > > .../maxim,max77759.example.dtb: pmic@66: nvmem: {'compatible': > ['maxim,max77759-nvmem'], 'nvmem-layout': {'compatible': ['fixed- > layout'], '#address-cells': 1, '#size-cells': 1, 'reboot-mode@0': {'reg': > [[0, 4]]}, 'boot-reason@4': {'reg': [[4, 4]]}, > 'shutdown-user-flag@8': {'reg': [[8, 1]]}, 'rsoc@10': {'reg': [[10, 2]]}}} is > not of type 'array' > from schema $id: > http://devicetree.org/schemas/nvmem/nvmem-consumer.yaml# > > I don't know if this can be made to work, i.e. can you have both > in yaml? Can a type be declared as a oneOf or something like that? I wasn't able to get this to work with a node name of just 'nvmem'. If anybody has any suggestions, I'll gladly try them. I've renamed the node from pmic-nvmem to nvmem-0 in v2, though. https://lore.kernel.org/all/20250226-max77759-mfd-v2-3-a65ebe2bc...@linaro.org/ Cheers, Andre

[PATCH v2 4/6] mfd: max77759: add Maxim MAX77759 core mfd driver

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. Fuel Gauge and TCPC have separate and independent I2C addresses, register maps, and interrupt lines and a

[PATCH v2 2/6] dt-bindings: nvmem: add max77759 binding

2025-02-26 Thread André Draszik
The Maxim MAX77759 is a companion PMIC for USB Type-C applications and includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C Port Controller (TCPC), NVMEM, and a GPIO expander. This describes its storage module (NVMEM). Signed-off-by: André Draszik --- v2: * drop example as the

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Lorenzo Stoakes
On Wed, Feb 26, 2025 at 07:01:36PM +0100, Oleg Nesterov wrote: > On 02/26, Lorenzo Stoakes wrote: > > > > On Wed, Feb 26, 2025 at 05:26:04PM +0100, Oleg Nesterov wrote: > > > On 02/24, jef...@chromium.org wrote: > > > > > > > > Unlike other system mappings, the uprobe mapping is not > > > > establi

[PATCH] scsi: elx: sli4: Replace deprecated strncpy() with strscpy()

2025-02-26 Thread Thorsten Blum
strncpy() is deprecated for NUL-terminated destination buffers; use strscpy() instead. Compile-tested only. Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Thorsten Blum --- drivers/scsi/elx/libefc_sli/sli4.c | 6 +++--- 1 file changed, 3 inserti

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-26 Thread Saeed Mahameed
On 26 Feb 13:47, Gustavo A. R. Silva wrote: -Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally. So, in this particular case, we create a new `struct mlx5e_umr_wqe_hdr` to enclose the header part of flexible structure `struct mlx5e_umr_wqe`. T

Re: [PATCH] thermal/debugfs: replace kzalloc() with kcalloc() in thermal_debug_tz_add()

2025-02-26 Thread Rafael J. Wysocki
On Sat, Feb 22, 2025 at 9:02 PM Ethan Carter Edwards wrote: > > We are trying to get rid of all multiplications from allocation > functions to prevent integer overflows[1]. Here the multiplication is > obviously safe, but using kcalloc() is more appropriate and improves > readability. This patch h

Re: [RFC] Circumventing FineIBT Via Entrypoints

2025-02-26 Thread Andrew Cooper
On 26/02/2025 10:48 pm, Rudolf Marek wrote: > Hi Andrew, > > Dne 25. 02. 25 v 22:14 Andrew Cooper napsal(a): >> As stand-in for "the reader", I'll point out that you need to add #DB to >> that list or you're in for a rude surprise when running the x86 >> selftests. > > Thanks for pointing this out.

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-26 Thread Jakub Kicinski
On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote: > On 26 Feb 13:47, Gustavo A. R. Silva wrote: > >-struct mlx5e_umr_wqe { > >+struct mlx5e_umr_wqe_hdr { > > struct mlx5_wqe_ctrl_seg ctrl; > > struct mlx5_wqe_umr_ctrl_seg uctrl; > > struct mlx5_mkey_seg mkc; > >

Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings

2025-02-26 Thread Gustavo A. R. Silva
-struct mlx5e_umr_wqe { +struct mlx5e_umr_wqe_hdr { struct mlx5_wqe_ctrl_seg   ctrl; struct mlx5_wqe_umr_ctrl_seg   uctrl; struct mlx5_mkey_seg   mkc; +}; + +struct mlx5e_umr_wqe { +    struct mlx5e_umr_wqe_hdr hdr; You missed or ignored my comment on v0, anyway: Can

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Oleg Nesterov
On 02/26, Oleg Nesterov wrote: > > On 02/24, jef...@chromium.org wrote: > > > > Unlike other system mappings, the uprobe mapping is not > > established during program startup. However, its lifetime is the same > > as the process's lifetime. It could be sealed from creation. > > Agreed, VM_SEALED sh

Re: [PATCH v7 4/7] mseal, system mappings: enable arm64

2025-02-26 Thread Jeff Xu
On Wed, Feb 26, 2025 at 9:12 AM Liam R. Howlett wrote: > > * Lorenzo Stoakes [250226 00:26]: > > On Tue, Feb 25, 2025 at 02:26:50PM -0800, Jeff Xu wrote: > > > On Mon, Feb 24, 2025 at 10:20 PM Lorenzo Stoakes > > > wrote: > > > > > > > > On Mon, Feb 24, 2025 at 10:52:43PM +, jef...@chromium.

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Oleg Nesterov
On 02/26, Lorenzo Stoakes wrote: > > On Wed, Feb 26, 2025 at 05:26:04PM +0100, Oleg Nesterov wrote: > > On 02/24, jef...@chromium.org wrote: > > > > > > Unlike other system mappings, the uprobe mapping is not > > > established during program startup. However, its lifetime is the same > > > as the p

Re: [PATCH v7 4/7] mseal, system mappings: enable arm64

2025-02-26 Thread Lorenzo Stoakes
On Wed, Feb 26, 2025 at 05:43:22PM +, Lorenzo Stoakes wrote: > On Wed, Feb 26, 2025 at 09:17:10AM -0800, Jeff Xu wrote: > > On Wed, Feb 26, 2025 at 9:12 AM Liam R. Howlett > > wrote: > > > > > > * Lorenzo Stoakes [250226 00:26]: > > > > On Tue, Feb 25, 2025 at 02:26:50PM -0800, Jeff Xu wrote

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Oleg Nesterov
On 02/26, Lorenzo Stoakes wrote: > > Like I said, Jeff opposes the change. I disagree with him, and agree with you, > because this is very silly. > > But I don't want to hold up this series with that discussion (this is for his > sake...) Neither me, so lets go with VM_SEALED_SYSMAP. My only obje

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Liam R. Howlett
* Lorenzo Stoakes [250226 13:06]: > On Wed, Feb 26, 2025 at 07:01:36PM +0100, Oleg Nesterov wrote: > > On 02/26, Lorenzo Stoakes wrote: > > > > > > On Wed, Feb 26, 2025 at 05:26:04PM +0100, Oleg Nesterov wrote: > > > > On 02/24, jef...@chromium.org wrote: > > > > > > > > > > Unlike other system ma

Re: [PATCH v7 4/7] mseal, system mappings: enable arm64

2025-02-26 Thread Liam R. Howlett
* Lorenzo Stoakes [250226 00:26]: > On Tue, Feb 25, 2025 at 02:26:50PM -0800, Jeff Xu wrote: > > On Mon, Feb 24, 2025 at 10:20 PM Lorenzo Stoakes > > wrote: > > > > > > On Mon, Feb 24, 2025 at 10:52:43PM +, jef...@chromium.org wrote: > > > > From: Jeff Xu > > > > > > > > Provide support for

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Oleg Nesterov
On 02/24, jef...@chromium.org wrote: > > Unlike other system mappings, the uprobe mapping is not > established during program startup. However, its lifetime is the same > as the process's lifetime. It could be sealed from creation. Agreed, VM_SEALED should be always for the "[uprobes]" vma, regard

Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping

2025-02-26 Thread Lorenzo Stoakes
On Wed, Feb 26, 2025 at 07:20:50PM +0100, Oleg Nesterov wrote: > On 02/26, Lorenzo Stoakes wrote: > > > > Like I said, Jeff opposes the change. I disagree with him, and agree with > > you, > > because this is very silly. > > > > But I don't want to hold up this series with that discussion (this is

Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding

2025-02-26 Thread Rob Herring (Arm)
ngs/gpio/maxim,max77759-gpio.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml: Documentation/devicetree/bindings/mfd/maxim,max77759.yaml See https://patchwork.ozlabs.org/project/devic

Re: [PATCH v2 2/6] dt-bindings: nvmem: add max77759 binding

2025-02-26 Thread Rob Herring (Arm)
evicetree/bindings/mfd/maxim,max77759.yaml See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-max77759-mfd-v2-2-a65ebe2bc...@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran '

Re: [RFC] Circumventing FineIBT Via Entrypoints

2025-02-26 Thread Rudolf Marek
Hi Andrew, Dne 25. 02. 25 v 22:14 Andrew Cooper napsal(a): As stand-in for "the reader", I'll point out that you need to add #DB to that list or you're in for a rude surprise when running the x86 selftests. Thanks for pointing this out. I forgot about the interrupt shadow on SYSCALL and possib

[PATCH] scsi: target: Replace deprecated strncpy() with strscpy()

2025-02-26 Thread Thorsten Blum
Since strncpy() is deprecated for NUL-terminated destination buffers, use strscpy() instead. Compile-tested only. Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Thorsten Blum --- drivers/target/target_core_configfs.c | 2 +- 1 file changed, 1 in