Re: [PATCH v2] ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC

2025-03-12 Thread Krzysztof Kozlowski
y: Mars Yang > Cc: Krzysztof Kozlowski > Cc: Andrew Lunn > Cc: Paul Menzel > Link: Reference to Ast2600 SOC: https://www.aspeedtech.com/server_ast2600/ [1] > Link: Reference to Blackwell GB200NVL Platform: > https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2] L

Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8

2025-03-10 Thread Krzysztof Kozlowski
ilbox and might interfere with applying entire sets. > Signed-off-by: Gabriel Gonzales > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many

Re: [PATCH v4 0/7] Add support for the Exynos7870 SoC, along with three devices

2025-03-05 Thread Krzysztof Kozlowski
On 28/02/2025 20:46, Kaustabh Chakraborty wrote: > Additional features implemented in this series include: > * I2C- touchscreen, IIO sensors, etc. > * UART - bluetooth and serial debugging > * MMC- eMMC, Wi-Fi SDIO, SDCard > * USB- micro-USB 2.0 interface > > Buil

Re: (subset) [PATCH v4 3/7] soc: samsung: exynos-chipid: add support for exynos7870

2025-03-05 Thread Krzysztof Kozlowski
k/linux/c/13a24175005fad410464bee482ed58af144ba250 Best regards, -- Krzysztof Kozlowski

Re: (subset) [PATCH v4 1/7] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible

2025-03-05 Thread Krzysztof Kozlowski
or the USB PHY). > > Applied, thanks! [1/7] dt-bindings: soc: samsung: exynos-pmu: add exynos7870-pmu compatible https://git.kernel.org/krzk/linux/c/bf869ecfb8d3d0fef07ed2752df93c977cc257b6 Best regards, -- Krzysztof Kozlowski

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread Krzysztof Kozlowski
On 24/02/2025 11:28, André Draszik wrote: > + gpio-controller: true > + > + "#gpio-cells": > +const: 2 > + > + gpio: > +$ref: /schemas/gpio/maxim,max77759-gpio.yaml There is no such file at this moment, so this is not bisectable. What's more, even if you fix it, you will have dependency

Re: [PATCH 1/6] dt-bindings: mfd: add max77759 binding

2025-02-24 Thread Krzysztof Kozlowski
On 24/02/2025 14:02, André Draszik wrote: > On Mon, 2025-02-24 at 06:48 -0600, Rob Herring (Arm) wrote: >> >> On Mon, 24 Feb 2025 10:28:49 +, André Draszik wrote: >>> Add device tree binding for the Maxim MAX77759 companion PMIC for USB >>> Type-C applications. >>> >>> The MAX77759 includes Bat

Re: [PATCH v3 1/7] dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible

2025-02-21 Thread Krzysztof Kozlowski
On Wed, Feb 19, 2025 at 12:33:11AM +0530, Kaustabh Chakraborty wrote: > Document the compatible string "samsung,exynos7870-chipid". The > registers are entirely compatible with "samsung,exynos4210-chipid". A bit odd (exynos7885 is compatible with 850), but I guess you really checked that. Best re

Re: (subset) [PATCH v3 1/7] dt-bindings: hwinfo: samsung,exynos-chipid: add exynos7870-chipid compatible

2025-02-21 Thread Krzysztof Kozlowski
os-chipid: add exynos7870-chipid compatible https://git.kernel.org/krzk/linux/c/0a86ea5534a9e4ae988a2e174e741b102d8a8691 Best regards, -- Krzysztof Kozlowski

Re: [PATCH v3 3/7] soc: samsung: exynos-chipid: add support for exynos7870

2025-02-21 Thread Krzysztof Kozlowski
On Wed, Feb 19, 2025 at 12:33:13AM +0530, Kaustabh Chakraborty wrote: > Add the product ID of Exynos7870 (S5E7870) to the existing list. > > Signed-off-by: Kaustabh Chakraborty > --- > drivers/soc/samsung/exynos-chipid.c | 1 + > 1 file changed, 1 insertion(+) > This does not apply anymore - c

Re: [PATCH v3 0/7] Add support for the Exynos7870 SoC, along with three devices

2025-02-21 Thread Krzysztof Kozlowski
On Wed, Feb 19, 2025 at 12:33:10AM +0530, Kaustabh Chakraborty wrote: > Samsung Exynos 7870 (codename: Joshua) is an ARM-v8 system-on-chip that was > announced in 2016. The chipset was found in several popular mid-range to > low-end Samsung phones, released within 2016 to 2019. > > This patch seri

Re: [PATCH v2 2/5] arm64: dts: exynos: add initial devicetree support for exynos7870

2025-02-04 Thread Krzysztof Kozlowski
On 04/02/2025 19:22, Ivaylo Ivanov wrote: >> + >> +#include >> +#include >> +#include >> + >> +/ { >> +compatible = "samsung,exynos7870"; >> +#address-cells = <2>; >> +#size-cells = <1>; >> + >> +/* Samsung's bootloader (S-BOOT) checks for these DT properties */ >> +model_inf

Re: [PATCH] ARM: dts: aspeed: Add device tree for Nvidia's GB200NVL BMC

2025-01-24 Thread Krzysztof Kozlowski
On Fri, Jan 24, 2025 at 05:18:19AM +, Willie Thai wrote: > From: wthai This does not match SoB. > > The GB200NVL BMC is an Aspeed Ast2600 based BMC > for Nvidia Blackwell GB200NVL platform. > > Signed-off-by: wthai Full name. > --- > .../bindings/arm/aspeed/aspeed.yaml |

Re: [PATCH v14 4/4] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2025-01-16 Thread Krzysztof Kozlowski
On 16/01/2025 16:47, Duje Mihanović wrote: >>> >>> +ARM/Marvell PXA1908 SOC support >>> +M: Duje Mihanović >>> +L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) >>> +S: Maintained >>> +T: git https://gitlab.com/LegoLivesMatter/linux >> >> Not sure if this was mentioned ever

Re: [PATCH v14 3/4] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte

2025-01-16 Thread Krzysztof Kozlowski
On Wed, Jan 15, 2025 at 09:35:56PM +0100, Duje Mihanović wrote: > Add DTS for Marvell PXA1908 SoC and Samsung Galaxy Core Prime Value > Edition LTE, a smartphone based on said SoC. > > Signed-off-by: Duje Mihanović > --- > arch/arm64/boot/dts/marvell/Makefile | 3 + > .../dts/mar

Re: [PATCH v14 4/4] MAINTAINERS: add myself as Marvell PXA1908 maintainer

2025-01-15 Thread Krzysztof Kozlowski
On Wed, Jan 15, 2025 at 09:35:57PM +0100, Duje Mihanović wrote: > Add myself as the maintainer for Marvell PXA1908 SoC support. > > Signed-off-by: Duje Mihanović > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index > a87ddad78e

Re: [PATCH v14 2/4] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform

2025-01-15 Thread Krzysztof Kozlowski
On Wed, Jan 15, 2025 at 09:35:55PM +0100, Duje Mihanović wrote: > Add ARCH_MMP configuration option for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović > --- > arch/arm64/Kconfig.platforms | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Krzysztof Kozlow

Re: [PATCH v2 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0

2024-10-31 Thread Krzysztof Kozlowski
On 31/10/2024 09:24, Andreas Kemnade wrote: > Am Thu, 31 Oct 2024 09:18:49 +0100 > schrieb Krzysztof Kozlowski : > >> On Wed, Oct 30, 2024 at 09:18:43PM +, Mithil Bavishi wrote: >>> Add samsung-espresso7 codename for the 7 inch variant >>>

Re: [PATCH v2 4/6] arm/dts: Add initial support for Galaxy Tab 2 7.0

2024-10-31 Thread Krzysztof Kozlowski
On Wed, Oct 30, 2024 at 09:18:44PM +, Mithil Bavishi wrote: > Create a device tree for the 3 inch variants (P3100, P3110, P3113) 3 inch variants of what? Describe here the hardware. > > Signed-off-by: Mithil Bavishi > --- Please use subject prefixes matching the subsystem. You can get them

Re: [PATCH v2 3/6] dt-bindings: omap: Add Samaung Galaxy Tab 2 7.0

2024-10-31 Thread Krzysztof Kozlowski
On Wed, Oct 30, 2024 at 09:18:43PM +, Mithil Bavishi wrote: > Add samsung-espresso7 codename for the 7 inch variant > > Signed-off-by: Mithil Bavishi > --- > Documentation/devicetree/bindings/arm/ti/omap.yaml | 1 + > 1 file changed, 1 insertion(+) > This is v2, so where is the changelog? S

Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible

2024-08-13 Thread Krzysztof Kozlowski
On 13/08/2024 21:33, Rob Herring wrote: > On Fri, Aug 09, 2024 at 07:39:53AM +0200, Krzysztof Kozlowski wrote: >> On 08/08/2024 20:40, Danila Tikhonov wrote: >>> The PN553 is another NFC chip from NXP, document the compatible in the >>> bindings. >>>

Re: [PATCH v2 05/11] dt-bindings: soc: qcom: qcom,pmic-glink: Document SM7325 compatible

2024-08-08 Thread Krzysztof Kozlowski
Platform > by using the QCM6490 bindings as fallback. > > Signed-off-by: Danila Tikhonov > --- > .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml| 5 + > 1 file changed, 5 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 06/11] dt-bindings: nfc: nxp,nci: Document PN553 compatible

2024-08-08 Thread Krzysztof Kozlowski
On 08/08/2024 20:40, Danila Tikhonov wrote: > The PN553 is another NFC chip from NXP, document the compatible in the > bindings. > > Signed-off-by: Danila Tikhonov > --- > Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentati

Re: [PATCH 10/11] dt-bindings: arm: qcom: Add SM7325 Nothing Phone 1

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > Nothing Phone 1 (nothing,spacewar) is a smartphone based on the SM7325 > SoC. > > Signed-off-by: Danila Tikhonov Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 11/11] arm64: dts: qcom: sm7325: Add device-tree for Nothing Phone 1

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > From: Eugene Lepshy > > Add device tree for the Nothing Phone 1 (nothing,spacewar) smartphone > which is based on the SM7325 SoC. ... > + > +&i2c2 { > + clock-frequency = <10>; > + status = "okay"; > + > + /* nxp,tfa9873 (EAR speaker

Re: [PATCH 09/11] dt-bindings: vendor-prefixes: Add Nothing Technology Limited

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > Add entry for Nothing Technology Limited (https://nl.nothing.tech/) > > Signed-off-by: Danila Tikhonov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 07/11] dt-bindings: arm: cpus: Add qcom kryo670 compatible

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > The Qualcomm Snapdragon 778G/778G+/780G/782G uses CPUs named Kryo 670. > Add the compatible string in the documentation. > > Signed-off-by: Danila Tikhonov > --- > Documentation/devicetree/bindings/arm/cpus.yaml | 1 + Acked-by: K

Re: [PATCH 06/11] usb: typec: ucsi: Add qcom,sm7325-pmic-glink as needing PDOS quirk

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > The SM7325 Linux Android firmware needs this workaround as well. Add it > to the list. > > Signed-off-by: Danila Tikhonov > --- > drivers/usb/typec/ucsi/ucsi_glink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucs

Re: [PATCH 01/11] dt-bindings: arm: qcom,ids: Add IDs for SM7325 family

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > Add Qualcomm SM7325/SM7325P (yupik) SoC IDs. > > Signed-off-by: Danila Tikhonov > --- > include/dt-bindings/arm/qcom,ids.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 02/11] soc: qcom: socinfo: Add Soc IDs for SM7325 family

2024-07-30 Thread Krzysztof Kozlowski
On 29/07/2024 22:18, Danila Tikhonov wrote: > Add Soc ID table entries for Qualcomm SM7325 family. > > Signed-off-by: Danila Tikhonov > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] ARM: dts: qcom: msm8974pro-samsung-klte: Add pstore node

2024-07-15 Thread Krzysztof Kozlowski
On 15/07/2024 10:32, Bingwu Zhang wrote: > From: Bingwu Zhang > > Add pstore node to allow for retrieving crash logs. > > Tested-by: Bingwu Zhang # on SM-G9008W > (samsung-kltechn) Tested-by tags are provided by others, not by yourself. It's expected that you test youro own patches. Drop the

Re: [PATCH v4 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280

2024-03-27 Thread Krzysztof Kozlowski
On 27/03/2024 12:35, Odelu Kukatla wrote: >>> maxItems: 1 >>> >>> + clocks: >>> +minItems: 1 >>> +maxItems: 2 >> >> Why is this flexible? Nothing in commit msg explains that. I gave the >> same talk twice, gave there examples, yet it is not enough... >> > > Clocks property is optio

Re: [PATCH v4 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support

2024-03-27 Thread Krzysztof Kozlowski
On 26/03/2024 21:56, Konrad Dybcio wrote: > On 25.03.2024 7:16 PM, Odelu Kukatla wrote: >> It adds QoS support for QNOC device and includes support for >> configuring priority, priority forward disable, urgency forwarding. >> This helps in priortizing the traffic originating from different >> inter

Re: [PATCH v4 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280

2024-03-26 Thread Krzysztof Kozlowski
On 25/03/2024 19:16, Odelu Kukatla wrote: > Added clock property to enable clocks required for accessing > qos registers. > > Signed-off-by: Odelu Kukatla > --- > .../bindings/interconnect/qcom,sc7280-rpmh.yaml| 14 ++ > 1 file changed, 14 insertions(+) > > diff --git > a/Docum

Re: [PATCH v6 1/4] dt-bindings: arm: qcom: Document QCS8550 SoC and the AIM300 AIoT board

2024-03-08 Thread Krzysztof Kozlowski
s a highly optimized family of modules designed to > support AIoT applications. It integrates QCS8550 SoC, UFS and PMIC chip > etc. > AIM stands for Artificial Intelligence Module. AIoT stands for AI IoT. > > Signed-off-by: Tengfei Fan Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] interconnect: qcom: icc-rpmh: Add QoS configuration support

2024-03-06 Thread Krzysztof Kozlowski
On 06/03/2024 08:30, Odelu Kukatla wrote: > It adds QoS support for QNOC device and includes support for > configuring priority, priority forward disable, urgency forwarding. > This helps in priortizing the traffic originating from different > interconnect masters at NoC(Network On Chip). > > Sign

Re: [PATCH v3 3/4] dt-bindings: interconnect: add clock property to enable QOS on SC7280

2024-03-06 Thread Krzysztof Kozlowski
On 06/03/2024 08:30, Odelu Kukatla wrote: > Added clock property to enable clocks required for accessing > qos registers. > > Signed-off-by: Odelu Kukatla > --- > .../interconnect/qcom,sc7280-rpmh.yaml| 49 +++ > 1 file changed, 49 insertions(+) > > diff --git > a/Docum

Re: [PATCH v5 1/4] dt-bindings: arm: qcom: Document QCS8550 SoC and the AIM300 AIoT board

2024-03-03 Thread Krzysztof Kozlowski
On 01/03/2024 14:41, Tengfei Fan wrote: > Document QCS8550 SoC and the AIM300 AIoT board bindings. > QCS8550 is derived from SM8550. The difference between SM8550 and > QCS8550 is QCS8550 doesn't have modem RF system. QCS8550 is mainly used > in IoT scenarios. > AIM300 Series is a highly optimized

Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree

2024-02-26 Thread Krzysztof Kozlowski
On 27/02/2024 05:33, Raihan Ahamed wrote: > I have checked again with latest dtschema before sending version 3 it > doesn't give anything related to gpu and iommu At least the second warning looks real, but the error was already there - in the DTSI. Best regards, Krzysztof

Re: [PATCH v3 2/2] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree

2024-02-26 Thread Krzysztof Kozlowski
> > Acked-by: Rob Herring > Acked-by: Krzysztof Kozlowski No, these did not happen! Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add Lenovo P2

2024-02-26 Thread Krzysztof Kozlowski
ead) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Acked-by: Krzysztof Kozlowski --- This is an automated instruction, just in case, because many review tags are being ignored. If you

Re: [PATCH] arm64: dts: qcom: msm8953-lenovo-kuntao: Add initial device tree

2024-02-25 Thread Krzysztof Kozlowski
On 26/02/2024 06:55, Raihan Ahamed wrote: > Lenovo P2 is a handset using the MSM8953 SoC released in 2016 > > Add a device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - WCNSS (WiFi/BT) > - Regulators > > Signed-off-by: Raihan

Re: [PATCH 2/7] dt-bindings: arm: qcom: Add Xperia 1 V

2024-02-12 Thread Krzysztof Kozlowski
On 12/02/2024 14:10, Konrad Dybcio wrote: > Document the SM8550 SONY Xperia 1 V (PDX234) board. > > Signed-off-by: Konrad Dybcio Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/7] dt-bindings: ASoC: cs35l45: Add interrupts

2024-02-12 Thread Krzysztof Kozlowski
On 12/02/2024 14:10, Konrad Dybcio wrote: > This chip seems to have an IRQ line, let us describe it. > > Signed-off-by: Konrad Dybcio Subject: ASoC: dt-bindings: cs35l45.. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:51, Svyatoslav Ryhel wrote: > чт, 1 лют. 2024 р. о 11:22 Krzysztof Kozlowski > пише: >> >> On 01/02/2024 10:20, Svyatoslav Ryhel wrote: >>> + pinmux@7868 { >>> + pinctrl-names = "default";

Re: [PATCH v2 3/3] ARM: tegra: Add device-tree for LG Optimus 4X HD (P880)

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:20, Svyatoslav Ryhel wrote: > + pinmux@7868 { > + pinctrl-names = "default"; > + pinctrl-0 = <&state_default>; > + > + state_default: pinmux { > + /* WLAN SDIO pinmux */ > + host_wlan_wake { Not mu

Re: [PATCH v2 1/3] dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880

2024-02-01 Thread Krzysztof Kozlowski
On 01/02/2024 10:20, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Add a compatible for the LG Optimus Vu P895 and Optimus 4X P880. > > Signed-off-by: Maxim Schwalm > Signed-off-by: Svyatoslav Ryhel > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 3/4] ARM: tegra: Add device-tree for LG Optimus Vu (P895)

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > Add device-tree for LG Optimus Vu P895, which is a NVIDIA > Tegra30-based smartphone, orignally running Android. > > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/boot/dts/nvidia/Makefile|1 + > arch/arm/boot/dts/nvidia/tegra30-lg

Re: [PATCH v1 2/4] dt-bindings: arm: tegra: Add LG Optimus Vu P895 and Optimus 4X P880

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > From: Maxim Schwalm > > Add a compatible for the LG Optimus Vu P895 and Optimus 4X P880. > > Signed-off-by: Maxim Schwalm > --- > Documentation/devicetree/bindings/arm/tegra.yaml | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Do

Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 17:06, Svyatoslav wrote: > > > 31 січня 2024 р. 18:02:31 GMT+02:00, Conor Dooley > написав(-ла): >> On Wed, Jan 31, 2024 at 05:30:58PM +0200, Svyatoslav wrote: >>> >>> >>> 31 січня 2024 р. 17:28:49 GMT+02:00, Conor Dooley >>> написав(-ла): On Wed, Jan 31, 2024 at 12:51:50PM

Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add LG Electronics, Inc. prefix

2024-02-01 Thread Krzysztof Kozlowski
On 31/01/2024 11:51, Svyatoslav Ryhel wrote: > Add missing LG Electronics, Inc. prefix used by some older devices. > > Signed-off-by: Svyatoslav Ryhel > --- NAK, same reasons as before: https://lore.kernel.org/all/9942f964-442e-e782-3926-6d7d11234...@canonical.com/ Best regards, Krzysztof

Re: [PATCH v3 2/3] dt-bindings: Add DPS310 as trivial device

2024-01-11 Thread Krzysztof Kozlowski
On 11/01/2024 19:12, Ninad Palsule wrote: > Infineon DPS310 is a barometric pressure and temperature sensor. > > Signed-off-by: Ninad Palsule This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a

Re: [PATCH v3 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc

2024-01-11 Thread Krzysztof Kozlowski
On 11/01/2024 19:12, Ninad Palsule wrote: > Document the new compatibles used on IBM system1-bmc > > Signed-off-by: Ninad Palsule > --- > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > 1 file changed, 1 insertion(+) This is a friendly reminder during the review process. It l

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 21:34, Krzysztof Kozlowski wrote: >>>>>>>>>> I have send it as a separate commit. >>>>>>>>>> https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ >>>>>>>>> Why did

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 20:06, Guenter Roeck wrote: > On 1/10/24 09:54, Krzysztof Kozlowski wrote: >> On 10/01/2024 16:54, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> >>> On 1/10/24 09:37, Krzysztof Kozlowski wrote: >>>> On 10/

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
On 10/01/2024 16:54, Ninad Palsule wrote: > Hello Krzysztof, > > > On 1/10/24 09:37, Krzysztof Kozlowski wrote: >> On 10/01/2024 15:31, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> >>> >>>>>>> I have

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-10 Thread Krzysztof Kozlowski
ds undocumented compatibles to the >>>> driver. Please, as Rob requested, work with Lukas on his series to make >>>> sure that these devices are documented. >>> I think krzysztof kozlowski suggested to send these patches separately: >>> https://lore.kernel.

Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

2024-01-09 Thread Krzysztof Kozlowski
t;>>>> Delete this from every patch that it appears from. >>> >>> I have send it as a separate commit. >>> https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ni...@linux.ibm.com/ >> Why did you do that? It now just adds undocumented compatibles to

Re: [PATCH v2 2/3] dt-bindings: Add DPS310 as trivial device

2024-01-09 Thread Krzysztof Kozlowski
On 08/01/2024 21:41, Ninad Palsule wrote: > Infineon DPS310 is a barometric pressure and temperature sensor. > > Signed-off-by: Ninad Palsule > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: arm: aspeed: add IBM system1-bmc

2024-01-09 Thread Krzysztof Kozlowski
On 08/01/2024 21:41, Ninad Palsule wrote: > Document the new compatibles used on IBM system1-bmc > > Signed-off-by: Ninad Palsule Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes

2023-12-14 Thread Krzysztof Kozlowski
On 14/12/2023 19:34, Ninad Palsule wrote: >>> chosen { >>> stdout-path = &uart5; >>> bootargs = "console=ttyS4,115200n8 earlycon"; >>> @@ -54,10 +113,12 @@ vga_memory: region@bf00 { >>> reg = <0xbf00 0x0100>; /* 16M */ >>> };

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 20:49, Ninad Palsule wrote: > Hello Krzysztof, > > On 12/13/23 13:37, Krzysztof Kozlowski wrote: >> On 13/12/2023 20:02, Ninad Palsule wrote: >>> Hello Krzysztof, >>> >>> On 12/12/23 14:26, Krzysztof Kozlowski wrote: >>>> On

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-13 Thread Krzysztof Kozlowski
On 13/12/2023 20:02, Ninad Palsule wrote: > Hello Krzysztof, > > On 12/12/23 14:26, Krzysztof Kozlowski wrote: >> On 12/12/2023 17:40, Ninad Palsule wrote: >>> This drop adds following devices in the device tree. >>> - EEPROM/VPD >>> - Power supplie

Re: [PATCH v1 8/8] ARM: dts: aspeed: System1: PS, sensor and more

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 17:40, Ninad Palsule wrote: > This drop adds following devices in the device tree. > - EEPROM/VPD > - Power supplies > - Humidity, pressure and temperature sensors. > - Trusted platform module(TPM) chip > > Tested: > This board is tested using the simics simulator. > > Signed-of

Re: [PATCH v1 6/8] ARM: dts: aspeed: System1: GPIO, Fan ctrl, Led

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 17:40, Ninad Palsule wrote: > This commit adds following devices to the device tree. > - GPIO pin assignements, GPIO expansion devices > - LED brinker devices > - Fan controllers > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Ninad Palsule > -

Re: [PATCH v1 5/8] ARM: dts: aspeed: System1: Voltage regulators

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 17:40, Ninad Palsule wrote: > This commit adds different voltage regulators. > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Ninad Palsule > --- > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 266 ++ Squash it. > 1 file ch

Re: [PATCH v1 4/8] ARM: dts: aspeed: System1: Add i2c and muxes

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 17:40, Ninad Palsule wrote: > This commit adds i2c devices and muxes. > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Ninad Palsule > --- > .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 577 ++ > 1 file changed, 577 insertion

Re: [PATCH v1 3/8] ARM: dts: aspeed: System1: IBM system1 BMC board

2023-12-12 Thread Krzysztof Kozlowski
On 12/12/2023 17:39, Ninad Palsule wrote: > From: Andrew Geissler > > Add a device tree for IBM system1 BMC board. It uses AST2600 SOC. > > Tested: > This board is tested using the simics simulator. > > Signed-off-by: Andrew Geissler > Signed-off-by: Ninad Palsule > --- > arch/arm/boot/d

Re: [PATCH v9 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-24 Thread Krzysztof Kozlowski
On 24/10/2023 08:37, Luka Panio wrote: > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc. > > Signed-off-by: Luka Panio > --- > v2: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v8 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-23 Thread Krzysztof Kozlowski
On 23/10/2023 11:02, Luka Panio wrote: > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc. > > Signed-off-by: Luka Panio > --- > v2: > Update commit message. Drop reserved gpio's as this device in reality do not > have gpio, and pins are not protected. > > v3: > Update commit messa

Re: [PATCH v6 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-23 Thread Krzysztof Kozlowski
On 23/10/2023 08:50, Luka Panio wrote: >> Did you base your work on these files? This would explain the license, >> but then please include original copyrights. > No, but the sm8250.dtsi that I do include has that license. Same as > all other sm8250 device's dts's so i thought mine should not be >

Re: [PATCH v6 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-22 Thread Krzysztof Kozlowski
On 22/10/2023 21:56, Luka Panio wrote: > On Sun, Oct 22, 2023 at 8:46 PM Krzysztof Kozlowski > wrote: > >> If there are no other copyrights here, why did you use BSD-3 license? > I am by no means a licensing expert, but as sm8250.dts did use BSD-3 > and other device tree&

Re: [PATCH v5 1/2] From: Luka Panio

2023-10-22 Thread Krzysztof Kozlowski
On 22/10/2023 19:26, Luka Panio wrote: >>> dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa) > >> Your subject is not correct. > > Sorry, but what should be there? Your subject is: "From: Luka Panio" Subject contains git commit subject. See git log --- PATH for ideas. > >> Please include

Re: [PATCH v6 2/2] arm64: dts: qcom: sm8250-xiaomi-pipa: Add initial device tree

2023-10-22 Thread Krzysztof Kozlowski
On 22/10/2023 19:38, Luka Panio wrote: > Initial support for Xiaomi Pad 6 tablet, that have sm8250 soc. > > Signed-off-by: Luka Panio > --- > v2: > Update commit message. Drop reserved gpio's as this device in reality do not > have gpio, and pins are not protected. > > v3: > Update commit mess

Re: [PATCH v5 1/2] From: Luka Panio

2023-10-22 Thread Krzysztof Kozlowski
On 21/10/2023 22:34, Luka Panio wrote: > dt-bindings: arm: qcom: Add Xiaomi Pad 6 (xiaomi-pipa) Your subject is not correct. > > Add a compatible for Xiaomi Pad 6. > > Signed-off-by: Luka Panio > > --- > Update commit message Please include full changelog. This is v5 so what happened between

Re: [PATCH] arm64: dts: exynos: Add reserved memory for pstore on E850-96

2023-10-12 Thread Krzysztof Kozlowski
On 12/10/2023 22:02, Krzysztof Kozlowski wrote: > > On Sat, 07 Oct 2023 22:36:33 -0500, Sam Protsenko wrote: >> Reserve a 2 MiB memory region to record kmsg dumps, console, ftrace and >> userspace messages. The implemented memory split allows capturing and >> reading co

Re: [PATCH] arm64: dts: exynos: Add reserved memory for pstore on E850-96

2023-10-12 Thread Krzysztof Kozlowski
565a3ff760fa7 Best regards, -- Krzysztof Kozlowski

Re: [PATCH v6 2/9] dt-bindings: pinctrl: pinctrl-single: add marvell,pxa1908-padconf compatible

2023-10-12 Thread Krzysztof Kozlowski
On 10/10/2023 19:27, Duje Mihanović wrote: > Add the "marvell,pxa1908-padconf" compatible to allow migrating to a > separate pinctrl driver later. > > Signed-off-by: Duje Mihanović > --- > Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml | 4 > 1 file changed, 4 insertions(+) >

Re: [PATCH] pinctrl: samsung: Annotate struct exynos_muxed_weint_data with __counted_by

2023-10-08 Thread Krzysztof Kozlowski
gt; its initialization earlier. > > [...] Applied, thanks! [1/1] pinctrl: samsung: Annotate struct exynos_muxed_weint_data with __counted_by https://git.kernel.org/pinctrl/samsung/c/4e1e21117e7e1275477ba80e634c769a511249bd Best regards, -- Krzysztof Kozlowski

Re: [PATCH] memory: atmel-ebi: Annotate struct atmel_ebi_dev with __counted_by

2023-09-24 Thread Krzysztof Kozlowski
t.kernel.org/krzk/linux-mem-ctrl/c/c1f2c81631df7654c249a457b7a54bbc36042248 Best regards, -- Krzysztof Kozlowski