Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Sascha Hauer
On Wed, Mar 21, 2012 at 01:44:01AM -0600, Paul Walmsley wrote: > Hello Saravana, > > Certainly a Kconfig help text change seems trivial enough. But even the > resistance to CONFIG_EXPERIMENTAL has been quite surprising to me, given > that every single defconfig in arch/arm/defconfig sets it: >

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-21 Thread Saravana Kannan
On Tue, March 20, 2012 7:02 am, Shawn Guo wrote: > On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote: > ... >> +struct clk_ops { >> +int (*prepare)(struct clk_hw *hw); >> +void(*unprepare)(struct clk_hw *hw); >> +int (*enable)(struct clk

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Paul Walmsley
Hello Arnd, On Sat, 17 Mar 2012, Arnd Bergmann wrote: > I think it's rather pointless, because the option is not going to > be user selectable but will get selected by the platform unless I'm > mistaken. The platform maintainers that care already know the state > of the framework. This is where

[PATCH v8 8/8] SH: shmobile: Consolidate time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/sh/kernel/cpu/shmobile/cpuidle.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletio

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Arnd Bergmann
On Tuesday 20 March 2012, Kevin Hilman wrote: > Maybe it's time that drivers/cpuidle gets a maintainer. With lots of > discussions of scheduler changes that affect load estimation, I suspect > we're all going to have a bit of CPUidle work to do in the > not-so-distant future. Hmm, according to th

[PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Robert Lee
This patch series moves various functionality duplicated in platform cpuidle drivers to the core cpuidle driver. Also, the platform irq disabling was removed as it appears that all calls into cpuidle_call_idle will have already called local_irq_disable(). These changes have been pulled into linu

[PATCH v8 1/8] cpuidle: Add common time keeping and irq enabling

2012-03-21 Thread Robert Lee
Make necessary changes to implement time keeping and irq enabling in the core cpuidle code. This will allow the removal of these functionalities from various platform cpuidle implementations whose timekeeping and irq enabling follows the form in this common code. Signed-off-by: Robert Lee Tested

[PATCH v8 2/8] ARM: at91: Consolidate time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/arm/mach-at91/cpuidle.c | 67 +++--- 1 file changed, 24

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Rafael J. Wysocki
On Wednesday, March 21, 2012, Amit Kucheria wrote: > On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote: > > Arnd Bergmann writes: > > > >> On Tuesday 20 March 2012, Robert Lee wrote: > >>> This patch series moves various functionality duplicated in platform > >>> cpuidle drivers to the core cp

[PATCH v8 3/8] ARM: kirkwood: Consolidate time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/arm/mach-kirkwood/cpuidle.c | 72 +++--- 1 file changed, 21

[PATCH v8 5/8] ARM: omap: Consolidate OMAP3 time keeping and irq enable

2012-03-21 Thread Robert Lee
Use core cpuidle timekeeping and irqen wrapper and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Tested-by: Jean Pihet Acked-by: Jean Pihet --- arch/arm/mach-omap2/cpuidle34xx.c | 42 +++--

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Paul Walmsley
Hello Sascha, On Sat, 17 Mar 2012, Sascha Hauer wrote: > On Fri, Mar 16, 2012 at 04:21:17PM -0600, Paul Walmsley wrote: > > > If the common clock code is to go upstream now, it should be marked as > > experimental. > > No, please don't do this. This effectively marks the architectures using >

[PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/arm/mach-davinci/cpuidle.c | 82 --- 1 file changed, 33

[PATCH v8 6/8] ARM: omap: Consolidate OMAP4 time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/arm/mach-omap2/cpuidle44xx.c | 21 +++-- 1 file changed, 3 insertions(+), 18

[PATCH v8 7/8] ARM: shmobile: Consolidate time keeping and irq enable

2012-03-21 Thread Robert Lee
Enable core cpuidle timekeeping and irq enabling and remove that handling from this code. Signed-off-by: Robert Lee Reviewed-by: Kevin Hilman Reviewed-by: Daniel Lezcano Acked-by: Jean Pihet --- arch/arm/mach-shmobile/cpuidle.c | 31 +++ 1 file changed, 7 insertio

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Arnd Bergmann
On Tuesday 20 March 2012, Robert Lee wrote: > This patch series moves various functionality duplicated in platform > cpuidle drivers to the core cpuidle driver. Also, the platform irq > disabling was removed as it appears that all calls into > cpuidle_call_idle will have already called local_irq_

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Amit Kucheria
On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote: > Arnd Bergmann writes: > >> On Tuesday 20 March 2012, Robert Lee wrote: >>> This patch series moves various functionality duplicated in platform >>> cpuidle drivers to the core cpuidle driver. Also, the platform irq >>> disabling was removed

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Kevin Hilman
Arnd Bergmann writes: > On Tuesday 20 March 2012, Robert Lee wrote: >> This patch series moves various functionality duplicated in platform >> cpuidle drivers to the core cpuidle driver. Also, the platform irq >> disabling was removed as it appears that all calls into >> cpuidle_call_idle will

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Kevin Hilman
Hi Rob, Robert Lee writes: > This patch series moves various functionality duplicated in platform > cpuidle drivers to the core cpuidle driver. Also, the platform irq > disabling was removed as it appears that all calls into > cpuidle_call_idle will have already called local_irq_disable(). > >

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Nicolas Pitre
On Tue, 20 Mar 2012, Kevin Hilman wrote: > Looks like you never heard from anyone actively working on at91, > shmobile, kirwood or davinci. > > I'm not sure we should merge those platform-specific changes without an > ack from those platform maintainers. Depends. There is a limit to how long yo

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Kevin Hilman
Arnd Bergmann writes: > On Tuesday 20 March 2012, Kevin Hilman wrote: >> Maybe it's time that drivers/cpuidle gets a maintainer. With lots of >> discussions of scheduler changes that affect load estimation, I suspect >> we're all going to have a bit of CPUidle work to do in the >> not-so-distant

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Nicolas Pitre
On Wed, 21 Mar 2012, Amit Kucheria wrote: > On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote: > > Maybe it's time that drivers/cpuidle gets a maintainer.  With lots of > > discussions of scheduler changes that affect load estimation, I suspect > > we're all going to have a bit of CPUidle work

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Deepthi Dharwar
On 03/21/2012 05:31 AM, Rafael J. Wysocki wrote: > On Wednesday, March 21, 2012, Amit Kucheria wrote: >> On Wed, Mar 21, 2012 at 12:48 AM, Kevin Hilman wrote: >>> Arnd Bergmann writes: >>> On Tuesday 20 March 2012, Robert Lee wrote: > This patch series moves various functionality duplic

Re: [PATCH v7 2/3] clk: introduce the common clock framework

2012-03-21 Thread Saravana Kannan
On 03/20/2012 04:53 PM, Turquette, Mike wrote: On Tue, Mar 20, 2012 at 10:46 AM, Saravana Kannan wrote: On Tue, March 20, 2012 7:02 am, Shawn Guo wrote: On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote: ... +struct clk_ops { +int (*prepare)(struct clk_hw *hw); +

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/20/2012 08:15 PM, Nicolas Pitre wrote: On Tue, 20 Mar 2012, Paul Walmsley wrote: We need to indicate in some way that the existing code and API is very likely to change in ways that could involve quite a bit of work for adopters. [...] Anyway. It is okay if we want to have some start

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Rob Lee
On Tue, Mar 20, 2012 at 7:10 PM, Kevin Hilman wrote: > Hi Rob, > > Robert Lee writes: > >> This patch series moves various functionality duplicated in platform >> cpuidle drivers to the core cpuidle driver. Also, the platform irq >> disabling was removed as it appears that all calls into >> cpuid

Re: [PATCH v8 0/8] Consolidate cpuidle functionality

2012-03-21 Thread Len Brown
> So, I suggest that if neither Len nor Arjan reappear shortly, people can > send CPUidle patches to me. /me reappears this series is in my tree now, and I'll be poking at it a bit tomorrow. If everything is happy I'll send it for 3.4. thanks, -Len ___

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Paul Walmsley
Hello Nico, On Tue, 20 Mar 2012, Nicolas Pitre wrote: > This common clk API has been under development for over *two* years > already, with several attempts to merge it. And each previous merge > attempt aborted because someone came along at the last minute to do > exactly what you are doing

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Paul Walmsley
Hello Saravana, On Tue, 20 Mar 2012, Saravana Kannan wrote: > To add a few more thoughts, while I agree with Paul that there is room for > improvement in the APIs, I think the difference in opinion comes when we ask > the question: > > "When we eventually refine the APIs in the future to be more

[RFC][PATCH 4/7] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

2012-03-21 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 0455858..254f97b 100644 --- a/arch/arm/mach-omap2/cpuidle44xx.c +++ b/arch/arm

[RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. A couple a things call my intention. Why the cpuidle device is set for cpu0 only and why the WFI is not used ? Daniel Lezcano (7): ARM: OMAP4: cpuidle -

[RFC][PATCH 7/7] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time

2012-03-21 Thread Daniel Lezcano
We initialized it at compile time, no need to do that at boot time. Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c | 26 +- 1 files changed, 1 insertions(+), 25 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpui

[RFC][PATCH 3/7] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table

2012-03-21 Thread Daniel Lezcano
We do not longer need this table as we defined the values in the driver states. Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle

[RFC][PATCH 6/7] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

2012-03-21 Thread Daniel Lezcano
We are storing the 'omap4_idle_data' in the private data field if the cpuidle device. As we are using this variable only in this file, that does not really make sense. Let's use the global variable directly instead dereferencing pointers in an idle critical loop. Also, that simplfies the code. Si

[RFC][PATCH 5/7] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time

2012-03-21 Thread Daniel Lezcano
Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index 254f97b..e14cd56 100644 --- a/arch/arm/mach-omap2/cpuidle44x

[RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

2012-03-21 Thread Daniel Lezcano
The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle44xx.c b/arch/arm/mach-omap2/cpuidle44xx.c index cfdbb86.

[RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

2012-03-21 Thread Daniel Lezcano
The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at boot time. Signed-off-by: Daniel Lezcano --- arch/arm/mach-omap2/cpuidle44xx.c | 56

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Shilimkar, Santosh
On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano wrote: > This patchset is a proposition to improve a bit the code. > The changes are code cleanup and does not change the behavior of the > driver itself. > Thanks. Will have a look at your series. > A couple a things call my intention. Why the cpui

Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

2012-03-21 Thread Shilimkar, Santosh
On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano wrote: > The 'valid' field is never used in the code, let's remove it. > > Signed-off-by: Daniel Lezcano > --- It is used during the registration. This field has been very useful for debug when need to disable a C-state etc. So unless and until ther

Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano wrote: The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano --- It is used during the registration. This field has been very useful for debug when need to

Re: [RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

2012-03-21 Thread Santosh Shilimkar
+ Jean, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: > The cpuidle API allows to declare statically the states in the driver > structure. Let's use it. > We do no longer need the fill_cstate function called at runtime and > by the way adding more instructions at boot time. > > Signe

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. Thanks. Will have a look at your series. Co

Re: [RFC][PATCH 4/7] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

2012-03-21 Thread Santosh Shilimkar
On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: > Signed-off-by: Daniel Lezcano > --- > arch/arm/mach-omap2/cpuidle44xx.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/cpuidle44xx.c > b/arch/arm/mach-omap2/cpuidle44xx.c > index 045

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Santosh Shilimkar
On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: > On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: >> On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano >> wrote: >>> This patchset is a proposition to improve a bit the code. >>> The changes are code cleanup and does not change the behavi

Re: [PATCH] usb: gadget: s3c-hsotg: fix kernel panic

2012-03-21 Thread Felipe Balbi
Hi, On Mon, Mar 19, 2012 at 05:52:08PM +0100, Lukasz Majewski wrote: > On Fri, 16 Mar 2012 13:35:20 + > Sangwook Lee wrote: > > > Fix kernel panic from s3c_hsotg_udc_stop. > > if udc_is_newstyle is true, s3c_hsotg_udc_stop should not > > call disconnect, unbind. > > > > As running rmmod g_ma

Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

2012-03-21 Thread Santosh Shilimkar
On Wednesday 21 March 2012 03:16 PM, Daniel Lezcano wrote: > On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: >> On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano >> wrote: >>> The 'valid' field is never used in the code, let's remove it. >>> >>> Signed-off-by: Daniel Lezcano >>> --- >> It is used

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Arnd Bergmann
On Tuesday 20 March 2012, Paul Walmsley wrote: > Hello Arnd, > > On Sat, 17 Mar 2012, Arnd Bergmann wrote: > > > I think it's rather pointless, because the option is not going to > > be user selectable but will get selected by the platform unless I'm > > mistaken. The platform maintainers that ca

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Santosh Shilimkar
Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: > This patchset is a proposition to improve a bit the code. > The changes are code cleanup and does not change the behavior of the > driver itself. > > A couple a things call my intention. Why the cpuidle device is set for cpu0 >

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 10:56 AM, Santosh Shilimkar wrote: On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of the driver itself. A couple a things call my intention.

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Shilimkar, Santosh
On Wed, Mar 21, 2012 at 4:13 PM, Daniel Lezcano wrote: > On 03/21/2012 10:56 AM, Santosh Shilimkar wrote: >> >> On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: >>> >>> On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano   wro

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 11:49 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 4:13 PM, Daniel Lezcano wrote: On 03/21/2012 10:56 AM, Santosh Shilimkar wrote: On Wednesday 21 March 2012 03:21 PM, Daniel Lezcano wrote: On 03/21/2012 10:36 AM, Shilimkar, Santosh wrote: On Wed, Mar 21, 2012 at 2

Re: [PATCH] usb: gadget: s3c-hsotg: fix kernel panic

2012-03-21 Thread Lukasz Majewski
On Wed, 21 Mar 2012 11:56:23 +0200 Felipe Balbi wrote: Hi Felipe, > > > This patch is based on Lukasz Majewski's patches: > > > [PATCH 0/9] USB: s3c-hsotg: USB S3C-HSOTG driver fixes and code > > > cleanu > > > This patch shall be placed on top of the above patch series. Unfortunately those pat

[PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Amit Daniel Kachhap
Basically without this patch changing the mode of thermal zone is not possible as wrong string size is passed to strncmp. Signed-off-by: Amit Daniel Kachhap --- drivers/thermal/thermal_sys.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/thermal_sys.c

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Jean Pihet
Hi Santosh, Daniel, On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: > Daniel, > > On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: >> This patchset is a proposition to improve a bit the code. >> The changes are code cleanup and does not change the behavior of the >> driver it

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Nicolas Pitre
On Wed, 21 Mar 2012, Paul Walmsley wrote: > Hello Nico, > > On Tue, 20 Mar 2012, Nicolas Pitre wrote: > > > This common clk API has been under development for over *two* years > > already, with several attempts to merge it. And each previous merge > > attempt aborted because someone came alon

Re: [RFC][PATCH 1/7] ARM: OMAP4: cpuidle - Remove unused valid field

2012-03-21 Thread Jean Pihet
On Wed, Mar 21, 2012 at 11:03 AM, Santosh Shilimkar wrote: > On Wednesday 21 March 2012 03:16 PM, Daniel Lezcano wrote: >> On 03/21/2012 10:41 AM, Shilimkar, Santosh wrote: >>> On Wed, Mar 21, 2012 at 2:57 PM, Daniel Lezcano >>>  wrote: The 'valid' field is never used in the code, let's remo

Re: [RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

2012-03-21 Thread Jean Pihet
On Wed, Mar 21, 2012 at 10:27 AM, Daniel Lezcano wrote: > The cpuidle API allows to declare statically the states in the driver > structure. Let's use it. > We do no longer need the fill_cstate function called at runtime and > by the way adding more instructions at boot time. > > Signed-off-by: Da

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Jean Pihet
On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: > Daniel, > > On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: >> This patchset is a proposition to improve a bit the code. >> The changes are code cleanup and does not change the behavior of the >> driver itself. >> >> A couple

Re: [RFC][PATCH 2/7] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 02:31 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 10:27 AM, Daniel Lezcano wrote: The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructio

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 02:19 PM, Jean Pihet wrote: Hi Santosh, Daniel, On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not cha

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 02:43 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of t

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Shilimkar, Santosh
On Wed, Mar 21, 2012 at 6:49 PM, Jean Pihet wrote: > Hi Santosh, Daniel, > > On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar > wrote: >> Daniel, >> >> On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: >>> This patchset is a proposition to improve a bit the code. >>> The changes are c

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: > Basically without this patch changing the mode of thermal zone > is not possible as wrong string size is passed to strncmp. Actually it is possible, $ echo -n disabled > mode works fine. But it fails without the -n, your patch would

Re: [PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Rob Lee
On Wed, Mar 21, 2012 at 9:28 AM, Rob Lee wrote: > Sekhar tested this patch on Davinci last night and found a problem.  I > looked at the code again and found a mindless omission on my part (see > below).  Fix is trivial.  I've check all other platforms and confirmed > this problem does not exist f

Re: [PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Rob Lee
Sekhar tested this patch on Davinci last night and found a problem. I looked at the code again and found a mindless omission on my part (see below). Fix is trivial. I've check all other platforms and confirmed this problem does not exist for those. Will resend a v9 of the patchset shortly. On

Re: [PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Amit Kucheria
Rob, you should start a new '3.4-fixes' branch containing such bugfixes that can be pushed to Len after -rc1. On Wed, Mar 21, 2012 at 4:28 PM, Rob Lee wrote: > Sekhar tested this patch on Davinci last night and found a problem.  I > looked at the code again and found a mindless omission on my par

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Eric Paris
On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled >

Re: ci.linaro.org planned downtime.

2012-03-21 Thread James Tunnicliffe
Hi, We have a new machine ready to run ci.linaro.org - we just need to move across the existing data. Since ci.linaro.org just hung we are going to shut down jenkins and get on with moving the data across. I hope the next announcement will be that we have a new machine and everything is running sm

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
Hi Eric, On Wed, 21 Mar 2012 10:47:52 -0400, Eric Paris wrote: > On Wed, Mar 21, 2012 at 10:13 AM, Jean Delvare wrote: > > Note that a quick grep suggests that drivers/misc/ad525x_dpot.c, > > security/selinux/hooks.c and arch/m68k/sun3/prom/console.c suffer from > > the same issue, if you want to

RE: [PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Nori, Sekhar
Hi Rob, On Wed, Mar 21, 2012 at 01:52:45, Robert Lee wrote: > Enable core cpuidle timekeeping and irq enabling and remove that > handling from this code. > > Signed-off-by: Robert Lee > Reviewed-by: Kevin Hilman > Reviewed-by: Daniel Lezcano > Acked-by: Jean Pihet > static struct cpuidle_dri

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Jean Delvare
On Wed, 21 Mar 2012 16:14:46 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 21, 2012 at 15:13, Jean Delvare wrote: > > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: > >> Basically without this patch changing the mode of thermal zone > >> is not possible as wrong string size is pas

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Geert Uytterhoeven
On Wed, Mar 21, 2012 at 15:13, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled > mo

Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Dave Martin
Hi all, Does anybody know how to stop the Gmail webmail frontend from corrupting sequences of space characters in preformatted text? When replying to a plaintext mail, Gmail seems to turn every second space into an ISO8859-1/Unicode non-breaking space character (U00A0). This seems to be a wor

Re: Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Joey STANFORD
Not much help but the going work-around is to not use the webmail interface for this and use mutt, thunderbird, etc. via imap and smtp. The added advantage there is you can add extensions to linkify bugs and such for places like launchpad, bugzilla, etc.. J On Wed, Mar 21, 2012 at 9:55 AM, Dav

RE: [PATCH v8 4/8] ARM: davinci: Consolidate time keeping and irq enable

2012-03-21 Thread Nori, Sekhar
Hi Amit, On Wed, Mar 21, 2012 at 20:06:29, Amit Kucheria wrote: > Rob, you should start a new '3.4-fixes' branch containing such > bugfixes that can be pushed to Len after -rc1. I think it is OK to send the fixes to Len right away so he can queue the fixes during merge window if he gets the chanc

Re: Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Dave Martin
On Wed, Mar 21, 2012 at 10:06:54AM -0600, Joey STANFORD wrote: > Not much help but the going work-around is to not use the webmail > interface for this and use mutt, thunderbird, etc. via imap and smtp. > The added advantage there is you can add extensions to linkify bugs > and such for places l

Re: Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Amber Graner
I had this happen as well, when using gmail in Chromium for things that I would cut and paste; however, it did not happen in Firefox. The way I worked around it was to use Firefox or barring that I would save the email as a draft, open it back up fix the spaces, then resave as a draft and view it

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 02:43 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are code cleanup and does not change the behavior of t

[PATCH] ARM: davinci: Fix for cpuidle consolidation changes

2012-03-21 Thread Robert Lee
The recent cpuidle consolidation changes erroneously omitted one critical line of code. Signed-off-by: Robert Lee --- arch/arm/mach-davinci/cpuidle.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-davinci/cpuidle.c b/arch/arm/mach-davinci/cpuidle.c

Re: Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Dave Martin
On Wed, Mar 21, 2012 at 12:20:22PM -0400, Amber Graner wrote: > I had this happen as well, when using gmail in Chromium for things that I > would cut and paste; however, it did not happen in Firefox. The way I > worked around it was to use Firefox or barring that I would save the email > as a draf

RE: [PATCH] ARM: davinci: Fix for cpuidle consolidation changes

2012-03-21 Thread Nori, Sekhar
On Wed, Mar 21, 2012 at 22:18:25, Robert Lee wrote: > The recent cpuidle consolidation changes erroneously omitted one > critical line of code. > > Signed-off-by: Robert Lee Tested this on a DA850 EVM. Acked-by: Sekhar Nori Thanks, Sekhar ___ lina

Re: Gmail corrupting spaces in plain-text mail?

2012-03-21 Thread Jon Medhurst (Tixy)
On Wed, 2012-03-21 at 15:55 +, Dave Martin wrote: > Does anybody know how to stop the Gmail webmail frontend from corrupting > sequences of space characters in preformatted text? > > Apart from "never reply to patches via webmail", does anyone know a > workaround? Have all the Gmail mail fo

ci.linaro.org is back and (hopefully) stable.

2012-03-21 Thread James Tunnicliffe
Hi, The migration of ci.linaro.org to new hardware is complete. We hope that this will result in a more stable and responsive system. We have had a few builds run successfully so everything seems to be fine, but we will be keeping an eye on it. Please let the infrastructure team know of any proble

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Mark Brown
On Wed, Mar 21, 2012 at 11:38:58AM -0700, Saravana Kannan wrote: > >So it would be interesting to know more about why you (or anyone else) > >perceive that the Kconfig changes would be harmful. > But the enthusiasm of the clock driver developers doesn't > necessarily translate to users of the clo

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Tony Lindgren
* Mark Brown [120321 12:11]: > On Wed, Mar 21, 2012 at 11:38:58AM -0700, Saravana Kannan wrote: > > > >So it would be interesting to know more about why you (or anyone else) > > >perceive that the Kconfig changes would be harmful. > > > But the enthusiasm of the clock driver developers doesn't >

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Mark Brown
On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: > On 03/21/2012 12:33 PM, Tony Lindgren wrote: > >* Mark Brown [120321 12:11]: > >>These aren't new APIs, the clock API has been around since forever. > I disagree. When I say clock API, I mean the actual functions and > their sema

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Mark Brown
On Wed, Mar 21, 2012 at 01:04:22PM -0700, Saravana Kannan wrote: > Sure, prepare/unprepare are already there in the .h file. But they > are stubs and have no impact till we move to the common clock > framework or platforms move to them with their own implementation > (certainly not happening in up

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Kevin Hilman
Daniel Lezcano writes: > On 03/21/2012 02:43 PM, Jean Pihet wrote: >> On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar >> wrote: >>> Daniel, >>> >>> On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the code. The changes are

Re: [RFC][PATCH 0/7] OMAP4 cpuidle cleanup

2012-03-21 Thread Daniel Lezcano
On 03/21/2012 10:54 PM, Kevin Hilman wrote: Daniel Lezcano writes: On 03/21/2012 02:43 PM, Jean Pihet wrote: On Wed, Mar 21, 2012 at 11:07 AM, Santosh Shilimkar wrote: Daniel, On Wednesday 21 March 2012 02:57 PM, Daniel Lezcano wrote: This patchset is a proposition to improve a bit the

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Russell King - ARM Linux
On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: > The meaning of clk_enable/disable has been changed and they won't work > without calling clk_prepare/unprepare. So, these are definitely new > APIs. If it weren't new APIs, then none of the general drivers would > need to chan

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:56 PM, Mark Brown wrote: On Wed, Mar 21, 2012 at 12:41:41PM -0700, Saravana Kannan wrote: On 03/21/2012 12:33 PM, Tony Lindgren wrote: * Mark Brown [120321 12:11]: These aren't new APIs, the clock API has been around since forever. I disagree. When I say clock API, I me

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:33 PM, Tony Lindgren wrote: * Mark Brown [120321 12:11]: On Wed, Mar 21, 2012 at 11:38:58AM -0700, Saravana Kannan wrote: So it would be interesting to know more about why you (or anyone else) perceive that the Kconfig changes would be harmful. But the enthusiasm of the cl

Re: [PATCH v7 1/3] Documentation: common clk API

2012-03-21 Thread Saravana Kannan
On 03/21/2012 12:44 AM, Paul Walmsley wrote: Hello Saravana, On Tue, 20 Mar 2012, Saravana Kannan wrote: To add a few more thoughts, while I agree with Paul that there is room for improvement in the APIs, I think the difference in opinion comes when we ask the question: "When we eventually re

Re: [PATCH] thermal: Fix for setting the thermal zone mode to enable/disable

2012-03-21 Thread Amit Kachhap
On 21 March 2012 19:43, Jean Delvare wrote: > On Wed, 21 Mar 2012 16:40:01 +0530, Amit Daniel Kachhap wrote: >> Basically without this patch changing the mode of thermal zone >> is not possible as wrong string size is passed to strncmp. > > Actually it is possible, > $ echo -n disabled > mode > wo

Re: [PATCH v13] Regulator: Add Anatop regulator driver

2012-03-21 Thread Shawn Guo
On Wed, Mar 14, 2012 at 10:29:12AM +0800, Ying-Chun Liu (PaulLiu) wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop is an integrated regulator inside i.MX6 SoC. > There are 3 digital regulators which controls PU, CORE (ARM), and SOC. > And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).

Re: [PATCH v13] Regulator: Add Anatop regulator driver

2012-03-21 Thread Ying-Chun Liu (PaulLiu)
(2012年03月22日 13:24), Shawn Guo wrote: > On Wed, Mar 14, 2012 at 10:29:12AM +0800, Ying-Chun Liu (PaulLiu) wrote: >> From: "Ying-Chun Liu (PaulLiu)" >> >> Anatop is an integrated regulator inside i.MX6 SoC. >> There are 3 digital regulators which controls PU, CORE (ARM), and SOC. >> And 3 analog re