Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-24 Thread Shawn Guo
On 25 April 2012 03:51, Russell King - ARM Linux wrote: > On Tue, Apr 24, 2012 at 10:40:35AM -0500, Rob Lee wrote: >> Thanks for the attention on this.  From what I've understood, I will >> send another submission that includes the imx cpuidle patchset and >> Shawn's device tree late initcall patc

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2012 at 10:40:35AM -0500, Rob Lee wrote: > Thanks for the attention on this. From what I've understood, I will > send another submission that includes the imx cpuidle patchset and > Shawn's device tree late initcall patchset and I'll provide > explanation of the two separate patchs

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-24 Thread Rob Lee
On Tue, Apr 24, 2012 at 3:36 AM, Shawn Guo wrote: > On Tue, Apr 24, 2012 at 08:54:26AM +0100, Russell King - ARM Linux wrote: >> On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote: >> > On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: >> > > >> Let me try last time.  What about havi

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-24 Thread Shawn Guo
On Tue, Apr 24, 2012 at 08:54:26AM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote: > > On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: > > > >> Let me try last time.  What about having a late_initcall hook in > > > >> machine_desc? > > >

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2012 at 09:38:43AM +0800, Shawn Guo wrote: > On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: > > >> Let me try last time.  What about having a late_initcall hook in > > >> machine_desc? > > > > > > Also fine with me. > > > > > > > Shall I add Shawn's patch to my imx cpuidl

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-23 Thread Shawn Guo
On Mon, Apr 23, 2012 at 10:45:02AM -0500, Rob Lee wrote: > >> Let me try last time.  What about having a late_initcall hook in > >> machine_desc? > > > > Also fine with me. > > > > Shall I add Shawn's patch to my imx cpuidle patchset or should the > arch/arm/kernel/setup.c and arch.h changes be su

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-23 Thread Rob Lee
>> Let me try last time.  What about having a late_initcall hook in >> machine_desc? > > Also fine with me. > Shall I add Shawn's patch to my imx cpuidle patchset or should the arch/arm/kernel/setup.c and arch.h changes be submitted separately? If separately, Shawn, did you want to submit this pat

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-23 Thread Sascha Hauer
On Mon, Apr 23, 2012 at 03:10:15PM +0800, Shawn Guo wrote: > On Mon, Apr 23, 2012 at 08:56:23AM +0200, Sascha Hauer wrote: > > On Mon, Apr 23, 2012 at 02:53:01PM +0800, Shawn Guo wrote: > > > On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote: > > > > On Mon, Apr 23, 2012 at 01:18:21PM +0

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-23 Thread Shawn Guo
On Mon, Apr 23, 2012 at 08:56:23AM +0200, Sascha Hauer wrote: > On Mon, Apr 23, 2012 at 02:53:01PM +0800, Shawn Guo wrote: > > On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote: > > > On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote: > > > > On Sun, Apr 22, 2012 at 11:44:39PM -0

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-22 Thread Sascha Hauer
On Mon, Apr 23, 2012 at 02:53:01PM +0800, Shawn Guo wrote: > On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote: > > On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote: > > > On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote: > > > > >> I don't think we need a cpu_is_imx6q(),

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-22 Thread Shawn Guo
On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote: > On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote: > > On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote: > > > >> I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific > > > >> hook at device_initcall ti

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-22 Thread Sascha Hauer
On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote: > On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote: > > >> I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific > > >> hook at device_initcall time can't be too wrong. Shawn? > > >> > > > Yep, it works for me. > > >

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-22 Thread Shawn Guo
On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote: > >> I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific > >> hook at device_initcall time can't be too wrong. Shawn? > >> > > Yep, it works for me. > > > Sascha, Shawn, thanks for the response. > > Since device_initcall i

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-22 Thread Rob Lee
>> I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific >> hook at device_initcall time can't be too wrong. Shawn? >> > Yep, it works for me. > Sascha, Shawn, thanks for the response. Since device_initcall isn't platform specific, it seems I would still need a cpu_is_imx6q() func

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-19 Thread Shawn Guo
On Thu, Apr 19, 2012 at 08:43:08AM +0200, Sascha Hauer wrote: > > Sascha or Shawn, any further comments on my question? > Sorry for the late response, Rob. > I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific > hook at device_initcall time can't be too wrong. Shawn? > Yep, it

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-18 Thread Sascha Hauer
On Wed, Apr 18, 2012 at 11:18:55PM -0500, Rob Lee wrote: > >>> If I called imx_cpuidle_init directly from imx5 or imx6q init > >>> routines, it would be getting called before the coreinit_call of core > >>> cpuidle causing a failure.  There were various other directions to > >>> take and all seemed

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-18 Thread Rob Lee
>>> If I called imx_cpuidle_init directly from imx5 or imx6q init >>> routines, it would be getting called before the coreinit_call of core >>> cpuidle causing a failure.  There were various other directions to >>> take and all seemed less desirable than this one. >>> >>> One alternative would be t

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Rob Lee
>> >> +void __init imx_cpuidle_set_driver(struct cpuidle_driver *p) >> >> +{ >> >> +     drv = p; >> >> +} >> > >> > You like it complicated, eh? Why do you introduce a function which sets >> > a variable... >> > >> >> This complication is used to deal with the timing of various levels of >> init c

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Sascha Hauer
On Tue, Apr 17, 2012 at 08:54:03AM -0500, Rob Lee wrote: > On Tue, Apr 17, 2012 at 2:43 AM, Sascha Hauer wrote: > > On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote: > >> Add common cpuidle init functionality that can be used by various > >> imx platforms. > >> > >> Signed-off-by: Robert

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Rob Lee
On Tue, Apr 17, 2012 at 9:13 AM, Christian Robottom Reis wrote: > On Tue, Apr 17, 2012 at 08:54:03AM -0500, Rob Lee wrote: >> >> +void __init imx_cpuidle_set_driver(struct cpuidle_driver *p) >> >> +{ >> >> +     drv = p; >> >> +} >> > >> > You like it complicated, eh? Why do you introduce a functi

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Christian Robottom Reis
On Tue, Apr 17, 2012 at 08:54:03AM -0500, Rob Lee wrote: > >> +void __init imx_cpuidle_set_driver(struct cpuidle_driver *p) > >> +{ > >> +     drv = p; > >> +} > > > > You like it complicated, eh? Why do you introduce a function which sets > > a variable... > > This complication is used to deal wi

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Rob Lee
On Tue, Apr 17, 2012 at 2:43 AM, Sascha Hauer wrote: > On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote: >> Add common cpuidle init functionality that can be used by various >> imx platforms. >> >> Signed-off-by: Robert Lee >> --- >> diff --git a/arch/arm/plat-mxc/Makefile b/arch/arm/pl

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-17 Thread Sascha Hauer
On Mon, Apr 16, 2012 at 06:50:12PM -0500, Robert Lee wrote: > Add common cpuidle init functionality that can be used by various > imx platforms. > > Signed-off-by: Robert Lee > --- > diff --git a/arch/arm/plat-mxc/Makefile b/arch/arm/plat-mxc/Makefile > index e81290c..7c9e05f 100644 > --- a/arch/

Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

2012-04-16 Thread Jesper Juhl
On Mon, 16 Apr 2012, Robert Lee wrote: > Add common cpuidle init functionality that can be used by various > imx platforms. > > Signed-off-by: Robert Lee > --- > arch/arm/plat-mxc/Makefile |2 + > arch/arm/plat-mxc/cpuidle.c | 89 > +