On 30 October 2012 13:01, Viresh Kumar wrote:
> From: Viresh Kumar
> Date: Mon, 29 Oct 2012 22:19:14 +0530
> Subject: [PATCH] net: dsa/slave: Fix compilation warnings
>
Ping!!
>
> Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and
> CONFIG_NET_DSA_TAG_TRAILER is defin
On 10/30/2012 10:45 AM, Viresh Kumar wrote:
> On 30 October 2012 14:56, Daniel Lezcano wrote:
>> Well, it is the same here, no ? Except, it is up to the user to disable
>> the option.
>
> I didn't wanted to add code like this:
>
>>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>>> !NE
On 30 October 2012 14:56, Daniel Lezcano wrote:
> Well, it is the same here, no ? Except, it is up to the user to disable
> the option.
I didn't wanted to add code like this:
>> + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA &&
>> !NET_DSA_TAG_TRAILER)
Why should we select NET_DSA_TAG_DSA
On 10/30/2012 10:03 AM, Viresh Kumar wrote:
> On 30 October 2012 14:30, Daniel Lezcano wrote:
>> It is very curious if we disable all the configs option, a slave
>> creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA
>> enabled and none of the NET_DSA_TAG* enabled will raise a
On 30 October 2012 14:30, Daniel Lezcano wrote:
> It is very curious if we disable all the configs option, a slave
> creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA
> enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the
> probe function, right ?
>
> Maybe we
On 10/30/2012 08:55 AM, Viresh Kumar wrote:
> On 30 October 2012 13:23, Daniel Lezcano wrote:
>>> From: Viresh Kumar
>
>>> config NET_DSA_TAG_DSA
>>> - bool
>>> + bool "Original DSA packet tagging format"
>>> + select NET_DSt
>>
>> typo NET_DSA
>
> Unbelievable mistake :(
>
> Will
On 30 October 2012 13:23, Daniel Lezcano wrote:
>> From: Viresh Kumar
>> config NET_DSA_TAG_DSA
>> - bool
>> + bool "Original DSA packet tagging format"
>> + select NET_DSt
>
> typo NET_DSA
Unbelievable mistake :(
Will fix it after some reviews now :)
--
viresh
_
On 10/30/2012 08:31 AM, Viresh Kumar wrote:
> On 30 October 2012 12:15, Viresh Kumar wrote:
>> And so, if we select NET_DSA from these tagging drivers, then only slave.c
>> will
>> get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so
>> no warnings.
>
> If my above explan
On 30 October 2012 12:15, Viresh Kumar wrote:
> And so, if we select NET_DSA from these tagging drivers, then only slave.c
> will
> get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so
> no warnings.
If my above explanation/assumption is correct, then please review follow
On 30 October 2012 01:29, Ben Hutchings wrote:
> On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote:
>> Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and
>> CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings:
>>
>> net/dsa/slave.c:51:12: warnin
On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote:
> Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and
> CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings:
>
> net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used
> [-Wunused
11 matches
Mail list logo
