On Mon, 2012-10-29 at 22:27 +0530, Viresh Kumar wrote: > Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and > CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: > > net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used > [-Wunused-function] > net/dsa/slave.c:60:12: warning: 'dsa_slave_open' defined but not used > [-Wunused-function] > net/dsa/slave.c:98:12: warning: 'dsa_slave_close' defined but not used > [-Wunused-function] > net/dsa/slave.c:116:13: warning: 'dsa_slave_change_rx_flags' defined but not > used [-Wunused-function] > net/dsa/slave.c:127:13: warning: 'dsa_slave_set_rx_mode' defined but not used > [-Wunused-function] > net/dsa/slave.c:136:12: warning: 'dsa_slave_set_mac_address' defined but not > used [-Wunused-function] > net/dsa/slave.c:164:12: warning: 'dsa_slave_ioctl' defined but not used > [-Wunused-function] > > Fix them by enclosing these routines under #ifdef,endif. [...]
This is not a useful configuration. It might make more sense to make NET_DSA a hidden option and have the DSA drivers (in drivers/net/dsa) select it rather than depending on it. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
