Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 18:11, Viresh Kumar wrote: > On 25 October 2012 15:34, Viresh Kumar wrote: >> On 25 October 2012 15:26, Hongbo Zhang wrote: > > This is what your prcmu driver's routines are doing: > > int db8500_prcmu_config_hotmon(u8 low, u8 high) > { > ... > wait_for_completion(&mb4

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 17:42, Viresh Kumar wrote: > On 25 October 2012 15:03, Hongbo Zhang wrote: >> On 25 October 2012 16:41, Viresh Kumar wrote: > >> Just paste my current pieces of codes here: >> >> static struct db8500_thsens_platform_data* >> db8500_thermal_parse_dt(struct platf

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Viresh Kumar
On 25 October 2012 15:34, Viresh Kumar wrote: > On 25 October 2012 15:26, Hongbo Zhang wrote: This is what your prcmu driver's routines are doing: int db8500_prcmu_config_hotmon(u8 low, u8 high) { ... wait_for_completion(&mb4_transfer.work); ... return 0; } This is why others i

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Viresh Kumar
On 25 October 2012 15:26, Hongbo Zhang wrote: > Verish, see the codes in include/linux/interrupt.h: s/verish/viresh :) > static inline int __must_check > devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler, > unsigned long irqflags, const char *devname,

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 17:33, Hongbo Zhang wrote: > On 25 October 2012 16:41, Viresh Kumar wrote: >> On 25 October 2012 13:56, Hongbo Zhang wrote: >> >> While replying to mails, don't remove lines like above. They help >> identifying who >> wrote what. >> >>> [...] > +/* Callback to get temperat

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Viresh Kumar
On 25 October 2012 15:03, Hongbo Zhang wrote: > On 25 October 2012 16:41, Viresh Kumar wrote: > Just paste my current pieces of codes here: > > static struct db8500_thsens_platform_data* > db8500_thermal_parse_dt(struct platform_device *pdev) > { > if (!np) { >

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
On 25 October 2012 16:41, Viresh Kumar wrote: > On 25 October 2012 13:56, Hongbo Zhang wrote: > > While replying to mails, don't remove lines like above. They help > identifying who > wrote what. > >> [...] +/* Callback to get temperature changing trend */ +static int db8500_sys_get_tre

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Viresh Kumar
On 25 October 2012 13:56, Hongbo Zhang wrote: While replying to mails, don't remove lines like above. They help identifying who wrote what. > [...] >>> +/* Callback to get temperature changing trend */ >>> +static int db8500_sys_get_trend(struct thermal_zone_device *thermal, For example, you ca

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-25 Thread Hongbo Zhang
[...] >> +/* Callback to get temperature changing trend */ >> +static int db8500_sys_get_trend(struct thermal_zone_device *thermal, >> + int trip, enum thermal_trend *trend) >> +{ >> + struct db8500_thermal_zone *pzone = thermal->devdata; >> + >> + *trend = pzone->

Re: [PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-24 Thread Viresh Kumar
On 24 October 2012 17:28, hongbo.zhang wrote: > From: "hongbo.zhang" > > This diver is based on the thermal management framework in thermal_sys.c. A > thermal zone device is created with the trip points to which cooling devices > can be bound, the current cooling device is cpufreq, e.g. CPU frequ

[PATCH V2 5/6] Thermal: Add ST-Ericsson DB8500 thermal dirver.

2012-10-24 Thread hongbo.zhang
From: "hongbo.zhang" This diver is based on the thermal management framework in thermal_sys.c. A thermal zone device is created with the trip points to which cooling devices can be bound, the current cooling device is cpufreq, e.g. CPU frequency is clipped down to cool the CPU, and other cooling