From: Yong Shen
Add a simple postfix to 'status' and 'state' when displaying
regulator information, to emphasis that 'status' is about hardware
status while 'state' is a software concept.
Signed-off-by: Yong Shen
---
display.c |4 ++--
reg
From: Yong Shen
push 'S' key to switch to 'sorting' mode, all the clocks will be sorted
by their name.
Signed-off-by: Yong Shen
---
clocks.c | 140 +-
display.c| 16 ---
powerdebug.c | 25 +-
From: Yong Shen
everytime when screen refresh, the clock_info data stucture will
be reacclocated, which does not make sence. This patch addresses
this issue.
Signed-off-by: Yong Shen
---
clocks.c | 204 --
clocks.h |3
From: Yong Shen
Signed-off-by: Yong Shen
---
clocks.c | 56 +++-
1 files changed, 55 insertions(+), 1 deletions(-)
diff --git a/clocks.c b/clocks.c
index dc5c03b..25588f7 100644
--- a/clocks.c
+++ b/clocks.c
@@ -16,12 +16,18 @@
#include
The first two patches had been post long time before, so I did not add 'v2' to
them.
They includes some comments from Daniel Lezcano.
The last two patches are for working items defined for powerdebug.
___
linaro-dev mailing list
linaro-dev@lists.linaro
aro.org wrote:
>
>> From: Yong Shen
>>
>> everytime when screen refresh, the clock_info data stucture will
>> be reacclocated, which does not make sence. This patch addresses
>> this issue.
>>
>> Signed-off-by: Yong Shen
>>
>
> Hi Yong,
>
> I
On Tue, Apr 5, 2011 at 8:49 PM, Daniel Lezcano wrote:
> On 04/05/2011 10:28 AM, yong.s...@linaro.org wrote:
>
>> From: Yong Shen
>>
>> Signed-off-by: Yong Shen
>> ---
>> clocks.c | 54
>> +-
&g
From: Yong Shen
everytime when screen refresh, the clock_info data stucture will
be reacclocated, which does not make sence. This patch addresses
this issue.
Signed-off-by: Yong Shen
---
clocks.c | 198 +++--
clocks.h |3
From: Yong Shen
Signed-off-by: Yong Shen
---
clocks.c | 54 +-
powerdebug.c |3 +++
powerdebug.h |3 +++
3 files changed, 59 insertions(+), 1 deletions(-)
diff --git a/clocks.c b/clocks.c
index 47881c5..a4c54b0 100644
--- a
On Mon, Mar 28, 2011 at 4:56 PM, Daniel Lezcano wrote:
> On 03/28/2011 08:28 AM, Yong Shen wrote:
>
>> On Sun, Mar 27, 2011 at 5:06 AM, Daniel Lezcano> >wrote:
>>
>> By moving the functions in the right order in the file, we can get ride
>>> of their
On Sun, Mar 27, 2011 at 5:06 AM, Daniel Lezcano wrote:
> By moving the functions in the right order in the file, we can get ride
> of their definitions and we can set them static.
>
Technically, those function names in head files should be declarations, not
definitions.
For this patch, it could be
>
>
> Ok, I will send the patchset very soon.
>
> Yong, sorry that will probably make some conflicts with your changes. In
> the future, I will send smaller patchset, but more often :)
>
> That happens, never mind.
> Thanks
> -- Daniel
>
>
___
linaro-de
Hi Daniel,
Yes. I had started the work for several days.
Previously, every time when clock info is refreshed, the data structure will
be reallocated as if it is the first time of building up clock info. The
goal is only allocating memory once, which means less system call made by
malloc and also r
From: Yong Shen
add a inotify watch on clock tree, only when clock tree is changed,
the clock info structure is rebuild and screen will be refreshed.
Signed-off-by: Yong Shen
---
clocks.c | 51 +++
powerdebug.c |6 +-
powerdebug.h
This patch is for working item "Allocate the data structures only once instead
of at every refresh" at
https://blueprints.edge.launchpad.net/linaro-pm-wg/+spec/a-new-tool-to-display-arm-specific-info.
source code: http://git.linaro.org/gitweb?p=tools/powerdebug.git;a=summary
git tree: git://git.
Hi Sascha,
I noticed there were no comments for v3, but you had comments for v2 which
was posted after v3. See below:
>>I see. Maybe we should make this a platform driver then like for example
>>davinci does.
>I had sent out v3 patch before the your last comments.
>I noticed how davinci is doing
On Mon, Feb 21, 2011 at 6:31 PM, Pawel Moll wrote:
> Hello,
>
> > When I am trying to use ftrace to measure cpuidle latency, I find that
> > the timestamp is always ending with , like below.
> > -0 [000]79.53: cpu_idle: state=0 cpu_id=0
>
> What platform and kernel is it
Hi there,
When I am trying to use ftrace to measure cpuidle latency, I find that the
timestamp is always ending with , like below.
bash-2.05b# head trace
# tracer: nop
#
# TASK-PIDCPU#TIMESTAMP FUNCTION
# | | | | |
-0 [
, Sascha Hauer wrote:
> On Thu, Feb 17, 2011 at 09:18:11AM +0100, Yong Shen wrote:
> > >
> > >
> > > > + return 0;
> > > > +}
> > > > +
> > > > +late_initcall(imx_cpuidle_init);
> > >
> > > We have a late_initc
change log:
addressed some comments in previous cycle.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
From: Yong Shen
implement cpuidle driver for iMX5 SOCs, leave cpuidle params to board
related code.
Signed-off-by: Yong Shen
---
arch/arm/mach-mx5/Makefile |1 +
arch/arm/mach-mx5/cpuidle.c | 112 +++
arch/arm/mach-mx5/cpuidle.h | 25
From: Yong Shen
Add tzic_enable_wake in the head file, so other code can call it.
Signed-off-by: Yong Shen
---
arch/arm/plat-mxc/include/mach/mxc.h |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-mxc/include/mach/mxc.h
b/arch/arm/plat-mxc/include/mach
From: Yong Shen
This parameters are workable, but need further tuning.
Signed-off-by: Yong Shen
---
arch/arm/mach-mx5/board-mx51_babbage.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c
b/arch/arm/mach-mx5/board
>
>
> > + return 0;
> > +}
> > +
> > +late_initcall(imx_cpuidle_init);
>
> We have a late_initcall here which needs to be protected from other
> cpus. On the other hand we depend on board code calling
> imx_cpuidle_board_params() before this initcall. I think the board code
> should call a imx_
On Wed, Feb 16, 2011 at 10:13 AM, Sascha Hauer wrote:
> On Wed, Feb 16, 2011 at 09:37:47AM +0100, Yong Shen wrote:
> > Hi Sascha,
> >
> >
> > > > + local_irq_disable();
> > > > + do_gettimeofday(&before);
> > > >
Hi Sascha,
> > + local_irq_disable();
> > + do_gettimeofday(&before);
> > +
> > + plat_lpc = __raw_readl(MXC_CORTEXA8_PLAT_LPC) &
> > + ~(MXC_CORTEXA8_PLAT_LPC_DSM);
>
> One thing that strikes me here is the fact that this code can probably
> run on i.MX53 aswell, right? It's
Hi Sascha,
On Tue, Feb 15, 2011 at 7:27 PM, Sascha Hauer wrote:
> On Fri, Feb 11, 2011 at 10:36:12AM +0100, yong.s...@linaro.org wrote:
> > From: Yong Shen
> >
> > implement cpuidle driver for iMX5 SOCs, leave cpuidle params to board
> > related code.
>
From: Yong Shen
implement cpuidle driver for iMX5 SOCs, leave cpuidle params to board
related code.
Signed-off-by: Yong Shen
---
arch/arm/mach-mx5/Makefile |1 +
arch/arm/mach-mx5/cpuidle.c | 113 +++
arch/arm/mach-mx5/cpuidle.h | 26
From: Yong Shen
This parameters are workable, but need further tuning.
Signed-off-by: Yong Shen
---
arch/arm/mach-mx5/board-mx51_babbage.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c
b/arch/arm/mach-mx5/board
change log:
1. move code to arch/arm/mach-mx5/, since it is cpu-type specific
2. provide a interface for various board to register board-specific params.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/li
Hi Vishwanath,
Thanks. I will take it as a reference.
Yong
On Wed, Feb 9, 2011 at 11:52 AM, Vishwanath Sripathy <
vishwanath.sripa...@linaro.org> wrote:
> Yong,
>
> On Tue, Feb 8, 2011 at 9:21 PM, Yong Shen wrote:
> > Hi Arnaud,
> > I also took a while to thin
On Tue, Feb 8, 2011 at 6:50 PM, Rob Herring wrote:
> On 02/08/2011 09:51 AM, Yong Shen wrote:
>
>> Hi Arnaud,
>>
>> I also took a while to think about this before posting patches. I prefer
>> to put it in board related code since the various PMIC used on each
&
Patard wrote:
> yong.s...@linaro.org writes:
>
> Hi,
>
> > From: Yong Shen
> >
> > Add cpuidle parameters to make cpuidle driver workable, but these
> > parameters need further tuning
> >
> > Signed-off-by: Yong Shen
> >
From: Yong Shen
Add cpuidle parameters to make cpuidle driver workable, but these
parameters need further tuning
Signed-off-by: Yong Shen
---
arch/arm/mach-mx5/board-mx51_babbage.c | 114
arch/arm/mach-mx5/devices.c|4 +
arch/arm/mach-mx5
From: Yong Shen
implement cpu idle driver which allow different imx SOCs and boards
to register their own cpuidle parameters
Signed-off-by: Yong Shen
---
arch/arm/plat-mxc/Makefile |1 +
arch/arm/plat-mxc/cpuidle.c | 74 ++
arch/arm
Also to freescale list, since there is no such driver in freescale bsp so far.
Yong
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Hi there,
I am trying to implement cpuidle driver for imx51, and for better
understanding how various c-state map to ARM soc,
I would like to get some comments.
First of all, we basically have 3 major state for imx51, which are defined
in specification of the soc. Like:
RUN - Core is active, cloc
Hi Alex,
On Tue, Jan 25, 2011 at 11:22 AM, Alexander Sack wrote:
> try to use 0800 ... or +49 800 ...
>
it works now, thanks for the hints.
Yong
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-d
Hi Loic,
> Germany 800 589 0993
I test the one for Germany and it does not work for mobile phone. I
guess the number starting with 800 is only for landline. We should
provide numbers which also works for mobile phone, in case landline is
not available in some cases.
Yong
___
From: Yong Shen
Expose clock debug information to debugfs, which makes it easier for clock
system debug by using tools like powerdebug developed by Linaro power
management group.
For long term, this can go into common clock framework, but so far it depends
on the process of common clk API
change log:
Add more description in commit.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Hi Nico,
On Wed, Jan 19, 2011 at 2:39 AM, Nicolas Pitre wrote:
> OK. Will the debugfs format be identical and will this work identically
> from a user space point of view once this is based on top of the common
> clock API? If yes then I'm happy to merge it into the Linaro kernel
> tree.
Yes, th
Hi Amit and Nico,
> For the benefit of Nico, and linaro tree maintenance - what is the
> status of this patch in mainline?
Before posting the patch here, I tried to post it in mainline
mail-list, (linux-arm-ker...@lists.infradead.org). However, mx5's
maintainer prefer to wait until common clk stru
From: Yong Shen
Expose clock debug information to debugfs, which makes it easier for clock
system debug by using tools like powerdebug developed by Linaro power
management group.
For long term, this can go into common clock framework, but so far it depends
on the process of common clk struck
To utilize powerdebug tool developed by power management group of Linaro, we
need this patch in kernel to expose clock information.
Yong
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
On Tue, Jan 4, 2011 at 7:54 PM, Amit Kucheria wrote:
> On Tue, Jan 4, 2011 at 3:16 PM, Yong Shen wrote:
>
>>>> In the last several weeks, Jeremy and I reviewed the clock debug code
>>>> based on common clock struct. In this code, I used below code to
On Tue, Jan 4, 2011 at 5:45 PM, Vincent Guittot
wrote:
> On 4 January 2011 09:58, Amit Kucheria wrote:
>> CC'ing linaro-dev
>>
>> On Tue, Jan 4, 2011 at 1:18 PM, Yong Shen wrote:
>>> hi there,
>>>
>>> In last weekly meeting, we talked ab
Hi Amit,
Please find out inline feedback.
On Tue, Jan 4, 2011 at 4:58 PM, Amit Kucheria wrote:
> CC'ing linaro-dev
>
> On Tue, Jan 4, 2011 at 1:18 PM, Yong Shen wrote:
>> hi there,
>>
>> In last weekly meeting, we talked about the real time display of cl
hi Jeremy,
It's nice to be close :).
And it seems that many people in arm kernel list are also intested in
the clock debug information, maybe we can post next version to that
list and let them know how things are going.
On Thu, Dec 9, 2010 at 10:02 AM, Jeremy Kerr wrote:
> Hi Yong,
>
> We're get
anges from last round:
1. add memory free afte clock initialization
2. Move CLK_NAME_LEN into #ifdef.
Thanks
Yong
On Fri, Dec 3, 2010 at 5:06 PM, Amit Kucheria wrote:
> On Fri, Dec 3, 2010 at 1:30 PM, Yong Shen wrote
>> Hi Jeremy,
>>
>> This is latest one for review. I add
Hi Jeremy,
This is latest one for review. I add some minor changes in.
Cheers
Yong
>From efe7fa8bea67f9bf532c0074a92d938e6d6f4c5d Mon Sep 17 00:00:00 2001
From: Yong Shen
Date: Thu, 18 Nov 2010 14:54:49 +0800
Subject: [PATCH] export clock debug information to user space
create a tree-l
Hi,
please see inline feedback.
On Wed, Dec 1, 2010 at 7:25 PM, Mark Brown
wrote:
> On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote:
>
>> move some common functions and micros of mc13783 regulaor driver to
>> a seperate file, which makes it possible for mc1
On Wed, Dec 1, 2010 at 3:50 PM, Sascha Hauer wrote:
> Hi Yong,
>
> On Wed, Dec 01, 2010 at 03:15:55PM +0800, Yong Shen wrote:
>> Hi there,
>>
>> This is the v2 with some changes according to comments from v1. There
>> will be few patches coming out after this
rom 2b6c378c3c42d695f72f987e5e158faa2aac15d5 Mon Sep 17 00:00:00 2001
From: Yong Shen
Date: Thu, 18 Nov 2010 14:54:49 +0800
Subject: [PATCHv2] export clock debug information to user space
create a tree-like directory structure in debugfs so user space
tools like powerdebug can generate readable clock information.
m
On Wed, Nov 24, 2010 at 7:02 PM, Amit Kucheria wrote:
> On 10 Nov 24, Yong Shen wrote:
>> Hi there,
>>
>> In power management group, we have a working item of exposing thermal
>> information to user space through sysfs. However, so far, the thermal
>> sensor dri
Hi there,
In power management group, we have a working item of exposing thermal
information to user space through sysfs. However, so far, the thermal
sensor drivers under 'drivers/hwmon' expose their information in
various nodes under sysfs, which makes information collection
difficult.
Intel's th
Hi Jeremy,
Your suggestion is better in the architecture view and it is clean and neat,
on the other side, mine is only concerning about the minimal changing
of previous code.
I will try your way and give your feedback.
Yong
On Mon, Nov 22, 2010 at 10:46 AM, Jeremy Kerr wrote:
> Hi Yong,
>
> >
Hi Jeremy,
In that case, I keep both, but add a condition checking in clkdev_add. See
below:
>From b8e2babd1cc30ffc1ca5fe3cc6a542a18b0ec7fa Mon Sep 17 00:00:00 2001
From: Yong Shen
Date: Thu, 18 Nov 2010 14:54:49 +0800
Subject: [PATCH] export clock debug information to user space
create a t
Hi Jeremy,
> + help
> > + export clk debug information to user space
> > diff --git a/arch/arm/common/clkdev.c b/arch/arm/common/clkdev.c
> > index 9e4c4d9..5f4a309 100644
> > --- a/arch/arm/common/clkdev.c
> > +++ b/arch/arm/common/clkdev.c
>
> This is still arm-specific? Looks like you've move
>
>
>
> Is mutt going crazy or is the indentation here completely off?
>
> The same thing throughout the patch.
>
> It is the email client's problem, I will also put patch in attachment from
now on, for better looking.
Yong
___
linaro-dev mailing list
li
Hi Jeremy,
Great ideal to make it beyond ARM specific.
Below is the updated patch as per your comments.
>From 5a3e2d3bf577e3059c9254a61d671910ab170623 Mon Sep 17 00:00:00 2001
From: Yong Shen
Date: Tue, 16 Nov 2010 15:00:28 +0800
Subject: [PATCH] export clock debug information to user sp
gt; release.
>
> In the short-term, we still need all partner platforms to expose this debug
> information for our tools in a consistent way - OMAP already does it this
> way. So we want this patch applied to the Samsung platform after review
> and
> similar ones for other SoC kerne
Hi Amit,
We are trying to make this clock debug interface generic, so every platform
can benefit from it. Maybe it is better to wait for a while until the common
interface comes out.
Yong
On Tue, Nov 16, 2010 at 6:54 PM, wrote:
> From: Amit Daniel Kachhap
>
> This patch adds support for clock
|-- i2c2_clk.clk
|-- i2c1_clk.clk
|-- fec_clk.clk
|-- gpt_clk.clk
|-- uart3_clk.clk
|-- uart2_clk.clk
|-- uart1_clk.clk
Patch:
>From 7bb4a43abf0d36a322a61a055f7e7aef18d242ab Mon Sep 17 00:00:00 2001
From: Yong Shen
Date: Tue, 16 Nov 2010 15:00:28 +0800
Subject: [PATCH] export cl
Hi Jeremy,
Thanks a lot.
Yes, it's also nice to have a file containing all the clock information
which you have implemented in the email.
Since we expect more features like enable/disable clocks in the debugfs, we
also like to have tree-like debugfs for clock information.
Below is my draft impleme
Hi Jeremy,
It's nice to know that your clock update is coming soon. I would not waster
your time talking more in detail here now, since everything will be more
clear after your code comes out. Thanks again for sharing, and talk to you
later.
Yong
On Wed, Nov 10, 2010 at 4:31 PM, Jeremy Kerr wrot
>
>
> >
> > #define INIT_CLK(name, o) {
> \
> >.ops= &o,
> \
> >.enable_count = 0,
> \
> >.lock.mutex = __MUTEX_INITIALIZER(name.lock.mutex), \
> >.name
Hi Jeremy,
Thanks for comments.
Please see my further discussion.
>
> > 1. Create clock information based on common clock device, more specific,
> > based on struct clk_lookup. Since platform drivers are supposed to
> register
> > their clock
> > using 'void clkdev_add(struct clk_lookup *cl)', c
Hi Jeremy,
In power management group of linaro, we want to export debug information of
clock to user space and make a common interface to all the SOC platform.
Currently, each SOC platform has their own way to export clock information,
like freesale and TI, which is not ideal.
To do so, I need to
From: Yong Shen
Currently, only two operating points: 160Mhz and 800Mhz.
the operating points are tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |1
From: Yong Shen
Currently, only two operating points: 160Mhz and 800Mhz.
the operating points are tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |1
Oct 18, 2010 at 1:51 PM, wrote:
> >From: Yong Shen
>
> >the operating points are tested on babbage 3.0
> Commit log needs more description like
> What are the supported operating points,
> Is there any link between mpu OPP and other devices?
> What are the platforms this
>
>
>
> > +#include
> > +
> > +static struct cpu_op mx51_cpu_op[] = {
> > + {
> > + .cpu_rate = 16000,},
> > + {
> > + .cpu_rate = 8,},
> > +};
>
> Why did you remove the values between 800MHz and 160MHz? 400MHz and
> 200Mhz should work also, no?
>
> It proved that thos
>
>
> > > > > >
> > > > > > +struct cpu_wp *(*get_cpu_wp)(int *wp);
> > > > > > +
> > > > >
> > > > > This is not needed.
> > > > >
> > > > This is needed, otherwise it does not pass compile.
> > >
> > > This hunk is the only change to arch/arm/mach-mx5/cpu.c and get_cpu_wp
> > > is introduced with
Hi amit,
On Mon, Oct 18, 2010 at 6:02 PM, Amit Kucheria wrote:
> Yong,
>
> I get the following errors if I try to compile this with the Linaro
> toolchain.
>
> In file included from
>
> /home/amit/work/sources/linux-amit-upstream.git/arch/arm/plat-mxc/include/mach/hardware.h:63:0,
>
it works for me. try again.
Yong
On Tue, Oct 19, 2010 at 9:51 AM, Shawn Guo wrote:
> I used to access Linaro gitweb below all the time. But from
> yesterday, I found it stops working for me. Anyone else experienced
> the same problem, or it's just the problem on my end?
>
> http://git.linaro.
Hi Sascha,
On Mon, Oct 18, 2010 at 4:31 PM, Sascha Hauer wrote:
> Hi Yong,
>
> On Mon, Oct 18, 2010 at 01:43:43PM +0800, Yong Shen wrote:
> > Hi Sascha,
> >
> > Thanks for your thorough review. I have two feedbacks to your commends.
> > Sorry for delayed respons
From: Yong Shen
the operating points are tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |1 +
arch/arm/mach-mx5/board-mx51_babbage.c | 12
Hi Amit,
I agree about all the comments. New patch is coming.
Yong
On Wed, Oct 13, 2010 at 6:38 PM, Amit Kucheria wrote:
> Yong,
>
> Some more comments. But the patch is looking good now.
>
> On Fri, Oct 8, 2010 at 11:08 AM, wrote:
> > From: Yong Shen
> >
>
Hi Sascha,
Thanks for your thorough review. I have two feedbacks to your commends.
Sorry for delayed response, cause I had a hard time due to my computer crash
and data loss.
> diff --git a/arch/arm/mach-mx5/cpu.c b/arch/arm/mach-mx5/cpu.c
> > index 2d37785..83add9c 100644
> > --- a/arch/arm/mach
Yes, having a interface which can also control clocks is great. I used to
write some code myself to debug clocks, so I have the same feeling with what
you said.
BTW, 'cheers' is normally used in Australia and New Zealand. Are you from
there? Just curious. :)
Yong
On Sat, Oct 16, 2010 at 1:34 PM,
ion WG might have comments.
> >
> > On Tue, Oct 12, 2010 at 9:04 AM, Yong Shen wrote:
> >> Hi Amit and Jeremy,
> >>
> >> This is not a patch review. But patch may better present my idea.
> Basically,
> >> I want to add some code in common clock
c. Kernel consolidation WG might have comments.
> > >
> > > On Tue, Oct 12, 2010 at 9:04 AM, Yong Shen
> wrote:
> > > > Hi Amit and Jeremy,
> > > >
> > > > This is not a patch review. But patch may better present my idea.
> Basically,
>
Does anybody have more comments on [PATCHv2] ?
On Thu, Oct 7, 2010 at 8:00 PM, Yong Shen wrote:
>
> > Using wp_tbl is because that it also contains information like regulator
>> > voltage.
>>
>> The clock code does not handle the regulators, not even in the fsl
>
Hope this time I can cover all the comments. :)
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
From: Yong Shen
it is tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |1 +
arch/arm/mach-mx5/board-mx51_babbage.c | 12 ++-
arch/arm/mach-mx5
> > Using wp_tbl is because that it also contains information like regulator
> > voltage.
>
> The clock code does not handle the regulators, not even in the fsl
> kernel.
>
I did not mean to say clock code will handle regulators. I mean this table
also contains such information which may be needed
> > # Object file lists.
> > -obj-y := cpu.o mm.o clock-mx51.o devices.o
> > +obj-y := cpu.o mm.o clock-mx51.o devices.o cpu_wp-mx51.o
>
> By hardcoding cpu_wp-mx51 here, you are making the assumption that even if
> cpufreq is turned off, you'll still need the entire WP table to set the
> cpu
From: Yong Shen
it is tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |2 +-
arch/arm/mach-mx5/board-mx51_babbage.c | 10 ++-
arch/arm/mach-mx5
2nd review. Updated according to comments from Sascha and Arnd.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
> I still disagree, but it's not important. IMHO most of the uses of
> __raw_readl should be converted to readl or readl_relaxed if you are
> worried about efficiency.
>
> The main difference between __raw_readl and readl_relaxed is that the
> endianess is well-defined on readl_relaxed.
>
>
auer wrote:
> On Thu, Sep 30, 2010 at 01:48:17PM +0300, Amit Kucheria wrote:
> > Add'ed linaro-dev and linux-arm-kernel to CC.
> >
> > Thanks Yong, some feeback follows inline.
> >
> > On 10 Sep 29, Yong Shen wrote:
> > > From: Yong Shen
>
out and length, this is more efficient. Also this is
extensively used in arch/arm/.
Again, thanks for your time for review. I will send out updated patch.
Yong
On Tue, Oct 5, 2010 at 8:25 PM, Arnd Bergmann wrote:
> > From: Yong Shen
> >
> > it is tested on babbage 3.0
>
>
From: Yong Shen
it is tested on babbage 3.0
Signed-off-by: Yong Shen
---
arch/arm/Kconfig |6 +
arch/arm/mach-mx5/Kconfig |1 +
arch/arm/mach-mx5/Makefile |2 +-
arch/arm/mach-mx5/board-mx51_babbage.c |7 +-
arch/arm/mach-mx5
mx51 cpufreq driver, it passed test on mx51 babbage 3.0 board.
___
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
Hi Amit,
Please see my feedback embedded.
On Thu, Sep 30, 2010 at 6:48 PM, Amit Kucheria wrote:
> Add'ed linaro-dev and linux-arm-kernel to CC.
>
> Thanks Yong, some feeback follows inline.
>
> On 10 Sep 29, Yong Shen wrote:
> > From: Yong Shen
> &g
;
> > > + struct ata_port *ap = ata_shost_to_port(shost);
> > > + struct ahci_port_priv *pp;
> > > +
> > > + if (!ap || ata_port_is_dummy(ap))
> > > + return -EINVAL;
> > > +
> > > + pp = ap->private_data;
> &g
Hi there,
rtpm_status_show() is still there in the code. You found that I removed the
rtpm_status_show() in the patch because that after back port, there are two
rtpm_status_show() in the code. So I removed one of them to resolve the
conflict.
Please look at patched source code.
Yong
On Wed, Sep
From: Arjan van de Ven
PowerTOP wants to be able to show the user how effective the ALPM link
power management is for the user. ALPM is worth around 0.5W on a quiet
link; PowerTOP wants to be able to find cases where the "quiet link" isn't
actually quiet.
This patch adds state accounting functio
From: Arjan van de Ven
In order for PowerTOP to be able to report how well the new runtime PM is
working for the various drivers, the kernel needs to export some basic
statistics in sysfs.
This patch adds two sysfs files in the runtime PM domain that expose the
total time a device has been activ
1 - 100 of 113 matches
Mail list logo
